openstudio-standards 0.3.0 → 0.3.1.rc1

data/lib/openstudio-standards/standards/Standards.Model.rb

@@ -208,7 +208,7 @@ class Standard
       # Add daylighting controls for 90.1-2013 and prior
       # Remove daylighting control for 90.1-PRM-2019 and onward
       model.getSpaces.sort.each do |space|
-        space_set_baseline_daylighting_controls(space, false, false)
+        space_set_baseline_daylighting_controls(space, true, false)
       end
 
       OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.Model', '*** Applying Baseline Constructions ***')
@@ -455,66 +455,61 @@ class Standard
       if unmet_load_hours_check
         nb_adjustments = 0
         loop do
-          model_run_simulation_and_log_errors(model, "#{sizing_run_dir}/final#{degs}") == false
-          # If UMLH are greater than the threshold allowed by Appendix G,
-          # increase zone air flow and load as per the recommendation in
-          # the PRM-RM; Note that the PRM-RM only suggest to increase
-          # air zone air flow, but the zone sizing factor in EnergyPlus
-          # increase both air flow and load.
-          if model_get_unmet_load_hours(model) > 300
-            # Limit the number of zone sizing factor adjustment to 8
-            unless nb_adjustments < 8
-              OpenStudio.logFree(OpenStudio::Error, 'openstudio.standards.Model', "After 8 rounds of zone sizing factor adjustments the unmet load hours for the baseline model (#{degs} degree of rotation) still exceed 300 hours. Please open an issue on GitHub (https://github.com/NREL/openstudio-standards/issues) and share your user model with the developers.")
-              break
-            end
-            model.getThermalZones.each do |thermal_zone|
-              # Cooling adjustments
-              clg_umlh = thermal_zone_get_unmet_load_hours(thermal_zone, 'Cooling')
-              if clg_umlh > 50
-                # Get zone cooling sizing factor
-                if thermal_zone.sizingZone.zoneCoolingSizingFactor.is_initialized
-                  sizing_factor = thermal_zone.sizingZone.zoneCoolingSizingFactor.get
-                else
-                  sizing_factor = 1.0
-                end
+          # Loop break condition: Limit the number of zone sizing factor adjustment to 3
+          unless nb_adjustments < 3
+            OpenStudio.logFree(OpenStudio::Error, 'openstudio.standards.Model', "After 3 rounds of zone sizing factor adjustments the unmet load hours for the baseline model (#{degs} degree of rotation) still exceed 300 hours. Please open an issue on GitHub (https://github.com/NREL/openstudio-standards/issues) and share your user model with the developers.")
+            break
+          end
+          # Close the previous SQL session if open to prevent EnergyPlus from overloading the same session
+          sql = model.sqlFile.get
+          if sql.connectionOpen
+            sql.close
+          end
 
-                # Make adjustment to zone cooling sizing factor
-                # Do not adjust factors greater or equal to 2
-                if sizing_factor < 2.0
-                  if clg_umlh > 150
-                    sizing_factor *= 1.1
-                  elsif clg_umlh > 50
-                    sizing_factor *= 1.05
+          if model_run_simulation_and_log_errors(model, "#{sizing_run_dir}/final#{degs}")
+            # If UMLH are greater than the threshold allowed by Appendix G,
+            # increase zone air flow and load as per the recommendation in
+            # the PRM-RM; Note that the PRM-RM only suggest to increase
+            # air zone air flow, but the zone sizing factor in EnergyPlus
+            # increase both air flow and load.
+            if model_get_unmet_load_hours(model) > 300
+              model.getThermalZones.each do |thermal_zone|
+                # Cooling adjustments
+                clg_umlh = thermal_zone_get_unmet_load_hours(thermal_zone, 'Cooling')
+                if clg_umlh > 50
+                  sizing_factor = 1.0
+                  if thermal_zone.sizingZone.zoneCoolingSizingFactor.is_initialized
+                    sizing_factor = thermal_zone.sizingZone.zoneCoolingSizingFactor.get
                   end
+                  # Make adjustment to zone cooling sizing factor
+                  # Do not adjust factors greater or equal to 2
+                  clg_umlh > 150 ? sizing_factor = [2.0, sizing_factor * 1.1].min : sizing_factor = [2.0, sizing_factor * 1.05].min
                   thermal_zone.sizingZone.setZoneCoolingSizingFactor(sizing_factor)
                 end
-              end
 
-              # Heating adjustments
-              htg_umlh = thermal_zone_get_unmet_load_hours(thermal_zone, 'Heating')
-              if htg_umlh > 50
-                # Get zone cooling sizing factor
-                if thermal_zone.sizingZone.zoneHeatingSizingFactor.is_initialized
-                  sizing_factor = thermal_zone.sizingZone.zoneHeatingSizingFactor.get
-                else
+                # Heating adjustments
+                # Reset sizing factor
+                htg_umlh = thermal_zone_get_unmet_load_hours(thermal_zone, 'Heating')
+                if htg_umlh > 50
                   sizing_factor = 1.0
-                end
-
-                # Make adjustment to zone heating sizing factor
-                # Do not adjust factors greater or equal to 2
-                if sizing_factor < 2.0
-                  if htg_umlh > 150
-                    sizing_factor *= 1.1
-                  elsif htg_umlh > 50
-                    sizing_factor *= 1.05
+                  if thermal_zone.sizingZone.zoneHeatingSizingFactor.is_initialized
+                    # Get zone heating sizing factor
+                    sizing_factor = thermal_zone.sizingZone.zoneHeatingSizingFactor.get
                   end
+
+                  # Make adjustment to zone heating sizing factor
+                  # Do not adjust factors greater or equal to 2
+                  htg_umlh > 150 ? sizing_factor = [2.0, sizing_factor * 1.1].min : sizing_factor = [2.0, sizing_factor * 1.05].min
                   thermal_zone.sizingZone.setZoneHeatingSizingFactor(sizing_factor)
                 end
               end
             end
           else
-            break
+            # simulation failure, raise the exception.
+            # OpenStudio.logFree(OpenStudio::Error, 'openstudio.model.Model', 'OpenStudio simulation failed.')
+            raise('OpenStudio simulation failed.')
           end
+          nb_adjustments += 1
         end
       end
     end
@@ -2265,8 +2260,9 @@ class Standard
   # @param climate_zone [String] ASHRAE climate zone, e.g. 'ASHRAE 169-2013-4A'
   # @param apply_controls [Bool] toggle whether to apply air loop and plant loop controls
   # @param sql_db_vars_map [Hash] hash map
+  # @param necb_ref_hp [Bool] for compatability with NECB ruleset only.
   # @return [Bool] returns true if successful, false if not
-  def model_apply_hvac_efficiency_standard(model, climate_zone, apply_controls: true, sql_db_vars_map: nil)
+  def model_apply_hvac_efficiency_standard(model, climate_zone, apply_controls: true, sql_db_vars_map: nil, necb_ref_hp: false)
     sql_db_vars_map = {} if sql_db_vars_map.nil?
 
     OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.Model', "Started applying HVAC efficiency standards for #{template} template.")
@@ -2302,11 +2298,11 @@ class Standard
     # set DX HP coils before DX clg coils because when DX HP coils need to first
     # pull the capacities of their paired DX clg coils, and this does not work
     # correctly if the DX clg coil efficiencies have been set because they are renamed.
-    model.getCoilHeatingDXSingleSpeeds.sort.each { |obj| sql_db_vars_map = coil_heating_dx_single_speed_apply_efficiency_and_curves(obj, sql_db_vars_map) }
+    model.getCoilHeatingDXSingleSpeeds.sort.each { |obj| sql_db_vars_map = coil_heating_dx_single_speed_apply_efficiency_and_curves(obj, sql_db_vars_map, necb_ref_hp) }
 
     # Unitary ACs
     model.getCoilCoolingDXTwoSpeeds.sort.each { |obj| sql_db_vars_map = coil_cooling_dx_two_speed_apply_efficiency_and_curves(obj, sql_db_vars_map) }
-    model.getCoilCoolingDXSingleSpeeds.sort.each { |obj| sql_db_vars_map = coil_cooling_dx_single_speed_apply_efficiency_and_curves(obj, sql_db_vars_map) }
+    model.getCoilCoolingDXSingleSpeeds.sort.each { |obj| sql_db_vars_map = coil_cooling_dx_single_speed_apply_efficiency_and_curves(obj, sql_db_vars_map, necb_ref_hp) }
     model.getCoilCoolingDXMultiSpeeds.sort.each { |obj| sql_db_vars_map = coil_cooling_dx_multi_speed_apply_efficiency_and_curves(obj, sql_db_vars_map) }
 
     # WSHPs
@@ -2355,7 +2351,7 @@ class Standard
 
     # Add daylighting controls to each space
     model.getSpaces.sort.each do |space|
-      added = space_add_daylighting_controls(space, false, false)
+      added = space_add_daylighting_controls(space, true, false)
     end
 
     OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.Model', 'Finished adding daylighting controls.')
@@ -3587,6 +3583,7 @@ class Standard
     existing_curves += model.getCurveQuadratics
     existing_curves += model.getCurveBicubics
     existing_curves += model.getCurveBiquadratics
+    existing_curves += model.getCurveQuadLinears
     existing_curves.sort.each do |curve|
       if curve.name.get.to_s == curve_name
         OpenStudio.logFree(OpenStudio::Debug, 'openstudio.standards.Model', "Already added curve: #{curve_name}")
@@ -3687,6 +3684,25 @@ class Standard
         curve.setMinimumCurveOutput(data['minimum_dependent_variable_output']) if data['minimum_dependent_variable_output']
         curve.setMaximumCurveOutput(data['maximum_dependent_variable_output']) if data['maximum_dependent_variable_output']
         return curve
+      when 'QuadLinear'
+        curve = OpenStudio::Model::CurveQuadLinear.new(model)
+        curve.setName(data['name'])
+        curve.setCoefficient1Constant(data['coeff_1'])
+        curve.setCoefficient2w(data['coeff_2'])
+        curve.setCoefficient3x(data['coeff_3'])
+        curve.setCoefficient4y(data['coeff_4'])
+        curve.setCoefficient5z(data['coeff_5'])
+        curve.setMinimumValueofw(data['minimum_independent_variable_w'])
+        curve.setMaximumValueofw(data['maximum_independent_variable_w'])
+        curve.setMinimumValueofx(data['minimum_independent_variable_x'])
+        curve.setMaximumValueofx(data['maximum_independent_variable_x'])
+        curve.setMinimumValueofy(data['minimum_independent_variable_y'])
+        curve.setMaximumValueofy(data['maximum_independent_variable_y'])
+        curve.setMinimumValueofz(data['minimum_independent_variable_z'])
+        curve.setMaximumValueofz(data['maximum_independent_variable_z'])
+        curve.setMinimumCurveOutput(data['minimum_dependent_variable_output'])
+        curve.setMaximumCurveOutput(data['maximum_dependent_variable_output'])
+        return curve
       when 'MultiVariableLookupTable'
         num_ind_var = data['number_independent_variables'].to_i
         table = OpenStudio::Model::TableMultiVariableLookup.new(model, num_ind_var)

data/lib/openstudio-standards/standards/Standards.PlantLoop.rb

@@ -945,11 +945,11 @@ class Standard
     final_boilers = [first_boiler, second_boiler]
     OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.PlantLoop', "For #{plant_loop.name}, added a second boiler.")
 
-    # Set the sizing factor for all boilers evenly and Rename the boilers
+    # Rename boilers and set the sizing factor
     sizing_factor = (1.0 / final_boilers.size).round(2)
     final_boilers.each_with_index do |boiler, i|
+      boiler.setName("#{plant_loop.name} Boiler #{i + 1} of #{final_boilers.size}")
       boiler.setSizingFactor(sizing_factor)
-      boiler.setName("#{first_boiler.name} #{i + 1} of #{final_boilers.size}")
     end
 
     # Set the equipment to stage sequentially

data/lib/openstudio-standards/standards/Standards.Space.rb

@@ -835,12 +835,22 @@ class Standard
   def space_add_daylighting_controls(space, remove_existing_controls, draw_daylight_areas_for_debugging = false)
     OpenStudio.logFree(OpenStudio::Debug, 'openstudio.standards.Space', "******For #{space.name}, adding daylight controls.")
 
+    # Get the space thermal zone
+    zone = space.thermalZone
+    if zone.empty?
+      OpenStudio.logFree(OpenStudio::Error, 'openstudio.standards.Space', "Space #{space.name} has no thermal zone; cannot set daylighting controls for zone.")
+    else
+      zone = zone.get
+    end
+
     # Check for existing daylighting controls
     # and remove if specified in the input
     existing_daylighting_controls = space.daylightingControls
     unless existing_daylighting_controls.empty?
       if remove_existing_controls
         space_remove_daylighting_controls(space)
+        zone.resetFractionofZoneControlledbyPrimaryDaylightingControl
+        zone.resetFractionofZoneControlledbySecondaryDaylightingControl
       else
         OpenStudio.logFree(OpenStudio::Info, 'openstudio.standards.Space', "For #{space.name}, daylight controls were already present, no additional controls added.")
         return false
@@ -1037,14 +1047,6 @@ class Standard
       end
     end
 
-    # Get the zone that the space is in
-    zone = space.thermalZone
-    if zone.empty?
-      OpenStudio.logFree(OpenStudio::Error, 'openstudio.standards.Space', "Space #{space.name} has no thermal zone")
-    else
-      zone = zone.get
-    end
-
     # Sort by priority; first by facade, then by area,
     # then by name to ensure deterministic in case identical in other ways
     sorted_windows = windows.sort_by { |_window, vals| [vals[:facade], vals[:area], vals[:name]] }
@@ -1079,16 +1081,6 @@ class Standard
       sensor_2_frac *= ssa_nongeo_frac unless ssa_nongeo_frac.nil?
     end
 
-    # Place the sensors and set control fractions
-    # get the zone that the space is in
-    zone = space.thermalZone
-    if zone.empty?
-      OpenStudio.logFree(OpenStudio::Error, 'openstudio.standards.Space', "Space #{space.name}, cannot determine daylighted areas.")
-      return false
-    else
-      zone = space.thermalZone.get
-    end
-
     # Ensure that total controlled fraction
     # is never set above 1 (100%)
     sensor_1_frac = sensor_1_frac.round(3)
@@ -1149,6 +1141,9 @@ class Standard
 
       # @todo rotate sensor to face window (only needed for glare calcs)
       zone.setPrimaryDaylightingControl(sensor_1)
+      if zone.fractionofZoneControlledbyPrimaryDaylightingControl + sensor_1_frac > 1
+        zone.resetFractionofZoneControlledbySecondaryDaylightingControl
+      end
       zone.setFractionofZoneControlledbyPrimaryDaylightingControl(sensor_1_frac)
     end
 
@@ -1191,6 +1186,9 @@ class Standard
 
       # @todo rotate sensor to face window (only needed for glare calcs)
       zone.setSecondaryDaylightingControl(sensor_2)
+      if zone.fractionofZoneControlledbySecondaryDaylightingControl + sensor_2_frac > 1
+        zone.resetFractionofZoneControlledbyPrimaryDaylightingControl
+      end
       zone.setFractionofZoneControlledbySecondaryDaylightingControl(sensor_2_frac)
     end