openstudio-standards 0.2.15 → 0.2.16.rc1

data/lib/openstudio-standards/btap/btap_result.rb

@@ -20,8 +20,8 @@ module BTAP
         " AND ReportForString='Entire Facility' AND TableName='Annual and Peak Values - Electricity' AND RowName='Electricity:Facility'" +
         " AND ColumnName='Electricity Maximum Value' AND Units='W'")
     natural_gas_peak = model.sqlFile().get().execAndReturnFirstDouble("SELECT Value FROM tabulardatawithstrings WHERE ReportName='EnergyMeters'" +
-        " AND ReportForString='Entire Facility' AND TableName='Annual and Peak Values - Gas' AND RowName='Gas:Facility'" +
-        " AND ColumnName='Gas Maximum Value' AND Units='W'")
+        " AND ReportForString='Entire Facility' AND TableName='Annual and Peak Values - Natural Gas' AND RowName='NaturalGas:Facility'" +
+        " AND ColumnName='Natural Gas Maximum Value' AND Units='W'")
 
     # Create hash to store all the collected data. 
     qaqc = {}

data/lib/openstudio-standards/btap/reporting.rb

@@ -215,8 +215,8 @@ module BTAP
       end
 
       natural_gas_peak = model.sqlFile().get().execAndReturnFirstDouble("SELECT Value FROM tabulardatawithstrings WHERE ReportName='EnergyMeters'" +
-          " AND ReportForString='Entire Facility' AND TableName='Annual and Peak Values - Gas' AND RowName='Gas:Facility'" +
-          " AND ColumnName='Gas Maximum Value' AND Units='W'")
+          " AND ReportForString='Entire Facility' AND TableName='Annual and Peak Values - Natural Gas' AND RowName='NaturalGas:Facility'" +
+          " AND ColumnName='Natural Gas Maximum Value' AND Units='W'")
       if natural_gas_peak.empty?
         natural_gas_peak = 0.0
       end

data/lib/openstudio-standards/btap/simmanager.rb

@@ -472,8 +472,8 @@ module BTAP
         end
 
         natural_gas_peak = model.sqlFile().get().execAndReturnFirstDouble("SELECT Value FROM tabulardatawithstrings WHERE ReportName='EnergyMeters'" +
-            " AND ReportForString='Entire Facility' AND TableName='Annual and Peak Values - Gas' AND RowName='Gas:Facility'" +
-            " AND ColumnName='Gas Maximum Value' AND Units='W'")
+            " AND ReportForString='Entire Facility' AND TableName='Annual and Peak Values - Natural Gas' AND RowName='NaturalGas:Facility'" +
+            " AND ColumnName='Natural Gas Maximum Value' AND Units='W'")
         if natural_gas_peak.empty?
           natural_gas_peak = 0.0
         end

data/lib/openstudio-standards/hvac_sizing/Siz.ControllerOutdoorAir.rb

@@ -54,60 +54,6 @@ class OpenStudio::Model::ControllerOutdoorAir
     end
     air_loop = oa_sys.airLoop.get
 
-    # Determine if the system is multizone
-    multizone = false
-    if air_loop.thermalZones.size > 1
-      multizone = true
-    end
-
-    # Determine if the system is variable volume
-    vav = false
-    air_loop.supplyComponents.reverse.each do |comp|
-      if comp.to_FanVariableVolume.is_initialized
-        vav = true
-      elsif comp.to_AirLoopHVACUnitaryHeatCoolVAVChangeoverBypass.is_initialized
-        fan = comp.to_AirLoopHVACUnitaryHeatCoolVAVChangeoverBypass.get.supplyAirFan
-        if fan.to_FanVariableVolume.is_initialized
-          vav = true
-        end
-      elsif comp.to_AirLoopHVACUnitarySystem.is_initialized
-        fan = comp.to_AirLoopHVACUnitarySystem.get.supplyFan
-        if fan.is_initialized
-          if fan.get.to_FanVariableVolume.is_initialized
-            vav = true
-          end
-        end
-      end
-    end
-    
-    # If it is a multizone VAV system, get the system multiplier
-    # to work around the bug in EnergyPlus.
-    if multizone && vav
-      if oa.is_initialized
-        oa_val = oa.get
-        
-        # Get the system multiplier
-        mult = 1
-
-        # Get all the zone multipliers
-        zn_mults = []
-        air_loop.thermalZones.each do |zone|
-          zn_mults << zone.multiplier
-        end
-     
-        # Warn if there are different multipliers
-        uniq_mults = zn_mults.uniq
-        if uniq_mults.size > 1
-          OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.AirLoopHVAC', "For #{air_loop.name}: not all zones on the system have an identical zone multiplier.  Multipliers are: #{uniq_mults.join(', ')}.")
-        else
-          mult = uniq_mults[0]
-        end
-
-        oa_val = oa_val * mult
-        oa = OpenStudio::OptionalDouble.new(oa_val)
-      end
-    end
-
     return oa
   end
 end

data/lib/openstudio-standards/hvac_sizing/Siz.HeatingCoolingFuels.rb

@@ -263,6 +263,11 @@ class OpenStudio::Model::Model
       # Get the object type
       obj_type = equipment.iddObjectType.valueName.to_s
       case obj_type
+      when 'OS_AirLooHVAC_UnitarySystem'
+        equipment = equipment.to_AirLoopHVACUnitarySystem.get
+        if equipment.heatingCoil.is_initialized
+          fuels += self.coil_heating_fuels(equipment.heatingCoil.get)
+        end
       when 'OS_AirTerminal_SingleDuct_ConstantVolume_FourPipeInduction'
         equipment = equipment.to_AirTerminalSingleDuctConstantVolumeFourPipeInduction.get
         fuels += self.coil_heating_fuels(equipment.heatingCoil)
@@ -350,7 +355,12 @@ class OpenStudio::Model::Model
     zone.equipment.each do |equipment|
       # Get the object type
       obj_type = equipment.iddObjectType.valueName.to_s
-      case obj_type    
+      case obj_type
+      when 'OS_AirLoopHVAC_UnitarySystem'
+        equipment = equipment.to_AirLoopHVACUnitarySystem.get
+        if equipment.coolingCoil.is_initialized
+          fuels += self.coil_cooling_fuels(equipment.coolingCoil.get)
+        end
       when 'OS_AirTerminal_SingleDuct_ConstantVolume_CooledBeam'
         equipment = equipment.to_AirTerminalSingleDuctConstantVolumeCooledBeam.get
         fuels += self.coil_cooling_fuels(equipment.coilCoolingCooledBeam)

data/lib/openstudio-standards/hvac_sizing/Siz.Model.rb

@@ -281,7 +281,7 @@ class OpenStudio::Model::Model
 
     result = OpenStudio::OptionalDouble.new
 
-    name = object.name.get.upcase
+    name = object.name.get.upcase.strip
 
     object_type = object.iddObject.type.valueDescription.gsub('OS:','')
 

data/lib/openstudio-standards/prototypes/common/buildings/Prototype.College.rb

@@ -9,6 +9,27 @@ module College
   # @param prototype_input [Hash] hash of prototype inputs
   # @return [Bool] returns true if successful, false if not
   def model_custom_hvac_tweaks(model, building_type, climate_zone, prototype_input)
+    OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.Model', 'Started building type specific adjustments')
+
+    model.getSpaces.each do |space|
+      if space.name.get.to_s == 'CB_PUBLIC_ELEVATORS_F1'
+        model_add_elevator(model,
+                           space,
+                           prototype_input['number_of_elevators'],
+                           prototype_input['elevator_type'],
+                           prototype_input['elevator_schedule'],
+                           prototype_input['elevator_fan_schedule'],
+                           prototype_input['elevator_fan_schedule'],
+                           building_type)
+      end
+    end
+
+    OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.Model', 'Finished building type specific adjustments')
+
+    # add extra infiltration for entry door
+    add_door_infiltration(climate_zone, model)
+    OpenStudio.logFree(OpenStudio::Info, 'openstudio.model.Model', 'Added door infiltration')
+  
     return true
   end
 
@@ -25,7 +46,7 @@ module College
     infiltration_entrydoor.setName('entry door Infiltration')
     infiltration_per_zone_entrydoor = 0
     if template == '90.1-2004'
-      infiltration_per_zone_entrydoor = 7.678585
+      infiltration_per_zone_entrydoor = 4.566024
       infiltration_entrydoor.setSchedule(model_add_schedule(model, 'College INFIL_Door_Opening_SCH'))
     elsif template == '90.1-2007'
       case climate_zone
@@ -35,10 +56,10 @@ module College
         'ASHRAE 169-2006-4A',
         'ASHRAE 169-2006-4B',
         'ASHRAE 169-2006-4C'
-        infiltration_per_zone_entrydoor = 5.600600
+        infiltration_per_zone_entrydoor = 3.204085
         infiltration_entrydoor.setSchedule(model_add_schedule(model, 'College INFIL_Door_Opening_SCH'))
       else
-        infiltration_per_zone_entrydoor = 7.678585
+        infiltration_per_zone_entrydoor = 4.566024
         infiltration_entrydoor.setSchedule(model_add_schedule(model, 'College INFIL_Door_Opening_SCH'))
       end
     elsif template == '90.1-2010' || template == '90.1-2013'
@@ -46,10 +67,10 @@ module College
       when 'ASHRAE 169-2006-3A',
         'ASHRAE 169-2006-3B',
         'ASHRAE 169-2006-3C'
-        infiltration_per_zone_entrydoor = 5.600600
+        infiltration_per_zone_entrydoor = 3.204085
         infiltration_entrydoor.setSchedule(model_add_schedule(model, 'College INFIL_Door_Opening_SCH'))
       else
-        infiltration_per_zone_entrydoor = 7.678585
+        infiltration_per_zone_entrydoor = 4.566024
         infiltration_entrydoor.setSchedule(model_add_schedule(model, 'College INFIL_Door_Opening_SCH'))
       end
     end

data/lib/openstudio-standards/prototypes/common/objects/Prototype.CoilCoolingWaterToAirHeatPumpEquationFit.rb

@@ -44,22 +44,41 @@ class Standard
     if type == 'OS default'
       # use OS default curves
     else # default curve set
-      clg_coil.setTotalCoolingCapacityCoefficient1(-4.30266987344639)
-      clg_coil.setTotalCoolingCapacityCoefficient2(7.18536990534372)
-      clg_coil.setTotalCoolingCapacityCoefficient3(-2.23946714486189)
-      clg_coil.setTotalCoolingCapacityCoefficient4(0.139995928440879)
-      clg_coil.setTotalCoolingCapacityCoefficient5(0.102660179888915)
-      clg_coil.setSensibleCoolingCapacityCoefficient1(6.0019444814887)
-      clg_coil.setSensibleCoolingCapacityCoefficient2(22.6300677244073)
-      clg_coil.setSensibleCoolingCapacityCoefficient3(-26.7960783730934)
-      clg_coil.setSensibleCoolingCapacityCoefficient4(-1.72374720346819)
-      clg_coil.setSensibleCoolingCapacityCoefficient5(0.490644802367817)
-      clg_coil.setSensibleCoolingCapacityCoefficient6(0.0693119353468141)
-      clg_coil.setCoolingPowerConsumptionCoefficient1(-5.67775976415698)
-      clg_coil.setCoolingPowerConsumptionCoefficient2(0.438988156976704)
-      clg_coil.setCoolingPowerConsumptionCoefficient3(5.845277342193)
-      clg_coil.setCoolingPowerConsumptionCoefficient4(0.141605667000125)
-      clg_coil.setCoolingPowerConsumptionCoefficient5(-0.168727936032429)
+      if model.version < OpenStudio::VersionString.new('3.2.0')
+        clg_coil.setTotalCoolingCapacityCoefficient1(-4.30266987344639)
+        clg_coil.setTotalCoolingCapacityCoefficient2(7.18536990534372)
+        clg_coil.setTotalCoolingCapacityCoefficient3(-2.23946714486189)
+        clg_coil.setTotalCoolingCapacityCoefficient4(0.139995928440879)
+        clg_coil.setTotalCoolingCapacityCoefficient5(0.102660179888915)
+        clg_coil.setSensibleCoolingCapacityCoefficient1(6.0019444814887)
+        clg_coil.setSensibleCoolingCapacityCoefficient2(22.6300677244073)
+        clg_coil.setSensibleCoolingCapacityCoefficient3(-26.7960783730934)
+        clg_coil.setSensibleCoolingCapacityCoefficient4(-1.72374720346819)
+        clg_coil.setSensibleCoolingCapacityCoefficient5(0.490644802367817)
+        clg_coil.setSensibleCoolingCapacityCoefficient6(0.0693119353468141)
+        clg_coil.setCoolingPowerConsumptionCoefficient1(-5.67775976415698)
+        clg_coil.setCoolingPowerConsumptionCoefficient2(0.438988156976704)
+        clg_coil.setCoolingPowerConsumptionCoefficient3(5.845277342193)
+        clg_coil.setCoolingPowerConsumptionCoefficient4(0.141605667000125)
+        clg_coil.setCoolingPowerConsumptionCoefficient5(-0.168727936032429)
+      else
+        clg_coil.totalCoolingCapacityCurve.setCoefficient1Constant(-4.30266987344639)
+        clg_coil.totalCoolingCapacityCurve.setCoefficient2w(7.18536990534372)
+        clg_coil.totalCoolingCapacityCurve.setCoefficient3x(-2.23946714486189)
+        clg_coil.totalCoolingCapacityCurve.setCoefficient4y(0.139995928440879)
+        clg_coil.totalCoolingCapacityCurve.setCoefficient5z(0.102660179888915)
+        clg_coil.sensibleCoolingCapacityCurve.setCoefficient1Constant(6.0019444814887)
+        clg_coil.sensibleCoolingCapacityCurve.setCoefficient2v(22.6300677244073)
+        clg_coil.sensibleCoolingCapacityCurve.setCoefficient3w(-26.7960783730934)
+        clg_coil.sensibleCoolingCapacityCurve.setCoefficient4x(-1.72374720346819)
+        clg_coil.sensibleCoolingCapacityCurve.setCoefficient5y(0.490644802367817)
+        clg_coil.sensibleCoolingCapacityCurve.setCoefficient6z(0.0693119353468141)
+        clg_coil.coolingPowerConsumptionCurve.setCoefficient1Constant(-5.67775976415698)
+        clg_coil.coolingPowerConsumptionCurve.setCoefficient2w(0.438988156976704)
+        clg_coil.coolingPowerConsumptionCurve.setCoefficient3x(5.845277342193)
+        clg_coil.coolingPowerConsumptionCurve.setCoefficient4y(0.141605667000125)
+        clg_coil.coolingPowerConsumptionCurve.setCoefficient5z(-0.168727936032429)
+      end
     end
 
     return clg_coil

data/lib/openstudio-standards/prototypes/common/objects/Prototype.CoilHeatingWaterToAirHeatPumpEquationFit.rb

@@ -44,16 +44,29 @@ class Standard
     if type == 'OS default'
       # use OS default curves
     else # default curve set
-      htg_coil.setHeatingCapacityCoefficient1(0.237847462869254)
-      htg_coil.setHeatingCapacityCoefficient2(-3.35823796081626)
-      htg_coil.setHeatingCapacityCoefficient3(3.80640467406376)
-      htg_coil.setHeatingCapacityCoefficient4(0.179200417311554)
-      htg_coil.setHeatingCapacityCoefficient5(0.12860719846082)
-      htg_coil.setHeatingPowerConsumptionCoefficient1(-3.79175529243238)
-      htg_coil.setHeatingPowerConsumptionCoefficient2(3.38799239505527)
-      htg_coil.setHeatingPowerConsumptionCoefficient3(1.5022612076303)
-      htg_coil.setHeatingPowerConsumptionCoefficient4(-0.177653510577989)
-      htg_coil.setHeatingPowerConsumptionCoefficient5(-0.103079864171839)
+      if model.version < OpenStudio::VersionString.new('3.2.0')
+        htg_coil.setHeatingCapacityCoefficient1(0.237847462869254)
+        htg_coil.setHeatingCapacityCoefficient2(-3.35823796081626)
+        htg_coil.setHeatingCapacityCoefficient3(3.80640467406376)
+        htg_coil.setHeatingCapacityCoefficient4(0.179200417311554)
+        htg_coil.setHeatingCapacityCoefficient5(0.12860719846082)
+        htg_coil.setHeatingPowerConsumptionCoefficient1(-3.79175529243238)
+        htg_coil.setHeatingPowerConsumptionCoefficient2(3.38799239505527)
+        htg_coil.setHeatingPowerConsumptionCoefficient3(1.5022612076303)
+        htg_coil.setHeatingPowerConsumptionCoefficient4(-0.177653510577989)
+        htg_coil.setHeatingPowerConsumptionCoefficient5(-0.103079864171839)
+      else
+        htg_coil.heatingCapacityCurve.setCoefficient1Constant(0.237847462869254)
+        htg_coil.heatingCapacityCurve.setCoefficient2w(-3.35823796081626)
+        htg_coil.heatingCapacityCurve.setCoefficient3x(3.80640467406376)
+        htg_coil.heatingCapacityCurve.setCoefficient4y(0.179200417311554)
+        htg_coil.heatingCapacityCurve.setCoefficient5z(0.12860719846082)
+        htg_coil.heatingPowerConsumptionCurve.setCoefficient1Constant(-3.79175529243238)
+        htg_coil.heatingPowerConsumptionCurve.setCoefficient2w(3.38799239505527)
+        htg_coil.heatingPowerConsumptionCurve.setCoefficient3x(1.5022612076303)
+        htg_coil.heatingPowerConsumptionCurve.setCoefficient4y(-0.177653510577989)
+        htg_coil.heatingPowerConsumptionCurve.setCoefficient5z(-0.103079864171839)
+      end
     end
 
     return htg_coil

data/lib/openstudio-standards/prototypes/common/objects/Prototype.Model.rb

@@ -2692,6 +2692,42 @@ Standard.class_eval do
     return true
   end
 
+  # Calculate a model's window or WWR
+  # Disregard space conditioning (assume all spaces are conditioned)
+  # which is true for most of not all prototypes
+  #
+  # @param model [OpenStudio::Model::Model] OpenStudio model object
+  # @param wwr [Boolean]
+  # @return [Numeric] Returns window to wall ratio (percentage) or window area.
+  def model_get_window_area_info(model, wwr = true)
+
+    window_area = 0
+    wall_area = 0
+
+    model.getSpaces.each do |space|
+      # Get zone multipler
+      multiplier = space.thermalZone.get.multiplier
+      space.surfaces.each do |surface|
+        next if surface.surfaceType != 'Wall'
+        next if surface.outsideBoundaryCondition != 'Outdoors'
+
+        # Get wall and window area
+        wall_area += surface.grossArea * multiplier
+        surface.subSurfaces.each do |subsurface|
+          subsurface_type = subsurface.subSurfaceType.to_s.downcase
+          # Do not count doors
+          next unless (subsurface_type.include? 'window') || (subsurface_type.include? 'glass')
+
+          window_area += subsurface.grossArea * subsurface.multiplier * multiplier
+        end
+      end
+    end
+    return window_area / wall_area * 100 if wwr
+
+    # else
+    return window_area
+  end
+
   # Calculate a model's window or WWR for a specific orientation
   # Disregard space conditioning (assume all spaces are conditioned)
   # which is true for most of not all prototypes

data/lib/openstudio-standards/prototypes/common/objects/Prototype.ServiceWaterHeating.rb

@@ -381,12 +381,13 @@ class Standard
       hpwh.setCondenserBottomLocation(h_condbot)
       hpwh.setCondenserTopLocation(h_condtop)
       hpwh.setTankElementControlLogic('MutuallyExclusive')
+      hpwh.autocalculateEvaporatorAirFlowRate
     elsif type == 'PumpedCondenser'
       hpwh.setDeadBandTemperatureDifference(3.89)
+      hpwh.autosizeEvaporatorAirFlowRate
     end
 
     # set heat pump water heater properties
-    hpwh.setEvaporatorAirFlowRate(OpenStudio.convert(181.0, 'ft^3/min', 'm^3/s').get)
     hpwh.setFanPlacement('DrawThrough')
     hpwh.setOnCycleParasiticElectricLoad(0.0)
     hpwh.setOffCycleParasiticElectricLoad(0.0)
@@ -445,9 +446,10 @@ class Standard
     if type == 'WrappedCondenser'
       coil = hpwh.dXCoil.to_CoilWaterHeatingAirToWaterHeatPumpWrapped.get
       coil.setRatedCondenserWaterTemperature(48.89)
+      coil.autocalculateRatedEvaporatorAirFlowRate
     elsif type == 'PumpedCondenser'
-      coil = OpenStudio::Model::CoilWaterHeatingAirToWaterHeatPump.new(model)
-      hpwh.setDXCoil(coil)
+      coil = hpwh.dXCoil.to_CoilWaterHeatingAirToWaterHeatPump.get
+      coil.autosizeRatedEvaporatorAirFlowRate
     end
 
     # set coil properties
@@ -457,7 +459,6 @@ class Standard
     coil.setRatedSensibleHeatRatio(shr)
     coil.setRatedEvaporatorInletAirDryBulbTemperature(OpenStudio.convert(67.5, 'F', 'C').get)
     coil.setRatedEvaporatorInletAirWetBulbTemperature(OpenStudio.convert(56.426, 'F', 'C').get)
-    coil.setRatedEvaporatorAirFlowRate(OpenStudio.convert(181.0, 'ft^3/min', 'm^3/s').get)
     coil.setEvaporatorFanPowerIncludedinRatedCOP(true)
     coil.setEvaporatorAirTemperatureTypeforCurveObjects('WetBulbTemperature')
     coil.setHeatingCapacityFunctionofTemperatureCurve(hpwh_cap)
@@ -507,8 +508,7 @@ class Standard
       tank.setSourceSideInletHeight(0)
       tank.setSourceSideOutletHeight(0)
     elsif type == 'PumpedCondenser'
-      tank = OpenStudio::Model::WaterHeaterMixed.new(model)
-      hpwh.setTank(tank)
+      tank = hpwh.tank.to_WaterHeaterMixed.get
       tank.setDeadbandTemperatureDifference(3.89)
       tank.setHeaterControlType('Cycle')
       tank.setHeaterMaximumCapacity(electric_backup_capacity)

data/lib/openstudio-standards/prototypes/common/objects/Prototype.hvac_systems.rb

@@ -5480,7 +5480,6 @@ class Standard
       ventilation.setSchedule(availability_schedule)
 
       if ventilation_type == 'Exhaust'
-        ventilation.setDesignFlowRateCalculationMethod('Flow/Zone')
         ventilation.setDesignFlowRate(flow_rate)
         ventilation.setFanPressureRise(31.1361206455786)
         ventilation.setFanTotalEfficiency(0.51)
@@ -5491,7 +5490,6 @@ class Standard
         ventilation.setMaximumIndoorTemperature(100.0)
         ventilation.setDeltaTemperature(-100.0)
       elsif ventilation_type == 'Natural'
-        ventilation.setDesignFlowRateCalculationMethod('Flow/Zone')
         ventilation.setDesignFlowRate(flow_rate)
         ventilation.setFanPressureRise(0.0)
         ventilation.setFanTotalEfficiency(1.0)
@@ -5502,7 +5500,6 @@ class Standard
         ventilation.setMaximumIndoorTemperature(29.4444452244559)
         ventilation.setDeltaTemperature(-100.0)
       elsif ventilation_type == 'Intake'
-        ventilation.setDesignFlowRateCalculationMethod('Flow/Area')
         ventilation.setFlowRateperZoneFloorArea(flow_rate)
         ventilation.setFanPressureRise(49.8)
         ventilation.setFanTotalEfficiency(0.53625)

data/lib/openstudio-standards/standards/Standards.AirLoopHVAC.rb

@@ -489,7 +489,7 @@ class Standard
         fan_pwr_limit_type = 'variable volume'
       elsif comp.to_AirLoopHVACUnitaryHeatCoolVAVChangeoverBypass.is_initialized
         fan = comp.to_AirLoopHVACUnitaryHeatCoolVAVChangeoverBypass.get.supplyAirFan
-        if fan.to_FanConstantVolume.is_initialized || comp.to_FanOnOff.is_initialized
+        if fan.to_FanConstantVolume.is_initialized || fan.to_FanOnOff.is_initialized
           fan_pwr_limit_type = 'constant volume'
         elsif fan.to_FanVariableVolume.is_initialized
           fan_pwr_limit_type = 'variable volume'
@@ -1712,7 +1712,7 @@ class Standard
     heat_exchanger_air_to_air_sensible_and_latent_apply_prototype_nominal_electric_power(erv)
 
     # add economizer lockout
-    erv.setSupplyAirOutletTemperatureControl(false)
+    erv.setSupplyAirOutletTemperatureControl(true)
     erv.setEconomizerLockout(true)
 
     # add defrost

data/lib/openstudio-standards/standards/Standards.CoilCoolingWaterToAirHeatPumpEquationFit.rb

@@ -103,7 +103,6 @@ class Standard
   # @param sql_db_vars_map [Hash] hash map
   # @return [Hash] hash of coil objects
   def coil_cooling_water_to_air_heat_pump_apply_efficiency_and_curves(coil_cooling_water_to_air_heat_pump, sql_db_vars_map)
-    successfully_set_all_properties = true
 
     # Get the search criteria
     search_criteria = {}
@@ -116,8 +115,15 @@ class Standard
 
     # Check to make sure properties were found
     if coil_props.nil?
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
-      successfully_set_all_properties = false
+      # search again without capacity
+      matching_objects = model_find_objects(standards_data['water_source_heat_pumps'], search_criteria, nil, Date.today)
+      if matching_objects.size.zero?
+        # This proves that the search_criteria has issue finding the correct coil prop
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "For #{coil_cooling_water_to_air_heat_pump.name}, cannot find efficiency info using #{search_criteria}, cannot apply efficiency standard.")
+      else
+        # Issue warning indicate the coil size is may be too large
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.CoilCoolingWaterToAirHeatPumpEquationFit', "The capacity of the coil: #{coil_cooling_water_to_air_heat_pump.name} maybe too large to be found in the efficiency standard. The coil capacity is #{capacity_btu_per_hr} Btu/hr.")
+      end
       return sql_db_vars_map
     end
 

data/lib/openstudio-standards/standards/Standards.CoilHeatingGas.rb

@@ -22,6 +22,8 @@ class Standard
     capacity_btu_per_hr = OpenStudio.convert(capacity_w, 'W', 'Btu/hr').get
     capacity_kbtu_per_hr = OpenStudio.convert(capacity_w, 'W', 'kBtu/hr').get
 
+    return false unless capacity_btu_per_hr > 0
+
     # Get the boiler properties, if it exists for this template
     return false unless standards_data.include?('furnaces')
 

data/lib/openstudio-standards/standards/Standards.Construction.rb

@@ -83,16 +83,22 @@ class Standard
     # and the R-value of the non-insulation layers and air films.
     # This is the desired R-value of the insulation.
     ins_r_value_si = target_r_value_si - other_layer_r_value_si
-    if ins_r_value_si <= 0.0
-      OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.Construction', "Requested U-value of #{target_u_value_ip} for #{construction.name} is too low given the other materials in the construction; insulation layer will not be modified.")
-      return false
-    end
-    ins_r_value_ip = OpenStudio.convert(ins_r_value_si, 'm^2*K/W', 'ft^2*h*R/Btu').get
 
     # Set the R-value of the insulation layer
-    construction.layers.each do |layer|
+    construction.layers.each_with_index do |layer, l|
       next unless layer.name.get == insulation_layer_name
 
+      # Remove insulation layer if requested R-value is lower than sum of non-insulation materials
+      if ins_r_value_si <= 0.0
+        OpenStudio.logFree(OpenStudio::Warn, 'openstudio.standards.Construction', "Requested U-value of #{target_u_value_ip} for #{construction.name} is too low given the other materials in the construction; insulation layer will be removed.")
+        construction.eraseLayer(l)
+        # Set the target R-value to the sum of other layers to make name match properties
+        target_r_value_ip = OpenStudio.convert(other_layer_r_value_si, 'm^2*K/W', 'ft^2*hr*R/Btu').get
+        break # Don't modify the insulation layer since it has been removed
+      end
+
+      # Modify the insulation layer
+      ins_r_value_ip = OpenStudio.convert(ins_r_value_si, 'm^2*K/W', 'ft^2*h*R/Btu').get
       if layer.to_StandardOpaqueMaterial.is_initialized
         layer = layer.to_StandardOpaqueMaterial.get
         layer.setThickness(ins_r_value_si * layer.conductivity)

data/lib/openstudio-standards/standards/Standards.Model.rb

@@ -2524,12 +2524,28 @@ class Standard
     # which specifies properties by construction category by climate zone set.
     # AKA the info in Tables 5.5-1-5.5-8
 
-    props = model_find_object(standards_data['construction_properties'],
-                              'template' => template,
-                              'climate_zone_set' => climate_zone_set,
-                              'intended_surface_type' => intended_surface_type,
-                              'standards_construction_type' => standards_construction_type,
-                              'building_category' => building_category)
+    wwr = model_get_percent_of_surface_range(model, intended_surface_type)
+
+    search_criteria = { 'template' => template,
+                        'climate_zone_set' => climate_zone_set,
+                        'intended_surface_type' => intended_surface_type,
+                        'standards_construction_type' => standards_construction_type,
+                        'building_category' => building_category }
+
+    if !wwr['minimum_percent_of_surface'].nil? && !wwr['maximum_percent_of_surface'].nil?
+      search_criteria['minimum_percent_of_surface'] = wwr['minimum_percent_of_surface']
+      search_criteria['maximum_percent_of_surface'] = wwr['maximum_percent_of_surface']
+    end
+
+    # First search
+    props = model_find_object(standards_data['construction_properties'], search_criteria)
+
+    if !props
+      # Second search: In case need to use climate zone (e.g: 3) instead of sub-climate zone (e.g: 3A) for search
+      climate_zone = climate_zone_set[0..-2]
+      search_criteria['climate_zone_set'] = climate_zone
+      props = model_find_object(standards_data['construction_properties'], search_criteria)
+    end
 
     if !props
       OpenStudio.logFree(OpenStudio::Error, 'openstudio.standards.Model', "Could not find construction properties for: #{template}-#{climate_zone_set}-#{intended_surface_type}-#{standards_construction_type}-#{building_category}.")
@@ -3602,6 +3618,12 @@ class Standard
     # switch to use this but update test in standards and measures to load this outside of the method
     construction_properties = model_find_object(standards_data['construction_properties'], search_criteria)
 
+    if !construction_properties
+      # Search again use climate zone (e.g. 3) instead of sub-climate zone (3A)
+      search_criteria['climate_zone_set'] = climate_zone_set[0..-2]
+      construction_properties = model_find_object(standards_data['construction_properties'], search_criteria)
+    end
+
     return construction_properties
   end
 
@@ -4290,7 +4312,7 @@ class Standard
   # @param possible_climate_zone_sets [Array] climate zone sets
   # @return [String] climate zone ses
   def model_get_climate_zone_set_from_list(model, possible_climate_zone_sets)
-    climate_zone_set = possible_climate_zone_sets.min
+    climate_zone_set = possible_climate_zone_sets.max
     return climate_zone_set
   end
 
@@ -5779,6 +5801,15 @@ class Standard
     return parametric_inputs
   end
 
+  # Determine the surface range of a baseline model.
+  # The method calculates the window to wall ratio (assuming all spaces are conditioned)
+  # and select the range based on the calculated window to wall ratio
+  # @param model [OpenStudio::Model::Model] OpenStudio model object
+  # @param intended_surface_type [String] surface type
+  def model_get_percent_of_surface_range(model, intended_surface_type)
+    return { 'minimum_percent_of_surface' => nil, 'maximum_percent_of_surface' => nil }
+  end
+
   # Default SAT reset type
   #
   # @param air_loop_hvac [OpenStudio::Model::AirLoopHVAC] air loop

data/lib/openstudio-standards/standards/Standards.Space.rb

@@ -321,7 +321,7 @@ class Standard
               min_y_val = vertex.y
             end
             # Max y value
-            if vertex.y > max_x_val
+            if vertex.y > max_y_val
               max_y_val = vertex.y
             end
           end

data/lib/openstudio-standards/standards/Standards.SpaceType.rb

@@ -599,6 +599,13 @@ class Standard
     # switch to use this but update test in standards and measures to load this outside of the method
     construction_properties = model_find_object(standards_data['construction_properties'], search_criteria)
 
+    if !construction_properties
+      # Search again use climate zone (e.g. 3) instead of sub-climate zone (3A)
+      search_criteria['climate_zone_set'] = climate_zone_set[0..-2]
+      construction_properties = model_find_object(standards_data['construction_properties'], search_criteria)
+    end
+
+
     return construction_properties
   end
 end