openstudio-common-measures 0.3.2 → 0.6.0

data/lib/measures/generic_qaqc/resources/check_mech_sys_efficiency.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -44,7 +44,9 @@ module OsLib_QAQC
     check_elems = OpenStudio::AttributeVector.new
     check_elems << OpenStudio::Attribute.new('name', 'Mechanical System Efficiency')
     check_elems << OpenStudio::Attribute.new('category', category)
-
+    check_elems << OpenStudio::Attribute.new('min_pass', min_pass * 100)
+    check_elems << OpenStudio::Attribute.new('max_pass', max_pass * 100)
+    
     if target_standard.include?('90.1-2013')
       display_standard = "ASHRAE #{target_standard}"
       check_elems << OpenStudio::Attribute.new('description', "Check against #{display_standard} Tables 6.8.1 A-K for the following component types: #{component_type_array.join(', ')}.")
@@ -62,6 +64,7 @@ module OsLib_QAQC
     if name_only == true
       results = []
       check_elems.each do |elem|
+        next if ['Double','Integer'].include? (elem.valueType.valueDescription)
         results << elem.valueAsString
       end
       return results
@@ -96,9 +99,9 @@ module OsLib_QAQC
         if standard_minimum_full_load_efficiency.nil?
           check_elems <<  OpenStudio::Attribute.new('flag', "Can't find target full load efficiency for #{component.name}.")
         elsif reference_COP < standard_minimum_full_load_efficiency * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "COP of #{reference_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_full_load_efficiency.round(2)}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "COP of #{reference_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_full_load_efficiency.round(2)}.")
         elsif reference_COP > standard_minimum_full_load_efficiency * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "COP  of #{reference_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_full_load_efficiency.round(2)}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "COP  of #{reference_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_full_load_efficiency.round(2)}.")
         end
       end
 
@@ -118,9 +121,9 @@ module OsLib_QAQC
         if standard_minimum_cop.nil?
           check_elems <<  OpenStudio::Attribute.new('flag', "Can't find target COP for #{component.name}.")
         elsif rated_COP < standard_minimum_cop * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of #{rated_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of #{rated_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         elsif rated_COP > standard_minimum_cop * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of  #{rated_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of  #{rated_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         end
       end
 
@@ -141,16 +144,16 @@ module OsLib_QAQC
         if standard_minimum_cop.nil?
           check_elems <<  OpenStudio::Attribute.new('flag', "Can't find target COP for #{component.name}.")
         elsif rated_high_speed_COP < standard_minimum_cop * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The high speed COP of #{rated_high_speed_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The high speed COP of #{rated_high_speed_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         elsif rated_high_speed_COP > standard_minimum_cop * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The high speed COP of  #{rated_high_speed_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The high speed COP of  #{rated_high_speed_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         end
         if standard_minimum_cop.nil?
           check_elems <<  OpenStudio::Attribute.new('flag', "Can't find target COP for #{component.name}.")
         elsif rated_low_speed_COP < standard_minimum_cop * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The low speed COP of #{rated_low_speed_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The low speed COP of #{rated_low_speed_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         elsif rated_low_speed_COP > standard_minimum_cop * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The low speed COP of  #{rated_low_speed_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The low speed COP of  #{rated_low_speed_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         end
       end
 
@@ -171,9 +174,9 @@ module OsLib_QAQC
         if standard_minimum_cop.nil?
           check_elems <<  OpenStudio::Attribute.new('flag', "Can't find target COP for #{component.name}.")
         elsif rated_COP < standard_minimum_cop * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of #{rated_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of #{rated_COP.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_cop.round(2)} for #{display_standard}.")
         elsif rated_COP > standard_minimum_cop * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of  #{rated_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_cop.round(2)}. for #{display_standard}")
+          check_elems <<  OpenStudio::Attribute.new('flag', "The COP of  #{rated_COP.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_cop.round(2)}. for #{display_standard}")
         end
       end
 
@@ -190,12 +193,14 @@ module OsLib_QAQC
         end
 
         # check actual against target
-        if standard_minimum_thermal_efficiency.nil?
+        if component.autosizedNominalCapacity.get == 0
+          check_elems <<  OpenStudio::Attribute.new('flag', "Boiler named #{component.name} has a capacity of 0.")
+        elsif standard_minimum_thermal_efficiency.nil?
           check_elems <<  OpenStudio::Attribute.new('flag', "Can't find target thermal efficiency for #{component.name}.")
         elsif nominal_thermal_efficiency < standard_minimum_thermal_efficiency * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Nominal thermal efficiency of #{nominal_thermal_efficiency.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_thermal_efficiency.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Nominal thermal efficiency of #{nominal_thermal_efficiency.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_thermal_efficiency.round(2)} for #{display_standard}.")
         elsif nominal_thermal_efficiency > standard_minimum_thermal_efficiency * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Nominal thermal efficiency of  #{nominal_thermal_efficiency.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_thermal_efficiency.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Nominal thermal efficiency of  #{nominal_thermal_efficiency.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_thermal_efficiency.round(2)} for #{display_standard}.")
         end
       end
 
@@ -219,9 +224,9 @@ module OsLib_QAQC
 
         # check actual against target
         if motor_eff < standard_minimum_motor_efficiency_and_size * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         elsif motor_eff > standard_minimum_motor_efficiency_and_size * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         end
       end
 
@@ -244,9 +249,9 @@ module OsLib_QAQC
 
         # check actual against target
         if motor_eff < standard_minimum_motor_efficiency_and_size * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         elsif motor_eff > standard_minimum_motor_efficiency_and_size * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         end
       end
 
@@ -270,9 +275,9 @@ module OsLib_QAQC
 
         # check actual against target
         if motor_eff < standard_minimum_motor_efficiency_and_size * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         elsif motor_eff > standard_minimum_motor_efficiency_and_size * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         end
       end
 
@@ -296,9 +301,9 @@ module OsLib_QAQC
 
         # check actual against target
         if motor_eff < standard_minimum_motor_efficiency_and_size * (1.0 - min_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{min_pass * 100} % below the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         elsif motor_eff > standard_minimum_motor_efficiency_and_size * (1.0 + max_pass)
-          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the expected value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
+          check_elems <<  OpenStudio::Attribute.new('flag', "Motor efficiency of #{motor_eff.round(2)} for #{component.name} is more than #{max_pass * 100} % above the value of #{standard_minimum_motor_efficiency_and_size.round(2)} for #{display_standard}.")
         end
       end
 

data/lib/measures/generic_qaqc/resources/check_mech_sys_part_load_eff.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -53,12 +53,15 @@ module OsLib_QAQC
     check_elems << OpenStudio::Attribute.new('name', 'Mechanical System Part Load Efficiency')
     check_elems << OpenStudio::Attribute.new('category', category)
     check_elems << OpenStudio::Attribute.new('description', "Check 40% and 80% part load efficency against #{display_standard} for the following compenent types: #{component_type_array.join(', ')}. Checking EIR Function of Part Load Ratio curve for chiller and EIR Function of Flow Fraction for DX coils.")
+    check_elems << OpenStudio::Attribute.new('min_pass', min_pass * 100)
+    check_elems << OpenStudio::Attribute.new('max_pass', max_pass * 100)
     # TODO: - add in check for VAV fan
 
     # stop here if only name is requested this is used to populate display name for arguments
     if name_only == true
       results = []
       check_elems.each do |elem|
+        next if ['Double','Integer'].include? (elem.valueType.valueDescription)
         results << elem.valueAsString
       end
       return results
@@ -143,7 +146,7 @@ module OsLib_QAQC
 
         if use_old_gem_code
           chlr_props = component.model.find_object($os_standards['chillers'], search_criteria, capacity_tons, Date.today)
-          chlr_props
+        else
           chlr_props = std.model_find_object(std.standards_data['chillers'], search_criteria, capacity_tons, Date.today)
         end
         if chlr_props.nil?

data/lib/measures/generic_qaqc/resources/check_mech_sys_type.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -40,7 +40,7 @@ module OsLib_QAQC
   def check_mech_sys_type(category, target_standard, name_only = false)
     # summary of the check
     check_elems = OpenStudio::AttributeVector.new
-    check_elems << OpenStudio::Attribute.new('name', 'Mechanical System Type')
+    check_elems << OpenStudio::Attribute.new('name', 'Baseline Mechanical System Type')
     check_elems << OpenStudio::Attribute.new('category', category)
 
     # add ASHRAE to display of target standard if includes with 90.1
@@ -49,7 +49,7 @@ module OsLib_QAQC
     else
       check_elems << OpenStudio::Attribute.new('description', 'Check against ASHRAE 90.1. Infers the baseline system type based on the equipment serving the zone and their heating/cooling fuels. Only does a high-level inference; does not look for the presence/absence of required controls, etc.')
     end
-
+    
     # stop here if only name is requested this is used to populate display name for arguments
     if name_only == true
       results = []
@@ -119,7 +119,7 @@ module OsLib_QAQC
         else
           if req_sys_type == '' then req_sys_type = 'Unknown' end
           puts "#{zone.name} baseline system type is incorrect. Supposed to be #{req_sys_type}, but was #{act_sys_type} instead."
-          check_elems << OpenStudio::Attribute.new('flag', "#{zone.name} baseline system type is incorrect. Supposed to be #{req_sys_type}, but was #{act_sys_type} instead.")
+          check_elems << OpenStudio::Attribute.new('flag', "For #{zone.name}, the baseline system type would be #{req_sys_type}; the current system type is #{act_sys_type}.")
         end
       end
     rescue StandardError => e

data/lib/measures/generic_qaqc/resources/check_part_loads.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:

data/lib/measures/generic_qaqc/resources/check_placeholder.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:

data/lib/measures/generic_qaqc/resources/check_plant_cap.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:

data/lib/measures/generic_qaqc/resources/check_plant_temps.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:

data/lib/measures/generic_qaqc/resources/check_plenum_loads.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:

data/lib/measures/generic_qaqc/resources/check_pump_pwr.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:

data/lib/measures/generic_qaqc/resources/check_sch_coord.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:

data/lib/measures/generic_qaqc/resources/check_schedules.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -42,60 +42,63 @@ module OsLib_QAQC
     check_elems = OpenStudio::AttributeVector.new
     check_elems << OpenStudio::Attribute.new('name', 'Schedules')
     check_elems << OpenStudio::Attribute.new('category', category)
-    check_elems << OpenStudio::Attribute.new('description', 'Check schedules for lighting, ventilation, occupant density, plug loads, and equipment based on DOE reference building schedules in terms of full load hours per year.')
+
+    # update display sttandard
+    if target_standard.include?('90.1')
+      display_standard = "ASHRAE #{target_standard}"
+    else
+      display_standard = target_standard
+    end
 
     # stop here if only name is requested this is used to populate display name for arguments
     if name_only == true
       results = []
+      check_elems << OpenStudio::Attribute.new('description', 'Check schedules for lighting, ventilation, occupant density, plug loads, and equipment based on DOE reference building schedules in terms of full load hours per year.')
       check_elems.each do |elem|
         results << elem.valueAsString
       end
       return results
     end
 
-    # Versions of OpenStudio greater than 2.4.0 use a modified version of
-    # openstudio-standards with different method calls.  These methods
-    # require a "Standard" object instead of the standard being passed into method calls.
-    # This Standard object is used throughout the QAQC check.
-    if OpenStudio::VersionString.new(OpenStudio.openStudioVersion) < OpenStudio::VersionString.new('2.4.3')
-      use_old_gem_code = true
-    else
-      use_old_gem_code = false
+    begin
+
+      # setup standard
       std = Standard.build(target_standard)
-    end
 
-    begin
+      # gather building type for summary
+      bt_cz = std.model_get_building_climate_zone_and_building_type(@model)
+      building_type = bt_cz['building_type']
+      # mapping to obuilding type to match space types
+      if building_type.include?("Office") then building_type = "Office" end
+      climate_zone = bt_cz['climate_zone']
+      prototype_prefix = "#{display_standard} #{building_type} #{climate_zone}"
+      check_elems << OpenStudio::Attribute.new('description', "Check schedules for lighting, ventilation, occupant density, plug loads, and equipment based on #{prototype_prefix} DOE reference building schedules in terms of full load hours per year.")
+      check_elems << OpenStudio::Attribute.new('min_pass', min_pass * 100)
+      check_elems << OpenStudio::Attribute.new('max_pass', max_pass * 100)
+      
+      # gather all non statandard space types so can be listed in single flag
+      non_tagged_space_types = []
+
       # loop through all space types used in the model
       @model.getSpaceTypes.each do |space_type|
         next if space_type.floorArea <= 0
 
         # load in standard info for this space type
-        if use_old_gem_code
-          data = space_type.get_standards_data(target_standard)
-        else
-          data = std.space_type_get_standards_data(space_type)
-        end
+        data = std.space_type_get_standards_data(space_type)
 
         if data.nil? || data.empty?
 
           # skip if all spaces using this space type are plenums
           all_spaces_plenums = true
           space_type.spaces.each do |space|
-            if use_old_gem_code
-              if !space.plenum?
-                all_spaces_plenums = false
-                next
-              end
-            else
-              if !std.space_plenum?(space)
-                all_spaces_plenums = false
-                next
-              end
+            if !std.space_plenum?(space)
+              all_spaces_plenums = false
+              next
             end
           end
 
           if !all_spaces_plenums
-            check_elems << OpenStudio::Attribute.new('flag', "Unexpected standards type for #{space_type.name}, can't validate schedules.")
+            non_tagged_space_types << space_type.floorArea
           end
 
           next
@@ -107,22 +110,14 @@ module OsLib_QAQC
         # check lighting schedules
         data['lighting_per_area'].nil? ? (target_ip = 0.0) : (target_ip = data['lighting_per_area'])
         if target_ip.to_f > 0
-          if use_old_gem_code
-            schedule_target = model_temp.add_schedule(data['lighting_schedule'])
-          else
-            schedule_target = std.model_add_schedule(model_temp, data['lighting_schedule'])
-          end
+          schedule_target = std.model_add_schedule(model_temp, data['lighting_schedule'])
           if !schedule_target
             check_elems << OpenStudio::Attribute.new('flag', "Didn't find schedule named #{data['lighting_schedule']} in standards json.")
           else
             # loop through and test individual load instances
-            if use_old_gem_code
-              target_hrs = schedule_target.annual_equivalent_full_load_hrs
-            else
-              target_hrs = std.schedule_ruleset_annual_equivalent_full_load_hrs(schedule_target)
-            end
+            target_hrs = std.schedule_ruleset_annual_equivalent_full_load_hrs(schedule_target.to_ScheduleRuleset.get)
             space_type.lights.each do |load_inst|
-              inst_sch_check = generate_load_insc_sch_check_attribute(target_hrs, load_inst, space_type, check_elems, min_pass, max_pass)
+              inst_sch_check = generate_load_insc_sch_check_attribute(target_hrs, load_inst, space_type, check_elems, min_pass, max_pass, target_standard)
               if inst_sch_check then check_elems << inst_sch_check end
             end
 
@@ -132,23 +127,15 @@ module OsLib_QAQC
         # check electric equipment schedules
         data['electric_equipment_per_area'].nil? ? (target_ip = 0.0) : (target_ip = data['electric_equipment_per_area'])
         if target_ip.to_f > 0
-          if use_old_gem_code
-            schedule_target = model_temp.add_schedule(data['electric_equipment_schedule'])
-          else
-            schedule_target = std.model_add_schedule(model_temp, data['electric_equipment_schedule'])
-          end
+          schedule_target = std.model_add_schedule(model_temp, data['electric_equipment_schedule'])
           if !schedule_target
             check_elems << OpenStudio::Attribute.new('flag', "Didn't find schedule named #{data['electric_equipment_schedule']} in standards json.")
           else
             # loop through and test individual load instances
-            if use_old_gem_code
-              target_hrs = schedule_target.annual_equivalent_full_load_hrs
-            else
-              target_hrs = std.schedule_ruleset_annual_equivalent_full_load_hrs(schedule_target)
-            end
+            target_hrs = std.schedule_ruleset_annual_equivalent_full_load_hrs(schedule_target.to_ScheduleRuleset.get)
 
             space_type.electricEquipment.each do |load_inst|
-              inst_sch_check = generate_load_insc_sch_check_attribute(target_hrs, load_inst, space_type, check_elems, min_pass, max_pass)
+              inst_sch_check = generate_load_insc_sch_check_attribute(target_hrs, load_inst, space_type, check_elems, min_pass, max_pass, target_standard)
               if inst_sch_check then check_elems << inst_sch_check end
             end
           end
@@ -158,22 +145,14 @@ module OsLib_QAQC
         # todo - update measure test to with space type to check this
         data['gas_equipment_per_area'].nil? ? (target_ip = 0.0) : (target_ip = data['gas_equipment_per_area'])
         if target_ip.to_f > 0
-          if use_old_gem_code
-            schedule_target = model_temp.add_schedule(data['gas_equipment_schedule'])
-          else
-            schedule_target = std.model_add_schedule(model_temp, data['gas_equipment_schedule'])
-          end
+          schedule_target = std.model_add_schedule(model_temp, data['gas_equipment_schedule'])
           if !schedule_target
             check_elems << OpenStudio::Attribute.new('flag', "Didn't find schedule named #{data['gas_equipment_schedule']} in standards json.")
           else
             # loop through and test individual load instances
-            if use_old_gem_code
-              target_hrs = schedule_target.annual_equivalent_full_load_hrs
-            else
-              target_hrs = std.schedule_ruleset_annual_equivalent_full_load_hrs(schedule_target)
-            end
+            target_hrs = std.schedule_ruleset_annual_equivalent_full_load_hrs(schedule_target.to_ScheduleRuleset.get)
             space_type.gasEquipment.each do |load_inst|
-              inst_sch_check = generate_load_insc_sch_check_attribute(target_hrs, load_inst, space_type, check_elems, min_pass, max_pass)
+              inst_sch_check = generate_load_insc_sch_check_attribute(target_hrs, load_inst, space_type, check_elems, min_pass, max_pass, target_standard)
               if inst_sch_check then check_elems << inst_sch_check end
             end
           end
@@ -182,22 +161,14 @@ module OsLib_QAQC
         # check occupancy schedules
         data['occupancy_per_area'].nil? ? (target_ip = 0.0) : (target_ip = data['occupancy_per_area'])
         if target_ip.to_f > 0
-          if use_old_gem_code
-            schedule_target = model_temp.add_schedule(data['occupancy_schedule'])
-          else
-            schedule_target = std.model_add_schedule(model_temp, data['occupancy_schedule'])
-          end
+          schedule_target = std.model_add_schedule(model_temp, data['occupancy_schedule'])
           if !schedule_target
             check_elems << OpenStudio::Attribute.new('flag', "Didn't find schedule named #{data['occupancy_schedule']} in standards json.")
           else
             # loop through and test individual load instances
-            if use_old_gem_code
-              target_hrs = schedule_target.annual_equivalent_full_load_hrs
-            else
-              target_hrs = std.schedule_ruleset_annual_equivalent_full_load_hrs(schedule_target)
-            end
+            target_hrs = std.schedule_ruleset_annual_equivalent_full_load_hrs(schedule_target.to_ScheduleRuleset.get)
             space_type.people.each do |load_inst|
-              inst_sch_check = generate_load_insc_sch_check_attribute(target_hrs, load_inst, space_type, check_elems, min_pass, max_pass)
+              inst_sch_check = generate_load_insc_sch_check_attribute(target_hrs, load_inst, space_type, check_elems, min_pass, max_pass, target_standard)
               if inst_sch_check then check_elems << inst_sch_check end
             end
 
@@ -212,7 +183,7 @@ module OsLib_QAQC
           if oa.outdoorAirFlowRateFractionSchedule.is_initialized
             # TODO: - update measure test to check this
             target_hrs = 8760
-            inst_sch_check = generate_load_insc_sch_check_attribute(target_hrs, oa, space_type, check_elems, min_pass, max_pass)
+            inst_sch_check = generate_load_insc_sch_check_attribute(target_hrs, oa, space_type, check_elems, min_pass, max_pass, target_standard)
             if inst_sch_check then check_elems << inst_sch_check end
           end
         end
@@ -227,13 +198,16 @@ module OsLib_QAQC
         # model load for space type where standards doesn't have one wont throw flag about mis-matched schedules
       end
 
+      # report about non standard space types
+      if non_tagged_space_types.size > 0
+        impacted_floor_area = non_tagged_space_types.sum
+        building_area = @model.getBuilding.floorArea
+        check_elems << OpenStudio::Attribute.new('flag', "Unexpected standard building/space types found for #{non_tagged_space_types.size} space types covering #{(100 * impacted_floor_area/building_area).round}% of floor area, can't provide comparisons for schedules for those space types.")
+      end
+
       # warn if there are spaces in model that don't use space type unless they appear to be plenums
       @model.getSpaces.each do |space|
-        if use_old_gem_code
-          next if space.plenum?
-        else
-          next if std.space_plenum?(space)
-        end
+        next if std.space_plenum?(space)
         if !space.spaceType.is_initialized
           check_elems << OpenStudio::Attribute.new('flag', "#{space.name} doesn't have a space type assigned, can't validate schedules.")
         end
@@ -255,21 +229,19 @@ module OsLib_QAQC
 
   # code for each load instance for different load types will pass through here
   # will return nill or a single attribute
-  def generate_load_insc_sch_check_attribute(target_hrs, load_inst, space_type, check_elems, min_pass, max_pass)
-    # Versions of OpenStudio greater than 2.4.0 use a modified version of
-    # openstudio-standards with different method calls.  These methods
-    # require a "Standard" object instead of the standard being passed into method calls.
-    # This Standard object is used throughout the QAQC check.
-    if OpenStudio::VersionString.new(OpenStudio.openStudioVersion) < OpenStudio::VersionString.new('2.4.3')
-      use_old_gem_code = true
-    else
-      use_old_gem_code = false
-      std = Standard.build('90.1-2013')
-    end
-
+  def generate_load_insc_sch_check_attribute(target_hrs, load_inst, space_type, check_elems, min_pass, max_pass, target_standard)
     schedule_inst = nil
     inst_hrs = nil
 
+    # setup standard
+    std = Standard.build(target_standard)
+      
+    # gather building type for summary
+    bt_cz = std.model_get_building_climate_zone_and_building_type(@model)
+    building_type = bt_cz['building_type']
+    climate_zone = bt_cz['climate_zone']
+    prototype_prefix = "#{target_standard} #{building_type} #{climate_zone}"
+
     # get schedule
     if (load_inst.class.to_s == 'OpenStudio::Model::People') && load_inst.numberofPeopleSchedule.is_initialized
       schedule_inst = load_inst.numberofPeopleSchedule.get
@@ -283,26 +255,18 @@ module OsLib_QAQC
 
     # get annual equiv for model schedule
     if schedule_inst.to_ScheduleRuleset.is_initialized
-      if use_old_gem_code
-        inst_hrs = schedule_inst.to_ScheduleRuleset.get.annual_equivalent_full_load_hrs
-      else
-        inst_hrs = std.schedule_ruleset_annual_equivalent_full_load_hrs(schedule_inst.to_ScheduleRuleset.get)
-      end
+      inst_hrs = std.schedule_ruleset_annual_equivalent_full_load_hrs(schedule_inst.to_ScheduleRuleset.get)
     elsif schedule_inst.to_ScheduleConstant.is_initialized
-      if use_old_gem_code
-        inst_hrs = schedule_inst.to_ScheduleConstant.get.annual_equivalent_full_load_hrs
-      else
-        inst_hrs = std.schedule_constant_annual_equivalent_full_load_hrs(schedule_inst.to_ScheduleConstant.get)
-      end
+      inst_hrs = std.schedule_constant_annual_equivalent_full_load_hrs(schedule_inst.to_ScheduleConstant.get)
     else
       return OpenStudio::Attribute.new('flag', "#{schedule_inst.name} isn't a Ruleset or Constant schedule. Can't calculate annual equivalent full load hours.")
     end
 
     # check instance against target
     if inst_hrs < target_hrs * (1.0 - min_pass)
-      return OpenStudio::Attribute.new('flag', "#{inst_hrs.round} annual equivalent full load hours for #{schedule_inst.name} in #{space_type.name} is more than #{min_pass * 100} (%) below the typical value of #{target_hrs.round} hours from the DOE Prototype building.")
+      return OpenStudio::Attribute.new('flag', "#{inst_hrs.round} annual equivalent full load hours for #{schedule_inst.name} in #{space_type.name} is more than #{min_pass * 100} (%) below the value of #{target_hrs.round} hours from the #{prototype_prefix} DOE Prototype building.")
     elsif inst_hrs > target_hrs * (1.0 + max_pass)
-      return OpenStudio::Attribute.new('flag', "#{inst_hrs.round} annual equivalent full load hours for #{schedule_inst.name} in #{space_type.name}  is more than #{max_pass * 100} (%) above the typical value of #{target_hrs.round} hours DOE Prototype building.")
+      return OpenStudio::Attribute.new('flag', "#{inst_hrs.round} annual equivalent full load hours for #{schedule_inst.name} in #{space_type.name}  is more than #{max_pass * 100} (%) above the value of #{target_hrs.round} hours from the #{prototype_prefix} DOE Prototype building.")
     end
 
     # will get to this if no flag was thrown

data/lib/measures/generic_qaqc/resources/check_simultaneous_heating_and_cooling.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -43,11 +43,13 @@ module OsLib_QAQC
     check_elems << OpenStudio::Attribute.new('name', 'Simultaneous Heating and Cooling')
     check_elems << OpenStudio::Attribute.new('category', category)
     check_elems << OpenStudio::Attribute.new('description', 'Check for simultaneous heating and cooling by looping through all Single Duct VAV Reheat Air Terminals and analyzing hourly data when there is a cooling load. ')
-
+    check_elems << OpenStudio::Attribute.new('max_pass', max_pass * 100)
+      
     # stop here if only name is requested this is used to populate display name for arguments
     if name_only == true
       results = []
       check_elems.each do |elem|
+        next if ['Double','Integer'].include? (elem.valueType.valueDescription)
         results << elem.valueAsString
       end
       return results

data/lib/measures/generic_qaqc/resources/check_supply_air_and_thermostat_temp_difference.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met:
@@ -50,11 +50,13 @@ module OsLib_QAQC
     else
       check_elems << OpenStudio::Attribute.new('description', "Check if fans modeled to ASHRAE 90.1 2013 Section G3.1.2.9 requirements. Compare the supply air temperature for each thermal zone against the thermostat setpoints. Throw flag if temperature difference excedes threshold set by #{@utility_name}.")
     end
-
+    check_elems << OpenStudio::Attribute.new('min_pass', max_delta)
+    
     # stop here if only name is requested this is used to populate display name for arguments
     if name_only == true
       results = []
       check_elems.each do |elem|
+        next if ['Double','Integer'].include? (elem.valueType.valueDescription)
         results << elem.valueAsString
       end
       return results

data/lib/measures/generic_qaqc/resources/check_weather_files.rb

@@ -1,5 +1,5 @@
 # *******************************************************************************
-# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
+# OpenStudio(R), Copyright (c) 2008-2021, Alliance for Sustainable Energy, LLC.
 # All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are met: