opal-rspec 0.5.0.beta2 → 0.5.0.beta3

data/opal/opal/rspec/formatter/html_printer.rb

@@ -0,0 +1,109 @@
+require_relative 'noop_flush_string_io'
+require_relative 'element'
+
+module Opal
+  module RSpec
+    class HtmlPrinter < ::RSpec::Core::Formatters::HtmlPrinter
+      def initialize(output)
+        super
+        @group_stack = []
+        @update_stack = []
+      end
+
+      def print_html_start
+        # Will output the header
+        super
+        # Now close out the doc so we can use DOM manipulation for the rest
+        @output.puts "</div>"
+        @output.puts "</div>"
+        @output.puts "</body>"
+        @output.puts "</html>"
+        @output.close
+        # From here, we'll do more direct DOM manipulation
+        reset_output
+        @root_node = Element.klass 'results'
+      end
+
+      def flush_output
+        node = @group_stack.last ? @group_stack.last : @root_node
+        new_node = Element.from_string(@output.string)
+        node.append new_node
+        reset_output
+      end
+
+      def reset_output
+        @output = NoopFlushStringIO.new
+      end
+
+      def print_example_group_start(group_id, description, number_of_parents)
+        super
+        @output.puts '</dl></div>'
+        parent_node = @group_stack.last ? @group_stack.last : @root_node
+        new_node = Element.from_string(@output.string)
+        reset_output
+        parent_node << new_node
+        @group_stack << new_node.get_child_by_tag_name('dl')
+        # We won't have this in the DOM until group ends, so need to queue up yellow/red updates
+        @update_stack << []
+      end
+
+      def print_example_group_end
+        @group_stack.pop
+        @update_stack.pop.each(&:call)
+      end
+
+      def print_example_passed(description, run_time)
+        super
+        flush_output
+      end
+
+      def print_example_failed(pending_fixed, description, run_time, failure_id, exception, extra_content, escape_backtrace=false)
+        super
+        flush_output
+      end
+
+      def print_example_pending(description, pending_message)
+        super
+        flush_output
+      end
+
+      def print_summary(duration, example_count, failure_count, pending_count)
+        # string mutation
+        totals = "#{example_count} example#{'s' unless example_count == 1}, "
+        totals += "#{failure_count} failure#{'s' unless failure_count == 1}"
+        totals += ", #{pending_count} pending" if pending_count > 0
+
+        formatted_duration = "%.5f" % duration
+        Element.id('duration').html = "Finished in <strong>#{formatted_duration} seconds</strong>"
+        Element.id('totals').html = totals
+      end
+
+      # Directly manipulate scripts here
+      def move_progress(percent_done)
+        `moveProgressBar(#{percent_done})`
+      end
+
+      def make_header_red
+        `makeRed('rspec-header')`
+      end
+
+      def make_header_yellow
+        `makeYellow('rspec-header')`
+      end
+
+      def make_example_group_header_red(group_id)
+        @update_stack.last << lambda do
+          `makeRed(#{"div_group_#{group_id}"})`
+          `makeRed(#{"example_group_#{group_id}"})`
+        end
+      end
+
+      def make_example_group_header_yellow(group_id)
+        @update_stack.last << lambda do
+          `makeYellow(#{"div_group_#{group_id}"})`
+          `makeYellow(#{"example_group_#{group_id}"})`
+        end
+      end
+    end
+  end
+end

data/opal/opal/rspec/formatter/noop_flush_string_io.rb

@@ -0,0 +1,9 @@
+module Opal
+  module RSpec
+    class NoopFlushStringIO < StringIO
+      # make printer happy
+      def flush
+      end
+    end
+  end
+end

data/opal/opal/rspec/formatter/opal_closed_tty_io.rb

@@ -0,0 +1,27 @@
+class OpalClosedTtyIO < IO
+  include IO::Writable
+
+  def initialize(runner_type, io_type)
+    raise "Unknown IO type #{io_type}!" unless [:stdout, :stderr].include?(io_type)
+    self.write_proc = case runner_type
+                        when :phantom
+                          `function(str){callPhantom([#{io_type}, str])}`
+                        when :node, :browser
+                          # opal io is already node aware, browser works as well, but we can't do anything about puts vs. print with the browser
+                          case io_type
+                            when :stdout
+                              $stdout.write_proc
+                            when :stderr
+                              $stderr.write_proc
+                          end
+                        else
+                          raise "Unknown runner type #{runner_type}"
+                      end
+    @tty = true
+  end
+
+  # We're deferring to stdout here, which doesn't need to be closed, but RSpec::BaseTextFormatter doesn't know that, so override this
+  def closed?
+    true
+  end
+end

data/opal/opal/rspec/pre_require_fixes.rb

@@ -2,3 +2,10 @@
 RUBY_DESCRIPTION = RUBY_VERSION unless defined?(RUBY_DESCRIPTION)
 
 class SecurityError < Exception; end unless defined?(SecurityError)
+
+# This completely changes the struct class, so need it before RSpec runs
+require_relative 'fixes/opal/compatibility'
+require_relative 'fixes/opal/corelib/struct'
+
+# RSpec code changes based on this
+require_relative 'fixes/rspec/support/ruby_features'

data/opal/opal/rspec/requires.rb

@@ -7,6 +7,7 @@ require 'diff/lcs/change'
 require 'diff/lcs/hunk'
 require 'diff/lcs/internals'
 require 'erb'
+require 'json'
 require 'optparse'
 require 'pathname'
 require 'pp'
@@ -25,9 +26,14 @@ require 'rspec/core/filter_manager'
 require 'rspec/core/flat_map'
 require 'rspec/core/formatters'
 require 'rspec/core/formatters/base_formatter'
+require 'rspec/core/formatters/base_text_formatter'
+require 'rspec/core/formatters/console_codes'
 require 'rspec/core/formatters/deprecation_formatter'
+require 'rspec/core/formatters/documentation_formatter'
 require 'rspec/core/formatters/helpers'
 require 'rspec/core/formatters/html_printer'
+require 'rspec/core/formatters/json_formatter'
+require 'rspec/core/formatters/progress_formatter'
 require 'rspec/core/hooks'
 require 'rspec/core/memoized_helpers'
 require 'rspec/core/metadata'
@@ -54,7 +60,33 @@ require 'rspec/expectations/version'
 require 'rspec/matchers'
 require 'rspec/matchers/aliased_matcher'
 require 'rspec/matchers/built_in'
+require 'rspec/matchers/built_in/all'
 require 'rspec/matchers/built_in/base_matcher'
+require 'rspec/matchers/built_in/be'
+require 'rspec/matchers/built_in/be_between'
+require 'rspec/matchers/built_in/be_instance_of'
+require 'rspec/matchers/built_in/be_kind_of'
+require 'rspec/matchers/built_in/be_within'
+require 'rspec/matchers/built_in/change'
+require 'rspec/matchers/built_in/compound'
+require 'rspec/matchers/built_in/contain_exactly'
+require 'rspec/matchers/built_in/cover'
+require 'rspec/matchers/built_in/eq'
+require 'rspec/matchers/built_in/eql'
+require 'rspec/matchers/built_in/equal'
+require 'rspec/matchers/built_in/exist'
+require 'rspec/matchers/built_in/has'
+require 'rspec/matchers/built_in/have_attributes'
+require 'rspec/matchers/built_in/include'
+require 'rspec/matchers/built_in/match'
+require 'rspec/matchers/built_in/operators'
+require 'rspec/matchers/built_in/output'
+require 'rspec/matchers/built_in/raise_error'
+require 'rspec/matchers/built_in/respond_to'
+require 'rspec/matchers/built_in/satisfy'
+require 'rspec/matchers/built_in/start_and_end_with'
+require 'rspec/matchers/built_in/throw_symbol'
+require 'rspec/matchers/built_in/yield'
 require 'rspec/matchers/composable'
 require 'rspec/matchers/dsl'
 require 'rspec/matchers/generated_descriptions'

data/opal/opal/rspec/runner.rb

@@ -1,72 +1,90 @@
-module Opal
-  module RSpec
-    class Runner
+require_relative 'formatter/opal_closed_tty_io'
 
-      class << self
-        def browser?
-          `typeof(document) !== "undefined"`
-        end
-
-        def phantom?
-          `typeof(phantom) !== 'undefined' || typeof(OPAL_SPEC_PHANTOM) !== 'undefined'`
-        end
-
-        def default_formatter
-          if phantom?
-            TextFormatter
-          else # browser
-            BrowserFormatter
-          end
-        end
+module ::RSpec::Core
+  class Runner
+    class << self
+      def browser?
+        `typeof(document) !== "undefined"`
+      end
 
-        def autorun          
-            Runner.new.run          
-        end
+      def phantom?
+        `typeof(phantom) !== 'undefined' || typeof(OPAL_SPEC_PHANTOM) !== 'undefined'`
       end
 
-      def initialize(options = {})
-        @options = options
-        @world = ::RSpec.world
-        @configuration = ::RSpec.configuration
+      def node?
+        `typeof(process) !== 'undefined' && typeof(process.versions) !== 'undefined'`
       end
 
-      def run(err=$stdout, out=$stdout)
-        @configuration.error_stream = err
-        @configuration.output_stream ||= out
+      def non_browser?
+        phantom? || node?
+      end
 
-        self.start
-        run_examples.then do          
-          self.finish
-        end        
+      def get_opal_closed_tty_io
+        runner_type = if phantom?
+                        :phantom
+                      elsif node?
+                        :node
+                      else
+                        :browser
+                      end
+        std_out = OpalClosedTtyIO.new runner_type,
+                                      :stdout
+        std_err = OpalClosedTtyIO.new runner_type,
+                                      :stderr
+        [std_err, std_out]
       end
 
-      def run_examples
-        @world.example_groups.inject(Promise.value) do |previous_promise, group|
-          previous_promise.then do
-            group.run @reporter
-          end
-        end        
-      end    
+      def autorun
+        # see NoCarriageReturnIO source for why this is being done (not on Node though)
+        err, out = get_opal_closed_tty_io
+        # Have to do this in 2 places. This will ensure the default formatter gets the right IO, but need to do this in config for custom formatters
+        # that will be constructed BEFORE this runs, see rspec.rb
+        run(ARGV, err, out).then do |status|
+          exit_with_code status.to_i
+        end
+      end
 
-      def config_hook(hook_when)
-        hook_context = ::RSpec::Core::SuiteHookContext.new
-        @configuration.hooks.run(hook_when, :suite, hook_context)
+      def exit_with_code(code)
+        # have to ignore OPAL_SPEC_PHANTOM for this one
+        if `typeof(phantom) !== "undefined"`
+          `phantom_exit(#{code})`
+        elsif node?
+          `process.exit(#{code})`
+        else
+          `Opal.global.OPAL_SPEC_CODE = #{code}`
+        end
       end
 
-      def config_hook(hook_when)
-        hook_context = ::RSpec::Core::SuiteHookContext.new
-        @configuration.hooks.run(hook_when, :suite, hook_context)
+      def run(args, err=$stderr, out=$stdout)
+        options = ConfigurationOptions.new(args)
+        new(options).run(err, out)
       end
+    end
 
-      def start
-        @reporter = @configuration.reporter
-        @reporter.start(@world.example_count)
-        config_hook :before
+    def run_groups_async(example_groups, reporter)
+      results = []
+      last_promise = example_groups.inject(Promise.value(true)) do |previous_promise, group|
+        previous_promise.then do |result|
+          results << result
+          group.run reporter
+        end
+      end
+      last_promise.then do |result|
+        results << result
+        results.all? ? 0 : @configuration.failure_exit_code
       end
+    end
 
-      def finish
-        config_hook :after
-        @reporter.finish
+    def run_specs(example_groups)
+      @configuration.reporter.report_async(@world.example_count(example_groups)) do |reporter|
+        hook_context = SuiteHookContext.new
+        Promise.value.then do
+          @configuration.hooks.run(:before, :suite, hook_context)
+          run_groups_async example_groups, reporter
+        end.ensure do |result|
+          @configuration.hooks.run(:after, :suite, hook_context)
+          result
+        end
       end
     end
   end

data/opal/opal/rspec/spec_opts.rb.erb

@@ -0,0 +1,28 @@
+<%
+    spec_opts = ENV['SPEC_OPTS']
+    if spec_opts && !spec_opts.empty?
+%>
+    RSpec.configure do |config|
+<%
+        if (match = /--(no-)?color\b/.match(spec_opts))
+            color_value = !match.captures[0]
+            # Have to use instance_variable_set because config.color= is designed to not allow overriding color once it's set, but
+            # we do not yet have true SPEC_OPTS parsing via RSpec config to get it initially set
+%>
+            config.instance_variable_set(:@color, <%=color_value.to_s%>)
+<%
+        end
+        if (requires = spec_opts.scan(/--require \S+/)).any?
+            requires.map {|r| /--require (.*)/.match(r).captures[0]}.each do |req| %>
+
+            require "<%= req %>"
+
+<%          end
+        end
+        if (match = /--format (\S+)/.match(spec_opts))
+            formatter = match.captures[0]
+%>
+            config.formatter = "<%=formatter%>"
+<%      end %>
+     end
+<% end %>

data/opal/opal/rspec/sprockets_runner.rb.erb

@@ -4,8 +4,10 @@
 require 'opal'
 require 'opal-rspec'
 
-<% Dir.glob('spec/**/*_spec.{rb,opal}').each do |s| %>
-require <%= s.sub(/^spec\//, '').sub(/\.(rb|opal)$/, '').inspect %>
+<%
+environment.get_opal_spec_requires.each do |s| %>
+require <%= s.inspect %>
 <% end %>
+require 'opal/rspec/spec_opts'
 
-Opal::RSpec::Runner.autorun
+::RSpec::Core::Runner.autorun

data/spec/mri/integration/browser_spec.rb

@@ -0,0 +1,31 @@
+require 'rspec'
+require 'capybara/rspec'
+require 'capybara-webkit'
+
+# Use Rack config exactly as shipped in the GEM
+Capybara.app = Rack::Builder.new_from_string(File.read('config.ru'))
+
+describe 'browser formatter', type: :feature do
+  RSpec.shared_examples :browser do |driver, error_fetcher|
+    context "in #{driver}", driver: driver do
+      before do
+        visit '/'
+        # Specs should run in 12 seconds but in case Travis takes longer, provide some cushion
+        Capybara.default_wait_time = 40
+      end
+
+      after do
+        js_errors = error_fetcher[page]
+        puts "Javascript errors: #{js_errors}" if js_errors.any?
+      end
+
+      it 'matches test results' do
+        expect(page).to have_content '142 examples, 40 failures, 12 pending'
+      end
+    end
+  end
+
+  # Travis version (4.x QT) might be causing this to fail
+  #include_examples :browser, :webkit, lambda {|page| page.driver.error_messages}
+  include_examples :browser, :selenium, lambda {|page| page.evaluate_script('window.jsErrors') }
+end

data/spec/mri/integration/rack/sprockets_runner_js_errors.rb.erb

@@ -0,0 +1,20 @@
+# This file is used by Opal::Server to basically load all spec files that
+# can be found in the spec/ directory.
+
+require 'opal'
+# Hard to capture errors w/ Selenium
+%x{
+  window.jsErrors = [];
+  window.onerror = function (errorMessage) {
+    window.jsErrors.push(errorMessage);
+  };
+}
+
+require 'opal-rspec'
+
+<%
+environment.get_opal_spec_requires.each do |s| %>
+require <%= s.inspect %>
+<% end %>
+require 'opal/rspec/spec_opts'
+::RSpec::Core::Runner.autorun