opal-rspec 0.5.0.beta2 → 0.5.0.beta3

data/spec/rspec/core/opal_alternates/rspec/core/memoized_helpers_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+module RSpec::Core
+  RSpec.describe 'Opal MemoizedHelpers' do
+    before(:each) { RSpec.configuration.configure_expectation_framework }
+
+    context "using 'self' as an explicit subject" do
+      it "delegates matcher to the ExampleGroup" do
+        group = ExampleGroup.describe("group") do
+          subject { self }
+          def ok?; true; end
+          def not_ok?; false; end
+
+          it { should eq(self) }
+          it { should be_ok }
+          it { should_not be_not_ok }
+        end
+
+        #expect(group.run).to be true
+        expect(group.run).to be_a Promise
+        expect(group.run.value).to be_truthy
+      end
+
+      it 'supports a new expect-based syntax' do
+        group = ExampleGroup.describe([1, 2, 3]) do
+          it { is_expected.to be_an Array }
+          it { is_expected.not_to include 4 }
+        end
+
+        #expect(group.run).to be true
+        expect(group.run).to be_a Promise
+        expect(group.run.value).to be_truthy
+      end
+    end
+  end
+end

data/spec/rspec/core/opal_alternates/rspec/core/metadata_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+module RSpec::Core
+  RSpec.describe 'Opal Metadata' do
+    describe "backwards compatibility" do
+      before { allow_deprecation }
+
+      describe ":example_group" do
+        it 'allows integration libraries like VCR to infer a fixture name from the example description by walking up nesting structure' do
+          fixture_name_for = lambda do |metadata|
+            description = metadata[:description]
+
+            if example_group = metadata[:example_group]
+              [fixture_name_for[example_group], description].join('/')
+            else
+              description
+            end
+          end
+
+          ex = inferred_fixture_name = nil
+
+          RSpec.configure do |config|
+            config.before(:example, :infer_fixture) { |e| inferred_fixture_name = fixture_name_for[e.metadata] }
+          end
+
+          # run returns a promise
+          # RSpec.describe "Group", :infer_fixture do
+          #   ex = example("ex") {}
+          # end.run
+          #
+          # raise ex.execution_result.exception if ex.execution_result.exception
+          #
+          # expect(inferred_fixture_name).to eq("Group/ex")
+
+          group = RSpec.describe "Group", :infer_fixture do
+            ex = example("ex") {}
+          end
+
+          group.run.then do
+            raise ex.execution_result.exception if ex.execution_result.exception
+
+            expect(inferred_fixture_name).to eq("Group/ex")
+          end
+        end
+      end
+    end
+  end
+end

data/spec/rspec/core/require_specs.rb

@@ -0,0 +1,25 @@
+class ::RSpec::Core::Ordering::Random
+  # there are a lot of these in the RSpec specs that create noise
+  HIDE_RANDOM_WARNINGS = true
+end
+
+# dealing with dynamic requires
+require 'rspec/support'
+require 'rspec/support/spec/deprecation_helpers'
+require 'rspec/support/spec/with_isolated_stderr'
+require 'rspec/support/spec/stderr_splitter'
+require 'rspec/support/spec/formatting_support'
+require 'rspec/support/spec/with_isolated_directory'
+require 'rspec/support/ruby_features'
+require 'support/shared_example_groups'
+require 'support/helper_methods'
+require 'support/matchers'
+require 'support/formatter_support'
+require 'sandboxing'
+require_relative 'fixes/missing_constants'
+require_relative 'fixes/shared_examples'
+require 'rspec/support/spec'
+require_relative 'config'
+require 'opal/fixes/deprecation_helpers'
+require 'opal/fixes/rspec_helpers'
+require_relative 'fixes/opal_itself'

data/spec/rspec/core/sandboxing.rb

@@ -0,0 +1,72 @@
+RSpec.configure do |c|
+  c.around { |ex| Sandboxing.sandboxed { ex.run } }
+end
+
+class NullObject
+  private
+  def method_missing(method, *args, &block)
+    # ignore
+  end
+end
+
+module Sandboxing
+  def self.sandboxed(&block)
+    # No load path in Opal
+    # orig_load_path = $LOAD_PATH.dup
+    orig_config = RSpec.configuration
+    orig_world  = RSpec.world
+    orig_example = RSpec.current_example
+    new_config = RSpec::Core::Configuration.new
+    new_config.expose_dsl_globally = false
+    new_config.expecting_with_rspec = true
+    new_world  = RSpec::Core::World.new(new_config)
+    RSpec.configuration = new_config
+    RSpec.world = new_world
+    object = Object.new
+    object.extend(RSpec::Core::SharedExampleGroup)
+
+    # Before https://github.com/opal/opal/commit/f73f766b261b881e6cd3256287b8afa28af99693, the stock class_exec won't work in Opal
+    # (class << RSpec::Core::ExampleGroup; self; end).class_exec do
+    #   alias_method :orig_run, :run
+    #   def run(reporter=nil)
+    #     RSpec.current_example = nil
+    #     orig_run(reporter || NullObject.new)
+    #   end
+    # end
+
+    RSpec::Core::ExampleGroup.class_eval do
+      class << self
+        alias_method :orig_run, :run
+
+        def run(reporter=nil)
+          RSpec.current_example = nil
+          orig_run(reporter || NullObject.new)
+        end
+      end
+    end
+
+    RSpec::Mocks.with_temporary_scope do
+      object.instance_exec(&block)
+    end
+  ensure
+    # See above comment
+    # (class << RSpec::Core::ExampleGroup; self; end).class_exec do
+    #   remove_method :run
+    #   alias_method :run, :orig_run
+    #   remove_method :orig_run
+    # end
+    RSpec::Core::ExampleGroup.class_eval do
+      class << self
+        remove_method :run
+        alias_method :run, :orig_run
+        remove_method :orig_run
+      end
+    end
+
+    RSpec.configuration = orig_config
+    RSpec.world = orig_world
+    RSpec.current_example = orig_example
+    # No load path in Opal
+    # $LOAD_PATH.replace(orig_load_path)
+  end
+end

data/spec/rspec/core/spec_files_exclude.txt

@@ -0,0 +1,41 @@
+# InSubProcess - requires forking
+**/dsl_spec.rb
+**/core/configuration_spec.rb
+**/shared_example_group_spec.rb
+
+# requires running services
+**/drb_spec.rb
+
+# opal does not like %W on line 107
+**/rspec/core/configuration_options_spec.rb
+
+# Nokogiri/filesystem heavy
+**/html_formatter_spec.rb
+
+# Coderay gem/opal
+**/snippet_extractor_spec.rb
+
+# Don't have Rake in Opal
+**/rake_task_spec.rb
+
+# Do not have the option parser std lib
+**/option_parser_spec.rb
+
+# We have to use our own runner anyways
+**/runner_spec.rb
+
+# uses heavy I/O
+**/order_spec.rb
+
+# I/O heavy test
+**/backtrace_formatter_spec.rb
+
+# Random - RSpec::Core::Backports::Random locks up the browser
+**/ordering_spec.rb
+**/random_spec.rb
+
+# I/O heavy and opal-rspec has to do its own initializing anyways
+**/project_initializer_spec.rb
+
+# profiling isn't supported on Opal
+**/profile_formatter_spec.rb

data/spec/rspec/expectations/config.rb

@@ -0,0 +1,16 @@
+require 'opal/progress_json_formatter' # verify case uses this
+
+RSpec::configure do |config|
+  config.color = true
+
+  config.include FormattingSupport
+  config.include RSpecHelpers
+
+  config.expect_with :rspec do |expectations|
+    $default_expectation_syntax = expectations.syntax
+    expectations.syntax = :expect
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  #config.full_description = 'RSpec::Matchers once required includes itself in Minitest::Test'
+end

data/spec/rspec/expectations/config.ru

@@ -0,0 +1,4 @@
+require 'opal/rspec'
+require_relative 'expectation_spec_loader'
+
+Opal::RSpec::ExpectationSpecLoader.run_rack_server self

data/spec/rspec/expectations/expectation_spec_loader.rb

@@ -0,0 +1,106 @@
+require_relative '../opal_rspec_spec_loader'
+
+module Opal
+  module RSpec
+    module ExpectationSpecLoader
+      extend Opal::RSpec::OpalRSpecSpecLoader
+
+      def self.expected_pending_count
+        0
+      end
+
+      def self.base_dir
+        'spec/rspec/expectations'
+      end
+
+      def self.spec_glob
+        %w{rspec-expectations/spec/**/*_spec.rb spec/rspec/expectations/opal_alternates/**/*_spec.rb}
+      end
+
+      def self.files_with_line_continue
+        [/matchers\/dsl_spec.rb/]
+      end
+
+      def self.files_with_multiline_regex
+        [/matchers\/built_in\/match_spec.rb/]
+      end
+
+      def self.post_requires
+        %w{fixes/example_patches.rb}
+      end
+
+      def self.sub_in_files
+        files = super
+        files = symbols_in_expectations files
+        files = integer_decimals files
+        anonymous_examples_operators files
+      end
+
+      def self.symbol_files
+        [
+            /respond_to_spec.rb/,
+            /include_spec.rb/,
+            /have_attributes_spec.rb/,
+            /has_spec.rb/,
+            /raise_error_spec.rb/
+        ]
+      end
+
+      def self.integer_float_files
+        [/be_within_spec.rb/]
+      end
+
+      def self.anonymous_examples_operators(files)
+        example_number = 0
+        replace_with_regex /specify do(.*?)end/m, 'anonymous examples we cannot filter', files, [/aliases_spec.rb/] do |match, temp_filename|
+          example_number += 1
+          body = match.captures[0]
+          contains_operator = /a_value [<>]/.match(body) || /a_value <=/.match(body)
+          next match.to_s unless contains_operator
+          fixed = "specify 'alias example #{example_number}' do\n#{body}\nend"
+          puts "#{temp_filename} - anonymous examples we cannot filter - replacing #{match.to_s} with #{fixed}"
+          fixed
+        end
+      end
+
+      def self.integer_decimals(files)
+        matching_exp = [
+            /fail_\w+\((.*)\)/,
+            /expect.*description\)\.to eq (.*)/
+        ]
+        # In Opal, 5.0 will be considered 5. Rather than muck with all of the code, any time we're expecting 5.0, just change it to 5
+        replace_with_regex matching_exp, 'expected integers when given integers', files, integer_float_files do |match, temp_filename|
+          integer_regex = /(\d+)\.0/
+          has_integers = integer_regex.match(match.captures[0])
+          next match.to_s unless has_integers
+          fixed = match.to_s.gsub(integer_regex, "\\1")
+          puts "#{temp_filename} - float/integer fix, replacing #{match.to_s} with #{fixed} in new temp file"
+          fixed
+        end
+      end
+
+      def self.stubbed_requires
+        [
+            'timeout', # not part of opal stdlib
+            'rubygems',
+            'simplecov', # hooks aren't available on Opal
+            'open3', # File I/O
+            'rake/file_utils', # Rake not around
+            'complex', # not part of opal stdlib
+            'rspec/support/spec/shell_out', # only does stuff Opal can't support anyways
+            'bigdecimal',
+        # 'aruba/api', # Cucumber lib that supports file creation during testing, N/A for us
+        # 'tmpdir',
+        # 'rspec/support/spec/shell_out', # only does stuff Opal can't support anyways
+        # 'rspec/support/spec/prevent_load_time_warnings'
+        ]
+      end
+
+      def self.additional_load_paths
+        [
+            'rspec-expectations/spec' # a few spec support files live outside of rspec-expectations/spec/rspec and live in support
+        ]
+      end
+    end
+  end
+end

data/spec/rspec/expectations/filter/bugs/aliased_matcher.txt

@@ -0,0 +1,2 @@
+# something w/ inheritance is wrong here
+RSpec::Matchers::AliasedMatcher can get a method object for delegated methods

data/spec/rspec/expectations/filter/bugs/aliases.rb

@@ -0,0 +1,13 @@
+rspec_filter 'aliases' do
+  unless at_least_opal_0_9?
+    # Opal is interpretting the == and === literally (as a boolean)
+    filter 'RSpec::Matchers should have an alias for "be == 3" with description: "a value == 3"'
+    filter 'RSpec::Matchers should have an alias for "be === 3" with description: "a value === 3"'
+
+    # https://github.com/opal/opal/pull/1136 - operators and method missing issues with a_value > < etc
+    # These are the specify matchers inside aliases_spec and they are poorly named, our rake task gives them a name for us
+    filter 'RSpec::Matchers alias example 6'
+    filter 'RSpec::Matchers alias example 7'
+    filter 'RSpec::Matchers alias example 8'
+  end
+end

data/spec/rspec/expectations/filter/bugs/base_matcher.txt

@@ -0,0 +1,2 @@
+# method owner doesn't fully work, so we can't count on these
+RSpec::Matchers::BuiltIn::BaseMatcher default failure message detection.*

data/spec/rspec/expectations/filter/bugs/be.rb

@@ -0,0 +1,4 @@
+rspec_filter 'be' do
+  # Maybe Numeric shouldn't == Fixnum but it does in Opal
+  filter('be_an_instance_of fails when class is higher up hierarchy').unless { at_least_opal_0_9? }
+end

data/spec/rspec/expectations/filter/bugs/be_instance_of.rb

@@ -0,0 +1,7 @@
+rspec_filter 'be_instance_of' do
+  unless at_least_opal_0_9?
+    # Maybe Numeric shouldn't == Fixnum but it does in Opal
+    filter('expect(actual).to be_an_instance_of(expected) fails if actual is instance of subclass of expected class')
+    filter('expect(actual).to be_instance_of(expected) fails if actual is instance of subclass of expected class')
+  end
+end

data/spec/rspec/expectations/filter/bugs/be_spec.txt

@@ -0,0 +1,2 @@
+# Depends on the DelegateClass working properly (and Opal's doesn't work right with respond_to?)
+arbitrary predicate with DelegateClass accesses methods defined in the delegating class.*

data/spec/rspec/expectations/filter/bugs/configuration.txt

@@ -0,0 +1,8 @@
+# in opal, currently can't undefine methods in a module when that module has been included in other classes (in this case, the example group) - see sandbox/undef.rb
+RSpec::Expectations::Configuration configuring rspec-expectations directly behaves like configuring the expectation syntax can limit the syntax to :should
+RSpec::Expectations::Configuration configuring rspec-expectations directly behaves like configuring the expectation syntax can limit the syntax to :expect
+RSpec::Expectations::Configuration configuring using the rspec-core config API behaves like configuring the expectation syntax can limit the syntax to :should
+RSpec::Expectations::Configuration configuring using the rspec-core config API behaves like configuring the expectation syntax can limit the syntax to :expect
+
+# global config problem
+RSpec::Expectations::Configuration#backtrace_formatter defaults to a null formatter when rspec-core is not loaded

data/spec/rspec/expectations/filter/bugs/contain_exactly.rb

@@ -0,0 +1,13 @@
+rspec_filter 'contain_exactly' do
+  # https://github.com/opal/opal/pull/1136 - operators and method missing issues with a_value > < etc
+  filter /should_not =~ \[:with, :multiple, :args\] fails when the arrays match.*/
+  unless at_least_opal_0_9?
+    filter('should =~ array when the array undefines `=~` still works')
+    filter('using contain_exactly with expect passes for an out of order valid positive expectation with hashes')
+    filter('using contain_exactly with expect passes for an in order valid positive expectation with hashes')
+  end
+  filter('should =~ array when the array defines a `send` method still works')
+  filter('should =~ array when the array defines a `=~` method delegates to that method rather than using the contain_exactly matcher')
+  filter('should =~ array fails an invalid positive expectation')
+  filter('should =~ array passes a valid positive expectation')
+end

data/spec/rspec/expectations/filter/bugs/define_negated_matcher.rb

@@ -0,0 +1,9 @@
+rspec_filter 'define_negated_matcher' do
+  # method owner (no issue/PR) and block (https://github.com/opal/opal/pull/1132)
+  filter('RSpec::Matchers.define_negated_matcher when the negated description is overriden overrides the failure message with the provided block')
+  filter('RSpec::Matchers.define_negated_matcher when the negated description is overriden overrides the description with the provided block').unless { at_least_opal_0_9? }
+  filter('RSpec::Matchers.define_negated_matcher when no block is passed when matched negatively fails matches against values that pass the original matcher')
+  filter('RSpec::Matchers.define_negated_matcher when no block is passed when matched positively fails matches against values that pass the original matcher')
+  filter('RSpec::Matchers.define_negated_matcher the failure message for a matcher with default failure messages when failing negatively uses the phrasing from the provided defined matcher alias')
+  filter('RSpec::Matchers.define_negated_matcher the failure message for a matcher with default failure messages when failing positively uses the phrasing from the provided defined matcher alias')
+end

data/spec/rspec/expectations/filter/bugs/description_generation.rb

@@ -0,0 +1,4 @@
+rspec_filter 'description_generation' do
+  # Probably related to https://github.com/opal/opal/pull/1117
+  filter('Matchers should be able to generate their own descriptions expect(...).to raise_error with type').unless { at_least_opal_0_9? }
+end

data/spec/rspec/expectations/filter/bugs/dsl.txt

@@ -0,0 +1,14 @@
+# probably due to an Opal bug in 0.8
+RSpec::Matchers::DSL::Matcher allows chainable methods to accept blocks
+
+# something w/ inheritance is wrong here
+RSpec::Matchers::DSL::Matcher defined using the dsl can get a method object for methods in the running example
+
+# probably class scoping issue since new_matcher creates a new DSL matcher class, probably https://github.com/opal/opal/issues/1110 related
+RSpec::Matchers::DSL::Matcher#match_unless_raises without a specified error class passes if no error is raised
+
+# not sure, class scoping issue? (see above)
+RSpec::Matchers::DSL::Matcher#match_unless_raises with an unexpected error raises the error
+RSpec::Matchers::DSL::Matcher#match_unless_raises with an assertion with passing assertion passes
+RSpec::Matchers::DSL::Matcher with an included module allows multiple modules to be included at once
+RSpec::Matchers::DSL::Matcher allows an early `return` to be used from a `match_unless_raises` block