opal-rspec 0.5.0.beta2 → 0.5.0.beta3

data/spec/rspec/expectations/opal_alternates/expectation_target_spec.rb

@@ -0,0 +1,21 @@
+describe 'Opal ExpectationTarget' do
+  context 'when constructed via #expect' do
+    it 'fails an invalid negative expectation' do
+      # Fixnum = Numeric on Opal
+      # message = /expected 5 not to be a kind of Fixnum/
+      message = /expected 5 not to be a kind of Num.*/
+      expect {
+        expect(5).not_to be_a(Fixnum)
+      }.to fail_with(message)
+    end
+
+    it 'fails an invalid negative expectation with a split infinitive' do
+      # Fixnum = Numeric on Opal
+      # message = /expected 5 not to be a kind of Fixnum/
+      message = /expected 5 not to be a kind of Num.*/
+      expect {
+        expect(5).to_not be_a(Fixnum)
+      }.to fail_with(message)
+    end
+  end
+end

data/spec/rspec/expectations/opal_alternates/yield_spec.rb

@@ -0,0 +1,11 @@
+describe 'Opal yield_successive_args matcher' do
+  include YieldHelpers
+  extend YieldHelpers
+
+  it 'has a description' do
+    expect(yield_successive_args(1, 3).description).to eq("yield successive args(1, 3)")
+    # symbols == string in opal
+    # expect(yield_successive_args([:a, 1], [:b, 2]).description).to eq("yield successive args([:a, 1], [:b, 2])")
+    expect(yield_successive_args([:a, 1], [:b, 2]).description).to eq('yield successive args(["a", 1], ["b", 2])')
+  end
+end

data/spec/rspec/expectations/require_specs.rb

@@ -0,0 +1,16 @@
+class ::RSpec::Core::Ordering::Random
+  # there are a lot of these in the RSpec specs that create noise
+  HIDE_RANDOM_WARNINGS = true
+end
+
+require_relative 'fixes/missing_constants'
+require_relative 'fixes/not_compatible'
+require_relative 'fixes/opal_itself'
+require_relative 'spec_helper_opal'
+require 'support/matchers'
+require 'rspec/support/spec/deprecation_helpers'
+require 'opal/fixes/deprecation_helpers'
+require 'opal/fixes/rspec_helpers'
+require_relative 'config'
+require_relative 'shared_examples'
+require 'support/shared_examples'

data/spec/rspec/expectations/shared_examples.rb

@@ -0,0 +1,47 @@
+RSpec.shared_context "with #should enabled", :uses_should do
+  orig_syntax = nil
+
+  before(:all) do
+    orig_syntax = RSpec::Matchers.configuration.syntax
+    RSpec::Matchers.configuration.syntax = [:expect, :should]
+  end
+
+  after(:context) do
+    RSpec::Matchers.configuration.syntax = orig_syntax
+  end
+end
+
+RSpec.shared_context "with the default expectation syntax" do
+  orig_syntax = nil
+
+  before(:context) do
+    orig_syntax = RSpec::Matchers.configuration.syntax
+    RSpec::Matchers.configuration.reset_syntaxes_to_default
+  end
+
+  after(:context) do
+    RSpec::Matchers.configuration.syntax = orig_syntax
+  end
+
+end
+
+RSpec.shared_context "with #should exclusively enabled", :uses_only_should do
+  orig_syntax = nil
+
+  before(:context) do
+    orig_syntax = RSpec::Matchers.configuration.syntax
+    RSpec::Matchers.configuration.syntax = :should
+  end
+
+  after(:context) do
+    RSpec::Matchers.configuration.syntax = orig_syntax
+  end
+end
+
+RSpec.shared_context "isolate include_chain_clauses_in_custom_matcher_descriptions" do
+  around do |ex|
+    orig = RSpec::Expectations.configuration.include_chain_clauses_in_custom_matcher_descriptions?
+    ex.run
+    RSpec::Expectations.configuration.include_chain_clauses_in_custom_matcher_descriptions = orig
+  end
+end

data/spec/rspec/expectations/spec_files_exclude.txt

@@ -0,0 +1,2 @@
+# opal-minispec integration not working yet
+**/minitest_integration_spec.rb

data/spec/rspec/expectations/spec_helper_opal.rb

@@ -0,0 +1,13 @@
+module FormattingSupport
+  def dedent(string)
+    string.gsub(/^\s+\|/, '').chomp
+  end
+end
+
+
+# Can't use subprocesses, etc.
+module MinitestIntegration
+  def with_minitest_loaded
+    yield
+  end
+end

data/spec/rspec/filter_processor.rb

@@ -0,0 +1,77 @@
+module Opal
+  module RSpec
+    module OpalVersionStuff
+      def at_least_opal_0_9?
+        # it's ok if we have a pre-release version
+        Gem::Dependency.new('opal', '>= 0.9').match?('opal', Gem::Version.new(opal_version).release.to_s)
+      end
+    end
+
+    class FilterProcessor
+      attr_reader :all_filters
+      attr_accessor :filename
+
+      include OpalVersionStuff
+
+      class GuardCheck
+        attr_reader :opal_version
+
+        include Opal::RSpec::OpalVersionStuff
+
+        def initialize(current_filters, opal_version)
+          @current_filters = current_filters
+          @opal_version = opal_version
+        end
+
+        def unless(&block)
+          result = instance_eval(&block)
+          remove_filter if result
+        end
+
+        def if(&block)
+          result = instance_eval(&block)
+          remove_filter unless result
+        end
+
+        private
+
+        def remove_filter
+          @current_filters.pop
+          nil
+        end
+      end
+
+      def initialize
+        @all_filters = []
+        @current_title = nil
+        @current_filters = []
+      end
+
+      def rspec_filter(title)
+        @current_filters = []
+        @current_title = title
+        yield
+        @all_filters += @current_filters.map do |filter|
+          filter.merge({title: @current_title})
+        end
+      end
+
+      def filter(value)
+        call_info = caller[0]
+        line_number = /.*:(\d+)/.match(call_info).captures[0]
+        @current_filters << {
+            filename: filename,
+            line_number: line_number,
+            exclusion: value
+        }
+        GuardCheck.new(@current_filters, opal_version)
+      end
+
+      private
+
+      def opal_version
+        Opal::VERSION
+      end
+    end
+  end
+end

data/spec/rspec/mocks/config.ru

@@ -0,0 +1,4 @@
+require 'opal/rspec'
+require_relative 'mocks_spec_loader'
+
+Opal::RSpec::MocksSpecLoader.run_rack_server self

data/spec/rspec/mocks/filter/bugs/and_call_original.txt

@@ -0,0 +1,9 @@
+# any_instance related
+and_call_original on a partial double when using any_instance works for instance methods defined on the class
+and_call_original on a partial double when using any_instance works for instance methods defined on the superclass of the class
+and_call_original on a partial double when using any_instance works when mocking the method on one class and calling the method on an instance of a subclass
+and_call_original on a partial double on an object that defines method_missing works for an any_instance partial mock
+and_call_original on a partial double on an object that defines method_missing raises an error for an unhandled message for an any_instance partial mock
+
+# SimpleDelegator
+and_call_original on a partial double for singleton methods works for SimpleDelegator subclasses

data/spec/rspec/mocks/filter/bugs/and_wrap_original.txt

@@ -0,0 +1,2 @@
+# This seems to be returning the correct method but something with method equality might be broken
+and_wrap_original on a partial double passes in the original method

data/spec/rspec/mocks/filter/bugs/any_instance.rb

@@ -0,0 +1,24 @@
+rspec_filter filter '#any_instance' do
+  filter '#any_instance when used after the test has finished restores the original behaviour, even if the expectation fails'
+  filter '#any_instance when used after the test has finished restores the original behavior of a stubbed method'
+  filter '#any_instance when directed at a method defined on a superclass mocks the method correctly'
+  filter '#any_instance when resetting post-verification existing method with stubbing private methods restores a stubbed private method after the spec is run'
+  filter '#any_instance when resetting post-verification existing method with expectations private methods restores a stubbed private method after the spec is run'
+  filter '#any_instance passing the receiver to the implementation block when configured to pass the instance an any instance stub does not pass the instance to and_call_original'
+  filter '#any_instance setting a message expectation with an expectation is set on a method that exists after any one instance has received a message fails if the method is invoked on a second instance'
+  filter "#any_instance setting a message expectation with an expectation is set on a method which does not exist behaves as 'exactly one instance' fails if the method is invoked on a second instance"
+  filter('#any_instance setting a message expectation works with a SimpleDelegator subclass').unless { at_least_opal_0_9? }
+  filter "#any_instance when stubbing behaves as 'every instance' handles freeze and duplication correctly"
+  filter "#any_instance when stubbing behaves as 'every instance' handles method restoration on subclasses"
+  filter /#any_instance when stubbing with #and_call_original and competing #with can combine and_call_original, with, and_return.*/
+  filter("#any_instance when stubbing with #and_raise can stub a method that doesn't exist").unless { at_least_opal_0_9? }
+  filter('#any_instance when stubbing with #and_raise can stub a method that exists').unless { at_least_opal_0_9? }
+  filter '#any_instance when stubbing when partially mocking objects resets partially mocked objects correctly'
+  filter '#any_instance unstubbing using `and_call_original` replaces the stubbed method with the original method'
+  filter '#any_instance unstubbing using `and_call_original` removes all stubs with the supplied method name'
+  filter '#any_instance unstubbing using `and_call_original` removes stubs even if they have already been invoked'
+  filter '#any_instance unstubbing using `and_call_original` removes stubs from sub class after invokation when super class was originally stubbed'
+  filter '#any_instance unstubbing using `and_call_original` removes any stubs set directly on an instance'
+  filter '#any_instance unstubbing using `and_call_original` does not get confused about string vs symbol usage for the message'
+  filter("#any_instance when stubbing behaves as 'every instance' handles stubbing on super and subclasses").if { at_least_opal_0_9? }
+end

data/spec/rspec/mocks/filter/bugs/argument_matchers.rb

@@ -0,0 +1,3 @@
+rspec_filter 'argument_matchers' do
+  filter('argument matchers matching duck_type matches duck type with two methods').unless { at_least_opal_0_9? }
+end

data/spec/rspec/mocks/filter/bugs/configuration.txt

@@ -0,0 +1,2 @@
+# can't change expect/should right now due to undef/Opal
+RSpec::Mocks::Configuration.*configuring the syntax.*

data/spec/rspec/mocks/filter/bugs/double.txt

@@ -0,0 +1,3 @@
+# arity/block
+RSpec::Mocks::Double yields 0 args.*
+RSpec::Mocks::Double yields many args.*

data/spec/rspec/mocks/filter/bugs/expiration.txt

@@ -0,0 +1,2 @@
+# class_double issues
+After a test double has been torn down for a class_double.*

data/spec/rspec/mocks/filter/bugs/instance_method_stasher.txt

@@ -0,0 +1,2 @@
+# some sort of inheritance problem, not sure what
+RSpec::Mocks::InstanceMethodStasher only stashes methods directly defined on the given class, not its ancestors

data/spec/rspec/mocks/filter/bugs/methods.rb

@@ -0,0 +1,5 @@
+rspec_filter 'methods' do
+  # can't change expect/should right now due to undef/Opal until 0.9
+  filter('Methods added to every object limits the number of methods that get added to all objects').unless { at_least_opal_0_9? }
+end
+

data/spec/rspec/mocks/filter/bugs/mocks.txt

@@ -0,0 +1,6 @@
+# any_instance
+RSpec::Mocks.with_temporary_scope in a before\(:all\) with an any_instance stub does not allow the double to be used in the examples
+RSpec::Mocks.with_temporary_scope in a before\(:all\) with an any_instance stub does not allow the double to be used after the scope in before\(:all\)
+
+# current issue with bridged classes (string in this case) and mocking
+RSpec::Mocks.teardown does not put rspec-mocks into an inconsistent state when called extra times

data/spec/rspec/mocks/filter/bugs/mutate_const.txt

@@ -0,0 +1,2 @@
+# a lof of constants functionality broken on Opal
+Constant Mutating.*

data/spec/rspec/mocks/filter/bugs/partial_double.rb

@@ -0,0 +1,8 @@
+rspec_filter 'partial double' do
+  # super/inheritance problems prevent verifying partial doubles except in cases where and_call_original is used
+  filter 'when verify_partial_doubles configuration option is set allows the mock to raise an error with yield'
+  filter 'when verify_partial_doubles configuration option is set allows stubbing and calls the stubbed implementation'
+
+  # not sure what's broken here on 0.8
+  filter(/Using a partial mock on a proxy object.*/).unless { at_least_opal_0_9? }
+end

data/spec/rspec/mocks/filter/bugs/receive.txt

@@ -0,0 +1,5 @@
+# can't change expect/should right now due to undef/Opal
+RSpec::Mocks::Matchers::Receive when used in a test framework without rspec-expectations can toggle the available syntax
+
+RSpec::Mocks::Matchers::Receive expect\(...\).to receive behaves like an expect syntax expectation behaves like a receive matcher allows chaining off a `do...end` block implementation to be provided
+RSpec::Mocks::Matchers::Receive allow\(...\).to receive behaves like an expect syntax allowance behaves like a receive matcher allows chaining off a `do...end` block implementation to be provided

data/spec/rspec/mocks/filter/bugs/should_syntax.txt

@@ -0,0 +1,5 @@
+# issues with any_instance on Opal
+Using the legacy should syntax #any_instance.*
+
+# stubbing a class method
+Using the legacy should syntax #unstub restores the correct implementations when stubbed and unstubbed on a parent and child class

data/spec/rspec/mocks/filter/bugs/space.txt

@@ -0,0 +1,2 @@
+# any_instance
+RSpec::Mocks::Space#any_instance_recorder_for returns the recorder for the given class

data/spec/rspec/mocks/filter/bugs/spy.txt

@@ -0,0 +1,5 @@
+# ClassVerifyingDouble inheriting from Module to support transferring nested constants, but that doesn't work on Opal
+the spy family of methods class_spy.*
+
+# depends on proper initializer behavior in ObjectVerifyingDoubleMethods
+the spy family of methods object_spy.*

data/spec/rspec/mocks/filter/bugs/stub_implementation.rb

@@ -0,0 +1,9 @@
+rspec_filter 'stub implementation' do
+  # stubs class methods
+  filter('unstubbing with `and_call_original` when partial doubles are verified restores the correct implementations when stubbed and unstubbed on a grandparent and grandchild class')
+      .unless { at_least_opal_0_9? }
+  filter('unstubbing with `and_call_original` when partial doubles are verified restores the correct implementations when stubbed and unstubbed on a parent and child class')
+      .unless { at_least_opal_0_9? }
+  filter('unstubbing with `and_call_original` when partial doubles are not verified restores the correct implementations when stubbed and unstubbed on a grandparent and grandchild class')
+  filter('unstubbing with `and_call_original` when partial doubles are not verified restores the correct implementations when stubbed and unstubbed on a parent and child class')
+end

data/spec/rspec/mocks/filter/unsupported/and_call_original.txt

@@ -0,0 +1,5 @@
+# arity
+and_call_original on a partial double errors when you pass through the wrong number of args
+
+# backtrace/line #
+and_call_original on a partial double warns when you override an existing implementation

data/spec/rspec/mocks/filter/unsupported/and_return.txt

@@ -0,0 +1,2 @@
+# arity checking disabled, so not catching this
+and_return when no argument is passed raises ArgumentError

data/spec/rspec/mocks/filter/unsupported/any_instance.rb

@@ -0,0 +1,6 @@
+rspec_filter 'any_instance' do
+  # Mock strings
+  filter '#any_instance when stubbing core ruby objects works with the non-standard constructor ""'
+  filter "#any_instance when stubbing core ruby objects works with the non-standard constructor ''"
+  filter '#any_instance setting a message expectation does not set the expectation on every instance'
+end

data/spec/rspec/mocks/filter/unsupported/argument_matchers.rb

@@ -0,0 +1,10 @@
+rspec_filter 'argument_matchers' do
+  # Fixnum == Float on Opal
+  filter 'argument matchers matching handling non-matcher arguments fails a class against an object of a different type'
+  filter('argument matchers matching instance_of handles non matching instances nicely').unless { at_least_opal_0_9? }
+  filter('argument matchers matching instance_of does NOT accept float as instance_of(Numeric)').unless { at_least_opal_0_9? }
+  filter('argument matchers matching instance_of does NOT accept fixnum as instance_of(Numeric)').unless { at_least_opal_0_9? }
+
+  # symbols and strings are different to this example but they are the same in Opal
+  filter 'argument matchers matching handling non-matcher arguments fails for a hash w/ wrong keys'
+end

data/spec/rspec/mocks/filter/unsupported/combining_implementation_instructions.rb

@@ -0,0 +1,9 @@
+rspec_filter 'combining_implementation_instructions' do
+  # Opal 0.8 does not support catch
+  filter('Combining implementation instructions can combine and_yield and and_throw').unless { at_least_opal_0_9? }
+  filter('Combining implementation instructions can combine and_yield, a block implementation and and_throw').unless { at_least_opal_0_9? }
+  filter('Combining implementation instructions allows the terminal action to be overriden').unless { at_least_opal_0_9? }
+
+  # line # / backtrace
+  filter 'Combining implementation instructions warns when the inner implementation block is overriden'
+end

data/spec/rspec/mocks/filter/unsupported/double.rb

@@ -0,0 +1,16 @@
+rspec_filter 'double' do
+  # private methods
+  filter "RSpec::Mocks::Double does not respond_to? method_missing (because it's private)"
+
+  # backtrace/line number
+  filter /RSpec::Mocks::Double reports line number of expectation of unreceived message.*/
+
+  # depends on eval
+  filter 'RSpec::Mocks::Double fails when calling yielding method with invalid kw args'
+
+  # throw not supported on Opal 0.8
+  filter('RSpec::Mocks::Double throws when told to').unless { at_least_opal_0_9? }
+
+  # private methods
+  filter('RSpec::Mocks::Double has method_missing as private')
+end

data/spec/rspec/mocks/filter/unsupported/expected_arg_verification.txt

@@ -0,0 +1,2 @@
+# arity doesn't work right with default args on Opal
+Expected argument verification \(when `#with` is called\) when doubling a loaded class when `no_args` is used allows a method expectation on a method that has defaults for all arguments

data/spec/rspec/mocks/filter/unsupported/have_received.txt

@@ -0,0 +1,2 @@
+# symbols == strings
+RSpec::Mocks::Matchers::HaveReceived expect\(...\).to have_received ordered when used on individually allowed messages fails when the messages are received out of order

data/spec/rspec/mocks/filter/unsupported/instance_double_with_class_loaded.txt

@@ -0,0 +1,8 @@
+# depends on private methods
+An instance double with the doubled class loaded gives a descriptive error message for NoMethodError
+An instance double with the doubled class loaded for null objects reports that it responds to protected methods when the appropriate arg is passed
+An instance double with the doubled class loaded for null objects reports that it responds to defined private methods when the appropriate arg is passed
+An instance double with the doubled class loaded for null objects includes the double's name in a private method error
+
+# arity, Opal can't tell the difference between send(*) and send() right now
+An instance double with the doubled class loaded allows `send` to be stubbed if it is defined on the class

data/spec/rspec/mocks/filter/unsupported/mocks.rb

@@ -0,0 +1,8 @@
+rspec_filter 'mocks' do
+  # Dir usage
+  filter 'RSpec::Mocks behaves like a library that issues no warnings when loaded issues no warnings when loaded'
+
+  # string mocking
+  filter 'RSpec::Mocks.teardown resets method stubs'
+  filter 'RSpec::Mocks.with_temporary_scope in a before(:all) with an any_instance stub allows the stub to be used'
+end

data/spec/rspec/mocks/filter/unsupported/nil_expectation_warning.rb

@@ -0,0 +1,8 @@
+rspec_filter 'nil_expectation_warning' do
+  # marshal not supported on Opal, other issues were fixed in 0.9 that allow this to pass
+  filter('#allow_message_expectations_on_nil does not affect subsequent examples').unless { at_least_opal_0_9? }
+  filter '#allow_message_expectations_on_nil doesnt error when marshalled'
+
+  # backtrace / line number
+  filter 'an expectation set on nil issues a warning with file and line number information'
+end

data/spec/rspec/mocks/filter/unsupported/partial_double.rb

@@ -0,0 +1,6 @@
+rspec_filter 'partial_double' do
+  # not sure what broke this on 0.8. public_methods impl?
+  filter('Method visibility when using partial mocks keeps public methods public').unless { at_least_opal_0_9? }
+  filter 'Method visibility when using partial mocks keeps private methods private'
+  filter 'Method visibility when using partial mocks keeps protected methods protected'
+end

data/spec/rspec/mocks/filter/unsupported/receive.txt

@@ -0,0 +1,13 @@
+# frozen and Opal
+RSpec::Mocks::Matchers::Receive expect\(...\).to receive behaves like resets partial mocks cleanly on a frozen object includes the spec location in the warning
+RSpec::Mocks::Matchers::Receive expect\(...\).to receive behaves like resets partial mocks cleanly on a frozen object warns about being unable to remove the method double
+RSpec::Mocks::Matchers::Receive allow\(...\).to receive behaves like resets partial mocks cleanly on a frozen object includes the spec location in the warning
+
+# line #
+RSpec::Mocks::Matchers::Receive expect\(...\).to receive behaves like an expect syntax expectation reports the line number of expectation of unreceived message
+RSpec::Mocks::Matchers::Receive allow\(...\).to receive behaves like resets partial mocks cleanly on a frozen object warns about being unable to remove the method double
+
+# Fixnum and Float will be considered the same in Opal
+RSpec::Mocks::Matchers::Receive expect\(...\).to receive behaves like an expect syntax expectation behaves like a receive matcher allows the caller to constrain the received arguments by matcher
+RSpec::Mocks::Matchers::Receive allow\(...\).to receive behaves like an expect syntax allowance behaves like a receive matcher allows the caller to constrain the received arguments by matcher
+RSpec::Mocks::Matchers::Receive expect\(...\).to receive behaves like an expect syntax expectation sets up a message expectation that formats argument matchers correctly