omnibus 5.4.0 → 5.5.0

data/spec/unit/publishers/s3_publisher_spec.rb

@@ -1,36 +1,36 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Omnibus
   describe S3Publisher do
-    let(:path) { '/path/to/files/*.deb' }
+    let(:path) { "/path/to/files/*.deb" }
 
     let(:package) do
       double(Package,
-        path: '/path/to/files/chef.deb',
-        name: 'chef.deb',
-        content: 'BINARY',
-        validate!: true,
+        path: "/path/to/files/chef.deb",
+        name: "chef.deb",
+        content: "BINARY",
+        validate!: true
       )
     end
 
     let(:metadata) do
       Metadata.new(package,
-        name: 'chef',
-        friendly_name: 'Chef',
-        homepage: 'https://getchef.com',
-        version: '11.0.6',
-        basename: 'chef.deb',
-        platform: 'ubuntu',
-        platform_version: '14.04',
-        arch: 'x86_64',
-        sha1: 'SHA1',
-        md5: 'ABCDEF123456',
+        name: "chef",
+        friendly_name: "Chef",
+        homepage: "https://getchef.com",
+        version: "11.0.6",
+        basename: "chef.deb",
+        platform: "ubuntu",
+        platform_version: "14.04",
+        arch: "x86_64",
+        sha1: "SHA1",
+        md5: "ABCDEF123456"
       )
     end
 
     let(:packages) { [package] }
 
-    let(:client) { double('Aws::S3::Resource') }
+    let(:client) { double("Aws::S3::Resource") }
 
     before do
       allow(package).to receive(:metadata).and_return(metadata)
@@ -43,65 +43,65 @@ module Omnibus
     describe '#publish' do
       before { allow(subject).to receive(:packages).and_return(packages) }
 
-      it 'validates the package' do
+      it "validates the package" do
         expect(package).to receive(:validate!).once
         subject.publish
       end
 
-      it 'uploads the metadata' do
+      it "uploads the metadata" do
         expect(subject).to receive(:store_object).with(
-          'ubuntu/14.04/x86_64/chef.deb/chef.deb.metadata.json',
+          "ubuntu/14.04/x86_64/chef.deb/chef.deb.metadata.json",
           FFI_Yajl::Encoder.encode(package.metadata.to_hash, pretty: true),
           nil,
-          'private',
+          "private"
         ).once
 
         subject.publish
       end
 
-      it 'uploads the package' do
+      it "uploads the package" do
         expect(subject).to receive(:store_object).with(
-          'ubuntu/14.04/x86_64/chef.deb/chef.deb',
+          "ubuntu/14.04/x86_64/chef.deb/chef.deb",
           package.content,
           package.metadata[:md5],
-          'private'
+          "private"
         ).once
 
         subject.publish
       end
 
-      context 'when the upload is set to public' do
-        subject { described_class.new(path, acl: 'public') }
+      context "when the upload is set to public" do
+        subject { described_class.new(path, acl: "public") }
 
-        it 'sets the access control to public_read' do
+        it "sets the access control to public_read" do
           expect(subject).to receive(:store_object).with(
-            'ubuntu/14.04/x86_64/chef.deb/chef.deb.metadata.json',
+            "ubuntu/14.04/x86_64/chef.deb/chef.deb.metadata.json",
             FFI_Yajl::Encoder.encode(package.metadata.to_hash, pretty: true),
             nil,
-            'public-read',
+            "public-read"
           ).once
 
           subject.publish
         end
       end
 
-      context 'when the upload is set to a nonsensical value' do
-        subject { described_class.new(path, acl: 'baconbits') }
+      context "when the upload is set to a nonsensical value" do
+        subject { described_class.new(path, acl: "baconbits") }
 
-        it 'sets the access control to private' do
+        it "sets the access control to private" do
           expect(subject).to receive(:store_object).with(
-            'ubuntu/14.04/x86_64/chef.deb/chef.deb.metadata.json',
+            "ubuntu/14.04/x86_64/chef.deb/chef.deb.metadata.json",
             FFI_Yajl::Encoder.encode(package.metadata.to_hash, pretty: true),
             nil,
-            'private',
+            "private"
           ).once
 
           subject.publish
         end
       end
 
-      context 'when a block is given' do
-        it 'yields the package to the block' do
+      context "when a block is given" do
+        it "yields the package to the block" do
           block = ->(package) { package.do_something! }
           expect(package).to receive(:do_something!).once
           subject.publish(&block)

data/spec/unit/s3_cacher_spec.rb

@@ -1,29 +1,29 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Omnibus
   describe S3Cache do
     let(:ruby_19) do
-      double('ruby_19',
-        name: 'ruby',
-        version: '1.9.3',
+      double("ruby_19",
+        name: "ruby",
+        version: "1.9.3",
         fetcher: double(Fetcher,
-          checksum: 'abcd1234',
-        ),
+          checksum: "abcd1234"
+        )
       )
     end
 
     let(:python_27) do
-      double('python',
-        name: 'python',
-        version: '2.7',
+      double("python",
+        name: "python",
+        version: "2.7",
         fetcher: double(Fetcher,
-          checksum: 'defg5678',
-        ),
+          checksum: "defg5678"
+        )
       )
     end
 
-    describe '.list' do
-      let(:keys) { %w(ruby-1.9.3-abcd1234 python-2.7.defg5678) }
+    describe ".list" do
+      let(:keys) { %w{ruby-1.9.3-abcd1234 python-2.7.defg5678} }
       let(:softwares) { [ruby_19, python_27] }
 
       before do
@@ -31,25 +31,25 @@ module Omnibus
         allow(S3Cache).to receive(:softwares).and_return(softwares)
       end
 
-      it 'lists the software that is cached on S3' do
+      it "lists the software that is cached on S3" do
         expect(S3Cache.list).to include(ruby_19)
         expect(S3Cache.list).to_not include(python_27)
       end
     end
 
-    describe '.keys' do
+    describe ".keys" do
       let(:bucket) { double(:bucket, objects: []) }
 
       before { allow(S3Cache).to receive(:bucket).and_return(bucket) }
 
-      it 'lists the keys on the S3 bucket' do
+      it "lists the keys on the S3 bucket" do
         expect(bucket).to receive(:objects).once
         S3Cache.keys
       end
     end
 
-    describe '.missing' do
-      let(:keys) { %w(ruby-1.9.3-abcd1234 python-2.7.defg5678) }
+    describe ".missing" do
+      let(:keys) { %w{ruby-1.9.3-abcd1234 python-2.7.defg5678} }
       let(:softwares) { [ruby_19, python_27] }
 
       before do
@@ -57,22 +57,22 @@ module Omnibus
         allow(S3Cache).to receive(:softwares).and_return(softwares)
       end
 
-      it 'lists the software that is cached on S3' do
+      it "lists the software that is cached on S3" do
         expect(S3Cache.missing).to_not include(ruby_19)
         expect(S3Cache.missing).to include(python_27)
       end
     end
 
-    describe '.populate' do
-      it 'pending a good samaritan to come along and write tests...'
+    describe ".populate" do
+      it "pending a good samaritan to come along and write tests..."
     end
 
-    describe '.fetch_missing' do
+    describe ".fetch_missing" do
       let(:softwares) { [ruby_19, python_27] }
 
       before { allow(S3Cache).to receive(:missing).and_return(softwares) }
 
-      it 'fetches the missing software' do
+      it "fetches the missing software" do
         expect(ruby_19).to receive(:fetch)
         expect(python_27).to receive(:fetch)
 
@@ -80,30 +80,30 @@ module Omnibus
       end
     end
 
-    describe '.key_for' do
-      context 'when the package does not have a name' do
-        it 'raises an exception' do
+    describe ".key_for" do
+      context "when the package does not have a name" do
+        it "raises an exception" do
           expect { S3Cache.key_for(double(name: nil)) }
             .to raise_error(InsufficientSpecification)
         end
       end
 
-      context 'when the package does not have a version' do
-        it 'raises an exception' do
-          expect { S3Cache.key_for(double(name: 'ruby', version: nil)) }
+      context "when the package does not have a version" do
+        it "raises an exception" do
+          expect { S3Cache.key_for(double(name: "ruby", version: nil)) }
             .to raise_error(InsufficientSpecification)
         end
       end
 
-      context 'when the package does not have a checksum' do
-        it 'raises an exception' do
-          expect { S3Cache.key_for(double(name: 'ruby', version: '1.9.3', fetcher: double(Fetcher, checksum: nil))) }
+      context "when the package does not have a checksum" do
+        it "raises an exception" do
+          expect { S3Cache.key_for(double(name: "ruby", version: "1.9.3", fetcher: double(Fetcher, checksum: nil))) }
             .to raise_error(InsufficientSpecification)
         end
       end
 
-      it 'returns the correct string' do
-        expect(S3Cache.key_for(ruby_19)).to eq('ruby-1.9.3-abcd1234')
+      it "returns the correct string" do
+        expect(S3Cache.key_for(ruby_19)).to eq("ruby-1.9.3-abcd1234")
       end
     end
   end

data/spec/unit/s3_helpers_spec.rb

@@ -1,5 +1,5 @@
-require 'spec_helper'
-require 'omnibus/s3_helpers'
+require "spec_helper"
+require "omnibus/s3_helpers"
 
 module Omnibus
   describe S3Helpers do
@@ -7,12 +7,12 @@ module Omnibus
 
     context 'when #s3_configuration is not defined' do
       describe '#client' do
-        it 'raises an error if it is not overridden' do
+        it "raises an error if it is not overridden" do
           expect { s3_configuration }.to raise_error(RuntimeError,
                                                      "You must override s3_configuration")
         end
 
-        it 'raises an error stating that s3_configuration must be overriden' do
+        it "raises an error stating that s3_configuration must be overriden" do
           expect { client }.to raise_error(RuntimeError,
                                            "You must override s3_configuration")
         end
@@ -21,10 +21,10 @@ module Omnibus
 
     describe '#to_base64_digest' do
       it 'turns "c3b5247592ce694f7097873aa07d66fe" into "w7UkdZLOaU9wl4c6oH1m/g=="' do
-        expect(to_base64_digest("c3b5247592ce694f7097873aa07d66fe")).to eql('w7UkdZLOaU9wl4c6oH1m/g==')
+        expect(to_base64_digest("c3b5247592ce694f7097873aa07d66fe")).to eql("w7UkdZLOaU9wl4c6oH1m/g==")
       end
 
-      it 'allows a nil input without error' do
+      it "allows a nil input without error" do
         expect(to_base64_digest(nil)).to be_nil
       end
     end

data/spec/unit/semantic_version_spec.rb

@@ -13,13 +13,13 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-require 'spec_helper'
+require "spec_helper"
 
 module Omnibus
   describe SemanticVersion do
 
     it "raises an InvalidVersion error if it doesn't understand the format" do
-      expect {Omnibus::SemanticVersion.new("wut")}.to raise_error(Omnibus::InvalidVersion)
+      expect { Omnibus::SemanticVersion.new("wut") }.to raise_error(Omnibus::InvalidVersion)
     end
 
     it "preserves leading the leading v when printing the string" do