omnibus 5.4.0 → 5.5.0

data/spec/functional/fetchers/git_fetcher_spec.rb

@@ -1,12 +1,12 @@
-require 'spec_helper'
-require 'omnibus/manifest_entry'
+require "spec_helper"
+require "omnibus/manifest_entry"
 
 module Omnibus
   describe GitFetcher do
-    include_examples 'a software'
+    include_examples "a software"
 
-    let(:remote)  { remote_git_repo('zlib') }
-    let(:version) { 'master' }
+    let(:remote)  { remote_git_repo("zlib") }
+    let(:version) { "master" }
 
     let(:source) do
       { git: remote }
@@ -14,42 +14,42 @@ module Omnibus
 
     let(:manifest_entry) do
       double(ManifestEntry,
-        name: 'software',
-        locked_version: '45ded6d3b1a35d66ed866b2c3eb418426e6382b0',
+        name: "software",
+        locked_version: "45ded6d3b1a35d66ed866b2c3eb418426e6382b0",
         described_version: version,
         locked_source: source)
     end
 
     subject { described_class.new(manifest_entry, project_dir, build_dir) }
-    
-    let(:revision) { shellout!('git rev-parse HEAD', cwd: project_dir).stdout.strip }
+
+    let(:revision) { shellout!("git rev-parse HEAD", cwd: project_dir).stdout.strip }
 
     describe '#fetch_required?' do
-      context 'when the repo is not cloned' do
-        it 'return true' do
+      context "when the repo is not cloned" do
+        it "return true" do
           expect(subject.fetch_required?).to be_truthy
         end
       end
 
-      context 'when the repo is cloned' do
+      context "when the repo is cloned" do
         before { subject.fetch }
 
-        context 'when the revision is not available' do
+        context "when the revision is not available" do
           let(:manifest_entry) do
             double(ManifestEntry,
-              name: 'software',
-              locked_version: 'abcdefabcdef5d66ed866b2c3eb418426e6382b0',
+              name: "software",
+              locked_version: "abcdefabcdef5d66ed866b2c3eb418426e6382b0",
               described_version: version,
               locked_source: source)
           end
 
-          it 'return true' do
+          it "return true" do
             expect(subject.fetch_required?).to be_truthy
           end
         end
 
-        context 'when the revisions are the same' do
-          it 'return false' do
+        context "when the revisions are the same" do
+          it "return false" do
             expect(subject.fetch_required?).to be(false)
           end
         end
@@ -57,7 +57,7 @@ module Omnibus
     end
 
     describe '#version_guid' do
-      it 'includes the current revision' do
+      it "includes the current revision" do
         expect(subject.version_guid).to match(/^git:[0-9a-f]{40}/)
       end
     end
@@ -67,12 +67,12 @@ module Omnibus
         subject.fetch
       end
 
-      it 'returns true' do
+      it "returns true" do
         expect(subject.clean).to be_truthy
       end
 
-      context 'when the project directory has extra files in it' do
-        it 'cleans the git repo' do
+      context "when the project directory has extra files in it" do
+        it "cleans the git repo" do
           create_file("#{project_dir}/file_a")
           create_file("#{project_dir}/.file_b")
           subject.clean
@@ -81,117 +81,115 @@ module Omnibus
         end
       end
 
-      context 'when the project directory is at a different version' do
+      context "when the project directory is at a different version" do
         before do
           # Dirty the project_dir by giving it a conflicting commit.
-          create_file("#{project_dir}/file_a") { 'some new file' }
-          create_file("#{project_dir}/configure") { 'LALALALA' }
-          shellout!('git add .', cwd: project_dir)
+          create_file("#{project_dir}/file_a") { "some new file" }
+          create_file("#{project_dir}/configure") { "LALALALA" }
+          shellout!("git add .", cwd: project_dir)
           shellout!('git commit -am "Some commit"', cwd: project_dir)
           create_file("#{project_dir}/.file_b")
         end
 
-        it 'checks out the right version' do
+        it "checks out the right version" do
           subject.clean
           expect(revision).to eq(manifest_entry.locked_version)
         end
 
-        it 'resets the working tree' do
+        it "resets the working tree" do
           subject.clean
           expect("#{project_dir}/file_a").to_not be_a_file
           expect("#{project_dir}/.file_b").to_not be_a_file
-          expect(File.read("#{project_dir}/configure")).to_not match('LA')
+          expect(File.read("#{project_dir}/configure")).to_not match("LA")
         end
       end
     end
 
     describe '#fetch'  do
-      let(:version)  { 'v1.2.4' }
-      let(:remote)   { remote_git_repo('zlib', annotated_tags: [version]) }
+      let(:version)  { "v1.2.4" }
+      let(:remote)   { remote_git_repo("zlib", annotated_tags: [version]) }
       let(:manifest_entry) do
         double(ManifestEntry,
-               name: 'software',
-               locked_version: 'efde208366abd0f91419d8a54b45e3f6e0540105',
+               name: "software",
+               locked_version: "efde208366abd0f91419d8a54b45e3f6e0540105",
                described_version: version,
                locked_source: source)
       end
 
       subject { described_class.new(manifest_entry, project_dir, build_dir) }
 
-
-      it 'clones the repository' do
+      it "clones the repository" do
         subject.fetch
         expect("#{project_dir}/.git").to be_a_directory
       end
     end
 
-
     describe '#resolve_version' do
-      context 'when the version is a tag' do
-        let(:version)  { 'v1.2.3' }
-        let(:remote)   { remote_git_repo('zlib', tags: [version]) }
+      context "when the version is a tag" do
+        let(:version)  { "v1.2.3" }
+        let(:remote)   { remote_git_repo("zlib", tags: [version]) }
 
-        it 'parses the tag' do
-          expect(GitFetcher.resolve_version(version, source)).to eq('53c72c4abcc961b153996f5b5f402ce715e47146')
+        it "parses the tag" do
+          expect(GitFetcher.resolve_version(version, source)).to eq("53c72c4abcc961b153996f5b5f402ce715e47146")
         end
       end
 
-      context 'when the version is an annnotated tag' do
-        let(:version)  { 'v1.2.4' }
-        let(:remote)   { remote_git_repo('zlib', annotated_tags: [version]) }
+      context "when the version is an annnotated tag" do
+        let(:version)  { "v1.2.4" }
+        let(:remote)   { remote_git_repo("zlib", annotated_tags: [version]) }
 
-        it 'it defererences and parses the annotated tag' do
-          expect(GitFetcher.resolve_version(version, source)).to eq('efde208366abd0f91419d8a54b45e3f6e0540105')
+        it "it defererences and parses the annotated tag" do
+          expect(GitFetcher.resolve_version(version, source)).to eq("efde208366abd0f91419d8a54b45e3f6e0540105")
         end
       end
 
-      context 'when the version is a branch' do
-        let(:version) { 'sethvargo/magic_ponies' }
-        let(:remote)  { remote_git_repo('zlib', branches: [version]) }
+      context "when the version is a branch" do
+        let(:version) { "sethvargo/magic_ponies" }
+        let(:remote)  { remote_git_repo("zlib", branches: [version]) }
 
-        it 'parses the branch' do
-          expect(GitFetcher.resolve_version(version, source)).to eq('171a1aec35ac0a050f8dccd9c9ef4609b1d8d8ea')
+        it "parses the branch" do
+          expect(GitFetcher.resolve_version(version, source)).to eq("171a1aec35ac0a050f8dccd9c9ef4609b1d8d8ea")
         end
       end
 
-      context 'when the version is a full SHA-1' do
-        let(:version) { '45ded6d3b1a35d66ed866b2c3eb418426e6382b0' }
-        let(:remote)  { remote_git_repo('zlib') }
+      context "when the version is a full SHA-1" do
+        let(:version) { "45ded6d3b1a35d66ed866b2c3eb418426e6382b0" }
+        let(:remote)  { remote_git_repo("zlib") }
 
-        it 'parses the full SHA-1' do
-          expect(GitFetcher.resolve_version(version, source)).to eq('45ded6d3b1a35d66ed866b2c3eb418426e6382b0')
+        it "parses the full SHA-1" do
+          expect(GitFetcher.resolve_version(version, source)).to eq("45ded6d3b1a35d66ed866b2c3eb418426e6382b0")
         end
       end
 
-      context 'when the version is a abbreviated SHA-1' do
-        let(:version) { '45ded6d' }
-        let(:remote)  { remote_git_repo('zlib') }
+      context "when the version is a abbreviated SHA-1" do
+        let(:version) { "45ded6d" }
+        let(:remote)  { remote_git_repo("zlib") }
 
-        it 'parses the abbreviated SHA-1' do
-          expect(GitFetcher.resolve_version(version, source)).to eq('45ded6d')
+        it "parses the abbreviated SHA-1" do
+          expect(GitFetcher.resolve_version(version, source)).to eq("45ded6d")
         end
       end
 
-      context 'when the version is a non-existent ref' do
-        let(:version) { 'fufufufufu' }
-        let(:remote)  { remote_git_repo('zlib') }
+      context "when the version is a non-existent ref" do
+        let(:version) { "fufufufufu" }
+        let(:remote)  { remote_git_repo("zlib") }
 
-        it 'raise an exception' do
+        it "raise an exception" do
           expect { GitFetcher.resolve_version(version, source) }.to raise_error(UnresolvableGitReference)
         end
       end
     end
 
     describe '#version_for_cache' do
-      it 'includes the resolved revision' do
-        expect(subject.version_for_cache).to eq('revision:45ded6d3b1a35d66ed866b2c3eb418426e6382b0')
+      it "includes the resolved revision" do
+        expect(subject.version_for_cache).to eq("revision:45ded6d3b1a35d66ed866b2c3eb418426e6382b0")
       end
 
-      it 'not use the current version on disk after fetching' do
-        expect(subject.version_for_cache).to eq('revision:45ded6d3b1a35d66ed866b2c3eb418426e6382b0')
+      it "not use the current version on disk after fetching" do
+        expect(subject.version_for_cache).to eq("revision:45ded6d3b1a35d66ed866b2c3eb418426e6382b0")
         subject.fetch
-        expect(subject.version_for_cache).to eq('revision:45ded6d3b1a35d66ed866b2c3eb418426e6382b0')
-        expect(revision).to_not eq('revision:45ded6d3b1a35d66ed866b2c3eb418426e6382b0')
+        expect(subject.version_for_cache).to eq("revision:45ded6d3b1a35d66ed866b2c3eb418426e6382b0")
+        expect(revision).to_not eq("revision:45ded6d3b1a35d66ed866b2c3eb418426e6382b0")
       end
     end
   end

data/spec/functional/fetchers/net_fetcher_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Omnibus
   module RSpec
@@ -10,52 +10,52 @@ module Omnibus
   end
 
   describe NetFetcher do
-    include_examples 'a software', 'zlib'
+    include_examples "a software", "zlib"
 
-    let(:source_url) { 'http://downloads.sourceforge.net/project/libpng/zlib/1.2.8/zlib-1.2.8.tar.gz' }
-    let(:source_md5) { '44d667c142d7cda120332623eab69f40' }
-    let(:source_sha1) { 'a4d316c404ff54ca545ea71a27af7dbc29817088' }
-    let(:source_sha256) { '36658cb768a54c1d4dec43c3116c27ed893e88b02ecfcb44f2166f9c0b7f2a0d' }
-    let(:source_sha512) { 'ece209d4c7ec0cb58ede791444dc754e0d10811cbbdebe3df61c0fd9f9f9867c1c3ccd5f1827f847c005e24eef34fb5bf87b5d3f894d75da04f1797538290e4a' }
+    let(:source_url) { "http://downloads.sourceforge.net/project/libpng/zlib/1.2.8/zlib-1.2.8.tar.gz" }
+    let(:source_md5) { "44d667c142d7cda120332623eab69f40" }
+    let(:source_sha1) { "a4d316c404ff54ca545ea71a27af7dbc29817088" }
+    let(:source_sha256) { "36658cb768a54c1d4dec43c3116c27ed893e88b02ecfcb44f2166f9c0b7f2a0d" }
+    let(:source_sha512) { "ece209d4c7ec0cb58ede791444dc754e0d10811cbbdebe3df61c0fd9f9f9867c1c3ccd5f1827f847c005e24eef34fb5bf87b5d3f894d75da04f1797538290e4a" }
 
     let(:source) do
       { url: source_url, md5: source_md5 }
     end
 
     let(:downloaded_file) { subject.send(:downloaded_file) }
-    let(:extracted) { File.join(source_dir, 'zlib-1.2.8') }
+    let(:extracted) { File.join(source_dir, "zlib-1.2.8") }
 
     let(:fetch!) { capture_stdout { subject.fetch } }
 
     let(:manifest_entry) do
       double(ManifestEntry,
-             name: 'software',
-             locked_version: '1.2.8',
-             described_version: '1.2.8',
+             name: "software",
+             locked_version: "1.2.8",
+             described_version: "1.2.8",
              locked_source: source)
     end
 
     subject { described_class.new(manifest_entry, project_dir, build_dir) }
 
     describe '#fetch_required?' do
-      context 'when the file is not downloaded' do
-        it 'return true' do
+      context "when the file is not downloaded" do
+        it "return true" do
           expect(subject.fetch_required?).to be_truthy
         end
       end
 
-      context 'when the file is downloaded' do
+      context "when the file is downloaded" do
         before { fetch! }
 
-        context 'when the checksum is different' do
-          it 'return true' do
-            allow(subject).to receive(:checksum).and_return('abcd1234')
+        context "when the checksum is different" do
+          it "return true" do
+            allow(subject).to receive(:checksum).and_return("abcd1234")
             expect(subject.fetch_required?).to be_truthy
           end
         end
 
-        context 'when the checksum is the same' do
-          it 'return false' do
+        context "when the checksum is the same" do
+          it "return false" do
             expect(subject.fetch_required?).to be(false)
           end
         end
@@ -63,38 +63,38 @@ module Omnibus
     end
 
     describe '#version_guid' do
-      context 'source with md5' do
-        it 'includes the md5 digest' do
+      context "source with md5" do
+        it "includes the md5 digest" do
           expect(subject.version_guid).to eq("md5:#{source_md5}")
         end
       end
 
-      context 'source with sha1' do
+      context "source with sha1" do
         let(:source) do
           { url: source_url, sha1: source_sha1 }
         end
 
-        it 'includes the sha1 digest' do
+        it "includes the sha1 digest" do
           expect(subject.version_guid).to eq("sha1:#{source_sha1}")
         end
       end
 
-      context 'source with sha256' do
+      context "source with sha256" do
         let(:source) do
           { url: source_url, sha256: source_sha256 }
         end
 
-        it 'includes the sha256 digest' do
+        it "includes the sha256 digest" do
           expect(subject.version_guid).to eq("sha256:#{source_sha256}")
         end
       end
 
-      context 'source with sha512' do
+      context "source with sha512" do
         let(:source) do
           { url: source_url, sha512: source_sha512 }
         end
 
-        it 'includes the sha512 digest' do
+        it "includes the sha512 digest" do
           expect(subject.version_guid).to eq("sha512:#{source_sha512}")
         end
       end
@@ -103,36 +103,36 @@ module Omnibus
     describe '#clean' do
       before { fetch! }
 
-      context 'when the project directory exists' do
+      context "when the project directory exists" do
         before do
           create_file("#{project_dir}/file_a")
         end
 
-        it 'extracts the asset' do
+        it "extracts the asset" do
           subject.clean
           expect(extracted).to_not be_a_file
         end
 
-        it 'returns true' do
+        it "returns true" do
           expect(subject.clean).to be_truthy
         end
       end
 
-      context 'when the project directory does not exist' do
+      context "when the project directory does not exist" do
         before do
           remove_directory(project_dir)
         end
 
-        it 'returns false' do
+        it "returns false" do
           expect(subject.clean).to be(false)
         end
       end
 
-      context 'when the source has read-only files' do
-        let(:source_url) { 'http://dl.bintray.com/oneclick/OpenKnapsack/x86/openssl-1.0.0q-x86-windows.tar.lzma' }
-        let(:source_md5) { '577dbe528415c6f178a9431fd0554df4' }
-        
-        it 'extracts the asset without crashing' do
+      context "when the source has read-only files" do
+        let(:source_url) { "http://dl.bintray.com/oneclick/OpenKnapsack/x86/openssl-1.0.0q-x86-windows.tar.lzma" }
+        let(:source_md5) { "577dbe528415c6f178a9431fd0554df4" }
+
+        it "extracts the asset without crashing" do
           subject.clean
           expect(extracted).to_not be_a_file
           subject.clean
@@ -140,15 +140,15 @@ module Omnibus
         end
       end
 
-      context 'when the source has broken symlinks' do
-        let(:source_url) { 'http://www.openssl.org/source/openssl-1.0.1q.tar.gz' }
-        let(:source_md5) { '54538d0cdcb912f9bc2b36268388205e' }
+      context "when the source has broken symlinks" do
+        let(:source_url) { "http://www.openssl.org/source/openssl-1.0.1q.tar.gz" }
+        let(:source_md5) { "54538d0cdcb912f9bc2b36268388205e" }
 
         let(:source) do
           { url: source_url, md5: source_md5, extract: :lax_tar }
         end
 
-        it 'extracts the asset without crashing' do
+        it "extracts the asset without crashing" do
           subject.clean
           expect(extracted).to_not be_a_file
           subject.clean
@@ -158,89 +158,89 @@ module Omnibus
     end
 
     describe '#fetch' do
-      context 'source with md5' do
-        it 'downloads the file' do
+      context "source with md5" do
+        it "downloads the file" do
           fetch!
           expect(downloaded_file).to be_a_file
         end
 
-        context 'when the checksum is invalid' do
-          let(:source_md5) { 'bad01234checksum' }
+        context "when the checksum is invalid" do
+          let(:source_md5) { "bad01234checksum" }
 
-          it 'raises an exception' do
+          it "raises an exception" do
             expect { fetch! }.to raise_error(ChecksumMismatch)
           end
         end
       end
 
-      context 'source with no checksum' do
+      context "source with no checksum" do
         let(:source) do
           { url: source_url }
         end
 
-        it 'raises an exception' do
+        it "raises an exception" do
           expect { fetch! }.to raise_error(ChecksumMissing)
         end
       end
 
-      context 'source with sha1' do
+      context "source with sha1" do
         let(:source) do
           { url: source_url, sha1: source_sha1 }
         end
 
-        it 'downloads the file' do
+        it "downloads the file" do
           fetch!
           expect(downloaded_file).to be_a_file
         end
 
-        context 'when the checksum is invalid' do
-          let(:source_sha1) { 'bad01234checksum' }
+        context "when the checksum is invalid" do
+          let(:source_sha1) { "bad01234checksum" }
 
-          it 'raises an exception' do
+          it "raises an exception" do
             expect { fetch! }.to raise_error(ChecksumMismatch)
           end
         end
       end
 
-      context 'source with sha256' do
+      context "source with sha256" do
         let(:source) do
           { url: source_url, sha256: source_sha256 }
         end
 
-        it 'downloads the file' do
+        it "downloads the file" do
           fetch!
           expect(downloaded_file).to be_a_file
         end
 
-        context 'when the checksum is invalid' do
-          let(:source_sha256) { 'bad01234checksum' }
+        context "when the checksum is invalid" do
+          let(:source_sha256) { "bad01234checksum" }
 
-          it 'raises an exception' do
+          it "raises an exception" do
             expect { fetch! }.to raise_error(ChecksumMismatch)
           end
         end
       end
 
-      context 'source with sha512' do
+      context "source with sha512" do
         let(:source) do
           { url: source_url, sha512: source_sha512 }
         end
 
-        it 'downloads the file' do
+        it "downloads the file" do
           fetch!
           expect(downloaded_file).to be_a_file
         end
 
-        context 'when the checksum is invalid' do
-          let(:source_sha512) { 'bad01234checksum' }
+        context "when the checksum is invalid" do
+          let(:source_sha512) { "bad01234checksum" }
 
-          it 'raises an exception' do
+          it "raises an exception" do
             expect { fetch! }.to raise_error(ChecksumMismatch)
           end
         end
       end
 
-      it 'when the download times out' do
+      it "when the download times out" do
         # Mock the Timeout::Error for this particular test only
         WebMock.disable_net_connect!
         stub_request(:get, "http://downloads.sourceforge.net/project/libpng/zlib/1.2.8/zlib-1.2.8.tar.gz").to_timeout
@@ -248,17 +248,17 @@ module Omnibus
           expect { subject.send(:download) }.to raise_error(Timeout::Error)
         end
 
-        expect(output).to include('Retrying failed download')
-        expect(output).to include('Download failed')
-        retry_count = output.scan('Retrying failed download').count
+        expect(output).to include("Retrying failed download")
+        expect(output).to include("Download failed")
+        retry_count = output.scan("Retrying failed download").count
         expect(retry_count).to eq(Omnibus::Config.fetcher_retries)
       end
 
-      context 'when the file is less than 10240 bytes' do
-        let(:source_url) { 'https://downloads.chef.io/packages-chef-io-public.key' }
-        let(:source_md5) { '369efc3a19b9118cdf51c7e87a34f266' }
+      context "when the file is less than 10240 bytes" do
+        let(:source_url) { "https://downloads.chef.io/packages-chef-io-public.key" }
+        let(:source_md5) { "369efc3a19b9118cdf51c7e87a34f266" }
 
-        it 'downloads the file' do
+        it "downloads the file" do
           fetch!
           expect(downloaded_file).to be_a_file
         end
@@ -272,38 +272,38 @@ module Omnibus
         create_file("#{project_dir}/.file_c")
       end
 
-      context 'source with md5' do
-        it 'includes the download_url and checksum' do
+      context "source with md5" do
+        it "includes the download_url and checksum" do
           expect(subject.version_for_cache).to eq("download_url:#{source_url}|md5:#{source_md5}")
         end
       end
 
-      context 'source with sha1' do
+      context "source with sha1" do
         let(:source) do
           { url: source_url, sha1: source_sha1 }
         end
 
-        it 'includes the download_url and checksum' do
+        it "includes the download_url and checksum" do
           expect(subject.version_for_cache).to eq("download_url:#{source_url}|sha1:#{source_sha1}")
         end
       end
 
-      context 'source with sha256' do
+      context "source with sha256" do
         let(:source) do
           { url: source_url, sha256: source_sha256 }
         end
 
-        it 'includes the download_url and checksum' do
+        it "includes the download_url and checksum" do
           expect(subject.version_for_cache).to eq("download_url:#{source_url}|sha256:#{source_sha256}")
         end
       end
 
-      context 'source with sha512' do
+      context "source with sha512" do
         let(:source) do
           { url: source_url, sha512: source_sha512 }
         end
 
-        it 'includes the download_url and checksum' do
+        it "includes the download_url and checksum" do
           expect(subject.version_for_cache).to eq("download_url:#{source_url}|sha512:#{source_sha512}")
         end
       end