omnibus 5.4.0 → 5.5.0

data/spec/unit/packagers/deb_spec.rb

@@ -1,15 +1,15 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Omnibus
   describe Packager::DEB do
     let(:project) do
       Project.new.tap do |project|
-        project.name('project')
-        project.homepage('https://example.com')
-        project.install_dir('/opt/project')
-        project.build_version('1.2.3')
-        project.build_iteration('2')
-        project.maintainer('Chef Software')
+        project.name("project")
+        project.homepage("https://example.com")
+        project.install_dir("/opt/project")
+        project.build_version("1.2.3")
+        project.build_iteration("2")
+        project.maintainer("Chef Software")
         project.license(project_license) if project_license
       end
     end
@@ -17,9 +17,9 @@ module Omnibus
     subject { described_class.new(project) }
 
     let(:project_license) { nil }
-    let(:project_root) { File.join(tmp_path, 'project/root') }
-    let(:package_dir)  { File.join(tmp_path, 'package/dir') }
-    let(:staging_dir)  { File.join(tmp_path, 'staging/dir') }
+    let(:project_root) { File.join(tmp_path, "project/root") }
+    let(:package_dir)  { File.join(tmp_path, "package/dir") }
+    let(:staging_dir)  { File.join(tmp_path, "staging/dir") }
 
     before do
       Config.project_root(project_root)
@@ -31,87 +31,87 @@ module Omnibus
     end
 
     describe '#vendor' do
-      it 'is a DSL method' do
+      it "is a DSL method" do
         expect(subject).to have_exposed_method(:vendor)
       end
 
-      it 'has a default value' do
-        expect(subject.vendor).to eq('Omnibus <omnibus@getchef.com>')
+      it "has a default value" do
+        expect(subject.vendor).to eq("Omnibus <omnibus@getchef.com>")
       end
 
-      it 'must be a string' do
+      it "must be a string" do
         expect { subject.vendor(Object.new) }.to raise_error(InvalidValue)
       end
     end
 
     describe '#license' do
-      it 'is a DSL method' do
+      it "is a DSL method" do
         expect(subject).to have_exposed_method(:license)
       end
 
-      it 'has a default value' do
-        expect(subject.license).to eq('Unspecified')
+      it "has a default value" do
+        expect(subject.license).to eq("Unspecified")
       end
 
-      it 'must be a string' do
+      it "must be a string" do
         expect { subject.license(Object.new) }.to raise_error(InvalidValue)
       end
 
-      context 'with project license' do
-        let(:project_license) { 'custom-license' }
+      context "with project license" do
+        let(:project_license) { "custom-license" }
 
-        it 'uses project license' do
-          expect(subject.license).to eq('custom-license')
+        it "uses project license" do
+          expect(subject.license).to eq("custom-license")
         end
       end
     end
 
     describe '#priority' do
-      it 'is a DSL method' do
+      it "is a DSL method" do
         expect(subject).to have_exposed_method(:priority)
       end
 
-      it 'has a default value' do
-        expect(subject.priority).to eq('extra')
+      it "has a default value" do
+        expect(subject.priority).to eq("extra")
       end
 
-      it 'must be a string' do
+      it "must be a string" do
         expect { subject.priority(Object.new) }.to raise_error(InvalidValue)
       end
     end
 
     describe '#section' do
-      it 'is a DSL method' do
+      it "is a DSL method" do
         expect(subject).to have_exposed_method(:section)
       end
 
-      it 'has a default value' do
-        expect(subject.section).to eq('misc')
+      it "has a default value" do
+        expect(subject.section).to eq("misc")
       end
 
-      it 'must be a string' do
+      it "must be a string" do
         expect { subject.section(Object.new) }.to raise_error(InvalidValue)
       end
     end
 
     describe '#id' do
-      it 'is :deb' do
+      it "is :deb" do
         expect(subject.id).to eq(:deb)
       end
     end
 
     describe '#package_name' do
       before do
-        allow(subject).to receive(:safe_architecture).and_return('amd64')
+        allow(subject).to receive(:safe_architecture).and_return("amd64")
       end
 
-      it 'includes the name, version, and build iteration' do
-        expect(subject.package_name).to eq('project_1.2.3-2_amd64.deb')
+      it "includes the name, version, and build iteration" do
+        expect(subject.package_name).to eq("project_1.2.3-2_amd64.deb")
       end
     end
 
     describe '#debian_dir' do
-      it 'is nested inside the staging_dir' do
+      it "is nested inside the staging_dir" do
         expect(subject.debian_dir).to eq("#{staging_dir}/DEBIAN")
       end
     end
@@ -121,12 +121,12 @@ module Omnibus
         allow(subject).to receive(:safe_architecture).and_return("amd64")
       end
 
-      it 'generates the file' do
+      it "generates the file" do
         subject.write_control_file
         expect("#{staging_dir}/DEBIAN/control").to be_a_file
       end
 
-      it 'has the correct content' do
+      it "has the correct content" do
         subject.write_control_file
         contents = File.read("#{staging_dir}/DEBIAN/control")
 
@@ -146,25 +146,25 @@ module Omnibus
 
     describe '#write_conffiles_file' do
       before do
-        project.config_file('/opt/project/file1')
-        project.config_file('/opt/project/file2')
+        project.config_file("/opt/project/file1")
+        project.config_file("/opt/project/file2")
       end
 
-      context 'when there are no files' do
+      context "when there are no files" do
         before { project.config_files.clear }
 
-        it 'does not render the file' do
+        it "does not render the file" do
           subject.write_conffiles_file
           expect("#{staging_dir}/DEBIAN/conffiles").to_not be_a_file
         end
       end
 
-      it 'generates the file' do
+      it "generates the file" do
         subject.write_conffiles_file
         expect("#{staging_dir}/DEBIAN/conffiles").to be_a_file
       end
 
-      it 'has the correct content' do
+      it "has the correct content" do
         subject.write_conffiles_file
         contents = File.read("#{staging_dir}/DEBIAN/conffiles")
 
@@ -181,7 +181,7 @@ module Omnibus
         create_file("#{project_root}/package-scripts/project/postrm") { "postrm" }
       end
 
-      it 'copies the scripts into the DEBIAN dir with permissions = 100755', :not_supported_on_windows do
+      it "copies the scripts into the DEBIAN dir with permissions = 100755", :not_supported_on_windows do
         subject.write_scripts
 
         expect("#{staging_dir}/DEBIAN/preinst").to be_a_file
@@ -189,13 +189,13 @@ module Omnibus
         expect("#{staging_dir}/DEBIAN/prerm").to be_a_file
         expect("#{staging_dir}/DEBIAN/postrm").to be_a_file
 
-        expect("#{staging_dir}/DEBIAN/preinst").to have_permissions '100755'
-        expect("#{staging_dir}/DEBIAN/postinst").to have_permissions '100755'
-        expect("#{staging_dir}/DEBIAN/prerm").to have_permissions '100755'
-        expect("#{staging_dir}/DEBIAN/postrm").to have_permissions '100755'
+        expect("#{staging_dir}/DEBIAN/preinst").to have_permissions "100755"
+        expect("#{staging_dir}/DEBIAN/postinst").to have_permissions "100755"
+        expect("#{staging_dir}/DEBIAN/prerm").to have_permissions "100755"
+        expect("#{staging_dir}/DEBIAN/postrm").to have_permissions "100755"
       end
 
-      it 'logs a message' do
+      it "logs a message" do
         output = capture_logging do
           subject.write_scripts
         end
@@ -216,12 +216,12 @@ module Omnibus
         create_file("#{staging_dir}/DEBIAN/postrm") { "postrm" }
       end
 
-      it 'generates the file' do
+      it "generates the file" do
         subject.write_md5_sums
         expect("#{staging_dir}/DEBIAN/md5sums").to be_a_file
       end
 
-      it 'has the correct content' do
+      it "has the correct content" do
         subject.write_md5_sums
         contents = File.read("#{staging_dir}/DEBIAN/md5sums")
 
@@ -241,18 +241,18 @@ module Omnibus
         allow(subject).to receive(:safe_architecture).and_return("amd64")
       end
 
-      it 'logs a message' do
+      it "logs a message" do
         output = capture_logging { subject.create_deb_file }
-        expect(output).to include('Creating .deb file')
+        expect(output).to include("Creating .deb file")
       end
 
-      it 'executes the command using `fakeroot`' do
+      it "executes the command using `fakeroot`" do
         expect(subject).to receive(:shellout!)
           .with(/\Afakeroot/)
         subject.create_deb_file
       end
 
-      it 'uses the correct command' do
+      it "uses the correct command" do
         expect(subject).to receive(:shellout!)
           .with(/dpkg-deb -z9 -Zgzip -D --build/)
         subject.create_deb_file
@@ -267,25 +267,25 @@ module Omnibus
         create_file("#{staging_dir}/file2") { "2" * 20_000 }
       end
 
-      it 'stats all the files in the install_dir' do
+      it "stats all the files in the install_dir" do
         expect(subject.package_size).to eq(29)
       end
     end
 
     describe '#safe_base_package_name' do
       context 'when the project name is "safe"' do
-        it 'returns the value without logging a message' do
-          expect(subject.safe_base_package_name).to eq('project')
+        it "returns the value without logging a message" do
+          expect(subject.safe_base_package_name).to eq("project")
           expect(subject).to_not receive(:log)
         end
       end
 
-      context 'when the project name has invalid characters' do
+      context "when the project name has invalid characters" do
         before { project.name("Pro$ject123.for-realz_2") }
 
-        it 'returns the value while logging a message' do
+        it "returns the value while logging a message" do
           output = capture_logging do
-            expect(subject.safe_base_package_name).to eq('pro-ject123.for-realz-2')
+            expect(subject.safe_base_package_name).to eq("pro-ject123.for-realz-2")
           end
 
           expect(output).to include("The `name' component of Debian package names can only include")
@@ -294,37 +294,37 @@ module Omnibus
     end
 
     describe '#safe_build_iteration' do
-      it 'returns the build iteration' do
+      it "returns the build iteration" do
         expect(subject.safe_build_iteration).to eq(project.build_iteration)
       end
     end
 
     describe '#safe_version' do
       context 'when the project build_version is "safe"' do
-        it 'returns the value without logging a message' do
-          expect(subject.safe_version).to eq('1.2.3')
+        it "returns the value without logging a message" do
+          expect(subject.safe_version).to eq("1.2.3")
           expect(subject).to_not receive(:log)
         end
       end
 
-      context 'when the project build_version has dashes' do
-        before { project.build_version('1.2-rc.1') }
+      context "when the project build_version has dashes" do
+        before { project.build_version("1.2-rc.1") }
 
-        it 'returns the value while logging a message' do
+        it "returns the value while logging a message" do
           output = capture_logging do
-            expect(subject.safe_version).to eq('1.2~rc.1')
+            expect(subject.safe_version).to eq("1.2~rc.1")
           end
 
           expect(output).to include("Dashes hold special significance in the Debian package versions.")
         end
       end
 
-      context 'when the project build_version has invalid characters' do
+      context "when the project build_version has invalid characters" do
         before { project.build_version("1.2$alpha.~##__2") }
 
-        it 'returns the value while logging a message' do
+        it "returns the value while logging a message" do
           output = capture_logging do
-            expect(subject.safe_version).to eq('1.2_alpha.~_2')
+            expect(subject.safe_version).to eq("1.2_alpha.~_2")
           end
 
           expect(output).to include("The `version' component of Debian package names can only include")

data/spec/unit/packagers/ips_spec.rb

@@ -1,27 +1,27 @@
-require 'spec_helper'
-require 'pry'
+require "spec_helper"
+require "pry"
 
 module Omnibus
   describe Packager::IPS do
     let(:project) do
       Project.new.tap do |project|
-        project.name('project')
-        project.homepage('https://example.com')
-        project.install_dir('/opt/project')
-        project.build_version('1.2.3')
-        project.build_iteration('2')
-        project.maintainer('Chef Software')
+        project.name("project")
+        project.homepage("https://example.com")
+        project.install_dir("/opt/project")
+        project.build_version("1.2.3")
+        project.build_iteration("2")
+        project.maintainer("Chef Software")
       end
     end
 
     subject { described_class.new(project) }
 
-    let(:project_root) { File.join(tmp_path, 'project/root') }
-    let(:package_dir)  { File.join(tmp_path, 'package/dir') }
-    let(:staging_dir)  { File.join(tmp_path, 'staging/dir') }
-    let(:source_dir)   { File.join(staging_dir, 'proto_install')}
-    let(:repo_dir)     { File.join(staging_dir, 'publish/repo')}
-    let(:architecture) { 'i86pc' }
+    let(:project_root) { File.join(tmp_path, "project/root") }
+    let(:package_dir)  { File.join(tmp_path, "package/dir") }
+    let(:staging_dir)  { File.join(tmp_path, "staging/dir") }
+    let(:source_dir)   { File.join(staging_dir, "proto_install") }
+    let(:repo_dir)     { File.join(staging_dir, "publish/repo") }
+    let(:architecture) { "i86pc" }
     let(:shellout) { double("Mixlib::ShellOut", :run_command => true, :error! => nil) }
 
     before do
@@ -34,18 +34,18 @@ module Omnibus
       create_directory(source_dir)
       create_directory(repo_dir)
 
-      stub_ohai(platform: 'solaris2', version: '5.11') do |data|
-        data['kernel']['machine'] = architecture
+      stub_ohai(platform: "solaris2", version: "5.11") do |data|
+        data["kernel"]["machine"] = architecture
       end
     end
 
     describe '#publisher_prefix' do
-      it 'is a DSL method' do
+      it "is a DSL method" do
         expect(subject).to have_exposed_method(:publisher_prefix)
       end
 
-      it 'has a default value' do
-        expect(subject.publisher_prefix).to eq('Omnibus')
+      it "has a default value" do
+        expect(subject.publisher_prefix).to eq("Omnibus")
       end
     end
 
@@ -54,55 +54,55 @@ module Omnibus
     end
 
     describe '#package_name' do
-      it 'should create correct package name' do
-        expect(subject.package_name).to eq('project.p5p')
+      it "should create correct package name" do
+        expect(subject.package_name).to eq("project-1.2.3-2.i386.p5p")
       end
     end
 
     describe '#fmri_package_name' do
-      it 'should create correct fmri package name' do
-        expect(subject.fmri_package_name).to eq ('project@1.2.3,5.11-2')
+      it "should create correct fmri package name" do
+        expect(subject.fmri_package_name).to eq ("project@1.2.3,5.11-2")
       end
     end
 
     describe '#pkg_metadata_file' do
-      it 'is created inside the staging_dir' do
+      it "is created inside the staging_dir" do
         expect(subject.pkg_metadata_file).to eq("#{subject.staging_dir}/gen.manifestfile")
       end
     end
 
     describe '#pkg_manifest_file' do
-      it 'is created inside the staging_dir' do
+      it "is created inside the staging_dir" do
         expect(subject.pkg_manifest_file).to eq("#{subject.staging_dir}/#{subject.safe_base_package_name}.p5m")
       end
     end
 
     describe '#repo_dir' do
-      it 'is created inside the staging_dir' do
+      it "is created inside the staging_dir" do
         expect(subject.repo_dir).to eq("#{subject.staging_dir}/publish/repo")
       end
     end
 
     describe '#source_dir' do
-      it 'is created inside the staging_dir' do
+      it "is created inside the staging_dir" do
         expect(subject.source_dir).to eq("#{subject.staging_dir}/proto_install")
       end
     end
 
     describe '#safe_base_package_name' do
       context 'when the project name is "safe"' do
-        it 'returns the value without logging a message' do
-          expect(subject.safe_base_package_name).to eq('project')
+        it "returns the value without logging a message" do
+          expect(subject.safe_base_package_name).to eq("project")
           expect(subject).to_not receive(:log)
         end
       end
 
-      context 'when the project name has invalid characters' do
+      context "when the project name has invalid characters" do
         before { project.name("Pro$ject123.for-realz_2") }
 
-        it 'returns the value while logging a message' do
+        it "returns the value while logging a message" do
           output = capture_logging do
-            expect(subject.safe_base_package_name).to eq('pro-ject123.for-realz-2')
+            expect(subject.safe_base_package_name).to eq("pro-ject123.for-realz-2")
           end
 
           expect(output).to include("The `name' component of IPS package names can only include")
@@ -111,27 +111,27 @@ module Omnibus
     end
 
     describe '#safe_architecture' do
-      context 'the architecture is Intel-based' do
-        let(:architecture) { 'i86pc' }
+      context "the architecture is Intel-based" do
+        let(:architecture) { "i86pc" }
 
-        it 'returns `i386`' do
-          expect(subject.safe_architecture).to eq('i386')
+        it "returns `i386`" do
+          expect(subject.safe_architecture).to eq("i386")
         end
       end
 
-      context 'the architecture is SPARC-based' do
-        let(:architecture) { 'sun4v' }
+      context "the architecture is SPARC-based" do
+        let(:architecture) { "sun4v" }
 
-        it 'returns `sparc`' do
-          expect(subject.safe_architecture).to eq('sparc')
+        it "returns `sparc`" do
+          expect(subject.safe_architecture).to eq("sparc")
         end
       end
 
-      context 'anything else' do
-        let(:architecture) { 'FOO' }
+      context "anything else" do
+        let(:architecture) { "FOO" }
 
-        it 'returns the value from Ohai' do
-          expect(subject.safe_architecture).to eq('FOO')
+        it "returns the value from Ohai" do
+          expect(subject.safe_architecture).to eq("FOO")
         end
       end
     end
@@ -211,7 +211,7 @@ module Omnibus
     describe "#export_pkg_archive_file" do
       it "uses the correct commands" do
         expect(subject).to receive(:shellout!)
-          .with("pkgrecv -s #{staging_dir}/publish/repo -a -d #{package_dir}/project.p5p project")
+          .with("pkgrecv -s #{staging_dir}/publish/repo -a -d #{package_dir}/project-1.2.3-2.i386.p5p project")
 
         expect(shellout).to receive(:stdout)
         subject.export_pkg_archive_file

data/spec/unit/packagers/makeself_spec.rb

@@ -1,23 +1,23 @@
-require 'spec_helper'
+require "spec_helper"
 
 module Omnibus
   describe Packager::Makeself do
     let(:project) do
       Project.new.tap do |project|
-        project.name('project')
-        project.homepage('https://example.com')
-        project.install_dir('/opt/project')
-        project.build_version('1.2.3')
-        project.build_iteration('2')
-        project.maintainer('Chef Software')
+        project.name("project")
+        project.homepage("https://example.com")
+        project.install_dir("/opt/project")
+        project.build_version("1.2.3")
+        project.build_iteration("2")
+        project.maintainer("Chef Software")
       end
     end
 
     subject { described_class.new(project) }
 
-    let(:project_root) { File.join(tmp_path, 'project/root') }
-    let(:package_dir)  { File.join(tmp_path, 'package/dir') }
-    let(:staging_dir)  { File.join(tmp_path, 'staging/dir') }
+    let(:project_root) { File.join(tmp_path, "project/root") }
+    let(:package_dir)  { File.join(tmp_path, "package/dir") }
+    let(:staging_dir)  { File.join(tmp_path, "staging/dir") }
 
     before do
       Config.project_root(project_root)
@@ -28,37 +28,37 @@ module Omnibus
     end
 
     describe '#id' do
-      it 'is :makeself' do
+      it "is :makeself" do
         expect(subject.id).to eq(:makeself)
       end
     end
 
     describe '#package_name' do
       before do
-        allow(subject).to receive(:safe_architecture).and_return('x86_64')
+        allow(subject).to receive(:safe_architecture).and_return("x86_64")
       end
 
-      it 'includes the name, version, and build iteration' do
-        expect(subject.package_name).to eq('project-1.2.3_2.x86_64.sh')
+      it "includes the name, version, and build iteration" do
+        expect(subject.package_name).to eq("project-1.2.3_2.x86_64.sh")
       end
     end
 
     describe '#write_makeselfinst' do
-      it 'generates the executable file', :not_supported_on_windows do
+      it "generates the executable file", :not_supported_on_windows do
         subject.write_makeselfinst
         expect("#{staging_dir}/makeselfinst").to be_an_executable
       end
 
-      it 'has the correct content' do
+      it "has the correct content" do
         subject.write_makeselfinst
         contents = File.read("#{staging_dir}/makeselfinst")
 
-        expect(contents).to include('INSTALL_DIR=/opt/project')
+        expect(contents).to include("INSTALL_DIR=/opt/project")
       end
     end
 
     describe '#write_scripts' do
-      let(:default_scripts) { %w( postinst ) }
+      let(:default_scripts) { %w{ postinst } }
       before do
         default_scripts.each do |script_name|
           create_file("#{project_root}/package-scripts/project/#{script_name}") do
@@ -67,7 +67,7 @@ module Omnibus
         end
       end
 
-      it 'writes the scripts into the staging dir' do
+      it "writes the scripts into the staging dir" do
         subject.write_scripts
 
         default_scripts.each do |script_name|
@@ -85,12 +85,12 @@ module Omnibus
         allow(Dir).to receive(:chdir) { |_, &b| b.call }
       end
 
-      it 'logs a message' do
+      it "logs a message" do
         output = capture_logging { subject.create_makeself_package }
-        expect(output).to include('Creating makeself package')
+        expect(output).to include("Creating makeself package")
       end
 
-      it 'uses the correct command' do
+      it "uses the correct command" do
         expect(subject).to receive(:shellout!)
           .with(/makeself\.sh/)
         subject.create_makeself_package