mysigner 0.1.2 → 0.1.4

data/lib/mysigner/cli/concerns/api_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Mysigner
   class CLI < Thor
     module Concerns
@@ -8,15 +10,13 @@ module Mysigner
           # 1. Environment variable
           # 2. Check if localhost is running
           # 3. Production default
-          
+
           return ENV['MYSIGNER_API_URL'] if ENV['MYSIGNER_API_URL']
-          
+
           # Check if localhost:3000 is accessible
           localhost_url = 'http://localhost:3000'
-          if localhost_accessible?(localhost_url)
-            return localhost_url
-          end
-          
+          return localhost_url if localhost_accessible?(localhost_url)
+
           # Default to production
           'https://mysigner.dev'
         end
@@ -24,7 +24,7 @@ module Mysigner
         def localhost_accessible?(url)
           require 'net/http'
           require 'uri'
-          
+
           begin
             uri = URI.parse(url)
             http = Net::HTTP.new(uri.host, uri.port)
@@ -33,7 +33,7 @@ module Mysigner
             request = Net::HTTP::Get.new('/up')
             response = http.request(request)
             response.code == '200'
-          rescue
+          rescue StandardError
             false
           end
         end
@@ -42,78 +42,70 @@ module Mysigner
         def prompt_api_url
           default = default_api_url
           say "API URL: #{default}", :cyan
-          
+
           loop do
-            custom = ask("Press Enter to use default, or type custom URL:", default: "")
-            
+            custom = ask('Press Enter to use default, or type custom URL:', default: '')
+
             # Use default if empty or nil
-            if custom.nil? || custom.empty?
-              return default
-            end
-            
+            return default if custom.nil? || custom.empty?
+
             # Validate and normalize the custom URL
             normalized_url = normalize_api_url(custom.strip)
-            
-            if valid_api_url?(normalized_url)
-              return normalized_url
-            else
-              error "Invalid URL format"
-              say "Please enter a valid URL (e.g., http://localhost:3000 or https://api.example.com)", :yellow
-              say ""
-            end
+
+            return normalized_url if valid_api_url?(normalized_url)
+
+            error 'Invalid URL format'
+            say 'Please enter a valid URL (e.g., http://localhost:3000 or https://api.example.com)', :yellow
+            say ''
           end
         end
 
         # Normalize API URL (add protocol, remove trailing slash)
         def normalize_api_url(url)
           # Add http:// if no protocol specified
-          url = "http://#{url}" unless url.match?(/^https?:\/\//)
-          
+          url = "http://#{url}" unless url.match?(%r{^https?://})
+
           # Remove trailing slash
-          url = url.chomp('/')
-          
-          url
+          url.chomp('/')
         end
 
         # Validate API URL format
         def valid_api_url?(url)
-          begin
-            uri = URI.parse(url)
-            
-            # Must have http or https scheme
-            return false unless uri.scheme.to_s.match?(/^https?$/)
-            
-            # Must have a host
-            return false if uri.host.nil? || uri.host.empty?
-            
-            # Valid formats:
-            # - http://localhost:3000
-            # - https://api.example.com
-            # - http://192.168.1.1:8080
-            true
-          rescue URI::InvalidURIError
-            false
-          end
+          uri = URI.parse(url)
+
+          # Must have http or https scheme
+          return false unless uri.scheme.to_s.match?(/^https?$/)
+
+          # Must have a host
+          return false if uri.host.nil? || uri.host.empty?
+
+          # Valid formats:
+          # - http://localhost:3000
+          # - https://api.example.com
+          # - http://192.168.1.1:8080
+          true
+        rescue URI::InvalidURIError
+          false
         end
 
         # Prompt for user email with validation
         def prompt_for_email
           loop do
-            email = ask("Your Email:").to_s.strip
-            
+            email = ask('Your Email:').to_s.strip
+
             if email.empty?
-              error "Email cannot be empty"
-              say ""
+              error 'Email cannot be empty'
+              say ''
               next
             end
-            
+
             unless valid_email?(email)
-              error "Invalid email format"
-              say "Please enter a valid email address (e.g., user@example.com)", :yellow
-              say ""
+              error 'Invalid email format'
+              say 'Please enter a valid email address (e.g., user@example.com)', :yellow
+              say ''
               next
             end
-            
+
             return email
           end
         end