mysigner 0.1.2 → 0.1.4

data/lib/mysigner/build/detector.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Mysigner
   module Build
     class Detector
@@ -9,9 +11,7 @@ module Mysigner
       # @param platform [Symbol, nil] Force detection for specific platform (:ios, :android, or nil for auto-detect iOS)
       def self.detect(directory = Dir.pwd, platform: nil)
         # If platform is explicitly android, detect android
-        if platform == :android
-          return detect_android(directory)
-        end
+        return detect_android(directory) if platform == :android
 
         # Default behavior: detect iOS (backwards compatible)
         detect_ios(directory)
@@ -21,7 +21,7 @@ module Mysigner
       # Returns: { platform: :android, type: :gradle, path: String, framework: :capacitor/:react_native/:flutter/:native }
       def self.detect_android(directory = Dir.pwd)
         # 1. Check for Capacitor (most specific first)
-        if File.exist?("#{directory}/capacitor.config.json") || 
+        if File.exist?("#{directory}/capacitor.config.json") ||
            File.exist?("#{directory}/capacitor.config.ts")
           return detect_capacitor_android(directory)
         end
@@ -34,21 +34,21 @@ module Mysigner
             # Auto-run expo prebuild
             puts "\n📦 Expo managed workflow detected (no android/ folder)"
             puts "🔧 Running: npx expo prebuild --platform android\n\n"
-            
+
             result = system("cd #{directory} && npx expo prebuild --platform android")
-            
+
             unless result && Dir.exist?("#{directory}/android")
               raise NoProjectError, <<~ERROR
                 Failed to generate Android project with expo prebuild.
-                
+
                 Try running manually:
                   npx expo prebuild --platform android
-                
+
                 Alternative: Use EAS Build (Expo's cloud service)
                 Learn more: https://docs.expo.dev/bare/overview/
               ERROR
             end
-            
+
             puts "\n✓ Android project generated successfully\n\n"
           end
         end
@@ -56,15 +56,11 @@ module Mysigner
         # 3. Check for React Native
         if File.exist?("#{directory}/package.json") && Dir.exist?("#{directory}/android")
           content = File.read("#{directory}/package.json")
-          if content.include?('react-native')
-            return detect_react_native_android(directory)
-          end
+          return detect_react_native_android(directory) if content.include?('react-native')
         end
 
         # 3. Check for Flutter
-        if File.exist?("#{directory}/pubspec.yaml")
-          return detect_flutter_android(directory)
-        end
+        return detect_flutter_android(directory) if File.exist?("#{directory}/pubspec.yaml")
 
         # 4. Check for .NET MAUI / Xamarin
         maui_project = Dir.glob("#{directory}/*.csproj").first
@@ -81,8 +77,6 @@ module Mysigner
         app_gradle_kts = "#{directory}/app/build.gradle.kts"
         root_gradle = "#{directory}/build.gradle"
         root_gradle_kts = "#{directory}/build.gradle.kts"
-        settings_gradle = "#{directory}/settings.gradle"
-        settings_gradle_kts = "#{directory}/settings.gradle.kts"
 
         if File.exist?(app_gradle) || File.exist?(app_gradle_kts)
           return {
@@ -119,7 +113,7 @@ module Mysigner
       # Detect iOS project in directory (original detect behavior)
       def self.detect_ios(directory = Dir.pwd)
         # 1. Check for Capacitor (most specific first)
-        if File.exist?("#{directory}/capacitor.config.json") || 
+        if File.exist?("#{directory}/capacitor.config.json") ||
            File.exist?("#{directory}/capacitor.config.ts")
           return detect_capacitor(directory)
         end
@@ -132,21 +126,21 @@ module Mysigner
             # Auto-run expo prebuild
             puts "\n📦 Expo managed workflow detected (no ios/ folder)"
             puts "🔧 Running: npx expo prebuild --platform ios\n\n"
-            
+
             result = system("cd #{directory} && npx expo prebuild --platform ios")
-            
+
             unless result && Dir.exist?("#{directory}/ios")
               raise NoProjectError, <<~ERROR
                 Failed to generate iOS project with expo prebuild.
-                
+
                 Try running manually:
                   npx expo prebuild --platform ios
-                
+
                 Alternative: Use EAS Build (Expo's cloud service)
                 Learn more: https://docs.expo.dev/bare/overview/
               ERROR
             end
-            
+
             puts "\n✓ iOS project generated successfully\n\n"
           end
         end
@@ -154,15 +148,11 @@ module Mysigner
         # 3. Check for React Native
         if File.exist?("#{directory}/package.json") && Dir.exist?("#{directory}/ios")
           content = File.read("#{directory}/package.json")
-          if content.include?('react-native')
-            return detect_react_native(directory)
-          end
+          return detect_react_native(directory) if content.include?('react-native')
         end
 
         # 4. Check for Flutter
-        if File.exist?("#{directory}/pubspec.yaml")
-          return detect_flutter(directory)
-        end
+        return detect_flutter(directory) if File.exist?("#{directory}/pubspec.yaml")
 
         # 5. Check for native iOS project (workspace first, then project)
         workspace = Dir.glob("#{directory}/*.xcworkspace").first
@@ -187,18 +177,18 @@ module Mysigner
           }
         end
 
-        raise NoProjectError, "No Xcode project found in #{directory}. Run in a project directory or try 'mysigner init' first."
+        raise NoProjectError,
+              "No Xcode project found in #{directory}. Run in a project directory or try 'mysigner init' first."
       end
 
-      private
-
       # Android detection for cross-platform frameworks
 
       def self.detect_capacitor_android(directory)
         android_dir = "#{directory}/android"
-        
+
         unless Dir.exist?(android_dir)
-          raise NoProjectError, "Capacitor project detected but no android/ folder found. Run 'npx cap add android' first."
+          raise NoProjectError,
+                "Capacitor project detected but no android/ folder found. Run 'npx cap add android' first."
         end
 
         app_gradle = "#{android_dir}/app/build.gradle"
@@ -216,7 +206,8 @@ module Mysigner
           }
         end
 
-        raise NoProjectError, "Capacitor project detected but no Android build.gradle found. Run 'npx cap sync android' first."
+        raise NoProjectError,
+              "Capacitor project detected but no Android build.gradle found. Run 'npx cap sync android' first."
       end
 
       def self.detect_react_native_android(directory)
@@ -237,15 +228,13 @@ module Mysigner
           }
         end
 
-        raise NoProjectError, "React Native project detected but no Android build.gradle found in android/ directory."
+        raise NoProjectError, 'React Native project detected but no Android build.gradle found in android/ directory.'
       end
 
       def self.detect_flutter_android(directory)
         android_dir = "#{directory}/android"
 
-        unless Dir.exist?(android_dir)
-          raise NoProjectError, "Flutter project detected but no android/ folder found. Run 'flutter create .' first."
-        end
+        raise NoProjectError, "Flutter project detected but no android/ folder found. Run 'flutter create .' first." unless Dir.exist?(android_dir)
 
         app_gradle = "#{android_dir}/app/build.gradle"
         app_gradle_kts = "#{android_dir}/app/build.gradle.kts"
@@ -262,19 +251,20 @@ module Mysigner
           }
         end
 
-        raise NoProjectError, "Flutter project detected but no Android build.gradle found. Run 'flutter build apk' first."
+        raise NoProjectError,
+              "Flutter project detected but no Android build.gradle found. Run 'flutter build apk' first."
       end
 
       def self.detect_dotnet_android(directory, csproj_path)
         content = File.read(csproj_path)
-        
+
         framework_type = if content.include?('Maui')
-          :maui
-        elsif content.include?('Xamarin.Forms')
-          :xamarin_forms
-        else
-          :xamarin
-        end
+                           :maui
+                         elsif content.include?('Xamarin.Forms')
+                           :xamarin_forms
+                         else
+                           :xamarin
+                         end
 
         {
           platform: :android,
@@ -291,7 +281,7 @@ module Mysigner
 
       def self.detect_capacitor(directory)
         ios_dir = "#{directory}/ios/App"
-        
+
         # Capacitor always creates App.xcworkspace
         workspace = "#{ios_dir}/App.xcworkspace"
         project = "#{ios_dir}/App.xcodeproj"
@@ -348,7 +338,7 @@ module Mysigner
           }
         end
 
-        raise NoProjectError, "React Native project detected but no Xcode project found in ios/ directory."
+        raise NoProjectError, 'React Native project detected but no Xcode project found in ios/ directory.'
       end
 
       def self.detect_flutter(directory)
@@ -385,4 +375,3 @@ module Mysigner
     end
   end
 end
-

data/lib/mysigner/build/error_analyzer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Mysigner
   module Build
     class ErrorAnalyzer
@@ -18,11 +20,11 @@ module Mysigner
         return nil unless any_issues?
 
         lines = []
-        lines << ""
-        lines << "=" * 70
-        lines << "  💡 SUGGESTIONS: How to fix these build errors"
-        lines << "=" * 70
-        lines << ""
+        lines << ''
+        lines << ('=' * 70)
+        lines << '  💡 SUGGESTIONS: How to fix these build errors'
+        lines << ('=' * 70)
+        lines << ''
 
         # Group issues by type for cleaner output
         profile_issues = @issues.select { |i| i[:type] == :profile_capability }
@@ -31,8 +33,8 @@ module Mysigner
 
         # Profile capability issues
         if profile_issues.any?
-          lines << "  📋 PROVISIONING PROFILE ISSUES"
-          lines << ""
+          lines << '  📋 PROVISIONING PROFILE ISSUES'
+          lines << ''
 
           # Group by profile name
           by_profile = profile_issues.group_by { |i| i[:profile_name] }
@@ -40,70 +42,70 @@ module Mysigner
             capabilities = issues.map { |i| i[:capability] }.compact.uniq
             lines << "  Profile: \"#{profile_name}\""
             lines << "  Missing capabilities: #{capabilities.join(', ')}"
-            lines << ""
+            lines << ''
           end
 
-          lines << "  How to fix:"
-          lines << "    1. Go to Apple Developer Portal → Certificates, Identifiers & Profiles"
+          lines << '  How to fix:'
+          lines << '    1. Go to Apple Developer Portal → Certificates, Identifiers & Profiles'
           lines << "    2. Select 'Identifiers' and find your Bundle ID"
-          lines << "    3. Enable the missing capabilities (App Groups, Apple Pay, etc.)"
-          lines << "    4. If adding App Groups or Merchant IDs, make sure to select the specific identifiers"
+          lines << '    3. Enable the missing capabilities (App Groups, Apple Pay, etc.)'
+          lines << '    4. If adding App Groups or Merchant IDs, make sure to select the specific identifiers'
           lines << "    5. Go to 'Profiles' and regenerate the affected provisioning profiles"
-          lines << "    6. Download new profiles: mysigner sync ios && mysigner profile download <ID>"
-          lines << "    7. Install profiles to: ~/Library/MobileDevice/Provisioning Profiles/"
-          lines << ""
+          lines << '    6. Download new profiles: mysigner sync ios && mysigner profile download <ID>'
+          lines << '    7. Install profiles to: ~/Library/MobileDevice/Provisioning Profiles/'
+          lines << ''
         end
 
         # Missing specific identifiers (App Group ID, Merchant ID)
         if identifier_issues.any?
-          lines << "  🔗 MISSING IDENTIFIERS"
-          lines << ""
+          lines << '  🔗 MISSING IDENTIFIERS'
+          lines << ''
 
           identifier_issues.each do |issue|
             lines << "  Profile: \"#{issue[:profile_name]}\""
             lines << "  Missing: #{issue[:identifier_type]} - #{issue[:identifier]}"
-            lines << ""
+            lines << ''
           end
 
-          lines << "  How to fix:"
-          lines << "    1. Go to Apple Developer Portal → Identifiers"
-          lines << "    2. Find your Bundle ID and edit it"
-          lines << "    3. Under the capability, add/select the specific identifier:"
-          lines << "       • For App Groups: select your group.* identifier"
-          lines << "       • For Apple Pay: select your merchant.* identifier"
-          lines << "    4. Regenerate the provisioning profile"
-          lines << ""
+          lines << '  How to fix:'
+          lines << '    1. Go to Apple Developer Portal → Identifiers'
+          lines << '    2. Find your Bundle ID and edit it'
+          lines << '    3. Under the capability, add/select the specific identifier:'
+          lines << '       • For App Groups: select your group.* identifier'
+          lines << '       • For Apple Pay: select your merchant.* identifier'
+          lines << '    4. Regenerate the provisioning profile'
+          lines << ''
         end
 
         # Certificate mismatch
         if cert_issues.any?
-          lines << "  🔐 CERTIFICATE MISMATCH"
-          lines << ""
-          lines << "  Your app and its extensions are signed with different certificates."
-          lines << ""
-          lines << "  How to fix:"
-          lines << "    1. Open your Xcode project"
-          lines << "    2. For EACH target (main app AND extensions):"
-          lines << "       • Select the target → Signing & Capabilities"
-          lines << "       • Ensure all targets use the same signing identity:"
+          lines << '  🔐 CERTIFICATE MISMATCH'
+          lines << ''
+          lines << '  Your app and its extensions are signed with different certificates.'
+          lines << ''
+          lines << '  How to fix:'
+          lines << '    1. Open your Xcode project'
+          lines << '    2. For EACH target (main app AND extensions):'
+          lines << '       • Select the target → Signing & Capabilities'
+          lines << '       • Ensure all targets use the same signing identity:'
           lines << "         - For App Store: 'Apple Distribution'"
           lines << "         - For Development: 'Apple Development'"
-          lines << "    3. Make sure all targets use matching profile types:"
-          lines << "       • App Store profiles for App Store builds"
-          lines << "       • Development profiles for development builds"
-          lines << ""
-          lines << "  Quick fix for App Store builds:"
-          lines << "    In project.pbxproj, ensure Release configuration has:"
-          lines << "      CODE_SIGN_IDENTITY = \"Apple Distribution\""
-          lines << "      PROVISIONING_PROFILE_SPECIFIER = \"YourApp App Store\""
-          lines << ""
+          lines << '    3. Make sure all targets use matching profile types:'
+          lines << '       • App Store profiles for App Store builds'
+          lines << '       • Development profiles for development builds'
+          lines << ''
+          lines << '  Quick fix for App Store builds:'
+          lines << '    In project.pbxproj, ensure Release configuration has:'
+          lines << '      CODE_SIGN_IDENTITY = "Apple Distribution"'
+          lines << '      PROVISIONING_PROFILE_SPECIFIER = "YourApp App Store"'
+          lines << ''
         end
 
-        lines << "  📚 More help:"
+        lines << '  📚 More help:'
         lines << "    • Run 'mysigner doctor' to check your setup"
         lines << "    • Run 'mysigner profiles' to list available profiles"
-        lines << "    • Check My Signer dashboard for Bundle ID capabilities"
-        lines << ""
+        lines << '    • Check My Signer dashboard for Bundle ID capabilities'
+        lines << ''
 
         lines.join("\n")
       end
@@ -118,10 +120,10 @@ module Mysigner
 
       def analyze_error(error)
         # Normalize curly quotes to straight quotes
-        error = error.gsub(/["""]/, '"').gsub(/[''']/, "'")
+        error = error.gsub('"', '"').gsub('\'', "'")
 
         # Pattern: Provisioning profile "X" doesn't include the Y capability
-        if match = error.match(/Provisioning profile "([^"]+)".*(?:doesn't|does not) include the (.+?) capability/i)
+        if (match = error.match(/Provisioning profile "([^"]+)".*(?:doesn't|does not) include the (.+?) capability/i))
           @issues << {
             type: :profile_capability,
             profile_name: match[1],
@@ -130,27 +132,27 @@ module Mysigner
         end
 
         # Pattern: Provisioning profile "X" doesn't support the Y App Group
-        if match = error.match(/Provisioning profile "([^"]+)".*(?:doesn't|does not) support the (.+?) App Group/i)
+        if (match = error.match(/Provisioning profile "([^"]+)".*(?:doesn't|does not) support the (.+?) App Group/i))
           @issues << {
             type: :missing_identifier,
             profile_name: match[1],
-            identifier_type: "App Group",
+            identifier_type: 'App Group',
             identifier: match[2].strip
           }
         end
 
         # Pattern: Provisioning profile "X" doesn't support the Y Merchant ID
-        if match = error.match(/Provisioning profile "([^"]+)".*(?:doesn't|does not) support the (.+?) Merchant ID/i)
+        if (match = error.match(/Provisioning profile "([^"]+)".*(?:doesn't|does not) support the (.+?) Merchant ID/i))
           @issues << {
             type: :missing_identifier,
             profile_name: match[1],
-            identifier_type: "Merchant ID",
+            identifier_type: 'Merchant ID',
             identifier: match[2].strip
           }
         end
 
         # Pattern: Provisioning profile "X" doesn't match the entitlements file's value
-        if match = error.match(/Provisioning profile "([^"]+)".*(?:doesn't|does not) match.*entitlements.*?for the (.+?) entitlement/i)
+        if (match = error.match(/Provisioning profile "([^"]+)".*(?:doesn't|does not) match.*entitlements.*?for the (.+?) entitlement/i))
           capability = entitlement_to_capability(match[2])
           @issues << {
             type: :profile_capability,
@@ -160,7 +162,7 @@ module Mysigner
         end
 
         # Pattern: Embedded binary is not signed with the same certificate
-        if error.include?("Embedded binary is not signed with the same certificate")
+        if error.include?('Embedded binary is not signed with the same certificate')
           @issues << {
             type: :certificate_mismatch,
             message: error
@@ -168,23 +170,23 @@ module Mysigner
         end
 
         # Pattern: Code Sign error
-        if error.include?("Code Sign error")
-          @issues << {
-            type: :code_sign_error,
-            message: error
-          }
-        end
+        return unless error.include?('Code Sign error')
+
+        @issues << {
+          type: :code_sign_error,
+          message: error
+        }
       end
 
       def entitlement_to_capability(entitlement)
         mappings = {
-          "com.apple.security.application-groups" => "App Groups",
-          "com.apple.developer.in-app-payments" => "Apple Pay",
-          "aps-environment" => "Push Notifications",
-          "com.apple.developer.associated-domains" => "Associated Domains",
-          "com.apple.developer.applesignin" => "Sign in with Apple",
-          "com.apple.developer.icloud-services" => "iCloud",
-          "com.apple.developer.healthkit" => "HealthKit"
+          'com.apple.security.application-groups' => 'App Groups',
+          'com.apple.developer.in-app-payments' => 'Apple Pay',
+          'aps-environment' => 'Push Notifications',
+          'com.apple.developer.associated-domains' => 'Associated Domains',
+          'com.apple.developer.applesignin' => 'Sign in with Apple',
+          'com.apple.developer.icloud-services' => 'iCloud',
+          'com.apple.developer.healthkit' => 'HealthKit'
         }
         mappings[entitlement] || entitlement
       end

data/lib/mysigner/build/executor.rb

@@ -1,5 +1,6 @@
-require 'set'
+# frozen_string_literal: true
 
+require 'English'
 module Mysigner
   module Build
     class Executor
@@ -20,7 +21,8 @@ module Mysigner
       #   - team_id: Development team ID to override project setting
       #   - bundle_id: Bundle ID to override project setting
       #   - skip_extensions: If true, disable code signing for extension targets
-      def build!(target_name = nil, configuration = 'Release', scheme: nil, signing_style: nil, team_id: nil, bundle_id: nil, skip_extensions: false)
+      def build!(target_name = nil, configuration = 'Release', scheme: nil, signing_style: nil, team_id: nil,
+                 bundle_id: nil, skip_extensions: false)
         target = target_name || @parser.main_target.name
         scheme_name = scheme || target
         @signing_style = signing_style
@@ -31,7 +33,7 @@ module Mysigner
         # Use Xcode's default DerivedData location to keep project clean
         # This matches Xcode's behavior and avoids polluting the project directory
         output_dir = File.join(@project_info[:directory], 'build')
-        FileUtils.mkdir_p(output_dir) unless Dir.exist?(output_dir)
+        FileUtils.mkdir_p(output_dir)
 
         # Generate archive path with timestamp
         timestamp = Time.now.strftime('%Y%m%d-%H%M%S')
@@ -44,14 +46,10 @@ module Mysigner
         # Execute build
         success = execute_with_output(cmd)
 
-        unless success
-          raise BuildError, "Build failed. Check output above for errors."
-        end
+        raise BuildError, 'Build failed. Check output above for errors.' unless success
 
         # Verify archive was created
-        unless File.exist?(archive_path)
-          raise BuildError, "Build reported success but archive not found at: #{archive_path}"
-        end
+        raise BuildError, "Build reported success but archive not found at: #{archive_path}" unless File.exist?(archive_path)
 
         archive_path
       end
@@ -59,14 +57,14 @@ module Mysigner
       private
 
       def build_command(scheme, configuration, archive_path)
-        cmd = ['xcodebuild', 'archive']
+        cmd = %w[xcodebuild archive]
 
         # Workspace or project
-        if @project_info[:type] == :workspace
-          cmd += ['-workspace', @project_info[:path]]
-        else
-          cmd += ['-project', @project_info[:path]]
-        end
+        cmd += if @project_info[:type] == :workspace
+                 ['-workspace', @project_info[:path]]
+               else
+                 ['-project', @project_info[:path]]
+               end
 
         # Scheme and configuration
         cmd += [
@@ -78,26 +76,22 @@ module Mysigner
         # SDK selection based on platform
         platform = @parser.target_platform(scheme)
         sdk = case platform
-        when :macos
-          'macosx'
-        when :tvos
-          'appletvos'
-        when :watchos
-          'watchos'
-        else
-          'iphoneos'  # default to iOS
-        end
+              when :macos
+                'macosx'
+              when :tvos
+                'appletvos'
+              when :watchos
+                'watchos'
+              else
+                'iphoneos' # default to iOS
+              end
         cmd += ['-sdk', sdk]
 
         # Override team ID if provided
-        if @team_id
-          cmd += ["DEVELOPMENT_TEAM=#{@team_id}"]
-        end
-        
+        cmd += ["DEVELOPMENT_TEAM=#{@team_id}"] if @team_id
+
         # Override bundle ID if provided
-        if @bundle_id
-          cmd += ["PRODUCT_BUNDLE_IDENTIFIER=#{@bundle_id}"]
-        end
+        cmd += ["PRODUCT_BUNDLE_IDENTIFIER=#{@bundle_id}"] if @bundle_id
 
         # Handle signing based on style
         case @signing_style
@@ -131,13 +125,13 @@ module Mysigner
       end
 
       def execute_with_output(cmd)
-        puts "🏗️  Running: xcodebuild archive..."
-        puts ""
+        puts '🏗️  Running: xcodebuild archive...'
+        puts ''
 
         @build_errors = []
 
         # Run command and capture output in real-time
-        IO.popen(cmd, err: [:child, :out]) do |io|
+        IO.popen(cmd, err: %i[child out]) do |io|
           io.each_line do |line|
             # Filter output to show only important messages
             next if line.strip.empty?
@@ -166,11 +160,10 @@ module Mysigner
           end
         end
 
-        puts "" # New line after dots
+        puts '' # New line after dots
 
-        $?.success?
+        $CHILD_STATUS.success?
       end
     end
   end
 end
-