mysigner 0.1.2 → 0.1.4

data/lib/mysigner/signing/validator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Mysigner
   module Signing
     class Validator
@@ -19,20 +21,20 @@ module Mysigner
         team_id = @team_id_override || @parser.team_id(@target_name, @configuration)
         if team_id.nil? || team_id.empty?
           result[:errors] << "No development team set for target '#{@target_name}'"
-          result[:errors] << ""
-          result[:errors] << "Fix Option 1: Add team to My Signer"
-          result[:errors] << "  1. Open https://mysigner.dev"
-          result[:errors] << "  2. Go to Settings → App Store Connect"
-          result[:errors] << "  3. Add your Team ID"
-          result[:errors] << "  4. Run: mysigner build (team will auto-fetch)"
-          result[:errors] << ""
-          result[:errors] << "Fix Option 2: Pass team via CLI"
-          result[:errors] << "  mysigner build --team YOUR_TEAM_ID"
-          result[:errors] << ""
-          result[:errors] << "Fix Option 3: Set in Xcode"
-          result[:errors] << "  Open Xcode → Select target → Signing & Capabilities → Select a team"
-          result[:errors] << ""
-          result[:errors] << "Find your team ID at: https://developer.apple.com/account/#!/membership/"
+          result[:errors] << ''
+          result[:errors] << 'Fix Option 1: Add team to My Signer'
+          result[:errors] << '  1. Open https://mysigner.dev'
+          result[:errors] << '  2. Go to Settings → App Store Connect'
+          result[:errors] << '  3. Add your Team ID'
+          result[:errors] << '  4. Run: mysigner build (team will auto-fetch)'
+          result[:errors] << ''
+          result[:errors] << 'Fix Option 2: Pass team via CLI'
+          result[:errors] << '  mysigner build --team YOUR_TEAM_ID'
+          result[:errors] << ''
+          result[:errors] << 'Fix Option 3: Set in Xcode'
+          result[:errors] << '  Open Xcode → Select target → Signing & Capabilities → Select a team'
+          result[:errors] << ''
+          result[:errors] << 'Find your team ID at: https://developer.apple.com/account/#!/membership/'
           result[:valid] = false
         elsif @team_id_override && @parser.team_id(@target_name, @configuration).nil?
           result[:warnings] << "Using team from My Signer: #{@team_id_override}"
@@ -42,15 +44,13 @@ module Mysigner
 
         # Check 2: Code signing style
         signing_style = @parser.code_sign_style(@target_name, @configuration)
-        if signing_style.nil?
-          result[:warnings] << "Code signing style not explicitly set (will use Xcode default)"
-        end
+        result[:warnings] << 'Code signing style not explicitly set (will use Xcode default)' if signing_style.nil?
 
         # Check 3: Bundle ID
         bundle_id = @parser.bundle_id(@target_name, @configuration)
         if bundle_id.nil? || bundle_id.empty? || bundle_id.include?('$(')
           result[:errors] << "Bundle ID not set or contains variables: #{bundle_id}"
-          result[:errors] << "Fix: Open Xcode → Select target → General → Bundle Identifier"
+          result[:errors] << 'Fix: Open Xcode → Select target → General → Bundle Identifier'
           result[:valid] = false
         end
 
@@ -79,22 +79,22 @@ module Mysigner
         result = validate
 
         if result[:warnings].any?
-          puts ""
-          puts "⚠️  Warnings:"
+          puts ''
+          puts '⚠️  Warnings:'
           result[:warnings].each { |w| puts "  • #{w}" }
         end
 
         if result[:errors].any?
-          puts ""
-          puts "❌ Validation Failed:"
-          puts ""
+          puts ''
+          puts '❌ Validation Failed:'
+          puts ''
           result[:errors].each { |e| puts "  • #{e}" }
-          puts ""
-          raise ValidationError, "Pre-build validation failed. Fix the errors above and try again."
+          puts ''
+          raise ValidationError, 'Pre-build validation failed. Fix the errors above and try again.'
         end
 
-        puts "✓ Pre-build validation passed" if result[:warnings].empty?
-        puts "" if result[:warnings].any?
+        puts '✓ Pre-build validation passed' if result[:warnings].empty?
+        puts '' if result[:warnings].any?
       end
 
       private
@@ -104,19 +104,17 @@ module Mysigner
 
         # Check for valid iOS distribution certificates in keychain
         output = `security find-identity -v -p codesigning 2>&1`
-        
+
         if output.include?('0 valid identities found')
-          result[:errors] << "No code signing certificates found in keychain"
-          result[:errors] << "Fix: Install your distribution certificate (.p12 file)"
+          result[:errors] << 'No code signing certificates found in keychain'
+          result[:errors] << 'Fix: Install your distribution certificate (.p12 file)'
         else
           # Count valid certificates
           cert_count = output.scan(/\d+\)\s+[A-F0-9]+/).count
           result[:warnings] << "Found #{cert_count} code signing certificate(s) in keychain"
-          
+
           # Check for expired certificates
-          if output.include?('CSSMERR')
-            result[:warnings] << "Some certificates may be invalid or expired"
-          end
+          result[:warnings] << 'Some certificates may be invalid or expired' if output.include?('CSSMERR')
         end
 
         result
@@ -127,18 +125,18 @@ module Mysigner
 
         # Check provisioning profile directory
         profiles_dir = File.expand_path('~/Library/MobileDevice/Provisioning Profiles')
-        
+
         unless Dir.exist?(profiles_dir)
-          result[:warnings] << "No provisioning profiles directory found"
-          result[:warnings] << "Profiles will be downloaded automatically if using automatic signing"
+          result[:warnings] << 'No provisioning profiles directory found'
+          result[:warnings] << 'Profiles will be downloaded automatically if using automatic signing'
           return result
         end
 
         profiles = Dir.glob("#{profiles_dir}/*.mobileprovision")
-        
+
         if profiles.empty?
-          result[:warnings] << "No provisioning profiles found"
-          result[:warnings] << "Profiles will be downloaded automatically if using automatic signing"
+          result[:warnings] << 'No provisioning profiles found'
+          result[:warnings] << 'Profiles will be downloaded automatically if using automatic signing'
         else
           result[:warnings] << "Found #{profiles.count} provisioning profile(s) installed"
         end