mongoid 7.0.6 → 7.1.2

data/spec/mongoid/criteria/queryable/extensions/set_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Set do

data/spec/mongoid/criteria/queryable/extensions/string_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe String do
@@ -315,7 +318,7 @@ describe String do
     context "when provided a regex" do
 
       let(:regex) do
-        /^[123]/
+        /\A[123]/.freeze
       end
 
       let(:evolved) do

data/spec/mongoid/criteria/queryable/extensions/symbol_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Symbol do

data/spec/mongoid/criteria/queryable/extensions/time_spec.rb

@@ -1,4 +1,7 @@
-require "spec_helper"
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "lite_spec_helper"
 
 describe Time do
 
@@ -8,22 +11,27 @@ describe Time do
 
       context "when the time is not in utc" do
 
-        let(:date) do
-          Time.new(2010, 1, 1, 12, 0, 0)
+        let(:time) do
+          Time.new(2010, 1, 1, 14, 0, 0, '+02:00')
         end
 
         let(:evolved) do
-          described_class.evolve(date)
+          described_class.evolve(time)
         end
 
         let(:expected) do
-          Time.new(2010, 1, 1, 12, 0, 0).utc
+          Time.new(2010, 1, 1, 12, 0, 0, '+00:00')
         end
 
         it "returns the same time" do
           expect(evolved).to eq(expected)
         end
 
+        it 'does not mutate original time' do
+          described_class.evolve(time)
+          expect(time.utc_offset).to eq(7200)
+        end
+
         it "returns the time in utc" do
           expect(evolved.utc_offset).to eq(0)
         end
@@ -31,12 +39,12 @@ describe Time do
 
       context "when the time is already utc" do
 
-        let(:date) do
+        let(:time) do
           Time.new(2010, 1, 1, 12, 0, 0).utc
         end
 
         let(:evolved) do
-          described_class.evolve(date)
+          described_class.evolve(time)
         end
 
         let(:expected) do
@@ -57,12 +65,12 @@ describe Time do
 
       context "when the array is composed of times" do
 
-        let(:date) do
+        let(:time) do
           Time.new(2010, 1, 1, 12, 0, 0)
         end
 
         let(:evolved) do
-          described_class.evolve([ date ])
+          described_class.evolve([ time ])
         end
 
         let(:expected) do
@@ -80,16 +88,16 @@ describe Time do
 
       context "when the array is composed of strings" do
 
-        let(:date) do
+        let(:time) do
           Time.parse("1st Jan 2010 12:00:00+01:00")
         end
 
         let(:evolved) do
-          described_class.evolve([ date.to_s ])
+          described_class.evolve([ time.to_s ])
         end
 
         it "returns the strings as a times" do
-          expect(evolved).to eq([ date.to_time ])
+          expect(evolved).to eq([ time.to_time ])
         end
 
         it "returns the times in utc" do
@@ -146,7 +154,7 @@ describe Time do
 
     context "when provided a range" do
 
-      context "when the range are dates" do
+      context "when the range are times" do
 
         let(:min) do
           Time.new(2010, 1, 1, 12, 0, 0)
@@ -273,16 +281,16 @@ describe Time do
 
     context "when provided a string" do
 
-      let(:date) do
+      let(:time) do
         Time.parse("1st Jan 2010 12:00:00+01:00")
       end
 
       let(:evolved) do
-        described_class.evolve(date.to_s)
+        described_class.evolve(time.to_s)
       end
 
       it "returns the string as a time" do
-        expect(evolved).to eq(date.to_time)
+        expect(evolved).to eq(time.to_time)
       end
 
       it "returns the time in utc" do

data/spec/mongoid/criteria/queryable/extensions/time_with_zone_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe ActiveSupport::TimeWithZone do

data/spec/mongoid/criteria/queryable/key_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Criteria::Queryable::Key do

data/spec/mongoid/criteria/queryable/mergeable_spec.rb

@@ -1,12 +1,15 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Criteria::Queryable::Mergeable do
 
-  describe "#intersect" do
+  let(:query) do
+    Mongoid::Query.new
+  end
 
-    let(:query) do
-      Mongoid::Query.new
-    end
+  describe "#intersect" do
 
     before do
       query.intersect
@@ -19,10 +22,6 @@ describe Mongoid::Criteria::Queryable::Mergeable do
 
   describe "#override" do
 
-    let(:query) do
-      Mongoid::Query.new
-    end
-
     before do
       query.override
     end
@@ -34,10 +33,6 @@ describe Mongoid::Criteria::Queryable::Mergeable do
 
   describe "#union" do
 
-    let(:query) do
-      Mongoid::Query.new
-    end
-
     before do
       query.union
     end
@@ -46,4 +41,45 @@ describe Mongoid::Criteria::Queryable::Mergeable do
       expect(query.strategy).to eq(:__union__)
     end
   end
+
+  describe '#_mongoid_expand_keys' do
+    it 'expands simple keys' do
+      query.send(:_mongoid_expand_keys, {a: 1}).should == {a: 1}
+    end
+
+    let(:gt) do
+      Mongoid::Criteria::Queryable::Key.new("age", :__override__, "$gt")
+    end
+
+    let(:gtp) do
+      Mongoid::Criteria::Queryable::Key.new("age", :__override__, "$gt")
+    end
+
+    let(:lt) do
+      Mongoid::Criteria::Queryable::Key.new("age", :__override__, "$lt")
+    end
+
+    it 'expands Key instances' do
+      query.send(:_mongoid_expand_keys, {gt => 42}).should == {'age' => {'$gt' => 42}}
+    end
+
+    it 'expands multiple Key instances on the same field' do
+      query.send(:_mongoid_expand_keys, {gt => 42, lt => 50}).should == {
+        'age' => {'$gt' => 42, '$lt' => 50}}
+    end
+
+    it 'expands simple and Key instances on the same field' do
+      query.send(:_mongoid_expand_keys, {'age' => 42, lt => 50}).should == {
+        'age' => {'$eq' => 42, '$lt' => 50}}
+    end
+
+    it 'expands Key and simple instances on the same field' do
+      query.send(:_mongoid_expand_keys, {gt => 42, 'age' => 50}).should == {
+        'age' => {'$gt' => 42, '$eq' => 50}}
+    end
+
+    it 'Ruby does not allow same symbol operator with different values' do
+      {gt => 42, gtp => 50}.should == {gtp => 50}
+    end
+  end
 end

data/spec/mongoid/criteria/queryable/optional_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Criteria::Queryable::Optional do

data/spec/mongoid/criteria/queryable/options_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Criteria::Queryable::Options do

data/spec/mongoid/criteria/queryable/pipeline_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Criteria::Queryable::Pipeline do

data/spec/mongoid/criteria/queryable/queryable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Query do

data/spec/mongoid/criteria/queryable/selectable_logical_spec.rb

@@ -9,8 +9,292 @@ describe Mongoid::Criteria::Queryable::Selectable do
     Mongoid::Query.new("id" => "_id")
   end
 
+  shared_examples_for 'returns a cloned query' do
+
+    it "returns a cloned query" do
+      expect(selection).to_not equal(query)
+    end
+  end
+
+  # Hoisting means the operator can be elided, for example
+  # Foo.and(a: 1) produces simply {'a' => 1}.
+  shared_examples_for 'a hoisting logical operation' do
+
+    let(:query) do
+      Mongoid::Query.new
+    end
+
+    context "when provided a single criterion" do
+
+      shared_examples_for 'adds the conditions to top level' do
+
+        it "adds the conditions to top level" do
+          expect(selection.selector).to eq(
+            "field" => [ 1, 2 ]
+          )
+        end
+
+        it_behaves_like 'returns a cloned query'
+      end
+
+      let(:selection) do
+        query.send(tested_method, field: [ 1, 2 ])
+      end
+
+      it_behaves_like 'adds the conditions to top level'
+
+      context 'when the criterion is wrapped in an array' do
+        let(:selection) do
+          query.send(tested_method, [{field: [ 1, 2 ] }])
+        end
+
+        it_behaves_like 'adds the conditions to top level'
+      end
+
+      context 'when the criterion is wrapped in a deep array with nil elements' do
+        let(:selection) do
+          query.send(tested_method, [[[{field: [ 1, 2 ] }]], [nil]])
+        end
+
+        it_behaves_like 'adds the conditions to top level'
+      end
+    end
+
+    context 'when argument is a Criteria' do
+      let(:base) do
+        query.where(hello: 'world')
+      end
+
+      let(:other) do
+        query.where(foo: 'bar')
+      end
+
+      let(:result) { base.send(tested_method, other) }
+
+      it 'combines' do
+        expect(result.selector).to eq(
+          'hello' => 'world',
+          'foo' => 'bar',
+        )
+      end
+    end
+
+    context "when provided a single criterion that is handled via Key" do
+
+      shared_examples_for 'adds the conditions to top level' do
+
+        it "adds the conditions to top level" do
+          expect(selection.selector).to eq({
+            "field" => {'$gt' => 3},
+          })
+        end
+
+        it_behaves_like 'returns a cloned query'
+      end
+
+      let(:selection) do
+        query.send(tested_method, :field.gt => 3)
+      end
+
+      it_behaves_like 'adds the conditions to top level'
+
+      context 'when the criterion is wrapped in an array' do
+        let(:selection) do
+          query.send(tested_method, [{ :field.gt => 3 }])
+        end
+
+        it_behaves_like 'adds the conditions to top level'
+      end
+
+      context 'when the criterion is wrapped in a deep array with nil elements' do
+        let(:selection) do
+          query.send(tested_method, [[[{ :field.gt => 3 }]], [nil]])
+        end
+
+        it_behaves_like 'adds the conditions to top level'
+      end
+
+      context 'when the criterion is a time' do
+        let(:selection) do
+          query.send(tested_method, :field.gte => Time.new(2020, 1, 1))
+        end
+
+        it 'adds the conditions' do
+          expect(selection.selector).to eq({
+            "field" => {'$gte' => Time.new(2020, 1, 1)},
+          })
+        end
+
+        it 'keeps argument type' do
+          selection.selector['field']['$gte'].should be_a(Time)
+        end
+      end
+
+      context 'when the criterion is a datetime' do
+        let(:selection) do
+          query.send(tested_method, :field.gte => DateTime.new(2020, 1, 1))
+        end
+
+        it 'adds the conditions' do
+          expect(selection.selector).to eq({
+            "field" => {'$gte' => Time.utc(2020, 1, 1)},
+          })
+        end
+
+        it 'converts argument to a time' do
+          selection.selector['field']['$gte'].should be_a(Time)
+        end
+      end
+
+      context 'when the criterion is a date' do
+        let(:selection) do
+          query.send(tested_method, :field.gte => Date.new(2020, 1, 1))
+        end
+
+        it 'adds the conditions' do
+          expect(selection.selector).to eq({
+            "field" => {'$gte' => Time.utc(2020, 1, 1)},
+          })
+        end
+
+        it 'converts argument to a time' do
+          selection.selector['field']['$gte'].should be_a(Time)
+        end
+      end
+    end
+
+    context "when provided a nested criterion" do
+
+      let(:selection) do
+        query.send(tested_method, :test.elem_match => { :field.in => [ 1, 2 ] })
+      end
+
+      it "builds the correct selector" do
+        expect(selection.selector).to eq({
+          "test" => { "$elemMatch" => { "field" => { "$in" => [ 1, 2 ] }}}
+        })
+      end
+
+      it_behaves_like 'returns a cloned query'
+    end
+
+    context "when chaining the criteria" do
+
+      context "when the criteria are for different fields" do
+
+        let(:selection) do
+          query.and(first: [ 1, 2 ]).send(tested_method, second: [ 3, 4 ])
+        end
+
+        it "adds the conditions to top level" do
+          expect(selection.selector).to eq({
+            "first" => [ 1, 2 ],
+            "second" => [ 3, 4 ],
+          })
+        end
+
+        it_behaves_like 'returns a cloned query'
+      end
+
+      context "when the criteria are on the same field" do
+
+        let(:selection) do
+          query.and(first: [ 1, 2 ]).send(tested_method, first: [ 3, 4 ])
+        end
+
+        it "combines via $and operator" do
+          expect(selection.selector).to eq({
+            "first" => [ 1, 2 ],
+            "$and" => [
+              { "first" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it_behaves_like 'returns a cloned query'
+      end
+    end
+  end
+
+  # Non-hoisting means the operator is always present, for example
+  # Foo.or(a: 1) produces {'$or' => [{'a' => 1}]}.
+  shared_examples_for 'a non-hoisting logical operation' do
+
+    context 'when there is a single predicate' do
+      let(:query) do
+        Mongoid::Query.new.send(tested_method, hello: 'world')
+      end
+
+      it 'adds the predicate' do
+        expect(query.selector).to eq(expected_operator => [{'hello' => 'world'}])
+      end
+    end
+
+    context 'when the single predicate is wrapped in an array' do
+      let(:query) do
+        Mongoid::Query.new.send(tested_method, [{hello: 'world'}])
+      end
+
+      it 'adds the predicate' do
+        expect(query.selector).to eq(expected_operator => [{'hello' => 'world'}])
+      end
+    end
+
+    context 'when argument is a Criteria' do
+      let(:query) do
+        Mongoid::Query.new.where(hello: 'world')
+      end
+
+      let(:other) do
+        Mongoid::Query.new.where(foo: 'bar')
+      end
+
+      let(:result) { query.send(tested_method, other) }
+
+      it 'combines' do
+        # This is used for $or / $nor, the two conditions should remain
+        # as separate hashes
+        expect(result.selector).to eq(expected_operator => [{'hello' => 'world'}, {'foo' => 'bar'}])
+      end
+    end
+
+    context 'when argument is a mix of Criteria and hashes' do
+      let(:query) do
+        Mongoid::Query.new.where(hello: 'world')
+      end
+
+      let(:other1) do
+        Mongoid::Query.new.where(foo: 'bar')
+      end
+
+      let(:other2) do
+        {bar: 42}
+      end
+
+      let(:other3) do
+        Mongoid::Query.new.where(a: 2)
+      end
+
+      let(:result) { query.send(tested_method, other1, other2, other3) }
+
+      it 'combines' do
+        expect(result.selector).to eq(expected_operator => [
+          {'hello' => 'world'},
+          {'foo' => 'bar'},
+          {'bar' => 42},
+          {'a' => 2},
+        ])
+      end
+    end
+  end
+
   describe "#and" do
 
+    let(:tested_method) { :and }
+    let(:expected_operator) { '$and' }
+
+    it_behaves_like 'a hoisting logical operation'
+
     context "when provided no criterion" do
 
       let(:selection) do
@@ -25,9 +309,7 @@ describe Mongoid::Criteria::Queryable::Selectable do
         expect(selection).to eq(query)
       end
 
-      it "returns a cloned query" do
-        expect(selection).to_not equal(query)
-      end
+      it_behaves_like 'returns a cloned query'
     end
 
     context "when provided nil" do
@@ -44,103 +326,669 @@ describe Mongoid::Criteria::Queryable::Selectable do
         expect(selection).to eq(query)
       end
 
-      it "returns a cloned query" do
-        expect(selection).to_not equal(query)
+      it_behaves_like 'returns a cloned query'
+    end
+
+    context "when provided multiple criteria" do
+
+      context "when the criterion is already included" do
+
+        context 'simple criterion' do
+          let(:selection) do
+            query.and({ first: [ 1, 2 ] }).and({ first: [ 1, 2 ] })
+          end
+
+          it "adds all conditions" do
+            expect(selection.selector).to eq({
+              'first' => [1, 2],
+              "$and" => [
+                { "first" => [ 1, 2 ] }
+              ]
+            })
+          end
+
+          it_behaves_like 'returns a cloned query'
+        end
+
+        context 'Key criterion' do
+          let(:selection) do
+            query.and({ first: [ 1, 2 ] }).and(:first.gt => 3)
+          end
+
+          it "adds all conditions" do
+            expect(selection.selector).to eq({
+              'first' => [1, 2],
+              "$and" => [
+                { "first" => {'$gt' => 3} }
+              ]
+            })
+          end
+
+          it_behaves_like 'returns a cloned query'
+        end
+
+        context 'Key criterion when existing criterion is an operator' do
+          let(:selection) do
+            query.and(:first.lt => 5).and(:first.gt => 3)
+          end
+
+          it "adds all conditions" do
+            expect(selection.selector).to eq({
+              'first' => {'$lt' => 5, '$gt' => 3},
+            })
+          end
+
+          it_behaves_like 'returns a cloned query'
+        end
+      end
+
+      context "when the new criteria are for different fields" do
+
+        let(:selection) do
+          query.and({ first: [ 1, 2 ] }, { second: [ 3, 4 ] })
+        end
+
+        it "adds all conditions to top level" do
+          expect(selection.selector).to eq({
+            "first" => [ 1, 2 ],
+            "second" => [ 3, 4 ],
+          })
+        end
+
+        it_behaves_like 'returns a cloned query'
+      end
+
+      context "when the new criteria are for the same field" do
+
+        context 'when criteria are simple' do
+          let(:selection) do
+            query.and({ first: [ 1, 2 ] }, { first: [ 3, 4 ] })
+          end
+
+          it "combines via $and operator" do
+            expect(selection.selector).to eq({
+              "first" => [ 1, 2 ],
+              "$and" => [
+                { "first" => [ 3, 4 ] }
+              ]
+            })
+          end
+
+          it_behaves_like 'returns a cloned query'
+        end
+
+        context 'when criteria are handled via Key' do
+          shared_examples_for 'adds the conditions to top level' do
+
+            it "adds the conditions to top level" do
+              expect(selection.selector).to eq({
+                "field" => {'$gt' => 3, '$lt' => 5},
+              })
+            end
+
+            it_behaves_like 'returns a cloned query'
+          end
+
+          context 'criteria are provided in the same hash' do
+            let(:selection) do
+              query.send(tested_method, :field.gt => 3, :field.lt => 5)
+            end
+
+            it_behaves_like 'adds the conditions to top level'
+          end
+
+          context 'criteria are provided in separate hashes' do
+            let(:selection) do
+              query.send(tested_method, {:field.gt => 3}, {:field.lt => 5})
+            end
+
+            it_behaves_like 'adds the conditions to top level'
+          end
+
+          context 'when the criterion is wrapped in an array' do
+            let(:selection) do
+              query.send(tested_method, [:field.gt => 3], [:field.lt => 5])
+            end
+
+            it_behaves_like 'adds the conditions to top level'
+          end
+        end
+
+        context 'when criteria are simple and handled via Key' do
+          shared_examples_for 'combines conditions with $and' do
+
+            it "combines conditions with $and" do
+              expect(selection.selector).to eq({
+                "field" => 3,
+                '$and' => ['field' => {'$lt' => 5}],
+              })
+            end
+
+            it_behaves_like 'returns a cloned query'
+          end
+
+          context 'criteria are provided in the same hash' do
+            let(:selection) do
+              query.send(tested_method, :field => 3, :field.lt => 5)
+            end
+
+            it_behaves_like 'combines conditions with $and'
+          end
+
+          context 'criteria are provided in separate hashes' do
+            let(:selection) do
+              query.send(tested_method, {:field => 3}, {:field.lt => 5})
+            end
+
+            it_behaves_like 'combines conditions with $and'
+          end
+
+          context 'when the criterion is wrapped in an array' do
+            let(:selection) do
+              query.send(tested_method, [:field => 3], [:field.lt => 5])
+            end
+
+            it_behaves_like 'combines conditions with $and'
+          end
+        end
+
+        context 'when criteria are handled via Key and simple' do
+          shared_examples_for 'combines conditions with $and' do
+
+            it "combines conditions with $and" do
+              expect(selection.selector).to eq({
+                "field" => {'$gt' => 3},
+                '$and' => ['field' => 5],
+              })
+            end
+
+            it_behaves_like 'returns a cloned query'
+          end
+
+          context 'criteria are provided in the same hash' do
+            let(:selection) do
+              query.send(tested_method, :field.gt => 3, :field => 5)
+            end
+
+            it_behaves_like 'combines conditions with $and'
+          end
+
+          context 'criteria are provided in separate hashes' do
+            let(:selection) do
+              query.send(tested_method, {:field.gt => 3}, {:field => 5})
+            end
+
+            it_behaves_like 'combines conditions with $and'
+          end
+
+          context 'when the criterion is wrapped in an array' do
+            let(:selection) do
+              query.send(tested_method, [:field.gt => 3], [:field => 5])
+            end
+
+            it_behaves_like 'combines conditions with $and'
+          end
+        end
       end
     end
 
-    context "when provided a single criterion" do
+    context 'when argument is a Criteria' do
+      let(:query) do
+        Mongoid::Query.new.where(hello: 'world')
+      end
+
+      let(:result) { query.and(other) }
+
+      context 'different fields' do
+
+        let(:other) do
+          Mongoid::Query.new.where(foo: 'bar')
+        end
+
+        it 'combines both fields at top level' do
+          expect(result.selector).to eq('hello' => 'world', 'foo' => 'bar')
+        end
+      end
+
+      context 'same field' do
+
+        let(:other) do
+          Mongoid::Query.new.where(hello: /bar/)
+        end
+
+        it 'combines fields with $and' do
+          expect(result.selector).to eq('hello' => 'world', '$and' => [{'hello' => /bar/}])
+        end
+      end
+    end
+
+    context 'when argument is a mix of Criteria and hashes' do
+      let(:query) do
+        Mongoid::Query.new.where(hello: 'world')
+      end
+
+      let(:other1) do
+        Mongoid::Query.new.where(foo: 'bar')
+      end
+
+      let(:other2) do
+        {bar: 42}
+      end
+
+      let(:other3) do
+        Mongoid::Query.new.where(a: 2)
+      end
+
+      let(:result) { query.and(other1, other2, other3) }
+
+      it 'combines' do
+        expect(result.selector).to eq('hello' => 'world',
+          'foo' => 'bar',
+          'bar' => 42,
+          'a' => 2,
+        )
+      end
+    end
+
+    context 'when Key instances are used and types involved have serializers' do
+      let(:time) { Time.now }
+
+      let(:query) do
+        Band.all.and(:created_at.gt => time)
+      end
+
+      let(:expected) do
+        {'created_at' => {'$gt' => time.utc}}
+      end
+
+      it 'combines and evolves' do
+        expect(query.selector).to eq(expected)
+      end
+    end
+
+    describe 'query shape' do
+      shared_examples_for 'adds most recent criterion as $and' do
+        let(:selector) { scope.selector }
+
+        it 'adds most recent criterion as $and' do
+          expect(selector).to eq('foo' => 1, '$and' => [{'foo' => 2}])
+        end
+      end
+
+      context 'and/and' do
+        let(:scope) do
+          Band.and(foo: 1).and(foo: 2)
+        end
+
+        it_behaves_like 'adds most recent criterion as $and'
+      end
+
+      context 'and/and' do
+        let(:scope) do
+          Band.and(foo: 1).and(foo: 2)
+        end
+
+        it_behaves_like 'adds most recent criterion as $and'
+      end
+
+      context 'and/where' do
+        let(:scope) do
+          Band.and(foo: 1).where(foo: 2)
+        end
+
+        it_behaves_like 'adds most recent criterion as $and'
+      end
+
+      context 'where/and' do
+        let(:scope) do
+          Band.where(foo: 1).and(foo: 2)
+        end
+
+        it_behaves_like 'adds most recent criterion as $and'
+      end
+
+      context 'where/where' do
+        let(:scope) do
+          Band.where(foo: 1).where(foo: 2)
+        end
+
+        it_behaves_like 'adds most recent criterion as $and'
+      end
+    end
+
+    context 'when conditions already exist in criteria' do
+      let(:base_selection) do
+        query.where(foo: 'bar')
+      end
+
+      context 'when hash conditions are given' do
+        let(:selection) do
+          base_selection.and(hello: 'world')
+        end
+
+        it 'adds new conditions to top level' do
+          selection.selector.should == {
+            'foo' => 'bar',
+            'hello' => 'world',
+          }
+        end
+      end
+
+      context 'when criteria conditions are given' do
+        let(:selection) do
+          base_selection.and(query.where(hello: 'world'))
+        end
+
+        it 'adds new conditions to top level' do
+          selection.selector.should == {
+            'foo' => 'bar',
+            'hello' => 'world',
+          }
+        end
+      end
+
+      context 'when complex criteria conditions are given' do
+        let(:selection) do
+          base_selection.and(query.or([one: 'one'], [two: 'two']))
+        end
+
+        it 'adds new conditions to top level' do
+          selection.selector.should == {
+            'foo' => 'bar',
+            '$or' => [
+              {'one' => 'one'},
+              {'two' => 'two'},
+            ],
+          }
+        end
+      end
+    end
+  end
+
+  shared_examples '$or/$nor' do
+
+    it_behaves_like 'a non-hoisting logical operation'
+
+    context "when provided no arguments" do
 
       let(:selection) do
-        query.and(field: [ 1, 2 ])
+        query.send(tested_method)
       end
 
-      it "adds the $and selector" do
-        expect(selection.selector).to eq({
-          "$and" => [{ "field" => [ 1, 2 ] }]
-        })
+      it_behaves_like 'returns a cloned query'
+
+      it "does not add any criteria" do
+        expect(selection.selector).to eq({})
       end
 
-      it "returns a cloned query" do
-        expect(selection).to_not equal(query)
+      it "returns the query" do
+        expect(selection).to eq(query)
       end
     end
 
-    context "when provided a nested criterion" do
+    context "when provided nil" do
 
       let(:selection) do
-        query.and(:test.elem_match => { :field.in => [ 1, 2 ] })
+        query.send(tested_method, nil)
       end
 
-      it "adds the $and selector" do
-        expect(selection.selector).to eq({
-          "$and" => [{ "test" => { "$elemMatch" => { "field" => { "$in" => [ 1, 2 ] }}}}]
-        })
+      it_behaves_like 'returns a cloned query'
+
+      it "does not add any criteria" do
+        expect(selection.selector).to eq({})
       end
 
-      it "returns a cloned query" do
-        expect(selection).to_not equal(query)
+      it "returns the query" do
+        expect(selection).to eq(query)
       end
     end
 
-    context "when provided multiple criterion" do
+    context "when provided a single criterion" do
 
-      context "when the criterion is already included" do
+      let(:selection) do
+        query.send(tested_method, field: [ 1, 2 ])
+      end
+
+      it_behaves_like 'returns a cloned query'
+
+      it "adds the $or/$nor selector" do
+        expect(selection.selector).to eq({
+          expected_operator => [{ "field" => [ 1, 2 ] }]
+        })
+      end
+
+      context 'when the criterion is wrapped in array' do
 
         let(:selection) do
-          query.and({ first: [ 1, 2 ] }).and({ first: [ 1, 2 ] })
+          query.send(tested_method, [{ field: [ 1, 2 ] }])
         end
 
-        it "does not duplicate the $and selector" do
+        it_behaves_like 'returns a cloned query'
+
+        it "adds the $or/$nor selector" do
           expect(selection.selector).to eq({
-            "$and" => [
-              { "first" => [ 1, 2 ] }
-            ]
+            expected_operator => [{ "field" => [ 1, 2 ] }]
           })
         end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
+        context 'when the array has nil as one of the elements' do
+
+          let(:selection) do
+            query.send(tested_method, [{ field: [ 1, 2 ] }, nil])
+          end
+
+          it_behaves_like 'returns a cloned query'
+
+          it "adds the $or/$nor selector ignoring the nil element" do
+            expect(selection.selector).to eq({
+              expected_operator => [{ "field" => [ 1, 2 ] }]
+            })
+          end
         end
       end
 
-      context "when the criterion are for different fields" do
+      context 'when query already has a condition on another field' do
 
         let(:selection) do
-          query.and({ first: [ 1, 2 ] }, { second: [ 3, 4 ] })
+          query.where(foo: 'bar').send(tested_method, field: [ 1, 2 ])
         end
 
-        it "adds the $and selector" do
+        it 'moves original conditions under $or/$nor' do
           expect(selection.selector).to eq({
-            "$and" => [
+            expected_operator => [{'foo' => 'bar'}, { "field" => [ 1, 2 ] }]
+          })
+        end
+      end
+
+      context 'when query already has an $or/$nor condition and another condition' do
+
+        let(:selection) do
+          query.send(tested_method, field: [ 1, 2 ]).where(foo: 'bar').send(tested_method, test: 1)
+        end
+
+        it 'unions existing conditions' do
+          expect(selection.selector).to eq(
+            expected_operator => [
+              {
+                expected_operator => [{ "field" => [ 1, 2 ] }],
+                'foo' => 'bar',
+              },
+              {'test' => 1},
+            ]
+          )
+        end
+      end
+    end
+
+    context "when provided multiple criteria" do
+
+      context "when the criteria are for different fields" do
+
+        let(:selection) do
+          query.send(tested_method, { first: [ 1, 2 ] }, { second: [ 3, 4 ] })
+        end
+
+        it_behaves_like 'returns a cloned query'
+
+        it "adds the $or/$nor selector" do
+          expect(selection.selector).to eq({
+            expected_operator => [
               { "first" => [ 1, 2 ] },
               { "second" => [ 3, 4 ] }
             ]
           })
         end
+      end
+
+      context "when the criteria uses a Key instance" do
+
+        let(:selection) do
+          query.send(tested_method, { first: [ 1, 2 ] }, { :second.gt => 3 })
+        end
+
+        it "adds the $or/$nor selector" do
+          expect(selection.selector).to eq({
+            expected_operator => [
+              { "first" => [ 1, 2 ] },
+              { "second" => { "$gt" => 3 }}
+            ]
+          })
+        end
+
+        it_behaves_like 'returns a cloned query'
+
+        context 'when the criterion is a time' do
+          let(:selection) do
+            query.send(tested_method, :field.gte => Time.new(2020, 1, 1))
+          end
+
+          it 'adds the conditions' do
+            expect(selection.selector).to eq(expected_operator => [
+              "field" => {'$gte' => Time.new(2020, 1, 1)},
+            ])
+          end
+
+          it 'keeps the type' do
+            selection.selector[expected_operator].first['field']['$gte'].should be_a(Time)
+          end
+        end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
+        context 'when the criterion is a datetime' do
+          let(:selection) do
+            query.send(tested_method, :field.gte => DateTime.new(2020, 1, 1))
+          end
+
+          it 'adds the conditions' do
+            expect(selection.selector).to eq(expected_operator => [
+              "field" => {'$gte' => Time.utc(2020, 1, 1)},
+            ])
+          end
+
+          it 'converts argument to a time' do
+            selection.selector[expected_operator].first['field']['$gte'].should be_a(Time)
+          end
+        end
+
+        context 'when the criterion is a date' do
+          let(:selection) do
+            query.send(tested_method, :field.gte => Date.new(2020, 1, 1))
+          end
+
+          it 'adds the conditions' do
+            expect(selection.selector).to eq(expected_operator => [
+              "field" => {'$gte' => Time.utc(2020, 1, 1)},
+            ])
+          end
+
+          it 'converts argument to a time' do
+            selection.selector[expected_operator].first['field']['$gte'].should be_a(Time)
+          end
         end
       end
 
-      context "when the criterion are on the same field" do
+      context "when a criterion has an aliased field" do
 
         let(:selection) do
-          query.and({ first: [ 1, 2 ] }, { first: [ 3, 4 ] })
+          query.send(tested_method, { id: 1 })
         end
 
-        it "appends both $and expressions" do
+        it "adds the $or/$nor selector and aliases the field" do
           expect(selection.selector).to eq({
-            "$and" => [
+            expected_operator => [ { "_id" => 1 } ]
+          })
+        end
+
+        it_behaves_like 'returns a cloned query'
+      end
+
+      context "when a criterion is wrapped in an array" do
+
+        let(:selection) do
+          query.send(tested_method, [{ first: [ 1, 2 ] }, { :second.gt => 3 }])
+        end
+
+        it_behaves_like 'returns a cloned query'
+
+        it "adds the $or/$nor selector" do
+          expect(selection.selector).to eq({
+            expected_operator => [
               { "first" => [ 1, 2 ] },
-              { "first" => [ 3, 4 ] }
+              { "second" => { "$gt" => 3 }}
             ]
           })
         end
+      end
+
+      context "when the criteria are on the same field" do
+
+        context 'simple criteria' do
+          let(:selection) do
+            query.send(tested_method, { first: [ 1, 2 ] }, { first: [ 3, 4 ] })
+          end
+
+          it_behaves_like 'returns a cloned query'
+
+          it "appends both $or/$nor expressions" do
+            expect(selection.selector).to eq({
+              expected_operator => [
+                { "first" => [ 1, 2 ] },
+                { "first" => [ 3, 4 ] }
+              ]
+            })
+          end
+        end
+
+        context 'Key criteria as one argument' do
+          let(:selection) do
+            query.send(tested_method, :first.gt => 3, :first.lt => 5)
+          end
+
+          it_behaves_like 'returns a cloned query'
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
+          it "adds all criteria" do
+            expect(selection.selector).to eq({
+              expected_operator => [
+                { "first" => {'$gt' => 3, '$lt' => 5} },
+              ]
+            })
+          end
+        end
+
+        context 'Key criteria as multiple arguments' do
+          let(:selection) do
+            query.send(tested_method, {:first.gt => 3}, {:first.lt => 5})
+          end
+
+          it_behaves_like 'returns a cloned query'
+
+          it "adds all criteria" do
+            expect(selection.selector).to eq({
+              expected_operator => [
+                { "first" => {'$gt' => 3} },
+                { "first" => {'$lt' => 5} },
+              ]
+            })
+          end
         end
       end
     end
@@ -150,385 +998,452 @@ describe Mongoid::Criteria::Queryable::Selectable do
       context "when the criterion are for different fields" do
 
         let(:selection) do
-          query.and(first: [ 1, 2 ]).and(second: [ 3, 4 ])
+          query.send(tested_method, first: [ 1, 2 ]).send(tested_method, second: [ 3, 4 ])
         end
 
-        it "adds the $and selectors" do
+        it_behaves_like 'returns a cloned query'
+
+        it "adds the $or/$nor selectors" do
           expect(selection.selector).to eq({
-            "$and" => [
+            expected_operator => [
               { "first" => [ 1, 2 ] },
               { "second" => [ 3, 4 ] }
             ]
           })
         end
-
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
-        end
       end
 
       context "when the criterion are on the same field" do
 
         let(:selection) do
-          query.and(first: [ 1, 2 ]).and(first: [ 3, 4 ])
+          query.send(tested_method, first: [ 1, 2 ]).send(tested_method, first: [ 3, 4 ])
         end
 
-        it "appends both $and expressions" do
+        it_behaves_like 'returns a cloned query'
+
+        it "appends both $or/$nor expressions" do
           expect(selection.selector).to eq({
-            "$and" => [
+            expected_operator => [
               { "first" => [ 1, 2 ] },
               { "first" => [ 3, 4 ] }
             ]
           })
         end
-
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
-        end
       end
     end
   end
 
   describe "#or" do
 
-    context "when provided no criterion" do
+    let(:tested_method) { :or }
+    let(:expected_operator) { '$or' }
+
+    it_behaves_like '$or/$nor'
+  end
+
+  describe "#nor" do
+
+    let(:tested_method) { :nor }
+    let(:expected_operator) { '$nor' }
+
+    it_behaves_like '$or/$nor'
+  end
+
+  describe "#any_of" do
+
+    let(:tested_method) { :any_of }
+    let(:expected_operator) { '$or' }
+
+    it_behaves_like 'a hoisting logical operation'
+
+    # When multiple arguments are given to any_of, it behaves differently
+    # from and.
+    context 'when argument is a mix of Criteria and hashes' do
+      let(:query) do
+        Mongoid::Query.new.where(hello: 'world')
+      end
+
+      let(:other1) do
+        Mongoid::Query.new.where(foo: 'bar')
+      end
+
+      let(:other2) do
+        {bar: 42}
+      end
+
+      let(:other3) do
+        Mongoid::Query.new.where(a: 2)
+      end
+
+      let(:result) { query.send(tested_method, other1, other2, other3) }
+
+      it 'combines' do
+        expect(result.selector).to eq(
+          'hello' => 'world',
+          expected_operator => [
+            {'foo' => 'bar'},
+            {'bar' => 42},
+            {'a' => 2},
+          ],
+        )
+      end
+    end
+
+    context "when provided no arguments" do
 
       let(:selection) do
-        query.or
+        query.any_of
       end
 
-      it "does not add any criterion" do
+      it_behaves_like 'returns a cloned query'
+
+      it "does not add any criteria" do
         expect(selection.selector).to eq({})
       end
 
       it "returns the query" do
         expect(selection).to eq(query)
       end
-
-      it "returns a cloned query" do
-        expect(selection).to_not equal(query)
-      end
     end
 
     context "when provided nil" do
 
       let(:selection) do
-        query.or(nil)
+        query.any_of(nil)
       end
 
-      it "does not add any criterion" do
+      it_behaves_like 'returns a cloned query'
+
+      it "does not add any criteria" do
         expect(selection.selector).to eq({})
       end
 
       it "returns the query" do
         expect(selection).to eq(query)
       end
-
-      it "returns a cloned query" do
-        expect(selection).to_not equal(query)
-      end
     end
 
     context "when provided a single criterion" do
 
       let(:selection) do
-        query.or(field: [ 1, 2 ])
+        query.any_of(field: [ 1, 2 ])
       end
 
+      it_behaves_like 'returns a cloned query'
+
       it "adds the $or selector" do
-        expect(selection.selector).to eq({
-          "$or" => [{ "field" => [ 1, 2 ] }]
-        })
+        expect(selection.selector).to eq(
+          "field" => [ 1, 2 ],
+        )
       end
 
-      it "returns a cloned query" do
-        expect(selection).to_not equal(query)
-      end
-    end
+      context 'when the criterion is wrapped in array' do
 
-    context "when provided multiple criterion" do
+        let(:selection) do
+          query.any_of([{ field: [ 1, 2 ] }])
+        end
+
+        it_behaves_like 'returns a cloned query'
+
+        it "adds the condition" do
+          expect(selection.selector).to eq(
+            "field" => [ 1, 2 ],
+          )
+        end
 
-      context "when the criterion are for different fields" do
+        context 'when the array has nil as one of the elements' do
 
-        let(:selection) do
-          query.or({ first: [ 1, 2 ] }, { second: [ 3, 4 ] })
-        end
+          let(:selection) do
+            query.any_of([{ field: [ 1, 2 ] }, nil])
+          end
 
-        it "adds the $or selector" do
-          expect(selection.selector).to eq({
-            "$or" => [
-              { "first" => [ 1, 2 ] },
-              { "second" => [ 3, 4 ] }
-            ]
-          })
-        end
+          it_behaves_like 'returns a cloned query'
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
+          it "adds the $or selector ignoring the nil element" do
+            expect(selection.selector).to eq(
+              "field" => [ 1, 2 ],
+            )
+          end
         end
       end
 
-      context "when a criterion has a selectable key" do
+      context 'when query already has a condition on another field' do
 
-        let(:selection) do
-          query.or({ first: [ 1, 2 ] }, { :second.gt => 3 })
-        end
+        context 'when there is one argument' do
 
-        it "adds the $or selector" do
-          expect(selection.selector).to eq({
-            "$or" => [
-              { "first" => [ 1, 2 ] },
-              { "second" => { "$gt" => 3 }}
-            ]
-          })
+          let(:selection) do
+            query.where(foo: 'bar').any_of(field: [ 1, 2 ])
+          end
+
+          it 'adds the new condition' do
+            expect(selection.selector).to eq(
+              'foo' => 'bar',
+              'field' => [1, 2],
+            )
+          end
         end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
+        context 'when there are multiple arguments' do
+
+          let(:selection) do
+            query.where(foo: 'bar').any_of({field: [ 1, 2 ]}, {hello: 'world'})
+          end
+
+          it 'adds the new condition' do
+            expect(selection.selector).to eq(
+              'foo' => 'bar',
+              '$or' => [
+                {'field' => [1, 2]},
+                {'hello' => 'world'},
+              ],
+            )
+          end
         end
       end
 
-      context "when the criterion has an aliased field" do
+      context 'when query already has an $or condition and another condition' do
 
         let(:selection) do
-          query.or({ id: 1 })
-        end
-
-        it "adds the $or selector and aliases the field" do
-          expect(selection.selector).to eq({
-            "$or" => [ { "_id" => 1 } ]
-          })
+          query.or(field: [ 1, 2 ]).where(foo: 'bar').any_of(test: 1)
         end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
+        it 'adds the new condition' do
+          expect(selection.selector).to eq(
+            '$or' => [{'field' => [1, 2]}],
+            'foo' => 'bar',
+            'test' => 1,
+          )
         end
       end
+    end
 
-      context "when a criterion is wrapped in an array" do
+    context "when provided multiple criteria" do
+
+      context "when the criteria are for different fields" do
 
         let(:selection) do
-          query.or([{ first: [ 1, 2 ] }, { :second.gt => 3 }])
+          query.any_of({ first: [ 1, 2 ] }, { second: [ 3, 4 ] })
         end
 
+        it_behaves_like 'returns a cloned query'
+
         it "adds the $or selector" do
           expect(selection.selector).to eq({
             "$or" => [
               { "first" => [ 1, 2 ] },
-              { "second" => { "$gt" => 3 }}
+              { "second" => [ 3, 4 ] }
             ]
           })
         end
-
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
-        end
       end
 
-      context "when the criterion are on the same field" do
+      context "when the criteria uses a Key instance" do
 
         let(:selection) do
-          query.or({ first: [ 1, 2 ] }, { first: [ 3, 4 ] })
+          query.any_of({ first: [ 1, 2 ] }, { :second.gt => 3 })
         end
 
-        it "appends both $or expressions" do
+        it "adds the $or selector" do
           expect(selection.selector).to eq({
             "$or" => [
               { "first" => [ 1, 2 ] },
-              { "first" => [ 3, 4 ] }
+              { "second" => { "$gt" => 3 }}
             ]
           })
         end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
-        end
+        it_behaves_like 'returns a cloned query'
       end
-    end
 
-    context "when chaining the criterion" do
+      context 'when criteria are simple and handled via Key' do
+        shared_examples_for 'adds conditions with $or' do
 
-      context "when the criterion are for different fields" do
+          it "adds conditions with $or" do
+            expect(selection.selector).to eq({
+              '$or' => [
+                {'field' => 3},
+                {'field' => {'$lt' => 5}},
+              ],
+            })
+          end
 
-        let(:selection) do
-          query.or(first: [ 1, 2 ]).or(second: [ 3, 4 ])
+          it_behaves_like 'returns a cloned query'
         end
 
-        it "adds the $or selectors" do
-          expect(selection.selector).to eq({
-            "$or" => [
-              { "first" => [ 1, 2 ] },
-              { "second" => [ 3, 4 ] }
-            ]
-          })
-        end
+        shared_examples_for 'adds one condition' do
+
+          it "adds one condition" do
+            expect(selection.selector).to eq({
+              'field' => 3,
+              '$and' => [
+                {'field' => {'$lt' => 5}},
+              ],
+            })
+          end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
+          it_behaves_like 'returns a cloned query'
         end
-      end
 
-      context "when the criterion are on the same field" do
+        context 'criteria are provided in the same hash' do
+          let(:selection) do
+            query.send(tested_method, :field => 3, :field.lt => 5)
+          end
 
-        let(:selection) do
-          query.or(first: [ 1, 2 ]).or(first: [ 3, 4 ])
+          it_behaves_like 'adds one condition'
         end
 
-        it "appends both $or expressions" do
-          expect(selection.selector).to eq({
-            "$or" => [
-              { "first" => [ 1, 2 ] },
-              { "first" => [ 3, 4 ] }
-            ]
-          })
+        context 'criteria are provided in separate hashes' do
+          let(:selection) do
+            query.send(tested_method, {:field => 3}, {:field.lt => 5})
+          end
+
+          it_behaves_like 'adds conditions with $or'
         end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
+        context 'when the criterion is wrapped in an array' do
+          let(:selection) do
+            query.send(tested_method, [:field => 3], [:field.lt => 5])
+          end
+
+          it_behaves_like 'adds conditions with $or'
         end
       end
-    end
-  end
 
-  describe "#nor" do
+      context 'when criteria are handled via Key and simple' do
+        shared_examples_for 'adds conditions with $or' do
 
-    context "when provided no criterion" do
+          it "adds conditions with $or" do
+            expect(selection.selector).to eq({
+              '$or' => [
+                {'field' => {'$gt' => 3}},
+                {'field' => 5},
+              ],
+            })
+          end
 
-      let(:selection) do
-        query.nor
-      end
+          it_behaves_like 'returns a cloned query'
+        end
 
-      it "does not add any criterion" do
-        expect(selection.selector).to eq({})
-      end
+        shared_examples_for 'adds one condition' do
 
-      it "returns the query" do
-        expect(selection).to eq(query)
-      end
+          it "adds one condition" do
+            expect(selection.selector).to eq({
+              'field' => {'$gt' => 3},
+              '$and' => ['field' => 5],
+            })
+          end
 
-      it "returns a cloned query" do
-        expect(selection).to_not equal(query)
-      end
-    end
+          it_behaves_like 'returns a cloned query'
+        end
 
-    context "when provided nil" do
+        context 'criteria are provided in the same hash' do
+          let(:selection) do
+            query.send(tested_method, :field.gt => 3, :field => 5)
+          end
 
-      let(:selection) do
-        query.nor(nil)
-      end
+          it_behaves_like 'adds one condition'
+        end
 
-      it "does not add any criterion" do
-        expect(selection.selector).to eq({})
-      end
+        context 'criteria are provided in separate hashes' do
+          let(:selection) do
+            query.send(tested_method, {:field.gt => 3}, {:field => 5})
+          end
 
-      it "returns the query" do
-        expect(selection).to eq(query)
-      end
+          it_behaves_like 'adds conditions with $or'
+        end
 
-      it "returns a cloned query" do
-        expect(selection).to_not equal(query)
+        context 'when the criterion is wrapped in an array' do
+          let(:selection) do
+            query.send(tested_method, [:field.gt => 3], [:field => 5])
+          end
+
+          it_behaves_like 'adds conditions with $or'
+        end
       end
-    end
 
-    context "when provided a single criterion" do
+      context "when a criterion has an aliased field" do
 
-      let(:selection) do
-        query.nor(field: [ 1, 2 ])
-      end
+        let(:selection) do
+          query.any_of({ id: 1 })
+        end
 
-      it "adds the $nor selector" do
-        expect(selection.selector).to eq({
-          "$nor" => [{"field" => [ 1, 2 ] }]
-        })
-      end
+        it "adds the $or selector and aliases the field" do
+          expect(selection.selector).to eq(
+            "_id" => 1,
+          )
+        end
 
-      it "returns a cloned query" do
-        expect(selection).to_not equal(query)
+        it_behaves_like 'returns a cloned query'
       end
-    end
 
-    context "when provided multiple criterion" do
-
-      context "when the criterion are fnor different fields" do
+      context "when a criterion is wrapped in an array" do
 
         let(:selection) do
-          query.nor({ first: [ 1, 2 ] }, { second: [ 3, 4 ] })
+          query.any_of([{ first: [ 1, 2 ] }, { :second.gt => 3 }])
         end
 
-        it "adds the $nor selector" do
+        it_behaves_like 'returns a cloned query'
+
+        it "adds the $or selector" do
           expect(selection.selector).to eq({
-            "$nor" => [
+            "$or" => [
               { "first" => [ 1, 2 ] },
-              { "second" => [ 3, 4 ] }
+              { "second" => { "$gt" => 3 }}
             ]
           })
         end
-
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
-        end
       end
 
-      context "when the criterion are on the same field" do
+      context "when the criteria are on the same field" do
 
         let(:selection) do
-          query.nor({ first: [ 1, 2 ] }, { first: [ 3, 4 ] })
+          query.any_of({ first: [ 1, 2 ] }, { first: [ 3, 4 ] })
         end
 
-        it "appends both $nor expressions" do
+        it_behaves_like 'returns a cloned query'
+
+        it "appends both $or expressions" do
           expect(selection.selector).to eq({
-            "$nor" => [
+            "$or" => [
               { "first" => [ 1, 2 ] },
               { "first" => [ 3, 4 ] }
             ]
           })
         end
-
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
-        end
       end
     end
 
-    context "when chaining the criterion" do
+    context "when chaining the criteria" do
 
-      context "when the criterion are fnor different fields" do
+      context "when the criteria are for different fields" do
 
         let(:selection) do
-          query.nor(first: [ 1, 2 ]).nor(second: [ 3, 4 ])
+          query.any_of(first: [ 1, 2 ]).any_of(second: [ 3, 4 ])
         end
 
-        it "adds the $nor selectors" do
-          expect(selection.selector).to eq({
-            "$nor" => [
-              { "first" => [ 1, 2 ] },
-              { "second" => [ 3, 4 ] }
-            ]
-          })
-        end
+        it_behaves_like 'returns a cloned query'
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
+        it "adds the conditions separately" do
+          expect(selection.selector).to eq(
+            "first" => [ 1, 2 ],
+            "second" => [ 3, 4 ],
+          )
         end
       end
 
-      context "when the criterion are on the same field" do
+      context "when the criteria are on the same field" do
 
         let(:selection) do
-          query.nor(first: [ 1, 2 ]).nor(first: [ 3, 4 ])
+          query.any_of(first: [ 1, 2 ]).any_of(first: [ 3, 4 ])
         end
 
-        it "appends both $nor expressions" do
-          expect(selection.selector).to eq({
-            "$nor" => [
-              { "first" => [ 1, 2 ] },
-              { "first" => [ 3, 4 ] }
-            ]
-          })
-        end
+        it_behaves_like 'returns a cloned query'
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
+        it "adds the conditions separately" do
+          expect(selection.selector).to eq(
+            "first" => [ 1, 2 ],
+            '$and' => [{"first" => [ 3, 4 ]}],
+          )
         end
       end
     end
@@ -561,27 +1476,45 @@ describe Mongoid::Criteria::Queryable::Selectable do
         expect(query.negating).to be nil
       end
 
-      context "when the following criteria is a query method" do
-
+      shared_examples_for 'negates the next condition' do
         let(:selection) do
-          query.not.all(field: [ 1, 2 ])
+          query.not.send(query_method, field: [ 1, 2 ])
         end
 
-        it "negates the all selection" do
+        it "negates the next condition" do
           expect(selection.selector).to eq(
-            { "field" => { "$not" => { "$all" => [ 1, 2 ] }}}
+            { "field" => { "$not" => { operator => [ 1, 2 ] }}}
           )
         end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
-        end
+        it_behaves_like 'returns a cloned query'
 
         it "removes the negation on the clone" do
           expect(selection).to_not be_negating
         end
       end
 
+      context "when the next condition is #all" do
+        let(:query_method) { :all }
+        let(:operator) { '$all' }
+
+        it_behaves_like 'negates the next condition'
+      end
+
+      context "when the next condition is #in" do
+        let(:query_method) { :in }
+        let(:operator) { '$in' }
+
+        it_behaves_like 'negates the next condition'
+      end
+
+      context "when the next condition is #nin" do
+        let(:query_method) { :nin }
+        let(:operator) { '$nin' }
+
+        it_behaves_like 'negates the next condition'
+      end
+
       context "when the following criteria is a gt method" do
 
         let(:selection) do
@@ -594,10 +1527,27 @@ describe Mongoid::Criteria::Queryable::Selectable do
           )
         end
 
-        it "returns a coned query" do
-          expect(selection).to_not eq(query)
+        it_behaves_like 'returns a cloned query'
+
+        it "removes the negation on the clone" do
+          expect(selection).to_not be_negating
+        end
+      end
+
+      context "when the criteria uses Key" do
+
+        let(:selection) do
+          query.not(:age.gt => 50)
+        end
+
+        it "negates the gt selection" do
+          expect(selection.selector).to eq(
+            '$and' => ['$nor' => ['age' => {'$gt' => 50}]]
+          )
         end
 
+        it_behaves_like 'returns a cloned query'
+
         it "removes the negation on the clone" do
           expect(selection).to_not be_negating
         end
@@ -615,9 +1565,7 @@ describe Mongoid::Criteria::Queryable::Selectable do
           )
         end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
-        end
+        it_behaves_like 'returns a cloned query'
 
         it "removes the negation on the clone" do
           expect(selection).to_not be_negating
@@ -636,10 +1584,27 @@ describe Mongoid::Criteria::Queryable::Selectable do
           )
         end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
+        it_behaves_like 'returns a cloned query'
+
+        it "removes the negation on the clone" do
+          expect(selection).to_not be_negating
+        end
+      end
+
+      context 'when the following criteria uses string were form' do
+
+        let(:selection) do
+          query.not.where('hello world')
+        end
+
+        it "negates the selection with an operator" do
+          expect(selection.selector).to eq(
+            '$and' => [{'$nor' => [{'$where' => 'hello world'}]}]
+          )
         end
 
+        it_behaves_like 'returns a cloned query'
+
         it "removes the negation on the clone" do
           expect(selection).to_not be_negating
         end
@@ -661,9 +1626,7 @@ describe Mongoid::Criteria::Queryable::Selectable do
         expect(selection).to eq(query)
       end
 
-      it "returns a cloned query" do
-        expect(selection).to_not equal(query)
-      end
+      it_behaves_like 'returns a cloned query'
     end
 
     context "when provided a single criterion" do
@@ -678,14 +1641,31 @@ describe Mongoid::Criteria::Queryable::Selectable do
         })
       end
 
-      it "returns a cloned query" do
-        expect(selection).to_not equal(query)
+      it_behaves_like 'returns a cloned query'
+    end
+
+    context "when negating a field in the original selector" do
+      let(:query) do
+        Mongoid::Query.new("id" => "_id").where(field: 'foo')
       end
+
+      let(:selection) do
+        query.not(field: 'bar')
+      end
+
+      it "combines the conditions" do
+        expect(selection.selector).to eq({
+          "field" => 'foo',
+          '$and' => [{'$nor' => [{ "field" => 'bar' }]}],
+        })
+      end
+
+      it_behaves_like 'returns a cloned query'
     end
 
-    context "when provided multiple criterion" do
+    context "when provided multiple criteria" do
 
-      context "when the criterion are for different fields" do
+      context "when the criteria are for different fields" do
 
         let(:selection) do
           query.not(first: /1/, second: /2/)
@@ -698,9 +1678,23 @@ describe Mongoid::Criteria::Queryable::Selectable do
           })
         end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
+        it_behaves_like 'returns a cloned query'
+      end
+
+      context "when the criteria are given in separate arguments" do
+
+        let(:selection) do
+          query.not({first: /1/}, {second: /2/})
+        end
+
+        it "adds the $not selectors" do
+          expect(selection.selector).to eq({
+            "first" => { "$not" => /1/ },
+            "second" => { "$not" => /2/ }
+          })
         end
+
+        it_behaves_like 'returns a cloned query'
       end
     end
 
@@ -719,9 +1713,7 @@ describe Mongoid::Criteria::Queryable::Selectable do
           })
         end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
-        end
+        it_behaves_like 'returns a cloned query'
       end
 
       context "when the criterion are on the same field" do
@@ -730,15 +1722,14 @@ describe Mongoid::Criteria::Queryable::Selectable do
           query.not(first: /1/).not(first: /2/)
         end
 
-        it "overwrites the first $not selector" do
-          expect(selection.selector).to eq({
-            "first" =>  { "$not" => /2/ }
-          })
+        it "combines conditions" do
+          expect(selection.selector).to eq(
+            "first" =>  { "$not" => /1/ },
+            '$and' => [{'$nor' => [{'first' => /2/}]}],
+          )
         end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
-        end
+        it_behaves_like 'returns a cloned query'
       end
 
       context "when the criterion are a double negative" do
@@ -753,9 +1744,85 @@ describe Mongoid::Criteria::Queryable::Selectable do
           })
         end
 
-        it "returns a cloned query" do
-          expect(selection).to_not equal(query)
-        end
+        it_behaves_like 'returns a cloned query'
+      end
+    end
+
+    context 'when argument is a Criteria' do
+      let(:query) do
+        Mongoid::Query.new.where(hello: 'world')
+      end
+
+      let(:other) do
+        Mongoid::Query.new.where(foo: 'bar')
+      end
+
+      let(:result) { query.not(other) }
+
+      it 'combines' do
+        expect(result.selector).to eq('hello' => 'world', 'foo' => {'$ne' => 'bar'})
+      end
+    end
+
+    context 'when argument is a simple Criteria with multiple fields' do
+      let(:query) do
+        Mongoid::Query.new.where(hello: 'world')
+      end
+
+      let(:other) do
+        Mongoid::Query.new.where(a: 1, b: 2)
+      end
+
+      let(:result) { query.not(other) }
+
+      it 'combines fields into top level criteria' do
+        expect(result.selector).to eq('hello' => 'world',
+          'a' => {'$ne' => 1}, 'b' => {'$ne' => 2})
+      end
+    end
+
+    context 'when argument is a complex Criteria' do
+      let(:query) do
+        Mongoid::Query.new.where(hello: 'world')
+      end
+
+      let(:other) do
+        Mongoid::Query.new.where('$nor' => [{a: 1, b: 2}])
+      end
+
+      let(:result) { query.not(other) }
+
+      it 'combines with $and of $nor' do
+        expect(result.selector).to eq('hello' => 'world', '$and' => [{'$nor' => [{
+          '$nor' => [{'a' => 1, 'b' => 2}]}]}])
+      end
+    end
+
+    context 'when argument is a mix of Criteria and hashes' do
+      let(:query) do
+        Mongoid::Query.new.where(hello: 'world')
+      end
+
+      let(:other1) do
+        Mongoid::Query.new.where(foo: 'bar')
+      end
+
+      let(:other2) do
+        {bar: 42}
+      end
+
+      let(:other3) do
+        Mongoid::Query.new.where(a: 2)
+      end
+
+      let(:result) { query.not(other1, other2, other3) }
+
+      it 'combines' do
+        expect(result.selector).to eq('hello' => 'world',
+          'foo' => {'$ne' => 'bar'},
+          'bar' => {'$ne' => 42},
+          'a' => {'$ne' => 2},
+        )
       end
     end
   end