mongoid 7.0.6 → 7.1.2

data/spec/mongoid/association/polymorphic_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe "Polymorphic Associations" do

data/spec/mongoid/association/referenced/belongs_to/binding_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::BelongsTo::Binding do

data/spec/mongoid/association/referenced/belongs_to/buildable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::BelongsTo::Buildable do

data/spec/mongoid/association/referenced/belongs_to/eager_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 require_relative '../has_many_models'
 
@@ -75,6 +78,9 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
     end
 
     context "when including the belongs_to association" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       it "queries twice" do
 
@@ -87,6 +93,9 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
     end
 
     context "when the association is not polymorphic" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       let(:eager) do
         Post.includes(:person).last
@@ -105,13 +114,13 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
         end
 
         it "does not query when touching the association" do
-          expect_query(0) do
+          expect_no_queries do
             expect(eager.person).to eq(person)
           end
         end
 
         it "does not query when updating the association" do
-          expect_query(0) do
+          expect_no_queries do
             eager.person.username = "arthurnn"
           end
         end
@@ -137,18 +146,201 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
 
     context "when the association is polymorphic" do
 
-      let!(:movie) do
-        Movie.create(name: "Bladerunner")
+      context "without namespaces" do
+
+        let!(:stand_alone_rating) do
+          Rating.create(value: 7)
+        end
+
+        let!(:bar) do
+          Bar.create(name: "FooBar")
+        end
+
+        let(:bar_rating) do
+          bar.create_rating(value: 5)
+        end
+
+        let!(:movie) do
+          Movie.create(name: "Bladerunner")
+        end
+
+        let(:movie_rating) do
+          movie.ratings.create(value: 10)
+        end
+
+        let(:eager) do
+          Rating.includes(:ratable).entries
+        end
+
+        context "when the eager load has returned documents" do
+
+          before do
+            bar_rating
+            movie_rating
+            eager
+          end
+
+          it "puts the documents in the parent document" do
+            expect(eager.map { |e| e.ivar(:ratable) }).to eq([nil, bar, movie])
+          end
+
+          it "does not query when touching the association" do
+            expect_no_queries do
+              expect(eager.map(&:ratable)).to eq([nil, bar, movie])
+            end
+          end
+
+          it "does not query when updating the association" do
+            expect_no_queries do
+              eager.last.ratable.name = "Easy rider"
+            end
+          end
+        end
+
+        context "when the eager load has not returned documents" do
+
+          before { eager }
+
+          it "does not set anything on the parent" do
+            expect(eager.map { |e| e.ivar(:ratable) }).to all(be nil)
+          end
+
+          it "has a nil association" do
+            expect(eager.map(&:ratable)).to all(be nil)
+          end
+        end
       end
 
-      let!(:rating) do
-        movie.ratings.create(value: 10)
+      context "with namespaces" do
+
+        let!(:stand_alone_review) do
+          Publication::Review.create(summary: "awful")
+        end
+
+        let!(:encyclopedia) do
+          Publication::Encyclopedia.create(title: "Encyclopedia Britannica")
+        end
+
+        let(:encyclopedia_review) do
+          encyclopedia.reviews.create(summary: "inspiring")
+        end
+
+        let!(:pull_request) do
+          Coding::PullRequest.create(title: "Add eager loading for polymorphic belongs_to associations")
+        end
+
+        let(:pull_request_review) do
+          pull_request.reviews.create(summary: "Looks good to me")
+        end
+
+        let(:eager) do
+          Publication::Review.includes(:reviewable).entries
+        end
+
+        context "when the eager load has returned documents" do
+
+          before do
+            encyclopedia_review
+            pull_request_review
+            eager
+          end
+
+          it "puts the documents in the parent document" do
+            expect(eager.map { |e| e.ivar(:reviewable) }).to eq([nil, encyclopedia, pull_request])
+          end
+
+          it "does not query when touching the association" do
+            expect_no_queries do
+              expect(eager.map(&:reviewable)).to eq([nil, encyclopedia, pull_request])
+            end
+          end
+
+          it "does not query when updating the association" do
+            expect_no_queries do
+              eager.last.reviewable.title = "Load stuff eagerly"
+            end
+          end
+        end
+
+        context "when the eager load has not returned documents" do
+
+          before { eager }
+
+          it "does not set anything on the parent" do
+            expect(eager.map { |e| e.ivar(:reviewable) }).to all(be nil)
+          end
+
+          it "has a nil association" do
+            expect(eager.map(&:reviewable)).to all(be nil)
+          end
+        end
+      end
+
+      context 'when eager loading multiple associations' do
+        let(:reviewable) do
+          Publication::Encyclopedia.create!(title: "Encyclopedia Britannica")
+        end
+
+        let!(:reviewable_review) do
+          Publication::Review.create!(summary: "awful",
+            reviewable: reviewable)
+        end
+
+        let(:reviewer) do
+          Dog.create!
+        end
+
+        let!(:reviewer_review) do
+          Publication::Review.create(summary: "okay",
+            reviewer: reviewer)
+        end
+
+        let(:template) do
+          Template.create!
+        end
+
+        let!(:template_review) do
+          Publication::Review.create(summary: "Looks good to me",
+            template: template)
+        end
+
+        let(:eager) do
+          Publication::Review.includes(:reviewable, :reviewer, :template).entries
+        end
+
+        it 'loads all associations eagerly' do
+          loaded = expect_query(4) do
+            eager
+          end
+
+          expect_no_queries do
+            eager.map(&:reviewable).compact.should == [reviewable]
+          end
+
+          expect_no_queries do
+            eager.map(&:reviewer).compact.should == [reviewer]
+          end
+
+          expect_no_queries do
+            eager.map(&:template).compact.should == [template]
+          end
+        end
       end
 
-      it "raises an error" do
-        expect {
-          Rating.includes(:ratable).last
-        }.to raise_error(Mongoid::Errors::EagerLoad)
+      context 'when eager loading an association that has type but not value set' do
+
+        let!(:reviewer_review) do
+          Publication::Review.create(summary: "okay",
+            reviewer_type: 'Dog')
+        end
+
+        let(:eager) do
+          Publication::Review.includes(:reviewable, :reviewer, :template).entries
+        end
+
+        it 'does not error' do
+          eager.map(&:reviewer).should == [nil]
+        end
       end
     end
 
@@ -162,6 +354,9 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
     end
 
     context "when all the values for the belongs_to association are nil" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       before do
         2.times { |i| HmmTicket.create!(person: nil) }

data/spec/mongoid/association/referenced/belongs_to/proxy_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::BelongsTo::Proxy do

data/spec/mongoid/association/referenced/belongs_to_query_spec.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+require_relative './has_many_models'
+
+describe Mongoid::Association::Referenced::BelongsTo do
+  context 'when projecting with #only' do
+    before do
+      school = HmmSchool.create!(district: 'foo', team: 'Bulldogs')
+      HmmStudent.create!(school: school, name: 'Dave', grade: 10)
+    end
+
+    let(:student) do
+      HmmStudent.where(name: 'Dave').only(:school_id, 'school._id', 'school.district').first
+    end
+
+    let(:school) { student.school }
+
+    it 'populates specified fields only' do
+      pending 'https://jira.mongodb.org/browse/MONGOID-4704'
+
+      expect(school.district).to eq('foo')
+      # has a default value specified in the model
+      expect do
+        school.team
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(student.attributes.keys).to eq(['_id', 'name'])
+    end
+
+    # Delete this test when https://jira.mongodb.org/browse/MONGOID-4704 is
+    # implemented and above test is unpended
+    it 'fetches all fields' do
+      expect(school.district).to eq('foo')
+      expect(school.team).to eq('Bulldogs')
+    end
+  end
+end

data/spec/mongoid/association/referenced/belongs_to_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 require_relative './has_one_models'
 

data/spec/mongoid/association/referenced/has_and_belongs_to_many/binding_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasAndBelongsToMany::Binding do

data/spec/mongoid/association/referenced/has_and_belongs_to_many/buildable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasAndBelongsToMany::Buildable do

data/spec/mongoid/association/referenced/has_and_belongs_to_many/eager_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 require_relative '../has_and_belongs_to_many_models'
 
@@ -43,6 +46,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Eager do
     end
 
     context "when including the has_and_belongs_to_many association" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       it "queries twice" do
         expect_query(2) do
@@ -62,6 +68,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Eager do
     end
 
     context "when the association is not polymorphic" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       let(:eager) do
         Person.asc(:_id).includes(:preferences).last
@@ -116,6 +125,10 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Eager do
     end
 
     context "when some related documents no longer exist" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
+
       before do
         # Deleting the first one to meet Builders::Referenced::ManyToMany#query?
         House.collection.find(_id: Person.first.house_ids.first).delete_one
@@ -132,6 +145,9 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Eager do
     end
 
     context "when all the values for the has_and_belongs_to_many association are empty" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       before do
         2.times { |i| HabtmmPerson.create! }

data/spec/mongoid/association/referenced/has_and_belongs_to_many/proxy_persistence_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# encoding: utf-8
 
 require "spec_helper"
 require_relative '../has_and_belongs_to_many_models'
@@ -16,15 +17,15 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       expect(company.e_ids).to eq([456])
     end
 
-    describe 'nullify' do
+    describe '#nullify' do
       before do
         company.employees << repl_employee
         company.save!
         expect(company.employees.length).to eq(2)
-        repl_employee.habtmm_company_ids = [company.id]
+        repl_employee.c_ids = [company.c_id]
         repl_employee.save!
         repl_employee.reload
-        expect(repl_employee.habtmm_company_ids).to eq([company.id])
+        expect(repl_employee.c_ids).to eq([123])
       end
 
       context 'without replacement' do
@@ -33,7 +34,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         it 'disassociates child from parent' do
           company.employees.nullify
           repl_employee.reload
-          expect(repl_employee.habtmm_company_ids).to eq([])
+          expect(repl_employee.c_ids).to eq([])
         end
       end
 
@@ -48,9 +49,29 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         it 'keeps replacement associated with the parent' do
           company.employees.nullify([repl_employee])
           repl_employee.reload
-          expect(repl_employee.habtmm_company_ids).to eq([company.id])
+          expect(repl_employee.c_ids).to eq([123])
         end
       end
     end
   end
+
+  describe '#<<' do
+    let(:dog) { Dog.create! }
+    let(:breed) { Breed.create! }
+
+    it 'adds association on both ends' do
+      dog.breeds << breed
+      expect(breed.dogs).to eq([dog])
+    end
+
+    context 'with primary_key and foreign_key given' do
+      let(:company) { HabtmmCompany.create!(c_id: 123) }
+      let(:employee) { HabtmmEmployee.create!(e_id: 456) }
+
+      it 'adds association on both ends' do
+        company.employees << employee
+        expect(employee.companies).to eq([company])
+      end
+    end
+  end
 end