mongoid 7.0.6 → 7.1.2

data/spec/app/models/video_game.rb

@@ -1 +1,4 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 class VideoGame < Game; end

data/spec/app/models/weapon.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 class Weapon
   include Mongoid::Document
 

data/spec/app/models/wiki_page.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 class WikiPage
   include Mongoid::Document
   include Mongoid::Timestamps

data/spec/app/models/word.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 class Word
   include Mongoid::Document
   field :name, type: String

data/spec/app/models/word_origin.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 class WordOrigin
   include Mongoid::Document
 

data/spec/app/models/writer.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 class Writer
   include Mongoid::Document
   field :speed, type: Integer, default: 0

data/spec/config/mongoid.yml

@@ -39,6 +39,7 @@ test:
     belongs_to_required_by_default: false
     app_name: 'testing'
     background_indexing: false
+    join_contexts: false
 test_with_max_staleness:
   clients:
     default:

data/spec/integration/app_spec.rb

@@ -0,0 +1,192 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require 'spec_helper'
+
+BASE = File.join(File.dirname(__FILE__), '../..')
+TMP_BASE = File.join(BASE, 'tmp')
+
+describe 'Mongoid application tests' do
+  before(:all) do
+    unless SpecConfig.instance.app_tests?
+      skip 'Set APP_TESTS=1 in environment to run application tests'
+    end
+
+    require 'fileutils'
+    require 'support/child_process_helper'
+    require 'open-uri'
+
+    FileUtils.mkdir_p(TMP_BASE)
+  end
+
+  context 'demo application - sinatra' do
+    it 'runs' do
+      clone_application(
+        'https://github.com/mongoid/mongoid-demo',
+        subdir: 'sinatra-minimal',
+      ) do
+
+        process = ChildProcess.build(*%w(bundle exec ruby app.rb))
+        process.environment.update(clean_env)
+        process.io.inherit!
+        process.start
+
+        begin
+          # JRuby needs a long timeout
+          wait_for_port(4567, 20)
+          sleep 1
+
+          uri = URI.parse('http://localhost:4567/posts')
+          resp = JSON.parse(uri.open.read)
+        ensure
+          Process.kill('TERM', process.pid)
+          status = process.wait
+        end
+
+        resp.should == []
+
+        status.should == 0
+      end
+    end
+  end
+
+  context 'demo application - rails-api' do
+    ['~> 6.0.0'].each do |rails_version|
+      context "with rails #{rails_version}" do
+        it 'runs' do
+          clone_application(
+            'https://github.com/mongoid/mongoid-demo',
+            subdir: 'rails-api',
+            rails_version: rails_version,
+          ) do
+
+            process = ChildProcess.build(*%w(bundle exec rails s))
+            process.environment.update(clean_env)
+            process.io.inherit!
+            process.start
+
+            begin
+              # JRuby needs a long timeout
+              wait_for_port(3000, 30)
+              sleep 1
+
+              uri = URI.parse('http://localhost:3000/posts')
+              resp = JSON.parse(uri.open.read)
+            ensure
+              Process.kill('TERM', process.pid)
+              status = process.wait
+            end
+
+            resp.should == []
+
+            # 143 = 128 + 15
+            [0, 15, 143].should include(status)
+          end
+        end
+      end
+    end
+  end
+
+  context 'new application - rails' do
+    ['~> 5.1.0', '~> 5.2.0', '~> 6.0.0'].each do |rails_version|
+      context "with rails #{rails_version}" do
+        it 'creates' do
+          ChildProcessHelper.check_call(%w(gem uni rails -a))
+          ChildProcessHelper.check_call(%w(gem install rails --no-document -v) + [rails_version])
+
+          Dir.chdir(TMP_BASE) do
+            FileUtils.rm_rf('mongoid-test')
+            ChildProcessHelper.check_call(%w(rails new mongoid-test --skip-spring), env: clean_env)
+
+            Dir.chdir('mongoid-test') do
+              adjust_app_gemfile
+              ChildProcessHelper.check_call(%w(bundle install), env: clean_env)
+
+              ChildProcessHelper.check_call(%w(rails g model post), env: clean_env)
+              ChildProcessHelper.check_call(%w(rails g model comment post:belongs_to), env: clean_env)
+
+              # https://jira.mongodb.org/browse/MONGOID-4885
+              comment_text = File.read('app/models/comment.rb')
+              comment_text.should =~ /belongs_to :post/
+              comment_text.should_not =~ /embedded_in :post/
+            end
+          end
+        end
+      end
+    end
+  end
+
+  def clone_application(repo_url, subdir: nil, rails_version: nil)
+    Dir.chdir(TMP_BASE) do
+      FileUtils.rm_rf(File.basename(repo_url))
+      ChildProcessHelper.check_call(%w(git clone) + [repo_url])
+      Dir.chdir(File.join(*[File.basename(repo_url), subdir].compact)) do
+        adjust_app_gemfile(rails_version: rails_version)
+        ChildProcessHelper.check_call(%w(bundle install), env: clean_env)
+        puts `git diff`
+
+        config = {'development' => {'clients' => {'default' => {'uri' => SpecConfig.instance.uri_str}}}}
+        File.open('config/mongoid.yml', 'w') do |f|
+          f << YAML.dump(config)
+        end
+
+        yield
+      end
+    end
+  end
+
+  def adjust_app_gemfile(rails_version: nil)
+    lock_lines = IO.readlines('Gemfile.lock')
+    # Get rid of the bundled with line so that whatever bundler is installed
+    # on the system is usable with the application.
+    if i = lock_lines.index("BUNDLED WITH\n")
+      lock_lines.slice!(i, 2)
+      File.open('Gemfile.lock', 'w') do |f|
+        f << lock_lines.join
+      end
+    end
+
+    gemfile_lines = IO.readlines('Gemfile')
+    gemfile_lines.delete_if do |line|
+      line =~ /mongoid/
+    end
+    gemfile_lines << "gem 'mongoid', path: '#{File.expand_path(BASE)}'\n"
+    if rails_version
+      gemfile_lines.delete_if do |line|
+        line =~ /rails/
+      end
+      gemfile_lines << "gem 'rails', '#{rails_version}'\n"
+    end
+    File.open('Gemfile', 'w') do |f|
+      f << gemfile_lines.join
+    end
+  end
+
+  def remove_spring
+    # Spring produces this error in Evergreen:
+    # /data/mci/280eb2ecf4fd69208e2106cd3af526f1/src/rubies/ruby-2.7.0/lib/ruby/gems/2.7.0/gems/spring-2.1.0/lib/spring/client/run.rb:26:
+    # in `initialize': too long unix socket path (126bytes given but 108bytes max) (ArgumentError)
+    # Is it trying to create unix sockets in current directory?
+    # https://stackoverflow.com/questions/30302021/rails-runner-without-spring
+    ChildProcessHelper.check_call(%w(bin/spring binstub --remove --all), env: clean_env)
+  end
+
+  def clean_env
+    @clean_env ||= Hash[ENV.keys.grep(/BUNDLE|RUBYOPT/).map { |k| [k, nil ] }]
+  end
+
+  def wait_for_port(port, timeout)
+    deadline = Time.now + timeout
+    loop do
+      begin
+        Socket.tcp('localhost', port, nil, nil, connect_timeout: 0.5) do |socket|
+          return
+        end
+      rescue IOError, SystemCallError
+        if Time.now > deadline
+          raise
+        end
+      end
+    end
+  end
+end

data/spec/integration/associations/belongs_to_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 require_relative '../../mongoid/association/referenced/has_one_models'
 

data/spec/integration/associations/embedded_spec.rb

@@ -0,0 +1,175 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require 'spec_helper'
+require_relative '../../mongoid/association/embedded/embeds_many_models'
+require_relative '../../mongoid/association/embedded/embeds_one_models'
+
+describe 'embedded associations' do
+  context 'without default order' do
+    let(:congress) do
+      EmmCongress.create!
+    end
+
+    let(:legislator) do
+      EmmLegislator.create!(congress: congress, a: 1)
+    end
+
+    shared_examples_for 'an embedded association' do
+      it 'adds child documents to parent association object' do
+        legislator
+        congress.legislators._target.should == [legislator]
+      end
+
+      it 'adds child documents to parent association object criteria' do
+        legislator
+        congress.legislators.criteria.documents.should == [legislator]
+      end
+
+      it 'populates documents on parent association object' do
+        congress.legislators.documents.should == [legislator]
+      end
+
+      it 'returns created child when referencing embedded association' do
+        congress.legislators.should == [legislator]
+      end
+
+      it 'returns created child when referencing Criteria created from embedded association' do
+        congress.legislators.all.should be_a(Mongoid::Criteria)
+        congress.legislators.all.to_a.should == [legislator]
+      end
+    end
+
+    context 'when association was not previously referenced' do
+      before do
+        legislator
+      end
+
+      it_behaves_like 'an embedded association'
+    end
+
+    context 'when association was previously referenced' do
+      before do
+        # This query must be before the product is created
+        congress.legislators.where(a: 1).first
+
+        legislator
+      end
+
+      it_behaves_like 'an embedded association'
+    end
+  end
+
+  context 'with default order' do
+    let(:manufactory) do
+      EmmManufactory.create!
+    end
+
+    let(:product) do
+      EmmProduct.create!(manufactory: manufactory, name: 'Car')
+    end
+
+    shared_examples_for 'adds child documents to parent association' do
+      it 'adds child documents to parent association' do
+        manufactory.products._target.should == [product]
+      end
+    end
+
+    shared_examples_for 'an embedded association' do
+      it 'adds child documents to parent association object' do
+        product
+        manufactory.products._target.should == [product]
+      end
+
+      it 'adds child documents to parent association object criteria' do
+        product
+        manufactory.products.criteria.documents.should == [product]
+      end
+
+      it 'populates documents on parent association object' do
+        manufactory.products.documents.should == [product]
+      end
+
+      it 'returns created child when referencing embedded association' do
+        manufactory.products.should == [product]
+      end
+
+      it 'returns created child when referencing Criteria created from embedded association' do
+        manufactory.products.all.should be_a(Mongoid::Criteria)
+        manufactory.products.all.to_a.should == [product]
+      end
+    end
+
+    context 'when association is not loaded' do
+      before do
+        product
+      end
+
+      it_behaves_like 'an embedded association'
+    end
+
+    context 'when association is loaded' do
+      before do
+        # This query must be before the product is created
+        manufactory.products.where(name: "Car").first
+
+        product
+      end
+
+      it_behaves_like 'an embedded association'
+    end
+  end
+
+  describe 'parent association' do
+    let(:parent) do
+      parent_cls.new
+    end
+
+    context 'embeds_one' do
+
+      shared_examples 'is set' do
+        it 'is set' do
+          parent.child = child_cls.new
+          parent.child.parent.should == parent
+        end
+      end
+
+      context 'class_name set without leading ::' do
+        let(:parent_cls) { EomParent }
+        let(:child_cls) { EomChild }
+
+        it_behaves_like 'is set'
+      end
+
+      context 'class_name set with leading ::' do
+        let(:parent_cls) { EomCcParent }
+        let(:child_cls) { EomCcChild }
+
+        it_behaves_like 'is set'
+      end
+    end
+
+    context 'embeds_many' do
+
+      let(:child) { parent.legislators.new }
+
+      shared_examples 'is set' do
+        it 'is set' do
+          child.congress.should == parent
+        end
+      end
+
+      context 'class_name set without leading ::' do
+        let(:parent_cls) { EmmCongress }
+
+        it_behaves_like 'is set'
+      end
+
+      context 'class_name set with leading ::' do
+        let(:parent_cls) { EmmCcCongress }
+
+        it_behaves_like 'is set'
+      end
+    end
+  end
+end

data/spec/integration/associations/foreign_key_spec.rb

@@ -0,0 +1,99 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require 'spec_helper'
+require_relative './foreign_key_spec_models'
+
+describe 'Association foreign key configuration' do
+  describe 'has_many/belongs_to' do
+    it 'creates child' do
+      company = ForeignKeySpec::Company.create!(c: 'test')
+      email = ForeignKeySpec::Email.create!(company: company)
+      expect(email.c_ref).to eq('test')
+    end
+
+    it 'looks up child' do
+      company = ForeignKeySpec::Company.create!(c: 'test')
+      email = ForeignKeySpec::Email.create!(company: company)
+
+      company = ForeignKeySpec::Company.find(company.id)
+      expect(company.emails.first.id).to eq(email.id)
+    end
+
+    it 'looks up parent' do
+      company = ForeignKeySpec::Company.create!(c: 'test')
+      email = ForeignKeySpec::Email.create!(company: company)
+
+      email = ForeignKeySpec::Email.find(email.id)
+      expect(email.company.id).to eq(company.id)
+    end
+
+    context 'with default scope' do
+      context 'using default scope' do
+        it 'looks up child' do
+          company = ForeignKeySpec::ScopedCompany.create!(c: 'test')
+          on_email = ForeignKeySpec::ScopedEmail.create!(company: company, s: 'on')
+          off_email = ForeignKeySpec::ScopedEmail.create!(company: company, s: 'off')
+
+          company = ForeignKeySpec::ScopedCompany.find(company.id)
+          expect(company.emails.length).to eq(1)
+          expect(company.emails.first.id).to eq(on_email.id)
+        end
+      end
+
+      context 'unscoped' do
+        it 'looks up child' do
+          company = ForeignKeySpec::ScopedCompany.create!(c: 'test')
+          on_email = ForeignKeySpec::ScopedEmail.create!(company: company, s: 'on')
+          off_email = ForeignKeySpec::ScopedEmail.create!(company: company, s: 'off')
+
+          company = ForeignKeySpec::ScopedCompany.find(company.id)
+          expect(company.emails.unscoped.length).to eq(2)
+          expect(company.emails.unscoped.map(&:id).sort).to eq([on_email.id, off_email.id].sort)
+        end
+      end
+    end
+  end
+
+  describe 'has_one/belongs_to' do
+    it 'creates child' do
+      company = ForeignKeySpec::Company.create!(c: 'test')
+      founder = ForeignKeySpec::Founder.create!(company: company)
+      expect(founder.c_ref).to eq('test')
+    end
+
+    it 'looks up child' do
+      company = ForeignKeySpec::Company.create!(c: 'test')
+      founder = ForeignKeySpec::Founder.create!(company: company)
+
+      company = ForeignKeySpec::Company.find(company.id)
+      expect(company.founder.id).to eq(founder.id)
+    end
+
+    it 'looks up parent' do
+      company = ForeignKeySpec::Company.create!(c: 'test')
+      founder = ForeignKeySpec::Founder.create!(company: company)
+
+      email = ForeignKeySpec::Founder.find(founder.id)
+      expect(founder.company.id).to eq(company.id)
+    end
+  end
+
+  describe 'has_and_belongs_to_many' do
+    it 'persists association on the other side' do
+      animal = ForeignKeySpec::Animal.create!(a: 'bear')
+      zoo = ForeignKeySpec::Zoo.create!(z: 'bz')
+      animal.zoos << zoo
+      animal.save!
+
+      # This write should not be necessary, but without it the test fails.
+      # https://jira.mongodb.org/browse/MONGOID-4648
+      zoo.animals << animal
+      zoo.save!
+
+      expect(zoo.animals).to eq([animal])
+      zoo = ForeignKeySpec::Zoo.find(zoo.id)
+      expect(zoo.animals).to eq([animal])
+    end
+  end
+end