mongoid 7.0.2 → 8.1.1

data/spec/mongoid/association/referenced/has_one/proxy_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasOne::Proxy do
@@ -85,7 +87,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -131,7 +133,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
             it "detaches the previous relation" do
               expect {
                 game.reload
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Game with id\(s\)/)
             end
           end
         end
@@ -140,7 +142,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when relation have a different primary_key" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:cat) do
@@ -213,7 +215,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:bar) do
-          Bar.create
+          Bar.create!
         end
 
         let(:rating) do
@@ -248,7 +250,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing persisted (dependent: :destroy) relation" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:game) do
@@ -321,7 +323,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing unpersisted (dependent: :destroy) relation" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:game) do
@@ -394,7 +396,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing persisted (dependent: :nullify) relation" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:cat) do
@@ -467,7 +469,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing unpersisted (dependent: :nullify) relation" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:cat) do
@@ -540,7 +542,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing relation with a new one" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         context "when dependent is destroy" do
@@ -550,7 +552,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
           end
 
           let!(:new_game) do
-            Game.create(name: "Starcraft 2")
+            Game.create!(name: "Starcraft 2")
           end
 
           before do
@@ -581,7 +583,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
           end
 
           let!(:new_account) do
-            Account.create(name: "checking")
+            Account.create!(name: "checking")
           end
 
           before do
@@ -643,7 +645,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -706,7 +708,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:bar) do
-          Bar.create
+          Bar.create!
         end
 
         let(:rating) do
@@ -757,7 +759,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when using object ids" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -784,7 +786,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when providing no attributes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -807,7 +809,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when providing nil attributes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -833,7 +835,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when using object ids" do
 
         let(:bar) do
-          Bar.create
+          Bar.create!
         end
 
         let(:rating) do
@@ -877,7 +879,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when the relation is not polymorphic" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:game) do
@@ -904,7 +906,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when providing no attributes" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:game) do
@@ -927,7 +929,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when providing nil attributes" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:game) do
@@ -950,7 +952,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when the relation is polymorphic" do
 
       let(:bar) do
-        Bar.create
+        Bar.create!
       end
 
       let(:rating) do
@@ -985,7 +987,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
   describe "#nullify" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:game) do
@@ -1059,15 +1061,15 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
   context "when reloading the relation" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:game_one) do
-      Game.create(name: "Warcraft 3")
+      Game.create!(name: "Warcraft 3")
     end
 
     let!(:game_two) do
-      Game.create(name: "Starcraft 2")
+      Game.create!(name: "Starcraft 2")
     end
 
     before do
@@ -1119,11 +1121,11 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when autobuild is true for child" do
 
       let(:explosion) do
-        Explosion.create
+        Explosion.create!
       end
 
       let(:bomb) do
-        bomb = Bomb.create
+        bomb = Bomb.create!
         bomb.explosion = explosion
         bomb
       end
@@ -1137,4 +1139,110 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       end
     end
   end
+
+  context "when there is a foreign key in the aliased associations" do
+    it "has the correct aliases" do
+      # Instances of Driver do not respond to vehicle_id.
+      expect(Driver.aliased_associations.key?("vehicle_id")).to be false
+      expect(Vehicle.aliased_associations.key?("driver_id")).to be false
+      expect(Vehicle.aliased_fields["driver"]).to eq("driver_id")
+    end
+  end
+
+  context "when the document is not persisted and the association is invalid" do
+
+    before do
+      class HomParent
+        include Mongoid::Document
+        has_one :child, class_name: "HomChild"
+        field :name
+        validates :name, presence: true
+      end
+
+      class HomChild; include Mongoid::Document; end
+
+      belongs_to
+      child.parent = parent
+      child.save
+    end
+
+    after do
+      Object.send(:remove_const, :HomParent)
+      Object.send(:remove_const, :HomChild)
+    end
+
+    let(:belongs_to) do
+      HomChild.belongs_to :parent, autosave: true, validate: false, optional: optional
+    end
+
+    let(:child) { HomChild.new }
+    let(:parent) { HomParent.new }
+
+
+    context "when belongs_to_required_by_default is true" do
+      config_override :belongs_to_required_by_default, true
+
+      context "when optional is true" do
+        let(:optional) { true }
+
+        it "persists the child with the parent_id" do
+          expect(HomChild.first.parent_id).to eq(parent._id)
+          expect(HomParent.count).to eq(0)
+        end
+      end
+
+      context "when optional is false" do
+        let(:optional) { false }
+
+        it "doesn't persist the parent or the child" do
+          expect(HomChild.count).to eq(0)
+          expect(HomParent.count).to eq(0)
+        end
+      end
+
+      context "when optional is not set" do
+        let(:belongs_to) do
+          HomChild.belongs_to :parent, autosave: true, validate: false
+        end
+
+        it "doesn't persist the parent or the child" do
+          expect(HomChild.count).to eq(0)
+          expect(HomParent.count).to eq(0)
+        end
+      end
+    end
+
+    context "when belongs_to_required_by_default is false" do
+      config_override :belongs_to_required_by_default, false
+
+      context "when optional is true" do
+        let(:optional) { true }
+
+        it "persists the child with the parent_id" do
+          expect(HomChild.first.parent_id).to eq(parent._id)
+          expect(HomParent.count).to eq(0)
+        end
+      end
+
+      context "when optional is false" do
+        let(:optional) { false }
+
+        it "doesn't persist the parent or the child" do
+          expect(HomChild.count).to eq(0)
+          expect(HomParent.count).to eq(0)
+        end
+      end
+
+      context "when optional is not set" do
+        let(:belongs_to) do
+          HomChild.belongs_to :parent, autosave: true, validate: false
+        end
+
+        it "persists the child with the parent_id" do
+          expect(HomChild.first.parent_id).to eq(parent._id)
+          expect(HomParent.count).to eq(0)
+        end
+      end
+    end
+  end
 end

data/spec/mongoid/association/referenced/has_one_models.rb

@@ -0,0 +1,113 @@
+# frozen_string_literal: true
+
+class HomCollege
+  include Mongoid::Document
+
+  has_one :accreditation, class_name: 'HomAccreditation'
+
+  # The address is added with different dependency mechanisms in tests:
+  #has_one :address, class_name: 'HomAddress', dependent: :destroy
+
+  field :state, type: String
+end
+
+class HomAccreditation
+  include Mongoid::Document
+
+  belongs_to :college, class_name: 'HomCollege'
+
+  field :degree, type: String
+  field :year, type: Integer, default: 2012
+
+  def format
+    'fmt'
+  end
+
+  def price
+    42
+  end
+end
+
+class HomAccreditation::Child
+  include Mongoid::Document
+
+  belongs_to :hom_college
+end
+
+class HomAddress
+  include Mongoid::Document
+
+  belongs_to :college, class_name: 'HomCollege'
+end
+
+module HomNs
+  class PrefixedParent
+    include Mongoid::Document
+
+    has_one :child, class_name: 'PrefixedChild'
+  end
+
+  class PrefixedChild
+    include Mongoid::Document
+
+    belongs_to :parent, class_name: 'PrefixedParent'
+  end
+end
+
+class HomPolymorphicParent
+  include Mongoid::Document
+
+  has_one :p_child, as: :parent
+end
+
+class HomPolymorphicChild
+  include Mongoid::Document
+
+  belongs_to :p_parent, polymorphic: true
+end
+
+class HomBus
+  include Mongoid::Document
+
+  has_one :driver, class_name: 'HomBusDriver'
+end
+
+class HomBusDriver
+  include Mongoid::Document
+
+  # No belongs_to :bus
+end
+
+class HomTrainer
+  include Mongoid::Document
+
+  field :name, type: String
+
+  has_one :animal, class_name: 'HomAnimal', scope: :reptile
+end
+
+class HomAnimal
+  include Mongoid::Document
+
+  field :taxonomy, type: String
+
+  scope :reptile, -> { where(taxonomy: 'reptile') }
+
+  belongs_to :trainer, class_name: 'HomTrainer', scope: -> { where(name: 'Dave') }
+end
+
+class HomPost
+  include Mongoid::Document
+
+  field :title, type: String
+
+  has_one :comment, inverse_of: :post, class_name: 'HomComment'
+end
+
+class HomComment
+  include Mongoid::Document
+
+  field :content, type: String
+
+  belongs_to :post, inverse_of: :comment, optional: true, class_name: 'HomPost'
+end

data/spec/mongoid/association/referenced/has_one_query_spec.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative './has_one_models'
+
+describe Mongoid::Association::Referenced::HasOne do
+  context 'when projecting with #only' do
+    before do
+      college = HomCollege.create!(state: 'ny')
+      HomAccreditation.create!(college: college, degree: 'cs', year: 2017)
+    end
+
+    let(:college) do
+      HomCollege.where(state: 'ny').only('accreditation._id', 'accreditation.degree').first
+    end
+
+    let(:accreditation) { college.accreditation }
+
+    it 'populates specified fields only' do
+      pending 'https://jira.mongodb.org/browse/MONGOID-4704'
+
+      expect(accreditation.degree).to eq('cs')
+      # has a default value specified in the model
+      expect do
+        accreditation.year
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(legislator.attributes.keys).to eq(['_id', 'degree'])
+    end
+
+    # Delete this test when https://jira.mongodb.org/browse/MONGOID-4704 is
+    # implemented and above test is unpended
+    it 'fetches all fields' do
+      expect(accreditation.degree).to eq('cs')
+      expect(accreditation.year).to eq(2017)
+    end
+  end
+end

data/spec/mongoid/association/referenced/has_one_spec.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 require "spec_helper"
+require_relative './has_one_models'
 
 describe Mongoid::Association::Referenced::HasOne do
 
@@ -483,6 +486,27 @@ describe Mongoid::Association::Referenced::HasOne do
     end
   end
 
+  describe '#scope' do
+
+    context 'when scope is specified in the options' do
+
+      let(:options) do
+        { scope: -> { unscoped.where(foo: :bar) } }
+      end
+
+      it 'returns a Criteria Queryable Key' do
+        expect(association.scope).to be_a(Proc)
+      end
+    end
+
+    context 'when scope is not specified in the options' do
+
+      it 'returns nil' do
+        expect(association.scope).to be_nil
+      end
+    end
+  end
+
   describe '#as' do
 
     context 'when :as is specified in the options' do
@@ -744,7 +768,7 @@ describe Mongoid::Association::Referenced::HasOne do
     end
   end
 
-  describe '##inverse' do
+  describe '#inverse' do
 
     context 'when polymorphic' do
 
@@ -908,12 +932,12 @@ describe Mongoid::Association::Referenced::HasOne do
         end
       end
 
-      it 'returns the proper namespaced class name' do
+      it 'returns the inferred unqualified class name' do
         define_classes
 
         expect(
             HasOneAssociationClassName::OwnedClass.relations['owner_class'].relation_class_name
-        ).to eq('HasOneAssociationClassName::OwnerClass')
+        ).to eq('OwnerClass')
       end
     end
 
@@ -926,6 +950,16 @@ describe Mongoid::Association::Referenced::HasOne do
       it 'returns the class name option' do
         expect(association.relation_class_name).to eq('OtherBelongingObject')
       end
+
+      context 'when the class is namespaced' do
+        let(:association) do
+          HomNs::PrefixedParent.relations['child']
+        end
+
+        it 'returns unqualified class name as given in the :class_name option' do
+          expect(association.relation_class_name).to eq('PrefixedChild')
+        end
+      end
     end
 
     context 'when the class_name option is not specified' do
@@ -934,9 +968,19 @@ describe Mongoid::Association::Referenced::HasOne do
         expect(association.relation_class_name).to eq('BelongingObject')
       end
     end
+
+    context "when the class is not defined" do
+      let(:name) do
+        :undefined_class
+      end
+
+      it 'does not trigger autoloading' do
+        expect(association.relation_class_name).to eq('UndefinedClass')
+      end
+    end
   end
 
-  describe '#klass' do
+  describe '#relation_class' do
 
     context 'when the :class_name option is specified' do
 
@@ -950,22 +994,48 @@ describe Mongoid::Association::Referenced::HasOne do
       end
 
       it 'returns the class name option' do
-        expect(association.klass).to eq(_class)
+        expect(association.relation_class).to eq(_class)
+      end
+
+      context 'when the class is namespaced' do
+        let(:association) do
+          HomNs::PrefixedParent.relations['child']
+        end
+
+        it 'returns resolved class instance' do
+          expect(association.relation_class).to eq(HomNs::PrefixedChild)
+        end
       end
     end
 
     context 'when the class_name option is not specified' do
 
       it 'uses the name of the relation to deduce the class name' do
-        expect(association.klass).to eq(BelongingObject)
+        expect(association.relation_class).to eq(BelongingObject)
       end
     end
   end
 
+  describe '#klass' do
+    it 'is the target class' do
+      expect(association.klass).to eq(BelongingObject)
+    end
+  end
+
   describe '#inverse_class_name' do
 
     it 'returns the name of the owner class' do
-      expect(association.inverse_class_name).to eq(OwnerObject.name)
+      expect(association.inverse_class_name).to eq('OwnerObject')
+    end
+
+    context 'polymorphic association' do
+      let(:association) do
+        has_one_class.has_one :belonging_object, as: :bar
+      end
+
+      it 'returns the name of the owner class' do
+        expect(association.inverse_class_name).to eq(OwnerObject.name)
+      end
     end
   end
 
@@ -974,6 +1044,16 @@ describe Mongoid::Association::Referenced::HasOne do
     it 'returns the owner class' do
       expect(association.inverse_class).to be(OwnerObject)
     end
+
+    context 'polymorphic association' do
+      let(:association) do
+        has_one_class.has_one :belonging_object, as: :bar
+      end
+
+      it 'returns the owner class' do
+        expect(association.inverse_class).to be(OwnerObject)
+      end
+    end
   end
 
   describe '#inverse_of' do

data/spec/mongoid/association/reflections_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Reflections do