mongoid 7.0.2 → 8.1.1

data/spec/mongoid/criteria/findable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Criteria::Findable do
@@ -7,11 +9,11 @@ describe Mongoid::Criteria::Findable do
     context "when finding by a document" do
 
       let(:band) do
-        Band.create(name: "Tool")
+        Band.create!(name: "Tool")
       end
 
       let!(:record) do
-        band.records.create(name: "Undertow")
+        band.records.create!(name: "Undertow")
       end
 
       context "when the document is the root" do
@@ -35,12 +37,48 @@ describe Mongoid::Criteria::Findable do
           expect(found).to eq(band)
         end
       end
+
+      context 'when criteria has additional conditions' do
+        let(:band) do
+          Band.create!(name: "Tool")
+        end
+
+        let(:found) do
+          Band.where(name: 'Blah').find(band.id)
+        end
+
+        it 'respects conditions' do
+          expect do
+            found
+          end.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
+        end
+      end
+
+      context 'when criteria has additional conditions on id' do
+        let(:band) do
+          Band.create!(name: "Tool")
+        end
+
+        let(:other) do
+          Band.create!(name: "Other")
+        end
+
+        let(:found) do
+          Band.where(id: other.id).find(band.id)
+        end
+
+        it 'respects both conditions' do
+          expect do
+            found
+          end.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
+        end
+      end
     end
 
     context "when using object ids" do
 
       let!(:band) do
-        Band.create
+        Band.create!
       end
 
       context "when providing a single id" do
@@ -70,10 +108,7 @@ describe Mongoid::Criteria::Findable do
         context "when the id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find(BSON::ObjectId.new)
@@ -82,19 +117,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find(BSON::ObjectId.new)
@@ -110,7 +138,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing a splat of ids" do
 
         let!(:band_two) do
-          Band.create(name: "Tool")
+          Band.create!(name: "Tool")
         end
 
         context "when all ids match" do
@@ -142,10 +170,7 @@ describe Mongoid::Criteria::Findable do
         context "when any id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find(band.id, BSON::ObjectId.new)
@@ -154,19 +179,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find(band.id, BSON::ObjectId.new)
@@ -182,7 +200,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing an array of ids" do
 
         let!(:band_two) do
-          Band.create(name: "Tool")
+          Band.create!(name: "Tool")
         end
 
         context "when all ids match" do
@@ -214,10 +232,7 @@ describe Mongoid::Criteria::Findable do
         context "when any id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find([ band.id, BSON::ObjectId.new ])
@@ -226,19 +241,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find([ band.id, BSON::ObjectId.new ])
@@ -267,10 +275,7 @@ describe Mongoid::Criteria::Findable do
         context "when the id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find(BSON::ObjectId.new.as_json)
@@ -279,19 +284,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find(BSON::ObjectId.new.as_json)
@@ -307,7 +305,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing a splat of extended json ids" do
 
         let!(:band_two) do
-          Band.create(name: "Tool")
+          Band.create!(name: "Tool")
         end
 
         context "when all ids match" do
@@ -339,10 +337,7 @@ describe Mongoid::Criteria::Findable do
         context "when any id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find(band.id.as_json, BSON::ObjectId.new.as_json)
@@ -351,19 +346,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find(band.id.as_json, BSON::ObjectId.new.as_json)
@@ -379,7 +367,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing an array of extended json ids" do
 
         let!(:band_two) do
-          Band.create(name: "Tool")
+          Band.create!(name: "Tool")
         end
 
         context "when all ids match" do
@@ -411,10 +399,7 @@ describe Mongoid::Criteria::Findable do
         context "when any id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find([ band.id.as_json, BSON::ObjectId.new.as_json ])
@@ -423,19 +408,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find([ band.id.as_json, BSON::ObjectId.new.as_json ])
@@ -460,7 +438,7 @@ describe Mongoid::Criteria::Findable do
       end
 
       let!(:band) do
-        Band.create do |band|
+        Band.create! do |band|
           band.id = "tool"
         end
       end
@@ -481,10 +459,7 @@ describe Mongoid::Criteria::Findable do
         context "when the id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find("depeche-mode")
@@ -493,19 +468,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find("depeche-mode")
@@ -521,7 +489,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing a splat of ids" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = "depeche-mode"
           end
         end
@@ -544,10 +512,7 @@ describe Mongoid::Criteria::Findable do
         context "when any id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find(band.id, "new-order")
@@ -556,19 +521,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find(band.id, "new-order")
@@ -584,7 +542,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing an array of ids" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = "depeche-mode"
           end
         end
@@ -607,10 +565,7 @@ describe Mongoid::Criteria::Findable do
         context "when any id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find([ band.id, "new-order" ])
@@ -619,19 +574,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find([ band.id, "new-order" ])
@@ -656,7 +604,7 @@ describe Mongoid::Criteria::Findable do
       end
 
       let!(:band) do
-        Band.create do |band|
+        Band.create! do |band|
           band.id = {"new-order" => true, "Depeche Mode" => false}
         end
       end
@@ -677,10 +625,7 @@ describe Mongoid::Criteria::Findable do
         context "when the id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find({"new-order" => false, "Faith no More" => true})
@@ -689,19 +634,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find({"new-order" => false, "Faith no More" => true})
@@ -717,7 +655,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing a splat of ids" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = {"Radiohead" => false, "Nirvana"=> true}
           end
         end
@@ -740,10 +678,7 @@ describe Mongoid::Criteria::Findable do
         context "when any id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find(band.id, {"Radiohead" => true, "Nirvana"=> false})
@@ -752,19 +687,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find(band.id, {"Radiohead" => true, "Nirvana"=> false})
@@ -780,7 +708,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing an array of ids" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = {"Radiohead" => false, "Nirvana"=> true}
           end
         end
@@ -803,10 +731,7 @@ describe Mongoid::Criteria::Findable do
         context "when any id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find([ band.id, {"Radiohead" => true, "Nirvana"=> false} ])
@@ -815,19 +740,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find([ band.id, {"Radiohead" => true, "Nirvana"=> false} ])
@@ -852,7 +770,7 @@ describe Mongoid::Criteria::Findable do
       end
 
       let!(:band) do
-        Band.create do |band|
+        Band.create! do |band|
           band.id = 1
         end
       end
@@ -873,10 +791,7 @@ describe Mongoid::Criteria::Findable do
         context "when the id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find(3)
@@ -885,19 +800,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find(3)
@@ -913,7 +821,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing a splat of ids" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = 2
           end
         end
@@ -936,10 +844,7 @@ describe Mongoid::Criteria::Findable do
         context "when any id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find(band.id, 3)
@@ -948,19 +853,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find(band.id, 3)
@@ -976,7 +874,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing an array of ids" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = 2
           end
         end
@@ -999,10 +897,7 @@ describe Mongoid::Criteria::Findable do
         context "when any id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find([ band.id, 3 ])
@@ -1011,19 +906,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find([ band.id, 3 ])
@@ -1039,7 +927,7 @@ describe Mongoid::Criteria::Findable do
       context "when providing a range" do
 
         let!(:band_two) do
-          Band.create do |band|
+          Band.create! do |band|
             band.id = 2
           end
         end
@@ -1062,10 +950,7 @@ describe Mongoid::Criteria::Findable do
         context "when any id does not match" do
 
           context "when raising a not found error" do
-
-            before do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, true
 
             let(:found) do
               Band.find(1..3)
@@ -1074,19 +959,12 @@ describe Mongoid::Criteria::Findable do
             it "raises an error" do
               expect {
                 found
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Band with id\(s\)/)
             end
           end
 
           context "when raising no error" do
-
-            before do
-              Mongoid.raise_not_found_error = false
-            end
-
-            after do
-              Mongoid.raise_not_found_error = true
-            end
+            config_override :raise_not_found_error, false
 
             let(:found) do
               Band.find(1..3)
@@ -1111,7 +989,7 @@ describe Mongoid::Criteria::Findable do
     context "when using string and object ids" do
 
       let!(:band) do
-        Band.create
+        Band.create!
       end
 
       context "when providing multiple ids" do
@@ -1128,6 +1006,42 @@ describe Mongoid::Criteria::Findable do
         end
       end
     end
+
+    context "when passing in a block" do
+
+      let!(:band1) { Band.create!(name: '1') }
+      let!(:band2) { Band.create!(name: '2') }
+      let!(:band3) { Band.create!(name: '2') }
+
+      it "yields the documents to the block" do
+        doc = Band.find { |b| b.name == '2' }
+        expect(doc).to eq(band2)
+      end
+    end
+
+    context "when passing in ids and a block" do
+
+      let!(:band1) { Band.create!(name: '1') }
+      let!(:band2) { Band.create!(name: '2') }
+      let!(:band3) { Band.create!(name: '2') }
+
+      it "acts like findable find" do
+        docs = Band.find(band1.id, band2.id) { |b| b.name == '2' }
+        expect(docs).to eq([ band1, band2 ])
+      end
+    end
+
+    context "when passing in a Proc and a block" do
+
+      let!(:band1) { Band.create!(name: '1') }
+      let!(:band2) { Band.create!(name: '2') }
+      let!(:band3) { Band.create!(name: '2') }
+
+      it "acts like findable find" do
+        docs = Band.find(-> { 'default' }) { |b| b.name == '3' }
+        expect(docs).to eq('default')
+      end
+    end
   end
 
   describe "#for_ids" do
@@ -1151,11 +1065,11 @@ describe Mongoid::Criteria::Findable do
   describe "#multiple_from__db" do
 
     let!(:band) do
-      Band.create(name: "Depeche Mode")
+      Band.create!(name: "Depeche Mode")
     end
 
     let!(:band_two) do
-      Band.create(name: "Tool")
+      Band.create!(name: "Tool")
     end
 
     context "when providing a single id" do
@@ -1196,4 +1110,23 @@ describe Mongoid::Criteria::Findable do
       end
     end
   end
+
+  describe '#from_database_selector' do
+    let(:criteria) { Mongoid::Criteria.new(Band) }
+    let(:result) { criteria.send(:from_database_selector, [1]) }
+
+    context 'when criteria is empty' do
+      it 'adds id' do
+        expect(result.selector).to eq('_id' => 1)
+      end
+    end
+
+    context 'when criteria is restricted by id' do
+      let(:criteria) { Mongoid::Criteria.new(Band).where(id: 2) }
+
+      it 'adds id' do
+        expect(result.selector).to eq('_id' => 2, '$and' => [{'_id' => 1}])
+      end
+    end
+  end
 end