mongoid 7.0.13 → 8.0.8

data/spec/mongoid/contextual/atomic_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Contextual::Atomic do
@@ -5,15 +7,15 @@ describe Mongoid::Contextual::Atomic do
   describe "#add_to_set" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave" ])
+      Band.create!(members: [ "Dave" ])
     end
 
     let!(:new_order) do
-      Band.create(members: [ "Peter" ])
+      Band.create!(members: [ "Peter" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     context "when the criteria has no sorting" do
@@ -99,10 +101,107 @@ describe Mongoid::Contextual::Atomic do
     end
   end
 
+  describe "#add_each_to_set" do
+
+    let!(:depeche_mode) do
+      Band.create!(members: [ "Dave" ])
+    end
+
+    let!(:new_order) do
+      Band.create!(members: [ "Peter" ])
+    end
+
+    let!(:smiths) do
+      Band.create!
+    end
+
+    context "when the criteria has no sorting" do
+
+      let(:criteria) do
+        Band.all
+      end
+
+      let(:context) do
+        Mongoid::Contextual::Mongo.new(criteria)
+      end
+
+      before do
+        context.add_each_to_set(members: [ "Dave", "Joe" ])
+      end
+
+      it "does not add duplicates" do
+        expect(depeche_mode.reload.members).to eq([ "Dave", "Joe" ])
+      end
+
+      it "adds unique values" do
+        expect(new_order.reload.members).to eq([ "Peter", "Dave", "Joe" ])
+      end
+
+      it "adds to non initialized fields" do
+        expect(smiths.reload.members).to eq([ "Dave", "Joe" ])
+      end
+    end
+
+    context "when the criteria has sorting" do
+
+      let(:criteria) do
+        Band.asc(:name)
+      end
+
+      let(:context) do
+        Mongoid::Contextual::Mongo.new(criteria)
+      end
+
+      before do
+        context.add_each_to_set(members: [ "Dave", "Joe" ], genres: "Electro")
+      end
+
+      it "does not add duplicates" do
+        expect(depeche_mode.reload.members).to eq([ "Dave", "Joe" ])
+      end
+
+      it "adds multiple operations" do
+        expect(depeche_mode.reload.genres).to eq([ "Electro" ])
+      end
+
+      it "adds unique values" do
+        expect(new_order.reload.members).to eq([ "Peter", "Dave", "Joe" ])
+      end
+
+      it "adds to non initialized fields" do
+        expect(smiths.reload.members).to eq([ "Dave", "Joe" ])
+      end
+    end
+
+    context 'when the criteria has a collation' do
+      min_server_version '3.4'
+
+      let(:criteria) do
+        Band.where(members: [ "DAVE" ]).collation(locale: 'en_US', strength: 2)
+      end
+
+      let(:context) do
+        Mongoid::Contextual::Mongo.new(criteria)
+      end
+
+      before do
+        context.add_each_to_set(members: [ "Dave", "Joe" ], genres: "Electro")
+      end
+
+      it "does not add duplicates" do
+        expect(depeche_mode.reload.members).to eq([ "Dave", "Joe" ])
+      end
+
+      it "adds multiple operations" do
+        expect(depeche_mode.reload.genres).to eq([ "Electro" ])
+      end
+    end
+  end
+
   describe "#bit" do
 
     let!(:depeche_mode) do
-      Band.create(likes: 60)
+      Band.create!(likes: 60)
     end
 
     let(:criteria) do
@@ -150,7 +249,7 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ], likes: 60)
+        Band.create!(members: [ "Dave" ], likes: 60)
       end
 
       let(:criteria) do
@@ -174,15 +273,15 @@ describe Mongoid::Contextual::Atomic do
   describe "#inc" do
 
     let!(:depeche_mode) do
-      Band.create(likes: 60)
+      Band.create!(likes: 60)
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let!(:beatles) do
-      Band.create(years: 2)
+      Band.create!(years: 2)
     end
 
     let(:criteria) do
@@ -230,7 +329,7 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let(:criteria) do
@@ -254,11 +353,11 @@ describe Mongoid::Contextual::Atomic do
   describe "#pop" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave", "Martin" ])
+      Band.create!(members: [ "Dave", "Martin" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let(:criteria) do
@@ -303,7 +402,7 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let(:criteria) do
@@ -327,11 +426,11 @@ describe Mongoid::Contextual::Atomic do
   describe "#pull" do
 
     let!(:depeche_mode) do
-      Band.create(members: [ "Dave", "Alan" ])
+      Band.create!(members: [ "Dave", "Alan" ])
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let(:criteria) do
@@ -358,7 +457,7 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let(:criteria) do
@@ -384,11 +483,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave", "Alan", "Fletch" ])
+        Band.create!(members: [ "Dave", "Alan", "Fletch" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -416,7 +515,7 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave", "Alan", "Fletch" ])
+        Band.create!(members: [ "Dave", "Alan", "Fletch" ])
       end
 
       let(:criteria) do
@@ -442,11 +541,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -474,11 +573,11 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -508,11 +607,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -540,11 +639,11 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -570,11 +669,11 @@ describe Mongoid::Contextual::Atomic do
     context 'when the criteria does not have a collation' do
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -586,15 +685,15 @@ describe Mongoid::Contextual::Atomic do
       end
 
       before do
-        context.rename(members: :artists)
+        context.rename(members: :musicians)
       end
 
       it "renames existing fields" do
-        expect(depeche_mode.reload.artists).to eq([ "Dave" ])
+        expect(depeche_mode.reload.musicians).to eq([ "Dave" ])
       end
 
       it "does not rename non existent fields" do
-        expect(smiths.reload).to_not respond_to(:artists)
+        expect(smiths.reload).to_not respond_to(:musicians)
       end
     end
 
@@ -602,11 +701,11 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(members: [ "Dave" ])
+        Band.create!(members: [ "Dave" ])
       end
 
       let!(:smiths) do
-        Band.create
+        Band.create!
       end
 
       let(:criteria) do
@@ -618,15 +717,15 @@ describe Mongoid::Contextual::Atomic do
       end
 
       before do
-        context.rename(members: :artists)
+        context.rename(members: :musicians)
       end
 
       it "renames existing fields" do
-        expect(depeche_mode.reload.artists).to eq([ "Dave" ])
+        expect(depeche_mode.reload.musicians).to eq([ "Dave" ])
       end
 
       it "does not rename non existent fields" do
-        expect(smiths.reload).to_not respond_to(:artists)
+        expect(smiths.reload).to_not respond_to(:musicians)
       end
     end
   end
@@ -634,11 +733,11 @@ describe Mongoid::Contextual::Atomic do
   describe "#set" do
 
     let!(:depeche_mode) do
-      Band.create(name: "Depeche Mode")
+      Band.create!(name: "Depeche Mode")
     end
 
     let!(:smiths) do
-      Band.create
+      Band.create!
     end
 
     let(:criteria) do
@@ -680,11 +779,11 @@ describe Mongoid::Contextual::Atomic do
     context "when unsetting a single field" do
 
       let!(:depeche_mode) do
-        Band.create(name: "Depeche Mode", years: 10)
+        Band.create!(name: "Depeche Mode", years: 10)
       end
 
       let!(:new_order) do
-        Band.create(name: "New Order", years: 10)
+        Band.create!(name: "New Order", years: 10)
       end
 
       let(:criteria) do
@@ -701,27 +800,28 @@ describe Mongoid::Contextual::Atomic do
           context.unset(:name)
         end
 
-        it "unsets the first existing field" do
-          expect(depeche_mode.reload.name).to be_nil
-        end
-
-        it "unsets the last existing field" do
-          expect(new_order.reload.name).to be_nil
+        it "unsets the fields from all documents" do
+          depeche_mode.reload
+          new_order.reload
+          expect(depeche_mode.name).to be_nil
+          expect(depeche_mode.years).to_not be_nil
+          expect(new_order.name).to be_nil
+          expect(new_order.years).to_not be_nil
         end
       end
 
       context "when the field is aliased" do
-
         before do
           context.unset(:years)
         end
 
-        it "unsets the first existing field" do
-          expect(depeche_mode.reload.years).to be_nil
-        end
-
-        it "unsets the last existing field" do
-          expect(new_order.reload.years).to be_nil
+        it "unsets the fields from all documents" do
+          depeche_mode.reload
+          new_order.reload
+          expect(depeche_mode.name).to_not be_nil
+          expect(depeche_mode.years).to be_nil
+          expect(new_order.name).to_not be_nil
+          expect(new_order.years).to be_nil
         end
       end
     end
@@ -729,7 +829,8 @@ describe Mongoid::Contextual::Atomic do
     context "when unsetting multiple fields" do
 
       let!(:new_order) do
-        Band.create(name: "New Order", genres: [ "electro", "dub" ], years: 10)
+        Band.create!(name: "New Order", genres: %w[electro dub], years: 10,
+          likes: 200, rating: 4.3, origin: 'Space')
       end
 
       let(:criteria) do
@@ -746,12 +847,13 @@ describe Mongoid::Contextual::Atomic do
           context.unset(:name, :genres)
         end
 
-        it "unsets name field" do
-          expect(new_order.reload.name).to be_nil
-        end
-
-        it "unsets genres field" do
-          expect(new_order.reload.genres).to be_nil
+        it "unsets the specified fields" do
+          new_order.reload
+          expect(new_order.name).to be_nil
+          expect(new_order.genres).to be_nil
+          expect(new_order.years).to_not be_nil
+          expect(new_order.likes).to_not be_nil
+          expect(new_order.rating).to_not be_nil
         end
       end
 
@@ -761,12 +863,46 @@ describe Mongoid::Contextual::Atomic do
           context.unset(:name, :years)
         end
 
-        it "unsets the unaliased field" do
-          expect(new_order.reload.name).to be_nil
+        it "unsets the specified fields" do
+          new_order.reload
+          expect(new_order.name).to be_nil
+          expect(new_order.genres).to_not be_nil
+          expect(new_order.years).to be_nil
+          expect(new_order.likes).to_not be_nil
+          expect(new_order.rating).to_not be_nil
+        end
+      end
+
+      context "when using Hash arguments" do
+
+        before do
+          context.unset({ years: true, likes: "" }, { rating: false, origin: nil })
+        end
+
+        it "unsets the specified fields" do
+          new_order.reload
+          expect(new_order.name).to_not be_nil
+          expect(new_order.genres).to_not be_nil
+          expect(new_order.years).to be_nil
+          expect(new_order.likes).to be_nil
+          expect(new_order.rating).to be_nil
+          expect(new_order.origin).to be_nil
+        end
+      end
+
+      context "when mixing argument types" do
+
+        before do
+          context.unset(:name, [:years], { likes: "" }, { rating: false })
         end
 
-        it "unsets the aliased field" do
-          expect(new_order.reload.years).to be_nil
+        it "unsets the specified fields" do
+          new_order.reload
+          expect(new_order.name).to be_nil
+          expect(new_order.genres).to_not be_nil
+          expect(new_order.years).to be_nil
+          expect(new_order.likes).to be_nil
+          expect(new_order.rating).to be_nil
         end
       end
     end
@@ -775,11 +911,11 @@ describe Mongoid::Contextual::Atomic do
       min_server_version '3.4'
 
       let!(:depeche_mode) do
-        Band.create(name: "Depeche Mode", years: 10)
+        Band.create!(name: "Depeche Mode", years: 10)
       end
 
       let!(:new_order) do
-        Band.create(name: "New Order", years: 10)
+        Band.create!(name: "New Order", years: 10)
       end
 
       let(:criteria) do
@@ -795,7 +931,9 @@ describe Mongoid::Contextual::Atomic do
       end
 
       it "unsets the unaliased field" do
-        expect(depeche_mode.reload.name).to be_nil
+        depeche_mode.reload
+        expect(depeche_mode.name).to be_nil
+        expect(depeche_mode.years).to_not be_nil
       end
     end
   end

data/spec/mongoid/contextual/geo_near_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Contextual::GeoNear do
@@ -14,11 +16,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     context "when results are returned" do
@@ -56,7 +58,7 @@ describe Mongoid::Contextual::GeoNear do
       end
 
       it "is nil except for 4.0 sharded when it is 0" do
-        expect(geo_near.average_distance).to be expected_value
+        expect(geo_near.average_distance).to eq expected_value
       end
     end
   end
@@ -72,11 +74,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     context "when no options are provided" do
@@ -136,7 +138,7 @@ describe Mongoid::Contextual::GeoNear do
       end
     end
 
-    context "when spcifying spherical" do
+    context "when specifying spherical" do
 
       let(:criteria) do
         Bar.all
@@ -209,11 +211,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     let(:geo_near) do
@@ -254,11 +256,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     let(:criteria) do
@@ -289,11 +291,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     context "when results are returned" do
@@ -338,11 +340,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Pub.create(location: [ 52.30, 13.25 ])
+      Pub.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Pub.create(location: [ 52.30, 13.35 ])
+      Pub.create!(location: [ 52.30, 13.35 ])
     end
 
     context "when results are returned" do
@@ -373,11 +375,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     let(:criteria) do
@@ -428,11 +430,11 @@ describe Mongoid::Contextual::GeoNear do
     end
 
     let!(:bar_one) do
-      Bar.create(location: [ 52.30, 13.25 ])
+      Bar.create!(location: [ 52.30, 13.25 ])
     end
 
     let!(:bar_two) do
-      Bar.create(location: [ 52.30, 13.35 ])
+      Bar.create!(location: [ 52.30, 13.35 ])
     end
 
     let(:criteria) do

data/spec/mongoid/contextual/map_reduce_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Contextual::MapReduce do
@@ -21,11 +23,11 @@ describe Mongoid::Contextual::MapReduce do
   end
 
   let!(:depeche_mode) do
-    Band.create(name: "Depeche Mode", likes: 200)
+    Band.create!(name: "Depeche Mode", likes: 200)
   end
 
   let!(:tool) do
-    Band.create(name: "Tool", likes: 100)
+    Band.create!(name: "Tool", likes: 100)
   end
 
   let!(:collection) do
@@ -192,22 +194,8 @@ describe Mongoid::Contextual::MapReduce do
         Band.where(name: 'DEPECHE MODE').collation(locale: 'en_US', strength: 2)
       end
 
-      context 'when the server supports collations' do
-        min_server_version '3.4'
-
-        it 'applies the collation' do
-          expect(map_reduce.out(inline: 1).count).to eq(1)
-        end
-      end
-
-      context 'when the server does not support collations' do
-        max_server_version '3.2'
-
-        it 'raises an exception' do
-          expect {
-            map_reduce.out(inline: 1).to_a
-          }.to raise_exception(Mongo::Error::UnsupportedCollation)
-        end
+      it 'applies the collation' do
+        expect(map_reduce.out(inline: 1).count).to eq(1)
       end
     end
   end