mongoid 7.0.13 → 8.0.8

data/spec/mongoid/association/embedded/embeds_many/proxy_spec.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 require "spec_helper"
+require_relative '../embeds_many_models.rb'
 
 describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
@@ -112,7 +115,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:address) do
@@ -131,7 +134,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       context "when appending more than one document at once" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:address_one) do
@@ -207,7 +210,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
         context "when the parent is not a new record" do
 
           let(:parent_role) do
-            Role.create(name: "CEO")
+            Role.create!(name: "CEO")
           end
 
           let(:child_role) do
@@ -226,7 +229,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
       context "when the child has one sided many to many relation" do
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:message) do
@@ -309,7 +312,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when the parent is not a new record" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
@@ -330,11 +333,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       context "when setting via an overridden method from the parent" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:address) do
-          person.addresses.create(street: "Alt Treptow")
+          person.addresses.create!(street: "Alt Treptow")
         end
 
         let!(:new_address) do
@@ -342,7 +345,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
         end
 
         before do
-          person.update_attributes(set_addresses: [ new_address ])
+          person.update_attributes!(set_addresses: [ new_address ])
         end
 
         it "overwrites the existing addresses" do
@@ -372,7 +375,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
           before do
             person.addresses = [ address_two ]
-            person.save
+            person.save!
           end
 
           it "sets the new documents" do
@@ -406,7 +409,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
           before do
             doctor.addresses = [ address_one ]
-            doctor.save
+            doctor.save!
           end
 
           it "sets the documents" do
@@ -425,7 +428,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
             before do
               doctor.addresses = [ address_two ]
-              doctor.save
+              doctor.save!
             end
 
             it "sets the new documents" do
@@ -443,7 +446,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when replacing an existing relation" do
 
       let(:person) do
-        Person.create(addresses: addresses)
+        Person.create!(addresses: addresses)
       end
 
       let(:addresses) do
@@ -504,7 +507,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       end
 
       let(:tracking_id) do
-        MyCompany::Model::TrackingId.create
+        MyCompany::Model::TrackingId.create!
       end
 
       let(:history) do
@@ -539,7 +542,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
           inflect.singular("address_numbers", "address_number")
         end
         slave.address_numbers << AddressNumber.new(country_code: 1)
-        slave.save
+        slave.save!
       end
 
       it "requires an inflection to determine the class" do
@@ -550,15 +553,15 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when setting the entire tree via a hash" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:address_one) do
-        person.addresses.create(street: "Tauentzienstr")
+        person.addresses.create!(street: "Tauentzienstr")
       end
 
       let!(:address_two) do
-        person.addresses.create(street: "Kudamm")
+        person.addresses.create!(street: "Kudamm")
       end
 
       let(:attributes) do
@@ -569,7 +572,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
         before do
           attributes["addresses"][0]["city"] = "Berlin"
-          person.update_attributes(attributes)
+          person.update_attributes!(attributes)
         end
 
         it "sets the new attributes" do
@@ -585,15 +588,15 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when setting an embedded sub-document tree via a hash" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:address_one) do
-        person.addresses.create(street: "Tauentzienstr")
+        person.addresses.create!(street: "Tauentzienstr")
       end
 
       let!(:location_one) do
-        person.addresses.first.locations.create(name: "Work")
+        person.addresses.first.locations.create!(name: "Work")
       end
 
       let(:attributes) do
@@ -605,7 +608,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
         before do
           attributes["city"] = "Berlin"
           attributes["locations"][0]["name"] = "Home"
-          person.addresses.first.update_attributes(attributes)
+          person.addresses.first.update_attributes!(attributes)
         end
 
         it "sets the new attributes on the address" do
@@ -678,7 +681,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       context "when the parent is not a new record" do
 
         let(:parent_role) do
-          Role.create(name: "CTO")
+          Role.create!(name: "CTO")
         end
 
         let(:child_role) do
@@ -746,7 +749,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       context "when the parent is persisted" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:address) do
@@ -795,7 +798,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
           context "when saving the parent" do
 
             before do
-              person.save
+              person.save!
               person.reload
             end
 
@@ -809,7 +812,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       context "when setting on a reload" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:address) do
@@ -879,7 +882,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       context "when the documents are not new records" do
 
         let(:parent_role) do
-          Role.create
+          Role.create!
         end
 
         let(:child_role) do
@@ -909,13 +912,13 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   describe "#as_document" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     context 'when a string is used to access an attribute' do
 
       let!(:address) do
-        person.addresses.create(street: "one")
+        person.addresses.create!(street: "one")
       end
 
       let(:document) do
@@ -930,7 +933,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context 'when a symbol is used to access an attribute' do
 
       let!(:address) do
-        person.addresses.create(street: "one")
+        person.addresses.create!(street: "one")
       end
 
       let(:document) do
@@ -945,7 +948,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when the relation has no default scope" do
 
       let!(:address) do
-        person.addresses.create(street: "one")
+        person.addresses.create!(street: "one")
       end
 
       let(:document) do
@@ -1102,7 +1105,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       context "when providing nested attributes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:address) do
@@ -1116,7 +1119,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
         context "when followed by a save" do
 
           before do
-            address.save
+            address.save!
           end
 
           let(:location) do
@@ -1136,13 +1139,13 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when the parent has been persisted" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the children are persisted" do
 
         let!(:address) do
-          person.addresses.create(street: "High St")
+          person.addresses.create!(street: "High St")
         end
 
         let!(:relation) do
@@ -1258,7 +1261,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when the parent is not a new record" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address) do
@@ -1277,7 +1280,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when concatenating an empty array" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       before do
@@ -1293,7 +1296,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when appending more than one document at once" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:address_one) do
@@ -1365,7 +1368,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       context "when the parent is not a new record" do
 
         let(:parent_role) do
-          Role.create(name: "CEO")
+          Role.create!(name: "CEO")
         end
 
         let(:child_role) do
@@ -1386,17 +1389,262 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   describe "#count" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     before do
-      person.addresses.create(street: "Upper")
+      person.addresses.create!(street: "Upper")
       person.addresses.build(street: "Bond")
+      person.addresses.build(street: "Lower")
     end
 
     it "returns the number of persisted documents" do
       expect(person.addresses.count).to eq(1)
     end
+
+    context 'block form' do
+      it "iterates across all documents" do
+        expect(person.addresses.count {|a| a.persisted? }).to eq(1)
+        expect(person.addresses.count {|a| !a.persisted? }).to eq(2)
+        expect(person.addresses.count {|a| a.street.include?('on') }).to eq(1)
+        expect(person.addresses.count {|a| a.street.ends_with?('er') }).to eq(2)
+      end
+    end
+
+    context 'argument form' do
+      it "behaves correctly when given a model instance" do
+        expect(person.addresses.count(person.addresses.first)).to eq(1)
+      end
+
+      it "behaves correctly when given a non-model instance" do
+        expect(person.addresses.count(1)).to eq(0)
+      end
+    end
+  end
+
+  describe "#any?" do
+
+    let(:person) do
+      Person.create!
+    end
+
+    context "when documents are persisted" do
+      before do
+        person.addresses.create!(street: "Upper")
+      end
+
+      it "returns true" do
+        expect(person.addresses.any?).to be true
+      end
+
+      it "block form iterates across all documents" do
+        expect(person.addresses.any? {|a| a.street == "Upper" }).to be true
+        expect(person.addresses.any? {|a| a.street == "Bond" }).to be false
+      end
+
+      context 'argument form' do
+        it "behaves correctly when given a model instance" do
+          expect(person.addresses.any?(person.addresses.first)).to be true
+        end
+
+        it "behaves correctly when given a non-model instance" do
+          expect(person.addresses.any?(1)).to be false
+        end
+      end
+    end
+
+    context "when documents are not persisted" do
+      before do
+        person.addresses.build(street: "Bond")
+      end
+
+      it "returns true" do
+        expect(person.addresses.any?).to be true
+      end
+
+      it "block form iterates across all documents" do
+        expect(person.addresses.any? {|a| a.street == "Upper" }).to be false
+        expect(person.addresses.any? {|a| a.street == "Bond" }).to be true
+      end
+
+      context 'argument form' do
+        it "behaves correctly when given a model instance" do
+          expect(person.addresses.any?(person.addresses.first)).to be true
+        end
+
+        it "behaves correctly when given a non-model instance" do
+          expect(person.addresses.any?(1)).to be false
+        end
+      end
+    end
+
+    context "when documents are not present" do
+      it "returns false" do
+        expect(person.addresses.any?).to be false
+      end
+
+      it "block form iterates across all documents" do
+        expect(person.addresses.any?(&:a)).to be false
+      end
+
+      it "argument form is supported" do
+        expect(person.addresses.any?(1)).to be false
+      end
+    end
+  end
+
+  describe "#all?" do
+
+    let(:person) do
+      Person.create!
+    end
+
+    context "when documents are persisted" do
+      before do
+        person.addresses.create!(street: "Upper")
+      end
+
+      it "returns true" do
+        expect(person.addresses.all?).to be true
+      end
+
+      it "block form iterates across all documents" do
+        expect(person.addresses.all? {|a| a.street == "Upper" }).to be true
+        expect(person.addresses.all? {|a| a.street == "Bond" }).to be false
+      end
+
+      context 'argument form' do
+        it "behaves correctly when given a model instance" do
+          expect(person.addresses.all?(person.addresses.first)).to be true
+        end
+
+        it "behaves correctly when given a non-model instance" do
+          expect(person.addresses.all?(1)).to be false
+        end
+      end
+    end
+
+    context "when documents are not persisted" do
+      before do
+        person.addresses.build(street: "Bond")
+      end
+
+      it "returns true" do
+        expect(person.addresses.all?).to be true
+      end
+
+      it "block form iterates across all documents" do
+        expect(person.addresses.all? {|a| a.street == "Upper" }).to be false
+        expect(person.addresses.all? {|a| a.street == "Bond" }).to be true
+      end
+
+      context 'argument form' do
+        it "behaves correctly when given a model instance" do
+          expect(person.addresses.all?(person.addresses.first)).to be true
+        end
+
+        it "behaves correctly when given a non-model instance" do
+          expect(person.addresses.all?(1)).to be false
+        end
+      end
+    end
+
+    context "when documents are not present" do
+      it "returns false" do
+        expect(person.addresses.all?).to be true
+      end
+
+      it "block form iterates across all documents" do
+        expect(person.addresses.all?(&:foo)).to be true
+      end
+
+      context 'argument form' do
+        it "behaves correctly when given nil" do
+          expect(person.addresses.all?(nil)).to be true
+        end
+
+        it "behaves correctly when given a non-model instance" do
+          expect(person.addresses.all?(1)).to be true
+        end
+      end
+    end
+  end
+
+  describe "#none?" do
+
+    let(:person) do
+      Person.create!
+    end
+
+    context "when documents are persisted" do
+      before do
+        person.addresses.create!(street: "Upper")
+      end
+
+      it "returns true" do
+        expect(person.addresses.none?).to be false
+      end
+
+      it "block form iterates across all documents" do
+        expect(person.addresses.none? {|a| a.street == "Upper" }).to be false
+        expect(person.addresses.none? {|a| a.street == "Bond" }).to be true
+      end
+
+      context 'argument form' do
+        it "behaves correctly when given a model instance" do
+          expect(person.addresses.none?(person.addresses.first)).to be false
+        end
+
+        it "behaves correctly when given a non-model instance" do
+          expect(person.addresses.none?(1)).to be true
+        end
+      end
+    end
+
+    context "when documents are not persisted" do
+      before do
+        person.addresses.build(street: "Bond")
+      end
+
+      it "returns true" do
+        expect(person.addresses.none?).to be false
+      end
+
+      it "block form iterates across all documents" do
+        expect(person.addresses.none? {|a| a.street == "Upper" }).to be true
+        expect(person.addresses.none? {|a| a.street == "Bond" }).to be false
+      end
+
+      context 'argument form' do
+        it "behaves correctly when given a model instance" do
+          expect(person.addresses.none?(person.addresses.first)).to be false
+        end
+
+        it "behaves correctly when given a non-model instance" do
+          expect(person.addresses.none?(1)).to be true
+        end
+      end
+    end
+
+    context "when documents are not present" do
+      it "returns false" do
+        expect(person.addresses.none?).to be true
+      end
+
+      it "block form iterates across all documents" do
+        expect(person.addresses.none?(&:a)).to be true
+      end
+
+      context 'argument form' do
+        it "behaves correctly when given nil" do
+          expect(person.addresses.none?(nil)).to be true
+        end
+
+        it "behaves correctly when given a non-model instance" do
+          expect(person.addresses.none?(1)).to be true
+        end
+      end
+    end
   end
 
   describe "#create" do
@@ -1404,11 +1652,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when providing multiple attributes" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:addresses) do
-        person.addresses.create([{ street: "Bond" }, { street: "Upper" }])
+        person.addresses.create!([{ street: "Bond" }, { street: "Upper" }])
       end
 
       it "creates multiple documents" do
@@ -1431,11 +1679,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when the relation is not cyclic" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:address) do
-        person.addresses.create(street: "Bond") do |address|
+        person.addresses.create!(street: "Bond") do |address|
           address.state = "CA"
         end
       end
@@ -1479,7 +1727,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       context "when embedding a multi word named document" do
 
         let!(:component) do
-          person.address_components.create(street: "Test")
+          person.address_components.create!(street: "Test")
         end
 
         it "saves the embedded document" do
@@ -1491,11 +1739,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when the relation is cyclic" do
 
       let!(:entry) do
-        Entry.create(title: "hi")
+        Entry.create!(title: "hi")
       end
 
       let!(:child_entry) do
-        entry.child_entries.create(title: "hello")
+        entry.child_entries.create!(title: "hello")
       end
 
       it "creates a new child" do
@@ -1507,7 +1755,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   describe "#create!" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when providing multiple attributes" do
@@ -1614,51 +1862,56 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     end
   end
 
-  describe "#delete" do
-
-    let(:person) do
-      Person.new
-    end
+  %i[ delete delete_one ].each do |method|
+    describe "\##{method}" do
+      let(:address_one) { Address.new(street: "first") }
+      let(:address_two) { Address.new(street: "second") }
 
-    let(:address_one) do
-      Address.new(street: "first")
-    end
+      before do
+        person.addresses << [ address_one, address_two ]
+      end
 
-    let(:address_two) do
-      Address.new(street: "second")
-    end
+      shared_examples_for 'deleting from the collection' do
+        context 'when the document exists in the relation' do
+          let!(:deleted) do
+            person.addresses.send(method, address_one)
+          end
 
-    before do
-      person.addresses << [ address_one, address_two ]
-    end
+          it 'deletes the document' do
+            expect(person.addresses).to eq([ address_two ])
+            expect(person.reload.addresses).to eq([ address_two ]) if person.persisted?
+          end
 
-    context "when the document exists in the relation" do
+          it 'deletes the document from the unscoped' do
+            expect(person.addresses.send(:_unscoped)).to eq([ address_two ])
+          end
 
-      let!(:deleted) do
-        person.addresses.delete(address_one)
-      end
+          it 'reindexes the relation' do
+            expect(address_two._index).to eq(0)
+          end
 
-      it "deletes the document" do
-        expect(person.addresses).to eq([ address_two ])
-      end
+          it 'returns the document' do
+            expect(deleted).to eq(address_one)
+          end
+        end
 
-      it "deletes the document from the unscoped" do
-        expect(person.addresses.send(:_unscoped)).to eq([ address_two ])
+        context 'when the document does not exist' do
+          it 'returns nil' do
+            expect(person.addresses.send(method, Address.new)).to be_nil
+          end
+        end
       end
 
-      it "reindexes the relation" do
-        expect(address_two._index).to eq(0)
-      end
+      context 'when the root document is unpersisted' do
+        let(:person) { Person.new }
 
-      it "returns the document" do
-        expect(deleted).to eq(address_one)
+        it_behaves_like 'deleting from the collection'
       end
-    end
 
-    context "when the document does not exist" do
+      context 'when the root document is persisted' do
+        let(:person) { Person.create }
 
-      it "returns nil" do
-        expect(person.addresses.delete(Address.new)).to be_nil
+        it_behaves_like 'deleting from the collection'
       end
     end
   end
@@ -1666,7 +1919,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   describe "#delete_if" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when the documents are new" do
@@ -1715,11 +1968,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when the documents persisted" do
 
       let!(:address_one) do
-        person.addresses.create(street: "Bond")
+        person.addresses.create!(street: "Bond")
       end
 
       let!(:address_two) do
-        person.addresses.create(street: "Upper")
+        person.addresses.create!(street: "Upper")
       end
 
       context "when a block is provided" do
@@ -1774,7 +2027,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     describe "##{method}" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the documents are new" do
@@ -1828,11 +2081,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       context "when the documents persisted" do
 
         let!(:address_one) do
-          person.addresses.create(street: "Bond")
+          person.addresses.create!(street: "Bond")
         end
 
         let!(:address_two) do
-          person.addresses.create(street: "Upper")
+          person.addresses.create!(street: "Upper")
         end
 
         context "when conditions are provided" do
@@ -1879,7 +2132,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
         context "when removing and resaving" do
 
           let(:owner) do
-            PetOwner.create(title: "AKC")
+            PetOwner.create!(title: "AKC")
           end
 
           before do
@@ -1962,6 +2215,79 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
           end
         end
       end
+
+      context "when modifying the document beforehand" do
+        let(:parent) { EmmParent.new }
+
+        before do
+
+          parent.blocks << EmmBlock.new(name: 'test', children: [size: 1, order: 1])
+          parent.save!
+
+          parent.blocks[0].children[0].assign_attributes(size: 2)
+
+          parent.blocks.destroy_all(:name => 'test')
+        end
+
+        it "deletes the correct document in the database" do
+          expect(parent.reload.blocks.length).to eq(0)
+        end
+      end
+
+      context "when nil _id" do
+        let(:parent) { EmmParent.new }
+
+        before do
+          parent.blocks << EmmBlock.new(_id: nil, name: 'test', children: [size: 1, order: 1])
+          parent.blocks << EmmBlock.new(_id: nil, name: 'test2', children: [size: 1, order: 1])
+          parent.save!
+
+          parent.blocks.destroy_all(:name => 'test')
+        end
+
+        it "deletes only the matching documents in the database" do
+          expect(parent.reload.blocks.length).to eq(1)
+        end
+      end
+
+      # Since without an _id field we must us a $pullAll with the attributes of
+      # the embedded document, if you modify it beforehand, the query will not
+      # be able to find the correct document to pull.
+      context "when modifying the document with nil _id" do
+        let(:parent) { EmmParent.new }
+
+        before do
+          parent.blocks << EmmBlock.new(_id: nil, name: 'test', children: [size: 1, order: 1])
+          parent.blocks << EmmBlock.new(_id: nil, name: 'test2', children: [size: 1, order: 1])
+          parent.save!
+
+          parent.blocks[0].children[0].assign_attributes(size: 2)
+
+          parent.blocks.destroy_all(:name => 'test')
+        end
+
+        it "does not delete the correct documents" do
+          expect(parent.reload.blocks.length).to eq(2)
+        end
+      end
+
+      context "when documents with and without _id" do
+        let(:parent) { EmmParent.new }
+
+        before do
+          parent.blocks << EmmBlock.new(_id: nil, name: 'test', children: [size: 1, order: 1])
+          parent.blocks << EmmBlock.new(name: 'test', children: [size: 1, order: 1])
+          parent.save!
+
+          parent.blocks[1].children[0].assign_attributes(size: 2)
+
+          parent.blocks.destroy_all(:name => 'test')
+        end
+
+        it "does not delete the correct documents" do
+          expect(parent.reload.blocks.length).to eq(0)
+        end
+      end
     end
   end
 
@@ -1975,13 +2301,13 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   describe "#exists?" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when documents exist in the database" do
 
       before do
-        person.addresses.create(street: "Bond St")
+        person.addresses.create!(street: "Bond St")
       end
 
       it "returns true" do
@@ -2039,7 +2365,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
           it "raises an error" do
             expect {
               person.addresses.find(BSON::ObjectId.new)
-            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+            }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Address with id\(s\)/)
           end
         end
 
@@ -2088,7 +2414,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
           it "raises an error" do
             expect {
               person.addresses.find([ BSON::ObjectId.new ])
-            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+            }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Address with id\(s\)/)
           end
         end
 
@@ -2112,12 +2438,50 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
         end
       end
     end
+
+    context "with block" do
+      let!(:author) do
+        Person.create!(title: 'Person')
+      end
+
+      let!(:video_one) do
+        author.videos.create!(title: 'video one')
+      end
+
+      let!(:video_two) do
+        author.videos.create!(title: 'video two')
+      end
+
+      it "finds one" do
+        expect(
+          author.videos.find do |video|
+            video.title == 'video one'
+          end
+        ).to eq(video_one)
+      end
+
+      it "returns first match of multiple" do
+        expect(
+          author.videos.find do |video|
+            ['video one', 'video two'].include?(video.title)
+          end
+        ).to be_a(Video)
+      end
+
+      it "returns nil when not found" do
+        expect(
+          author.videos.find do |video|
+            video.title == 'non exiting one'
+          end
+        ).to be_nil
+      end
+    end
   end
 
   describe "#find_or_create_by" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:address) do
@@ -2160,11 +2524,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     # context "when the child belongs to another document" do
     #
     #   let(:product) do
-    #     Product.create
+    #     Product.create!
     #   end
     #
     #   let(:purchase) do
-    #     Purchase.create
+    #     Purchase.create!
     #   end
     #
     #   let(:line_item) do
@@ -2183,7 +2547,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   describe "#find_or_create_by!" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:address) do
@@ -2235,11 +2599,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     # context "when the child belongs to another document" do
     #
     #   let(:product) do
-    #     Product.create
+    #     Product.create!
     #   end
     #
     #   let(:purchase) do
-    #     Purchase.create
+    #     Purchase.create!
     #   end
     #
     #   let(:line_item) do
@@ -2357,11 +2721,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   describe "#method_missing" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:address_one) do
-      person.addresses.create(
+      person.addresses.create!(
           street: "Market",
           state: "CA",
           services: [ "1", "2" ]
@@ -2369,7 +2733,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     end
 
     let!(:address_two) do
-      person.addresses.create(
+      person.addresses.create!(
           street: "Madison",
           state: "NY",
           services: [ "1", "2" ]
@@ -2413,13 +2777,26 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     end
 
     context "when providing a criteria class method" do
+      context "without keyword arguments" do
 
-      let(:addresses) do
-        person.addresses.california
+        let(:addresses) do
+          person.addresses.california
+        end
+
+        it "applies the criteria to the documents" do
+          expect(addresses).to eq([ address_one ])
+        end
       end
 
-      it "applies the criteria to the documents" do
-        expect(addresses).to eq([ address_one ])
+      context "with keyword arguments" do
+
+        let(:addresses) do
+          person.addresses.city_and_state(city: "Sacramento", state: "CA")
+        end
+
+        it "applies the criteria to the documents" do
+          expect(addresses).to eq([])
+        end
       end
     end
 
@@ -2504,17 +2881,17 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   describe "#pop" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when no argument is provided" do
 
       let!(:address_one) do
-        person.addresses.create(street: "sonnenallee")
+        person.addresses.create!(street: "sonnenallee")
       end
 
       let!(:address_two) do
-        person.addresses.create(street: "hermannstr")
+        person.addresses.create!(street: "hermannstr")
       end
 
       let!(:popped) do
@@ -2537,11 +2914,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when an integer is provided" do
 
       let!(:address_one) do
-        person.addresses.create(street: "sonnenallee")
+        person.addresses.create!(street: "sonnenallee")
       end
 
       let!(:address_two) do
-        person.addresses.create(street: "hermannstr")
+        person.addresses.create!(street: "hermannstr")
       end
 
       context "when the number is zero" do
@@ -2623,17 +3000,17 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   describe "#shift" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when no argument is provided" do
 
       let!(:address_one) do
-        person.addresses.create(street: "sonnenallee")
+        person.addresses.create!(street: "sonnenallee")
       end
 
       let!(:address_two) do
-        person.addresses.create(street: "hermannstr")
+        person.addresses.create!(street: "hermannstr")
       end
 
       let!(:shifted) do
@@ -2656,11 +3033,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when an integer is provided" do
 
       let!(:address_one) do
-        person.addresses.create(street: "sonnenallee")
+        person.addresses.create!(street: "sonnenallee")
       end
 
       let!(:address_two) do
-        person.addresses.create(street: "hermannstr")
+        person.addresses.create!(street: "hermannstr")
       end
 
       context "when the number is zero" do
@@ -2808,11 +3185,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     describe "##{method}" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       before do
-        person.addresses.create(street: "Upper")
+        person.addresses.create!(street: "Upper")
         person.addresses.build(street: "Bond")
       end
 
@@ -2850,7 +3227,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when there are no documents present" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       it "updates nothing" do
@@ -2861,11 +3238,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when documents are present" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:address) do
-        person.addresses.create(street: "Hobrecht", number: 27)
+        person.addresses.create!(street: "Hobrecht", number: 27)
       end
 
       context "when updating with a where clause" do
@@ -2900,16 +3277,16 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when updating the bottom level" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:address) do
-        person.addresses.create(street: "Joachimstr")
+        person.addresses.create!(street: "Joachimstr")
       end
 
       let!(:location) do
-        address.locations.create(name: "vacation", number: 0)
-        address.locations.create(name: "work", number: 3)
+        address.locations.create!(name: "vacation", number: 0)
+        address.locations.create!(name: "work", number: 3)
       end
 
       context "when updating with replacement of embedded array" do
@@ -2917,7 +3294,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
         context "when updating with a hash" do
 
           before do
-            address.update_attributes(locations: [{ name: "home" }])
+            address.update_attributes!(locations: [{ name: "home" }])
           end
 
           it "updates the attributes" do
@@ -2938,7 +3315,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
         before do
           location.number = 7
-          location.save
+          location.save!
         end
 
         let(:updated_location_number) do
@@ -3071,7 +3448,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when creating a persisted tree" do
 
       let(:quiz) do
-        Quiz.create
+        Quiz.create!
       end
 
       let(:page) do
@@ -3136,7 +3513,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       context "when saving the root" do
 
         before do
-          person.save
+          person.save!
         end
 
         it "persists the first level document" do
@@ -3162,7 +3539,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
     describe "replacing the entire embedded list" do
 
-      context "when an embeds many relationship contains a nil as the first item" do
+      context "when an embeds many relationship contains nil as the first item" do
 
         let(:person) do
           Person.create!
@@ -3183,7 +3560,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
         end
       end
 
-      context "when an embeds many relationship contains a nil in the middle of the list" do
+      context "when an embeds many relationship contains nil in the middle of the list" do
 
         let(:person) do
           Person.create!
@@ -3204,7 +3581,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
         end
       end
 
-      context "when an embeds many relationship contains a nil at the end of the list" do
+      context "when an embeds many relationship contains nil at the end of the list" do
 
         let(:person) do
           Person.create!
@@ -3228,7 +3605,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
     describe "appending to the embedded list" do
 
-      context "when appending a nil to the first position in an embedded list" do
+      context "when appending nil to the first position in an embedded list" do
 
         let(:person) do
           Person.create! phone_numbers: []
@@ -3247,7 +3624,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
         end
       end
 
-      context "when appending a nil into the middle of an embedded list" do
+      context "when appending nil into the middle of an embedded list" do
 
         let(:person) do
           Person.create! phone_numbers: []
@@ -3266,7 +3643,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
         end
       end
 
-      context "when appending a nil to the end of an embedded list" do
+      context "when appending nil to the end of an embedded list" do
 
         let(:person) do
           Person.create! phone_numbers: []
@@ -3290,11 +3667,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when accessing the parent in a destroy callback" do
 
     let!(:league) do
-      League.create
+      League.create!
     end
 
     let!(:division) do
-      league.divisions.create
+      league.divisions.create!
     end
 
     before do
@@ -3309,15 +3686,15 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when updating the parent with all attributes" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:address) do
-      person.addresses.create
+      person.addresses.create!
     end
 
     before do
-      person.update_attributes(person.attributes)
+      person.update_attributes!(person.attributes)
     end
 
     it "does not duplicate the embedded documents" do
@@ -3332,13 +3709,13 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when embedding children named versions" do
 
     let(:acolyte) do
-      Acolyte.create(name: "test")
+      Acolyte.create!(name: "test")
     end
 
     context "when creating a child" do
 
       let(:version) do
-        acolyte.versions.create(number: 1)
+        acolyte.versions.create!(number: 1)
       end
 
       it "allows the operation" do
@@ -3363,7 +3740,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     let!(:account) do
       Account.new(name: "Testing").tap do |acct|
         acct.memberships.build
-        acct.save
+        acct.save!
       end
     end
 
@@ -3375,10 +3752,10 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
       before do
         account.name = ""
-        account.save
       end
 
       it "does not lose the parent reference" do
+        expect(account.save).to eq false
         expect(from_db.memberships.first.account).to eq(account)
       end
     end
@@ -3398,15 +3775,15 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when moving an embedded document from one parent to another" do
 
     let!(:person_one) do
-      Person.create
+      Person.create!
     end
 
     let!(:person_two) do
-      Person.create
+      Person.create!
     end
 
     let!(:address) do
-      person_one.addresses.create(street: "Kudamm")
+      person_one.addresses.create!(street: "Kudamm")
     end
 
     before do
@@ -3441,7 +3818,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when the relation has a default scope" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when the default scope is a sort" do
@@ -3511,7 +3888,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when indexing the documents" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when the documents have a limiting default scope" do
@@ -3560,18 +3937,18 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when the embedded document has an array field" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:video) do
-      person.videos.create
+      person.videos.create!
     end
 
     context "when saving the array on a persisted document" do
 
       before do
         video.genres = [ "horror", "scifi" ]
-        video.save
+        video.save!
       end
 
       it "sets the value" do
@@ -3596,7 +3973,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
           before do
             loaded_video.genres = [ "comedy" ]
-            loaded_video.save
+            loaded_video.save!
           end
 
           it "sets the new value" do
@@ -3614,15 +3991,15 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when destroying an embedded document" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:address_one) do
-      person.addresses.create(street: "hobrecht")
+      person.addresses.create!(street: "hobrecht")
     end
 
     let!(:address_two) do
-      person.addresses.create(street: "maybachufer")
+      person.addresses.create!(street: "maybachufer")
     end
 
     before do
@@ -3661,6 +4038,28 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     end
   end
 
+  context "when destroying a document with multiple nil _ids" do
+    let(:congress) { EmmCongress.create! }
+
+    before do
+      congress.legislators << EmmLegislator.new(_id: nil, a: 1)
+      congress.legislators << EmmLegislator.new(_id: nil, a: 2)
+
+      congress.legislators[0].destroy
+    end
+
+    it "deletes the correct document locally" do
+      pending "MONGOID-5394"
+      expect(congress.legislators.length).to eq(1)
+      expect(congress.legislators.first.a).to eq(1)
+    end
+
+    it "only deletes the one document" do
+      pending "MONGOID-5394"
+      expect(congress.reload.legislators.length).to eq(1)
+    end
+  end
+
   context "when adding a document" do
 
     let(:person) do
@@ -3694,7 +4093,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when the association has an order defined" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:message_one) do
@@ -3725,11 +4124,11 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
       before do
         person.aliases = [ { name: "A", priority: 3 }, { name: "B", priority: 4 }]
-        person.save
+        person.save!
       end
 
       let!(:person2) do
-        Person.create( aliases: [ { name: "C", priority: 1 }, { name: "D", priority: 2 }])
+        Person.create!( aliases: [ { name: "C", priority: 1 }, { name: "D", priority: 2 }])
       end
 
       it "allows ordering on a key of an embedded document" do
@@ -3764,7 +4163,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when updating multiple levels in one update" do
 
     let!(:person) do
-      Person.create(
+      Person.create!(
           addresses: [
               { locations: [{ name: "home" }]}
           ]
@@ -3778,7 +4177,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       end
 
       before do
-        from_db.update_attributes(
+        from_db.update_attributes!(
             addresses: [
                 { locations: [{ name: "work" }]}
             ]
@@ -3798,15 +4197,15 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when the embedded relation sorts on a boolean" do
 
     let(:circuit) do
-      Circuit.create
+      Circuit.create!
     end
 
     let!(:bus_one) do
-      circuit.buses.create(saturday: true)
+      circuit.buses.create!(saturday: true)
     end
 
     let!(:bus_two) do
-      circuit.buses.create(saturday: false)
+      circuit.buses.create!(saturday: false)
     end
 
     it "orders properly with the boolean" do
@@ -3817,7 +4216,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when batch replacing multiple relations in a single update" do
 
     let(:document) do
-      Person.create
+      Person.create!
     end
 
     let(:person) do
@@ -3825,23 +4224,23 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     end
 
     let!(:symptom_one) do
-      person.symptoms.create
+      person.symptoms.create!
     end
 
     let!(:symptom_two) do
-      person.symptoms.create
+      person.symptoms.create!
     end
 
     let!(:appointment_one) do
-      person.appointments.create
+      person.appointments.create!
     end
 
     let!(:appointment_two) do
-      person.appointments.create
+      person.appointments.create!
     end
 
     before do
-      person.update_attributes(
+      person.update_attributes!(
           appointments: [ appointment_one.as_document, appointment_two.as_document ],
           symptoms: [ symptom_one.as_document, symptom_two.as_document ]
       )
@@ -4174,7 +4573,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when the parent has an after create callback" do
 
       before do
-        server.save
+        server.save!
       end
 
       it "does not push the embedded documents twice" do
@@ -4186,7 +4585,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
   context "when embedded documents are stored without ids" do
 
     let!(:band) do
-      Band.create(name: "Moderat")
+      Band.create!(name: "Moderat")
     end
 
     before do
@@ -4236,7 +4635,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       company = Company.new
       4.times { |i| company.staffs << Staff.new(age: 50 + i)}
       2.times { |i| company.staffs << Staff.new(age: 40)}
-      company.save
+      company.save!
       company.staffs.delete_if {|x| x.age >= 50}
       expect(company.staffs.count).to eq(2)
     end
@@ -4313,7 +4712,7 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     context "when the parent is persisted" do
 
       let(:zone) do
-        DNS::Zone.create
+        DNS::Zone.create!
       end
 
       let(:soa_1) do
@@ -4351,4 +4750,119 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       end
     end
   end
+
+  context "when trying to persist the empty list" do
+
+    context "in an embeds_many relation" do
+
+      let(:band) { Band.create! }
+
+      before do
+        band.labels = []
+        band.save!
+      end
+
+      let(:reloaded_band) { Band.collection.find(_id: band._id).first }
+
+      it "persists the empty list" do
+        expect(reloaded_band).to have_key(:labels)
+        expect(reloaded_band[:labels]).to eq []
+      end
+    end
+
+    context "in a nested embeds_many relation" do
+
+      let(:survey) { Survey.create!(questions: [Question.new]) }
+
+      before do
+        survey.questions.first.answers = []
+        survey.save!
+      end
+
+      let(:reloaded_survey) { Survey.collection.find(_id: survey._id).first }
+
+      it "persists the empty list" do
+        expect(reloaded_survey).to have_key(:questions)
+        expect(reloaded_survey[:questions][0]).to have_key(:answers)
+        expect(reloaded_survey[:questions][0][:answers]).to eq []
+      end
+    end
+
+    context "when not setting the embeds_many field" do
+
+      let(:band) { Band.create! }
+
+      let(:reloaded_band) { Band.collection.find(_id: band._id).first }
+
+      it "does not persist the empty list" do
+        expect(reloaded_band).to_not have_key(:labels)
+      end
+    end
+  end
+
+  context "when using assign_attributes with an already populated array" do
+    let(:post) { EmmPost.create! }
+
+    before do
+      post.assign_attributes(company_tags: [{id: BSON::ObjectId.new, title: 'a'}],
+        user_tags: [{id: BSON::ObjectId.new, title: 'b'}])
+      post.save!
+      post.reload
+      post.assign_attributes(company_tags: [{id: BSON::ObjectId.new, title: 'c'}],
+        user_tags: [])
+      post.save!
+      post.reload
+    end
+
+    it "has the correct embedded documents" do
+      expect(post.company_tags.length).to eq(1)
+      expect(post.company_tags.first.title).to eq("c")
+    end
+  end
+
+  context "when the parent fails validation" do
+    let(:school) { EmmSchool.new }
+    let(:student) { school.students.new }
+
+    before do
+      student.save
+    end
+
+    it "does not mark the parent as persisted" do
+      expect(school.persisted?).to be false
+    end
+
+    it "does not mark the child as persisted" do
+      expect(student.persisted?).to be false
+    end
+
+    it "does not persist the parent" do
+      expect(School.count).to eq(0)
+    end
+  end
+
+  context "when doing assign_attributes then assignment" do
+
+    let(:post) do
+      EmmPost.create!(
+        company_tags: [ EmmCompanyTag.new(title: "1"), EmmCompanyTag.new(title: "1") ],
+        user_tags: [ EmmUserTag.new(title: "1"), EmmUserTag.new(title: "1") ]
+      )
+    end
+
+    let(:from_db) { EmmPost.find(post.id) }
+
+    before do
+      post.assign_attributes(
+        company_tags: [ EmmCompanyTag.new(title: '3'), EmmCompanyTag.new(title: '4') ]
+      )
+      post.user_tags = [ EmmUserTag.new(title: '3'), EmmUserTag.new(title: '4') ]
+      post.save!
+    end
+
+    it "persists the associations correctly" do
+      expect(from_db.user_tags.size).to eq(2)
+      expect(from_db.company_tags.size).to eq(2)
+    end
+  end
 end