mongoid 7.0.10 → 7.4.0

data/spec/mongoid/association/referenced/has_many_models.rb

@@ -1,8 +1,13 @@
+# frozen_string_literal: true
+
 class HmmCompany
   include Mongoid::Document
 
   field :p, type: Integer
   has_many :emails, primary_key: :p, foreign_key: :f, class_name: 'HmmEmail'
+
+  # The addresses are added with different dependency mechanisms in tests:
+  #has_many :addresses, class_name: 'HmmAddress', dependent: :destroy
 end
 
 class HmmEmail
@@ -12,6 +17,29 @@ class HmmEmail
   belongs_to :company, primary_key: :p, foreign_key: :f, class_name: 'HmmCompany'
 end
 
+class HmmAddress
+  include Mongoid::Document
+
+  belongs_to :company, class_name: 'HmmCompany'
+end
+
+class HmmOwner
+  include Mongoid::Document
+
+  has_many :pets, class_name: 'HmmPet', inverse_of: :current_owner
+
+  field :name, type: String
+end
+
+class HmmPet
+  include Mongoid::Document
+
+  belongs_to :current_owner, class_name: 'HmmOwner', inverse_of: :pets, optional: true
+  belongs_to :previous_owner, class_name: 'HmmOwner', inverse_of: nil, optional: true
+
+  field :name, type: String
+end
+
 class HmmSchool
   include Mongoid::Document
 
@@ -35,3 +63,33 @@ class HmmTicket
 
   belongs_to :person
 end
+
+class HmmBus
+  include Mongoid::Document
+
+  has_many :seats, class_name: 'HmmBusSeat'
+end
+
+class HmmBusSeat
+  include Mongoid::Document
+
+  # No belongs_to :bus
+end
+
+class HmmTrainer
+  include Mongoid::Document
+
+  field :name, type: String
+
+  has_many :animals, class_name: 'HmmAnimal', scope: :reptile
+end
+
+class HmmAnimal
+  include Mongoid::Document
+
+  field :taxonomy, type: String
+
+  scope :reptile, -> { where(taxonomy: 'reptile') }
+
+  belongs_to :trainer, class_name: 'HmmTrainer', scope: -> { where(name: 'Dave') }
+end

data/spec/mongoid/association/referenced/has_many_query_spec.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative './has_many_models'
+
+describe Mongoid::Association::Referenced::HasMany do
+  context 'when projecting with #only' do
+    before do
+      school = HmmSchool.create!(district: 'foo')
+      HmmStudent.create!(school: school, name: 'Dave', grade: 10)
+    end
+
+    let(:school) do
+      HmmSchool.where(district: 'foo').only('students._id', 'students.name').first
+    end
+
+    let(:student) { school.students.first }
+
+    it 'populates specified fields only' do
+      pending 'https://jira.mongodb.org/browse/MONGOID-4704'
+
+      expect(student.name).to eq('Dave')
+      # has a default value specified in the model
+      expect do
+        student.grade
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(student.attributes.keys).to eq(['_id', 'name'])
+    end
+
+    # Delete this test when https://jira.mongodb.org/browse/MONGOID-4704 is
+    # implemented and above test is unpended
+    it 'fetches all fields' do
+      expect(student.name).to eq('Dave')
+      expect(student.grade).to eq(10)
+    end
+  end
+end

data/spec/mongoid/association/referenced/has_many_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasMany do
@@ -492,6 +494,27 @@ describe Mongoid::Association::Referenced::HasMany do
     end
   end
 
+  describe '#scope' do
+
+    context 'when scope is specified in the options' do
+
+      let(:options) do
+        { scope: -> { unscoped.where(foo: :bar) } }
+      end
+
+      it 'returns a Criteria Queryable Key' do
+        expect(association.scope).to be_a(Proc)
+      end
+    end
+
+    context 'when scope is not specified in the options' do
+
+      it 'returns nil' do
+        expect(association.scope).to be_nil
+      end
+    end
+  end
+
   describe '#as' do
 
     context 'when :as is specified in the options' do

data/spec/mongoid/association/referenced/has_one/binding_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasOne::Binding do

data/spec/mongoid/association/referenced/has_one/buildable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasOne::Buildable do
@@ -12,14 +14,18 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
       association.build(base, object)
     end
 
+    let(:options) do
+      {}
+    end
+
     let(:association) do
-      Mongoid::Association::Referenced::HasOne.new(Person, :account)
+      Mongoid::Association::Referenced::HasOne.new(Person, :account, options)
     end
 
     context "when provided an id" do
 
       let!(:account) do
-        Account.create!(person_id: object, name: 'banking')
+        Account.create!(person_id: object, name: 'banking', balance: 200)
       end
 
       let(:object) do
@@ -27,7 +33,7 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
       end
 
       before do
-        expect(Account).to receive(:where).with(association.foreign_key => object).and_call_original
+        expect_any_instance_of(Mongoid::Criteria).to receive(:where).with(association.foreign_key => object).and_call_original
       end
 
       it "sets the document" do
@@ -35,6 +41,46 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
       end
     end
 
+    context "when scope is specified" do
+
+      let!(:account) do
+        Account.create!(person_id: object, name: 'banking', balance: 200)
+      end
+
+      let(:object) do
+        BSON::ObjectId.new
+      end
+
+      let(:options) do
+        {
+            scope: -> { gt(balance: 100) }
+        }
+      end
+
+      before do
+        expect_any_instance_of(Mongoid::Criteria).to receive(:where).with(association.foreign_key => object).and_call_original
+        expect_any_instance_of(Mongoid::Criteria).to receive(:gt).with(balance: 100).and_call_original
+      end
+
+      context "when document satisfies scope" do
+
+        it "sets the document" do
+          expect(document).to eq(account)
+        end
+      end
+
+      context "when document does not satisfy scope" do
+
+        let!(:account) do
+          Account.create!(person_id: object, name: 'banking', balance: 50)
+        end
+
+        it "returns nil" do
+          expect(document).to eq(nil)
+        end
+      end
+    end
+
     context "when provided a object" do
 
       let(:object) do
@@ -83,11 +129,11 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
     context "when the document is persisted" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:game) do
-        Game.create(person: person)
+        Game.create!(person: person)
       end
 
       it "returns the document" do
@@ -98,11 +144,11 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
     context "when the document have a non standard pk" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:cat) do
-        Cat.create(person: person)
+        Cat.create!(person: person)
       end
 
       it "returns the document" do

data/spec/mongoid/association/referenced/has_one/eager_spec.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 require "spec_helper"
+require_relative '../has_one_models'
 
 describe Mongoid::Association::Referenced::HasOne::Eager do
 
@@ -63,9 +66,15 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
       eager.send(:set_on_parent, person.username, :foo)
     end
 
-    it "doesnt call an extra query" do
-      expect_query(0) do
-        eager.send(:set_on_parent, person.username, :foo)
+    context 'when able to make query count assertions' do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
+
+      it "doesnt call an extra query" do
+        expect_query(0) do
+          eager.send(:set_on_parent, person.username, :foo)
+        end
       end
     end
   end
@@ -82,6 +91,9 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
     end
 
     context "when including the has_one relation" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       it "queries twice" do
 
@@ -95,6 +107,9 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
     end
 
     context "when including more than one has_one relation" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       it "queries 3 times" do
 
@@ -138,7 +153,7 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
     context "when the relation is polymorphic" do
 
       let!(:book) do
-        Book.create(name: "Game of Thrones")
+        Book.create!(name: "Game of Thrones")
       end
 
       let!(:rating) do
@@ -159,5 +174,20 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
         end
       end
     end
+
+    context "when the association has scope" do
+      let!(:trainer1) { HomTrainer.create!(name: 'Dave') }
+      let!(:trainer2) { HomTrainer.create!(name: 'Ash') }
+      let!(:animal1) { HomAnimal.create!(taxonomy: 'reptile', trainer: trainer1) }
+      let!(:animal2) { HomAnimal.create!(taxonomy: 'bird', trainer: trainer1) }
+
+      let(:eager) do
+        HomTrainer.includes(:animal).where(_id: trainer1._id).to_a.first
+      end
+
+      it 'eager loads the included docs' do
+        expect(eager.animal).to eq animal1
+      end
+    end
   end
 end

data/spec/mongoid/association/referenced/has_one/proxy_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::HasOne::Proxy do
@@ -85,7 +87,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -140,7 +142,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when relation have a different primary_key" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:cat) do
@@ -213,7 +215,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:bar) do
-          Bar.create
+          Bar.create!
         end
 
         let(:rating) do
@@ -248,7 +250,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing persisted (dependent: :destroy) relation" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:game) do
@@ -321,7 +323,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing unpersisted (dependent: :destroy) relation" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:game) do
@@ -394,7 +396,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing persisted (dependent: :nullify) relation" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:cat) do
@@ -467,7 +469,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing unpersisted (dependent: :nullify) relation" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:cat) do
@@ -540,7 +542,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when replacing an existing relation with a new one" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         context "when dependent is destroy" do
@@ -550,7 +552,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
           end
 
           let!(:new_game) do
-            Game.create(name: "Starcraft 2")
+            Game.create!(name: "Starcraft 2")
           end
 
           before do
@@ -581,7 +583,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
           end
 
           let!(:new_account) do
-            Account.create(name: "checking")
+            Account.create!(name: "checking")
           end
 
           before do
@@ -643,7 +645,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -706,7 +708,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:bar) do
-          Bar.create
+          Bar.create!
         end
 
         let(:rating) do
@@ -757,7 +759,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when using object ids" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -784,7 +786,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when providing no attributes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -807,7 +809,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when providing nil attributes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:game) do
@@ -833,7 +835,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
       context "when using object ids" do
 
         let(:bar) do
-          Bar.create
+          Bar.create!
         end
 
         let(:rating) do
@@ -877,7 +879,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when the relation is not polymorphic" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:game) do
@@ -904,7 +906,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when providing no attributes" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:game) do
@@ -927,7 +929,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when providing nil attributes" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:game) do
@@ -950,7 +952,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when the relation is polymorphic" do
 
       let(:bar) do
-        Bar.create
+        Bar.create!
       end
 
       let(:rating) do
@@ -985,7 +987,7 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
   describe "#nullify" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:game) do
@@ -1059,15 +1061,15 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
   context "when reloading the relation" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:game_one) do
-      Game.create(name: "Warcraft 3")
+      Game.create!(name: "Warcraft 3")
     end
 
     let!(:game_two) do
-      Game.create(name: "Starcraft 2")
+      Game.create!(name: "Starcraft 2")
     end
 
     before do
@@ -1119,11 +1121,11 @@ describe Mongoid::Association::Referenced::HasOne::Proxy do
     context "when autobuild is true for child" do
 
       let(:explosion) do
-        Explosion.create
+        Explosion.create!
       end
 
       let(:bomb) do
-        bomb = Bomb.create
+        bomb = Bomb.create!
         bomb.explosion = explosion
         bomb
       end

data/spec/mongoid/association/referenced/has_one_models.rb

@@ -1,8 +1,13 @@
+# frozen_string_literal: true
+
 class HomCollege
   include Mongoid::Document
 
   has_one :accreditation, class_name: 'HomAccreditation'
 
+  # The address is added with different dependency mechanisms in tests:
+  #has_one :address, class_name: 'HomAddress', dependent: :destroy
+
   field :state, type: String
 end
 
@@ -13,6 +18,14 @@ class HomAccreditation
 
   field :degree, type: String
   field :year, type: Integer, default: 2012
+
+  def format
+    'fmt'
+  end
+
+  def price
+    42
+  end
 end
 
 class HomAccreditation::Child
@@ -21,6 +34,12 @@ class HomAccreditation::Child
   belongs_to :hom_college
 end
 
+class HomAddress
+  include Mongoid::Document
+
+  belongs_to :college, class_name: 'HomCollege'
+end
+
 module HomNs
   class PrefixedParent
     include Mongoid::Document
@@ -46,3 +65,33 @@ class HomPolymorphicChild
 
   belongs_to :p_parent, polymorphic: true
 end
+
+class HomBus
+  include Mongoid::Document
+
+  has_one :driver, class_name: 'HomBusDriver'
+end
+
+class HomBusDriver
+  include Mongoid::Document
+
+  # No belongs_to :bus
+end
+
+class HomTrainer
+  include Mongoid::Document
+
+  field :name, type: String
+
+  has_one :animal, class_name: 'HomAnimal', scope: :reptile
+end
+
+class HomAnimal
+  include Mongoid::Document
+
+  field :taxonomy, type: String
+
+  scope :reptile, -> { where(taxonomy: 'reptile') }
+
+  belongs_to :trainer, class_name: 'HomTrainer', scope: -> { where(name: 'Dave') }
+end

data/spec/mongoid/association/referenced/has_one_query_spec.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative './has_one_models'
+
+describe Mongoid::Association::Referenced::HasOne do
+  context 'when projecting with #only' do
+    before do
+      college = HomCollege.create!(state: 'ny')
+      HomAccreditation.create!(college: college, degree: 'cs', year: 2017)
+    end
+
+    let(:college) do
+      HomCollege.where(state: 'ny').only('accreditation._id', 'accreditation.degree').first
+    end
+
+    let(:accreditation) { college.accreditation }
+
+    it 'populates specified fields only' do
+      pending 'https://jira.mongodb.org/browse/MONGOID-4704'
+
+      expect(accreditation.degree).to eq('cs')
+      # has a default value specified in the model
+      expect do
+        accreditation.year
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(legislator.attributes.keys).to eq(['_id', 'degree'])
+    end
+
+    # Delete this test when https://jira.mongodb.org/browse/MONGOID-4704 is
+    # implemented and above test is unpended
+    it 'fetches all fields' do
+      expect(accreditation.degree).to eq('cs')
+      expect(accreditation.year).to eq(2017)
+    end
+  end
+end