mongoid 7.0.10 → 7.4.0

data/spec/mongoid/persistable/deletable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Persistable::Deletable do
@@ -5,7 +7,7 @@ describe Mongoid::Persistable::Deletable do
   describe "#delete" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when deleting a readonly document" do
@@ -21,6 +23,20 @@ describe Mongoid::Persistable::Deletable do
       end
     end
 
+    context 'when deleting a document that was not saved' do
+      let(:unsaved_person) { Person.new(id: person.id) }
+
+      before do
+        unsaved_person.delete
+      end
+
+      it 'deletes the matching document from the database' do
+        lambda do
+          person.reload
+        end.should raise_error(Mongoid::Errors::DocumentNotFound)
+      end
+    end
+
     context "when removing a root document" do
 
       let!(:deleted) do
@@ -70,7 +86,7 @@ describe Mongoid::Persistable::Deletable do
       context "when the document has been saved" do
 
         before do
-          address.save
+          address.save!
           address.delete
         end
 
@@ -89,11 +105,11 @@ describe Mongoid::Persistable::Deletable do
       context "when the document has been saved" do
 
         let(:address) do
-          person.addresses.create(street: "Bond Street")
+          person.addresses.create!(street: "Bond Street")
         end
 
         let(:location) do
-          address.locations.create(name: "Home")
+          address.locations.create!(name: "Home")
         end
 
         let(:from_db) do
@@ -117,19 +133,19 @@ describe Mongoid::Persistable::Deletable do
     context "when deleting subclasses" do
 
       let!(:firefox) do
-        Firefox.create(name: "firefox")
+        Firefox.create!(name: "firefox")
       end
 
       let!(:firefox2) do
-        Firefox.create(name: "firefox 2")
+        Firefox.create!(name: "firefox 2")
       end
 
       let!(:browser) do
-        Browser.create(name: "browser")
+        Browser.create!(name: "browser")
       end
 
       let!(:canvas) do
-        Canvas.create(name: "canvas")
+        Canvas.create!(name: "canvas")
       end
 
       context "when deleting a single document" do
@@ -170,12 +186,178 @@ describe Mongoid::Persistable::Deletable do
         end
       end
     end
+
+    context "when deleting all documents with a custom discriminator key" do
+      before do
+        Canvas.discriminator_key = "dkey"
+      end
+
+      after do
+        Canvas.discriminator_key = nil
+      end
+
+      let!(:firefox) do
+        Firefox.create!(name: "firefox")
+      end
+
+      let!(:firefox2) do
+        Firefox.create!(name: "firefox 2")
+      end
+
+      let!(:browser) do
+        Browser.create!(name: "browser")
+      end
+
+      let!(:canvas) do
+        Canvas.create!(name: "canvas")
+      end
+
+      before do
+        Firefox.delete_all
+      end
+
+      it "deletes from the parent class collection" do
+        expect(Canvas.count).to eq(2)
+      end
+
+      it "returns correct counts for child classes" do
+        expect(Firefox.count).to eq(0)
+      end
+
+      it "returns correct counts for root subclasses" do
+        expect(Browser.count).to eq(1)
+      end
+    end
+
+    context "when deleting all documents with a custom discriminator value" do
+      before do
+        Canvas.discriminator_key = "dkey"
+        Firefox.discriminator_value = "dvalue"
+      end
+
+      after do
+        Canvas.discriminator_key = nil
+        Firefox.discriminator_value = nil
+      end
+
+      let!(:firefox) do
+        Firefox.create!(name: "firefox")
+      end
+
+      let!(:firefox2) do
+        Firefox.create!(name: "firefox 2")
+      end
+
+      let!(:browser) do
+        Browser.create!(name: "browser")
+      end
+
+      let!(:canvas) do
+        Canvas.create!(name: "canvas")
+      end
+
+      before do
+        Firefox.delete_all
+      end
+
+      it "deletes from the parent class collection" do
+        expect(Canvas.count).to eq(2)
+      end
+
+      it "returns correct counts for child classes" do
+        expect(Firefox.count).to eq(0)
+      end
+
+      it "returns correct counts for root subclasses" do
+        expect(Browser.count).to eq(1)
+      end
+    end
+
+    context 'when there are dependent documents' do
+      context 'has_one' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(bolt: Bolt.create!)
+          end
+
+          it 'does not destroy dependent documents' do
+            Bolt.count.should == 1
+            parent.delete
+            Bolt.count.should == 1
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!(threadlocker: Threadlocker.create!)
+          end
+
+          it 'does not destroy dependent documents' do
+            Threadlocker.count.should == 1
+            parent.delete
+            Threadlocker.count.should == 1
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(sealer: Sealer.create!)
+          end
+
+          it 'does not destroy dependent documents' do
+            Sealer.count.should == 1
+            parent.delete
+            Sealer.count.should == 1
+          end
+        end
+      end
+
+      context 'has_many' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(nuts: [Nut.create!])
+          end
+
+          it 'does not destroy dependent documents' do
+            Nut.count.should == 1
+            parent.delete
+            Nut.count.should == 1
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!(washers: [Washer.create!])
+          end
+
+          it 'does not destroy dependent documents' do
+            Washer.count.should == 1
+            parent.delete
+            Washer.count.should == 1
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(spacers: [Spacer.create!])
+          end
+
+          it 'does not destroy dependent documents' do
+            Spacer.count.should == 1
+            parent.delete
+            Spacer.count.should == 1
+          end
+        end
+      end
+    end
   end
 
   describe "#delete_all" do
 
     let!(:person) do
-      Person.create(title: "sir")
+      Person.create!(title: "sir")
     end
 
     context "when no conditions are provided" do
@@ -196,7 +378,7 @@ describe Mongoid::Persistable::Deletable do
     context "when conditions are provided" do
 
       let!(:person_two) do
-        Person.create
+        Person.create!
       end
 
       context "when no conditions attribute provided" do
@@ -232,7 +414,7 @@ describe Mongoid::Persistable::Deletable do
       context 'when the write concern is unacknowledged' do
 
         before do
-          Person.create(title: 'miss')
+          Person.create!(title: 'miss')
         end
 
         let!(:deleted) do
@@ -248,5 +430,85 @@ describe Mongoid::Persistable::Deletable do
         end
       end
     end
+
+    context 'when there are dependent documents' do
+      context 'has_one' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(bolt: Bolt.create!)
+          end
+
+          it 'does not destroy dependent documents' do
+            Bolt.count.should == 1
+            Hole.delete_all
+            Bolt.count.should == 1
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!(threadlocker: Threadlocker.create!)
+          end
+
+          it 'does not destroy dependent documents' do
+            Threadlocker.count.should == 1
+            Hole.delete_all
+            Threadlocker.count.should == 1
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(sealer: Sealer.create!)
+          end
+
+          it 'does not destroy dependent documents' do
+            Sealer.count.should == 1
+            Hole.delete_all
+            Sealer.count.should == 1
+          end
+        end
+      end
+
+      context 'has_many' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(nuts: [Nut.create!])
+          end
+
+          it 'does not destroy dependent documents' do
+            Nut.count.should == 1
+            Hole.delete_all
+            Nut.count.should == 1
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!(washers: [Washer.create!])
+          end
+
+          it 'does not destroy dependent documents' do
+            Washer.count.should == 1
+            Hole.delete_all
+            Washer.count.should == 1
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(spacers: [Spacer.create!])
+          end
+
+          it 'does not destroy dependent documents' do
+            Spacer.count.should == 1
+            Hole.delete_all
+            Spacer.count.should == 1
+          end
+        end
+      end
+    end
   end
 end

data/spec/mongoid/persistable/destroyable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Persistable::Destroyable do
@@ -5,7 +7,7 @@ describe Mongoid::Persistable::Destroyable do
   describe "#destroy" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when destroying a readonly document" do
@@ -21,9 +23,23 @@ describe Mongoid::Persistable::Destroyable do
       end
     end
 
+    context 'when destroying a document that was not saved' do
+      let(:unsaved_person) { Person.new(id: person.id) }
+
+      before do
+        unsaved_person.destroy
+      end
+
+      it 'deletes the matching document from the database' do
+        lambda do
+          person.reload
+        end.should raise_error(Mongoid::Errors::DocumentNotFound)
+      end
+    end
+
     context "when removing a root document" do
 
-      let!(:destroyd) do
+      let!(:destroyed) do
         person.destroy
       end
 
@@ -34,7 +50,7 @@ describe Mongoid::Persistable::Destroyable do
       end
 
       it "returns true" do
-        expect(destroyd).to be true
+        expect(destroyed).to be true
       end
 
       it "resets the flagged for destroy flag" do
@@ -70,7 +86,7 @@ describe Mongoid::Persistable::Destroyable do
       context "when the document has been saved" do
 
         before do
-          address.save
+          address.save!
           address.destroy
         end
 
@@ -118,11 +134,11 @@ describe Mongoid::Persistable::Destroyable do
       context "when the document has been saved" do
 
         let(:address) do
-          person.addresses.create(street: "Bond Street")
+          person.addresses.create!(street: "Bond Street")
         end
 
         let(:location) do
-          address.locations.create(name: "Home")
+          address.locations.create!(name: "Home")
         end
 
         let(:from_db) do
@@ -142,6 +158,90 @@ describe Mongoid::Persistable::Destroyable do
         end
       end
     end
+
+    context 'when there are dependent documents' do
+      context 'has_one' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(bolt: Bolt.create!)
+          end
+
+          it 'destroys dependent documents' do
+            Bolt.count.should == 1
+            parent.destroy
+            Bolt.count.should == 0
+          end
+        end
+
+        context 'dependent: :destroy_all' do
+          let!(:parent) do
+            Hole.create!(threadlocker: Threadlocker.create!)
+          end
+
+          it 'deletes dependent documents' do
+            Threadlocker.count.should == 1
+            parent.destroy
+            Threadlocker.count.should == 0
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(sealer: Sealer.create!)
+          end
+
+          it 'raises an exception' do
+            Sealer.count.should == 1
+            lambda do
+              parent.destroy
+            end.should raise_error(Mongoid::Errors::DeleteRestriction)
+            Sealer.count.should == 1
+          end
+        end
+      end
+
+      context 'has_many' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(nuts: [Nut.create!])
+          end
+
+          it 'destroys dependent documents' do
+            Nut.count.should == 1
+            parent.destroy
+            Nut.count.should == 0
+          end
+        end
+
+        context 'dependent: :destroy_all' do
+          let!(:parent) do
+            Hole.create!(washers: [Washer.create!])
+          end
+
+          it 'deletes dependent documents' do
+            Washer.count.should == 1
+            parent.destroy
+            Washer.count.should == 0
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(spacers: [Spacer.create!])
+          end
+
+          it 'raises an exception' do
+            Spacer.count.should == 1
+            lambda do
+              parent.destroy
+            end.should raise_error(Mongoid::Errors::DeleteRestriction)
+            Spacer.count.should == 1
+          end
+        end
+      end
+    end
   end
 
   describe "#destroy!" do
@@ -149,7 +249,7 @@ describe Mongoid::Persistable::Destroyable do
     context "when no validation callback returns false" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       it "returns true" do
@@ -160,7 +260,7 @@ describe Mongoid::Persistable::Destroyable do
     context "when a validation callback returns false" do
 
       let(:album) do
-        Album.create
+        Album.create!
       end
 
       before do
@@ -182,7 +282,7 @@ describe Mongoid::Persistable::Destroyable do
   describe "#destroy_all" do
 
     let!(:person) do
-      Person.create(title: "sir")
+      Person.create!(title: "sir")
     end
 
     context "when no conditions are provided" do
@@ -203,7 +303,7 @@ describe Mongoid::Persistable::Destroyable do
     context "when conditions are provided" do
 
       let!(:person_two) do
-        Person.create
+        Person.create!
       end
 
       context "when no conditions attribute provided" do
@@ -225,7 +325,7 @@ describe Mongoid::Persistable::Destroyable do
     context 'when the write concern is unacknowledged' do
 
       before do
-        Person.create(title: 'miss')
+        Person.create!(title: 'miss')
       end
 
       let!(:removed) do
@@ -261,5 +361,95 @@ describe Mongoid::Persistable::Destroyable do
         end
       end
     end
+
+    context 'when there are dependent documents' do
+      context 'has_one' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!.tap do |hole|
+              Bolt.create!(hole: hole)
+            end
+          end
+
+          it 'destroys dependent documents' do
+            Bolt.count.should == 1
+            Hole.destroy_all
+            Bolt.count.should == 0
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!.tap do |hole|
+              Threadlocker.create!(hole: hole)
+            end
+          end
+
+          it 'deletes dependent documents' do
+            Threadlocker.count.should == 1
+            Hole.destroy_all
+            Threadlocker.count.should == 0
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!.tap do |hole|
+              Sealer.create!(hole: hole)
+            end
+          end
+
+          it 'raises an exception' do
+            Sealer.count.should == 1
+            lambda do
+              Hole.destroy_all
+            end.should raise_error(Mongoid::Errors::DeleteRestriction)
+            Sealer.count.should == 1
+          end
+        end
+      end
+
+      context 'has_many' do
+
+        context 'dependent: :destroy' do
+          let!(:parent) do
+            Hole.create!(nuts: [Nut.create!])
+          end
+
+          it 'destroys dependent documents' do
+            Nut.count.should == 1
+            Hole.destroy_all
+            Nut.count.should == 0
+          end
+        end
+
+        context 'dependent: :delete_all' do
+          let!(:parent) do
+            Hole.create!(washers: [Washer.create!])
+          end
+
+          it 'deletes dependent documents' do
+            Washer.count.should == 1
+            Hole.destroy_all
+            Washer.count.should == 0
+          end
+        end
+
+        context 'dependent: :restrict_with_exception' do
+          let!(:parent) do
+            Hole.create!(spacers: [Spacer.create!])
+          end
+
+          it 'raises an exception' do
+            Spacer.count.should == 1
+            lambda do
+              Hole.destroy_all
+            end.should raise_error(Mongoid::Errors::DeleteRestriction)
+            Spacer.count.should == 1
+          end
+        end
+      end
+    end
   end
 end