mongoid 7.0.10 → 7.4.0

data/spec/mongoid/association/embedded/embeds_many_models.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# encoding: utf-8
 
 class EmmCongress
   include Mongoid::Document
+  include Mongoid::Timestamps
 
   embeds_many :legislators, class_name: 'EmmLegislator'
 
@@ -51,3 +51,19 @@ class EmmProduct
 
   field :name, type: String
 end
+
+class EmmInner
+  include Mongoid::Document
+
+  embeds_many :friends, :class_name => self.name, :cyclic => true
+  embedded_in :parent, :class_name => self.name, :cyclic => true
+
+  field :level, :type => Integer
+end
+
+class EmmOuter
+  include Mongoid::Document
+  embeds_many :inners, class_name: 'EmmInner'
+
+  field :level, :type => Integer
+end

data/spec/mongoid/association/embedded/embeds_many_query_spec.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative './embeds_many_models'
+
+describe Mongoid::Association::Embedded::EmbedsMany do
+
+  context 'when projecting with #only' do
+    before do
+      congress = EmmCongress.new(name: 'foo')
+      congress.legislators << EmmLegislator.new(a: 1, b: 2)
+      congress.save!
+    end
+
+    let(:congress) do
+      EmmCongress.where(name: 'foo').only(:name, 'legislators._id', 'legislators.a').first
+    end
+
+    let(:legislator) { congress.legislators.first }
+
+    it 'populates specified fields only' do
+      expect(legislator.a).to eq(1)
+      # has a default value specified in the model
+      expect do
+        legislator.b
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(legislator.attributes.keys).to eq(['_id', 'a'])
+    end
+
+    context 'when using only with $' do
+      before do
+        Patient.destroy_all
+        Patient.create!(
+          title: 'Steve',
+          addresses: [
+            Address.new(number: '123'),
+            Address.new(number: '456'),
+          ],
+        )
+      end
+
+      let(:patient) do
+        Patient.where('addresses.number' => {'$gt' => 100}).only('addresses.$').first
+      end
+
+      it 'loads embedded association' do
+        expect(patient.addresses.first.number).to eq(123)
+      end
+    end
+  end
+end

data/spec/mongoid/association/embedded/embeds_many_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsMany do
@@ -859,4 +861,4 @@ describe Mongoid::Association::Embedded::EmbedsMany do
       expect(association.path(double( :_parent => true))).to be_a(Mongoid::Atomic::Paths::Embedded::Many)
     end
   end
-end
+end

data/spec/mongoid/association/embedded/embeds_one/binding_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsOne::Binding do

data/spec/mongoid/association/embedded/embeds_one/buildable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsOne::Buildable do

data/spec/mongoid/association/embedded/embeds_one/proxy_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
@@ -85,7 +87,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:name) do
@@ -171,7 +173,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
           context "when replacing an existing document" do
 
             let(:pet_owner) do
-              PetOwner.create
+              PetOwner.create!
             end
 
             let(:pet_one) do
@@ -204,7 +206,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
         context 'when the original document does not need to be unset because it will be replaced by the $set' do
 
           let!(:pet_owner) do
-            PetOwner.create(pet: pet_one)
+            PetOwner.create!(pet: pet_one)
           end
 
           let(:pet_one) do
@@ -277,7 +279,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:parent_shelf) do
-          Shelf.create
+          Shelf.create!
         end
 
         let(:child_shelf) do
@@ -309,7 +311,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
     context "when setting a new document multiple times in a row" do
 
       let(:parent) do
-        Parent.create
+        Parent.create!
       end
 
       before do
@@ -370,7 +372,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
       context "when the parent is persisted" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:name) do
@@ -459,7 +461,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
       context "when the documents are not new records" do
 
         let(:parent_shelf) do
-          Shelf.create
+          Shelf.create!
         end
 
         let(:child_shelf) do
@@ -608,7 +610,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:name) do
@@ -653,7 +655,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:parent_shelf) do
-          Shelf.create
+          Shelf.create!
         end
 
         let!(:child_shelf) do
@@ -755,7 +757,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
       context "when the parent is not a new record" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:name) do
@@ -776,7 +778,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
       context "when the embedded document inherits its relationship" do
 
         let(:courier_job) do
-          CourierJob.create
+          CourierJob.create!
         end
 
         let(:old_child) do
@@ -845,7 +847,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
   context "when the embedded document has an array field" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:name) do
@@ -864,7 +866,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
 
       before do
         from_db.aliases = [ "Syd", "Sydney" ]
-        from_db.save
+        from_db.save!
       end
 
       it "sets the values of the array" do
@@ -880,7 +882,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
   context "when embedding a many under a one" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     before do
@@ -906,7 +908,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
         context "when saving the root" do
 
           before do
-            from_db.save
+            from_db.save!
           end
 
           it "persists the new document on the first save" do
@@ -920,15 +922,15 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
   context "when embedding a one under a many" do
 
     let!(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:address_one) do
-      person.addresses.create(street: "hobrecht")
+      person.addresses.create!(street: "hobrecht")
     end
 
     let!(:address_two) do
-      person.addresses.create(street: "kreuzberg")
+      person.addresses.create!(street: "kreuzberg")
     end
 
     context "when a parent was removed outside of mongoid" do
@@ -963,7 +965,7 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
   context "when embedded documents are stored without ids" do
 
     let!(:band) do
-      Band.create(name: "Moderat")
+      Band.create!(name: "Moderat")
     end
 
     before do
@@ -1010,9 +1012,9 @@ describe Mongoid::Association::Embedded::EmbedsOne::Proxy do
   context "when parent validation of child is set to false" do
 
     let(:building) do
-      building = Building.create
+      building = Building.create!
       building.building_address = BuildingAddress.new
-      building.save
+      building.save!
       building.reload
     end
 

data/spec/mongoid/association/embedded/embeds_one_dnl_models.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file is added as an autoload target, but should never be actually
 # processed.
 

data/spec/mongoid/association/embedded/embeds_one_models.rb

@@ -1,5 +1,8 @@
+# frozen_string_literal: true
+
 class EomParent
   include Mongoid::Document
+  include Mongoid::Timestamps
 
   embeds_one :child, class_name: 'EomChild'
 

data/spec/mongoid/association/embedded/embeds_one_query_spec.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative './embeds_one_models'
+
+describe Mongoid::Association::Embedded::EmbedsOne do
+
+  context 'when projecting with #only' do
+    before do
+      parent = EomParent.new(name: 'foo')
+      parent.child = EomChild.new(a: 1, b: 2)
+      parent.save!
+    end
+
+    let(:parent) do
+      EomParent.where(name: 'foo').only(:name, 'child._id', 'child.a').first
+    end
+
+    it 'populates specified fields only' do
+      expect(parent.child.a).to eq(1)
+      # has a default value specified in the model
+      expect do
+        parent.child.b
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(parent.child.attributes.keys).to eq(['_id', 'a'])
+    end
+  end
+end

data/spec/mongoid/association/embedded/embeds_one_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 require_relative './embeds_one_models'
 
@@ -951,4 +953,4 @@ describe Mongoid::Association::Embedded::EmbedsOne do
       expect(association.create_relation(owner, target)).to be_a(EmbeddedObject)
     end
   end
-end
+end

data/spec/mongoid/association/macros_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Macros do
@@ -404,7 +406,7 @@ describe Mongoid::Association::Macros do
               let(:default_require) { true }
 
               it 'does not require the association' do
-                expect(relation.save).to be(true)
+                expect(relation.save!).to be(true)
               end
             end
 
@@ -413,7 +415,7 @@ describe Mongoid::Association::Macros do
               let(:default_require) { false }
 
               it 'does not require the association' do
-                expect(relation.save).to be(true)
+                expect(relation.save!).to be(true)
               end
             end
           end
@@ -496,7 +498,7 @@ describe Mongoid::Association::Macros do
                 let(:default_require) { true }
 
                 it 'does not require the association' do
-                  expect(relation.save).to be(true)
+                  expect(relation.save!).to be(true)
                 end
               end
 
@@ -505,7 +507,7 @@ describe Mongoid::Association::Macros do
                 let(:default_require) { true }
 
                 it 'does not require the association' do
-                  expect(relation.save).to be(true)
+                  expect(relation.save!).to be(true)
                 end
               end
             end
@@ -524,7 +526,7 @@ describe Mongoid::Association::Macros do
                 let(:default_require) { true }
 
                 it 'does not require the association' do
-                  expect(relation.save).to be(true)
+                  expect(relation.save!).to be(true)
                 end
               end
 
@@ -533,7 +535,7 @@ describe Mongoid::Association::Macros do
                 let(:default_require) { false }
 
                 it 'does not require the association' do
-                  expect(relation.save).to be(true)
+                  expect(relation.save!).to be(true)
                 end
               end
             end
@@ -556,7 +558,7 @@ describe Mongoid::Association::Macros do
               let(:default_require) { true }
 
               it 'does not require the association' do
-                expect(relation.save).to be(true)
+                expect(relation.save!).to be(true)
               end
             end
 
@@ -565,7 +567,7 @@ describe Mongoid::Association::Macros do
               let(:default_require) { false }
 
               it 'does not require the association' do
-                expect(relation.save).to be(true)
+                expect(relation.save!).to be(true)
               end
             end
           end
@@ -614,7 +616,7 @@ describe Mongoid::Association::Macros do
         let(:default_require) { false }
 
         it 'does not require the association' do
-          expect(relation.save).to be(true)
+          expect(relation.save!).to be(true)
         end
       end
     end

data/spec/mongoid/association/nested/many_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Nested::Many do

data/spec/mongoid/association/nested/one_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Nested::One do
@@ -134,20 +136,24 @@ describe Mongoid::Association::Nested::One do
         { allow_destroy: true }
       end
 
-      let(:builder) do
-        described_class.new(association, {
-          id: name.id,
-          last_name: "Lang",
-          _destroy: true
-        }, options)
-      end
+      %i(id _id).each do |id_field|
+        context "#{id_field}" do
+          let(:builder) do
+            described_class.new(association, {
+              id_field => name.id,
+              last_name: "Lang",
+              _destroy: true
+            }, options)
+          end
 
-      before do
-        builder.build(person)
-      end
+          before do
+            builder.build(person)
+          end
 
-      it "deletes the relation" do
-        expect(person.name).to be_nil
+          it "deletes the relation" do
+            expect(person.name).to be_nil
+          end
+        end
       end
     end
   end

data/spec/mongoid/association/options_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Options do

data/spec/mongoid/association/polymorphic_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe "Polymorphic Associations" do

data/spec/mongoid/association/referenced/belongs_to/binding_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::BelongsTo::Binding do

data/spec/mongoid/association/referenced/belongs_to/buildable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::BelongsTo::Buildable do
@@ -12,8 +14,12 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
       association.build(base, object)
     end
 
+    let(:options) do
+      {}
+    end
+
     let(:association) do
-      Post.relations['person']
+      Mongoid::Association::Referenced::BelongsTo.new(Post, :person, options)
     end
 
     context "when provided an id" do
@@ -21,7 +27,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
       context "when the object is an object id" do
 
         let!(:person) do
-          Person.create(_id: object)
+          Person.create!(_id: object, username: 'Bob')
         end
 
         let(:object) do
@@ -29,7 +35,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
         end
 
         before do
-          expect(Person).to receive(:where).with(association.primary_key => object).and_call_original
+          expect_any_instance_of(Mongoid::Criteria).to receive(:where).with(association.primary_key => object).and_call_original
         end
 
         it "sets the document" do
@@ -37,6 +43,41 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
         end
       end
 
+      context "when scope is specified" do
+
+        let!(:person) do
+          Person.create(_id: object, username: 'Bob')
+        end
+
+        let(:object) do
+          BSON::ObjectId.new
+        end
+
+        let(:options) do
+          {
+            scope: -> { where(username: 'Bob') }
+          }
+        end
+
+        context "when document satisfies scope" do
+
+          it "sets the document" do
+            expect(document).to eq(person)
+          end
+        end
+
+        context "when document does not satisfy scope" do
+
+          let!(:person) do
+            Person.create(_id: object, username: 'Bruce')
+          end
+
+          it "returns nil" do
+            expect(document).to eq(nil)
+          end
+        end
+      end
+
       context 'when the id is nil' do
 
         let(:object) do
@@ -55,7 +96,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
       context "when the id does not correspond to a document in the database" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:object) do
@@ -63,7 +104,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
         end
 
         before do
-          expect(Person).to receive(:where).with(association.primary_key => object).and_call_original
+          expect_any_instance_of(Mongoid::Criteria).to receive(:where).with(association.primary_key => object).and_call_original
         end
 
         it 'returns nil' do
@@ -74,7 +115,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
       context "when the object is an integer" do
 
         let!(:person) do
-          Person.create(_id: object)
+          Person.create!(_id: object)
         end
 
         let(:object) do
@@ -82,7 +123,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
         end
 
         before do
-          expect(Person).to receive(:where).with(association.primary_key => object).and_call_original
+          expect_any_instance_of(Mongoid::Criteria).to receive(:where).with(association.primary_key => object).and_call_original
         end
 
         it "sets the document" do
@@ -94,7 +135,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
     context "when provided a object" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:object) do
@@ -102,7 +143,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
       end
 
       before do
-        expect(Person).not_to receive(:where)
+        expect_any_instance_of(Mongoid::Criteria).not_to receive(:where)
       end
 
       it "returns the object" do
@@ -113,7 +154,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
     context "when the document is persisted" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:game) do
@@ -128,16 +169,16 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
     context 'setting an associated document to nil' do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:game) do
-        Game.create(person: person)
+        Game.create!(person: person)
       end
 
       before do
         game.person = nil
-        game.save
+        game.save!
       end
 
       it 'sets the person_id to nil' do
@@ -153,11 +194,11 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
   describe '#substitute' do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:game) do
-      Game.create(person: person)
+      Game.create!(person: person)
     end
 
     context 'setting an associated document to nil' do
@@ -178,7 +219,7 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
     context 'setting an associated document to other doc' do
 
       let(:other_person) do
-        Person.create
+        Person.create!
       end
 
       before do