mongoid 6.4.8 → 7.5.4

data/spec/mongoid/findable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Findable do
@@ -5,8 +7,8 @@ describe Mongoid::Findable do
   describe ".distinct" do
 
     before do
-      Band.create(name: "Tool")
-      Band.create(name: "Photek")
+      Band.create!(name: "Tool")
+      Band.create!(name: "Photek")
     end
 
     it "returns the distinct values for the field" do
@@ -17,7 +19,7 @@ describe Mongoid::Findable do
   describe ".each" do
 
     let!(:band) do
-      Band.create
+      Band.create!
     end
 
     it "iterates through all documents" do
@@ -30,7 +32,7 @@ describe Mongoid::Findable do
   describe ".each_with_index" do
 
     let!(:band) do
-      Band.create
+      Band.create!
     end
 
     it "iterates through all documents" do
@@ -43,7 +45,7 @@ describe Mongoid::Findable do
   describe ".find_one_and_update" do
 
     let!(:person) do
-      Person.create(title: "Senior")
+      Person.create!(title: "Senior")
     end
 
     it "returns the document" do
@@ -56,7 +58,7 @@ describe Mongoid::Findable do
     context "when collection is a embeds_many" do
 
       let(:person) do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       let!(:message) do
@@ -105,7 +107,7 @@ describe Mongoid::Findable do
     context "when the document is found" do
 
       let!(:person) do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       context "when no block is provided" do
@@ -182,7 +184,7 @@ describe Mongoid::Findable do
     context "when the document is found" do
 
       let!(:person) do
-        Person.create(title: "sir")
+        Person.create!(title: "sir")
       end
 
       context "when no block is provided" do
@@ -221,12 +223,42 @@ describe Mongoid::Findable do
     describe "##{method}" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       it "returns the first matching document" do
         expect(Person.send(method)).to eq(person)
       end
+
+      it "doen't raise when passing options" do
+        expect do
+          Person.first(id_sort: :none)
+        end.to_not raise_error
+      end
+
+      it "passes the limit through" do
+        Person.first(1).length.should == 1
+      end
+    end
+  end
+
+  describe "#last" do
+    let!(:person) do
+      Person.create!
+    end
+
+    it "returns the first matching document" do
+      expect(Person.last).to eq(person)
+    end
+
+    it "doen't raise when passing options" do
+      expect do
+        Person.last(id_sort: :none)
+      end.to_not raise_error
+    end
+
+    it "passes the limit through" do
+      Person.last(1).length.should == 1
     end
   end
 
@@ -235,7 +267,7 @@ describe Mongoid::Findable do
     context "when the document is found" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       it "returns the document" do
@@ -248,7 +280,7 @@ describe Mongoid::Findable do
       context "when providing a document" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:from_db) do
@@ -303,7 +335,7 @@ describe Mongoid::Findable do
     context "when the document is found" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       it "returns the document" do
@@ -316,7 +348,7 @@ describe Mongoid::Findable do
       context "when providing a document" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let(:found) do
@@ -377,7 +409,7 @@ describe Mongoid::Findable do
   describe ".none" do
 
     let!(:depeche) do
-      Band.create(name: "Depeche Mode", likes: 3)
+      Band.create!(name: "Depeche Mode", likes: 3)
     end
 
     context "when not chaining any criteria" do
@@ -442,15 +474,15 @@ describe Mongoid::Findable do
   describe ".pluck" do
 
     let!(:depeche) do
-      Band.create(name: "Depeche Mode", likes: 3)
+      Band.create!(name: "Depeche Mode", likes: 3)
     end
 
     let!(:tool) do
-      Band.create(name: "Tool", likes: 3)
+      Band.create!(name: "Tool", likes: 3)
     end
 
     let!(:photek) do
-      Band.create(name: "Photek", likes: 1)
+      Band.create!(name: "Photek", likes: 1)
     end
 
     context "when field values exist" do
@@ -476,6 +508,38 @@ describe Mongoid::Findable do
     end
   end
 
+  describe '.count' do
+    context 'when the collection is not empty' do
+      before do
+        Band.create!(name: "Tool")
+        Band.create!(name: "Photek")
+      end
+
+      it 'returns the currect count' do
+        expect(Band.count).to eq(2)
+      end
+    end
+  end
+
+  describe '.estimated_count' do
+    context 'when the collection is not empty' do
+      before do
+        Band.create!(name: "Tool")
+        Band.create!(name: "Photek")
+      end
+
+      it 'returns the correct count' do
+        expect(Band.estimated_count).to eq(2)
+      end
+    end
+
+    context 'when the collection is empty' do
+      it 'returns the correct count' do
+        expect(Band.estimated_count).to eq(0)
+      end
+    end
+  end
+
   Mongoid::Criteria::Queryable::Selectable.forwardables.each do |method|
 
     describe "##{method}" do
@@ -496,7 +560,7 @@ describe Mongoid::Findable do
 
     let!(:time) do
       Time.zone.now.tap do |t|
-        User.create(last_login: t, name: 'Tom')
+        User.create!(last_login: t, name: 'Tom')
       end
     end
 
@@ -518,7 +582,7 @@ describe Mongoid::Findable do
 
     let!(:time) do
       Time.now.tap do |t|
-        User.create(last_login: t, name: 'Tom')
+        User.create!(last_login: t, name: 'Tom')
       end
     end
 

data/spec/mongoid/indexable/specification_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Indexable::Specification do

data/spec/mongoid/indexable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Indexable do
@@ -45,7 +47,7 @@ describe Mongoid::Indexable do
       end
     end
 
-    context "when database specific options exist", if: non_legacy_server? do
+    context "when database specific options exist" do
 
       let(:klass) do
         Class.new do
@@ -89,12 +91,13 @@ describe Mongoid::Indexable do
         klass.create_indexes
       end
 
-      it "creates the indexes" do
-        expect(klass.collection.indexes.get(_type: 1)).to_not be_nil
+      it "creates the indexes by using specified background option" do
+        index = klass.collection.indexes.get(_type: 1)
+        expect(index[:background]).to eq(true)
       end
     end
 
-    context "when database options are specified", if: non_legacy_server? do
+    context "when database options are specified" do
 
       let(:klass) do
         Class.new do
@@ -104,12 +107,9 @@ describe Mongoid::Indexable do
         end
       end
 
-      before do
-        klass.create_indexes
-      end
-
       after do
         klass.remove_indexes
+        Mongoid::Config.background_indexing = false
       end
 
       let(:indexes) do
@@ -118,12 +118,25 @@ describe Mongoid::Indexable do
         end
       end
 
-      it "creates the indexes" do
-        expect(indexes.get(_type: 1)).to_not be_nil
+      it "creates the indexes by using default background_indexing option" do
+        klass.create_indexes
+
+        index = indexes.get(_type: 1)
+        expect(index[:background]).to eq(Mongoid::Config.background_indexing)
+      end
+
+      it "creates the indexes by using specified background_indexing option" do
+        Mongoid::Config.background_indexing = true
+
+        klass.create_indexes
+
+        index = indexes.get(_type: 1)
+        expect(index[:background]).to eq(true)
       end
     end
 
-    context "when a collation option is specified", if: collation_supported? do
+    context "when a collation option is specified" do
+      min_server_version '3.4'
 
       let(:klass) do
         Class.new do
@@ -177,6 +190,32 @@ describe Mongoid::Indexable do
         expect(spec.options).to eq(unique: false, background: true)
       end
     end
+
+    context "when using a custom discriminator_key" do 
+      context "when indexes have not been added" do
+        let(:klass) do
+          Class.new do
+            include Mongoid::Document
+            self.discriminator_key = "dkey"
+            def self.hereditary?
+              true
+            end
+          end
+        end
+  
+        before do
+          klass.add_indexes
+        end
+  
+        let(:spec) do
+          klass.index_specification(dkey: 1)
+        end
+  
+        it "adds the _type index" do
+          expect(spec.options).to eq(unique: false, background: true)
+        end
+      end
+    end
   end
 
   describe ".index" do
@@ -298,7 +337,8 @@ describe Mongoid::Indexable do
       end
     end
 
-    context "when providing a collation option", if: collation_supported? do
+    context "when providing a collation option" do
+      min_server_version '3.4'
 
       before do
         klass.index({ name: 1 }, collation: { locale: 'en_US', strength: 2 })
@@ -368,7 +408,7 @@ describe Mongoid::Indexable do
       end
     end
 
-    context "when providing a geospacial index" do
+    context "when providing a geospatial index" do
 
       before do
         klass.index({ location: "2d" }, { min: -200, max: 200, bits: 32 })
@@ -378,7 +418,7 @@ describe Mongoid::Indexable do
         klass.index_specification(location: "2d").options
       end
 
-      it "sets the geospacial index" do
+      it "sets the geospatial index" do
         expect(options).to eq({ min: -200, max: 200, bits: 32 })
       end
     end

data/spec/mongoid/inspectable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Inspectable do
@@ -23,12 +25,39 @@ describe Mongoid::Inspectable do
       end
 
       it "displays defined fields" do
-        expect(inspected).to include("title: \"CEO\"")
+        expect(inspected).to include(%q,title: "CEO",)
       end
 
       it "displays field aliases" do
         expect(inspected).to include("t(test):")
       end
+
+      it "displays the default discriminator key" do
+        expect(inspected).to include(%q,_type: "Person",)
+      end
+    end
+
+    context "when using a custom discriminator key" do
+
+      before do
+        Person.discriminator_key = "dkey"
+      end
+
+      after do
+        Person.discriminator_key = nil
+      end
+
+      let(:person) do
+        Person.new(title: "CEO")
+      end
+
+      let(:inspected) do
+        person.inspect
+      end
+
+      it "displays the new discriminator key" do
+        expect(inspected).to include(%q,dkey: "Person",)
+      end
     end
 
     context "when allowing dynamic fields" do
@@ -42,7 +71,15 @@ describe Mongoid::Inspectable do
       end
 
       it "includes dynamic attributes" do
-        expect(inspected).to include("some_attribute: \"foo\"")
+        expect(inspected).to include(%q,some_attribute: "foo",)
+      end
+    end
+
+    context 'when id is unaliased' do
+      let(:shirt) { Shirt.new(id: 1, _id: 2) }
+
+      it 'shows the correct _id and id values' do
+        shirt.inspect.should == "#<Shirt _id: 2, color: nil, id: \"1\">"
       end
     end
   end