mongoid 5.4.1 → 6.1.1

data/spec/mongoid/persistable/creatable_spec.rb

@@ -523,13 +523,18 @@ describe Mongoid::Persistable::Creatable do
       context "when a unique index exists" do
 
         before do
+          Person.index({ ssn: 1 }, { unique: true })
           Person.create_indexes
         end
 
+        after do
+          Person.collection.drop
+        end
+
         it "raises an error" do
           expect {
             4.times { Person.create!(ssn: "555-55-1029") }
-          }.to raise_error
+          }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
     end
@@ -562,7 +567,7 @@ describe Mongoid::Persistable::Creatable do
       end
     end
 
-    context "when a callback returns false" do
+    context "when a callback aborts the chain" do
 
       it "raises a callback error" do
         expect { Oscar.create! }.to raise_error(Mongoid::Errors::Callback)

data/spec/mongoid/persistable/deletable_spec.rb

@@ -30,7 +30,7 @@ describe Mongoid::Persistable::Deletable do
       it "deletes the document from the collection" do
         expect {
           Person.find(person.id)
-        }.to raise_error
+        }.to raise_error(Mongoid::Errors::DocumentNotFound)
       end
 
       it "returns true" do
@@ -213,6 +213,21 @@ describe Mongoid::Persistable::Deletable do
           expect(removed).to eq(1)
         end
       end
+
+      context "when the conditions need to be mongoized" do
+
+        let!(:removed) do
+          Person.delete_all(id: person.id)
+        end
+
+        it "removes the matching documents" do
+          expect(Person.count).to eq(1)
+        end
+
+        it "returns the number of documents removed" do
+          expect(removed).to eq(1)
+        end
+      end
     end
   end
 end

data/spec/mongoid/persistable/destroyable_spec.rb

@@ -30,7 +30,7 @@ describe Mongoid::Persistable::Destroyable do
       it "destroys the document from the collection" do
         expect {
           Person.find(person.id)
-        }.to raise_error
+        }.to raise_error(Mongoid::Errors::DocumentNotFound)
       end
 
       it "returns true" do
@@ -164,7 +164,11 @@ describe Mongoid::Persistable::Destroyable do
       end
 
       before do
-        expect(album).to receive(:set_parent_name).and_return(false)
+        Album.before_destroy(:set_parent_name_fail)
+      end
+
+      after do
+        Album.reset_callbacks(:destroy)
       end
 
       it "raises an exception" do

data/spec/mongoid/persistable/savable_spec.rb

@@ -189,8 +189,8 @@ describe Mongoid::Persistable::Savable do
               "title" => "King",
               "name.first_name" => "Ryan"
             },
-            "$push"=> {
-              "addresses" => {'$each' => [ { "_id" => address.id, "street" => "Bond St" } ]}
+            "$pushAll"=> {
+              "addresses" => [ { "_id" => address.id, "street" => "Bond St" } ]
             }
           })
         end
@@ -295,20 +295,37 @@ describe Mongoid::Persistable::Savable do
       end
     end
 
-    context "when the document is readonly" do
-
-      let(:person) do
-        Person.only(:title).first
-      end
+    context "when the changed attribute is not writable" do
 
       before do
         Person.create(title: "sir")
       end
 
+      let(:person) do
+        Person.only(:title).first
+      end
+
       it "raises an error" do
         expect {
+          person.username = 'unloaded-attribute'
           person.save
-        }.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        }.to raise_error(Mongoid::Errors::ReadonlyAttribute)
+      end
+
+      context 'when the changed attribute is aliased' do
+
+        before do
+          Person.create(at: Time.now)
+        end
+
+        let(:person) do
+          Person.only(:at).first
+        end
+
+        it "saves the document" do
+          person.aliased_timestamp = Time.now
+          expect(person.save(validate: false)).to be true
+        end
       end
     end
 
@@ -353,12 +370,17 @@ describe Mongoid::Persistable::Savable do
         end
 
         before do
+          Person.index({ ssn: 1 }, { unique: true })
           Person.create_indexes
           Person.create!(ssn: "555-55-9999")
         end
 
-        it "raises an error" do
-          expect { person.save! }.to raise_error
+        after do
+          Person.collection.drop
+        end
+
+        it "raises an OperationFailure" do
+          expect { person.save! }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
     end
@@ -374,12 +396,12 @@ describe Mongoid::Persistable::Savable do
       end
 
       it "raises an error with multiple save attempts" do
-        expect { subject.save! }.to raise_error
-        expect { subject.save! }.to raise_error
+        expect { service.save! }.to raise_error(Mongoid::Errors::Validations)
+        expect { service.save! }.to raise_error(Mongoid::Errors::Validations)
       end
     end
 
-    context "when a callback returns false" do
+    context "when a callback aborts the callback chain" do
 
       let(:oscar) do
         Oscar.new
@@ -495,22 +517,5 @@ describe Mongoid::Persistable::Savable do
         expect(from_db.shapes.first.canvas).to eq(firefox)
       end
     end
-
-    context "when the document is readonly" do
-
-      let(:person) do
-        Person.only(:title).first
-      end
-
-      before do
-        Person.create(title: "sir")
-      end
-
-      it "raises an error" do
-        expect {
-          person.save!
-        }.to raise_error(Mongoid::Errors::ReadonlyDocument)
-      end
-    end
   end
 end

data/spec/mongoid/persistable/settable_spec.rb

@@ -230,6 +230,22 @@ describe Mongoid::Persistable::Settable do
       end
     end
 
+    context 'when the field is assigned with nil' do
+
+      before do
+        church.location = nil
+        church.set('location.neighborhood' => 'Kreuzberg')
+      end
+
+      it 'updates the hash while keeping existing key and values locally' do
+        expect(church.location).to eq({'neighborhood' => 'Kreuzberg'})
+      end
+
+      it 'updates the hash in the database' do
+        expect(church.reload.location).to eq({'neighborhood' => 'Kreuzberg'})
+      end
+    end
+
     context 'when the field type is String' do
 
       before do
@@ -261,48 +277,48 @@ describe Mongoid::Persistable::Settable do
         expect(church.reload.location).to eq({ 'city' => 'Berlin', 'street' => 'Yorckstr.'})
       end
     end
-  end
 
-  context 'when the field is a nested hash' do
+    context 'when the field is a bested hash' do
 
-    context 'when a leaf value in the nested hash is updated' do
+      context 'when a leaf value in the nested hash is updated' do
 
-      let(:church) do
-        Church.new.tap do |a|
-          a.location = {'address' => {'city' => 'Berlin', 'street' => 'Yorckstr'}}
-          a.name = 'Church1'
-          a.save
+        let(:church) do
+          Church.new.tap do |a|
+            a.location = {'address' => {'city' => 'Berlin', 'street' => 'Yorckstr'}}
+            a.name = 'Church1'
+            a.save
+          end
         end
-      end
 
-      before do
-        church.set('location.address.city' => 'Munich')
-      end
+        before do
+          church.set('location.address.city' => 'Munich')
+        end
 
-      it 'does not reset the nested hash' do
-        expect(church.name).to eq('Church1')
-        expect(church.location).to eql({'address' => {'city' => 'Munich', 'street' => 'Yorckstr'}})
+        it 'does not reset the nested hash' do
+          expect(church.name).to eq('Church1')
+          expect(church.location).to eql({'address' => {'city' => 'Munich', 'street' => 'Yorckstr'}})
+        end
       end
-    end
 
 
-    context 'when the nested hash is many levels deep' do
+      context 'when the nested hash is many levels deep' do
 
-      let(:church) do
-        Church.new.tap do |a|
-          a.location = {'address' => {'state' => {'address' => {'city' => 'Berlin', 'street' => 'Yorckstr'}}}}
-          a.name = 'Church1'
-          a.save
+        let(:church) do
+          Church.new.tap do |a|
+            a.location = {'address' => {'state' => {'address' => {'city' => 'Berlin', 'street' => 'Yorckstr'}}}}
+            a.name = 'Church1'
+            a.save
+          end
         end
-      end
 
-      before do
-        church.set('location.address.state.address.city' => 'Munich')
-      end
+        before do
+          church.set('location.address.state.address.city' => 'Munich')
+        end
 
-      it 'does not reset the nested hash' do
-        expect(church.name).to eq('Church1')
-        expect(church.location).to eql({'address' => {'state' => {'address' => {'city' => 'Munich', 'street' => 'Yorckstr'}}}})
+        it 'does not reset the nested hash' do
+          expect(church.name).to eq('Church1')
+          expect(church.location).to eql({'address' => {'state' => {'address' => {'city' => 'Munich', 'street' => 'Yorckstr'}}}})
+        end
       end
     end
   end

data/spec/mongoid/persistable/updatable_spec.rb

@@ -112,6 +112,24 @@ describe Mongoid::Persistable::Updatable do
       end
     end
 
+    context "when dynamic attributes are not enabled" do
+
+      it "raises exception for an unknown attribute " do
+        account = Account.create
+
+        expect {
+          account.update_attribute(:somethingnew, "somethingnew")
+        }.to raise_error(Mongoid::Errors::UnknownAttribute)
+      end
+
+      it "will update value of aliased field" do
+        person = Person.create
+        person.update_attribute(:t, "test_value")
+        expect(person.reload.t).to eq "test_value"
+        expect(person.test).to eq "test_value"
+      end
+    end
+
     context "when provided a symbol attribute name" do
 
       let(:post) do
@@ -168,7 +186,7 @@ describe Mongoid::Persistable::Updatable do
         it "raises an error" do
           expect {
             post.update_attribute(:title, "something")
-          }.to raise_error
+          }.to raise_error(RuntimeError)
         end
       end
     end
@@ -269,6 +287,167 @@ describe Mongoid::Persistable::Updatable do
         expect(from_db.reload.name).to eq("home")
       end
     end
+
+    context 'when the field is read-only' do
+
+      before do
+        Person.attr_readonly :species
+      end
+
+      after do
+        Person.readonly_attributes.reject! { |a| a.to_s == 'species' }
+      end
+
+      let(:person) do
+        Person.create(species: :human)
+      end
+
+      it 'raises an error when trying to set the attribute' do
+        expect {
+          person.update_attribute(:species, :reptile)
+        }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+      end
+
+      context 'when referring to the attribute with a string' do
+
+        it 'raises an error when trying to set the attribute' do
+          expect {
+            person.update_attribute('species', :reptile)
+          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        end
+      end
+
+      context 'when the field is aliased' do
+
+        before do
+          Person.attr_readonly :at
+        end
+
+        after do
+          Person.readonly_attributes.reject! { |a| a.to_s == 'at' }
+        end
+
+        it 'raises an error when trying to set the attribute using the db name' do
+          expect {
+            person.update_attribute(:at, Time.now)
+          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        end
+
+        it 'raises an error when trying to set the attribute using the aliased name' do
+          expect {
+            person.update_attribute(:aliased_timestamp, Time.now)
+          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        end
+      end
+    end
+
+    context 'when the field is loaded explicitly' do
+
+      before do
+        Person.create(title: 'Captain')
+      end
+
+      context 'when the loaded attribute is updated' do
+
+        let(:person) do
+          Person.only(:title).first.tap do |_person|
+            _person.update_attribute(:title, 'Esteemed')
+          end
+        end
+
+        it 'allows the field to be updated' do
+          expect(person.title).to eq('Esteemed')
+        end
+
+        it 'persists the updated field' do
+          expect(person.reload.title).to eq('Esteemed')
+        end
+      end
+
+      context 'when the an attribute other than the loaded one is updated' do
+
+        let(:person) do
+          Person.only(:title).first
+        end
+
+        it 'does not allow the field to be updated' do
+          expect {
+            person.update_attribute(:age, 20)
+          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        end
+
+        it 'does not persist the change' do
+          expect(person.reload.age).to eq(100)
+        end
+
+        context 'when referring to the attribute with a string' do
+
+          it 'does not allow the field to be updated' do
+            expect {
+              person.update_attribute('age', 20)
+            }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+          end
+
+          it 'does not persist the change' do
+            expect(person.reload.age).to eq(100)
+          end
+        end
+      end
+    end
+
+    context 'when fields are explicitly not loaded' do
+
+      before do
+        Person.create(title: 'Captain')
+      end
+
+      context 'when the loaded attribute is updated' do
+
+        let(:person) do
+          Person.without(:age).first.tap do |_person|
+            _person.update_attribute(:title, 'Esteemed')
+          end
+        end
+
+        it 'allows the field to be updated' do
+          expect(person.title).to eq('Esteemed')
+        end
+
+        it 'persists the updated field' do
+          expect(person.reload.title).to eq('Esteemed')
+        end
+      end
+
+      context 'when the non-loaded attribute is updated' do
+
+        let(:person) do
+          Person.without(:title).first
+        end
+
+        it 'does not allow the field to be updated' do
+          expect {
+            person.update_attribute(:title, 'Esteemed')
+          }.to raise_exception(ActiveModel::MissingAttributeError)
+        end
+
+        it 'does not persist the change' do
+          expect(person.reload.title).to eq('Captain')
+        end
+
+        context 'when referring to the attribute with a string' do
+
+          it 'does not allow the field to be updated' do
+            expect {
+              person.update_attribute('title', 'Esteemed')
+            }.to raise_exception(ActiveModel::MissingAttributeError)
+          end
+
+          it 'does not persist the change' do
+            expect(person.reload.title).to eq('Captain')
+          end
+        end
+      end
+    end
   end
 
   [:update_attributes, :update].each do |method|
@@ -283,7 +462,7 @@ describe Mongoid::Persistable::Updatable do
 
         it "raises an error" do
           expect {
-            person.update_attributes(map: { "$bad.key" => "value" })
+            person.update_attributes(map: { "bad.key" => "value" })
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
@@ -319,7 +498,7 @@ describe Mongoid::Persistable::Updatable do
 
         it "raises an error" do
           expect {
-            person.send(method, map: { "$bad.key" => "value" })
+            person.send(method, map: { "bad.key" => "value" })
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
@@ -360,7 +539,7 @@ describe Mongoid::Persistable::Updatable do
         it "raises an error" do
           expect {
             person.send(method, title: "something")
-          }.to raise_error
+          }.to raise_error(RuntimeError)
         end
       end
 
@@ -543,7 +722,7 @@ describe Mongoid::Persistable::Updatable do
 
   describe "#update!" do
 
-    context "when a callback returns false" do
+    context "when a callback aborts the callback chain" do
 
       let(:oscar) do
         Oscar.new