mongoid 5.4.1 → 6.1.1

data/spec/mongoid/errors/invalid_relation_spec.rb

@@ -0,0 +1,37 @@
+require "spec_helper"
+
+describe Mongoid::Errors::InvalidRelation do
+
+  describe "#message" do
+
+    module MyModule
+      def crazy_method; self; end
+    end
+
+    before do
+      Object.send(:include, MyModule)
+    end
+
+    let(:error) do
+      described_class.new(Person, :crazy_method)
+    end
+
+    it "contains the problem in the message" do
+      expect(error.message).to include(
+                                   "Defining a relation named 'crazy_method' is not allowed."
+                               )
+    end
+
+    it "contains the summary in the message" do
+      expect(error.message).to include(
+                                   "Defining this relation would override the method 'crazy_method'"
+                               )
+    end
+
+    it "contains the resolution in the message" do
+      expect(error.message).to include(
+                                   "Use Mongoid.destructive_fields to see what names are not allowed"
+                               )
+    end
+  end
+end

data/spec/mongoid/errors/mongoid_error_spec.rb

@@ -50,15 +50,18 @@ describe Mongoid::Errors::MongoidError do
   describe "#to_json" do
 
     it "has problem" do
-      expect(error.to_json).to include('"problem":"message"')
+      # @todo: uncomment if https://github.com/rails/rails/pull/24628 is merged
+      #expect(error.to_json).to include('"problem":"message"')
     end
 
     it "has summary" do
-      expect(error.to_json).to include('"summary":"summary"')
+      # @todo: uncomment if https://github.com/rails/rails/pull/24628 is merged
+      #expect(error.to_json).to include('"summary":"summary"')
     end
 
     it "has resolution" do
-      expect(error.to_json).to include('"resolution":"resolution"')
+      # @todo: uncomment if https://github.com/rails/rails/pull/24628 is merged
+      #expect(error.to_json).to include('"resolution":"resolution"')
     end
   end
 end

data/spec/mongoid/extensions/big_decimal_spec.rb

@@ -2,16 +2,64 @@ require "spec_helper"
 
 describe Mongoid::Extensions::BigDecimal do
 
-  let(:number) do
+  let(:big_decimal) do
     BigDecimal.new("123456.789")
   end
 
   describe ".demongoize" do
 
-    context "when the the value is a string" do
+    context "when the value is an empty String" do
 
-      it "returns a big decimal" do
-        expect(BigDecimal.demongoize(number.to_s)).to eq(number)
+      let(:string) do
+        ""
+      end
+
+      it "returns nil" do
+        expect(BigDecimal.demongoize(string)).to be_nil
+      end
+    end
+
+    context "when the value is a numeric String" do
+
+      let(:string) do
+        "123456.789"
+      end
+
+      it "returns a BigDecimal" do
+        expect(BigDecimal.demongoize(string)).to eq(BigDecimal.new(string))
+      end
+    end
+
+    context "when the value is the numeric String zero" do
+
+      let(:string) do
+        "0.0"
+      end
+
+      it "returns a BigDecimal" do
+        expect(BigDecimal.demongoize(string)).to eq(BigDecimal.new(string))
+      end
+    end
+
+    context "when the value is the numeric String negative zero" do
+
+      let(:string) do
+        "-0.0"
+      end
+
+      it "returns a BigDecimal" do
+        expect(BigDecimal.demongoize(string)).to eq(BigDecimal.new(string))
+      end
+    end
+
+    context "when the value is a non-numeric String" do
+
+      let(:string) do
+        "1a2"
+      end
+
+      it "returns nil" do
+        expect(BigDecimal.demongoize(string)).to be_nil
       end
     end
 
@@ -22,18 +70,29 @@ describe Mongoid::Extensions::BigDecimal do
       end
     end
 
-    context "when the value is a float" do
+    context "when the value is true" do
 
-      let(:float) do
-        123456.789
+      let(:value) do
+        true
       end
 
-      it "returns a float" do
-        expect(BigDecimal.demongoize(float)).to eq(float)
+      it "returns nil" do
+        expect(BigDecimal.demongoize(value)).to be_nil
       end
     end
 
-    context "when the value is an integer" do
+    context "when the value is false" do
+
+      let(:value) do
+        false
+      end
+
+      it "returns nil" do
+        expect(BigDecimal.demongoize(value)).to be_nil
+      end
+    end
+
+    context "when the value is an Integer" do
 
       let(:integer) do
         123456
@@ -44,7 +103,18 @@ describe Mongoid::Extensions::BigDecimal do
       end
     end
 
-    context "when the value is NaN" do
+    context "when the value is a Float" do
+
+      let(:float) do
+        123456.789
+      end
+
+      it "returns a float" do
+        expect(BigDecimal.demongoize(float)).to eq(float)
+      end
+    end
+
+    context "when the value is the String 'NaN'" do
 
       let(:nan) do
         "NaN"
@@ -54,22 +124,126 @@ describe Mongoid::Extensions::BigDecimal do
         BigDecimal.demongoize(nan)
       end
 
-      it "returns a big decimal" do
+      it "returns a BigDecimal" do
         expect(demongoized).to be_a(BigDecimal)
       end
 
-      it "is a NaN big decimal" do
+      it "is a NaN BigDecimal" do
         expect(demongoized).to be_nan
       end
     end
+
+    context "when the value is the String 'Infinity'" do
+
+      let(:infinity) do
+        "Infinity"
+      end
+
+      let(:demongoized) do
+        BigDecimal.demongoize(infinity)
+      end
+
+      it "returns a BigDecimal" do
+        expect(demongoized).to be_a(BigDecimal)
+      end
+
+      it "is a infinity BigDecimal" do
+        expect(demongoized.infinite?).to eq 1
+      end
+    end
+
+    context "when the value is the String '-Infinity'" do
+
+      let(:neg_infinity) do
+        "-Infinity"
+      end
+
+      let(:demongoized) do
+        BigDecimal.demongoize(neg_infinity)
+      end
+
+      it "returns a BigDecimal" do
+        expect(demongoized).to be_a(BigDecimal)
+      end
+
+      it "is a negative infinity BigDecimal" do
+        expect(demongoized.infinite?).to eq -1
+      end
+    end
   end
 
   describe ".mongoize" do
 
-    context "when the value is a big decimal" do
+    context "when the value is a BigDecimal" do
 
       it "returns a string" do
-        expect(BigDecimal.mongoize(number)).to eq(number.to_s)
+        expect(BigDecimal.mongoize(big_decimal)).to eq(big_decimal.to_s)
+      end
+    end
+
+    context "when the value is the BigDecimal zero" do
+
+      let(:big_decimal) do
+        BigDecimal.new("0.0")
+      end
+
+      it "returns a BigDecimal" do
+        expect(BigDecimal.mongoize(big_decimal)).to eq(big_decimal.to_s)
+      end
+    end
+
+    context "when the value is the BigDecimal negative zero" do
+
+      let(:big_decimal) do
+        BigDecimal.new("-0.0")
+      end
+
+      it "returns a BigDecimal" do
+        expect(BigDecimal.mongoize(big_decimal)).to eq(big_decimal.to_s)
+      end
+    end
+
+    context "when the value is an empty String" do
+
+      let(:string) do
+        ""
+      end
+
+      it "returns nil" do
+        expect(BigDecimal.mongoize(string)).to be_nil
+      end
+    end
+
+    context "when the value is an integer numeric String" do
+
+      let(:string) do
+        "123456"
+      end
+
+      it "returns the String" do
+        expect(BigDecimal.mongoize(string)).to eq string
+      end
+    end
+
+    context "when the value is a float numeric String" do
+
+      let(:string) do
+        "123456.789"
+      end
+
+      it "returns the String" do
+        expect(BigDecimal.mongoize(string)).to eq string
+      end
+    end
+
+    context "when the value is a non-numeric String" do
+
+      let(:string) do
+        "1a2"
+      end
+
+      it "returns nil" do
+        expect(BigDecimal.mongoize(string)).to be_nil
       end
     end
 
@@ -80,25 +254,153 @@ describe Mongoid::Extensions::BigDecimal do
       end
     end
 
-    context "when the value is an integer" do
+    context "when the value is true" do
+
+      let(:value) do
+        true
+      end
+
+      it "returns nil" do
+        expect(BigDecimal.mongoize(value)).to be_nil
+      end
+    end
+
+    context "when the value is false" do
+
+      let(:value) do
+        false
+      end
+
+      it "returns nil" do
+        expect(BigDecimal.mongoize(value)).to be_nil
+      end
+    end
+
+    context "when the value is an Integer" do
 
       it "returns a string" do
         expect(BigDecimal.mongoize(123456)).to eq("123456")
       end
     end
 
-    context "when the value is a float" do
+    context "when the value is a Float" do
 
       it "returns a string" do
         expect(BigDecimal.mongoize(123456.789)).to eq("123456.789")
       end
     end
+
+    context "when the value is String NaN" do
+
+      let(:nan) do
+        "NaN"
+      end
+
+      it "returns a String" do
+        expect(BigDecimal.mongoize(nan)).to eq("NaN")
+      end
+    end
+
+    context "when the value is String Infinity" do
+
+      let(:infinity) do
+        "Infinity"
+      end
+
+      it "returns a String" do
+        expect(BigDecimal.mongoize(infinity)).to eq("Infinity")
+      end
+    end
+
+    context "when the value is String negative Infinity" do
+
+      let(:neg_infinity) do
+        "-Infinity"
+      end
+
+      it "returns a String" do
+        expect(BigDecimal.mongoize(neg_infinity)).to eq("-Infinity")
+      end
+    end
+
+    context "when the value is BigDecimal NaN" do
+
+      let(:nan) do
+        BigDecimal.new("NaN")
+      end
+
+      it "returns a String" do
+        expect(BigDecimal.mongoize(nan)).to eq("NaN")
+      end
+    end
+
+    context "when the value is BigDecimal Infinity" do
+
+      let(:infinity) do
+        BigDecimal.new("Infinity")
+      end
+
+      it "returns a String" do
+        expect(BigDecimal.mongoize(infinity)).to eq("Infinity")
+      end
+    end
+
+    context "when the value is BigDecimal negative Infinity" do
+
+      let(:neg_infinity) do
+        BigDecimal.new("-Infinity")
+      end
+
+      it "returns a String" do
+        expect(BigDecimal.mongoize(neg_infinity)).to eq("-Infinity")
+      end
+    end
+
+    context "when the value is the constant Float::NAN" do
+
+      let(:nan) do
+        Float::NAN
+      end
+
+      it "returns a String" do
+        expect(BigDecimal.mongoize(nan)).to eq("NaN")
+      end
+    end
+
+    context "when the value is constant Float::INFINITY" do
+
+      let(:infinity) do
+        Float::INFINITY
+      end
+
+      it "returns a String" do
+        expect(BigDecimal.mongoize(infinity)).to eq("Infinity")
+      end
+    end
+
+    context "when the value is constant Float::INFINITY * -1" do
+
+      let(:neg_infinity) do
+        Float::INFINITY * -1
+      end
+
+      it "returns a String" do
+        expect(BigDecimal.mongoize(neg_infinity)).to eq("-Infinity")
+      end
+    end
   end
 
   describe "#mongoize" do
 
     it "returns a string" do
-      expect(number.mongoize).to eq(number.to_s)
+      expect(big_decimal.mongoize).to eq(big_decimal.to_s)
+    end
+  end
+
+  describe "#numeric?" do
+
+    it "returns true" do
+      expect(big_decimal.numeric?).to eq(true)
     end
   end
 end