mongoid 5.4.1 → 6.1.1

data/spec/mongoid/extensions/boolean_spec.rb

@@ -82,6 +82,13 @@ describe Mongoid::Boolean do
         end
       end
 
+      context "when provided on" do
+
+        it "returns true" do
+          expect(described_class.mongoize("on")).to eq(true)
+        end
+      end
+
       context "when provided false" do
 
         it "returns false" do
@@ -123,6 +130,13 @@ describe Mongoid::Boolean do
           expect(described_class.mongoize("n")).to eq(false)
         end
       end
+
+      context "when provided off" do
+
+        it "returns true" do
+          expect(described_class.mongoize("off")).to eq(false)
+        end
+      end
     end
   end
 

data/spec/mongoid/extensions/date_spec.rb

@@ -135,12 +135,8 @@ describe Mongoid::Extensions::Date do
 
       context "when the string is an invalid time" do
 
-        let(:epoch) do
-          Date.new(1970, 1, 1)
-        end
-
-        it "returns epoch" do
-          expect(Date.mongoize("time")).to eq(epoch)
+        it "returns nil" do
+          expect(Date.mongoize("time")).to eq(nil)
         end
       end
     end

data/spec/mongoid/extensions/date_time_spec.rb

@@ -129,12 +129,8 @@ describe Mongoid::Extensions::DateTime do
 
     context "when the string is an invalid time" do
 
-      let(:epoch) do
-        Time.utc(1970, 1, 1, 0, 0, 0, 0)
-      end
-
-      it "returns epoch" do
-        expect(DateTime.mongoize("time")).to eq(epoch)
+      it "returns nil" do
+        expect(DateTime.mongoize("time")).to eq(nil)
       end
     end
   end

data/spec/mongoid/extensions/decimal128_spec.rb

@@ -41,4 +41,4 @@ describe Mongoid::Extensions::Decimal128 do
       end
     end
   end
-end
+end

data/spec/mongoid/extensions/float_spec.rb

@@ -23,7 +23,7 @@ describe Mongoid::Extensions::Float do
 
   describe ".demongoize" do
 
-    context "when the the value is a float" do
+    context "when the value is a float" do
 
       it "returns a float" do
         expect(Float.demongoize(number)).to eq(number)
@@ -144,4 +144,11 @@ describe Mongoid::Extensions::Float do
       expect(number.mongoize).to eq(number)
     end
   end
+
+  describe "#numeric?" do
+
+    it "returns true" do
+      expect(number.numeric?).to eq(true)
+    end
+  end
 end

data/spec/mongoid/extensions/hash_spec.rb

@@ -247,6 +247,21 @@ describe Mongoid::Extensions::Hash do
     end
   end
 
+  context "when the parent key is not present" do
+
+    let(:hash) do
+      { "101" => { "name" => "hundred and one" } }
+    end
+
+    let(:nested) do
+      hash.__nested__("100.name")
+    end
+
+    it "should return nil" do
+      expect(nested).to eq(nil)
+    end
+  end
+
   describe ".demongoize" do
 
     let(:hash) do

data/spec/mongoid/extensions/integer_spec.rb

@@ -23,7 +23,7 @@ describe Mongoid::Extensions::Integer do
 
   describe ".demongoize" do
 
-    context "when the the value is an integer" do
+    context "when the value is an integer" do
 
       it "returns a integer" do
         expect(Integer.demongoize(number)).to eq(number)
@@ -133,4 +133,11 @@ describe Mongoid::Extensions::Integer do
       expect(number.mongoize).to eq(number)
     end
   end
+
+  describe "#numeric?" do
+
+    it "returns true" do
+      expect(number.numeric?).to eq(true)
+    end
+  end
 end

data/spec/mongoid/extensions/object_spec.rb

@@ -289,4 +289,15 @@ describe Mongoid::Extensions::Object do
       end
     end
   end
+
+  describe "#numeric?" do
+
+    let(:object) do
+      Object.new
+    end
+
+    it "returns false" do
+      expect(object.numeric?).to eq(false)
+    end
+  end
 end

data/spec/mongoid/extensions/string_spec.rb

@@ -301,6 +301,27 @@ describe Mongoid::Extensions::String do
         expect("blah").to_not be_numeric
       end
     end
+
+    context "when the string is NaN" do
+
+      it "returns true" do
+        expect("NaN").to be_numeric
+      end
+    end
+
+    context "when the string is Infinity" do
+
+      it "returns true" do
+        expect("Infinity").to be_numeric
+      end
+    end
+
+    context "when the string is -Infinity" do
+
+      it "returns true" do
+        expect("-Infinity").to be_numeric
+      end
+    end
   end
 
   describe "#singularize" do

data/spec/mongoid/extensions/time_spec.rb

@@ -204,12 +204,8 @@ describe Mongoid::Extensions::Time do
 
       context "when the string is an invalid time" do
 
-        let(:epoch) do
-          Time.utc(1970, 1, 1, 0, 0, 0, 0)
-        end
-
-        it "converts the time to epoch" do
-          expect(Time.mongoize("time")).to eq(epoch)
+        it "converts the time to nil" do
+          expect(Time.mongoize("time")).to eq(nil)
         end
       end
 

data/spec/mongoid/extensions/time_with_zone_spec.rb

@@ -204,12 +204,8 @@ describe Mongoid::Extensions::TimeWithZone do
 
       context "when the string is an invalid time" do
 
-        let(:epoch) do
-          Time.utc(1970, 1, 1, 0, 0, 0)
-        end
-
-        it "returns epoch" do
-          expect(ActiveSupport::TimeWithZone.mongoize("time")).to eq(epoch)
+        it "returns nil" do
+          expect(ActiveSupport::TimeWithZone.mongoize("time")).to eq(nil)
         end
       end
 

data/spec/mongoid/findable_spec.rb

@@ -476,7 +476,7 @@ describe Mongoid::Findable do
     end
   end
 
-  Origin::Selectable.forwardables.each do |method|
+  Mongoid::Criteria::Queryable::Selectable.forwardables.each do |method|
 
     describe "##{method}" do
 
@@ -485,4 +485,49 @@ describe Mongoid::Findable do
       end
     end
   end
+
+  context 'when Mongoid is configured to use activesupport time zone' do
+
+    before do
+      Mongoid.use_utc = false
+      Mongoid.use_activesupport_time_zone = true
+      Time.zone = "Asia/Kolkata"
+    end
+
+    let!(:time) do
+      Time.zone.now.tap do |t|
+        User.create(last_login: t, name: 'Tom')
+      end
+    end
+
+    it 'uses activesupport time zone' do
+      expect(User.distinct(:last_login).first.to_s).to eql(time.in_time_zone('Asia/Kolkata').to_s)
+    end
+
+    it 'loads other fields accurately' do
+      expect(User.distinct(:name)).to match_array(['Tom'])
+    end
+  end
+
+  context 'when Mongoid is not configured to use activesupport time zone' do
+
+    before do
+      Mongoid.use_utc = true
+      Mongoid.use_activesupport_time_zone = false
+    end
+
+    let!(:time) do
+      Time.now.tap do |t|
+        User.create(last_login: t, name: 'Tom')
+      end
+    end
+
+    it 'uses utc' do
+      expect(User.distinct(:last_login).first.to_s).to eql(time.utc.to_s)
+    end
+
+    it 'loads other fields accurately' do
+      expect(User.distinct(:name)).to match_array(['Tom'])
+    end
+  end
 end

data/spec/mongoid/indexable_spec.rb

@@ -2,6 +2,10 @@ require "spec_helper"
 
 describe Mongoid::Indexable do
 
+  after do
+    Person.collection.drop
+  end
+
   describe ".included" do
 
     let(:klass) do
@@ -58,7 +62,9 @@ describe Mongoid::Indexable do
       end
 
       let(:indexes) do
-        klass.with(database: "mongoid_optional").collection.indexes
+        klass.with(database: "mongoid_optional") do |klass|
+          klass.collection.indexes
+        end
       end
 
       it "creates the indexes" do
@@ -107,7 +113,9 @@ describe Mongoid::Indexable do
       end
 
       let(:indexes) do
-        klass.with(database: "mongoid_optional").collection.indexes
+        klass.with(database: "mongoid_optional") do |klass|
+          klass.collection.indexes
+        end
       end
 
       it "creates the indexes" do
@@ -121,7 +129,7 @@ describe Mongoid::Indexable do
         Class.new do
           include Mongoid::Document
           store_in collection: "test_db_indexes"
-          index({name: 1}, {collation: {locale: 'en_US', strength: 2}})
+          index({ name: 1 }, { collation: { locale: 'en_US', strength: 2 }})
         end
       end
 
@@ -181,6 +189,10 @@ describe Mongoid::Indexable do
       end
     end
 
+    after do
+      klass.collection.drop
+    end
+
     context "when indexing a field that is aliased" do
 
       before do

data/spec/mongoid/interceptable_spec.rb

@@ -280,13 +280,18 @@ describe Mongoid::Interceptable do
       end
     end
 
-    context "callback returns false" do
+    context "callback aborts the callback chain" do
 
       before do
-        expect(artist).to receive(:before_create_stub).once.and_return(false)
+        Artist.before_create(:before_create_fail_stub)
+        expect(artist).to receive(:before_create_fail_stub).once.and_call_original
         artist.save
       end
 
+      after do
+        Artist.reset_callbacks(:create)
+      end
+
       it "does not get saved" do
         expect(artist.persisted?).to be false
       end
@@ -316,13 +321,18 @@ describe Mongoid::Interceptable do
         end
       end
 
-      context "when callback returns false" do
+      context "when callback halts the callback chain" do
 
         before do
-          expect(artist).to receive(:before_save_stub).once.and_return(false)
+          Artist.before_save(:before_save_fail_stub)
+        end
+
+        after do
+          Artist.reset_callbacks(:save)
         end
 
         it "the save returns false" do
+          expect(artist).to receive(:before_save_fail_stub).once.and_call_original
           expect(artist.save).to be false
         end
       end
@@ -343,7 +353,7 @@ describe Mongoid::Interceptable do
       context "when the callback returns true" do
 
         before do
-          expect(artist).to receive(:before_save_stub).once.and_return(true)
+          expect(artist).to receive(:before_update_stub).once.and_return(true)
         end
 
         it "the save returns true" do
@@ -351,13 +361,18 @@ describe Mongoid::Interceptable do
         end
       end
 
-      context "when the callback returns false" do
+      context "when the callback halts the callback chain" do
 
         before do
-          expect(artist).to receive(:before_save_stub).once.and_return(false)
+          Artist.before_update(:before_update_fail_stub)
+        end
+
+        after do
+          Artist.reset_callbacks(:update)
         end
 
         it "the save returns false" do
+          expect(artist).to receive(:before_update_fail_stub).once.and_call_original
           expect(artist.save).to be false
         end
       end
@@ -389,13 +404,18 @@ describe Mongoid::Interceptable do
       end
     end
 
-    context "when the callback returns false" do
+    context "when the callback halts the callback chain" do
 
       before do
-        expect(artist).to receive(:before_destroy_stub).once.and_return(false)
+        Artist.before_destroy(:before_destroy_fail_stub)
+      end
+
+      after do
+        Artist.reset_callbacks(:destroy)
       end
 
       it "the destroy returns false" do
+        expect(artist).to receive(:before_destroy_fail_stub).once.and_call_original
         expect(artist.destroy).to be false
       end
     end
@@ -1132,6 +1152,25 @@ describe Mongoid::Interceptable do
               expect(band.reload.records.first.before_validation_called).to be true
             end
           end
+
+          context 'when the parent is updated' do
+
+            let(:band) do
+              Band.create(name: "Moderat")
+            end
+
+            before do
+              band.update(records: [ { name: 'Black on Both Sides' }])
+            end
+
+            it 'executes the callback' do
+              expect(band.records.first.before_validation_called).to be true
+            end
+
+            it 'persists the change' do
+              expect(band.reload.records.first.before_validation_called).to be true
+            end
+          end
         end
 
         context "when the child is persisted" do
@@ -1434,6 +1473,25 @@ describe Mongoid::Interceptable do
         end
       end
 
+      describe '#after_destroy' do
+
+        context 'when the parent is updated in a child after_destroy callback' do
+
+          let!(:person) do
+            Person.create!(ordered_posts: [OrderedPost.new])
+          end
+
+          before do
+            post = OrderedPost.first
+            post.destroy
+          end
+
+          it 'updates the parent' do
+            expect(person.reload.title).to eq('Minus one ordered post.')
+          end
+        end
+      end
+
       describe "#before_validation" do
 
         context "when the child is new" do
@@ -1544,7 +1602,7 @@ describe Mongoid::Interceptable do
 
     before(:all) do
       Person.before_save do |doc|
-        doc.mode != :prevent_save
+        throw(:abort) if doc.mode == :prevent_save
       end
     end