mongoid 3.1.6 → 4.0.2

data/spec/mongoid/tasks/database_spec.rb

@@ -0,0 +1,160 @@
+require "spec_helper"
+
+describe "Mongoid::Tasks::Database" do
+
+  let(:logger) do
+    double("logger").tap do |log|
+      allow(log).to receive(:info)
+    end
+  end
+
+  before do
+    allow(Mongoid::Tasks::Database).to receive(:logger).and_return(logger)
+  end
+
+  let(:models) do
+    [ User, Account, Address, Draft ]
+  end
+
+  describe ".create_indexes" do
+
+    let!(:klass) do
+      User
+    end
+
+    let(:indexes) do
+      Mongoid::Tasks::Database.create_indexes(models)
+    end
+
+    context "with ordinary Rails models" do
+
+      it "creates the indexes for the models" do
+        expect(klass).to receive(:create_indexes).once
+        indexes
+      end
+    end
+
+    context "with a model without indexes" do
+
+      let(:klass) do
+        Account
+      end
+
+      it "does nothing" do
+        expect(klass).to receive(:create_indexes).never
+        indexes
+      end
+    end
+
+    context "when an exception is raised" do
+
+      it "is not swallowed" do
+        expect(klass).to receive(:create_indexes).and_raise(ArgumentError)
+        expect { indexes }.to raise_error(ArgumentError)
+      end
+    end
+
+    context "when index is defined on embedded model" do
+
+      let!(:klass) do
+        Address
+      end
+
+      before do
+        klass.index(street: 1)
+      end
+
+      it "does nothing, but logging" do
+        expect(klass).to receive(:create_indexes).never
+        indexes
+      end
+    end
+
+    context "when index is defined on self-embedded (cyclic) model" do
+
+      let(:klass) do
+        Draft
+      end
+
+      it "creates the indexes for the models" do
+        expect(klass).to receive(:create_indexes).once
+        indexes
+      end
+    end
+  end
+
+  describe ".undefined_indexes" do
+
+    before(:each) do
+      Mongoid::Tasks::Database.create_indexes(models)
+    end
+
+    let(:indexes) do
+      Mongoid::Tasks::Database.undefined_indexes(models)
+    end
+
+    it "returns the removed indexes" do
+      expect(indexes).to be_empty
+    end
+
+    context "with extra index on model collection" do
+
+      before(:each) do
+        User.collection.indexes.create(account_expires: 1)
+      end
+
+      let(:names) do
+        indexes[User].map{ |index| index['name'] }
+      end
+
+      it "should have single index returned" do
+        expect(names).to eq(['account_expires_1'])
+      end
+    end
+  end
+
+  describe ".remove_undefined_indexes" do
+
+    let(:indexes) do
+      User.collection.indexes
+    end
+
+    before(:each) do
+      Mongoid::Tasks::Database.create_indexes(models)
+      indexes.create(account_expires: 1)
+      Mongoid::Tasks::Database.remove_undefined_indexes(models)
+    end
+
+    let(:removed_indexes) do
+      Mongoid::Tasks::Database.undefined_indexes(models)
+    end
+
+    it "returns the removed indexes" do
+      expect(removed_indexes).to be_empty
+    end
+  end
+
+  describe ".remove_indexes" do
+
+    let!(:klass) do
+      User
+    end
+
+    let(:indexes) do
+      klass.collection.indexes
+    end
+
+    before :each do
+      Mongoid::Tasks::Database.create_indexes(models)
+      Mongoid::Tasks::Database.remove_indexes(models)
+    end
+
+    it "removes indexes from klass" do
+      expect(indexes.reject{ |doc| doc["name"] == "_id_" }).to be_empty
+    end
+
+    it "leaves _id index untouched" do
+      expect(indexes.select{ |doc| doc["name"] == "_id_" }).to_not be_empty
+    end
+  end
+end

data/spec/mongoid/threaded_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe Mongoid::Threaded do
 
   let(:object) do
-    stub
+    double
   end
 
   describe "#begin" do
@@ -17,7 +17,7 @@ describe Mongoid::Threaded do
     end
 
     it "adds a boolen to the load stack" do
-      described_class.stack("load").should eq([ true ])
+      expect(described_class.stack("load")).to eq([ true ])
     end
   end
 
@@ -26,7 +26,7 @@ describe Mongoid::Threaded do
     context "when loading is not set" do
 
       it "returns false" do
-        described_class.should_not be_executing(:load)
+        expect(described_class).to_not be_executing(:load)
       end
     end
 
@@ -41,7 +41,7 @@ describe Mongoid::Threaded do
       end
 
       it "returns true" do
-        described_class.should be_executing(:load)
+        expect(described_class).to be_executing(:load)
       end
     end
 
@@ -52,7 +52,7 @@ describe Mongoid::Threaded do
       end
 
       it "returns false" do
-        described_class.should_not be_executing(:load)
+        expect(described_class).to_not be_executing(:load)
       end
     end
   end
@@ -66,7 +66,7 @@ describe Mongoid::Threaded do
       end
 
       it "returns an empty stack" do
-        loading.should be_empty
+        expect(loading).to be_empty
       end
     end
 
@@ -85,7 +85,7 @@ describe Mongoid::Threaded do
       end
 
       it "returns the stack" do
-        loading.should eq([ true ])
+        expect(loading).to eq([ true ])
       end
     end
   end
@@ -102,67 +102,14 @@ describe Mongoid::Threaded do
     end
 
     it "removes a boolen from the stack" do
-      described_class.stack("load").should be_empty
-    end
-  end
-
-  describe "#clear_persistence_options" do
-
-    before do
-      described_class.set_persistence_options(Band, { safe: { w: 3 }})
-    end
-
-    let!(:cleared) do
-      described_class.clear_persistence_options(Band)
-    end
-
-    it "removes all persistence options" do
-      described_class.persistence_options(Band).should be_nil
-    end
-
-    it "returns true" do
-      cleared.should be_true
-    end
-  end
-
-  describe "#identity_map" do
-
-    before do
-      Thread.current["[mongoid]:identity-map"] = object
-    end
-
-    after do
-      Thread.current["[mongoid]:identity-map"] = nil
-    end
-
-    it "returns the object with the identity map key" do
-      described_class.identity_map.should eq(object)
-    end
-  end
-
-  describe "#persistence_options" do
-
-    before do
-      described_class.set_persistence_options(Band, { safe: { w: 3 }})
-    end
-
-    after do
-      described_class.set_persistence_options(Band, nil)
-    end
-
-    let(:options) do
-      described_class.persistence_options(Band)
-    end
-
-    it "sets the persistence options" do
-      options.should eq({ safe: { w: 3 }})
+      expect(described_class.stack("load")).to be_empty
     end
   end
 
   describe "#scope_stack" do
 
     it "returns the default with the scope stack key" do
-      described_class.scope_stack.should be_a(Hash)
+      expect(described_class.scope_stack).to be_a(Hash)
     end
   end
 
@@ -181,7 +128,7 @@ describe Mongoid::Threaded do
     end
 
     it "marks the document as being validated" do
-      described_class.validations_for(Person).should eq([ person.id ])
+      expect(described_class.validations_for(Person)).to eq([ person.id ])
     end
   end
 
@@ -197,7 +144,7 @@ describe Mongoid::Threaded do
     end
 
     it "unmarks the document as being validated" do
-      described_class.validations_for(Person).should be_empty
+      expect(described_class.validations_for(Person)).to be_empty
     end
   end
 
@@ -218,14 +165,14 @@ describe Mongoid::Threaded do
       end
 
       it "returns true" do
-        described_class.validated?(person).should be_true
+        expect(described_class.validated?(person)).to be true
       end
     end
 
     context "when the document is not validated" do
 
       it "returns false" do
-        described_class.validated?(person).should be_false
+        expect(described_class.validated?(person)).to be false
       end
     end
   end
@@ -245,7 +192,7 @@ describe Mongoid::Threaded do
     end
 
     it "marks the document as being autosaved" do
-      described_class.autosaves_for(Person).should eq([ person.id ])
+      expect(described_class.autosaves_for(Person)).to eq([ person.id ])
     end
   end
 
@@ -261,7 +208,7 @@ describe Mongoid::Threaded do
     end
 
     it "unmarks the document as being autosaved" do
-      described_class.autosaves_for(Person).should be_empty
+      expect(described_class.autosaves_for(Person)).to be_empty
     end
   end
 
@@ -282,14 +229,14 @@ describe Mongoid::Threaded do
       end
 
       it "returns true" do
-        described_class.autosaved?(person).should be_true
+        expect(described_class.autosaved?(person)).to be true
       end
     end
 
     context "when the document is not autosaved" do
 
       it "returns false" do
-        described_class.autosaved?(person).should be_false
+        expect(described_class.autosaved?(person)).to be false
       end
     end
   end

data/spec/mongoid/timestamps/created/short_spec.rb

@@ -18,19 +18,19 @@ describe Mongoid::Timestamps::Created::Short do
     end
 
     it "adds c_at to the document" do
-      fields["c_at"].should_not be_nil
+      expect(fields["c_at"]).to_not be_nil
     end
 
     it "does not add u_at to the document" do
-      fields["u_at"].should be_nil
+      expect(fields["u_at"]).to be_nil
     end
 
     it "does not add the created_at to the document" do
-      fields["created_at"].should be_nil
+      expect(fields["created_at"]).to be_nil
     end
 
     it "forces the c_at timestamps to UTC" do
-      quiz.created_at.should be_within(10).of(Time.now.utc)
+      expect(quiz.created_at).to be_within(10).of(Time.now.utc)
     end
   end
 
@@ -41,11 +41,11 @@ describe Mongoid::Timestamps::Created::Short do
     end
 
     it "runs the created callbacks" do
-      quiz.created_at.should be_within(10).of(Time.now.utc)
+      expect(quiz.created_at).to be_within(10).of(Time.now.utc)
     end
 
     it "allows access via the raw field" do
-      quiz.c_at.should eq(quiz.created_at)
+      expect(quiz.c_at).to eq(quiz.created_at)
     end
   end
 end

data/spec/mongoid/timestamps/created_spec.rb

@@ -18,15 +18,15 @@ describe Mongoid::Timestamps::Created do
     end
 
     it "adds created_at to the document" do
-      fields["created_at"].should_not be_nil
+      expect(fields["created_at"]).to_not be_nil
     end
 
     it "does not add updated_at to the document" do
-      fields["updated_at"].should be_nil
+      expect(fields["updated_at"]).to be_nil
     end
 
     it "forces the created_at timestamps to UTC" do
-      quiz.created_at.should be_within(10).of(Time.now.utc)
+      expect(quiz.created_at).to be_within(10).of(Time.now.utc)
     end
   end
 
@@ -37,8 +37,8 @@ describe Mongoid::Timestamps::Created do
     end
 
     it "runs the created callbacks" do
-      quiz.created_at.should_not be_nil
-      quiz.created_at.should be_within(10).of(Time.now.utc)
+      expect(quiz.created_at).to_not be_nil
+      expect(quiz.created_at).to be_within(10).of(Time.now.utc)
     end
   end
 end

data/spec/mongoid/timestamps/timeless_spec.rb

@@ -73,11 +73,11 @@ describe Mongoid::Timestamps::Timeless do
         end
 
         it "does not set the created timestamp" do
-          document.created_at.should be_nil
+          expect(document.created_at).to be_nil
         end
 
         it "does not set the updated timestamp" do
-          document.updated_at.should be_nil
+          expect(document.updated_at).to be_nil
         end
 
         it "clears out the timeless option after save" do
@@ -91,7 +91,7 @@ describe Mongoid::Timestamps::Timeless do
           end
 
           it "sets the updated timestamp" do
-            document.updated_at.should_not be_nil
+            expect(document.updated_at).to_not be_nil
           end
         end
       end
@@ -103,11 +103,11 @@ describe Mongoid::Timestamps::Timeless do
         end
 
         it "does not set the created timestamp" do
-          document.created_at.should be_nil
+          expect(document.created_at).to be_nil
         end
 
         it "does not set the updated timestamp" do
-          document.updated_at.should be_nil
+          expect(document.updated_at).to be_nil
         end
 
         it "clears out the timeless option after save" do
@@ -121,7 +121,7 @@ describe Mongoid::Timestamps::Timeless do
           end
 
           it "sets the updated timestamp" do
-            document.updated_at.should_not be_nil
+            expect(document.updated_at).to_not be_nil
           end
         end
       end