mongoid 3.1.6 → 4.0.2

data/spec/mongoid/relations/cyclic_spec.rb

@@ -11,15 +11,15 @@ describe Mongoid::Relations::Cyclic do
       end
 
       it "creates the parent relation" do
-        document.should respond_to(:parent_role)
+        expect(document).to respond_to(:parent_role)
       end
 
       it "creates the child relation" do
-        document.should respond_to(:child_roles)
+        expect(document).to respond_to(:child_roles)
       end
 
       it "sets cyclic to true" do
-        document.cyclic.should be_true
+        expect(document.cyclic).to be true
       end
     end
 
@@ -30,15 +30,15 @@ describe Mongoid::Relations::Cyclic do
       end
 
       it "creates the parent relation" do
-        document.should respond_to(:parent_entry)
+        expect(document).to respond_to(:parent_entry)
       end
 
       it "creates the child relation" do
-        document.should respond_to(:child_entries)
+        expect(document).to respond_to(:child_entries)
       end
 
       it "sets cyclic to true" do
-        document.cyclic.should be_true
+        expect(document.cyclic).to be true
       end
     end
 
@@ -62,15 +62,15 @@ describe Mongoid::Relations::Cyclic do
       end
 
       it "creates the parent relation" do
-        document.should respond_to(:parent_node)
+        expect(document).to respond_to(:parent_node)
       end
 
       it "creates the child relation" do
-        document.should respond_to(:child_nodes)
+        expect(document).to respond_to(:child_nodes)
       end
 
       it "sets cyclic to true" do
-        document.cyclic.should be_true
+        expect(document.cyclic).to be true
       end
     end
 
@@ -81,15 +81,15 @@ describe Mongoid::Relations::Cyclic do
       end
 
       it "creates the parent relation" do
-        document.should respond_to(:parent_apple)
+        expect(document).to respond_to(:parent_apple)
       end
 
       it "creates the child relation" do
-        document.should respond_to(:child_apples)
+        expect(document).to respond_to(:child_apples)
       end
 
       it "sets cyclic to true" do
-        document.cyclic.should be_true
+        expect(document.cyclic).to be true
       end
     end
 
@@ -100,7 +100,7 @@ describe Mongoid::Relations::Cyclic do
       end
 
       it "creates relation with cascading callbacks enabled" do
-        document.class.relations['child_pineapples'].should be_cascading_callbacks
+        expect(document.class.relations['child_pineapples']).to be_cascading_callbacks
       end
     end
   end
@@ -112,15 +112,15 @@ describe Mongoid::Relations::Cyclic do
     end
 
     it "creates the parent relation" do
-      document.should respond_to(:parent_shelf)
+      expect(document).to respond_to(:parent_shelf)
     end
 
     it "creates the child relation" do
-      document.should respond_to(:child_shelf)
+      expect(document).to respond_to(:child_shelf)
     end
 
     it "sets cyclic to true" do
-      document.cyclic.should be_true
+      expect(document.cyclic).to be true
     end
 
     context "when cascading callbacks are enabled" do
@@ -130,7 +130,7 @@ describe Mongoid::Relations::Cyclic do
       end
 
       it "creates relation with cascading callbacks enabled" do
-        document.class.relations['child_mango'].should be_cascading_callbacks
+        expect(document.class.relations['child_mango']).to be_cascading_callbacks
       end
     end
   end
@@ -150,7 +150,7 @@ describe Mongoid::Relations::Cyclic do
     end
 
     it "sets the parent node" do
-      child_one.parent_node.should eq(root)
+      expect(child_one.parent_node).to eq(root)
     end
   end
 end

data/spec/mongoid/relations/eager/belongs_to_spec.rb

@@ -0,0 +1,154 @@
+require "spec_helper"
+
+describe Mongoid::Relations::Eager::BelongsTo do
+
+  describe ".grouped_docs" do
+
+    let(:docs) do
+      Post.all.to_a
+    end
+
+    let(:person) do
+      Person.create!
+    end
+
+    let(:metadata) do
+      Post.reflect_on_association(:person)
+    end
+
+    let(:eager) do
+      described_class.new([metadata], docs).tap do |b|
+        b.shift_metadata
+      end
+    end
+
+    before do
+      Post.create!(person: person)
+    end
+
+    it "aggregates by the parent id" do
+      expect(eager.grouped_docs.keys).to eq([person.id])
+    end
+  end
+
+  describe ".set_on_parent" do
+
+    let(:docs) do
+      Post.all.to_a
+    end
+
+    let(:person) do
+      Person.create!
+    end
+
+    let(:metadata) do
+      Post.reflect_on_association(:person)
+    end
+
+    let(:eager) do
+      described_class.new([metadata], docs).tap do |b|
+        b.shift_metadata
+      end
+    end
+
+    before do
+      Post.create!(person: person)
+    end
+
+    it "sets the relation into the parent" do
+      docs.each do |doc|
+        expect(doc).to receive(:set_relation).with(:person, :foo)
+      end
+      eager.set_on_parent(person.id, :foo)
+    end
+  end
+
+  describe ".includes" do
+
+    let(:person) do
+      Person.create!
+    end
+
+    before do
+      3.times { |i| Account.create!(person: person, name: "savings#{i}") }
+    end
+
+    context "when including the belongs_to relation" do
+
+      it "queries twice" do
+
+        expect_query(2) do
+          Account.all.includes(:person).each do |account|
+            expect(account.person).to_not be_nil
+          end
+        end
+      end
+    end
+
+    context "when the relation is not polymorphic" do
+
+      let(:eager) do
+        Post.includes(:person).last
+      end
+
+      context "when the eager load has returned documents" do
+
+        let!(:post) do
+          person.posts.create(title: "testing")
+        end
+
+        before { eager }
+
+        it "puts the documents in the parent document" do
+          expect(eager.ivar(:person)).to eq(person)
+        end
+
+        it "does not query when touching the association" do
+          expect_query(0) do
+            expect(eager.person).to eq(person)
+          end
+        end
+
+        it "does not query when updating the association" do
+          expect_query(0) do
+            eager.person.username = "arthurnn"
+          end
+        end
+      end
+
+      context "when the eager load has not returned documents" do
+
+        let!(:post) do
+          Post.create(title: "testing")
+        end
+
+        before { eager }
+
+        it "does not set anything on the parent" do
+          expect(eager.ivar(:person)).to be nil
+        end
+
+        it "has a nil relation" do
+          expect(eager.person).to be nil
+        end
+      end
+    end
+
+    context "when the relation is polymorphic" do
+
+      let!(:movie) do
+        Movie.create(name: "Bladerunner")
+      end
+
+      let!(:rating) do
+        movie.ratings.create(value: 10)
+      end
+
+      it "raises an error" do
+        expect {
+          Rating.includes(:ratable).last
+        }.to raise_error(Mongoid::Errors::EagerLoad)
+      end
+    end
+  end
+end

data/spec/mongoid/relations/eager/has_and_belongs_to_many_spec.rb

@@ -0,0 +1,117 @@
+require "spec_helper"
+
+describe Mongoid::Relations::Eager::HasAndBelongsToMany do
+
+  describe ".keys_from_docs" do
+
+    let(:docs) do
+      Person.all.to_a
+    end
+
+    let!(:person) do
+      Person.create!(houses: [house])
+    end
+
+    let!(:house) do
+      House.create!
+    end
+
+    let(:metadata) do
+      Person.reflect_on_association(:houses)
+    end
+
+    let(:eager) do
+      described_class.new([metadata], docs).tap do |b|
+        b.shift_metadata
+      end
+    end
+
+    it "aggregates by the foreign key" do
+      expect(eager.keys_from_docs).to eq([house.id])
+    end
+  end
+
+  describe ".includes" do
+
+    let(:person) do
+      Person.create!
+    end
+
+    before do
+      Person.create!(houses: 3.times.map { House.create! })
+    end
+
+    context "when including the has_and_belongs_to_many relation" do
+
+      it "queries twice" do
+        expect_query(2) do
+          Person.all.includes(:houses).each do |person|
+            expect(person.houses).to_not be_nil
+
+            expect(person.houses.length).to be(3)
+          end
+        end
+      end
+
+      it "has all items" do
+        Person.all.includes(:houses).each do |person|
+          expect(person.ivar(:houses).length).to be(3)
+        end
+      end
+    end
+
+    context "when the relation is not polymorphic" do
+
+      let(:eager) do
+        Person.includes(:preferences).last
+      end
+
+      context "when the eager load has returned documents" do
+
+        let!(:preference) do
+          person.preferences.create(name: "testing")
+        end
+
+        before { eager }
+
+        it "puts the documents in the parent document" do
+          expect(eager.ivar(:preferences)).to eq([ preference ])
+        end
+
+        it "does not query when touching the association" do
+          expect_query(0) do
+            expect(eager.preferences).to eq([ preference ])
+          end
+        end
+
+        it "does not query when updating the association" do
+          expect_query(0) do
+            eager.preferences.first.name = "new pref"
+            expect(eager.preferences.first.name).to eq("new pref")
+          end
+        end
+      end
+
+      context "when the eager load has not returned documents" do
+
+        before { eager }
+
+        it "has an empty proxy" do
+          expect(eager.preferences).to eq []
+        end
+
+        it "does not query when touching the association" do
+          expect_query(0) do
+            eager.preferences.entries
+          end
+        end
+
+        it "returns the proxy" do
+          expect do
+            eager.preferences.create(name: "testing")
+          end.to_not raise_error
+        end
+      end
+    end
+  end
+end

data/spec/mongoid/relations/eager/has_many_spec.rb

@@ -0,0 +1,207 @@
+require "spec_helper"
+
+describe Mongoid::Relations::Eager::HasMany do
+
+  describe ".grouped_docs" do
+
+    let(:docs) do
+      Person.all.to_a
+    end
+
+    let(:person) do
+      Person.create!
+    end
+
+    let(:metadata) do
+      Person.reflect_on_association(:posts)
+    end
+
+    let(:eager) do
+      described_class.new([metadata], docs).tap do |b|
+        b.shift_metadata
+      end
+    end
+
+    before do
+      Post.create!(person: person)
+    end
+
+    it "aggregates by the parent primary key" do
+      expect(eager.grouped_docs.keys).to eq([person.id])
+    end
+  end
+
+  describe ".set_on_parent" do
+
+    let(:docs) do
+      Person.all.to_a
+    end
+
+    let(:person) do
+      Person.create!
+    end
+
+    let(:metadata) do
+      Person.reflect_on_association(:posts)
+    end
+
+    let(:eager) do
+      described_class.new([metadata], docs).tap do |b|
+        b.shift_metadata
+      end
+    end
+
+    before do
+      Post.create!(person: person)
+      eager
+    end
+
+    it "sets the relation into the parent" do
+      docs.each do |doc|
+        expect(doc).to receive(:__build__).once.with(:posts, :foo, metadata)
+      end
+      eager.set_on_parent(person.id, :foo)
+    end
+
+    it "doesnt call an extra query" do
+      expect_query(0) do
+        eager.set_on_parent(person.id, :foo)
+      end
+    end
+  end
+
+  describe ".includes" do
+
+    let(:person) do
+      Person.create!
+    end
+
+    context "when including the has_many relation" do
+
+      before do
+        3.times { Drug.create!(person: person) }
+        Drug.create!(person: Person.create!)
+      end
+
+      it "queries twice" do
+
+         expect_query(2) do
+          Person.all.includes(:drugs).each do |person|
+            expect(person.drugs.entries).to_not be_empty
+          end
+        end
+      end
+    end
+
+    context "when the relation is not polymorphic" do
+
+      context "when the eager load has returned documents" do
+
+        let!(:post) do
+          person.posts.create(title: "testing")
+        end
+
+        let!(:eager) do
+          Person.includes(:posts).last
+        end
+
+        it "puts the documents in the parent document" do
+          expect(eager.ivar(:posts)).to eq([post])
+        end
+
+        it "does not query when touching the association" do
+          expect_query(0) do
+            expect(eager.posts).to eq([post])
+          end
+        end
+
+        it "does not query when updating the association" do
+          expect_query(0) do
+            eager.posts.first.title = "New title"
+          end
+        end
+      end
+
+      context "when the eager load has not returned documents" do
+
+        before { person }
+
+        let!(:eager) do
+          Person.includes(:posts).last
+        end
+
+        it "does not set anything on the parent" do
+          expect(eager.ivar(:posts)).to be_empty
+        end
+
+        it "has an empty proxy" do
+          expect(eager.posts).to eq([])
+        end
+
+        it "does not query when touching the association" do
+          expect_query(0) do
+            eager.posts.entries
+          end
+        end
+
+        it "returns the proxy" do
+          expect do
+            eager.posts.create(title: "testing")
+          end.to_not raise_error
+        end
+      end
+
+      context "when the eager load has not returned documents for some" do
+
+        let!(:person_one) do
+          person
+        end
+
+        let!(:person_two) do
+          Person.create(username: "durran")
+        end
+
+        let!(:post) do
+          person_one.posts.create(title: "testing")
+        end
+
+        let!(:eager) do
+          Person.includes(:posts).asc(:username).to_a
+        end
+
+        it "puts the found documents in the parent document" do
+          expect(eager.first.ivar(:posts)).to eq([post])
+        end
+
+        it "does not set documents not found" do
+          expect(eager.last.ivar(:posts)).to be_empty
+        end
+      end
+    end
+
+    context "when the relation is polymorphic" do
+
+      let!(:movie) do
+        Movie.create(name: "Bladerunner")
+      end
+
+      let!(:rating) do
+        movie.ratings.create(value: 10)
+      end
+
+      let!(:eager) do
+        Movie.includes(:ratings).first
+      end
+
+      it "puts the found documents in the parent document" do
+        expect(eager.ivar(:ratings)).to eq([rating])
+      end
+
+      it "does not query when touching the association" do
+        expect_query(0) do
+          expect(eager.ratings).to eq([rating])
+        end
+      end
+    end
+  end
+end