mongoid 3.1.6 → 4.0.2

data/spec/mongoid/selectable_spec.rb

@@ -0,0 +1,134 @@
+require "spec_helper"
+
+describe Mongoid::Selectable do
+
+  describe "#atomic_selector" do
+
+    context "when the document is a root document" do
+
+      context "when the document has a shard key" do
+
+        let(:profile) do
+          Profile.create(name: "google")
+        end
+
+        let!(:selector) do
+          profile.atomic_selector
+        end
+
+        it "returns the id and shard key in the hash" do
+          expect(selector).to eq({ "_id" => profile.id, "name" => profile.name })
+        end
+      end
+
+      context "when the document does not have a shard key" do
+
+        context "when using object ids" do
+
+          let(:band) do
+            Band.create
+          end
+
+          let(:selector) do
+            band.atomic_selector
+          end
+
+          it "returns the hash with the id" do
+            expect(selector).to eq({ "_id" => band.id })
+          end
+        end
+
+        context "when using a custom id" do
+
+          let(:account) do
+            Account.create(name: "savings")
+          end
+
+          let(:selector) do
+            account.atomic_selector
+          end
+
+          context "when the id has not changed" do
+
+            it "returns the hash with the key" do
+              expect(selector).to eq({ "_id" => "savings" })
+            end
+          end
+
+          context "when the composite key has changed" do
+
+            before do
+              account.new_record = false
+              account.name = "current"
+            end
+
+            it "returns the hash with the old key" do
+              expect(selector).to eq({ "_id" => "savings" })
+            end
+          end
+        end
+      end
+    end
+
+    context "when the document is embedded" do
+
+      let(:person) do
+        Person.create
+      end
+
+      context "when the document is an embeds one" do
+
+        let(:name) do
+          person.create_name(first_name: "test", last_name: "user")
+        end
+
+        it "returns the hash with the selector" do
+          expect(name.atomic_selector).to eq(
+            { "_id" => person.id, "name._id" => name.id }
+          )
+        end
+      end
+
+      context "when the document is an embeds many" do
+
+        let(:address) do
+          person.addresses.create(street: "kreuzbergstr")
+        end
+
+        it "returns the hash with the selector" do
+          expect(address.atomic_selector).to eq(
+            { "_id" => person.id, "addresses._id" => address.id }
+          )
+        end
+
+        context "when the document's id changes" do
+
+          before do
+            address._id = "hobrecht"
+          end
+
+          it "returns only the parent selector" do
+            expect(address.atomic_selector).to eq(person.atomic_selector)
+          end
+        end
+
+        context "when the document is embedded multiple levels" do
+
+          let(:location) do
+            address.locations.create
+          end
+
+          it "returns a hash with the selector" do
+            expect(location.atomic_selector).to eq(
+              {
+                "_id" => person.id,
+                "addresses._id" => address.id,
+                "addresses.0.locations._id" => location.id
+              }
+            )
+          end
+        end
+      end
+    end
+  end
+end

data/spec/mongoid/{serialization_spec.rb → serializable_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Serialization do
+describe Mongoid::Serializable do
 
   describe "#field_names" do
 
@@ -9,7 +9,36 @@ describe Mongoid::Serialization do
     end
 
     it "does not duplicate fields" do
-      band.send(:field_names, {}).should eq(band.fields.except("_type").keys.sort)
+      expect(band.send(:field_names, {})).to eq(band.fields.except("_type").keys.sort)
+    end
+  end
+
+  describe ".include_root_in_json" do
+
+    let(:person) do
+      Person.new
+    end
+
+    context "when config set to true" do
+
+      before do
+        Mongoid.include_root_in_json = true
+      end
+
+      it "returns true" do
+        expect(person.include_root_in_json).to be true
+      end
+    end
+
+    context "when config set to false" do
+
+      before do
+        Mongoid.include_root_in_json = false
+      end
+
+      it "returns false" do
+        expect(person.include_root_in_json).to be false
+      end
     end
   end
 
@@ -30,7 +59,7 @@ describe Mongoid::Serialization do
       end
 
       it "grabs the attribute direct from the hash" do
-        attributes["loop"].should eq("testing")
+        expect(attributes["loop"]).to eq("testing")
       end
     end
 
@@ -45,7 +74,7 @@ describe Mongoid::Serialization do
       end
 
       it "uses the overridden method" do
-        attributes["override_me"].should eq("1")
+        expect(attributes["override_me"]).to eq("1")
       end
     end
 
@@ -62,7 +91,7 @@ describe Mongoid::Serialization do
         end
 
         it "includes the embedded documents" do
-          attributes["addresses"].first.should eq(address.serializable_hash)
+          expect(attributes["addresses"].first).to eq(address.serializable_hash)
         end
       end
 
@@ -77,11 +106,11 @@ describe Mongoid::Serialization do
         end
 
         it "uses the options" do
-          attributes["id"].should eq(person.id)
+          expect(attributes["id"]).to eq(person.id)
         end
 
         it "uses the options on embedded documents" do
-          address_attributes["id"].should eq(address.id)
+          expect(address_attributes["id"]).to eq(address.id)
         end
       end
 
@@ -96,7 +125,7 @@ describe Mongoid::Serialization do
         end
 
         it "includes the deeply nested document" do
-          attributes["addresses"][0]["locations"].should_not be_empty
+          expect(attributes["addresses"][0]["locations"]).to_not be_empty
         end
       end
     end
@@ -116,7 +145,7 @@ describe Mongoid::Serialization do
       end
 
       it "converts the objects to the defined type" do
-        attributes["dob"].should eq(date)
+        expect(attributes["dob"]).to eq(date)
       end
     end
 
@@ -127,7 +156,7 @@ describe Mongoid::Serialization do
       end
 
       before do
-        person.write_attributes(attributes, false)
+        person.write_attributes(attributes)
       end
 
       let(:field_names) do
@@ -135,15 +164,15 @@ describe Mongoid::Serialization do
       end
 
       it "serializes assigned attributes" do
-        person.serializable_hash.should include attributes
+        expect(person.serializable_hash).to include attributes
       end
 
       it "includes all defined fields except _type" do
-        person.serializable_hash.keys.should include(*field_names)
+        expect(person.serializable_hash.keys).to include(*field_names)
       end
 
       it "does not include _type" do
-        person.serializable_hash.keys.should_not include "_type"
+        expect(person.serializable_hash.keys).to_not include "_type"
       end
 
       context "when providing options" do
@@ -157,7 +186,7 @@ describe Mongoid::Serialization do
         end
 
         it "does not modify the options in the argument" do
-          options[:except].should be_nil
+          expect(options[:except]).to be_nil
         end
       end
 
@@ -172,14 +201,14 @@ describe Mongoid::Serialization do
         end
 
         it "includes _type field" do
-          person.serializable_hash.keys.should include '_type'
+          expect(person.serializable_hash.keys).to include '_type'
         end
       end
 
       context "when specifying which fields to only include" do
 
         it "only includes the specified fields" do
-          person.serializable_hash(only: [:title]).should eq(
+          expect(person.serializable_hash(only: [:title])).to eq(
             { "title" => attributes["title"] }
           )
         end
@@ -188,20 +217,38 @@ describe Mongoid::Serialization do
       context "when specifying extra inclusions" do
 
         it "includes the extra fields" do
-          person.serializable_hash(
+          expect(person.serializable_hash(
             methods: [ :_type ]
-          ).has_key?("_type").should be_true
+          ).has_key?("_type")).to be true
         end
       end
 
       context "when specifying which fields to exclude" do
 
         it "excludes the specified fields" do
-          person.serializable_hash(except: [:title]).should_not include(
+          expect(person.serializable_hash(except: [:title])).to_not include(
             "title" => attributes["title"]
           )
         end
       end
+
+      context "when only two attributes are loaded" do
+        before do
+          person.save
+        end
+
+        let(:from_db) do
+          Person.only("_id", "username").first
+        end
+
+        let(:hash) do
+          from_db.serializable_hash
+        end
+
+        it "returns those two attributes only" do
+          expect(hash.keys).to eq(["_id", "username"])
+        end
+      end
     end
 
     context "when a model has dynamic fields" do
@@ -219,13 +266,13 @@ describe Mongoid::Serialization do
       end
 
       it "includes dynamic fields" do
-        person.serializable_hash[dynamic_field_name].should eq(dynamic_value)
+        expect(person.serializable_hash[dynamic_field_name]).to eq(dynamic_value)
       end
 
       context "when specifying which dynamic fields to only include" do
 
         it "only includes the specified dynamic fields" do
-          person.serializable_hash(only: [dynamic_field_name]).should eq(
+          expect(person.serializable_hash(only: [dynamic_field_name])).to eq(
             { dynamic_field_name => dynamic_value }
           )
         end
@@ -234,7 +281,7 @@ describe Mongoid::Serialization do
       context "when specified which dynamic fields to exclude" do
 
         it "excludes the specified fields" do
-          person.serializable_hash(except: [dynamic_field_name]).should_not include(
+          expect(person.serializable_hash(except: [dynamic_field_name])).to_not include(
             dynamic_field_name => dynamic_value
           )
         end
@@ -248,7 +295,7 @@ describe Mongoid::Serialization do
       end
 
       before do
-        person.write_attributes(attributes, false)
+        person.write_attributes(attributes)
       end
 
       context "when the model is saved before the relation is added" do
@@ -268,7 +315,7 @@ describe Mongoid::Serialization do
           end
 
           it "includes the relation" do
-            person.serializable_hash.keys.should include('addresses')
+            expect(person.serializable_hash.keys).to include('addresses')
           end
         end
 
@@ -282,7 +329,7 @@ describe Mongoid::Serialization do
           end
 
           it "includes the relation" do
-            person.serializable_hash.keys.should include('name')
+            expect(person.serializable_hash.keys).to include('name')
           end
         end
       end
@@ -300,7 +347,7 @@ describe Mongoid::Serialization do
           end
 
           it "includes the relation" do
-            person.serializable_hash.keys.should include('addresses')
+            expect(person.serializable_hash.keys).to include('addresses')
           end
         end
 
@@ -314,7 +361,7 @@ describe Mongoid::Serialization do
           end
 
           it "includes the relation" do
-            person.serializable_hash.keys.should include('name')
+            expect(person.serializable_hash.keys).to include('name')
           end
         end
       end
@@ -323,7 +370,7 @@ describe Mongoid::Serialization do
     context "when including methods" do
 
       it "includes the method result" do
-        person.serializable_hash(methods: [:foo]).should include(
+        expect(person.serializable_hash(methods: [:foo])).to include(
           "foo" => person.foo
         )
       end
@@ -362,7 +409,7 @@ describe Mongoid::Serialization do
             end
 
             it "does not generate new ids" do
-              hash["addresses"].first["_id"].should be_nil
+              expect(hash["addresses"].first["_id"]).to be_nil
             end
           end
 
@@ -373,12 +420,12 @@ describe Mongoid::Serialization do
             end
 
             it "includes the first relation" do
-              relation_hash[0].should include
+              expect(relation_hash[0]).to include
                 { "_id" => "kudamm", "street" => "Kudamm" }
             end
 
             it "includes the second relation" do
-              relation_hash[1].should include
+              expect(relation_hash[1]).to include
                 { "_id" => "tauentzienstr", "street" => "Tauentzienstr" }
             end
           end
@@ -390,12 +437,12 @@ describe Mongoid::Serialization do
             end
 
             it "includes the first relation" do
-              relation_hash[0].should include
+              expect(relation_hash[0]).to include
                 { "_id" => "kudamm", "street" => "Kudamm" }
             end
 
             it "includes the second relation" do
-              relation_hash[1].should include
+              expect(relation_hash[1]).to include
                 { "_id" => "tauentzienstr", "street" => "Tauentzienstr" }
             end
           end
@@ -409,11 +456,11 @@ describe Mongoid::Serialization do
               end
 
               it "includes the first relation sans exceptions" do
-                relation_hash[0].should include({ "street" => "Kudamm" })
+                expect(relation_hash[0]).to include({ "street" => "Kudamm" })
               end
 
               it "includes the second relation sans exceptions" do
-                relation_hash[1].should include({ "street" => "Tauentzienstr" })
+                expect(relation_hash[1]).to include({ "street" => "Tauentzienstr" })
               end
             end
 
@@ -432,9 +479,9 @@ describe Mongoid::Serialization do
               end
 
               it "includes the first relation" do
-                relation_hash[0]["locations"].any? do |location|
+                expect(relation_hash[0]["locations"].any? do |location|
                   location["name"] == "Home"
-                end.should be_true
+                end).to be true
               end
 
               context "after retrieved from database" do
@@ -460,12 +507,12 @@ describe Mongoid::Serialization do
                 end
 
                 it "includes the specific ralations" do
-                  relation_hash[0]["locations"].map do |location|
+                  expect(relation_hash[0]["locations"].map do |location|
                     location["name"]
-                  end.should include "Home"
-                  relation_hash[1]["locations"].map do |location|
+                  end).to include "Home"
+                  expect(relation_hash[1]["locations"].map do |location|
                     location["name"]
-                  end.should include "Hotel"
+                  end).to include "Hotel"
                 end
               end
             end
@@ -484,15 +531,15 @@ describe Mongoid::Serialization do
               end
 
               it "does not contain the root exclusion" do
-                hash["_id"].should be_nil
+                expect(hash["_id"]).to be_nil
               end
 
               it "does not include the embedded many exclusion" do
-                relation_hash[0]["_id"].should be_nil
+                expect(relation_hash[0]["_id"]).to be_nil
               end
 
               it "does not include the embedded one exclusion" do
-                hash["name"]["_id"].should be_nil
+                expect(hash["name"]["_id"]).to be_nil
               end
             end
           end
@@ -515,7 +562,7 @@ describe Mongoid::Serialization do
             end
 
             it "includes the specified relation" do
-              relation_hash.should include
+              expect(relation_hash).to include
                 { "_id" => "leo-marvin", "first_name" => "Leo", "last_name" => "Marvin" }
             end
           end
@@ -527,7 +574,7 @@ describe Mongoid::Serialization do
             end
 
             it "includes the specified relation" do
-              relation_hash.should include
+              expect(relation_hash).to include
                 { "_id" => "leo-marvin", "first_name" => "Leo", "last_name" => "Marvin" }
             end
           end
@@ -539,7 +586,7 @@ describe Mongoid::Serialization do
             end
 
             it "includes the specified relation sans exceptions" do
-              relation_hash.should include
+              expect(relation_hash).to include
                 { "first_name" => "Leo", "last_name" => "Marvin" }
             end
           end
@@ -566,15 +613,15 @@ describe Mongoid::Serialization do
             end
 
             it "includes the specified relation" do
-              relation_hash.should_not be_nil
+              expect(relation_hash).to_not be_nil
             end
 
             it "includes the first document related fields" do
-              relation_hash[0]["title"].should eq("First")
+              expect(relation_hash[0]["title"]).to eq("First")
             end
 
             it "includes the second document related fields" do
-              relation_hash[1]["title"].should eq("Second")
+              expect(relation_hash[1]["title"]).to eq("Second")
             end
           end
 
@@ -585,15 +632,15 @@ describe Mongoid::Serialization do
             end
 
             it "includes the specified relation" do
-              relation_hash.should_not be_nil
+              expect(relation_hash).to_not be_nil
             end
 
             it "includes the first document related fields" do
-              relation_hash[0]["title"].should eq("First")
+              expect(relation_hash[0]["title"]).to eq("First")
             end
 
             it "includes the second document related fields" do
-              relation_hash[1]["title"].should eq("Second")
+              expect(relation_hash[1]["title"]).to eq("Second")
             end
           end
 
@@ -604,23 +651,23 @@ describe Mongoid::Serialization do
             end
 
             it "includes the specified relation" do
-              relation_hash.should_not be_nil
+              expect(relation_hash).to_not be_nil
             end
 
             it "includes the first document related fields" do
-              relation_hash[0]["title"].should eq("First")
+              expect(relation_hash[0]["title"]).to eq("First")
             end
 
             it "includes the second document related fields" do
-              relation_hash[1]["title"].should eq("Second")
+              expect(relation_hash[1]["title"]).to eq("Second")
             end
 
             it "does not include the first document exceptions" do
-              relation_hash[0]["_id"].should be_nil
+              expect(relation_hash[0]["_id"]).to be_nil
             end
 
             it "does not include the second document exceptions" do
-              relation_hash[1]["_id"].should be_nil
+              expect(relation_hash[1]["_id"]).to be_nil
             end
           end
         end
@@ -646,15 +693,15 @@ describe Mongoid::Serialization do
             end
 
             it "includes the specified relation" do
-              relation_hash.should_not be_nil
+              expect(relation_hash).to_not be_nil
             end
 
             it "includes the first document related fields" do
-              relation_hash[0]["name"].should eq("First")
+              expect(relation_hash[0]["name"]).to eq("First")
             end
 
             it "includes the second document related fields" do
-              relation_hash[1]["name"].should eq("Second")
+              expect(relation_hash[1]["name"]).to eq("Second")
             end
           end
 
@@ -665,15 +712,15 @@ describe Mongoid::Serialization do
             end
 
             it "includes the specified relation" do
-              relation_hash.should_not be_nil
+              expect(relation_hash).to_not be_nil
             end
 
             it "includes the first document related fields" do
-              relation_hash[0]["name"].should eq("First")
+              expect(relation_hash[0]["name"]).to eq("First")
             end
 
             it "includes the second document related fields" do
-              relation_hash[1]["name"].should eq("Second")
+              expect(relation_hash[1]["name"]).to eq("Second")
             end
           end
 
@@ -691,27 +738,27 @@ describe Mongoid::Serialization do
             end
 
             it "includes the specified relation" do
-              relation_hash.should_not be_nil
+              expect(relation_hash).to_not be_nil
             end
 
             it "includes the first document related fields" do
-              relation_hash[0]["name"].should eq("First")
+              expect(relation_hash[0]["name"]).to eq("First")
             end
 
             it "includes the second document related fields" do
-              relation_hash[1]["name"].should eq("Second")
+              expect(relation_hash[1]["name"]).to eq("Second")
             end
 
             it "does not include the first document exceptions" do
-              relation_hash[0]["_id"].should be_nil
+              expect(relation_hash[0]["_id"]).to be_nil
             end
 
             it "does not include the second document exceptions" do
-              relation_hash[1]["_id"].should be_nil
+              expect(relation_hash[1]["_id"]).to be_nil
             end
 
             it "does not include the root exceptions" do
-              hash["preference_ids"].should be_nil
+              expect(hash["preference_ids"]).to be_nil
             end
           end
         end
@@ -732,7 +779,7 @@ describe Mongoid::Serialization do
       end
 
       it "uses the mongoid configuration" do
-        person.to_json.should include("person")
+        expect(person.to_json).to include("person")
       end
     end
 
@@ -743,7 +790,7 @@ describe Mongoid::Serialization do
       end
 
       it "uses the mongoid configuration" do
-        person.to_json.should_not include("person")
+        expect(person.to_json).to_not include("person")
       end
     end
 
@@ -760,7 +807,7 @@ describe Mongoid::Serialization do
         end
 
         it "serializes only the relation" do
-          json.should include(address.street)
+          expect(json).to include(address.street)
         end
       end
 
@@ -775,7 +822,7 @@ describe Mongoid::Serialization do
         end
 
         it "serializes only the relation" do
-          json.should include(post.title)
+          expect(json).to include(post.title)
         end
       end
     end
@@ -783,14 +830,14 @@ describe Mongoid::Serialization do
 
   describe "#to_xml" do
 
-    context "Moped::BSON::ObjectId" do
+    context "BSON::ObjectId" do
 
       let(:person) do
         Person.new
       end
 
       it "serializes as string" do
-        person.to_xml.should include("<_id>#{person.id}</_id>")
+        expect(person.to_xml).to include("<_id>#{person.id}</_id>")
       end
     end
 
@@ -803,12 +850,12 @@ describe Mongoid::Serialization do
       end
 
       it "properly types the array" do
-        person.to_xml.should include("<aliases type=\"array\">")
+        expect(person.to_xml).to include("<aliases type=\"array\">")
       end
 
       it "serializes the array" do
-        person.to_xml.should include("<alias>Kelly</alias>")
-        person.to_xml.should include("<alias>Machine Gun</alias>")
+        expect(person.to_xml).to include("<alias>Kelly</alias>")
+        expect(person.to_xml).to include("<alias>Machine Gun</alias>")
       end
     end
 
@@ -821,12 +868,12 @@ describe Mongoid::Serialization do
       end
 
       it "properly types the hash" do
-        person.to_xml.should include("<map>")
+        expect(person.to_xml).to include("<map>")
       end
 
       it "serializes the hash" do
-        person.to_xml.should include("<lat type=\"float\">24.5</lat>")
-        person.to_xml.should include("<long type=\"float\">22.1</long>")
+        expect(person.to_xml).to include("<lat type=\"float\">24.5</lat>")
+        expect(person.to_xml).to include("<long type=\"float\">22.1</long>")
       end
     end
   end