mongoid 3.1.5 → 8.0.2

data/spec/mongoid/fields/foreign_key_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Fields::ForeignKey do
@@ -7,7 +9,7 @@ describe Mongoid::Fields::ForeignKey do
     let(:field) do
       described_class.new(
         :vals,
-        metadata: Person.relations["preferences"],
+        association: Person.relations["preferences"],
         type: Array,
         default: [],
         identity: true
@@ -52,7 +54,7 @@ describe Mongoid::Fields::ForeignKey do
       end
 
       it "adds the current to the modifications" do
-        mods["preference_ids"].should eq(
+        expect(mods["preference_ids"]).to eq(
           [ preference_one.id, preference_three.id ]
         )
       end
@@ -62,13 +64,13 @@ describe Mongoid::Fields::ForeignKey do
   describe "#eval_default" do
 
     let(:default) do
-      [ Moped::BSON::ObjectId.new ]
+      [ BSON::ObjectId.new ]
     end
 
     let(:field) do
       described_class.new(
         :vals,
-        metadata: Person.relations["posts"],
+        association: Person.relations["posts"],
         type: Array,
         default: default,
         identity: true
@@ -76,11 +78,11 @@ describe Mongoid::Fields::ForeignKey do
     end
 
     it "dups the default value" do
-      field.eval_default(Person.new).should_not equal(default)
+      expect(field.eval_default(Person.new)).to_not equal(default)
     end
 
     it "returns the correct value" do
-      field.eval_default(Person.new).should eq(default)
+      expect(field.eval_default(Person.new)).to eq(default)
     end
   end
 
@@ -89,7 +91,7 @@ describe Mongoid::Fields::ForeignKey do
     let(:field) do
       described_class.new(
         :vals,
-        metadata: Person.relations["posts"],
+        association: Person.relations["posts"],
         type: Array,
         default: [],
         identity: true
@@ -97,20 +99,20 @@ describe Mongoid::Fields::ForeignKey do
     end
 
     it "returns true" do
-      field.should be_foreign_key
+      expect(field).to be_foreign_key
     end
   end
 
   describe "#evolve" do
 
-    let(:metadata) do
+    let(:association) do
       Person.reflect_on_association(:preferences)
     end
 
     context "when provided a document" do
 
       let(:field) do
-        described_class.new(:person_id, type: Object, metadata: metadata)
+        described_class.new(:person_id, type: Object, association: association)
       end
 
       let(:game) do
@@ -122,14 +124,14 @@ describe Mongoid::Fields::ForeignKey do
       end
 
       it "returns the id for the document" do
-        evolved.should eq(game.id)
+        expect(evolved).to eq(game.id)
       end
     end
 
     context "when the type is an array" do
 
       let(:field) do
-        described_class.new(:preference_ids, type: Array, default: [], metadata: metadata)
+        described_class.new(:preference_ids, type: Array, default: [], association: association)
       end
 
       context "when providing a single value" do
@@ -137,7 +139,7 @@ describe Mongoid::Fields::ForeignKey do
         context "when the value is an id string" do
 
           let(:id) do
-            Moped::BSON::ObjectId.new
+            BSON::ObjectId.new
           end
 
           let(:evolved) do
@@ -145,7 +147,7 @@ describe Mongoid::Fields::ForeignKey do
           end
 
           it "converts the value to an object id" do
-            evolved.should eq(id)
+            expect(evolved).to eq(id)
           end
         end
 
@@ -156,7 +158,7 @@ describe Mongoid::Fields::ForeignKey do
           end
 
           it "does not convert the value" do
-            evolved.should eq("testing")
+            expect(evolved).to eq("testing")
           end
         end
 
@@ -167,7 +169,7 @@ describe Mongoid::Fields::ForeignKey do
           end
 
           it "does not convert the value" do
-            evolved.should be_empty
+            expect(evolved).to be_empty
           end
         end
       end
@@ -179,11 +181,11 @@ describe Mongoid::Fields::ForeignKey do
           context "when the relation stores ids as object ids" do
 
             let(:id_one) do
-              Moped::BSON::ObjectId.new
+              BSON::ObjectId.new
             end
 
             let(:id_two) do
-              Moped::BSON::ObjectId.new
+              BSON::ObjectId.new
             end
 
             let(:evolved) do
@@ -191,26 +193,26 @@ describe Mongoid::Fields::ForeignKey do
             end
 
             it "converts the value to an object id" do
-              evolved.should eq([ id_one, id_two ])
+              expect(evolved).to eq([ id_one, id_two ])
             end
           end
 
           context "when the relation stores ids as strings" do
 
-            let!(:metadata) do
+            let!(:association) do
               Agent.reflect_on_association(:accounts)
             end
 
             let!(:field) do
-              described_class.new(:account_ids, type: Array, default: [], metadata: metadata)
+              described_class.new(:account_ids, type: Array, default: [], association: association)
             end
 
             let(:id_one) do
-              Moped::BSON::ObjectId.new.to_s
+              BSON::ObjectId.new.to_s
             end
 
             let(:id_two) do
-              Moped::BSON::ObjectId.new.to_s
+              BSON::ObjectId.new.to_s
             end
 
             let(:evolved) do
@@ -218,7 +220,7 @@ describe Mongoid::Fields::ForeignKey do
             end
 
             it "does not convert the values to object ids" do
-              evolved.should eq([ id_one, id_two ])
+              expect(evolved).to eq([ id_one, id_two ])
             end
           end
         end
@@ -230,7 +232,7 @@ describe Mongoid::Fields::ForeignKey do
           end
 
           it "does not convert the value" do
-            evolved.should eq([ "testing" ])
+            expect(evolved).to eq([ "testing" ])
           end
         end
 
@@ -241,7 +243,7 @@ describe Mongoid::Fields::ForeignKey do
           end
 
           it "does not convert the value" do
-            evolved.should eq([ "" ])
+            expect(evolved).to eq([ "" ])
           end
         end
 
@@ -252,7 +254,7 @@ describe Mongoid::Fields::ForeignKey do
           end
 
           it "does not convert the value" do
-            evolved.should eq([ nil ])
+            expect(evolved).to eq([ nil ])
           end
         end
       end
@@ -260,12 +262,12 @@ describe Mongoid::Fields::ForeignKey do
 
     context "when the type is an object" do
 
-      let(:metadata) do
+      let(:association) do
         Game.reflect_on_association(:person)
       end
 
       let(:field) do
-        described_class.new(:person_id, type: Object, metadata: metadata)
+        described_class.new(:person_id, type: Object, association: association)
       end
 
       context "when providing a single value" do
@@ -275,7 +277,7 @@ describe Mongoid::Fields::ForeignKey do
           context "when the value is an id string" do
 
             let(:id) do
-              Moped::BSON::ObjectId.new
+              BSON::ObjectId.new
             end
 
             let(:evolved) do
@@ -283,7 +285,7 @@ describe Mongoid::Fields::ForeignKey do
             end
 
             it "converts the value to an object id" do
-              evolved.should eq(id)
+              expect(evolved).to eq(id)
             end
           end
 
@@ -294,7 +296,7 @@ describe Mongoid::Fields::ForeignKey do
             end
 
             it "does not convert the value" do
-              evolved.should eq("testing")
+              expect(evolved).to eq("testing")
             end
           end
 
@@ -305,25 +307,25 @@ describe Mongoid::Fields::ForeignKey do
             end
 
             it "does not convert the value" do
-              evolved.should be_empty
+              expect(evolved).to be_empty
             end
           end
         end
 
         context "when the relation stores string ids" do
 
-          let(:metadata) do
+          let(:association) do
             Comment.reflect_on_association(:account)
           end
 
           let(:field) do
-            described_class.new(:person_id, type: Object, metadata: metadata)
+            described_class.new(:person_id, type: Object, association: association)
           end
 
           context "when the value is an id string" do
 
             let(:id) do
-              Moped::BSON::ObjectId.new
+              BSON::ObjectId.new
             end
 
             let(:evolved) do
@@ -331,7 +333,7 @@ describe Mongoid::Fields::ForeignKey do
             end
 
             it "does not convert the value to an object id" do
-              evolved.should eq(id.to_s)
+              expect(evolved).to eq(id.to_s)
             end
           end
 
@@ -342,7 +344,7 @@ describe Mongoid::Fields::ForeignKey do
             end
 
             it "does not convert the value" do
-              evolved.should eq("testing")
+              expect(evolved).to eq("testing")
             end
           end
 
@@ -353,7 +355,7 @@ describe Mongoid::Fields::ForeignKey do
             end
 
             it "does not convert the value" do
-              evolved.should be_empty
+              expect(evolved).to be_empty
             end
           end
         end
@@ -366,11 +368,11 @@ describe Mongoid::Fields::ForeignKey do
           context "when the relation stores ids as object ids" do
 
             let(:id_one) do
-              Moped::BSON::ObjectId.new
+              BSON::ObjectId.new
             end
 
             let(:id_two) do
-              Moped::BSON::ObjectId.new
+              BSON::ObjectId.new
             end
 
             let(:evolved) do
@@ -378,26 +380,26 @@ describe Mongoid::Fields::ForeignKey do
             end
 
             it "converts the value to an object id" do
-              evolved.should eq([ id_one, id_two ])
+              expect(evolved).to eq([ id_one, id_two ])
             end
           end
 
           context "when the relation stores ids as strings" do
 
-            let(:metadata) do
+            let(:association) do
               Comment.reflect_on_association(:account)
             end
 
             let(:field) do
-              described_class.new(:person_id, type: Object, metadata: metadata)
+              described_class.new(:person_id, type: Object, association: association)
             end
 
             let(:id_one) do
-              Moped::BSON::ObjectId.new.to_s
+              BSON::ObjectId.new.to_s
             end
 
             let(:id_two) do
-              Moped::BSON::ObjectId.new.to_s
+              BSON::ObjectId.new.to_s
             end
 
             let(:evolved) do
@@ -405,7 +407,7 @@ describe Mongoid::Fields::ForeignKey do
             end
 
             it "does not convert the values to object ids" do
-              evolved.should eq([ id_one, id_two ])
+              expect(evolved).to eq([ id_one, id_two ])
             end
           end
         end
@@ -417,7 +419,7 @@ describe Mongoid::Fields::ForeignKey do
           end
 
           it "does not convert the value" do
-            evolved.should eq([ "testing" ])
+            expect(evolved).to eq([ "testing" ])
           end
         end
 
@@ -428,7 +430,7 @@ describe Mongoid::Fields::ForeignKey do
           end
 
           it "does not convert the value" do
-            evolved.should eq([ "" ])
+            expect(evolved).to eq([ "" ])
           end
         end
 
@@ -439,11 +441,34 @@ describe Mongoid::Fields::ForeignKey do
           end
 
           it "does not convert the value" do
-            evolved.should eq([ nil ])
+            expect(evolved).to eq([ nil ])
           end
         end
       end
     end
+
+    context "when the association is polymoprhic" do
+
+      let(:association) do
+        Agent.reflect_on_association(:names)
+      end
+
+      let(:field) do
+        described_class.new(:nameable_id, type: Object, association: association)
+      end
+
+      let(:value) do
+        BSON::ObjectId.new().to_s
+      end
+
+      let(:evolved) do
+        field.evolve(value)
+      end
+
+      it "does not change the foreign key" do
+        expect(evolved).to eq(BSON::ObjectId.from_string(value))
+      end
+    end
   end
 
   describe "#lazy?" do
@@ -451,22 +476,22 @@ describe Mongoid::Fields::ForeignKey do
     context "when the key is resizable" do
 
       let(:field) do
-        described_class.new(:test, type: Array)
+        described_class.new(:test, type: Array, overwrite: true)
       end
 
       it "returns true" do
-        field.should be_lazy
+        expect(field).to be_lazy
       end
     end
 
     context "when the key is not resizable" do
 
       let(:field) do
-        described_class.new(:test, type: Moped::BSON::ObjectId)
+        described_class.new(:test, type: BSON::ObjectId, overwrite: true)
       end
 
       it "returns false" do
-        field.should_not be_lazy
+        expect(field).to_not be_lazy
       end
     end
   end
@@ -477,12 +502,8 @@ describe Mongoid::Fields::ForeignKey do
 
       context "when the array is object ids" do
 
-        let(:metadata) do
-          Mongoid::Relations::Metadata.new(
-            inverse_class_name: "Game",
-            name: :person,
-            relation: Mongoid::Relations::Referenced::In
-          )
+        let(:association) do
+          Game.relations["person"]
         end
 
         let(:field) do
@@ -491,14 +512,15 @@ describe Mongoid::Fields::ForeignKey do
             type: Array,
             default: [],
             identity: true,
-            metadata: metadata
+            association: association,
+            overwrite: true
           )
         end
 
         context "when provided nil" do
 
           it "returns an empty array" do
-            field.mongoize(nil).should be_empty
+            expect(field.mongoize(nil)).to be_empty
           end
         end
 
@@ -509,29 +531,29 @@ describe Mongoid::Fields::ForeignKey do
           end
 
           it "returns an empty array" do
-            field.mongoize(array).should eq(array)
+            expect(field.mongoize(array)).to eq(array)
           end
 
           it "returns the same instance" do
-            field.mongoize(array).should equal(array)
+            expect(field.mongoize(array)).to equal(array)
           end
         end
 
         context "when using object ids" do
 
           let(:object_id) do
-            Moped::BSON::ObjectId.new
+            BSON::ObjectId.new
           end
 
           it "performs conversion on the ids if strings" do
-            field.mongoize([object_id.to_s]).should eq([object_id])
+            expect(field.mongoize([object_id.to_s])).to eq([object_id])
           end
         end
 
         context "when not using object ids" do
 
           let(:object_id) do
-            Moped::BSON::ObjectId.new
+            BSON::ObjectId.new
           end
 
           before do
@@ -539,21 +561,23 @@ describe Mongoid::Fields::ForeignKey do
               :_id,
               type: String,
               pre_processed: true,
-              default: ->{ Moped::BSON::ObjectId.new.to_s }
+              default: ->{ BSON::ObjectId.new.to_s },
+              overwrite: true
             )
           end
 
           after do
             Person.field(
               :_id,
-              type: Moped::BSON::ObjectId,
+              type: BSON::ObjectId,
               pre_processed: true,
-              default: ->{ Moped::BSON::ObjectId.new }
+              default: ->{ BSON::ObjectId.new },
+              overwrite: true
             )
           end
 
           it "does not convert" do
-            field.mongoize([object_id.to_s]).should eq([object_id.to_s])
+            expect(field.mongoize([object_id.to_s])).to eq([object_id.to_s])
           end
         end
       end
@@ -563,12 +587,8 @@ describe Mongoid::Fields::ForeignKey do
 
       context "when the array is object ids" do
 
-        let(:metadata) do
-          Mongoid::Relations::Metadata.new(
-            inverse_class_name: "Game",
-            name: :person,
-            relation: Mongoid::Relations::Referenced::In
-          )
+        let(:association) do
+          Game.relations['person']
         end
 
         let(:field) do
@@ -577,18 +597,19 @@ describe Mongoid::Fields::ForeignKey do
             type: Object,
             default: nil,
             identity: true,
-            metadata: metadata
+            association: association,
+            overwrite: true
           )
         end
 
         context "when using object ids" do
 
           let(:object_id) do
-            Moped::BSON::ObjectId.new
+            BSON::ObjectId.new
           end
 
           it "performs conversion on the ids if strings" do
-            field.mongoize(object_id.to_s).should eq(object_id)
+            expect(field.mongoize(object_id.to_s)).to eq(object_id)
           end
         end
 
@@ -599,7 +620,7 @@ describe Mongoid::Fields::ForeignKey do
             context "when provided a string" do
 
               let(:object_id) do
-                Moped::BSON::ObjectId.new
+                BSON::ObjectId.new
               end
 
               before do
@@ -607,21 +628,23 @@ describe Mongoid::Fields::ForeignKey do
                   :_id,
                   type: String,
                   pre_processed: true,
-                  default: ->{ Moped::BSON::ObjectId.new.to_s }
+                  default: ->{ BSON::ObjectId.new.to_s },
+                  overwrite: true
                 )
               end
 
               after do
                 Person.field(
                   :_id,
-                  type: Moped::BSON::ObjectId,
+                  type: BSON::ObjectId,
                   pre_processed: true,
-                  default: ->{ Moped::BSON::ObjectId.new }
+                  default: ->{ BSON::ObjectId.new },
+                  overwrite: true
                 )
               end
 
               it "does not convert" do
-                field.mongoize(object_id.to_s).should eq(object_id.to_s)
+                expect(field.mongoize(object_id.to_s)).to eq(object_id.to_s)
               end
             end
           end
@@ -631,20 +654,21 @@ describe Mongoid::Fields::ForeignKey do
             context "when provided a string" do
 
               before do
-                Person.field(:_id, type: Integer)
+                Person.field(:_id, type: Integer, overwrite: true)
               end
 
               after do
                 Person.field(
                   :_id,
-                  type: Moped::BSON::ObjectId,
+                  type: BSON::ObjectId,
                   pre_processed: true,
-                  default: ->{ Moped::BSON::ObjectId.new }
+                  default: ->{ BSON::ObjectId.new },
+                  overwrite: true
                 )
               end
 
               it "converts the string to an integer" do
-                field.mongoize("1").should eq(1)
+                expect(field.mongoize("1")).to eq(1)
               end
             end
           end
@@ -662,7 +686,7 @@ describe Mongoid::Fields::ForeignKey do
       end
 
       it "returns true" do
-        field.should be_resizable
+        expect(field).to be_resizable
       end
     end
 
@@ -673,7 +697,7 @@ describe Mongoid::Fields::ForeignKey do
       end
 
       it "returns false" do
-        field.should_not be_resizable
+        expect(field).to_not be_resizable
       end
     end
   end
@@ -687,7 +711,7 @@ describe Mongoid::Fields::ForeignKey do
       end
 
       it "casts the ids on the initial set" do
-        agent.account_ids.should eq([ "true", "false", "1", "2" ])
+        expect(agent.account_ids).to eq([ "true", "false", "1", "2" ])
       end
     end
   end