mongoid 3.1.5 → 8.0.2

data/spec/mongoid/extensions/array_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Array do
@@ -7,7 +9,7 @@ describe Mongoid::Extensions::Array do
     context "when provided an array of strings" do
 
       let(:object_id) do
-        Moped::BSON::ObjectId.new
+        BSON::ObjectId.new
       end
 
       let(:other) do
@@ -23,18 +25,18 @@ describe Mongoid::Extensions::Array do
       end
 
       it "converts the convertible ones to object ids" do
-        evolved.should eq([ object_id, other ])
+        expect(evolved).to eq([ object_id, other ])
       end
 
       it "returns the same instance" do
-        evolved.should equal(array)
+        expect(evolved).to equal(array)
       end
     end
 
     context "when provided an array of object ids" do
 
       let(:object_id) do
-        Moped::BSON::ObjectId.new
+        BSON::ObjectId.new
       end
 
       let(:array) do
@@ -46,18 +48,18 @@ describe Mongoid::Extensions::Array do
       end
 
       it "returns the array" do
-        evolved.should eq(array)
+        expect(evolved).to eq(array)
       end
 
       it "returns the same instance" do
-        evolved.should equal(array)
+        expect(evolved).to equal(array)
       end
     end
 
     context "when some values are nil" do
 
       let(:object_id) do
-        Moped::BSON::ObjectId.new
+        BSON::ObjectId.new
       end
 
       let(:array) do
@@ -69,18 +71,18 @@ describe Mongoid::Extensions::Array do
       end
 
       it "returns the array with the nils" do
-        evolved.should eq([ object_id, nil ])
+        expect(evolved).to eq([ object_id, nil ])
       end
 
       it "returns the same instance" do
-        evolved.should equal(array)
+        expect(evolved).to equal(array)
       end
     end
 
     context "when some values are empty strings" do
 
       let(:object_id) do
-        Moped::BSON::ObjectId.new
+        BSON::ObjectId.new
       end
 
       let(:array) do
@@ -92,11 +94,11 @@ describe Mongoid::Extensions::Array do
       end
 
       it "returns the array with the empty strings" do
-        evolved.should eq([ object_id, "" ])
+        expect(evolved).to eq([ object_id, "" ])
       end
 
       it "returns the same instance" do
-        evolved.should equal(array)
+        expect(evolved).to equal(array)
       end
     end
   end
@@ -106,7 +108,7 @@ describe Mongoid::Extensions::Array do
     context "when provided an array of strings" do
 
       let(:object_id) do
-        Moped::BSON::ObjectId.new
+        BSON::ObjectId.new
       end
 
       let(:other) do
@@ -122,18 +124,18 @@ describe Mongoid::Extensions::Array do
       end
 
       it "converts the convertible ones to object ids" do
-        mongoized.should eq([ object_id, other ])
+        expect(mongoized).to eq([ object_id, other ])
       end
 
       it "returns the same instance" do
-        mongoized.should equal(array)
+        expect(mongoized).to equal(array)
       end
     end
 
     context "when provided an array of object ids" do
 
       let(:object_id) do
-        Moped::BSON::ObjectId.new
+        BSON::ObjectId.new
       end
 
       let(:array) do
@@ -145,18 +147,18 @@ describe Mongoid::Extensions::Array do
       end
 
       it "returns the array" do
-        mongoized.should eq(array)
+        expect(mongoized).to eq(array)
       end
 
       it "returns the same instance" do
-        mongoized.should equal(array)
+        expect(mongoized).to equal(array)
       end
     end
 
     context "when some values are nil" do
 
       let(:object_id) do
-        Moped::BSON::ObjectId.new
+        BSON::ObjectId.new
       end
 
       let(:array) do
@@ -168,18 +170,18 @@ describe Mongoid::Extensions::Array do
       end
 
       it "returns the array without the nils" do
-        mongoized.should eq([ object_id ])
+        expect(mongoized).to eq([ object_id ])
       end
 
       it "returns the same instance" do
-        mongoized.should equal(array)
+        expect(mongoized).to equal(array)
       end
     end
 
     context "when some values are empty strings" do
 
       let(:object_id) do
-        Moped::BSON::ObjectId.new
+        BSON::ObjectId.new
       end
 
       let(:array) do
@@ -191,11 +193,11 @@ describe Mongoid::Extensions::Array do
       end
 
       it "returns the array without the empty strings" do
-        mongoized.should eq([ object_id ])
+        expect(mongoized).to eq([ object_id ])
       end
 
       it "returns the same instance" do
-        mongoized.should equal(array)
+        expect(mongoized).to equal(array)
       end
     end
   end
@@ -204,41 +206,37 @@ describe Mongoid::Extensions::Array do
 
     context "when the related model uses object ids" do
 
-      let(:metadata) do
+      let(:association) do
         Person.relations["preferences"]
       end
 
-      let(:constraint) do
-        metadata.constraint
-      end
-
       context "when provided an object id" do
 
         let(:object_id) do
-          Moped::BSON::ObjectId.new
+          BSON::ObjectId.new
         end
 
         let(:fk) do
-          Array.__mongoize_fk__(constraint, object_id)
+          Array.__mongoize_fk__(association, object_id)
         end
 
         it "returns the object id as an array" do
-          fk.should eq([ object_id ])
+          expect(fk).to eq([ object_id ])
         end
       end
 
       context "when provided a object ids" do
 
         let(:object_id) do
-          Moped::BSON::ObjectId.new
+          BSON::ObjectId.new
         end
 
         let(:fk) do
-          Array.__mongoize_fk__(constraint, [ object_id ])
+          Array.__mongoize_fk__(association, [ object_id ])
         end
 
         it "returns the object ids" do
-          fk.should eq([ object_id ])
+          expect(fk).to eq([ object_id ])
         end
       end
 
@@ -247,15 +245,15 @@ describe Mongoid::Extensions::Array do
         context "when the string is a legal object id" do
 
           let(:object_id) do
-            Moped::BSON::ObjectId.new
+            BSON::ObjectId.new
           end
 
           let(:fk) do
-            Array.__mongoize_fk__(constraint, object_id.to_s)
+            Array.__mongoize_fk__(association, object_id.to_s)
           end
 
           it "returns the object id in an array" do
-            fk.should eq([ object_id ])
+            expect(fk).to eq([ object_id ])
           end
         end
 
@@ -266,22 +264,22 @@ describe Mongoid::Extensions::Array do
           end
 
           let(:fk) do
-            Array.__mongoize_fk__(constraint, string)
+            Array.__mongoize_fk__(association, string)
           end
 
           it "returns the string in an array" do
-            fk.should eq([ string ])
+            expect(fk).to eq([ string ])
           end
         end
 
         context "when the string is blank" do
 
           let(:fk) do
-            Array.__mongoize_fk__(constraint, "")
+            Array.__mongoize_fk__(association, "")
           end
 
           it "returns an empty array" do
-            fk.should be_empty
+            expect(fk).to be_empty
           end
         end
       end
@@ -289,11 +287,11 @@ describe Mongoid::Extensions::Array do
       context "when provided nil" do
 
         let(:fk) do
-          Array.__mongoize_fk__(constraint, nil)
+          Array.__mongoize_fk__(association, nil)
         end
 
         it "returns an empty array" do
-          fk.should be_empty
+          expect(fk).to be_empty
         end
       end
 
@@ -302,15 +300,15 @@ describe Mongoid::Extensions::Array do
         context "when the strings are legal object ids" do
 
           let(:object_id) do
-            Moped::BSON::ObjectId.new
+            BSON::ObjectId.new
           end
 
           let(:fk) do
-            Array.__mongoize_fk__(constraint, [ object_id.to_s ])
+            Array.__mongoize_fk__(association, [ object_id.to_s ])
           end
 
           it "returns the object id in an array" do
-            fk.should eq([ object_id ])
+            expect(fk).to eq([ object_id ])
           end
         end
 
@@ -321,22 +319,22 @@ describe Mongoid::Extensions::Array do
           end
 
           let(:fk) do
-            Array.__mongoize_fk__(constraint, [ string ])
+            Array.__mongoize_fk__(association, [ string ])
           end
 
           it "returns the string in an array" do
-            fk.should eq([ string ])
+            expect(fk).to eq([ string ])
           end
         end
 
         context "when the strings are blank" do
 
           let(:fk) do
-            Array.__mongoize_fk__(constraint, [ "", "" ])
+            Array.__mongoize_fk__(association, [ "", "" ])
           end
 
           it "returns an empty array" do
-            fk.should be_empty
+            expect(fk).to be_empty
           end
         end
       end
@@ -344,11 +342,11 @@ describe Mongoid::Extensions::Array do
       context "when provided nils" do
 
         let(:fk) do
-          Array.__mongoize_fk__(constraint, [ nil, nil, nil ])
+          Array.__mongoize_fk__(association, [ nil, nil, nil ])
         end
 
         it "returns an empty array" do
-          fk.should be_empty
+          expect(fk).to be_empty
         end
       end
     end
@@ -356,56 +354,36 @@ describe Mongoid::Extensions::Array do
 
   describe "#__mongoize_time__" do
 
-    context "when using active support's time zone" do
-
-      before do
-        Mongoid.use_activesupport_time_zone = true
-        ::Time.zone = "Tokyo"
-      end
-
-      after do
-        ::Time.zone = "Berlin"
-      end
+    let(:array) do
+      [ 2010, 11, 19, 00, 24, 49.123457 ]
+    end
 
-      let(:array) do
-        [ 2010, 11, 19, 00, 24, 49 ]
-      end
+    let(:mongoized) do
+      array.__mongoize_time__
+    end
 
-      let(:time) do
-        array.__mongoize_time__
-      end
+    context "when using active support's time zone" do
+      include_context 'using AS time zone'
 
-      it "converts to a time" do
-        time.should eq(::Time.zone.local(*array))
-      end
+      # In AS time zone (could be different from Ruby time zone)
+      let(:expected_time) { ::Time.zone.local(*array).in_time_zone }
 
       it "converts to the as time zone" do
-        time.zone.should eq("JST")
+        expect(mongoized.zone).to eq("JST")
       end
+
+      it_behaves_like 'mongoizes to AS::TimeWithZone'
+      it_behaves_like 'maintains precision when mongoized'
     end
 
     context "when not using active support's time zone" do
+      include_context 'not using AS time zone'
 
-      before do
-        Mongoid.use_activesupport_time_zone = false
-      end
+      # In Ruby time zone (could be different from AS time zone)
+      let(:expected_time) { ::Time.local(*array).in_time_zone }
 
-      after do
-        Mongoid.use_activesupport_time_zone = true
-        Time.zone = nil
-      end
-
-      let(:array) do
-        [ 2010, 11, 19, 00, 24, 49 ]
-      end
-
-      let(:time) do
-        array.__mongoize_time__
-      end
-
-      it "converts to a time" do
-        time.should eq(Time.local(*array))
-      end
+      it_behaves_like 'mongoizes to Time'
+      it_behaves_like 'maintains precision when mongoized'
     end
   end
 
@@ -419,8 +397,8 @@ describe Mongoid::Extensions::Array do
           [{ "_id" => { "$in" => [] }}]
         end
 
-        it "returns true" do
-          array.should be_blank_criteria
+        it "is false" do
+          expect(array.blank_criteria?).to be false
         end
       end
 
@@ -430,8 +408,8 @@ describe Mongoid::Extensions::Array do
           [{ "_id" => "test" }, { "_id" => { "$in" => [] }}]
         end
 
-        it "returns true" do
-          array.should be_blank_criteria
+        it "is false" do
+          expect(array.blank_criteria?).to be false
         end
       end
     end
@@ -450,7 +428,7 @@ describe Mongoid::Extensions::Array do
       end
 
       it "returns nil" do
-        deleted.should be_nil
+        expect(deleted).to be_nil
       end
     end
 
@@ -465,11 +443,11 @@ describe Mongoid::Extensions::Array do
       end
 
       it "deletes the object" do
-        array.should eq([ "2" ])
+        expect(array).to eq([ "2" ])
       end
 
       it "returns the object" do
-        deleted.should eq("1")
+        expect(deleted).to eq("1")
       end
     end
 
@@ -484,11 +462,11 @@ describe Mongoid::Extensions::Array do
       end
 
       it "deletes the first object" do
-        array.should eq([ "2", "1" ])
+        expect(array).to eq([ "2", "1" ])
       end
 
       it "returns the object" do
-        deleted.should eq("1")
+        expect(deleted).to eq("1")
       end
     end
   end
@@ -500,7 +478,7 @@ describe Mongoid::Extensions::Array do
     end
 
     it "returns the array" do
-      Array.demongoize(array).should eq(array)
+      expect(Array.demongoize(array)).to eq(array)
     end
   end
 
@@ -510,20 +488,34 @@ describe Mongoid::Extensions::Array do
       Date.new(2012, 1, 1)
     end
 
-    let(:array) do
+    let(:input) do
       [ date ]
     end
 
     let(:mongoized) do
-      Array.mongoize(array)
+      Array.mongoize(input)
     end
 
     it "mongoizes each element in the array" do
-      mongoized.first.should be_a(Time)
+      expect(mongoized.first).to be_a(Time)
     end
 
     it "converts the elements properly" do
-      mongoized.first.should eq(date)
+      expect(mongoized.first).to eq(Time.utc(2012, 1, 1, 0, 0, 0))
+    end
+
+    context "when passing in a set" do
+      let(:input) do
+        [ date ].to_set
+      end
+
+      it "mongoizes to an array" do
+        expect(mongoized).to be_a(Array)
+      end
+
+      it "converts the elements properly" do
+        expect(mongoized.first).to eq(Time.utc(2012, 1, 1, 0, 0, 0))
+      end
     end
   end
 
@@ -542,11 +534,11 @@ describe Mongoid::Extensions::Array do
     end
 
     it "mongoizes each element in the array" do
-      mongoized.first.should be_a(Time)
+      expect(mongoized.first).to be_a(Time)
     end
 
     it "converts the elements properly" do
-      mongoized.first.should eq(date)
+      expect(mongoized.first).to eq(Time.utc(2012, 1, 1, 0, 0, 0))
     end
   end
 
@@ -559,7 +551,7 @@ describe Mongoid::Extensions::Array do
       end
 
       it "returns true" do
-        array.should be_multi_arged
+        expect(array).to be_multi_arged
       end
     end
 
@@ -572,7 +564,7 @@ describe Mongoid::Extensions::Array do
         end
 
         it "returns false" do
-          array.should_not be_multi_arged
+          expect(array).to_not be_multi_arged
         end
       end
 
@@ -583,7 +575,7 @@ describe Mongoid::Extensions::Array do
         end
 
         it "returns false" do
-          array.should_not be_multi_arged
+          expect(array).to_not be_multi_arged
         end
       end
 
@@ -594,7 +586,7 @@ describe Mongoid::Extensions::Array do
         end
 
         it "returns true" do
-          array.should be_multi_arged
+          expect(array).to be_multi_arged
         end
       end
 
@@ -605,7 +597,7 @@ describe Mongoid::Extensions::Array do
         end
 
         it "returns true" do
-          array.should be_multi_arged
+          expect(array).to be_multi_arged
         end
       end
 
@@ -616,7 +608,7 @@ describe Mongoid::Extensions::Array do
         end
 
         it "returns true" do
-          array.should be_multi_arged
+          expect(array).to be_multi_arged
         end
       end
     end
@@ -625,14 +617,14 @@ describe Mongoid::Extensions::Array do
   describe ".resizable?" do
 
     it "returns true" do
-      Array.should be_resizable
+      expect(Array).to be_resizable
     end
   end
 
   describe "#resiable?" do
 
     it "returns true" do
-      [].should be_resizable
+      expect([]).to be_resizable
     end
   end
 end