mock_redis 0.5.4 → 0.31.0

data/spec/commands/zinterstore_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "#zinterstore(destination, keys, [:weights => [w,w,], [:aggregate => :sum|:min|:max])" do
+describe '#zinterstore(destination, keys, [:weights => [w,w,], [:aggregate => :sum|:min|:max])' do
   before do
     @odds   = 'mock-redis-test:zinterstore:odds'
     @primes = 'mock-redis-test:zinterstore:primes'
@@ -18,45 +18,79 @@ describe "#zinterstore(destination, keys, [:weights => [w,w,], [:aggregate => :s
     @redises.zadd(@primes, 7, 'seven')
   end
 
-  it "returns the number of elements in the new set" do
+  it 'returns the number of elements in the new set' do
     @redises.zinterstore(@dest, [@odds, @primes]).should == 3
   end
 
   it "sums the members' scores by default" do
     @redises.zinterstore(@dest, [@odds, @primes])
     @redises.zrange(@dest, 0, -1, :with_scores => true).should ==
-      [["three", 6.0], ["five", 10.0], ["seven", 14.0]]
+      [['three', 6.0], ['five', 10.0], ['seven', 14.0]]
   end
 
-  it "removes existing elements in destination" do
+  it 'removes existing elements in destination' do
     @redises.zadd(@dest, 10, 'ten')
 
     @redises.zinterstore(@dest, [@primes])
     @redises.zrange(@dest, 0, -1, :with_scores => true).should ==
-      [["two", 2.0], ["three", 3.0], ["five", 5.0], ["seven", 7.0]]
+      [['two', 2.0], ['three', 3.0], ['five', 5.0], ['seven', 7.0]]
   end
 
-  it "raises an error if keys is empty" do
+  it 'raises an error if keys is empty' do
     lambda do
       @redises.zinterstore(@dest, [])
-    end.should raise_error(RuntimeError)
+    end.should raise_error(Redis::CommandError)
   end
 
-  context "the :weights argument" do
-    it "multiplies the scores by the weights while aggregating" do
+  context 'when used with a set' do
+    before do
+      @primes_text = 'mock-redis-test:zinterstore:primes-text'
+
+      @redises.sadd(@primes_text, 'two')
+      @redises.sadd(@primes_text, 'three')
+      @redises.sadd(@primes_text, 'five')
+      @redises.sadd(@primes_text, 'seven')
+    end
+
+    it 'returns the number of elements in the new set' do
+      @redises.zinterstore(@dest, [@odds, @primes_text]).should == 3
+    end
+
+    it 'sums the scores, substituting 1.0 for set values' do
+      @redises.zinterstore(@dest, [@odds, @primes_text])
+      @redises.zrange(@dest, 0, -1, :with_scores => true).should ==
+        [['three', 4.0], ['five', 6.0], ['seven', 8.0]]
+    end
+  end
+
+  context 'when used with a non-coercible structure' do
+    before do
+      @non_set = 'mock-redis-test:zinterstore:non-set'
+
+      @redises.set(@non_set, 'one')
+    end
+    it 'raises an error for wrong value type' do
+      lambda do
+        @redises.zinterstore(@dest, [@odds, @non_set])
+      end.should raise_error(Redis::CommandError)
+    end
+  end
+
+  context 'the :weights argument' do
+    it 'multiplies the scores by the weights while aggregating' do
       @redises.zinterstore(@dest, [@odds, @primes], :weights => [2, 3])
       @redises.zrange(@dest, 0, -1, :with_scores => true).should ==
-        [["three", 15.0], ["five", 25.0], ["seven", 35.0]]
+        [['three', 15.0], ['five', 25.0], ['seven', 35.0]]
     end
 
-    it "raises an error if the number of weights != the number of keys" do
+    it 'raises an error if the number of weights != the number of keys' do
       lambda do
-        @redises.zinterstore(@dest, [@odds, @primes], :weights => [1,2,3])
-      end.should raise_error(RuntimeError)
+        @redises.zinterstore(@dest, [@odds, @primes], :weights => [1, 2, 3])
+      end.should raise_error(Redis::CommandError)
     end
   end
 
-  context "the :aggregate argument" do
+  context 'the :aggregate argument' do
     before do
       @smalls = 'mock-redis-test:zinterstore:smalls'
       @bigs   = 'mock-redis-test:zinterstore:bigs'
@@ -67,16 +101,16 @@ describe "#zinterstore(destination, keys, [:weights => [w,w,], [:aggregate => :s
       @redises.zadd(@bigs, 200, 'ernie')
     end
 
-    it "aggregates scores with min when :aggregate => :min is specified" do
+    it 'aggregates scores with min when :aggregate => :min is specified' do
       @redises.zinterstore(@dest, [@bigs, @smalls], :aggregate => :min)
       @redises.zrange(@dest, 0, -1, :with_scores => true).should ==
-        [["bert", 1.0], ["ernie", 2.0]]
+        [['bert', 1.0], ['ernie', 2.0]]
     end
 
-    it "aggregates scores with max when :aggregate => :max is specified" do
+    it 'aggregates scores with max when :aggregate => :max is specified' do
       @redises.zinterstore(@dest, [@bigs, @smalls], :aggregate => :max)
       @redises.zrange(@dest, 0, -1, :with_scores => true).should ==
-        [["bert", 100.0], ["ernie", 200.0]]
+        [['bert', 100.0], ['ernie', 200.0]]
     end
 
     it "allows 'min', 'MIN', etc. as aliases for :min" do
@@ -87,10 +121,10 @@ describe "#zinterstore(destination, keys, [:weights => [w,w,], [:aggregate => :s
       @redises.zscore(@dest, 'bert').should == 1.0
     end
 
-    it "raises an error for unknown aggregation function" do
+    it 'raises an error for unknown aggregation function' do
       lambda do
         @redises.zinterstore(@dest, [@bigs, @smalls], :aggregate => :mix)
-      end.should raise_error(RuntimeError)
+      end.should raise_error(Redis::CommandError)
     end
   end
 end

data/spec/commands/zpopmax_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+describe '#zpopmax(key, count)' do
+  before(:each) do
+    @key = 'mock-redis-test:zpopmax'
+    @redises.del(@key)
+    @redises.zadd(@key, 1, 'one')
+    @redises.zadd(@key, 2, 'two')
+    @redises.zadd(@key, 3, 'three')
+  end
+
+  context 'when count is unspecified' do
+    it 'returns nil if the set does not exist' do
+      @redises.zpopmax('does-not-exist').should nil
+    end
+
+    it 'returns the highest ranked element' do
+      @redises.zpopmax(@key).should == ['three', 3]
+      @redises.zcard(@key).should == 2
+    end
+  end
+
+  context 'when count is 1' do
+    let(:count) { 1 }
+
+    it 'returns nil if the set does not exist' do
+      @redises.zpopmax('does-not-exist', count).should nil
+    end
+
+    it 'returns the highest ranked element' do
+      @redises.zpopmax(@key, count).should == ['three', 3]
+      @redises.zcard(@key).should == 2
+    end
+  end
+
+  context 'when count is greater than 1' do
+    let(:count) { 2 }
+
+    it 'returns empty array if the set does not exist' do
+      @redises.zpopmax('does-not-exist', count).should == []
+    end
+
+    it 'returns the highest ranked elements' do
+      @redises.zpopmax(@key, count).should == [['three', 3], ['two', 2]]
+      @redises.zcard(@key).should == 1
+    end
+  end
+
+  context 'when count is greater than the size of the set' do
+    let(:count) { 4 }
+
+    it 'returns the entire set' do
+      before = @redises.zrange(@key, 0, count, with_scores: true).reverse
+      @redises.zpopmax(@key, count).should == before
+      @redises.zcard(@key).should == 0
+    end
+  end
+
+  it_should_behave_like 'a zset-only command'
+end

data/spec/commands/zpopmin_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+describe '#zpopmin(key, count)' do
+  before(:each) do
+    @key = 'mock-redis-test:zpopmin'
+    @redises.del(@key)
+    @redises.zadd(@key, 1, 'one')
+    @redises.zadd(@key, 2, 'two')
+    @redises.zadd(@key, 3, 'three')
+  end
+
+  context 'when count is unspecified' do
+    it 'returns nil if the set does not exist' do
+      @redises.zpopmin('does-not-exist').should nil
+    end
+
+    it 'returns the lowest ranked element' do
+      @redises.zpopmin(@key).should == ['one', 1]
+      @redises.zcard(@key).should == 2
+    end
+  end
+
+  context 'when count is 1' do
+    let(:count) { 1 }
+
+    it 'returns nil if the set does not exist' do
+      @redises.zpopmin('does-not-exist', count).should nil
+    end
+
+    it 'returns the lowest ranked element' do
+      @redises.zpopmin(@key, count).should == ['one', 1]
+      @redises.zcard(@key).should == 2
+    end
+  end
+
+  context 'when count is greater than 1' do
+    let(:count) { 2 }
+
+    it 'returns empty array if the set does not exist' do
+      @redises.zpopmin('does-not-exist', count).should == []
+    end
+
+    it 'returns the lowest ranked elements' do
+      @redises.zpopmin(@key, count).should == [['one', 1], ['two', 2]]
+      @redises.zcard(@key).should == 1
+    end
+  end
+
+  context 'when count is greater than the size of the set' do
+    let(:count) { 4 }
+
+    it 'returns the entire set' do
+      before = @redises.zrange(@key, 0, count, with_scores: true)
+      @redises.zpopmin(@key, count).should == before
+      @redises.zcard(@key).should == 0
+    end
+  end
+
+  it_should_behave_like 'a zset-only command'
+end

data/spec/commands/zrange_spec.rb

@@ -1,39 +1,80 @@
 require 'spec_helper'
 
-describe "#zrange(key, start, stop [, :with_scores => true])" do
+describe '#zrange(key, start, stop [, :with_scores => true])' do
   before do
     @key = 'mock-redis-test:zrange'
+    @redises.zadd(@key, 3, 'Jefferson')
     @redises.zadd(@key, 1, 'Washington')
     @redises.zadd(@key, 2, 'Adams')
-    @redises.zadd(@key, 3, 'Jefferson')
     @redises.zadd(@key, 4, 'Madison')
   end
 
-  it "returns the elements when the range is given as strings" do
-    @redises.zrange(@key, "0", "1").should == ['Washington', 'Adams']
+  context 'when the zset is empty' do
+    before do
+      @redises.del(@key)
+    end
+
+    it 'should return an empty array' do
+      @redises.exists?(@key).should == false
+      @redises.zrange(@key, 0, 4).should == []
+    end
   end
 
-  it "returns the elements in order by score" do
-    @redises.zrange(@key, 0, 1).should == ['Washington', 'Adams']
+  it 'returns the elements when the range is given as strings' do
+    @redises.zrange(@key, '0', '1').should == %w[Washington Adams]
   end
 
-  it "returns the elements in order by score (negative indices)" do
-    @redises.zrange(@key, -2, -1).should == ['Jefferson', 'Madison']
+  it 'returns the elements in order by score' do
+    @redises.zrange(@key, 0, 1).should == %w[Washington Adams]
+  end
+
+  context 'when a subset of elements have the same score' do
+    before do
+      @redises.zadd(@key, 1, 'Martha')
+    end
+
+    it 'returns the elements in ascending lexicographical order' do
+      @redises.zrange(@key, 0, 1).should == %w[Martha Washington]
+    end
+  end
+
+  it 'returns the elements in order by score (negative indices)' do
+    @redises.zrange(@key, -2, -1).should == %w[Jefferson Madison]
   end
 
   it 'returns empty list when start is too large' do
     @redises.zrange(@key, 5, -1).should == []
   end
 
-  it "returns the scores when :with_scores is specified" do
+  it 'returns entire list when start is out of bounds with negative end in bounds' do
+    @redises.zrange(@key, -5, -1).should == %w[Washington Adams Jefferson Madison]
+  end
+
+  it 'returns correct subset when start is out of bounds with positive end in bounds' do
+    @redises.zrange(@key, -5, 1).should == %w[Washington Adams]
+  end
+
+  it 'returns empty list when start is in bounds with negative end out of bounds' do
+    @redises.zrange(@key, 1, -5).should == []
+  end
+
+  it 'returns empty list when start is 0 with negative end out of bounds' do
+    @redises.zrange(@key, 0, -5).should == []
+  end
+
+  it 'returns correct subset when start is in bounds with negative end in bounds' do
+    @redises.zrange(@key, 1, -1).should == %w[Adams Jefferson Madison]
+  end
+
+  it 'returns the scores when :with_scores is specified' do
     @redises.zrange(@key, 0, 1, :with_scores => true).
-      should == [["Washington", 1.0], ["Adams", 2.0]]
+      should == [['Washington', 1.0], ['Adams', 2.0]]
   end
 
-  it "returns the scores when :withscores is specified" do
+  it 'returns the scores when :withscores is specified' do
     @redises.zrange(@key, 0, 1, :withscores => true).
-      should == [["Washington", 1.0], ["Adams", 2.0]]
+      should == [['Washington', 1.0], ['Adams', 2.0]]
   end
 
-  it_should_behave_like "a zset-only command"
+  it_should_behave_like 'a zset-only command'
 end

data/spec/commands/zrangebyscore_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "#zrangebyscore(key, start, stop [:with_scores => true] [:limit => [offset count]])" do
+describe '#zrangebyscore(key, start, stop [:with_scores => true] [:limit => [offset count]])' do
   before do
     @key = 'mock-redis-test:zrangebyscore'
     @redises.zadd(@key, 1, 'Washington')
@@ -9,60 +9,75 @@ describe "#zrangebyscore(key, start, stop [:with_scores => true] [:limit => [off
     @redises.zadd(@key, 4, 'Madison')
   end
 
-  it "returns the elements in order by score" do
-    @redises.zrangebyscore(@key, 1, 2).should == ['Washington', 'Adams']
+  context 'when the zset is empty' do
+    before do
+      @redises.del(@key)
+    end
+
+    it 'should return an empty array' do
+      @redises.exists?(@key).should == false
+      @redises.zrangebyscore(@key, 0, 4).should == []
+    end
+  end
+
+  it 'returns the elements in order by score' do
+    @redises.zrangebyscore(@key, 1, 2).should == %w[Washington Adams]
   end
 
-  it "returns the scores when :with_scores is specified" do
+  it 'returns the scores when :with_scores is specified' do
     @redises.zrangebyscore(@key, 1, 2, :with_scores => true).
-      should == [["Washington", 1.0], ["Adams", 2.0]]
+      should == [['Washington', 1.0], ['Adams', 2.0]]
   end
 
-  it "returns the scores when :withscores is specified" do
+  it 'returns the scores when :withscores is specified' do
     @redises.zrangebyscore(@key, 1, 2, :withscores => true).
-      should == [["Washington", 1.0], ["Adams", 2.0]]
+      should == [['Washington', 1.0], ['Adams', 2.0]]
   end
 
-  it "honors the :limit => [offset count] argument" do
+  it 'honors the :limit => [offset count] argument' do
     @redises.zrangebyscore(@key, -100, 100, :limit => [1, 2]).
-      should == ["Adams", "Jefferson"]
+      should == %w[Adams Jefferson]
   end
 
   it "raises an error if :limit isn't a 2-tuple" do
     lambda do
       @redises.zrangebyscore(@key, -100, 100, :limit => [1, 2, 3])
-    end.should raise_error(RuntimeError)
+    end.should raise_error(Redis::CommandError)
 
     lambda do
-      @redises.zrangebyscore(@key, -100, 100, :limit => "1, 2")
-    end.should raise_error
+      @redises.zrangebyscore(@key, -100, 100, :limit => '1, 2')
+    end.should raise_error(RedisMultiplexer::MismatchedResponse)
+  end
+
+  it 'treats scores like floats, not strings' do
+    @redises.zadd(@key, '10', 'Tyler')
+    @redises.zrangebyscore(@key, 1, 2).should == %w[Washington Adams]
   end
 
-  it "treats scores like floats, not strings" do
-    @redises.zadd(@key, "10", "Tyler")
-    @redises.zrangebyscore(@key, 1, 2).should == ['Washington', 'Adams']
+  it 'treats -inf as negative infinity' do
+    @redises.zrangebyscore(@key, '-inf', 3).should ==
+      %w[Washington Adams Jefferson]
   end
 
-  it "treats -inf as negative infinity" do
-    @redises.zrangebyscore(@key, "-inf", 3).should ==
-      ["Washington", "Adams", "Jefferson"]
+  it 'treats +inf as positive infinity' do
+    @redises.zrangebyscore(@key, 3, '+inf').should == %w[Jefferson Madison]
   end
 
-  it "treats +inf as positive infinity" do
-    @redises.zrangebyscore(@key, 3, "+inf").should == ["Jefferson", "Madison"]
+  it 'treats +inf as positive infinity' do
+    @redises.zrangebyscore(@key, 3, '+inf').should == %w[Jefferson Madison]
   end
 
-  it "treats +inf as positive infinity" do
-    @redises.zrangebyscore(@key, 3, "+inf").should == ["Jefferson", "Madison"]
+  it 'honors exclusive ranges on the left' do
+    @redises.zrangebyscore(@key, '(3', 4).should == ['Madison']
   end
 
-  it "honors exclusive ranges on the left" do
-    @redises.zrangebyscore(@key, "(3", 4).should == ["Madison"]
+  it 'honors exclusive ranges on the right' do
+    @redises.zrangebyscore(@key, '3', '(4').should == ['Jefferson']
   end
 
-  it "honors exclusive ranges on the right" do
-    @redises.zrangebyscore(@key, "3", "(4").should == ["Jefferson"]
+  it 'honors exclusive ranges on the left and the right simultaneously' do
+    @redises.zrangebyscore(@key, '(1', '(4').should == %w[Adams Jefferson]
   end
 
-  it_should_behave_like "a zset-only command"
+  it_should_behave_like 'a zset-only command'
 end

data/spec/commands/zrank_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "#zrank(key, member)" do
+describe '#zrank(key, member)' do
   before do
     @key = 'mock-redis-test:zrank'
 
@@ -13,17 +13,17 @@ describe "#zrank(key, member)" do
     @redises.zrank(@key, 'foo').should be_nil
   end
 
-  it "returns the index of the member in the set" do
+  it 'returns the index of the member in the set' do
     @redises.zrank(@key, 'one').should == 0
     @redises.zrank(@key, 'two').should == 1
     @redises.zrank(@key, 'three').should == 2
   end
 
-  it "handles integer members correctly" do
+  it 'handles integer members correctly' do
     member = 11
     @redises.zadd(@key, 4, member)
     @redises.zrank(@key, member).should == 3
   end
 
-  it_should_behave_like "a zset-only command"
+  it_should_behave_like 'a zset-only command'
 end

data/spec/commands/zrem_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "#zrem(key, member)" do
+describe '#zrem(key, member)' do
   before do
     @key = 'mock-redis-test:zrem'
 
@@ -8,30 +8,36 @@ describe "#zrem(key, member)" do
     @redises.zadd(@key, 2, 'two')
   end
 
-  it "returns true if member is present in the set" do
-    @redises.zrem(@key, 'one').should be_true
+  it 'returns true if member is present in the set' do
+    @redises.zrem(@key, 'one').should == true
   end
 
-  it "returns false if member is not present in the set" do
-    @redises.zrem(@key, 'nobody home').should be_false
+  it 'returns false if member is not present in the set' do
+    @redises.zrem(@key, 'nobody home').should == false
   end
 
-  it "removes member from the set" do
+  it 'removes member from the set' do
     @redises.zrem(@key, 'one')
     @redises.zrange(@key, 0, -1).should == ['two']
   end
 
-  it "removes integer member from the set" do
+  it 'removes integer member from the set' do
     member = 11
     @redises.zadd(@key, 3, member)
-    @redises.zrem(@key, member).should be_true
-    @redises.zrange(@key, 0, -1).should == ['one', 'two']
+    @redises.zrem(@key, member).should == true
+    @redises.zrange(@key, 0, -1).should == %w[one two]
   end
 
-  it "supports a variable number of arguments" do
-    @redises.zrem(@key, ['one', 'two'])
+  it 'supports a variable number of arguments' do
+    @redises.zrem(@key, %w[one two])
     @redises.zrange(@key, 0, -1).should be_empty
   end
 
-  it_should_behave_like "a zset-only command"
+  it 'raises an error if member is an empty array' do
+    lambda do
+      @redises.zrem(@key, [])
+    end.should raise_error(Redis::CommandError)
+  end
+
+  it_should_behave_like 'a zset-only command'
 end

data/spec/commands/zremrangebyrank_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "#zremrangebyrank(key, start, stop)" do
+describe '#zremrangebyrank(key, start, stop)' do
   before do
     @key = 'mock-redis-test:zremrangebyrank'
     @redises.zadd(@key, 1, 'Washington')
@@ -9,19 +9,19 @@ describe "#zremrangebyrank(key, start, stop)" do
     @redises.zadd(@key, 4, 'Madison')
   end
 
-  it "returns the number of elements in range" do
+  it 'returns the number of elements in range' do
     @redises.zremrangebyrank(@key, 2, 3).should == 2
   end
 
-  it "removes the elements" do
+  it 'removes the elements' do
     @redises.zremrangebyrank(@key, 2, 3)
     @redises.zrange(@key, 0, -1).should == %w[Washington Adams]
   end
 
-  it "does nothing if start is greater than cardinality of set" do
+  it 'does nothing if start is greater than cardinality of set' do
     @redises.zremrangebyrank(@key, 5, -1)
     @redises.zrange(@key, 0, -1).should == %w[Washington Adams Jefferson Madison]
   end
 
-  it_should_behave_like "a zset-only command"
+  it_should_behave_like 'a zset-only command'
 end

data/spec/commands/zremrangebyscore_spec.rb

@@ -1,6 +1,7 @@
 require 'spec_helper'
+require 'date'
 
-describe "#zremrangebyscore(key, min, max)" do
+describe '#zremrangebyscore(key, min, max)' do
   before do
     @key = 'mock-redis-test:zremrangebyscore'
     @redises.zadd(@key, 1, 'Washington')
@@ -9,20 +10,26 @@ describe "#zremrangebyscore(key, min, max)" do
     @redises.zadd(@key, 4, 'Madison')
   end
 
-  it "returns the number of elements in range" do
+  it 'returns the number of elements in range' do
     @redises.zremrangebyscore(@key, 2, 3).should == 2
   end
 
-  it "removes the elements" do
+  it 'removes the elements' do
     @redises.zremrangebyscore(@key, 2, 3)
     @redises.zrange(@key, 0, -1).should == %w[Washington Madison]
   end
 
   # As seen in http://redis.io/commands/zremrangebyscore
-  it "removes the elements for complex statements" do
+  it 'removes the elements for complex statements' do
     @redises.zremrangebyscore(@key, '-inf', '(4')
     @redises.zrange(@key, 0, -1).should == %w[Madison]
   end
 
-  it_should_behave_like "a zset-only command"
+  it_should_behave_like 'a zset-only command'
+
+  it 'throws a command error' do
+    expect do
+      @redises.zrevrangebyscore(@key, DateTime.now, '-inf')
+    end.to raise_error(Redis::CommandError)
+  end
 end