mock_redis 0.5.4 → 0.31.0

data/spec/commands/sdiffstore_spec.rb

@@ -7,52 +7,52 @@ describe '#sdiffstore(destination, key [, key, ...])' do
     @primes      = 'mock-redis-test:sdiffstore:primes'
     @destination = 'mock-redis-test:sdiffstore:destination'
 
-    (1..10).each {|i| @redises.sadd(@numbers, i) }
-    [2, 4, 6, 8, 10].each {|i| @redises.sadd(@evens, i) }
-    [2, 3, 5, 7].each {|i| @redises.sadd(@primes, i) }
+    (1..10).each { |i| @redises.sadd(@numbers, i) }
+    [2, 4, 6, 8, 10].each { |i| @redises.sadd(@evens, i) }
+    [2, 3, 5, 7].each { |i| @redises.sadd(@primes, i) }
   end
 
-  it "returns the number of elements in the resulting set" do
+  it 'returns the number of elements in the resulting set' do
     @redises.sdiffstore(@destination, @numbers, @evens).should == 5
   end
 
-  it "stores the resulting set" do
+  it 'stores the resulting set' do
     @redises.sdiffstore(@destination, @numbers, @evens)
     @redises.smembers(@destination).should == %w[9 7 5 3 1]
   end
 
-  it "does not store empty sets" do
+  it 'does not store empty sets' do
     @redises.sdiffstore(@destination, @numbers, @numbers).should == 0
     @redises.get(@destination).should be_nil
   end
 
-  it "treats missing keys as empty sets" do
+  it 'treats missing keys as empty sets' do
     @redises.sdiffstore(@destination, @evens, 'mock-redis-test:nonesuch')
     @redises.smembers(@destination).should == %w[10 8 6 4 2]
   end
 
-  it "removes existing elements in destination" do
+  it 'removes existing elements in destination' do
     @redises.sadd(@destination, 42)
 
     @redises.sdiffstore(@destination, @primes)
     @redises.smembers(@destination).should == %w[7 5 3 2]
   end
 
-  it "raises an error if given 0 sets" do
+  it 'raises an error if given 0 sets' do
     lambda do
       @redises.sdiffstore(@destination)
-    end.should raise_error(RuntimeError)
+    end.should raise_error(Redis::CommandError)
   end
 
-  it "raises an error if any argument is not a a set" do
+  it 'raises an error if any argument is not a a set' do
     @redises.set('mock-redis-test:notset', 1)
 
     lambda do
       @redises.sdiffstore(@destination, @numbers, 'mock-redis-test:notset')
-    end.should raise_error(RuntimeError)
+    end.should raise_error(Redis::CommandError)
 
     lambda do
       @redises.sdiffstore(@destination, 'mock-redis-test:notset', @numbers)
-    end.should raise_error(RuntimeError)
+    end.should raise_error(Redis::CommandError)
   end
 end

data/spec/commands/select_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "#select(db)" do
+describe '#select(db)' do
   before { @key = 'mock-redis-test:select' }
 
   it "returns 'OK'" do
@@ -14,7 +14,7 @@ describe "#select(db)" do
     @redises.get(@key).should == 'foo'
   end
 
-  it "switches databases" do
+  it 'switches databases' do
     @redises.select(0)
     @redises.set(@key, 'foo')
 
@@ -25,11 +25,11 @@ describe "#select(db)" do
     @redises.get(@key).should == 'foo'
   end
 
-  context "[mock only]" do
+  context '[mock only]' do
     # Time dependence introduces a bit of nondeterminism here
     before do
       @now = Time.now
-      Time.stub!(:now).and_return(@now)
+      Time.stub(:now).and_return(@now)
 
       @mock = @redises.mock
 
@@ -42,12 +42,20 @@ describe "#select(db)" do
       @mock.expire(@key, 200)
     end
 
-    it "keeps expire times per-db" do
+    it 'keeps expire times per-db' do
       @mock.select(0)
       @mock.ttl(@key).should == 100
 
       @mock.select(1)
       @mock.ttl(@key).should == 200
     end
+
+    it 'keeps expire times in miliseconds per-db' do
+      @mock.select(0)
+      (100_000 - 1000..100_000 + 1000).should cover(@mock.pttl(@key))
+
+      @mock.select(1)
+      (200_000 - 1000..200_000 + 1000).should cover(@mock.pttl(@key))
+    end
   end
 end

data/spec/commands/set_spec.rb

@@ -1,7 +1,119 @@
 require 'spec_helper'
 
 describe '#set(key, value)' do
+  let(:key) { 'mock-redis-test' }
+
   it "responds with 'OK'" do
     @redises.set('mock-redis-test', 1).should == 'OK'
   end
+
+  context 'options' do
+    it 'raises an error for EX seconds = 0' do
+      expect do
+        @redises.set('mock-redis-test', 1, ex: 0)
+      end.to raise_error(Redis::CommandError, 'ERR invalid expire time in set')
+    end
+
+    it 'raises an error for PX milliseconds = 0' do
+      expect do
+        @redises.set('mock-redis-test', 1, px: 0)
+      end.to raise_error(Redis::CommandError, 'ERR invalid expire time in set')
+    end
+
+    it 'accepts NX' do
+      @redises.del(key)
+      @redises.set(key, 1, nx: true).should == true
+      @redises.set(key, 1, nx: true).should == false
+    end
+
+    it 'accepts XX' do
+      @redises.del(key)
+      @redises.set(key, 1, xx: true).should == false
+      @redises.set(key, 1).should == 'OK'
+      @redises.set(key, 1, xx: true).should == true
+    end
+
+    it 'sets the ttl to -1' do
+      @redises.set(key, 1)
+      expect(@redises.ttl(key)).to eq(-1)
+    end
+
+    context 'with an expiry time' do
+      before :each do
+        Timecop.freeze
+        @redises.set(key, 1, ex: 90)
+      end
+
+      after :each do
+        @redises.del(key)
+        Timecop.return
+      end
+
+      it 'has the TTL set' do
+        expect(@redises.ttl(key)).to eq 90
+      end
+
+      it 'resets the TTL without keepttl' do
+        expect do
+          @redises.set(key, 2)
+        end.to change { @redises.ttl(key) }.from(90).to(-1)
+      end
+
+      it 'does not change the TTL with keepttl: true' do
+        expect do
+          @redises.set(key, 2, keepttl: true)
+        end.not_to change { @redises.ttl(key) }.from(90)
+      end
+    end
+
+    it 'accepts KEEPTTL' do
+      expect(@redises.set(key, 1, keepttl: true)).to eq 'OK'
+    end
+
+    it 'does not set TTL without ex' do
+      @redises.set(key, 1)
+      expect(@redises.ttl(key)).to eq(-1)
+    end
+
+    it 'sets the TTL' do
+      Timecop.freeze do
+        @redises.set(key, 1, ex: 90)
+        expect(@redises.ttl(key)).to eq 90
+      end
+    end
+
+    it 'raises on unknown options' do
+      @redises.del(key)
+      expect do
+        @redises.set(key, 1, logger: :something)
+      end.to raise_error(ArgumentError, /unknown keyword/)
+    end
+
+    context '[mock only]' do
+      before(:all) do
+        @mock = @redises.mock
+      end
+
+      before do
+        @now = Time.now
+        Time.stub(:now).and_return(@now)
+      end
+
+      it 'accepts EX seconds' do
+        @mock.set(key, 1, ex: 1).should == 'OK'
+        @mock.get(key).should_not be_nil
+        Time.stub(:now).and_return(@now + 2)
+        @mock.get(key).should be_nil
+      end
+
+      it 'accepts PX milliseconds' do
+        @mock.set(key, 1, px: 500).should == 'OK'
+        @mock.get(key).should_not be_nil
+        Time.stub(:now).and_return(@now + 300 / 1000.to_f)
+        @mock.get(key).should_not be_nil
+        Time.stub(:now).and_return(@now + 600 / 1000.to_f)
+        @mock.get(key).should be_nil
+      end
+    end
+  end
 end

data/spec/commands/setbit_spec.rb

@@ -1,10 +1,10 @@
-# -*- coding: utf-8 -*-
 require 'spec_helper'
 
-describe "#setbit(key, offset)" do
+describe '#setbit(key, offset)' do
   before do
+    Encoding.default_external = 'UTF-8'
     @key = 'mock-redis-test:setbit'
-    @redises.set(@key, 'h')    # ASCII 0x68
+    @redises.set(@key, 'h') # ASCII 0x68
   end
 
   it "returns the original stored bit's value" do
@@ -12,35 +12,44 @@ describe "#setbit(key, offset)" do
     @redises.setbit(@key, 1, 1).should == 1
   end
 
-  it "sets the bit within the string" do
-    $debug = true
+  it 'sets the bit within the string' do
     @redises.setbit(@key, 7, 1)
-    $debug = false
     @redises.get(@key).should == 'i'  # ASCII 0x69
   end
 
-  it "does the right thing with multibyte characters" do
-    @redises.set(@key, "€99.94")   # the euro sign is 3 bytes wide in UTF-8
+  it 'unsets the bit within the string' do
+    @redises.setbit(@key, 1, 0)
+    @redises.get(@key).should == '('  # ASCII 0x28
+  end
+
+  it 'does the right thing with multibyte characters' do
+    @redises.set(@key, '€99.94') # the euro sign is 3 bytes wide in UTF-8
     @redises.setbit(@key, 63, 1).should == 0
-    @redises.get(@key).should == "€99.95"
+    @redises.get(@key).should == '€99.95'
   end
 
-  it "expands the string if necessary" do
+  it 'expands the string if necessary' do
     @redises.setbit(@key, 9, 1)
-    @redises.get(@key).should == "h@"
+    @redises.get(@key).should == 'h@'
   end
 
-  it "sets added bits to 0" do
+  it 'sets added bits to 0' do
     @redises.setbit(@key, 17, 1)
     @redises.get(@key).should == "h\000@"
   end
 
-  it "treats missing keys as empty strings" do
+  it 'treats missing keys as empty strings' do
     @redises.del(@key)
     @redises.setbit(@key, 1, 1)
-    @redises.get(@key).should == "@"
+    @redises.get(@key).should == '@'
+  end
+
+  it 'sets and retrieves bits' do
+    @redises.setbit(@key, 22, 1)
+    @redises.getbit(@key, 22).should == 1
+    @redises.setbit(@key, 23, 0)
+    @redises.getbit(@key, 23).should == 0
   end
 
-  it_should_behave_like "a string-only command"
+  it_should_behave_like 'a string-only command'
 end
- 

data/spec/commands/setex_spec.rb

@@ -7,16 +7,32 @@ describe '#setex(key, seconds, value)' do
     @redises.setex(@key, 10, 'value').should == 'OK'
   end
 
-  it "sets the value" do
-    @redises.setex(@key, 10000, 'value')
+  it 'sets the value' do
+    @redises.setex(@key, 10_000, 'value')
     @redises.get(@key).should == 'value'
   end
 
-  it "sets the expiration time" do
-    @redises.setex(@key, 10000, 'value')
+  it 'sets the expiration time' do
+    @redises.setex(@key, 10_000, 'value')
 
     # no guarantee these are the same
     @redises.real.ttl(@key).should > 0
     @redises.mock.ttl(@key).should > 0
   end
+
+  context 'when expiration time is zero' do
+    it 'raises Redis::CommandError' do
+      expect do
+        @redises.setex(@key, 0, 'value')
+      end.to raise_error(Redis::CommandError, 'ERR invalid expire time in setex')
+    end
+  end
+
+  context 'when expiration time is negative' do
+    it 'raises Redis::CommandError' do
+      expect do
+        @redises.setex(@key, -2, 'value')
+      end.to raise_error(Redis::CommandError, 'ERR invalid expire time in setex')
+    end
+  end
 end

data/spec/commands/setnx_spec.rb

@@ -3,21 +3,21 @@ require 'spec_helper'
 describe '#setnx(key, value)' do
   before { @key = 'mock-redis-test:setnx' }
 
-  it "returns true if the key was absent" do
-    @redises.setnx(@key, 1).should be_true
+  it 'returns true if the key was absent' do
+    @redises.setnx(@key, 1).should == true
   end
 
-  it "returns false if the key was present" do
+  it 'returns false if the key was present' do
     @redises.set(@key, 2)
-    @redises.setnx(@key, 1).should be_false
+    @redises.setnx(@key, 1).should == false
   end
 
-  it "sets the value if missing" do
+  it 'sets the value if missing' do
     @redises.setnx(@key, 'value')
     @redises.get(@key).should == 'value'
   end
 
-  it "does nothing if the value is present" do
+  it 'does nothing if the value is present' do
     @redises.set(@key, 'old')
     @redises.setnx(@key, 'new')
     @redises.get(@key).should == 'old'

data/spec/commands/setrange_spec.rb

@@ -1,30 +1,30 @@
 require 'spec_helper'
 
-describe "#setrange(key, offset, value)" do
+describe '#setrange(key, offset, value)' do
   before do
     @key = 'mock-redis-test:setrange'
-    @redises.set(@key, "This is a string")
+    @redises.set(@key, 'This is a string')
   end
 
   it "returns the string's new length" do
-    @redises.setrange(@key, 0, "That").should == 16
+    @redises.setrange(@key, 0, 'That').should == 16
   end
 
-  it "updates part of the string" do
-    @redises.setrange(@key, 0, "That")
-    @redises.get(@key).should == "That is a string"
+  it 'updates part of the string' do
+    @redises.setrange(@key, 0, 'That')
+    @redises.get(@key).should == 'That is a string'
   end
 
-  it "zero-pads the string if necessary" do
-    @redises.setrange(@key, 20, "X")
+  it 'zero-pads the string if necessary' do
+    @redises.setrange(@key, 20, 'X')
     @redises.get(@key).should == "This is a string\000\000\000\000X"
   end
 
-  it "stores things as strings" do
-    other_key = "mock-redis-test:setrange-other-key"
+  it 'stores things as strings' do
+    other_key = 'mock-redis-test:setrange-other-key'
     @redises.setrange(other_key, 0, 1)
-    @redises.get(other_key).should == "1"
+    @redises.get(other_key).should == '1'
   end
 
-  it_should_behave_like "a string-only command"
+  it_should_behave_like 'a string-only command'
 end

data/spec/commands/sinter_spec.rb

@@ -6,36 +6,34 @@ describe '#sinter(key [, key, ...])' do
     @evens   = 'mock-redis-test:sinter:evens'
     @primes  = 'mock-redis-test:sinter:primes'
 
-    (1..10).each {|i| @redises.sadd(@numbers, i) }
-    [2, 4, 6, 8, 10].each {|i| @redises.sadd(@evens, i) }
-    [2, 3, 5, 7].each {|i| @redises.sadd(@primes, i) }
+    (1..10).each { |i| @redises.sadd(@numbers, i) }
+    [2, 4, 6, 8, 10].each { |i| @redises.sadd(@evens, i) }
+    [2, 3, 5, 7].each { |i| @redises.sadd(@primes, i) }
   end
 
-  it "returns the elements in the resulting set" do
-    @redises.sinter(@evens, @primes).should == ["2"]
+  it 'returns the elements in the resulting set' do
+    @redises.sinter(@evens, @primes).should == ['2']
   end
 
-  it "treats missing keys as empty sets" do
+  it 'treats missing keys as empty sets' do
     @redises.sinter(@destination, 'mock-redis-test:nonesuch').should == []
   end
 
-  it "raises an error if given 0 sets" do
+  it 'raises an error if given 0 sets' do
     lambda do
       @redises.sinter
-    end.should raise_error(RuntimeError)
+    end.should raise_error(Redis::CommandError)
   end
 
-  it "raises an error if any argument is not a a set" do
+  it 'raises an error if any argument is not a a set' do
     @redises.set('mock-redis-test:notset', 1)
 
     lambda do
       @redises.sinter(@numbers, 'mock-redis-test:notset')
-    end.should raise_error(RuntimeError)
+    end.should raise_error(Redis::CommandError)
 
     lambda do
       @redises.sinter('mock-redis-test:notset', @numbers)
-    end.should raise_error(RuntimeError)
+    end.should raise_error(Redis::CommandError)
   end
 end
-
-    

data/spec/commands/sinterstore_spec.rb

@@ -7,47 +7,47 @@ describe '#sinterstore(destination, key [, key, ...])' do
     @primes      = 'mock-redis-test:sinterstore:primes'
     @destination = 'mock-redis-test:sinterstore:destination'
 
-    (1..10).each {|i| @redises.sadd(@numbers, i) }
-    [2, 4, 6, 8, 10].each {|i| @redises.sadd(@evens, i) }
-    [2, 3, 5, 7].each {|i| @redises.sadd(@primes, i) }
+    (1..10).each { |i| @redises.sadd(@numbers, i) }
+    [2, 4, 6, 8, 10].each { |i| @redises.sadd(@evens, i) }
+    [2, 3, 5, 7].each { |i| @redises.sadd(@primes, i) }
   end
 
-  it "returns the number of elements in the resulting set" do
+  it 'returns the number of elements in the resulting set' do
     @redises.sinterstore(@destination, @numbers, @evens).should == 5
   end
 
-  it "stores the resulting set" do
+  it 'stores the resulting set' do
     @redises.sinterstore(@destination, @numbers, @evens)
     @redises.smembers(@destination).should == %w[10 8 6 4 2]
   end
 
-  it "does not store empty sets" do
+  it 'does not store empty sets' do
     @redises.sinterstore(@destination, 'mock-redis-test:nonesuch', @numbers).should == 0
     @redises.get(@destination).should be_nil
   end
 
-  it "removes existing elements in destination" do
+  it 'removes existing elements in destination' do
     @redises.sadd(@destination, 42)
 
     @redises.sinterstore(@destination, @primes)
     @redises.smembers(@destination).should == %w[7 5 3 2]
   end
 
-  it "raises an error if given 0 sets" do
+  it 'raises an error if given 0 sets' do
     lambda do
       @redises.sinterstore(@destination)
-    end.should raise_error(RuntimeError)
+    end.should raise_error(Redis::CommandError)
   end
 
-  it "raises an error if any argument is not a a set" do
+  it 'raises an error if any argument is not a a set' do
     @redises.set('mock-redis-test:notset', 1)
 
     lambda do
       @redises.sinterstore(@destination, @numbers, 'mock-redis-test:notset')
-    end.should raise_error(RuntimeError)
+    end.should raise_error(Redis::CommandError)
 
     lambda do
       @redises.sinterstore(@destination, 'mock-redis-test:notset', @numbers)
-    end.should raise_error(RuntimeError)
+    end.should raise_error(Redis::CommandError)
   end
 end

data/spec/commands/sismember_spec.rb

@@ -7,23 +7,23 @@ describe '#sismember(key, member)' do
     @redises.sadd(@key, 'beer')
   end
 
-  it "returns true if member is in set" do
-    @redises.sismember(@key, 'whiskey').should be_true
-    @redises.sismember(@key, 'beer').should be_true
+  it 'returns true if member is in set' do
+    @redises.sismember(@key, 'whiskey').should == true
+    @redises.sismember(@key, 'beer').should == true
   end
 
-  it "returns false if member is not in set" do
-    @redises.sismember(@key, 'cola').should be_false
+  it 'returns false if member is not in set' do
+    @redises.sismember(@key, 'cola').should == false
   end
 
-  it "stringifies member" do
+  it 'stringifies member' do
     @redises.sadd(@key, '1')
-    @redises.sismember(@key, 1).should be_true
+    @redises.sismember(@key, 1).should == true
   end
 
-  it "treats a nonexistent value as an empty set" do
-    @redises.sismember('mock-redis-test:nonesuch', 'beer').should be_false
+  it 'treats a nonexistent value as an empty set' do
+    @redises.sismember('mock-redis-test:nonesuch', 'beer').should == false
   end
 
-  it_should_behave_like "a set-only command"
+  it_should_behave_like 'a set-only command'
 end

data/spec/commands/smembers_spec.rb

@@ -3,16 +3,26 @@ require 'spec_helper'
 describe '#smembers(key)' do
   before { @key = 'mock-redis-test:smembers' }
 
-  it "returns [] for an empty set" do
+  it 'returns [] for an empty set' do
     @redises.smembers(@key).should == []
   end
 
   it "returns the set's members" do
-    @redises.sadd(@key, "Hello")
-    @redises.sadd(@key, "World")
-    @redises.sadd(@key, "Test")
+    @redises.sadd(@key, 'Hello')
+    @redises.sadd(@key, 'World')
+    @redises.sadd(@key, 'Test')
     @redises.smembers(@key).should == %w[Test World Hello]
   end
 
-  it_should_behave_like "a set-only command"
+  it 'returns unfrozen copies of the input' do
+    input = 'a string'
+    @redises.sadd(@key, input)
+    output = @redises.smembers(@key).first
+
+    expect(output).to eq input
+    expect(output).to_not equal input
+    expect(output).to_not be_frozen
+  end
+
+  it_should_behave_like 'a set-only command'
 end

data/spec/commands/smove_spec.rb

@@ -9,33 +9,33 @@ describe '#smove(source, destination, member)' do
     @redises.sadd(@dest, 2)
   end
 
-  it "returns true if the member exists in src" do
-    @redises.smove(@src, @dest, 1).should be_true
+  it 'returns true if the member exists in src' do
+    @redises.smove(@src, @dest, 1).should == true
   end
 
-  it "returns false if the member exists in src" do
-    @redises.smove(@src, @dest, 'nope').should be_false
+  it 'returns false if the member exists in src' do
+    @redises.smove(@src, @dest, 'nope').should == false
   end
 
-  it "returns true if the member exists in src and dest" do
+  it 'returns true if the member exists in src and dest' do
     @redises.sadd(@dest, 1)
-    @redises.smove(@src, @dest, 1).should be_true
+    @redises.smove(@src, @dest, 1).should == true
   end
 
-  it "moves member from source to destination" do
+  it 'moves member from source to destination' do
     @redises.smove(@src, @dest, 1)
-    @redises.sismember(@dest, 1).should be_true
-    @redises.sismember(@src, 1).should be_false
+    @redises.sismember(@dest, 1).should == true
+    @redises.sismember(@src, 1).should == false
   end
 
-  it "cleans up empty sets" do
+  it 'cleans up empty sets' do
     @redises.smove(@src, @dest, 1)
     @redises.get(@src).should be_nil
   end
 
-  it "treats a nonexistent value as an empty set" do
-    @redises.smove('mock-redis-test:nonesuch', @dest, 1).should be_false
+  it 'treats a nonexistent value as an empty set' do
+    @redises.smove('mock-redis-test:nonesuch', @dest, 1).should == false
   end
 
-  it_should_behave_like "a set-only command"
+  it_should_behave_like 'a set-only command'
 end

data/spec/commands/sort_list_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe '#sort(key, options)' do
+  before do
+    @key = 'mock-redis-test:list_sort'
+
+    @redises.rpush(@key, '1')
+    @redises.rpush(@key, '2')
+
+    @redises.set('mock-redis-test:values_1', 'a')
+    @redises.set('mock-redis-test:values_2', 'b')
+
+    @redises.set('mock-redis-test:weight_1', '2')
+    @redises.set('mock-redis-test:weight_2', '1')
+
+    @redises.hset('mock-redis-test:hash_1', 'key', 'x')
+    @redises.hset('mock-redis-test:hash_2', 'key', 'y')
+  end
+
+  it_should_behave_like 'a sortable'
+end