mock_redis 0.5.4 → 0.31.0

data/spec/commands/xrange_spec.rb

@@ -0,0 +1,164 @@
+require 'spec_helper'
+
+describe '#xrange("mystream", first: "0-1", last: "0-3", count: 10)' do
+  before { @key = 'mock-redis-test:xrange' }
+
+  it 'finds an empty range' do
+    expect(@redises.xrange(@key, '-', '+')).to eq []
+  end
+
+  it 'finds a single entry with a full range' do
+    @redises.xadd(@key, { key: 'value' }, id: '1234567891234-0')
+    expect(@redises.xrange(@key, '-', '+'))
+      .to eq [['1234567891234-0', { 'key' => 'value' }]]
+  end
+
+  it 'finds multiple key/value pairs with a full range' do
+    @redises.xadd(@key, { key1: 'value1', key2: 'value2', key3: 'value3' }, id: '1234567891234-0')
+    expect(@redises.xrange(@key, '-', '+'))
+      .to eq [['1234567891234-0', { 'key1' => 'value1', 'key2' => 'value2', 'key3' => 'value3' }]]
+  end
+
+  context 'six items on the list' do
+    before :each do
+      @redises.xadd(@key, { key1: 'value1' }, id: '1234567891234-0')
+      @redises.xadd(@key, { key2: 'value2' }, id: '1234567891245-0')
+      @redises.xadd(@key, { key3: 'value3' }, id: '1234567891245-1')
+      @redises.xadd(@key, { key4: 'value4' }, id: '1234567891278-0')
+      @redises.xadd(@key, { key5: 'value5' }, id: '1234567891278-1')
+      @redises.xadd(@key, { key6: 'value6' }, id: '1234567891299-0')
+    end
+
+    it 'returns entries in sequential order' do
+      expect(@redises.xrange(@key, '-', '+')).to eq(
+        [
+          ['1234567891234-0', { 'key1' => 'value1' }],
+          ['1234567891245-0', { 'key2' => 'value2' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891278-1', { 'key5' => 'value5' }],
+          ['1234567891299-0', { 'key6' => 'value6' }]
+        ]
+      )
+    end
+
+    it 'returns entries with a lower limit' do
+      expect(@redises.xrange(@key, '1234567891239-0', '+')).to eq(
+        [
+          ['1234567891245-0', { 'key2' => 'value2' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891278-1', { 'key5' => 'value5' }],
+          ['1234567891299-0', { 'key6' => 'value6' }]
+        ]
+      )
+    end
+
+    it 'returns all entries with a lower limit of 0-0' do
+      expect(@redises.xrange(@key, '0-0', '+')).to eq(
+        [
+          ['1234567891234-0', { 'key1' => 'value1' }],
+          ['1234567891245-0', { 'key2' => 'value2' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891278-1', { 'key5' => 'value5' }],
+          ['1234567891299-0', { 'key6' => 'value6' }]
+        ]
+      )
+    end
+
+    it 'returns entries with an upper limit' do
+      expect(@redises.xrange(@key, '-', '1234567891285-0')).to eq(
+        [
+          ['1234567891234-0', { 'key1' => 'value1' }],
+          ['1234567891245-0', { 'key2' => 'value2' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891278-1', { 'key5' => 'value5' }]
+        ]
+      )
+    end
+
+    it 'returns entries with both a lower and an upper limit inclusive' do
+      expect(@redises.xrange(@key, '1234567891245-0', '1234567891278-0')).to eq(
+        [
+          ['1234567891245-0', { 'key2' => 'value2' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891278-0', { 'key4' => 'value4' }]
+        ]
+      )
+    end
+
+    it 'returns entries with both a lower and an upper limit exclusive' do
+      expect(@redises.xrange(@key, '(1234567891245-0', '1234567891285-1')).to eq(
+        [
+          # We no longer get '1234567891245-0'
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891278-1', { 'key5' => 'value5' }] # Note sequence -1
+        ]
+      )
+    end
+
+    it 'finds the list with sequence numbers' do
+      expect(@redises.xrange(@key, '1234567891245-1', '1234567891278-0')).to eq(
+        [
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891278-0', { 'key4' => 'value4' }]
+        ]
+      )
+    end
+
+    it 'finds the list with lower bound without sequence numbers' do
+      expect(@redises.xrange(@key, '1234567891245', '+')).to eq(
+        [
+          ['1234567891245-0', { 'key2' => 'value2' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891278-1', { 'key5' => 'value5' }],
+          ['1234567891299-0', { 'key6' => 'value6' }]
+        ]
+      )
+    end
+
+    it 'finds the list with upper bound without sequence numbers' do
+      expect(@redises.xrange(@key, '-', '1234567891278')).to eq(
+        [
+          ['1234567891234-0', { 'key1' => 'value1' }],
+          ['1234567891245-0', { 'key2' => 'value2' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891278-1', { 'key5' => 'value5' }]
+        ]
+      )
+    end
+
+    it 'accepts limits as integers' do
+      expect(@redises.xrange(@key, 1_234_567_891_245, 1_234_567_891_278)).to eq(
+        [
+          ['1234567891245-0', { 'key2' => 'value2' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891278-1', { 'key5' => 'value5' }]
+        ]
+      )
+    end
+
+    it 'returns a limited number of items' do
+      expect(@redises.xrange(@key, '-', '+', count: 2)).to eq(
+        [
+          ['1234567891234-0', { 'key1' => 'value1' }],
+          ['1234567891245-0', { 'key2' => 'value2' }]
+        ]
+      )
+    end
+  end
+
+  it 'raises an invalid stream id error' do
+    expect { @redises.xrange(@key, 'X', '+') }
+      .to raise_error(
+        Redis::CommandError,
+        'ERR Invalid stream ID specified as stream command argument'
+      )
+  end
+end

data/spec/commands/xread_spec.rb

@@ -0,0 +1,66 @@
+require 'spec_helper'
+
+describe '#xread(keys, ids)' do
+  before :all do
+    sleep 1 - (Time.now.to_f % 1)
+    @key = 'mock-redis-test:xread'
+    @key1 = 'mock-redis-test:xread1'
+  end
+
+  it 'reads a single entry' do
+    @redises.xadd(@key, { key: 'value' }, id: '1234567891234-0')
+    expect(@redises.xread(@key, '0-0'))
+      .to eq({ @key => [['1234567891234-0', { 'key' => 'value' }]] })
+  end
+
+  it 'reads multiple entries from the beginning of the stream' do
+    @redises.xadd(@key, { key0: 'value0' }, id: '1234567891234-0')
+    @redises.xadd(@key, { key1: 'value1' }, id: '1234567891234-1')
+    expect(@redises.xread(@key, '0-0'))
+      .to eq({ @key => [['1234567891234-0', { 'key0' => 'value0' }],
+                        ['1234567891234-1', { 'key1' => 'value1' }]] })
+  end
+
+  it 'reads entries greater than the ID passed' do
+    @redises.xadd(@key, { key0: 'value0' }, id: '1234567891234-0')
+    @redises.xadd(@key, { key1: 'value1' }, id: '1234567891234-1')
+    expect(@redises.xread(@key, '1234567891234-0'))
+      .to eq({ @key => [['1234567891234-1', { 'key1' => 'value1' }]] })
+  end
+
+  it 'reads from multiple streams' do
+    @redises.xadd(@key, { key: 'value' }, id: '1234567891234-0')
+    @redises.xadd(@key1, { key1: 'value1' }, id: '1234567891234-0')
+    expect(@redises.xread([@key, @key1], %w[0-0 0-0]))
+      .to eq({ @key => [['1234567891234-0', { 'key' => 'value' }]],
+               @key1 => [['1234567891234-0', { 'key1' => 'value1' }]] })
+  end
+
+  it 'reads from multiple streams at the given IDs' do
+    @redises.xadd(@key, { key: 'value0' }, id: '1234567891234-0')
+    @redises.xadd(@key, { key: 'value1' }, id: '1234567891234-1')
+    @redises.xadd(@key, { key: 'value2' }, id: '1234567891234-2')
+    @redises.xadd(@key1, { key1: 'value0' }, id: '1234567891234-0')
+    @redises.xadd(@key1, { key1: 'value1' }, id: '1234567891234-1')
+    @redises.xadd(@key1, { key1: 'value2' }, id: '1234567891234-2')
+    # The first stream won't return anything since we specify the last ID
+    expect(@redises.xread([@key, @key1], %w[1234567891234-2 1234567891234-1]))
+      .to eq({ @key1 => [['1234567891234-2', { 'key1' => 'value2' }]] })
+  end
+
+  it 'supports the block parameter' do
+    @redises.xadd(@key, { key: 'value' }, id: '1234567891234-0')
+    expect(@redises.xread(@key, '0-0', block: 1000))
+      .to eq({ @key => [['1234567891234-0', { 'key' => 'value' }]] })
+  end
+
+  it 'limits results with count' do
+    @redises.xadd(@key, { key: 'value' }, id: '1234567891234-0')
+    @redises.xadd(@key, { key: 'value' }, id: '1234567891234-1')
+    @redises.xadd(@key, { key: 'value' }, id: '1234567891234-2')
+    expect(@redises.xread(@key, '0-0', count: 1))
+      .to eq({ @key => [['1234567891234-0', { 'key' => 'value' }]] })
+    expect(@redises.xread(@key, '1234567891234-0', count: 1))
+      .to eq({ @key => [['1234567891234-1', { 'key' => 'value' }]] })
+  end
+end

data/spec/commands/xrevrange_spec.rb

@@ -0,0 +1,130 @@
+require 'spec_helper'
+
+describe '#xrevrange(key, start, end)' do
+  before { @key = 'mock-redis-test:xrevrange' }
+
+  it 'finds an empty range' do
+    expect(@redises.xrevrange(@key, '-', '+')).to eq []
+  end
+
+  it 'finds a single entry with a full range' do
+    @redises.xadd(@key, { key: 'value' }, id: '1234567891234-0')
+    expect(@redises.xrevrange(@key, '+', '-'))
+      .to eq [['1234567891234-0', { 'key' => 'value' }]]
+  end
+
+  it 'finds multiple key/value pairs with a full range' do
+    @redises.xadd(@key, { key1: 'value1', key2: 'value2', key3: 'value3' }, id: '1234567891234-0')
+    expect(@redises.xrevrange(@key, '+', '-'))
+      .to eq [['1234567891234-0', { 'key1' => 'value1', 'key2' => 'value2', 'key3' => 'value3' }]]
+  end
+
+  context 'six items on the list' do
+    before :each do
+      @redises.xadd(@key, { key1: 'value1' }, id: '1234567891234-0')
+      @redises.xadd(@key, { key2: 'value2' }, id: '1234567891245-0')
+      @redises.xadd(@key, { key3: 'value3' }, id: '1234567891245-1')
+      @redises.xadd(@key, { key4: 'value4' }, id: '1234567891278-0')
+      @redises.xadd(@key, { key5: 'value5' }, id: '1234567891278-1')
+      @redises.xadd(@key, { key6: 'value6' }, id: '1234567891299-0')
+    end
+
+    it 'returns entries in sequential order' do
+      expect(@redises.xrevrange(@key, '+', '-')).to eq(
+        [
+          ['1234567891299-0', { 'key6' => 'value6' }],
+          ['1234567891278-1', { 'key5' => 'value5' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891245-0', { 'key2' => 'value2' }],
+          ['1234567891234-0', { 'key1' => 'value1' }],
+        ]
+      )
+    end
+
+    it 'returns entries with a lower limit' do
+      expect(@redises.xrevrange(@key, '+', '1234567891239-0')).to eq(
+        [
+          ['1234567891299-0', { 'key6' => 'value6' }],
+          ['1234567891278-1', { 'key5' => 'value5' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891245-0', { 'key2' => 'value2' }],
+        ]
+      )
+    end
+
+    it 'returns entries with an upper limit' do
+      expect(@redises.xrevrange(@key, '1234567891285-0', '-')).to eq(
+        [
+          ['1234567891278-1', { 'key5' => 'value5' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891245-0', { 'key2' => 'value2' }],
+          ['1234567891234-0', { 'key1' => 'value1' }],
+        ]
+      )
+    end
+
+    it 'returns entries with both a lower and an upper limit' do
+      expect(@redises.xrevrange(@key, '1234567891285-0', '1234567891239-0')).to eq(
+        [
+          ['1234567891278-1', { 'key5' => 'value5' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891245-0', { 'key2' => 'value2' }],
+        ]
+      )
+    end
+
+    it 'finds the list with sequence numbers' do
+      expect(@redises.xrevrange(@key, '1234567891278-0', '1234567891245-1')).to eq(
+        [
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+        ]
+      )
+    end
+
+    it 'finds the list with lower bound without sequence numbers' do
+      expect(@redises.xrevrange(@key, '+', '1234567891245')).to eq(
+        [
+          ['1234567891299-0', { 'key6' => 'value6' }],
+          ['1234567891278-1', { 'key5' => 'value5' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891245-0', { 'key2' => 'value2' }],
+        ]
+      )
+    end
+
+    it 'finds the list with upper bound without sequence numbers' do
+      expect(@redises.xrevrange(@key, '1234567891278', '-')).to eq(
+        [
+          ['1234567891278-1', { 'key5' => 'value5' }],
+          ['1234567891278-0', { 'key4' => 'value4' }],
+          ['1234567891245-1', { 'key3' => 'value3' }],
+          ['1234567891245-0', { 'key2' => 'value2' }],
+          ['1234567891234-0', { 'key1' => 'value1' }],
+        ]
+      )
+    end
+
+    it 'returns a limited number of items' do
+      expect(@redises.xrevrange(@key, count: 2)).to eq(
+        [
+          ['1234567891299-0', { 'key6' => 'value6' }],
+          ['1234567891278-1', { 'key5' => 'value5' }],
+        ]
+      )
+    end
+  end
+
+  it 'raises an invalid stream id error' do
+    expect { @redises.xrevrange(@key, 'X', '-') }
+      .to raise_error(
+        Redis::CommandError,
+        'ERR Invalid stream ID specified as stream command argument'
+      )
+  end
+end

data/spec/commands/xtrim_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe '#xtrim("mystream", 1000, approximate: true)' do
+  before { @key = 'mock-redis-test:xtrim' }
+
+  before :each do
+    @redises.xadd(@key, { key1: 'value1' }, id: '1234567891234-0')
+    @redises.xadd(@key, { key2: 'value2' }, id: '1234567891245-0')
+    @redises.xadd(@key, { key3: 'value3' }, id: '1234567891245-1')
+    @redises.xadd(@key, { key4: 'value4' }, id: '1234567891278-0')
+    @redises.xadd(@key, { key5: 'value5' }, id: '1234567891278-1')
+    @redises.xadd(@key, { key6: 'value6' }, id: '1234567891299-0')
+  end
+
+  it 'returns the number of elements deleted' do
+    expect(@redises.xtrim(@key, 4)).to eq 2
+  end
+
+  it 'returns 0 if count is greater than size' do
+    initial = @redises.xrange(@key, '-', '+')
+    expect(@redises.xtrim(@key, 1000)).to eq 0
+    expect(@redises.xrange(@key, '-', '+')).to eql(initial)
+  end
+
+  it 'deletes the oldes elements' do
+    @redises.xtrim(@key, 4)
+    expect(@redises.xrange(@key, '-', '+')).to eq(
+      [
+        ['1234567891245-1', { 'key3' => 'value3' }],
+        ['1234567891278-0', { 'key4' => 'value4' }],
+        ['1234567891278-1', { 'key5' => 'value5' }],
+        ['1234567891299-0', { 'key6' => 'value6' }]
+      ]
+    )
+  end
+end

data/spec/commands/zadd_spec.rb

@@ -1,40 +1,129 @@
 require 'spec_helper'
 
-describe "#zadd(key, score, member)" do
+describe '#zadd(key, score, member)' do
   before { @key = 'mock-redis-test:zadd' }
 
   it "returns true if member wasn't present in the set" do
-    @redises.zadd(@key, 1, 'foo').should be_true
+    @redises.zadd(@key, 1, 'foo').should == true
   end
 
-  it "returns false if member was present in the set" do
+  it 'returns false if member was present in the set' do
     @redises.zadd(@key, 1, 'foo')
-    @redises.zadd(@key, 1, 'foo').should be_false
+    @redises.zadd(@key, 1, 'foo').should == false
   end
 
-  it "adds member to the set" do
+  it 'adds member to the set' do
     @redises.zadd(@key, 1, 'foo')
     @redises.zrange(@key, 0, -1).should == ['foo']
   end
 
-  it "treats integer members as strings" do
+  it 'treats integer members as strings' do
     member = 11
     @redises.zadd(@key, 1, member)
     @redises.zrange(@key, 0, -1).should == [member.to_s]
   end
 
-  it "updates the score" do
+  it 'allows scores to be set to Float::INFINITY' do
+    member = '1'
+    @redises.zadd(@key, Float::INFINITY, member)
+    @redises.zrange(@key, 0, -1).should == [member]
+  end
+
+  it 'updates the score' do
     @redises.zadd(@key, 1, 'foo')
     @redises.zadd(@key, 2, 'foo')
 
     @redises.zscore(@key, 'foo').should == 2.0
   end
 
-  it "supports a variable number of arguments" do
+  it 'with XX option command do nothing if element not exist' do
+    @redises.zadd(@key, 1, 'foo')
+    @redises.zadd(@key, 2, 'bar', xx: true)
+    @redises.zrange(@key, 0, -1).should_not include 'bar'
+  end
+
+  it 'with XX option command update index on exist element' do
+    @redises.zadd(@key, 1, 'foo')
+    @redises.zadd(@key, 2, 'foo', xx: true)
+    @redises.zscore(@key, 'foo').should == 2.0
+  end
+
+  it 'with XX option and multiple elements command update index on exist element' do
+    @redises.zadd(@key, 1, 'foo')
+    added_count = @redises.zadd(@key, [[2, 'foo'], [2, 'bar']], xx: true)
+    added_count.should == 0
+
+    @redises.zscore(@key, 'foo').should == 2.0
+    @redises.zrange(@key, 0, -1).should_not include 'bar'
+  end
+
+  it "with NX option don't update current element" do
+    @redises.zadd(@key, 1, 'foo')
+    @redises.zadd(@key, 2, 'foo', nx: true)
+    @redises.zscore(@key, 'foo').should == 1.0
+  end
+
+  it 'with NX option create new element' do
+    @redises.zadd(@key, 1, 'foo')
+    @redises.zadd(@key, 2, 'bar', nx: true)
+    @redises.zrange(@key, 0, -1).should include 'bar'
+  end
+
+  it 'with NX option and multiple elements command only create element' do
+    @redises.zadd(@key, 1, 'foo')
+    added_count = @redises.zadd(@key, [[2, 'foo'], [2, 'bar']], nx: true)
+    added_count.should == 1
+    @redises.zscore(@key, 'bar').should == 2.0
+    @redises.zrange(@key, 0, -1).should eq %w[foo bar]
+  end
+
+  it 'XX and NX options in same time raise error' do
+    lambda do
+      @redises.zadd(@key, 1, 'foo', nx: true, xx: true)
+    end.should raise_error(Redis::CommandError)
+  end
+
+  it 'with INCR is act like zincrby' do
+    @redises.zadd(@key, 10, 'bert', incr: true).should == 10.0
+    @redises.zadd(@key, 3, 'bert', incr: true).should == 13.0
+  end
+
+  it 'with INCR and XX not create element' do
+    @redises.zadd(@key, 10, 'bert', xx: true, incr: true).should be_nil
+  end
+
+  it 'with INCR and XX increase score for exist element' do
+    @redises.zadd(@key, 2, 'bert')
+    @redises.zadd(@key, 10, 'bert', xx: true, incr: true).should == 12.0
+  end
+
+  it 'with INCR and NX create element with score' do
+    @redises.zadd(@key, 11, 'bert', nx: true, incr: true).should == 11.0
+  end
+
+  it 'with INCR and NX not update element' do
+    @redises.zadd(@key, 1, 'bert')
+    @redises.zadd(@key, 10, 'bert', nx: true, incr: true).should be_nil
+  end
+
+  it 'with INCR with variable number of arguments raise error' do
+    lambda do
+      @redises.zadd(@key, [[1, 'one'], [2, 'two']], incr: true)
+    end.should raise_error(Redis::CommandError)
+  end
+
+  it 'supports a variable number of arguments' do
     @redises.zadd(@key, [[1, 'one'], [2, 'two']])
-    @redises.zrange(@key, 0, -1).should == ['one', 'two']
+    @redises.zadd(@key, [[3, 'three']])
+    @redises.zrange(@key, 0, -1).should == %w[one two three]
+  end
+
+  it 'raises an error if an empty array is given' do
+    lambda do
+      @redises.zadd(@key, [])
+    end.should raise_error(Redis::CommandError)
   end
 
-  it_should_behave_like "arg 1 is a score"
-  it_should_behave_like "a zset-only command"
+  it_should_behave_like 'arg 1 is a score'
+  it_should_behave_like 'a zset-only command'
 end

data/spec/commands/zcard_spec.rb

@@ -1,19 +1,19 @@
 require 'spec_helper'
 
-describe "#zcard(key)" do
+describe '#zcard(key)' do
   before do
     @key = 'mock-redis-test:zcard'
   end
 
-  it "returns the number of elements in the zset" do
+  it 'returns the number of elements in the zset' do
     @redises.zadd(@key, 1, 'Washington')
     @redises.zadd(@key, 2, 'Adams')
     @redises.zcard(@key).should == 2
   end
 
-  it "returns 0 for nonexistent sets" do
+  it 'returns 0 for nonexistent sets' do
     @redises.zcard(@key).should == 0
   end
 
-  it_should_behave_like "a zset-only command"
+  it_should_behave_like 'a zset-only command'
 end

data/spec/commands/zcount_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "#zcount(key, min, max)" do
+describe '#zcount(key, min, max)' do
   before do
     @key = 'mock-redis-test:zcount'
     @redises.zadd(@key, 1, 'Washington')
@@ -9,23 +9,31 @@ describe "#zcount(key, min, max)" do
     @redises.zadd(@key, 4, 'Madison')
   end
 
-  it "returns the number of members in the zset with scores in (min..max)" do
+  it 'returns the number of members in the zset with scores in (min..max)' do
     @redises.zcount(@key, 3, 10).should == 2
   end
 
-  it "returns 0 if there are no such members" do
+  it 'returns 0 if there are no such members' do
     @redises.zcount(@key, 100, 200).should == 0
   end
 
-  it "returns count of all elements when -inf to +inf" do
-    @redises.zcount(@key, "-inf", '+inf').should == 4
+  it 'returns count of all elements when -inf to +inf' do
+    @redises.zcount(@key, '-inf', '+inf').should == 4
   end
 
-  it "returns a proper count of elements using +inf upper bound" do
-    @redises.zcount(@key, 3, "+inf").should == 2
+  it 'returns a proper count of elements using +inf upper bound' do
+    @redises.zcount(@key, 3, '+inf').should == 2
   end
 
-  it_should_behave_like "arg 1 is a score"
-  it_should_behave_like "arg 2 is a score"
-  it_should_behave_like "a zset-only command"
+  it 'returns a proper count of elements using exclusive lower bound' do
+    @redises.zcount(@key, '(3', '+inf').should == 1
+  end
+
+  it 'returns a proper count of elements using exclusive upper bound' do
+    @redises.zcount(@key, '-inf', '(3').should == 2
+  end
+
+  it_should_behave_like 'arg 1 is a score'
+  it_should_behave_like 'arg 2 is a score'
+  it_should_behave_like 'a zset-only command'
 end

data/spec/commands/zincrby_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
-describe "#zincrby(key, increment, member)" do
+describe '#zincrby(key, increment, member)' do
   before do
     @key = 'mock-redis-test:zincrby'
     @redises.zadd(@key, 1, 'bert')
   end
 
-  it "returns the new score as a string" do
+  it 'returns the new score as a string' do
     @redises.zincrby(@key, 10, 'bert').should == 11.0
   end
 
@@ -15,17 +15,17 @@ describe "#zincrby(key, increment, member)" do
     @redises.zscore(@key, 'bert').should == 11.0
   end
 
-  it "handles integer members correctly" do
+  it 'handles integer members correctly' do
     member = 11
     @redises.zadd(@key, 1, member)
     @redises.zincrby(@key, 1, member)
     @redises.zscore(@key, member).should == 2.0
   end
 
-  it "adds missing members with score increment" do
+  it 'adds missing members with score increment' do
     @redises.zincrby(@key, 5.5, 'bigbird').should == 5.5
   end
 
-  it_should_behave_like "arg 1 is a score"
-  it_should_behave_like "a zset-only command"
+  it_should_behave_like 'arg 1 is a score'
+  it_should_behave_like 'a zset-only command'
 end