metric_fu 4.11.1 → 4.13.0

data/spec/metric_fu/metrics/saikuro/generator_spec.rb

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'saikuro/generator' }
+MetricFu.metrics_require { "saikuro/generator" }
 
 describe MetricFu::SaikuroGenerator do
   STUB_TEST_DATA = lambda do |generator|
@@ -22,7 +22,7 @@ describe MetricFu::SaikuroGenerator do
     end
 
     it "should find the filename of a file" do
-      expect(@output[:saikuro][:files].first[:filename]).to eq('app/controllers/users_controller.rb')
+      expect(@output[:saikuro][:files].first[:filename]).to eq("app/controllers/users_controller.rb")
     end
 
     it "should find the name of the classes" do
@@ -55,16 +55,16 @@ describe MetricFu::SaikuroGenerator do
 
     it "doesn't try to get information if the file does not exist" do
       expect(@saikuro).to receive(:file_not_exists?).at_least(:once).and_return(true)
-      @saikuro.per_file_info('ignore_me')
+      @saikuro.per_file_info("ignore_me")
     end
   end
 
   describe MetricFu::SaikuroScratchFile do
     describe "getting elements from a Saikuro result file" do
-     it "should parse nested START/END sections" do
-       path = FIXTURE.fixtures_path.join("saikuro_sfiles", "thing.rb_cyclo.html").to_s
-       sfile = MetricFu::SaikuroScratchFile.new path
-       expect(sfile.elements.map { |e| e.complexity }.sort).to eql(["0","0","2"])
+      it "should parse nested START/END sections" do
+        path = FIXTURE.fixtures_path.join("saikuro_sfiles", "thing.rb_cyclo.html").to_s
+        sfile = MetricFu::SaikuroScratchFile.new path
+        expect(sfile.elements.map(&:complexity).sort).to eql(["0", "0", "2"])
       end
     end
   end

data/spec/metric_fu/metrics/stats/generator_spec.rb

@@ -1,10 +1,10 @@
 require "spec_helper"
-MetricFu.metrics_require { 'stats/generator' }
+MetricFu.metrics_require { "stats/generator" }
 
 describe StatsGenerator do
   describe "emit method" do
     it "should gather the raw data" do
-      ENV['CC_BUILD_ARTIFACTS'] = nil
+      ENV["CC_BUILD_ARTIFACTS"] = nil
       MetricFu.configure.reset
       allow(File).to receive(:directory?).and_return(true)
       stats = MetricFu::StatsGenerator.new
@@ -12,7 +12,7 @@ describe StatsGenerator do
     end
   end
 
-  #TODO review tested output
+  # TODO review tested output
   describe "analyze method" do
     before :each do
       @lines =  <<-HERE.gsub(/^\s*/, "")
@@ -34,11 +34,11 @@ describe StatsGenerator do
         Code LOC: 915     Test LOC: 2226     Code to Test Ratio: 1:2.4
 
       HERE
-      ENV['CC_BUILD_ARTIFACTS'] = nil
+      ENV["CC_BUILD_ARTIFACTS"] = nil
       MetricFu.configure.reset
       allow(File).to receive(:directory?).and_return(true)
       stats = MetricFu::StatsGenerator.new
-      stats.instance_variable_set('@output', @lines)
+      stats.instance_variable_set("@output", @lines)
       @results = stats.analyze
     end
 
@@ -55,7 +55,7 @@ describe StatsGenerator do
     end
 
     it "should get data on models" do
-      model_data = @results[:lines].find {|line| line[:name] == "Models"}
+      model_data = @results[:lines].find { |line| line[:name] == "Models" }
       expect(model_data[:classes]).to eq(9)
       expect(model_data[:methods]).to eq(31)
       expect(model_data[:loc]).to eq(285)
@@ -64,7 +64,7 @@ describe StatsGenerator do
       expect(model_data[:loc_per_method]).to eq(7)
     end
 
-    it 'handles code to test ratio is ratio is 1:NaN' do
+    it "handles code to test ratio is ratio is 1:NaN" do
       lines =  <<-HERE.gsub(/^\s*/, "")
       +----------------------+-------+-------+---------+---------+-----+-------+
       | Name                 | Lines |   LOC | Classes | Methods | M/C | LOC/M |
@@ -73,11 +73,11 @@ describe StatsGenerator do
         Code LOC: 0     Test LOC: 0     Code to Test Ratio: 1:NaN
 
       HERE
-      ENV['CC_BUILD_ARTIFACTS'] = nil
+      ENV["CC_BUILD_ARTIFACTS"] = nil
       MetricFu.configure.reset
       allow(File).to receive(:directory?).and_return(true)
       stats = MetricFu::StatsGenerator.new(MetricFu::Metric.get_metric(:stats).run_options)
-      stats.instance_variable_set('@output', lines)
+      stats.instance_variable_set("@output", lines)
       @results = stats.analyze
       expect(@results[:code_to_test_ratio]).to eq(0.0)
     end
@@ -85,7 +85,7 @@ describe StatsGenerator do
 
   describe "to_h method" do
     it "should put things into a hash" do
-      ENV['CC_BUILD_ARTIFACTS'] = nil
+      ENV["CC_BUILD_ARTIFACTS"] = nil
       MetricFu.configure.reset
       allow(File).to receive(:directory?).and_return(true)
       stats = MetricFu::StatsGenerator.new

data/spec/metric_fu/metrics/stats/grapher_spec.rb

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'stats/grapher' }
+MetricFu.metrics_require { "stats/grapher" }
 
 describe StatsGrapher do
   before :each do
@@ -61,7 +61,7 @@ describe StatsGrapher do
       end
 
       it "should update labels with the date" do
-        expect(@stats_grapher.labels).to receive(:update).with({ 0 => "01022003" })
+        expect(@stats_grapher.labels).to receive(:update).with(0 => "01022003")
         @stats_grapher.get_metrics(@metrics, @date)
       end
     end

data/spec/metric_fu/reporter_spec.rb

@@ -1,36 +1,35 @@
 require "spec_helper"
-MetricFu.lib_require { 'reporter' }
+MetricFu.lib_require { "reporter" }
 
 describe MetricFu::Reporter do
-
-  context 'given a single formatter' do
+  context "given a single formatter" do
     before do
-      @formatter = double('formatter')
+      @formatter = double("formatter")
       allow(@formatter).to receive(:to_a).and_return([@formatter])
       @reporter = Reporter.new(@formatter)
     end
 
-    it 'notifies the formatter' do
+    it "notifies the formatter" do
       expect(@formatter).to receive(:start)
       expect(@formatter).to receive(:finish)
       @reporter.start
       @reporter.finish
     end
 
-    it 'only sends notifications when supported by formatter' do
+    it "only sends notifications when supported by formatter" do
       allow(@formatter).to receive(:respond_to?).with(:display_results).and_return(false)
       expect(@formatter).not_to receive(:display_results)
       @reporter.display_results
     end
   end
 
-  context 'given multiple formatters' do
+  context "given multiple formatters" do
     before do
-      @formatters = [double('formatter'), double('formatter')]
+      @formatters = [double("formatter"), double("formatter")]
       @reporter = Reporter.new(@formatters)
     end
 
-    it 'notifies all formatters' do
+    it "notifies all formatters" do
       @formatters.each do |formatter|
         expect(formatter).to receive(:start)
         expect(formatter).to receive(:finish)

data/spec/metric_fu/reporting/graphs/graph_spec.rb

@@ -1,8 +1,7 @@
 require "spec_helper"
-MetricFu.reporting_require { 'graphs/graph' }
+MetricFu.reporting_require { "graphs/graph" }
 
 describe MetricFu do
-
   describe "responding to #graph" do
     it "should return an instance of Graph" do
       expect(MetricFu.graph).to be_a(Graph)
@@ -11,13 +10,11 @@ describe MetricFu do
 end
 
 describe MetricFu::Graph do
-
   before(:each) do
     @graph = MetricFu::Graph.new
   end
 
   describe "setting the date on the graph" do
-
     # TODO better test
     it "should set the date once for one data point" do
       metric_file = "metric_fu/tmp/_data/20101105.yml"

data/spec/metric_fu/reporting/graphs/grapher_spec.rb

@@ -9,16 +9,16 @@ describe "Bluff graphers responding to #graph!" do
   end
   it "should write chart file" do
     graphs = {}
-    available_graphs = MetricFu::Metric.enabled_metrics.select{|m|m.has_graph?}.map(&:name)
+    available_graphs = MetricFu::Metric.enabled_metrics.select(&:has_graph?).map(&:name)
     available_graphs.each do |graph|
-      grapher_name = graph.to_s.gsub("MetricFu::",'').gsub(/\/(.?)/) { "::#{$1.upcase}" }.gsub(/(?:^|_)(.)/) { $1.upcase }
-      grapher_name =  grapher_name+"Grapher"
+      grapher_name = graph.to_s.gsub("MetricFu::", "").gsub(/\/(.?)/) { "::#{$1.upcase}" }.gsub(/(?:^|_)(.)/) { $1.upcase }
+      grapher_name =  grapher_name + "Grapher"
       graphs[graph] = MetricFu.const_get(grapher_name).new
     end
     graphs.each do |key, val|
       val.graph!
-      output_dir = File.expand_path(File.join(MetricFu::Io::FileSystem.directory('output_directory')))
-      expect{ File.read(File.join(output_dir, "#{key.to_s.downcase}.js")) }.not_to raise_error
+      output_dir = File.expand_path(File.join(MetricFu::Io::FileSystem.directory("output_directory")))
+      expect { File.read(File.join(output_dir, "#{key.to_s.downcase}.js")) }.not_to raise_error
     end
   end
 end

data/spec/metric_fu/reporting/result_spec.rb

@@ -1,24 +1,22 @@
 require "spec_helper"
-MetricFu.reporting_require { 'result' }
+MetricFu.reporting_require { "result" }
 
 describe MetricFu do
-
   describe "#result" do
-    it 'should return an instance of Result' do
+    it "should return an instance of Result" do
       expect(MetricFu.result.instance_of?(Result)).to be(true)
     end
   end
 end
 
 describe MetricFu::Result do
-
   before(:each) do
     @result = MetricFu::Result.new
   end
 
   describe "#as_yaml" do
-    it 'should call #result_hash' do
-      result_hash = double('result_hash')
+    it "should call #result_hash" do
+      result_hash = double("result_hash")
       expect(result_hash).to receive(:to_yaml)
 
       expect(@result).to receive(:result_hash).and_return(result_hash)
@@ -30,20 +28,20 @@ describe MetricFu::Result do
   end
 
   describe "#add" do
-    it 'should add a passed hash to the result_hash instance variable' do
-      result_type = double('result_type')
-      allow(result_type).to receive(:to_s).and_return('type')
+    it "should add a passed hash to the result_hash instance variable" do
+      result_type = double("result_type")
+      allow(result_type).to receive(:to_s).and_return("type")
 
-      result_inst = double('result_inst')
+      result_inst = double("result_inst")
       expect(result_type).to receive(:new).and_return(result_inst)
 
-      expect(result_inst).to receive(:generate_result).and_return({:a => 'b'})
+      expect(result_inst).to receive(:generate_result).and_return(a: "b")
       expect(result_inst).to receive(:respond_to?).and_return(false)
 
       expect(MetricFu::Generator).to receive(:get_generator).
-               with(result_type).and_return(result_type)
-      result_hash = double('result_hash')
-      expect(result_hash).to receive(:merge!).with({:a => 'b'})
+        with(result_type).and_return(result_type)
+      result_hash = double("result_hash")
+      expect(result_hash).to receive(:merge!).with(a: "b")
       expect(@result).to receive(:result_hash).and_return(result_hash)
       expect(@result).to receive(:metric_options_for_result_type).with(result_type)
       @result.add(result_type)

data/spec/metric_fu/run_spec.rb

@@ -1,5 +1,5 @@
-require 'spec_helper'
-require 'metric_fu/cli/client'
+require "spec_helper"
+require "metric_fu/cli/client"
 
 describe MetricFu do
   let(:helper)  { MetricFu::Cli::Helper.new }
@@ -9,27 +9,25 @@ describe MetricFu do
   end
 
   def base_directory
-    directory('base_directory')
+    directory("base_directory")
   end
 
   def output_directory
-    directory('output_directory')
+    directory("output_directory")
   end
 
   def data_directory
-    directory('data_directory')
+    directory("data_directory")
   end
 
   context "given configured metrics, when run" do
-
     before do
-
       # TODO: Should probably use some sort of fake metric
       # to speed up tests. For now, just configuring with a
       # limited set, so we can test the basic functionality
       # without significantly slowing down the specs.
       MetricFu.configuration.configure_metrics do |metric|
-        if metric.name == :reek
+        if metric.name == :cane
           metric.enable
           metric.activated = true
           # so this doesn't seem to always be true
@@ -40,12 +38,11 @@ describe MetricFu do
           # need some help debugging
           # but tests seem more stable without it.
           # metric.should_receive(:run_external).and_return('')
-          allow(metric).to receive(:run_external).and_return('')
+          allow(metric).to receive(:run_external).and_return("")
         else
           metric.enabled = false
         end
       end
-
     end
 
     it "creates a report yaml file" do
@@ -78,22 +75,19 @@ describe MetricFu do
           metric_fu
         }.to_not create_file("#{output_directory}/index.html")
       end
-
     end
 
     context "with command line formatter" do
       it "outputs using command line formatter" do
-        expect { metric_fu "--format yaml"}.to create_file("#{base_directory}/report.yml")
+        expect { metric_fu "--format yaml" }.to create_file("#{base_directory}/report.yml")
       end
 
       it "doesn't output using formatters not configured" do
-        expect { metric_fu "--format yaml"}.to_not create_file("#{output_directory}/index.html")
+        expect { metric_fu "--format yaml" }.to_not create_file("#{output_directory}/index.html")
       end
-
     end
 
     context "with configured and command line formatter" do
-
       before do
         MetricFu::Configuration.run do |config|
           config.configure_formatter(:html)
@@ -101,13 +95,12 @@ describe MetricFu do
       end
 
       it "outputs using command line formatter" do
-        expect { metric_fu "--format yaml"}.to create_file("#{base_directory}/report.yml")
+        expect { metric_fu "--format yaml" }.to create_file("#{base_directory}/report.yml")
       end
 
       it "doesn't output using configured formatter (cli takes precedence)" do
-        expect { metric_fu "--format yaml"}.to_not create_file("#{output_directory}/index.html")
+        expect { metric_fu "--format yaml" }.to_not create_file("#{output_directory}/index.html")
       end
-
     end
 
     context "with configured specified out" do
@@ -128,32 +121,28 @@ describe MetricFu do
           metric_fu
         }.to_not create_file("#{base_directory}/report.yml")
       end
-
     end
 
     context "with command line specified formatter + out" do
       it "outputs to the specified path" do
-        expect { metric_fu "--format yaml --out customreport.yml"}.to create_file("#{base_directory}/customreport.yml")
+        expect { metric_fu "--format yaml --out customreport.yml" }.to create_file("#{base_directory}/customreport.yml")
       end
 
       it "doesn't output to default path" do
-        expect { metric_fu "--format yaml --out customreport.yml"}.to_not create_file("#{base_directory}/report.yml")
+        expect { metric_fu "--format yaml --out customreport.yml" }.to_not create_file("#{base_directory}/report.yml")
       end
-
     end
 
     context "with command line specified out only" do
       it "outputs to the specified path" do
-        expect { metric_fu "--out customdir --no-open"}.to create_file("#{base_directory}/customdir/index.html")
+        expect { metric_fu "--out customdir --no-open" }.to create_file("#{base_directory}/customdir/index.html")
       end
 
       it "doesn't output to default path" do
-        expect { metric_fu "--out customdir --no-open"}.to_not create_file("#{output_directory}/index.html")
+        expect { metric_fu "--out customdir --no-open" }.to_not create_file("#{output_directory}/index.html")
       end
-
     end
 
-
     after do
       MetricFu::Configuration.run do |config|
         config.formatters.clear
@@ -162,7 +151,6 @@ describe MetricFu do
   end
 
   context "given other options" do
-
     it "displays help" do
       out = metric_fu "--help"
       expect(out).to include helper.banner
@@ -175,14 +163,13 @@ describe MetricFu do
 
     it "errors on unknown flags" do
       failure = false
-      out = metric_fu "--asdasdasda" do |message|
+      out = metric_fu "--asdasdasda" do |_message|
         # swallow the error message
         failure = true
       end
-      expect(out).to include 'invalid option'
+      expect(out).to include "invalid option"
       expect(failure).to be_truthy
     end
-
   end
 
   after do
@@ -190,7 +177,7 @@ describe MetricFu do
   end
 
   def metric_fu(options = "--no-open")
-    message = ''
+    message = ""
     out = MetricFu::Utility.capture_output {
       begin
         argv = Shellwords.shellwords(options)
@@ -202,10 +189,9 @@ describe MetricFu do
         message << "#{system_exit.message} #{system_exit.backtrace}"
       end
     }
-    if message.start_with?('FAILURE')
+    if message.start_with?("FAILURE")
       block_given? ? yield(message) : STDERR.puts(message)
     end
     out
   end
-
 end