metric_fu 4.11.1 → 4.13.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    NjRkYzc2YTUyMTE0NzdkNTIxNmVhMTlkMGUzNzQ5NTIzYjY5N2JhNw==
-  data.tar.gz: !binary |-
-    YjYyYWU0YTk5NjE5ZDM4M2I1ZmVlNWY2ODM4NzM3Y2M4MTUwM2IxZQ==
+SHA256:
+  metadata.gz: 8ff6ebbe956db6bea6a6c659009c6b6d82cfd55bb307bab83fef44c84bc5ab62
+  data.tar.gz: f6c2186a24106cdaedebb726b1d6105bfa78133fa0634680312a432b1c6a6e4e
 SHA512:
-  metadata.gz: !binary |-
-    MjJmZjc0N2U3NmI1YTU3YTQwYmE3NjM2NTBhNDY0MmYzMmM2MTQyZjYxNmJj
-    OTM3ZmE1ODlmZjg1Yjg0MDZlYTNiZWNiZjAyMTM5MmQ0MThjNzJmMzkzODcy
-    YjcyZjA3YTYwNGE3ODQ0NzE5NjEwN2FiMWJlNTMyNjIyNjBkZWE=
-  data.tar.gz: !binary |-
-    YjA1NmJmMDZiYzc2ZDBkODVmNDliNWFkMDllZmQyMTk2NGNhN2YwNTFlNzcx
-    NzI3OGNkMDNmMGFhYjZjYWU5YTFjYmNkYTFlZDM0M2VkNGNlNmRmMmFmN2Iy
-    ZWVmNGRmNWQ2MmIxNDQ0MDg3MzFlZWM5MzM0MGVlZTYxNzM5MWQ=
+  metadata.gz: 727a55955630636b8c5a6e47e88a985f45fd33c1f5e5242a5cea410704b2eb9d4caf802a2a06f49b9f333ffc89be4792a73d322eb64e5f8d31505e677dd37c5a
+  data.tar.gz: 3f8687c5f52822478f00a675ece026125113898c2229fe3be251453d9b4cb4b27fdaa76b4ea85b9b9735339dce5e489c842379cf4dede48083013db028f89395

data/.gitignore

@@ -20,3 +20,9 @@ tmp
 *.swp
 tags
 .idea
+
+# rvm
+.ruby-version
+.ruby-gemset
+
+.overcommit.yml

data/.rubocop.yml

@@ -0,0 +1,15 @@
+inherit_from:
+  - config/rubocop.yml
+  - .rubocop_todo.yml
+
+# Files you want to exclude
+AllCops:
+  Exclude:
+    - bin/*
+    - gem_tasks/*
+    - lib/tasks/*
+    - Gemfile
+    - Rakefile
+    - bundle/**/*
+    - vendor/bundle/**/*
+    - spec/fixtures/line_numbers/*

data/.rubocop_todo.yml

@@ -0,0 +1,69 @@
+# This configuration was generated by `rubocop --auto-gen-config`
+# on 2015-01-27 12:05:28 -0600 using RuboCop version 0.28.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Configuration parameters: AlignWith, SupportedStyles.
+Lint/EndAlignment:
+  Enabled: false
+
+# Offense count: 2
+Lint/EnsureReturn:
+  Enabled: false
+
+# Offense count: 1
+Lint/RescueException:
+  Enabled: false
+
+# Offense count: 10
+Lint/ShadowingOuterLocalVariable:
+  Enabled: false
+
+# Offense count: 1
+Lint/UselessAccessModifier:
+  Enabled: false
+
+# Offense count: 27
+Lint/UselessAssignment:
+  Enabled: false
+
+# Offense count: 44
+Metrics/AbcSize:
+  Max: 56
+
+# Offense count: 393
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 709
+
+# Offense count: 3
+Metrics/PerceivedComplexity:
+  Max: 13
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/AndOr:
+  Enabled: false
+
+# Offense count: 2
+Style/EmptyElse:
+  Enabled: false
+
+# Offense count: 2
+# Configuration parameters: NamePrefix, NamePrefixBlacklist.
+Style/PredicateName:
+  Enabled: false
+
+# Offense count: 1
+Style/RescueModifier:
+  Enabled: false
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAsExpressionSeparator.
+Style/Semicolon:
+  Enabled: false

data/.simplecov

@@ -1,5 +1,7 @@
 # https://github.com/colszowka/simplecov#using-simplecov-for-centralized-config
 # see https://github.com/colszowka/simplecov/blob/master/lib/simplecov/defaults.rb
+# vim: set ft=ruby
+@minimum_coverage = ENV.fetch("COVERAGE_MINIMUM") { 87.8 }.to_f.round(2)
 if SimpleCov.respond_to?(:profiles)
   SimpleCov.profiles
 else
@@ -31,12 +33,42 @@ end.define 'metric_fu' do
 
   # Exclude these paths from analysis
   add_filter 'bundle'
+  add_filter 'vendor/bundle'
   add_filter 'bin'
   add_filter 'lib/metric_fu/tasks'
+
+  # https://github.com/colszowka/simplecov/blob/v0.9.1/lib/simplecov/defaults.rb#L60
+  # minimum_coverage @minimum_coverage
 end
-SimpleCov.at_exit do
-  File.open(File.join(SimpleCov.coverage_path, 'coverage_percent.txt'), 'w') do |f|
-    f.write SimpleCov.result.covered_percent
+
+## RUN SIMPLECOV
+if defined?(@running_tests)
+  @running_tests = false
+else
+  @running_tests = caller.any? {|line| line =~ /exe\/rspec/ }
+end
+if ENV["COVERAGE"] =~ /\Atrue\z/i
+  puts "[COVERAGE] Running with SimpleCov HTML Formatter"
+  formatters = [SimpleCov::Formatter::HTMLFormatter]
+  begin
+    puts '[COVERAGE] Running with SimpleCov HTML Formatter'
+    require 'metric_fu/metrics/rcov/simplecov_formatter'
+    formatters << SimpleCov::Formatter::MetricFu
+    puts '[COVERAGE] Running with SimpleCov MetricFu Formatter'
+  rescue LoadError
+    puts '[COVERAGE] SimpleCov MetricFu formatter could not be loaded'
   end
+  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[ *formatters ]
+  SimpleCov.start "metric_fu" if @running_tests
+else
+  SimpleCov.formatters = []
+end
+SimpleCov.at_exit do
   SimpleCov.result.format!
+  percent = Float(SimpleCov.result.covered_percent)
+  if percent < @minimum_coverage
+    abort "Spec coverage was not high enough: #{percent.round(2)} is < #{@minimum_coverage}%"
+  else
+    puts "Nice job! Spec coverage is still above #{@minimum_coverage}%"
+  end
 end

data/.travis.yml

@@ -1,22 +1,18 @@
 language: ruby
-bundler_args: --path vendor/bundle
+bundler_args: --path vendor/bundle --jobs=3 --retry=3
 script: bundle exec rspec
 cache: bundler
-gemfile:
-  - gemfiles/Gemfile.travis
+
 before_install:
   - gem install bundler
   - bundle config --local without local_development yard guard
 rvm:
   # 2.1, not 2.1.0 until fixed https://github.com/travis-ci/travis-ci/issues/2220
-  - 2.1
-  - 2.0.0
-  - 1.9.3
-  - 1.9.2
+  - 2.5
+  - 2.6
+  - 2.7
   - jruby
-  - "rbx-2"
 matrix:
   allow_failures:
-    - rvm: rbx-2
-    - rvm: 2.1
+    - rvm: jruby
   fast_finish: true

data/CONTRIBUTORS

@@ -8,9 +8,9 @@ Dan Mayer
 Robin Curry
 Sean Soper
 Delwyn de Villiers
+Martin Gotink
 Carl Youngblood
 Andre Arko
-Martin Gotink
 Chris Griego
 Sathish
 Michael Stark
@@ -21,6 +21,7 @@ jscruggs
 David Chelimsky
 adrien
 Jay Zeschin
+Greg Allen
 Alex Rothenberg
 calveto
 Avdi Grimm
@@ -31,12 +32,13 @@ Josef Šimánek
 Andy Gregorowicz
 Tarsoly András
 Benjamin Fleischer / Paul Swagerty
-unknown
 Nick Veys
+unknown
+Micah Geisel
 Extrovert
 Ben Turner
-KAKUTANI Shintaro
 Andrew Timberlake
+KAKUTANI Shintaro
 Guilherme Souza
 Przemysław Dąbek
 carlost
@@ -44,8 +46,8 @@ David Barri
 Beau Fabry
 Chris Mason
 Andrew Selder
-Mark Wilden
 iain
+Mark Wilden
 Alessandro Dias
 Lars E. Hoeg
 Eric Wollesen
@@ -60,16 +62,15 @@ khall
 Stefan Huber
 Todd A. Jacobs
 jayzes
-Bitdeli Chef
 Hans Hasselberg
 Scyllinice
+Bitdeli Chef
+René Föhring
 Matthew Gordon
-Guilherme Simões
 factorylabs
-Greg Allen
+Mike Ball
+Guilherme Simões
+Paul Elliott
+Joel Nimety
 Chris Ian Fiel
 Mike Szyndel
-Joel Nimety
-René Föhring
-Paul Elliott
-Mike Ball

data/Gemfile

@@ -1,39 +1,58 @@
 # encoding: utf-8
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
-group :test, :local_development  do
-  gem 'pry'
-  gem 'pry-nav'
-end
-
-gemspec :path => File.expand_path('..', __FILE__)
+if RUBY_VERSION >= '1.9.3'
+  gem "rubocop", platforms: :mri, groups: [:test, :local_development]
+  gem "activesupport", "~> 4.2"
 
-# Added by devtools
-group :development do
-  gem 'rake',  '~> 10.1.0'
-  gem 'rspec', '~> 3.0.0.beta2'
-  gem 'yard',  '~> 0.8.7', group: :yard
+  if RUBY_VERSION > '2.3'
+    gem "json", ">= 2.0"
+  else
+    gem "json", "~> 1.7"
+  end
+  if RUBY_VERSION =~ /^2\.0\..*/
+    gem "unparser", "0.2.4"
+  elsif RUBY_VERSION =~ /^1\.9\.3.*/
+    gem "unparser", "0.2.4"
+    gem "json_pure", "2.0.1"
+    gem "mime-types", "2.99.3"
+    gem "rest-client", "1.8.0"
+    gem "addressable", "2.4.0"
+    gem "ffi", "1.9.14" # windows support
+  end
+elsif RUBY_VERSION =~ /^1\.9\.2.*/
+  # because of https://github.com/railsbp/rails_best_practices/blob/master/rails_best_practices.gemspec
+  gem "activesupport", "~> 3.2"
+  # because of https://github.com/troessner/reek/issues/334
+  gem "reek", "~> 1.4.0"
+  # rbp -> as -> i18n
+  gem "i18n", "0.6.11"
+  gem "parallel", "= 1.3.3" # 1.3.4 disallows 1.9.2
+  gem "unparser", "0.1.5"
+  gem "json_pure", "2.0.1"
+  gem "mime-types", "2.99.3"
+  gem "rest-client", "1.8.0"
+  gem "json", "~> 1.7"
+  gem "addressable", "2.4.0"
+  gem "rainbow", "2.1.0"
+  gem "ffi", "1.9.14" # windows support
 end
 
-group :guard do
-  gem 'guard',         '~> 1.8.1'
-  gem 'guard-bundler', '~> 1.0.0'
-  gem 'guard-rspec'
-
-  # file system change event handling
-  gem 'listen',     '~> 1.3.0'
-  gem 'rb-fchange', '~> 0.0.6', require: false
-  gem 'rb-fsevent', '~> 0.9.3', require: false
-  gem 'rb-inotify', '~> 0.9.0', require: false
-
-  # notification handling
-  gem 'libnotify',               '~> 0.8.0', require: false
-  gem 'rb-notifu',               '~> 0.0.4', require: false
-  gem 'terminal-notifier-guard', '~> 1.5.3', require: false
-end
+gemspec path: File.expand_path("..", __FILE__)
 
 platform :jruby do
   group :jruby do
-    gem 'jruby-openssl', '~> 0.8.5'
+    gem "jruby-openssl", "~> 0.9.17"
   end
 end
+
+group :test, :local_development  do
+  gem "pry"
+  gem "pry-nav"
+end
+
+# Added by devtools
+group :development do
+  gem "rake",  "~> 10.1.0"
+  gem "yard",  "~> 0.8.7", group: :yard
+end

data/Guardfile

@@ -1,22 +1,22 @@
 guard :bundler do
-  watch('Gemfile')
-  watch('Gemfile.lock')
+  watch("Gemfile")
+  watch("Gemfile.lock")
   watch(%w{.+.gemspec\z})
 end
 
-guard :rspec, cli: File.read('.rspec').split.push('--fail-fast').join(' '), keep_failed: false do
+guard :rspec, cli: File.read(".rspec").split.push("--fail-fast").join(" "), keep_failed: false do
   # Run all specs if configuration is modified
-  watch('.rspec')              { 'spec' }
-  watch('Guardfile')           { 'spec' }
-  watch('Gemfile.lock')        { 'spec' }
-  watch('spec/spec_helper.rb') { 'spec' }
+  watch(".rspec")              { "spec" }
+  watch("Guardfile")           { "spec" }
+  watch("Gemfile.lock")        { "spec" }
+  watch("spec/spec_helper.rb") { "spec" }
 
   # Run all specs if supporting files are modified
-  watch(%r{\Aspec/(?:fixtures|lib|support|shared)/.+\.rb\z}) { 'spec' }
+  watch(%r{\Aspec/(?:fixtures|lib|support|shared)/.+\.rb\z}) { "spec" }
 
   # Run unit specs if associated lib code is modified
   watch(%r{\Alib/(.+)\.rb\z})     { |m| "spec/#{m[1]}_spec.rb" }
-  watch("lib/#{File.basename(File.expand_path('../', __FILE__))}.rb") { 'spec' }
+  watch("lib/#{File.basename(File.expand_path('../', __FILE__))}.rb") { "spec" }
 
   # Run a spec if it is modified
   watch(%r{\Aspec/.+_spec\.rb$\z})

data/HISTORY.md

@@ -4,13 +4,59 @@ Each change should fall into categories that would affect whether the release is
 
 As such, a _Feature_ would map to either major (breaking change) or minor. A _bug fix_ to a patch.  And _misc_ is either minor or patch, the difference being kind of fuzzy for the purposes of history.  Adding tests would be patch level.
 
-### Master [changes](https://github.com/metricfu/metric_fu/compare/v4.11.1...master)
+### [Unreleased](https://github.com/metricfu/metric_fu/compare/v4.13.0...master)
 
 * Breaking Changes
 * Features
 * Fixes
 * Misc
 
+### [4.13.0](https://github.com/metricfu/metric_fu/compare/v4.12.0...v4.13.0)
+
+* Features
+  * Setup CI pipeline on AppVeyor and fixed specs. (Rasmus Bergholdt, #285, fixes #284)
+  * Upgraded roodi to v5.0.0 (Jonathan Keam, #287)
+  * Updated jruby-openssl and removed unused rb-notifu gem (Jonathan Keam, #290)
+* Fixes
+  * Rails best practices options (Noah S-W, #264, #263)
+  * Fix deprecation warnings for Dir.exists? (Jared Szechy, #269)
+  * Fix specs (Luciano Sousa, #270)
+  * Fixed broken dependencies (Jonathan Keam, #279)
+  * FlogCli.flog must receive an expanded list of files (Rasmus Bergholdt, #282, fixes #273)
+  * Fix test warnings (Jonathan Keam, #289, addresses #288)
+* Misc
+  * Add a Gitter chat badge to README.md (#259)
+
+### [4.12.0](https://github.com/metricfu/metric_fu/compare/v4.11.4...v4.12.0)
+
+* Features
+  * Add line numbers to reek output. (ggallen, #255)
+  * Use reek directly. (Martin Gotink, #258)
+  * Add support for reek 2. (Martin Gotink, #258)
+* Fixes
+  * Use same styling for covered as ignored lines. (Martin Gotink, #254)
+
+### [4.11.4](https://github.com/metricfu/metric_fu/compare/v4.11.3...v4.11.4)
+
+* Fixes
+  * Hash hotspots output filenames. (Martin Gotink, #247, fixes #246)
+  * Fix invalid file links for rails best practices (Martin Gotink, #248)
+  * Add file links to cane and saikuro reports (Martin Gotink, #248)
+  * Fix incorrectly displaying not covered lines. (Martin Gotink, #249)
+  * Fix simplecov missing logger dependency. (Martin Gotink, #250, fixes #235)
+
+### [4.11.3](https://github.com/metricfu/metric_fu/compare/v4.11.2...v4.11.3)
+
+* Fixes
+  * Fix incorrectly passing --config option to reek. (Martin Gotink, #243, fixes #242)
+
+### [4.11.2](https://github.com/metricfu/metric_fu/compare/v4.11.1...v4.11.2)
+
+* Fixes
+  * Use reek as library, otherwise reek >= 1.6.2 hangs while reading input from stdin. (Martin Gotink, #240, fixes #239)
+* Misc
+  * Refactor MetricFu::Templates::MetricsTemplate#write into a composed method. (#237)
+
 ### [4.11.1](https://github.com/metricfu/metric_fu/compare/v4.11.0...v4.11.1)
 
 * Fixes