metric_fu 4.11.1 → 4.13.0

data/spec/metric_fu/metrics/flay/grapher_spec.rb

@@ -1,5 +1,5 @@
 require "spec_helper"
-MetricFu.metrics_require { 'flay/grapher' }
+MetricFu.metrics_require { "flay/grapher" }
 
 describe FlayGrapher do
   before :each do
@@ -49,7 +49,7 @@ describe FlayGrapher do
       end
 
       it "should update labels with the date" do
-        expect(@flay_grapher.labels).to receive(:update).with({ 0 => "1/2" })
+        expect(@flay_grapher.labels).to receive(:update).with(0 => "1/2")
         @flay_grapher.get_metrics(@metrics, @date)
       end
     end

data/spec/metric_fu/metrics/flog/configuration_spec.rb

@@ -1,20 +1,18 @@
-require 'spec_helper'
-require 'shared/configured'
-
-describe MetricFu::Configuration, 'for flog' do
-  it_behaves_like 'configured' do
+require "spec_helper"
+require "shared/configured"
 
+describe MetricFu::Configuration, "for flog" do
+  it_behaves_like "configured" do
     if MetricFu.configuration.mri?
-      it 'should set @flog to {:dirs_to_flog => @code_dirs}' do
-        load_metric 'flog'
-        expect(MetricFu::Metric.get_metric(:flog).run_options).to eq({
-          :all => true,
-         :continue => true,
-         :dirs_to_flog => ["lib"],
-         :quiet => true
-         })
+      it "should set @flog to {:dirs_to_flog => @code_dirs}" do
+        load_metric "flog"
+        expect(MetricFu::Metric.get_metric(:flog).run_options).to eq(
+          all: true,
+          continue: true,
+          dirs_to_flog: ["lib"],
+          quiet: true
+         )
       end
     end
-
   end
 end

data/spec/metric_fu/metrics/flog/generator_spec.rb

@@ -1,8 +1,7 @@
 require "spec_helper"
-MetricFu.metrics_require { 'flog/generator' }
+MetricFu.metrics_require { "flog/generator" }
 
 describe MetricFu::FlogGenerator do
-
   break if metric_not_activated?(:flog)
 
   before :each do
@@ -13,9 +12,10 @@ describe MetricFu::FlogGenerator do
 
   describe "emit method" do
     it "should look for files and flog them" do
-      expect(FlogCLI).to receive(:parse_options).with(["--all","--continue"]).and_return("options")
-      expect(FlogCLI).to receive(:new).with("options").and_return(flogger = double('flogger'))
-      expect(flogger).to receive(:flog).with("lib")
+      expect(FlogCLI).to receive(:parse_options).with(["--all", "--continue"]).and_return("options")
+      expect(FlogCLI).to receive(:new).with("options").and_return(flogger = double("flogger"))
+      files_to_flog = Dir[File.join('lib', '**/*.{rb,rake}')]
+      expect(flogger).to receive(:flog).with(*files_to_flog)
       @flog.emit
     end
   end
@@ -25,34 +25,34 @@ describe MetricFu::FlogGenerator do
       first_full_method_name = "ClassName#first_method_name"
       second_full_method_name = "ClassName#second_method_name"
 
-      flogger = double('flogger', :method_locations => {first_full_method_name => '/file/location.rb:11',
-                                                      second_full_method_name => '/file/location.rb:22'},
-                                :totals => {first_full_method_name => 11.11,
-                                            second_full_method_name => 22.22})
+      flogger = double("flogger", method_locations: { first_full_method_name => "/file/location.rb:11",
+                                                      second_full_method_name => "/file/location.rb:22" },
+                                  totals: { first_full_method_name => 11.11,
+                                            second_full_method_name => 22.22 })
       expect(flogger).to receive(:calculate)
       expect(flogger).to receive(:each_by_score).and_yield(
-        first_full_method_name, 11.11, {:branch => 11.1, :puts => 1.1}
+        first_full_method_name, 11.11, branch: 11.1, puts: 1.1
       ).and_yield(
-        second_full_method_name, 22.22, {:branch => 22.2, :puts => 2.2}
+        second_full_method_name, 22.22, branch: 22.2, puts: 2.2
       )
       @flog.instance_variable_set(:@flogger, flogger)
       @flog.analyze
       method_containers = @flog.instance_variable_get(:@method_containers)
       expect(method_containers.size).to eq(1)
 
-      expected={:methods=>{"ClassName#first_method_name" => { :path=>"/file/location.rb:11",
-                                                              :score=>11.11,
-                                                              :operators=>{ :branch=>11.1,
-                                                                            :puts=>1.1}},
-                           "ClassName#second_method_name" => {:path=>"/file/location.rb:22",
-                                                              :score=>22.22,
-                                                              :operators=>{ :branch=>22.2,
-                                                                            :puts=>2.2}}},
-                :path=>"/file/location.rb",
-                :average_score=>((11.11 + 22.22) / 2.0),
-                :total_score=>33.33,
-                :highest_score=>22.22,
-                :name=>"ClassName"}
+      expected = { methods: { "ClassName#first_method_name" => { path: "/file/location.rb:11",
+                                                                 score: 11.11,
+                                                                 operators: { branch: 11.1,
+                                                                              puts: 1.1 } },
+                              "ClassName#second_method_name" => { path: "/file/location.rb:22",
+                                                                  score: 22.22,
+                                                                  operators: { branch: 22.2,
+                                                                               puts: 2.2 } } },
+                   path: "/file/location.rb",
+                   average_score: ((11.11 + 22.22) / 2.0),
+                   total_score: 33.33,
+                   highest_score: 22.22,
+                   name: "ClassName" }
 
       expect(method_containers["ClassName"].to_h).to eq(expected)
     end
@@ -60,19 +60,18 @@ describe MetricFu::FlogGenerator do
 
   describe "to_h method" do
     it "should make-a nice hash" do
-      flogger = double('flogger', :total_score => 111.1, :average => 7.3)
+      flogger = double("flogger", total_score: 111.1, average: 7.3)
       @flog.instance_variable_set(:@flogger, flogger)
-      method_containers = {:ignore_me_1 =>  double('container_1', :highest_score => 11.1, :to_h => 'container_1'),
-                           :ignore_me_2 =>  double('container_2', :highest_score => 33.3, :to_h => 'container_2'),
-                           :ignore_me_3 =>  double('container_3', :highest_score => 22.2, :to_h => 'container_3')}
+      method_containers = { ignore_me_1: double("container_1", highest_score: 11.1, to_h: "container_1"),
+                            ignore_me_2: double("container_2", highest_score: 33.3, to_h: "container_2"),
+                            ignore_me_3: double("container_3", highest_score: 22.2, to_h: "container_3") }
       @flog.instance_variable_set(:@method_containers, method_containers)
 
-      expected = {:flog => { :total => 111.1,
-                  :average => 7.3,
-                  :method_containers => ['container_2', 'container_3', 'container_1']}}
+      expected = { flog: { total: 111.1,
+                           average: 7.3,
+                           method_containers: ["container_2", "container_3", "container_1"] } }
 
       expect(@flog.to_h).to eq(expected)
     end
-
   end
 end

data/spec/metric_fu/metrics/flog/grapher_spec.rb

@@ -1,11 +1,10 @@
 require "spec_helper"
-MetricFu.metrics_require { 'flog/grapher' }
+MetricFu.metrics_require { "flog/grapher" }
 
 describe MetricFu::FlogGrapher do
   before :each do
     MetricFu.configuration
     @flog_grapher = MetricFu::FlogGrapher.new
-
   end
 
   it "should respond to flog_total, flog_average and labels" do
@@ -26,12 +25,12 @@ describe MetricFu::FlogGrapher do
     before(:each) do
       methods = {}
       100.times do |i|
-        methods["method_name_#{i}"] = {:score => i.to_f}
+        methods["method_name_#{i}"] = { score: i.to_f }
       end
 
-      @metrics = {:flog => {:total => 111.1,
-                            :average => 7.7,
-                            :method_containers => [ {:methods => methods } ] } }
+      @metrics = { flog: { total: 111.1,
+                           average: 7.7,
+                           method_containers: [{ methods: methods }] } }
       @date = "1/2"
     end
 
@@ -48,7 +47,7 @@ describe MetricFu::FlogGrapher do
 
     context "when metrics were not generated" do
       before(:each) do
-        @metrics = FIXTURE.load_metric('metric_missing.yml')
+        @metrics = FIXTURE.load_metric("metric_missing.yml")
         @date = "1/2"
       end
 
@@ -70,7 +69,7 @@ describe MetricFu::FlogGrapher do
 
     context "when metrics have been generated" do
       before(:each) do
-        @metrics = FIXTURE.load_metric('20090630.yml')
+        @metrics = FIXTURE.load_metric("20090630.yml")
         @date = "1/2"
       end
 
@@ -86,7 +85,7 @@ describe MetricFu::FlogGrapher do
       end
 
       it "should update labels with the date" do
-        expect(@flog_grapher.labels).to receive(:update).with({ 0 => "1/2" })
+        expect(@flog_grapher.labels).to receive(:update).with(0 => "1/2")
         @flog_grapher.get_metrics(@metrics, @date)
       end
     end
@@ -105,5 +104,4 @@ describe MetricFu::FlogGrapher do
       @flog_grapher.get_metrics(@metrics, @date)
     end
   end
-
 end

data/spec/metric_fu/metrics/hotspots/analysis/analyzed_problems_spec.rb

@@ -1,8 +1,7 @@
-require 'spec_helper'
-MetricFu.metrics_require { 'hotspots/analysis/analyzed_problems' }
+require "spec_helper"
+MetricFu.metrics_require { "hotspots/analysis/analyzed_problems" }
 
 describe MetricFu::HotspotAnalyzedProblems do
-
   before do
     enable_hotspots
   end
@@ -13,7 +12,7 @@ describe MetricFu::HotspotAnalyzedProblems do
       common_columns = %w{metric}
       granularities =  %w{file_path class_name method_name}
       tool_analyzers = MetricFu::Hotspot.analyzers
-      analyzer_columns = common_columns + granularities + tool_analyzers.map{|analyzer| analyzer.columns}.flatten
+      analyzer_columns = common_columns + granularities + tool_analyzers.map(&:columns).flatten
 
       analyzer_tables = MetricFu::AnalyzerTables.new(analyzer_columns)
       tool_analyzers.each do |analyzer|
@@ -29,7 +28,6 @@ describe MetricFu::HotspotAnalyzedProblems do
   end
 
   context "with several types of data" do
-
     before do
       @result_hash = HOTSPOT_DATA["several_metrics.yml"]
       @analyzed_problems = analyzed_problems(@result_hash)
@@ -38,8 +36,8 @@ describe MetricFu::HotspotAnalyzedProblems do
 
     it "gives all issues for a class" do
       expected = {
-        :reek => "found 2 code smells",
-        :flog => "complexity is 37.9"
+        reek: "found 2 code smells",
+        flog: "complexity is 37.9"
       }
       # TODO Unsure if we want to make problems_with and location public or private at this point
       expect(@worst_items[:classes].first.problems).to eq(expected)
@@ -47,44 +45,42 @@ describe MetricFu::HotspotAnalyzedProblems do
 
     it "gives all issues for a method" do
       expected = {
-        :reek => "found 1 code smells",
-        :flog => "complexity is 37.9"}
+        reek: "found 1 code smells",
+        flog: "complexity is 37.9" }
       expect(@worst_items[:methods].first.problems).to eq(expected)
     end
 
     it "gives all issues for a file" do
       expected = {
-        :reek => "found 2 code smells" ,
-        :flog => "complexity is 37.9",
-        :churn => "detected high level of churn (changed 54 times)"}
+        reek: "found 2 code smells",
+        flog: "complexity is 37.9",
+        churn: "detected high level of churn (changed 54 times)" }
       expect(@worst_items[:files].first.problems).to eq(expected)
     end
 
     it "provide location for a method" do
       expected = MetricFu::Location.new("lib/client/client.rb",
-                              "Client",
-                              "Client#client_requested_sync")
+                                        "Client",
+                                        "Client#client_requested_sync")
       expect(@worst_items[:methods].first.location).to eq(expected)
     end
 
     it "provides location for a class" do
       expected = MetricFu::Location.new("lib/client/client.rb",
-                              "Client",
-                              nil)
+                                        "Client",
+                                        nil)
       expect(@worst_items[:classes].first.location).to eq(expected)
     end
 
     it "provides location for a file" do
       expected = MetricFu::Location.new("lib/client/client.rb",
-                              nil,
-                              nil)
+                                        nil,
+                                        nil)
       expect(@worst_items[:files].first.location).to eq(expected)
     end
-
   end
 
   context "with Saikuro data" do
-
     before do
       @result_hash = HOTSPOT_DATA["saikuro.yml"]
       @analyzed_problems = analyzed_problems(@result_hash)
@@ -93,18 +89,16 @@ describe MetricFu::HotspotAnalyzedProblems do
 
     it "gives complexity for method" do
       expected = {
-        :saikuro => "complexity is 1.0"
+        saikuro: "complexity is 1.0"
       }
       expect(@worst_items[:methods].last.problems).to eq(expected)
     end
 
     it "gives average complexity for class" do
       expected = {
-        :saikuro => "average complexity is 5.0"
+        saikuro: "average complexity is 5.0"
       }
       expect(@worst_items[:classes].last.problems).to eq(expected)
     end
-
   end
-
 end

data/spec/metric_fu/metrics/hotspots/analysis/analyzer_tables_spec.rb

@@ -1,8 +1,7 @@
-require 'spec_helper'
-MetricFu.metrics_require { 'hotspots/analysis/analyzer_tables' }
+require "spec_helper"
+MetricFu.metrics_require { "hotspots/analysis/analyzer_tables" }
 
 describe MetricFu::AnalyzerTables do
-
   before do
     enable_hotspots
   end
@@ -13,7 +12,7 @@ describe MetricFu::AnalyzerTables do
       common_columns = %w{metric}
       granularities =  %w{file_path class_name method_name}
       tool_analyzers = MetricFu::Hotspot.analyzers
-      analyzer_columns = common_columns + granularities + tool_analyzers.map{|analyzer| analyzer.columns}.flatten
+      analyzer_columns = common_columns + granularities + tool_analyzers.map(&:columns).flatten
 
       analyzer_tables = MetricFu::AnalyzerTables.new(analyzer_columns)
       tool_analyzers.each do |analyzer|
@@ -28,31 +27,28 @@ describe MetricFu::AnalyzerTables do
   end
 
   context "with Stats data" do
-
     before do
       @result_hash = HOTSPOT_DATA["stats.yml"]
       @table = analyzer_table(@result_hash).table
     end
 
     it "should have codeLOC" do
-      row = @table.find{|row| row['stat_name'] == :codeLOC}
-      expect(row['stat_value']).to eq(4222)
+      row = @table.find { |row| row["stat_name"] == :codeLOC }
+      expect(row["stat_value"]).to eq(4222)
     end
 
     it "should have testLOC" do
-      row = @table.find{|row| row['stat_name'] == :testLOC}
-      expect(row['stat_value']).to eq(2111)
+      row = @table.find { |row| row["stat_name"] == :testLOC }
+      expect(row["stat_value"]).to eq(2111)
     end
 
     it "should have code_to_test_ratio" do
-      row = @table.find{|row| row['stat_name'] == :code_to_test_ratio}
-      expect(row['stat_value']).to eq(2)
+      row = @table.find { |row| row["stat_name"] == :code_to_test_ratio }
+      expect(row["stat_value"]).to eq(2)
     end
-
   end
 
   context "with three different path representations of file (from Saikuro, Flog, and Reek)" do
-
     before do
       @result_hash = HOTSPOT_DATA["three_metrics_on_same_file.yml"]
       @table = analyzer_table(@result_hash).table
@@ -60,17 +56,16 @@ describe MetricFu::AnalyzerTables do
 
     specify "all records should have full file_path" do
       @table.each do |row|
-        expect(row['file_path']).to eq('lib/client/client.rb')
+        expect(row["file_path"]).to eq("lib/client/client.rb")
       end
     end
 
     specify "all records should have class name" do
-      expect(@table.select{|rows| rows.fetch(:class_name, :no_key) == nil }.size).to eq(0)
+      expect(@table.select { |rows| rows.fetch(:class_name, :no_key) == nil }.size).to eq(0)
     end
 
     specify "one record should not have method name" do
-      expect(@table.select{|rows| rows.fetch(:method_name, :no_key) == nil }.size).to eq(0)
+      expect(@table.select { |rows| rows.fetch(:method_name, :no_key) == nil }.size).to eq(0)
     end
-
   end
 end

data/spec/metric_fu/metrics/hotspots/analysis/ranking_spec.rb

@@ -1,16 +1,14 @@
 require "spec_helper"
-MetricFu.metrics_require { 'hotspots/analysis/ranking' }
+MetricFu.metrics_require { "hotspots/analysis/ranking" }
 
 describe MetricFu::Ranking do
-
   context "with many items" do
-
     specify "#top" do
       ranking = Ranking.new
       ranking[:a] = 10
       ranking[:b] = 50
       ranking[:c] = 1
-      expect(ranking.top).to eq([:b,:a, :c])
+      expect(ranking.top).to eq([:b, :a, :c])
     end
 
     specify "lowest item is at 0 percentile" do
@@ -28,7 +26,5 @@ describe MetricFu::Ranking do
       ranking[:d] = 5
       expect(ranking.percentile(:b)).to eq(0.75)
     end
-
   end
-
 end

data/spec/metric_fu/metrics/hotspots/analysis/rankings_spec.rb

@@ -1,8 +1,7 @@
-require 'spec_helper'
-MetricFu.metrics_require { 'hotspots/analysis/rankings' }
+require "spec_helper"
+MetricFu.metrics_require { "hotspots/analysis/rankings" }
 
 describe MetricFu::HotspotRankings do
-
   before do
     enable_hotspots
   end
@@ -14,7 +13,7 @@ describe MetricFu::HotspotRankings do
       common_columns = %w{metric}
       granularities =  %w{file_path class_name method_name}
       tool_analyzers = MetricFu::Hotspot.analyzers
-      analyzer_columns = common_columns + granularities + tool_analyzers.map{|analyzer| analyzer.columns}.flatten
+      analyzer_columns = common_columns + granularities + tool_analyzers.map(&:columns).flatten
 
       analyzer_tables = MetricFu::AnalyzerTables.new(analyzer_columns)
       tool_analyzers.each do |analyzer|
@@ -30,8 +29,8 @@ describe MetricFu::HotspotRankings do
   context "with several types of data" do
     it "gives all files, in order, from worst to best" do
       expected = [
-                  "lib/client/client.rb",
-                  "lib/client/foo.rb"]
+        "lib/client/client.rb",
+        "lib/client/foo.rb"]
       expect(rankings(result_hash).worst_files).to eq(expected)
     end
     def result_hash
@@ -39,7 +38,6 @@ describe MetricFu::HotspotRankings do
     end
   end
   context "with Reek data" do
-
     before do
       @result_hash = HOTSPOT_DATA["reek.yml"]
     end
@@ -55,10 +53,8 @@ describe MetricFu::HotspotRankings do
     it "gives worst file" do
       expect(rankings(@result_hash).worst_files[0]).to eq("lib/client/client.rb")
     end
-
   end
   context "with Saikuro data" do
-
     before do
       @result_hash = HOTSPOT_DATA["saikuro.yml"]
     end
@@ -70,10 +66,8 @@ describe MetricFu::HotspotRankings do
     it "gives worst class" do
       expect(rankings(@result_hash).worst_classes[0]).to eq("Bitly")
     end
-
   end
   context "with Flog data" do
-
     before do
       @result_hash = HOTSPOT_DATA["flog.yml"]
     end
@@ -89,11 +83,9 @@ describe MetricFu::HotspotRankings do
     it "gives worst file" do
       expect(rankings(@result_hash).worst_files[0]).to eq("lib/generators/rcov.rb:57")
     end
-
   end
 
   context "with Roodi data" do
-
     before do
       @result_hash = HOTSPOT_DATA["roodi.yml"]
     end
@@ -101,6 +93,5 @@ describe MetricFu::HotspotRankings do
     it "gives worst file" do
       expect(rankings(@result_hash).worst_files[0]).to eq("lib/client/client.rb")
     end
-
   end
 end