message_train 0.5.2 → 0.5.3

data/spec/controllers/message_train/boxes_controller_spec.rb

@@ -5,15 +5,29 @@ describe MessageTrain::BoxesController do
   include ControllerMacros
   routes { MessageTrain::Engine.routes }
 
-  let(:valid_params) { { 'conversations' => {unread_conversation.id.to_s => unread_conversation.id} } }
-  let(:invalid_params) { { 'conversations' => {'999' => 999} } }
-  let(:disallowed_params) { { 'conversations' => {someone_elses_conversation.id.to_s => someone_elses_conversation.id} } }
+  let(:valid_params) do
+    {
+      'conversations' => {
+        unread_conversation.id.to_s => unread_conversation.id
+      }
+    }
+  end
+  let(:invalid_params) do
+    { 'conversations' => { '999' => 999 } }
+  end
+  let(:disallowed_params) do
+    {
+      'conversations' => {
+        someone_elses_conversation.id.to_s => someone_elses_conversation.id
+      }
+    }
+  end
 
   before do
     login_user first_user
   end
 
-  describe "GET #show" do
+  describe 'GET #show' do
     before do
       get :show, division: 'in'
     end
@@ -31,18 +45,31 @@ describe MessageTrain::BoxesController do
     end
   end
 
-  describe "PATCH/PUT #update" do
+  describe 'PATCH/PUT #update' do
     describe 'with invalid params' do
       before do
-        put :update, division: 'in', mark_to_set: 'read', objects: invalid_params
+        put(
+          :update,
+          division: 'in',
+          mark_to_set: 'read',
+          objects: invalid_params
+        )
       end
       it_should_behave_like 'a 404 Not Found error'
     end
     describe 'with disallowed params' do
       before do
-        put :update, division: 'in', mark_to_set: 'read', objects: disallowed_params
+        put(
+          :update,
+          division: 'in',
+          mark_to_set: 'read',
+          objects: disallowed_params
+        )
       end
-      it_should_behave_like 'a page with an error message matching', /Access to Conversation \d+ denied/
+      it_should_behave_like(
+        'a page with an error message matching',
+        /Access to Conversation \d+ denied/
+      )
     end
     describe 'without params' do
       before do
@@ -58,10 +85,15 @@ describe MessageTrain::BoxesController do
     end
   end
 
-  describe "DELETE #destroy" do
+  describe 'DELETE #destroy' do
     describe 'with invalid params' do
       before do
-        delete :destroy, division: 'in', mark_to_set: 'ignore', objects: invalid_params
+        delete(
+          :destroy,
+          division: 'in',
+          mark_to_set: 'ignore',
+          objects: invalid_params
+        )
       end
       it_should_behave_like 'a 404 Not Found error'
     end
@@ -74,16 +106,32 @@ describe MessageTrain::BoxesController do
     describe 'with valid params' do
       context 'ignoring' do
         before do
-          delete :destroy, division: 'in', mark_to_set: 'ignore', objects: valid_params
+          delete(
+            :destroy,
+            division: 'in',
+            mark_to_set: 'ignore',
+            objects: valid_params
+          )
         end
-        it_should_behave_like 'a page with a notice message', 'Update successful'
+        it_should_behave_like(
+          'a page with a notice message',
+          'Update successful'
+        )
       end
       context 'unignoring' do
         before do
-          delete :destroy, division: 'in', mark_to_set: 'unignore', objects: valid_params
+          delete(
+            :destroy,
+            division: 'in',
+            mark_to_set: 'unignore',
+            objects: valid_params
+          )
         end
-        it_should_behave_like 'a page with a notice message', 'Update successful'
+        it_should_behave_like(
+          'a page with a notice message',
+          'Update successful'
+        )
       end
     end
   end
-end
+end

data/spec/controllers/message_train/concerns_spec.rb

@@ -5,21 +5,17 @@ describe MessageTrain::BoxesController do
   include ControllerMacros
   routes { MessageTrain::Engine.routes }
 
-  describe "GET #show"  do
-    # describe 'when not logged in' do
-    #   before do
-    #     access_anonymous
-    #     get :show, division: 'in'
-    #   end
-    #   it_should_behave_like 'a redirect with error', '/users/sign_in', 'You must sign in or sign up to continue.'
-    # end
-
+  describe 'GET #show' do
     describe 'when neither sending nor receiving is allowed' do
       before do
         login_user third_user
         get :show, division: 'in', collective_id: 'groups:first-group'
       end
-      it_should_behave_like 'a redirect with error', '/', 'Access to that box denied'
+      it_should_behave_like(
+        'a redirect with error',
+        '/',
+        'Access to that box denied'
+      )
     end
 
     describe 'when only sending is allowed' do
@@ -27,7 +23,11 @@ describe MessageTrain::BoxesController do
         login_user first_user
         get :show, division: 'in', collective_id: 'groups:first-group'
       end
-      it_should_behave_like 'a redirect with error', '/collectives/groups:first-group/box/sent', 'Access to that box denied'
+      it_should_behave_like(
+        'a redirect with error',
+        '/collectives/groups:first-group/box/sent',
+        'Access to that box denied'
+      )
     end
 
     describe 'when only receiving is allowed' do
@@ -35,7 +35,11 @@ describe MessageTrain::BoxesController do
         login_user first_user
         get :show, division: 'sent', collective_id: 'groups:membered-group'
       end
-      it_should_behave_like 'a redirect with error', '/collectives/groups:membered-group/box/in', 'Access to that box denied'
+      it_should_behave_like(
+        'a redirect with error',
+        '/collectives/groups:membered-group/box/in',
+        'Access to that box denied'
+      )
     end
   end
-end
+end

data/spec/controllers/message_train/conversations_controller_spec.rb

@@ -5,14 +5,18 @@ describe MessageTrain::ConversationsController do
   include ControllerMacros
   routes { MessageTrain::Engine.routes }
 
-  let(:valid_params) { { 'messages' => {unread_message.id.to_s => unread_message.id} } }
-  let(:invalid_params) { { 'messages' => {'999999' => 999999} } }
+  let(:valid_params) do
+    { 'messages' => { unread_message.id.to_s => unread_message.id } }
+  end
+  let(:invalid_params) do
+    { 'messages' => { '999999' => 999_999 } }
+  end
 
   before do
     login_user first_user
   end
 
-  describe "GET #show" do
+  describe 'GET #show' do
     before do
       get :show, box_division: 'in', id: unread_conversation.id
     end
@@ -34,10 +38,16 @@ describe MessageTrain::ConversationsController do
     end
   end
 
-  describe "PATCH/PUT #update" do
+  describe 'PATCH/PUT #update' do
     describe 'with invalid params' do
       before do
-        put :update, box_division: 'in', id: unread_conversation.id, mark_to_set: 'read', objects: invalid_params
+        put(
+          :update,
+          box_division: 'in',
+          id: unread_conversation.id,
+          mark_to_set: 'read',
+          objects: invalid_params
+        )
       end
       it_should_behave_like 'a 404 Not Found error'
     end
@@ -49,13 +59,19 @@ describe MessageTrain::ConversationsController do
     end
     describe 'with valid params' do
       before do
-        put :update, box_division: 'in', id: unread_conversation.id, mark_to_set: 'read', objects: valid_params
+        put(
+          :update,
+          box_division: 'in',
+          id: unread_conversation.id,
+          mark_to_set: 'read',
+          objects: valid_params
+        )
       end
       it_should_behave_like 'a page with a notice message', 'Update successful'
     end
   end
 
-  describe "DELETE #destroy" do
+  describe 'DELETE #destroy' do
     describe 'with invalid params' do
       before do
         delete :destroy, box_division: 'in', id: 999, mark_to_set: 'ignore'
@@ -71,16 +87,32 @@ describe MessageTrain::ConversationsController do
     describe 'with valid params' do
       context 'ignoring' do
         before do
-          delete :destroy, box_division: 'in', id: unread_conversation.id, mark_to_set: 'ignore'
+          delete(
+            :destroy,
+            box_division: 'in',
+            id: unread_conversation.id,
+            mark_to_set: 'ignore'
+          )
         end
-        it_should_behave_like 'a page with a notice message', 'Update successful'
+        it_should_behave_like(
+          'a page with a notice message',
+          'Update successful'
+        )
       end
       context 'unignoring' do
         before do
-          delete :destroy, box_division: 'in', id: unread_conversation.id, mark_to_set: 'unignore'
+          delete(
+            :destroy,
+            box_division: 'in',
+            id: unread_conversation.id,
+            mark_to_set: 'unignore'
+          )
         end
-        it_should_behave_like 'a page with a notice message', 'Update successful'
+        it_should_behave_like(
+          'a page with a notice message',
+          'Update successful'
+        )
       end
     end
   end
-end
+end

data/spec/controllers/message_train/messages_controller_spec.rb

@@ -8,23 +8,27 @@ describe MessageTrain::MessagesController do
   # This should return the minimal set of attributes required to create a valid
   # Dog. As you add validations to Dog, be sure to
   # adjust the attributes here as well.
-  let(:valid_attributes) {
-    { subject: 'Test Subject', recipients_to_save: {'users' => 'second-user, third-user'}, draft: false }
-  }
+  let(:valid_attributes) do
+    {
+      subject: 'Test Subject',
+      recipients_to_save: { 'users' => 'second-user, third-user' },
+      draft: false
+    }
+  end
 
-  let(:draft_attributes) {
-    { subject: 'Test Subject', recipients_to_save: {'users' => ''} }
-  }
+  let(:draft_attributes) do
+    { subject: 'Test Subject', recipients_to_save: { 'users' => '' } }
+  end
 
-  let(:invalid_attributes) {
+  let(:invalid_attributes) do
     { subject: nil }
-  }
+  end
 
   before do
     login_user first_user
   end
 
-  describe "GET #show" do
+  describe 'GET #show' do
     before do
       get :show, box_division: 'in', id: unread_message.id, format: :json
     end
@@ -41,9 +45,13 @@ describe MessageTrain::MessagesController do
     end
   end
 
-  describe "GET #new" do
+  describe 'GET #new' do
     before do
-      get :new, box_division: 'in', conversation_id: unread_message.message_train_conversation_id
+      get(
+        :new,
+        box_division: 'in',
+        conversation_id: unread_message.message_train_conversation_id
+      )
     end
     it_should_behave_like 'a successful page', which_renders: 'new'
 
@@ -59,7 +67,7 @@ describe MessageTrain::MessagesController do
     end
   end
 
-  describe "GET #edit" do
+  describe 'GET #edit' do
     describe 'as someone other than the owner' do
       before do
         get :edit, box_division: 'in', id: someone_elses_message.id
@@ -87,7 +95,7 @@ describe MessageTrain::MessagesController do
     end
   end
 
-  describe "POST #create" do
+  describe 'POST #create' do
     describe 'with valid attributes' do
       describe 'when draft' do
         before do
@@ -98,7 +106,7 @@ describe MessageTrain::MessagesController do
 
         context "sets the flash with an alert of the messages's draft status" do
           subject { flash[:alert] }
-          it { should eq 'Message saved as draft.'}
+          it { should eq 'Message saved as draft.' }
         end
       end
       describe 'when not draft' do
@@ -110,22 +118,30 @@ describe MessageTrain::MessagesController do
 
         context "sets the flash with a notice of the messages's creation" do
           subject { flash[:notice] }
-          it { should eq 'Message sent.'}
+          it { should eq 'Message sent.' }
         end
       end
     end
     describe 'with valid attributes, counting' do
       it 'results in a new conversation' do
-        expect { post :create, box_division: 'in', message: valid_attributes }.to change { MessageTrain::Conversation.count }.by(1)
+        expect do
+          post(:create, box_division: 'in', message: valid_attributes)
+        end.to change { MessageTrain::Conversation.count }.by(1)
       end
       it 'results in a new message' do
-        expect { post :create, box_division: 'in', message: valid_attributes }.to change { MessageTrain::Message.count }.by(1)
+        expect do
+          post(:create, box_division: 'in', message: valid_attributes)
+        end.to change { MessageTrain::Message.count }.by(1)
       end
       it 'results in new receipts' do
-        expect { post :create, box_division: 'in', message: valid_attributes }.to change { MessageTrain::Receipt.count }.by(3)
+        expect do
+          post(:create, box_division: 'in', message: valid_attributes)
+        end.to change { MessageTrain::Receipt.count }.by(3)
       end
       it 'results in email notifications' do
-        expect { post :create, box_division: 'in', message: valid_attributes }.to change { ActionMailer::Base.deliveries.count }.by(2)
+        expect do
+          post(:create, box_division: 'in', message: valid_attributes)
+        end.to change { ActionMailer::Base.deliveries.count }.by(2)
       end
     end
     describe 'with invalid params' do
@@ -141,58 +157,76 @@ describe MessageTrain::MessagesController do
 
       context "sets the flash with the message's errors" do
         subject { flash[:error] }
-        it { should eq "Subject can't be blank"}
+        it { should eq "Subject can't be blank" }
       end
     end
 
     describe 'with invalid params, counting' do
       it 'does not result in a new message' do
-        expect { post :create, box_division: 'in', message: invalid_attributes }.to_not change { MessageTrain::Message.count }
+        expect do
+          post :create, box_division: 'in', message: invalid_attributes
+        end.to_not change { MessageTrain::Message.count }
       end
     end
   end
 
-  describe "PUT #update" do
+  describe 'PUT #update' do
     describe 'as someone other than the owner' do
       before do
-        put :update, box_division: 'in', id: someone_elses_message.id, message: valid_attributes
+        put(
+          :update,
+          box_division: 'in',
+          id: someone_elses_message.id,
+          message: valid_attributes
+        )
       end
       it_should_behave_like 'a 404 Not Found error'
     end
     describe 'as the owner' do
       describe 'with invalid params' do
         before do
-          put :update, box_division: 'in', id: draft_message.id, message: invalid_attributes
+          put(
+            :update,
+            box_division: 'in',
+            id: draft_message.id,
+            message: invalid_attributes
+          )
         end
         it_should_behave_like 'a successful page', which_renders: 'edit'
-    
         context 'loads the given message into @message' do
           subject { assigns(:message) }
           it { should eq draft_message }
         end
-    
         context 'does not update @message' do
           subject { draft_message.reload }
           its(:subject) { should eq 'This should turn into a draft' }
         end
-    
         context "sets the flash with the message's errors" do
           subject { flash[:error] }
-          it { should eq "Subject can't be blank"}
+          it { should eq "Subject can't be blank" }
         end
       end
       describe 'with valid params' do
         describe 'when not a draft' do
           before do
-            put :update, box_division: 'in', id: sent_message.id, message: valid_attributes
+            put(
+              :update,
+              box_division: 'in',
+              id: sent_message.id,
+              message: valid_attributes
+            )
           end
           it_should_behave_like 'a 404 Not Found error'
         end
         describe 'when a draft' do
           describe 'and updating to not draft' do
-
             before do
-              put :update, box_division: 'in', id: draft_message.id, message: valid_attributes
+              put(
+                :update,
+                box_division: 'in',
+                id: draft_message.id,
+                message: valid_attributes
+              )
             end
             it_should_behave_like 'a redirect to', '/box/sent'
             it_should_behave_like 'a response without error'
@@ -202,22 +236,36 @@ describe MessageTrain::MessagesController do
               its(:subject) { should eq 'Test Subject' }
             end
 
-            context "sets no alert" do
+            context 'sets no alert' do
               subject { flash[:alert] }
               it { should be nil }
             end
 
             context "sets the flash with a notice of the message's update" do
               subject { flash[:notice] }
-              it { should eq 'Message sent.'}
+              it { should eq 'Message sent.' }
             end
           end
           describe 'and updating but keeping as a draft' do
-            let(:edited_draft_message) { { id: draft_message.id, subject: 'Still a draft', draft: 'Save As Draft' } }
+            let(:edited_draft_message) do
+              {
+                id: draft_message.id,
+                subject: 'Still a draft',
+                draft: 'Save As Draft'
+              }
+            end
             before do
-              put :update, box_division: 'in', id: draft_message.id, message: edited_draft_message
+              put(
+                :update,
+                box_division: 'in',
+                id: draft_message.id,
+                message: edited_draft_message
+              )
             end
-            it_should_behave_like 'a redirect matching', %r(/box/in/conversations/\d+)
+            it_should_behave_like(
+              'a redirect matching',
+              %r{/box/in/conversations/\d+}
+            )
             it_should_behave_like 'a response without error'
 
             context 'updates @message' do
@@ -225,19 +273,18 @@ describe MessageTrain::MessagesController do
               its(:subject) { should eq 'Still a draft' }
             end
 
-            context "sets no notice" do
+            context 'sets no notice' do
               subject { flash[:notice] }
               it { should be nil }
             end
 
             context "sets the flash with a alert of the message's update" do
               subject { flash[:alert] }
-              it { should eq 'Message saved as draft.'}
+              it { should eq 'Message saved as draft.' }
             end
           end
         end
       end
-      
     end
   end
-end
+end

data/spec/controllers/message_train/participants_controller_spec.rb

@@ -9,7 +9,7 @@ describe MessageTrain::ParticipantsController do
     login_user first_user
   end
 
-  describe "GET #index" do
+  describe 'GET #index' do
     describe 'with model to users' do
       before do
         get :index, box_division: 'in', model: 'users', format: :json
@@ -56,9 +56,15 @@ describe MessageTrain::ParticipantsController do
     end
   end
 
-  describe "GET #show" do
+  describe 'GET #show' do
     before do
-      get :show, box_division: 'in', model: 'users', id: first_user.id, format: :json
+      get(
+        :show,
+        box_division: 'in',
+        model: 'users',
+        id: first_user.id,
+        format: :json
+      )
     end
     it_should_behave_like 'a successful page', which_renders: 'show'
 
@@ -67,4 +73,4 @@ describe MessageTrain::ParticipantsController do
       it { should eq first_user }
     end
   end
-end
+end

data/spec/controllers/message_train/unsubscribes_controller_spec.rb

@@ -5,19 +5,19 @@ describe MessageTrain::UnsubscribesController do
   include ControllerMacros
   routes { MessageTrain::Engine.routes }
 
-  let(:valid_attributes) {
+  let(:valid_attributes) do
     { from_type: 'Group', from_id: membered_group.id }
-  }
+  end
 
-  let(:invalid_attributes) {
+  let(:invalid_attributes) do
     { from_type: 'Group', from_id: empty_group.id }
-  }
+  end
 
   before do
     login_user first_user
   end
 
-  describe "GET #index" do
+  describe 'GET #index' do
     before do
       get :index
     end
@@ -30,7 +30,7 @@ describe MessageTrain::UnsubscribesController do
     end
   end
 
-  describe "POST #create" do
+  describe 'POST #create' do
     describe 'with invalid attributes' do
       before do
         post :create, unsubscribe: invalid_attributes
@@ -41,30 +41,60 @@ describe MessageTrain::UnsubscribesController do
       before do
         post :create, unsubscribe: valid_attributes
       end
-      it_should_behave_like 'a redirect with a message', '/unsubscribes', notice: 'You are now unsubscribed from Membered Group, which means that you will not be notified by email of any messages received by that Group.'
+      it_should_behave_like(
+        'a redirect with a message',
+        '/unsubscribes',
+        notice: 'You are now unsubscribed from Membered Group, which means '\
+          'that you will not be notified by email of any messages received by '\
+          'that Group.'
+      )
       it_should_behave_like 'a response without error'
     end
     describe 'with :all set to true' do
       before do
         post :create, all: true
       end
-      it_should_behave_like 'a redirect with a message', '/unsubscribes', notice: 'You have unsubscribed from all messages, which means that you will not be notified by email of any messages received in any of your boxes.'
+      it_should_behave_like(
+        'a redirect with a message',
+        '/unsubscribes',
+        notice: 'You have unsubscribed from all messages, which means that '\
+          'you will not be notified by email of any messages received in any '\
+          'of your boxes.'
+      )
       it_should_behave_like 'a response without error'
     end
   end
 
-  describe "DELETE #destroy" do
+  describe 'DELETE #destroy' do
     describe 'with an id' do
       before do
-        delete :destroy, id: first_user.unsubscribes.where(from_type: 'Group', from_id: unsubscribed_group.id).first.id
+        delete(
+          :destroy,
+          id: first_user.unsubscribes.where(
+            from_type: 'Group',
+            from_id: unsubscribed_group.id
+          ).first.id
+        )
       end
-      it_should_behave_like 'a redirect with a message', '/unsubscribes', notice: 'You are no longer unsubscribed from Unsubscribed Group, which means that you will now be notified by email of any messages received in that Group.'
+      it_should_behave_like(
+        'a redirect with a message',
+        '/unsubscribes',
+        notice: 'You are no longer unsubscribed from Unsubscribed Group, '\
+          'which means that you will now be notified by email of any '\
+          'messages received in that Group.'
+      )
     end
     describe 'with :all set to true' do
       before do
         delete :destroy, all: true
       end
-      it_should_behave_like 'a redirect with a message', '/unsubscribes', notice: 'You are no longer unsubscribed from all messages, which means that you will now be notified by email of any messages received in boxes you are subscribed to.'
+      it_should_behave_like(
+        'a redirect with a message',
+        '/unsubscribes',
+        notice: 'You are no longer unsubscribed from all messages, which '\
+          'means that you will now be notified by email of any messages '\
+          'received in boxes you are subscribed to.'
+      )
     end
   end
-end
+end