message_train 0.5.2 → 0.5.3

data/config/routes.rb

@@ -1,10 +1,23 @@
 MessageTrain::Engine.routes.draw do
   concern :boxable do
-    resources :boxes, path: 'box', param: :division, only: [:show, :update, :destroy] do
+    resources(
+      :boxes,
+      path: 'box',
+      param: :division,
+      only: [:show, :update, :destroy]
+    ) do
       resources :conversations, only: [:show, :update, :destroy]
       resources :messages, except: [:index, :destroy]
-      get 'participants/:model', as: :model_participants, to: 'participants#index'
-      get 'participants/:model/:id', as: :model_participant, to: 'participants#show'
+      get(
+        'participants/:model',
+        as: :model_participants,
+        to: 'participants#index'
+      )
+      get(
+        'participants/:model/:id',
+        as: :model_participant,
+        to: 'participants#show'
+      )
     end
   end
 
@@ -16,18 +29,27 @@ MessageTrain::Engine.routes.draw do
     resources :unsubscribes, only: [:index, :create, :destroy]
   end
 
-  match '/box(/*path)' => redirect { |p, req|
-          req.flash[:error] = :you_must_sign_in_or_sign_up_to_continue.l
-          MessageTrain.configuration.user_sign_in_path
-  }, via: [:get, :put, :post, :delete]
+  match(
+    '/box(/*path)' => redirect do |_p, req|
+      req.flash[:error] = :you_must_sign_in_or_sign_up_to_continue.l
+      MessageTrain.configuration.user_sign_in_path
+    end,
+    via: [:get, :put, :post, :delete]
+  )
 
-  match '/collectives(/*path)' => redirect { |p, req|
-          req.flash[:error] = :you_must_sign_in_or_sign_up_to_continue.l
-          MessageTrain.configuration.user_sign_in_path
-        }, via: [:get, :put, :post, :delete]
+  match(
+    '/collectives(/*path)' => redirect do |_p, req|
+      req.flash[:error] = :you_must_sign_in_or_sign_up_to_continue.l
+      MessageTrain.configuration.user_sign_in_path
+    end,
+    via: [:get, :put, :post, :delete]
+  )
 
-  match '/unsubscribes(/*path)' => redirect { |p, req|
-          req.flash[:error] = :you_must_sign_in_or_sign_up_to_continue.l
-          MessageTrain.configuration.user_sign_in_path
-        }, via: [:get, :put, :post, :delete]
+  match(
+    '/unsubscribes(/*path)' => redirect do |_p, req|
+      req.flash[:error] = :you_must_sign_in_or_sign_up_to_continue.l
+      MessageTrain.configuration.user_sign_in_path
+    end,
+    via: [:get, :put, :post, :delete]
+  )
 end

data/lib/generators/message_train/install/install_generator.rb

@@ -1,36 +1,51 @@
 module MessageTrain
+  # Install Generator
   class InstallGenerator < Rails::Generators::Base
-    source_root File.expand_path("../templates", __FILE__)
+    source_root File.expand_path('../templates', __FILE__)
     require File.expand_path('../../utils', __FILE__)
     include Generators::Utils
     include Rails::Generators::Migration
 
     def hello
-      output "MessageTrain Installer will now install itself", :magenta
+      output 'MessageTrain Installer will now install itself', :magenta
     end
 
     # all public methods in here will be run in order
 
     def add_initializer
-      output "First, you'll need an initializer.  This is where you put your configuration options.", :magenta
-      template "initializer.rb", "config/initializers/message_train.rb"
+      output(
+        "First, you'll need an initializer. "\
+          'This is where you put your configuration options.',
+        :magenta
+      )
+      template 'initializer.rb', 'config/initializers/message_train.rb'
     end
 
     # Not doing this any more thanks to:
-    # http://blog.pivotal.io/pivotal-labs/labs/leave-your-migrations-in-your-rails-engines
+    # http://blog.pivotal.io/pivotal-labs/labs/\
+    # leave-your-migrations-in-your-rails-engines
     def add_migrations
-      output "Next come migrations.", :magenta
+      output 'Next come migrations.', :magenta
       rake 'message_train:install:migrations'
     end
 
     def add_route
-      output "Adding MessageTrain to your routes.rb file", :magenta
-      gsub_file "config/routes.rb", /mount MessageTrain::Engine => '\/.*', :as => 'message_train'/, ''
-      route("mount MessageTrain::Engine => '/', :as => 'message_train'")
+      output 'Adding MessageTrain to your routes.rb file', :magenta
+      gsub_file(
+        'config/routes.rb',
+        %r{mount MessageTrain::Engine => '/.*', as: 'message_train'},
+        ''
+      )
+      route("mount MessageTrain::Engine => '/', as: 'message_train'")
     end
 
     def goodbye
-      output "Thanks for installing! Don't forget to run your migrations. See http://gemvein.com/museum/cases/message_train for configuration tips.", :magenta
+      output(
+        "Thanks for installing! Don't forget to run your migrations. "\
+          'See http://gemvein.com/museum/cases/message_train for '\
+          'configuration tips.',
+        :magenta
+      )
     end
   end
-end
+end

data/lib/generators/message_train/install/templates/initializer.rb

@@ -9,5 +9,3 @@ MessageTrain.configure do |config|
   config.from_email = 'from@example.com'
   config.site_name = 'Example Site Name'
 end
-
-Rails.application.config.eager_load = true #FIXME: This is a weird place to put this. What would be better?

data/lib/generators/message_train/utils.rb

@@ -1,16 +1,23 @@
 module MessageTrain
   module Generators
+    # Generator Utiities
     module Utils
       def output(output, color = :green)
         say("           -  #{output}", color)
       end
 
       def ask_for(wording, default_value = nil, override_if_present_value = nil)
-        override_if_present_value.present? ?
-          display("Using [#{override_if_present_value}] for question '#{wording}'") && override_if_present_value :
-          ask("           ?  #{wording} Press <enter> for [#{default_value}] >", :yellow).presence || default_value
+        if override_if_present_value.present?
+          display(
+            "Using [#{override_if_present_value}] for question '#{wording}'"
+          ) && override_if_present_value
+        else
+          ask(
+            "           ?  #{wording} Press <enter> for [#{default_value}] >",
+            :yellow
+          ).presence || default_value
+        end
       end
     end
   end
 end
-

data/lib/message_train/configuration.rb

@@ -1,8 +1,7 @@
+# MessageTrain module
 module MessageTrain
   def self.configure(configuration = MessageTrain::Configuration.new)
-    if block_given?
-      yield configuration
-    end
+    block_given? && yield(configuration)
     @@configuration = configuration
   end
 
@@ -10,6 +9,7 @@ module MessageTrain
     @@configuration ||= MessageTrain::Configuration.new
   end
 
+  # MessageTrain configuration
   class Configuration
     attr_accessor :slug_columns,
                   :name_columns,
@@ -42,6 +42,5 @@ module MessageTrain
       self.from_email = ''
       self.site_name = 'Example Site Name'
     end
-
   end
-end
+end

data/lib/message_train/engine.rb

@@ -1,4 +1,5 @@
 module MessageTrain
+  # MessageTrain Engine
   class Engine < ::Rails::Engine
     isolate_namespace MessageTrain
     config.generators do |g|
@@ -9,12 +10,5 @@ module MessageTrain
       g.stylesheets     false
       g.javascripts     false
     end
-
-    config.to_prepare do
-      # Rails.application.config.assets.paths << File.expand_path("../../assets/stylesheets", __FILE__)
-      # Rails.application.config.assets.paths << File.expand_path("../../assets/javascripts", __FILE__)
-      # Rails.application.config.assets.precompile << %w( index )
-    end
-
   end
 end

data/lib/message_train/localization.rb

@@ -1,31 +1,27 @@
+# String Extension
 module StringExtension
   def localize(*args)
-    if args.first.is_a? Symbol
-      sym = args.shift
-    else
-      sym = underscore.tr(' ', '_').gsub(/[^a-z0-9_]+/i, '').to_sym
-    end
-    args << {:default => self}
-      
+    sym = if args.first.is_a? Symbol
+            args.shift
+          else
+            underscore.tr(' ', '_').gsub(/[^a-z0-9_]+/i, '').to_sym
+          end
+    args << { default: self }
     I18n.t(sym, *args).html_safe
   end
-  alias :l :localize
-end 
+  alias l localize
+end
 String.send :include, StringExtension
- 
- 
+
+# Symbol Extension
 module SymbolExtensionCustom
-  
   def localize_with_debugging(*args)
     localized_sym = I18n.translate(self, *args)
     localized_sym.is_a?(String) ? localized_sym.html_safe : localized_sym
   end
-  alias_method :l, :localize_with_debugging
-  
+  alias l localize_with_debugging
   def l_with_args(*args)
-    self.l(*args).html_safe
+    l(*args).html_safe
   end
-  
 end
- 
-Symbol.send :include, SymbolExtensionCustom
+Symbol.send :include, SymbolExtensionCustom