message_train 0.5.2 → 0.5.3

data/spec/models/message_train/message_spec.rb

@@ -18,19 +18,25 @@ module MessageTrain
       context 'sets draft to true on a message to no one' do
         subject { draft_conversation.messages.drafts.first }
         its(:sender) { should eq first_user }
-        its(:receipts) { should have_exactly(1).item } # i.e. sender
+        its(:receipts) { should have_exactly(1).item } # sender
         its(:recipients) { should be_empty }
         its(:draft) { should be true }
       end
       context 'generates receipts when present' do
         subject { sent_message }
         its(:sender) { should eq first_user }
-        its(:receipts) { should have_exactly(2).items } # i.e. sender and recipient
+        its(:receipts) { should have_exactly(2).items } # sender and recipient
         its(:recipients) { should include second_user }
         its(:draft) { should be false }
       end
       context 'generates error when recipient_to_save does not exist' do
-        let(:message) { first_user.box(:in).send_message(subject: 'Message with missing recipient', recipients_to_save: { 'users' => 'missing-user' }, body: 'Foo.') }
+        let(:message) do
+          first_user.box(:in).send_message(
+            subject: 'Message with missing recipient',
+            recipients_to_save: { 'users' => 'missing-user' },
+            body: 'Foo.'
+          )
+        end
         subject { message.errors.full_messages.to_sentence }
         it { should eq 'Recipient missing-user not found' }
       end
@@ -62,7 +68,7 @@ module MessageTrain
       describe '#missing_method' do
         # Testing super on method_missing
         it 'raises a NoMethodError' do
-          expect {unread_message.missing_method}.to raise_error(NoMethodError)
+          expect { unread_message.missing_method }.to raise_error(NoMethodError)
         end
       end
       context '.with_receipts_by' do
@@ -74,15 +80,24 @@ module MessageTrain
         it { should eq unread_message }
       end
       context '.with_trashed_to and #is_trashed_to?' do
-        subject { trashed_conversation.messages.with_trashed_to(first_user).first.is_trashed_to?(first_user) }
+        subject do
+          trashed_conversation.messages.with_trashed_to(first_user)
+                              .first.is_trashed_to?(first_user)
+        end
         it { should be true }
       end
       context '.with_deleted_to and #is_deleted_to?' do
-        subject { deleted_conversation.messages.with_deleted_to(first_user).first.is_deleted_to?(first_user) }
+        subject do
+          deleted_conversation.messages.with_deleted_to(first_user)
+                              .first.is_deleted_to?(first_user)
+        end
         it { should be true }
       end
       context '.with_read_to and #is_read_to?' do
-        subject { read_conversation.messages.with_read_to(first_user).first.is_read_to?(first_user) }
+        subject do
+          read_conversation.messages.with_read_to(first_user)
+                           .first.is_read_to?(first_user)
+        end
         it { should be true }
       end
       context '.mark' do

data/spec/models/message_train/receipt_spec.rb

@@ -42,19 +42,29 @@ module MessageTrain
         its(:count) { should be > 5 }
       end
       describe '.trashed_to' do
-        subject { MessageTrain::Receipt.trashed_to(first_user).first.message.conversation }
+        subject do
+          MessageTrain::Receipt.trashed_to(first_user)
+                               .first.message.conversation
+        end
         its(:subject) { should eq 'Membered Group Trashed Conversation' }
       end
       describe '.untrashed_to' do
-        subject { MessageTrain::Receipt.untrashed_to(first_user).first }
+        subject do
+          MessageTrain::Receipt.untrashed_to(first_user).first
+        end
         its(:marked_trash) { should be false }
       end
       describe '.read_to' do
-        subject { MessageTrain::Receipt.read_to(first_user).first.message.conversation }
+        subject do
+          MessageTrain::Receipt.read_to(first_user).first.message.conversation
+        end
         its(:subject) { should eq 'Membered Group Read Conversation' }
       end
       describe '.deleted_to' do
-        subject { MessageTrain::Receipt.deleted_to(first_user).first.message.conversation }
+        subject do
+          MessageTrain::Receipt.deleted_to(first_user)
+                               .first.message.conversation
+        end
         its(:subject) { should eq 'Membered Group Deleted Conversation' }
       end
       describe '.undeleted_to' do

data/spec/models/role_spec.rb

@@ -67,7 +67,9 @@ RSpec.describe Role do
 
     describe '#boxes_for_participant' do
       context 'when participant is a valid sender' do
-        subject { admin_role.boxes_for_participant(superadmin_user).collect { |x| x.division } }
+        subject do
+          admin_role.boxes_for_participant(superadmin_user).collect(&:division)
+        end
         it { should_not include :in }
         it { should include :sent }
         it { should include :drafts }
@@ -76,7 +78,9 @@ RSpec.describe Role do
         it { should_not include :ignored }
       end
       context 'when participant is a valid recipient' do
-        subject { admin_role.boxes_for_participant(admin_user).collect { |x| x.division } }
+        subject do
+          admin_role.boxes_for_participant(admin_user).collect(&:division)
+        end
         it { should include :in }
         it { should_not include :sent }
         it { should_not include :drafts }
@@ -92,7 +96,8 @@ RSpec.describe Role do
         its(:first) { should be_a MessageTrain::Conversation }
         it { should_not include unread_conversation }
         it { should include role_conversation }
-        it { should_not include role_draft } # Because received_through not set on sender receipts
+        # Because received_through not set on sender receipts
+        it { should_not include role_draft }
       end
       context 'when participant is a valid recipient' do
         subject { admin_role.all_conversations(admin_user) }
@@ -109,7 +114,8 @@ RSpec.describe Role do
         its(:first) { should be_a MessageTrain::Message }
         it { should_not include unread_message }
         it { should include role_message }
-        it { should_not include role_draft_message } # Because received_through not set on sender receipts
+        # Because received_through not set on sender receipts
+        it { should_not include role_draft_message }
       end
       context 'when participant is a valid recipient' do
         subject { admin_role.all_messages(admin_user) }
@@ -119,7 +125,5 @@ RSpec.describe Role do
         it { should_not include role_draft_message }
       end
     end
-
   end
-
 end

data/spec/models/user_spec.rb

@@ -13,7 +13,6 @@ RSpec.describe User do
   end
 
   describe 'Scopes and Methods' do
-
     describe '#box' do
       describe 'with valid number of arguments' do
         subject { first_user.box }
@@ -23,26 +22,44 @@ RSpec.describe User do
         its(:participant) { should be first_user }
       end
       describe 'with invalid number of arguments' do
-        it "should raise" do
-          expect{ first_user.box(:in, first_user, 'extra argument') }.to raise_error(RuntimeError, "Wrong number of arguments for User (expected 0..2, got 3)")
+        it 'should raise' do
+          expect do
+            first_user.box(:in, first_user, 'extra argument')
+          end.to(
+            raise_error(
+              RuntimeError,
+              'Wrong number of arguments for User (expected 0..2, got 3)'
+            )
+          )
         end
       end
     end
 
     describe '#collective_boxes' do
       describe 'with 0 arguments' do
-        subject { first_user.collective_boxes[:groups].collect { |x| x.parent } }
+        subject do
+          first_user.collective_boxes[:groups].collect(&:parent)
+        end
         it { should include membered_group }
         it { should include first_group }
       end
       describe 'with 1 argument' do
-        subject { first_user.collective_boxes(:in)[:groups].collect { |x| x.parent } }
+        subject do
+          first_user.collective_boxes(:in)[:groups].collect(&:parent)
+        end
         it { should include membered_group }
         it { should include first_group }
       end
       describe 'with 3 arguments' do
-        it "should raise" do
-          expect{ first_user.collective_boxes(:in, first_user, 'extra argument') }.to raise_error(RuntimeError, "Wrong number of arguments for User (expected 0..2, got 3)")
+        it 'should raise' do
+          expect do
+            first_user.collective_boxes(:in, first_user, 'extra argument')
+          end.to(
+            raise_error(
+              RuntimeError,
+              'Wrong number of arguments for User (expected 0..2, got 3)'
+            )
+          )
         end
       end
     end
@@ -63,37 +80,61 @@ RSpec.describe User do
         end
       end
       describe 'with 2 arguments' do
-        it "should raise" do
-          expect{ first_user.all_boxes(first_user, 'extra argument') }.to raise_error(RuntimeError, "Wrong number of arguments for User (expected 0..1, got 2)")
+        it 'should raise' do
+          expect do
+            first_user.all_boxes(first_user, 'extra argument')
+          end.to(
+            raise_error(
+              RuntimeError,
+              'Wrong number of arguments for User (expected 0..1, got 2)'
+            )
+          )
         end
       end
     end
 
     describe '#conversations' do
       context 'with division not set' do
-        subject { first_user.conversations.first.includes_receipts_to?(first_user) }
+        subject do
+          first_user.conversations.first.includes_receipts_to?(first_user)
+        end
         it { should be true }
       end
       context 'with division as :in' do
-        subject { first_user.conversations(:in).first.includes_receipts_to?(first_user) }
+        subject do
+          first_user.conversations(:in).first.includes_receipts_to?(first_user)
+        end
         it { should be true }
       end
       context 'with division as :sent' do
-        subject { first_user.conversations(:sent).first.includes_receipts_by?(first_user) }
+        subject do
+          first_user.conversations(:sent)
+                    .first.includes_receipts_by?(first_user)
+        end
         it { should be true }
       end
       context 'with division as :trash' do
-        subject { first_user.conversations(:trash).first.includes_trashed_for?(first_user) }
-        it { should be true}
+        subject do
+          first_user.conversations(:trash)
+                    .first.includes_trashed_for?(first_user)
+        end
+        it { should be true }
       end
       describe 'with 23 arguments' do
-        it "should raise" do
-          expect{ first_user.conversations(:in, first_user, 'extra argument') }.to raise_error(RuntimeError, "Wrong number of arguments for User (expected 0..2, got 3)")
+        it 'should raise' do
+          expect do
+            first_user.conversations(:in, first_user, 'extra argument')
+          end.to(
+            raise_error(
+              RuntimeError,
+              'Wrong number of arguments for User (expected 0..2, got 3)'
+            )
+          )
         end
       end
       context 'with impossible division' do
         subject { first_user.conversations(:impossible).nil? }
-        it { should be true}
+        it { should be true }
       end
     end
 
@@ -123,8 +164,15 @@ RSpec.describe User do
         end
       end
       describe 'with 2 arguments' do
-        it "should raise" do
-          expect{ first_user.all_conversations(first_user, 'extra argument') }.to raise_error(RuntimeError, "Wrong number of arguments for User (expected 0..1, got 2)")
+        it 'should raise' do
+          expect do
+            first_user.all_conversations(first_user, 'extra argument')
+          end.to(
+            raise_error(
+              RuntimeError,
+              'Wrong number of arguments for User (expected 0..1, got 2)'
+            )
+          )
         end
       end
       context 'when empty' do
@@ -159,8 +207,13 @@ RSpec.describe User do
         end
       end
       describe 'with 2 arguments' do
-        it "should raise" do
-          expect{ first_user.all_messages(first_user, 'extra argument') }.to raise_error(RuntimeError, "Wrong number of arguments for User (expected 0..1, got 2)")
+        it 'should raise' do
+          expect { first_user.all_messages(first_user, 'extra argument') }.to(
+            raise_error(
+              RuntimeError,
+              'Wrong number of arguments for User (expected 0..1, got 2)'
+            )
+          )
         end
       end
       context 'when empty' do
@@ -193,5 +246,4 @@ RSpec.describe User do
       it { should have_at_least(3).items }
     end
   end
-
 end

data/spec/rails_helper.rb

@@ -5,7 +5,9 @@ Coveralls.wear!
 ENV['RAILS_ENV'] ||= 'test'
 require File.expand_path('../dummy/config/environment', __FILE__)
 # Prevent database truncation if the environment is production
-abort("The Rails environment is running in production mode!") if Rails.env.production?
+abort(
+  'The Rails environment is running in production mode!'
+) if Rails.env.production?
 require 'spec_helper'
 require 'rspec/rails'
 # Add additional requires below this line. Rails is not loaded until this point!
@@ -29,7 +31,10 @@ require 'rake'
 # directory. Alternatively, in the individual `*_spec.rb` files, manually
 # require only the support files necessary.
 #
-Dir[MessageTrain::Engine.root.join('spec/support/**/*.rb')].each { |f| require f }
+Dir[MessageTrain::Engine.root.join('spec/support/**/*.rb')]
+  .each { |f| require f }
+Dir[MessageTrain::Engine.root.join('spec/support/**/**/*.rb')]
+  .each { |f| require f }
 
 # Checks for pending migrations before tests are run.
 # If you are not using ActiveRecord, you can remove this line.
@@ -64,7 +69,7 @@ RSpec.configure do |config|
   # You can disable this behaviour by removing the line below, and instead
   # explicitly tag your specs with their type, e.g.:
   #
-  #     RSpec.describe UsersController, :type => :controller do
+  #     RSpec.describe UsersController, type: :controller do
   #       # ...
   #     end
   #
@@ -75,7 +80,7 @@ RSpec.configure do |config|
   config.expect_with(:rspec) { |c| c.syntax = [:should, :expect] }
   config.mock_with(:rspec) { |c| c.syntax = [:should, :expect] }
 
-  config.before(:each)    { @routes = MessageTrain::Engine.routes }
+  config.before(:each) { @routes = MessageTrain::Engine.routes }
   config.include MessageTrain::Engine.routes.url_helpers
 
   config.include Warden::Test::Helpers

data/spec/spec_helper.rb

@@ -1,5 +1,7 @@
-# This file was generated by the `rails generate rspec:install` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# This file was generated by the `rails generate rspec:install` command.
+# Conventionally, all specs live under a `spec` directory, which RSpec adds to
+# the `$LOAD_PATH`.
+#
 # The generated `.rspec` file contains `--require spec_helper` which will cause
 # this file to always be loaded, without a need to explicitly require it in any
 # files.
@@ -25,9 +27,9 @@ RSpec.configure do |config|
     # and `failure_message` of custom matchers include text for helper methods
     # defined using `chain`, e.g.:
     #     be_bigger_than(2).and_smaller_than(4).description
-    #     # => "be bigger than 2 and smaller than 4"
+    #     # => 'be bigger than 2 and smaller than 4'
     # ...rather than:
-    #     # => "be bigger than 2"
+    #     # => 'be bigger than 2'
     expectations.include_chain_clauses_in_custom_matcher_descriptions = true
   end
 
@@ -39,54 +41,4 @@ RSpec.configure do |config|
     # `true` in RSpec 4.
     mocks.verify_partial_doubles = true
   end
-
-# The settings below are suggested to provide a good initial experience
-# with RSpec, but feel free to customize to your heart's content.
-=begin
-  # These two settings work together to allow you to limit a spec run
-  # to individual examples or groups you care about by tagging them with
-  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-  # get run.
-  config.filter_run :focus
-  config.run_all_when_everything_filtered = true
-
-  # Allows RSpec to persist some state between runs in order to support
-  # the `--only-failures` and `--next-failure` CLI options. We recommend
-  # you configure your source control system to ignore this file.
-  config.example_status_persistence_file_path = "spec/examples.txt"
-
-  # Limits the available syntax to the non-monkey patched syntax that is
-  # recommended. For more details, see:
-  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
-  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
-  config.disable_monkey_patching!
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-=end
 end

data/spec/support/controller_behaviors.rb

@@ -37,7 +37,7 @@ end
 shared_examples_for 'a redirect with a message' do |path, options|
   it_behaves_like 'a redirect matching', path
   options.each do |key, value|
-    context "sets #{key.to_s} message" do
+    context "sets #{key} message" do
       subject { flash[key] }
       it { should eq value }
     end
@@ -57,7 +57,7 @@ end
 shared_examples_for 'a page with a message' do |options|
   it_behaves_like 'a successful page'
   options.each do |key, value|
-    context "sets #{key.to_s} message" do
+    context "sets #{key} message" do
       subject { flash[key] }
       it { should eq value }
     end
@@ -66,7 +66,7 @@ end
 shared_examples_for 'a page with a message matching' do |options|
   it_behaves_like 'a successful page'
   options.each do |key, value|
-    context "sets #{key.to_s} message" do
+    context "sets #{key} message" do
       subject { flash[key] }
       it { should match value }
     end
@@ -85,7 +85,10 @@ shared_examples_for 'a page with an error message matching' do |message|
   it_behaves_like 'a page with a message matching', error: message
 end
 shared_examples_for 'a 403 Forbidden error' do
-  it_should_behave_like 'an error response with message', 'You are not authorized to access this page.'
+  it_should_behave_like(
+    'an error response with message',
+    'You are not authorized to access this page.'
+  )
 end
 shared_examples_for 'a redirect with error' do |path, message|
   it_behaves_like 'a redirect to', path
@@ -113,4 +116,4 @@ shared_examples_for 'a response without error' do
     subject { flash[:error] }
     it { should be nil }
   end
-end
+end

data/spec/support/controller_macros.rb

@@ -6,8 +6,8 @@ module ControllerMacros
 
   def login_user(user)
     @request ||= controller.request
-    @request.env["devise.mapping"] = Devise.mappings[:user]
+    @request.env['devise.mapping'] = Devise.mappings[:user]
     sign_in user
     user
   end
-end
+end

data/spec/support/factory_girl.rb

@@ -1,3 +1,3 @@
 RSpec.configure do |config|
   config.include FactoryGirl::Syntax::Methods
-end
+end

data/spec/support/feature_behaviors.rb

@@ -3,7 +3,11 @@ shared_examples_for 'an authenticated section' do |path|
     before do
       visit path
     end
-    it_behaves_like 'a bootstrap page with an alert', 'danger', 'You must sign in or sign up to continue.'
+    it_behaves_like(
+      'a bootstrap page with an alert',
+      'danger',
+      'You must sign in or sign up to continue.'
+    )
     context 'displays a login form' do
       subject { page }
       it { should have_selector 'form.new_user input#user_email' }
@@ -20,15 +24,26 @@ shared_examples_for 'a bootstrap page' do |options = {}|
       it { should have_title html_escape(options[:title]) }
       it { should have_xpath '//h1', text: options[:title] }
     end
-    it { should have_selector '.navbar .navbar-header .navbar-brand', text: BootstrapLeather.configuration.application_title }
+    it do
+      should(
+        have_selector(
+          '.navbar .navbar-header .navbar-brand',
+          text: BootstrapLeather.configuration.application_title
+        )
+      )
+    end
   end
 end
 
-shared_examples_for 'a bootstrap page with a dropdown navigation list' do |options|
+shared_examples_for(
+  'a bootstrap page with a dropdown navigation list'
+) do |options|
   if options[:text]
-    it { should have_selector 'li.dropdown a.dropdown-toggle', text: options[:text]}
+    it do
+      should have_selector 'li.dropdown a.dropdown-toggle', text: options[:text]
+    end
   else
-    it { should have_selector 'li.dropdown a.dropdown-toggle'}
+    it { should have_selector 'li.dropdown a.dropdown-toggle' }
   end
 end
 
@@ -42,20 +57,30 @@ shared_examples_for 'a bootstrap page without an alert' do |type|
   it { should_not have_selector ".alert.alert-#{type}" }
 end
 
-shared_examples_for 'a bootstrap page listing a collection of items' do |object, options={}|
+shared_examples_for(
+  'a bootstrap page listing a collection of items'
+) do |object, options = {}|
   options[:minimum] ||= 1
   options[:plural_title] ||= object.model_name.human.pluralize(2)
   options[:plural_name] ||= object.table_name
-  collection_css_id = options[:plural_name].gsub('_', '-')
+  collection_css_id = options[:plural_name].tr('_', '-')
   member_css_class = options[:plural_name].singularize
   it_behaves_like 'a bootstrap page', title: options[:plural_title].titlecase
   context "displays a list of ##{collection_css_id} in .#{member_css_class}" do
     subject { page }
-    it { should have_css("##{collection_css_id} .#{member_css_class}", minimum: options[:minimum]) }
+    it do
+      should(
+        have_css(
+          "##{collection_css_id} .#{member_css_class}",
+          minimum: options[:minimum])
+      )
+    end
   end
 end
 
-shared_examples_for 'a bootstrap page showing an item' do |object, title, options={}|
+shared_examples_for(
+  'a bootstrap page showing an item'
+) do |object, title, options = {}|
   options[:css_id] ||= object.table_name.singularize
   it_behaves_like 'a bootstrap page', title: title
   context "displays an item at ##{options[:css_id]}" do
@@ -66,11 +91,15 @@ end
 
 shared_examples_for 'a bootstrap form with errors' do |error_fields|
   subject { page }
-  for field in error_fields
-    it_behaves_like 'a bootstrap page with an alert', 'danger', "#{field.to_s.humanize} can't be blank"
+  error_fields.each do |field|
+    it_behaves_like(
+      'a bootstrap page with an alert',
+      'danger',
+      "#{field.to_s.humanize} can't be blank"
+    )
     context 'shows which field has errors' do
       subject { page }
-      it { should have_css('.form-group.has-error', text: field.to_s.humanize)}
+      it { should have_css('.form-group.has-error', text: field.to_s.humanize) }
     end
   end
-end
+end

data/spec/support/loaded_site/attachments.rb

@@ -0,0 +1,8 @@
+shared_context 'attachments' do
+  let(:image_attachment) do
+    MessageTrain::Attachment.find_by_attachment_file_name('image-sample.jpg')
+  end
+  let(:pdf_attachment) do
+    MessageTrain::Attachment.find_by_attachment_file_name('pdf-sample.pdf')
+  end
+end