message-driver 0.3.0 → 0.4.0

data/spec/units/message_driver/destination_spec.rb

@@ -4,14 +4,14 @@ module MessageDriver::Destination
   describe Base do
     subject(:destination) { Base.new(nil, nil, nil, nil) }
 
-    it "needs some real tests"
+    it 'needs some real tests'
 
     include_examples "doesn't support #message_count"
 
-    describe "#subscribe" do
-      it "raises an error" do
+    describe '#subscribe' do
+      it 'raises an error' do
         expect {
-          consumer = lambda do |m| end
+          consumer = lambda do |_| end
           destination.subscribe(&consumer)
         }.to raise_error "#subscribe is not supported by #{destination.class}"
       end

data/spec/units/message_driver/message_spec.rb

@@ -2,13 +2,13 @@ require 'spec_helper'
 
 module MessageDriver::Message
   describe Base do
-    describe "#initialize" do
-      let(:body) { "The message body" }
+    describe '#initialize' do
+      let(:body) { 'The message body' }
       let(:headers) { { foo: :bar, bar: :baz} }
       let(:properties) { {persistent: true, client_ack: true} }
-      let(:ctx) { double("adapter_context") }
+      let(:ctx) { double('adapter_context') }
 
-      context "sets the body, header and properites on initialization" do
+      context 'sets the body, header and properites on initialization' do
         subject { described_class.new(ctx, body, headers, properties) }
 
         its(:ctx) { should be(ctx) }
@@ -19,23 +19,23 @@ module MessageDriver::Message
     end
 
     let(:logger) { MessageDriver.logger }
-    let(:ctx) { double("adapter_context") }
-    let(:options) { double("options") }
-    subject(:message) { described_class.new(ctx, "body", {}, {}) }
+    let(:ctx) { double('adapter_context') }
+    let(:options) { double('options') }
+    subject(:message) { described_class.new(ctx, 'body', {}, {}) }
 
-    describe "#ack" do
+    describe '#ack' do
       before do
         allow(ctx).to receive(:ack_message)
       end
-      context "when the adapter supports client acks" do
+      context 'when the adapter supports client acks' do
         before do
           allow(ctx).to receive(:supports_client_acks?) { true }
         end
-        it "calls #ack_message with the message" do
+        it 'calls #ack_message with the message' do
           subject.ack
           expect(ctx).to have_received(:ack_message).with(subject, {})
         end
-        it "passes the supplied options to ack_message" do
+        it 'passes the supplied options to ack_message' do
           subject.ack(options)
           expect(ctx).to have_received(:ack_message).with(subject, options)
         end
@@ -48,27 +48,27 @@ module MessageDriver::Message
           subject.ack
           expect(ctx).not_to have_received(:ack_message)
         end
-        it "logs a warning" do
+        it 'logs a warning' do
           allow(logger).to receive(:debug)
           subject.ack
-          expect(logger).to have_received(:debug).with("this adapter does not support client acks")
+          expect(logger).to have_received(:debug).with('this adapter does not support client acks')
         end
       end
     end
 
-    describe "#nack" do
+    describe '#nack' do
       before do
         allow(ctx).to receive(:nack_message)
       end
-      context "when the adapter supports client nacks" do
+      context 'when the adapter supports client nacks' do
         before do
           allow(ctx).to receive(:supports_client_acks?) { true }
         end
-        it "calls #nack_message with the message" do
+        it 'calls #nack_message with the message' do
           subject.nack
           expect(ctx).to have_received(:nack_message).with(subject, {})
         end
-        it "passes the supplied options to nack_message" do
+        it 'passes the supplied options to nack_message' do
           subject.nack(options)
           expect(ctx).to have_received(:nack_message).with(subject, options)
         end
@@ -81,10 +81,10 @@ module MessageDriver::Message
           subject.nack
           expect(ctx).not_to have_received(:nack_message)
         end
-        it "logs a warning" do
+        it 'logs a warning' do
           allow(logger).to receive(:debug)
           subject.nack
-          expect(logger).to have_received(:debug).with("this adapter does not support client acks")
+          expect(logger).to have_received(:debug).with('this adapter does not support client acks')
         end
       end
     end

data/spec/units/message_driver/subscription_spec.rb

@@ -4,7 +4,7 @@ module MessageDriver::Subscription
   describe Base do
     let(:adapter) { double(MessageDriver::Adapters::Base) }
     let(:destination) { double(MessageDriver::Destination::Base) }
-    let(:consumer) { double("a consumer") }
+    let(:consumer) { double('a consumer') }
     subject(:subscription) { Base.new(adapter, destination, consumer) }
 
     it "sets it's adapter, destination and consumer on instansiation" do
@@ -13,11 +13,11 @@ module MessageDriver::Subscription
       expect(subscription.consumer).to eq(consumer)
     end
 
-    describe "#unsubscribe" do
-      it "raises an error" do
+    describe '#unsubscribe' do
+      it 'raises an error' do
         expect {
           subscription.unsubscribe
-        }.to raise_error("must be implemented in subclass")
+        }.to raise_error('must be implemented in subclass')
       end
     end
   end

data/test_lib/broker_config.rb

@@ -1,8 +1,8 @@
 class BrokerConfig
   class << self
     def config
-      adapter_file = File.expand_path("../../.adapter_under_test", __FILE__)
-      @adapter, @version = (ENV['ADAPTER'] || (File.exist?(adapter_file) && File.read(adapter_file).chomp)).split(":")
+      adapter_file = File.expand_path('../../.adapter_under_test', __FILE__)
+      @adapter, @version = (ENV['ADAPTER'] || (File.exist?(adapter_file) ? File.read(adapter_file).chomp : '')).split(':')
       case @adapter
       when 'bunny'
         {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: message-driver
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Matt Campbell
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-26 00:00:00.000000000 Z
+date: 2014-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Easy message queues for ruby using AMQ, STOMP and others
 email:
 - message-driver@soupmatt.com
@@ -76,6 +90,8 @@ files:
 - ".gitignore"
 - ".relish"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -115,10 +131,12 @@ files:
 - features/publishing_a_message.feature
 - features/publishing_with_transactions.feature
 - features/rabbitmq_specific_features/dead_letter_queueing.feature
+- features/rabbitmq_specific_features/publisher_acknowledgements.feature
 - features/step_definitions/dynamic_destinations_steps.rb
 - features/step_definitions/error_handling_steps.rb
 - features/step_definitions/logging_steps.rb
 - features/step_definitions/message_consumers_steps.rb
+- features/step_definitions/rabbitmq_specific_steps.rb
 - features/step_definitions/steps.rb
 - features/support/broker_config_helper.rb
 - features/support/env.rb
@@ -140,10 +158,10 @@ files:
 - lib/message_driver/logging.rb
 - lib/message_driver/message.rb
 - lib/message_driver/subscription.rb
-- lib/message_driver/vendor/.document
-- lib/message_driver/vendor/nesty.rb
-- lib/message_driver/vendor/nesty/nested_error.rb
 - lib/message_driver/version.rb
+- lib/vendor/.document
+- lib/vendor/nesty.rb
+- lib/vendor/nesty/nested_error.rb
 - message-driver.gemspec
 - spec/integration/bunny/amqp_integration_spec.rb
 - spec/integration/bunny/bunny_adapter_spec.rb
@@ -184,7 +202,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Easy message queues for ruby
@@ -215,10 +233,12 @@ test_files:
 - features/publishing_a_message.feature
 - features/publishing_with_transactions.feature
 - features/rabbitmq_specific_features/dead_letter_queueing.feature
+- features/rabbitmq_specific_features/publisher_acknowledgements.feature
 - features/step_definitions/dynamic_destinations_steps.rb
 - features/step_definitions/error_handling_steps.rb
 - features/step_definitions/logging_steps.rb
 - features/step_definitions/message_consumers_steps.rb
+- features/step_definitions/rabbitmq_specific_steps.rb
 - features/step_definitions/steps.rb
 - features/support/broker_config_helper.rb
 - features/support/env.rb
@@ -245,3 +265,4 @@ test_files:
 - spec/units/message_driver/destination_spec.rb
 - spec/units/message_driver/message_spec.rb
 - spec/units/message_driver/subscription_spec.rb
+has_rdoc: 

data/lib/message_driver/vendor/nesty.rb

@@ -1 +0,0 @@
-require "nesty/nested_error"

data/lib/message_driver/vendor/nesty/nested_error.rb

@@ -1,26 +0,0 @@
-module Nesty
-  module NestedError
-    attr_reader :nested, :raw_backtrace
-
-    def initialize(msg = nil, nested)
-      super(msg)
-      @nested = nested
-    end
-
-    def set_backtrace(backtrace)
-      @raw_backtrace = backtrace
-      if nested
-        backtrace = backtrace - nested_raw_backtrace
-        backtrace += ["#{nested.backtrace.first}: #{nested.message} (#{nested.class.name})"]
-        backtrace += nested.backtrace[1..-1] || []
-      end
-      super(backtrace)
-    end
-
-    private
-
-    def nested_raw_backtrace
-      nested.respond_to?(:raw_backtrace) ? nested.raw_backtrace : nested.backtrace
-    end
-  end
-end