message-driver 0.3.0 → 0.4.0

data/spec/integration/stomp/stomp_adapter_spec.rb

@@ -7,22 +7,22 @@ module MessageDriver::Adapters
 
     let(:valid_connection_attrs) { BrokerConfig.config }
 
-    describe "#initialize" do
+    describe '#initialize' do
       let(:connection_attrs) { valid_connection_attrs }
-      let(:broker) { double("broker") }
+      let(:broker) { double('broker') }
 
-      context "differing stomp versions" do
-        shared_examples "raises a stomp error" do
-          it "raises an error" do
-            stub_const("Stomp::Version::STRING", version)
+      context 'differing stomp versions' do
+        shared_examples 'raises a stomp error' do
+          it 'raises an error' do
+            stub_const('Stomp::Version::STRING', version)
             expect {
               described_class.new(broker, connection_attrs)
-            }.to raise_error MessageDriver::Error, "stomp 1.3.1 or a later version of the 1.3.x series is required for the stomp adapter"
+            }.to raise_error MessageDriver::Error, 'stomp 1.3.1 or a later version of the 1.3.x series is required for the stomp adapter'
           end
         end
         shared_examples "doesn't raise a stomp error" do
           it "doesn't raise an an error" do
-            stub_const("Stomp::Version::STRING", version)
+            stub_const('Stomp::Version::STRING', version)
             adapter = nil
             expect {
               adapter = described_class.new(broker, connection_attrs)
@@ -32,7 +32,7 @@ module MessageDriver::Adapters
         %w(1.1.0 1.2.9 1.3.0 1.4.0).each do |v|
           context "stomp version #{v}" do
             let(:version) { v }
-            include_examples "raises a stomp error"
+            include_examples 'raises a stomp error'
           end
         end
         %w(1.3.1 1.3.5).each do |v|
@@ -43,35 +43,35 @@ module MessageDriver::Adapters
         end
       end
 
-      describe "the resulting config" do
-        let(:connection_attrs) { {hosts: [{host: "my_host"}]} }
+      describe 'the resulting config' do
+        let(:connection_attrs) { {hosts: [{host: 'my_host'}]} }
         subject(:config) { described_class.new(broker, connection_attrs).config }
 
-        its([:connect_headers]) { should eq(:"accept-version" => "1.1,1.2") }
+        its([:connect_headers]) { should eq(:"accept-version" => '1.1,1.2') }
         its([:hosts]) { should eq(connection_attrs[:hosts]) }
 
-        context "when vhost is specified" do
-          let(:connection_attrs) { {hosts: [{host: "my_host"}], vhost: "my_vhost"} }
+        context 'when vhost is specified' do
+          let(:connection_attrs) { {hosts: [{host: 'my_host'}], vhost: 'my_vhost'} }
 
           it { should_not have_key(:vhost) }
-          its([:connect_headers]) { should eq(:"accept-version" => "1.1,1.2", :"host" => "my_vhost") }
+          its([:connect_headers]) { should eq(:"accept-version" => '1.1,1.2', :"host" => 'my_vhost') }
         end
 
-        context "when there are things in the connect_headers" do
-          let(:connection_attrs) { {hosts: [{host: "my_host"}], connect_headers: {"foo" => "bar"}} }
+        context 'when there are things in the connect_headers' do
+          let(:connection_attrs) { {hosts: [{host: 'my_host'}], connect_headers: {'foo' => 'bar'}} }
 
-          its([:connect_headers]) { should eq(:"accept-version" => "1.1,1.2", "foo" => "bar") }
+          its([:connect_headers]) { should eq(:"accept-version" => '1.1,1.2', 'foo' => 'bar') }
 
-          context "and accept-version is one of the parameters" do
-            let(:connection_attrs) { {hosts: [{host: "my_host"}], connect_headers: {"foo" => "bar", :"accept-version" => "foo!"}} }
+          context 'and accept-version is one of the parameters' do
+            let(:connection_attrs) { {hosts: [{host: 'my_host'}], connect_headers: {'foo' => 'bar', :"accept-version" => 'foo!'}} }
 
-            its([:connect_headers]) { should eq(:"accept-version" => "1.1,1.2", "foo" => "bar") }
+            its([:connect_headers]) { should eq(:"accept-version" => '1.1,1.2', 'foo' => 'bar') }
           end
         end
       end
     end
 
-    shared_context "a connected stomp adapter" do
+    shared_context 'a connected stomp adapter' do
       let(:broker) { MessageDriver::Broker.configure(valid_connection_attrs) }
       subject(:adapter) { broker.adapter }
 
@@ -80,54 +80,54 @@ module MessageDriver::Adapters
       end
     end
 
-    it_behaves_like "an adapter" do
-      include_context "a connected stomp adapter"
+    it_behaves_like 'an adapter' do
+      include_context 'a connected stomp adapter'
     end
 
-    describe "#new_context" do
-      include_context "a connected stomp adapter"
+    describe '#new_context' do
+      include_context 'a connected stomp adapter'
 
-      it "returns a StompAdapter::StompContext" do
+      it 'returns a StompAdapter::StompContext' do
         expect(adapter.new_context).to be_a StompAdapter::StompContext
       end
     end
 
     describe StompAdapter::StompContext do
-      include_context "a connected stomp adapter"
+      include_context 'a connected stomp adapter'
       subject(:adapter_context) { adapter.new_context }
 
-      it_behaves_like "an adapter context"
-      it_behaves_like "transactions are not supported"
-      it_behaves_like "client acks are not supported"
-      it_behaves_like "subscriptions are not supported"
+      it_behaves_like 'an adapter context'
+      it_behaves_like 'transactions are not supported'
+      it_behaves_like 'client acks are not supported'
+      it_behaves_like 'subscriptions are not supported'
 
-      describe "#create_destination" do
+      describe '#create_destination' do
 
-        context "the resulting destination" do
-          let(:dest_name) { "/queue/stomp_destination_spec" }
+        context 'the resulting destination' do
+          let(:dest_name) { '/queue/stomp_destination_spec' }
           subject(:destination) { adapter_context.create_destination(dest_name) }
 
           it { should be_a StompAdapter::Destination }
 
-          it_behaves_like "a destination"
+          it_behaves_like 'a destination'
           include_examples "doesn't support #message_count"
 
-          describe "pop_message" do
-            context "when there is a message on the queue" do
-              let(:body) { "Testing stomp pop_message" }
+          describe 'pop_message' do
+            context 'when there is a message on the queue' do
+              let(:body) { 'Testing stomp pop_message' }
               before do
                 destination.publish(body)
               end
 
-              it "returns the message" do
+              it 'returns the message' do
                 msg = destination.pop_message
                 expect(msg).to be_a MessageDriver::Adapters::StompAdapter::Message
                 expect(msg.body).to eq(body)
               end
             end
 
-            context "when the queue is empty" do
-              it "returns nil" do
+            context 'when the queue is empty' do
+              it 'returns nil' do
                 msg = destination.pop_message
                 expect(msg).to be_nil
               end

data/spec/spec_helper.rb

@@ -1,8 +1,11 @@
+require 'coveralls'
+Coveralls.wear!
+
 require 'message_driver'
 
 require File.join(File.dirname(__FILE__), '..', 'test_lib', 'broker_config')
 
-Dir["./spec/support/**/*.rb"].sort.each {|f| require f}
+Dir['./spec/support/**/*.rb'].sort.each {|f| require f}
 
 RSpec.configure do |c|
   c.treat_symbols_as_metadata_keys_with_true_values = true

data/spec/support/shared/adapter_examples.rb

@@ -1,12 +1,12 @@
-shared_examples "an adapter" do
-  describe "#new_context" do
-    it "returns a MessageDriver::Adapters::ContextBase" do
+shared_examples 'an adapter' do
+  describe '#new_context' do
+    it 'returns a MessageDriver::Adapters::ContextBase' do
       expect(subject.new_context).to be_a MessageDriver::Adapters::ContextBase
     end
   end
 
-  describe "#stop" do
-    it "invalidates all the adapter contexts" do
+  describe '#stop' do
+    it 'invalidates all the adapter contexts' do
       ctx1 = subject.new_context
       ctx2 = subject.new_context
       subject.stop
@@ -15,8 +15,8 @@ shared_examples "an adapter" do
     end
   end
 
-  describe "#broker" do
-    it "returns the broker associated with the adapter" do
+  describe '#broker' do
+    it 'returns the broker associated with the adapter' do
       expect(subject.broker).to be(broker)
     end
   end

data/spec/support/shared/client_ack_examples.rb

@@ -1,6 +1,6 @@
-shared_examples "client acks are supported" do
-  describe "#supports_client_acks" do
-    it "returns true" do
+shared_examples 'client acks are supported' do
+  describe '#supports_client_acks' do
+    it 'returns true' do
       expect(subject.supports_client_acks?).to eq(true)
     end
   end
@@ -9,9 +9,9 @@ shared_examples "client acks are supported" do
   it { should respond_to :nack_message }
 end
 
-shared_examples "client acks are not supported" do
-  describe "#supports_client_acks" do
-    it "returns false" do
+shared_examples 'client acks are not supported' do
+  describe '#supports_client_acks' do
+    it 'returns false' do
       expect(subject.supports_client_acks?).to eq(false)
     end
   end

data/spec/support/shared/context_examples.rb

@@ -1,14 +1,14 @@
-shared_examples "an adapter context" do
+shared_examples 'an adapter context' do
   it { should be_a MessageDriver::Adapters::ContextBase }
 
   its(:adapter) { should be adapter }
 
-  it "is initially valid" do
+  it 'is initially valid' do
     should be_valid
   end
 
-  describe "#invalidate" do
-    it "causes the context to become invalid" do
+  describe '#invalidate' do
+    it 'causes the context to become invalid' do
       subject.invalidate
       expect(subject).to_not be_valid
     end

data/spec/support/shared/destination_examples.rb

@@ -1,16 +1,16 @@
-shared_examples "a destination" do
+shared_examples 'a destination' do
   its(:adapter) { should be adapter }
 
-  describe "#pop_message" do
-    let(:body) { "The message body" }
-    let(:headers) { { "foo" => "bar", "bar" => "baz"} }
+  describe '#pop_message' do
+    let(:body) { 'The message body' }
+    let(:headers) { { 'foo' => 'bar', 'bar' => 'baz'} }
     let(:properties) { {persistent: true, client_ack: true} }
 
     before do
       destination.publish(body, headers, properties)
     end
 
-    context "the result" do
+    context 'the result' do
       subject(:message) { destination.pop_message }
 
       it { should be_a MessageDriver::Message::Base }
@@ -22,8 +22,8 @@ shared_examples "a destination" do
 end
 
 shared_examples "doesn't support #message_count" do
-  describe "#message_count" do
-    it "raises an error" do
+  describe '#message_count' do
+    it 'raises an error' do
       expect {
         destination.message_count
       }.to raise_error "#message_count is not supported by #{destination.class}"
@@ -31,11 +31,11 @@ shared_examples "doesn't support #message_count" do
   end
 end
 
-shared_examples "supports #message_count" do
+shared_examples 'supports #message_count' do
   it "reports it's message_count" do
     expect {
-      destination.publish("msg1")
-      destination.publish("msg2")
+      destination.publish('msg1')
+      destination.publish('msg2')
       pause_if_needed
     }.to change{destination.message_count}.by(2)
   end

data/spec/support/shared/subscription_examples.rb

@@ -1,14 +1,14 @@
-shared_examples "subscriptions are not supported" do
-  describe "#supports_subscriptions?" do
-    it "returns false" do
+shared_examples 'subscriptions are not supported' do
+  describe '#supports_subscriptions?' do
+    it 'returns false' do
       expect(subject.supports_subscriptions?).to eq(false)
     end
   end
 
-  describe "#subscribe" do
-    it "raises an error" do
-      destination = double("destination")
-      consumer = lambda do |m| end
+  describe '#subscribe' do
+    it 'raises an error' do
+      destination = double('destination')
+      consumer = lambda do |_| end
       expect {
         subject.subscribe(destination, &consumer)
       }.to raise_error "#subscribe is not supported by #{subject.adapter.class}"
@@ -16,17 +16,17 @@ shared_examples "subscriptions are not supported" do
   end
 end
 
-shared_examples "subscriptions are supported" do |subscription_type|
-  describe "#supports_subscriptions?" do
-    it "returns true" do
+shared_examples 'subscriptions are supported' do |subscription_type|
+  describe '#supports_subscriptions?' do
+    it 'returns true' do
       expect(subject.supports_subscriptions?).to eq(true)
     end
   end
 
-  let(:destination) { adapter_context.create_destination("subscriptions_example_queue") }
+  let(:destination) { adapter_context.create_destination('subscriptions_example_queue') }
 
-  let(:message1) { "message 1" }
-  let(:message2) { "message 2" }
+  let(:message1) { 'message 1' }
+  let(:message2) { 'message 2' }
   let(:messages) { [] }
   let(:consumer) do
     lambda do |msg|
@@ -34,7 +34,7 @@ shared_examples "subscriptions are supported" do |subscription_type|
     end
   end
 
-  describe "#subscribe" do
+  describe '#subscribe' do
     before do
       if destination.respond_to? :purge
         destination.purge
@@ -46,11 +46,11 @@ shared_examples "subscriptions are supported" do |subscription_type|
       subscription.unsubscribe
     end
 
-    it "returns a MessageDriver::Subscription::Base" do
+    it 'returns a MessageDriver::Subscription::Base' do
       expect(subscription).to be_a MessageDriver::Subscription::Base
     end
 
-    context "the subscription" do
+    context 'the subscription' do
       subject { subscription }
 
       it { should be_a MessageDriver::Subscription::Base }
@@ -59,23 +59,23 @@ shared_examples "subscriptions are supported" do |subscription_type|
       its(:destination) { should be destination }
       its(:consumer) { should be consumer }
 
-      describe "#unsubscribe" do
+      describe '#unsubscribe' do
         it "makes it so messages don't go to the consumer any more" do
           subscription.unsubscribe
           expect {
-            destination.publish("should not be consumed")
+            destination.publish('should not be consumed')
           }.to_not change{messages.size}
         end
       end
     end
 
-    context "when there are already messages in the destination" do
+    context 'when there are already messages in the destination' do
       before do
         destination.publish(message1)
         destination.publish(message2)
       end
 
-      it "plays the messages into the consumer" do
+      it 'plays the messages into the consumer' do
         expect {
           subscription
           pause_if_needed
@@ -85,7 +85,7 @@ shared_examples "subscriptions are supported" do |subscription_type|
         expect(bodies).to include(message2)
       end
 
-      it "removes the messages from the queue" do
+      it 'removes the messages from the queue' do
         pause_if_needed
         expect {
           subscription
@@ -94,12 +94,12 @@ shared_examples "subscriptions are supported" do |subscription_type|
       end
     end
 
-    context "when a message is published to the destination" do
+    context 'when a message is published to the destination' do
       before do
         subscription
       end
 
-      it "consumers the message into the consumer instead of putting them on the queue" do
+      it 'consumers the message into the consumer instead of putting them on the queue' do
         expect {
           expect {
             subject.publish(destination, message1)
@@ -110,10 +110,10 @@ shared_examples "subscriptions are supported" do |subscription_type|
       end
     end
 
-    context "when the consumer raises an error" do
-      let(:error) { RuntimeError.new("oh nos!") }
+    context 'when the consumer raises an error' do
+      let(:error) { RuntimeError.new('oh nos!') }
       let(:consumer) do
-        lambda do |msg|
+        lambda do |_|
           raise error
         end
       end
@@ -123,7 +123,7 @@ shared_examples "subscriptions are supported" do |subscription_type|
         destination.publish(message2)
       end
 
-      it "keeps processing the messages" do
+      it 'keeps processing the messages' do
         pause_if_needed
         expect {
           subscription
@@ -131,11 +131,11 @@ shared_examples "subscriptions are supported" do |subscription_type|
         }.to change{destination.message_count}.from(2).to(0)
       end
 
-      context "an error_handler is provided" do
+      context 'an error_handler is provided' do
         let(:error_handler) { double(:error_handler, call: nil) }
         let(:subscription) { adapter_context.subscribe(destination, error_handler: error_handler, &consumer) }
 
-        it "passes the errors and the messages to the error handler" do
+        it 'passes the errors and the messages to the error handler' do
           subscription
           pause_if_needed
           expect(error_handler).to have_received(:call).with(error, kind_of(MessageDriver::Message::Base)).at_least(2).times