message-driver 0.3.0 → 0.4.0

data/spec/integration/bunny/bunny_adapter_spec.rb

@@ -7,33 +7,33 @@ module MessageDriver::Adapters
 
     let(:valid_connection_attrs) { BrokerConfig.config }
 
-    describe "#initialize" do
-      context "differing bunny versions" do
-        let(:broker) { double("broker") }
-        shared_examples "raises an error" do
-          it "raises an error" do
-            stub_const("Bunny::VERSION", version)
+    describe '#initialize' do
+      context 'differing bunny versions' do
+        let(:broker) { double('broker') }
+        shared_examples 'raises an error' do
+          it 'raises an error' do
+            stub_const('Bunny::VERSION', version)
             expect {
               described_class.new(broker, valid_connection_attrs)
-            }.to raise_error MessageDriver::Error, "bunny 1.1.3 or later is required for the bunny adapter"
+            }.to raise_error MessageDriver::Error, 'bunny 1.2.2 or later is required for the bunny adapter'
           end
         end
         shared_examples "doesn't raise an error" do
           it "doesn't raise an an error" do
-            stub_const("Bunny::VERSION", version)
+            stub_const('Bunny::VERSION', version)
             adapter = nil
             expect {
               adapter = described_class.new(broker, valid_connection_attrs)
             }.to_not raise_error
           end
         end
-        %w(0.8.0 0.9.0.pre11 0.9.0.rc1 0.9.0 0.9.8 0.10.7 1.0.3 1.1.2).each do |v|
+        %w(0.8.0  0.9.0 0.9.8 0.10.7 1.0.3 1.1.2 1.2.1).each do |v|
           context "bunny version #{v}" do
             let(:version) { v }
-            include_examples "raises an error"
+            include_examples 'raises an error'
           end
         end
-        %w(1.1.3 1.1.5).each do |v|
+        %w(1.2.2 1.3.2 1.4.0).each do |v|
           context "bunny version #{v}" do
             let(:version) { v }
             include_examples "doesn't raise an error"
@@ -41,7 +41,7 @@ module MessageDriver::Adapters
         end
       end
 
-      it "connects to the rabbit broker" do
+      it 'connects to the rabbit broker' do
         broker = double(:broker)
         adapter = described_class.new(broker, valid_connection_attrs)
 
@@ -49,7 +49,7 @@ module MessageDriver::Adapters
         expect(adapter.connection).to be_open
       end
 
-      it "connects to the rabbit broker lazily" do
+      it 'connects to the rabbit broker lazily' do
         broker = double(:broker)
         adapter = described_class.new(broker, valid_connection_attrs)
 
@@ -57,7 +57,7 @@ module MessageDriver::Adapters
       end
     end
 
-    shared_context "a connected bunny adapter" do
+    shared_context 'a connected bunny adapter' do
       let(:broker) { MessageDriver::Broker.configure(valid_connection_attrs) }
       subject(:adapter) { broker.adapter }
       let(:connection) { adapter.connection }
@@ -67,43 +67,47 @@ module MessageDriver::Adapters
       end
     end
 
-    shared_context "with a queue" do
-      include_context "a connected bunny adapter"
+    shared_context 'with a queue' do
+      include_context 'a connected bunny adapter'
 
       let(:channel) { connection.create_channel }
-      let(:tmp_queue_name) { "my_temp_queue" }
+      let(:tmp_queue_name) { 'my_temp_queue' }
       let(:tmp_queue) { channel.queue(tmp_queue_name, exclusive: true) }
     end
 
-    it_behaves_like "an adapter" do
-      include_context "a connected bunny adapter"
+    it_behaves_like 'an adapter' do
+      include_context 'a connected bunny adapter'
     end
 
-    describe "#new_context" do
-      include_context "a connected bunny adapter"
+    describe '#new_context' do
+      include_context 'a connected bunny adapter'
 
-      it "returns a BunnyAdapter::BunnyContext" do
+      it 'returns a BunnyAdapter::BunnyContext' do
         expect(subject.new_context).to be_a BunnyAdapter::BunnyContext
       end
     end
 
     describe BunnyAdapter::BunnyContext do
-      include_context "a connected bunny adapter"
+      include_context 'a connected bunny adapter'
       subject(:adapter_context) { adapter.new_context }
+      around(:each) do |ex|
+        MessageDriver::Client.with_adapter_context(adapter_context) do
+          ex.run
+        end
+      end
 
-      it_behaves_like "an adapter context"
-      it_behaves_like "transactions are supported"
-      it_behaves_like "client acks are supported"
-      it_behaves_like "subscriptions are supported", BunnyAdapter::Subscription
+      it_behaves_like 'an adapter context'
+      it_behaves_like 'transactions are supported'
+      it_behaves_like 'client acks are supported'
+      it_behaves_like 'subscriptions are supported', BunnyAdapter::Subscription
 
-      describe "#pop_message" do
-        include_context "with a queue"
-        it "needs some real tests"
+      describe '#pop_message' do
+        include_context 'with a queue'
+        it 'needs some real tests'
       end
 
-
-      describe "#invalidate" do
-        it "closes the channel" do
+      describe '#invalidate' do
+        it 'closes the channel' do
           subject.with_channel(false) do |ch|
             expect(ch).to be_open
           end
@@ -112,26 +116,36 @@ module MessageDriver::Adapters
         end
       end
 
-      describe "#create_destination" do
+      describe '#create_destination' do
 
-        context "with defaults" do
-          context "the resulting destination" do
-            let(:dest_name) { "my_dest" }
+        context 'with defaults' do
+          context 'the resulting destination' do
+            let(:dest_name) { 'my_dest' }
             subject(:result) { adapter_context.create_destination(dest_name, exclusive: true) }
 
             it { should be_a BunnyAdapter::QueueDestination }
           end
         end
 
-        context "the type is queue" do
-          context "and there is no destination name given" do
-            subject(:destination) { adapter_context.create_destination("", type: :queue, exclusive: true) }
+        shared_examples 'supports publisher confirmations' do
+          let(:properties) { {persistent: false, confirm: true} }
+          it 'switches the channel to confirms mode' do
+            expect(adapter_context.channel.using_publisher_confirms?).to eq(true)
+          end
+          it 'waits until the confirm comes in' do
+            expect(adapter_context.channel.unconfirmed_set).to be_empty
+          end
+        end
+
+        context 'the type is queue' do
+          context 'and there is no destination name given' do
+            subject(:destination) { adapter_context.create_destination('', type: :queue, exclusive: true) }
             it { should be_a BunnyAdapter::QueueDestination }
             its(:name) { should be_a String }
             its(:name) { should_not be_empty }
           end
-          context "the resulting destination" do
-            let(:dest_name) { "my_dest" }
+          context 'the resulting destination' do
+            let(:dest_name) { 'my_dest' }
             subject(:destination) { adapter_context.create_destination(dest_name, type: :queue, exclusive: true) }
             before do
               destination
@@ -141,83 +155,84 @@ module MessageDriver::Adapters
             its(:name) { should be_a String }
             its(:name) { should eq(dest_name) }
 
-            include_examples "supports #message_count"
+            include_examples 'supports #message_count'
 
             it "strips off the type so it isn't set on the destination" do
               expect(subject.dest_options).to_not have_key :type
             end
-            it "ensures the queue is declared" do
+            it 'ensures the queue is declared' do
               expect {
                 connection.with_channel do |ch|
                   ch.queue(dest_name, passive: true)
                 end
               }.to_not raise_error
             end
-            context "publishing a message" do
-              let(:body) { "Testing the QueueDestination" }
-              let(:headers) { {"foo" => "bar"} }
+            context 'publishing a message' do
+              let(:body) { 'Testing the QueueDestination' }
+              let(:headers) { {'foo' => 'bar'} }
               let(:properties) { {persistent: false} }
               before do
                 subject.publish(body, headers, properties)
               end
-              it "publishes via the default exchange" do
+              it 'publishes via the default exchange' do
                 msg = subject.pop_message
                 expect(msg.body).to eq(body)
                 expect(msg.headers).to eq(headers)
                 expect(msg.properties[:delivery_mode]).to eq(1)
-                expect(msg.delivery_info.exchange).to eq("")
+                expect(msg.delivery_info.exchange).to eq('')
                 expect(msg.delivery_info.routing_key).to eq(subject.name)
               end
+              include_examples 'supports publisher confirmations'
             end
-            it_behaves_like "a destination"
+            it_behaves_like 'a destination'
           end
-          context "and bindings are provided" do
-            let(:dest_name) { "binding_test_queue" }
-            let(:exchange) { adapter_context.create_destination("amq.direct", type: :exchange) }
+          context 'and bindings are provided' do
+            let(:dest_name) { 'binding_test_queue' }
+            let(:exchange) { adapter_context.create_destination('amq.direct', type: :exchange) }
 
             it "raises an exception if you don't provide a source" do
               expect {
-                adapter_context.create_destination("bad_bind_queue", type: :queue, exclusive: true, bindings: [{args: {routing_key: "test_exchange_bind"}}])
+                adapter_context.create_destination('bad_bind_queue', type: :queue, exclusive: true, bindings: [{args: {routing_key: 'test_exchange_bind'}}])
               }.to raise_error MessageDriver::Error, /must provide a source/
             end
 
-            it "routes message to the queue through the exchange" do
-              destination = adapter_context.create_destination(dest_name, type: :queue, exclusive: true, bindings: [{source: "amq.direct", args: {routing_key: "test_queue_bind"}}])
-              exchange.publish("test queue bindings", {}, {routing_key: "test_queue_bind"})
+            it 'routes message to the queue through the exchange' do
+              destination = adapter_context.create_destination(dest_name, type: :queue, exclusive: true, bindings: [{source: 'amq.direct', args: {routing_key: 'test_queue_bind'}}])
+              exchange.publish('test queue bindings', {}, routing_key: 'test_queue_bind')
               message = destination.pop_message
               expect(message).to_not be_nil
-              expect(message.body).to eq("test queue bindings")
+              expect(message.body).to eq('test queue bindings')
             end
           end
 
-          context "we are not yet connected to the broker and :no_declare is provided" do
+          context 'we are not yet connected to the broker and :no_declare is provided' do
             it "doesn't cause a connection to the broker" do
               connection.stop
-              adapter_context.create_destination("test_queue", no_declare: true, type: :queue, exclusive: true)
+              adapter_context.create_destination('test_queue', no_declare: true, type: :queue, exclusive: true)
               expect(adapter.connection(false)).to_not be_open
             end
 
-            context "with a server-named queue" do
-              it "raises an error" do
+            context 'with a server-named queue' do
+              it 'raises an error' do
                 expect {
-                  adapter_context.create_destination("", no_declare: true, type: :queue, exclusive: true)
-                }.to raise_error MessageDriver::Error, "server-named queues must be declared, but you provided :no_declare => true"
+                  adapter_context.create_destination('', no_declare: true, type: :queue, exclusive: true)
+                }.to raise_error MessageDriver::Error, 'server-named queues must be declared, but you provided :no_declare => true'
               end
             end
 
-            context "with bindings" do
-              it "raises an error" do
+            context 'with bindings' do
+              it 'raises an error' do
                 expect {
-                  adapter_context.create_destination("tmp_queue", no_declare: true, bindings: [{source: "amq.fanout"}], type: :queue, exclusive: true)
-                }.to raise_error MessageDriver::Error, "queues with bindings must be declared, but you provided :no_declare => true"
+                  adapter_context.create_destination('tmp_queue', no_declare: true, bindings: [{source: 'amq.fanout'}], type: :queue, exclusive: true)
+                }.to raise_error MessageDriver::Error, 'queues with bindings must be declared, but you provided :no_declare => true'
               end
             end
           end
         end
 
-        context "the type is exchange" do
-          context "the resulting destination" do
-            let(:dest_name) { "my_dest" }
+        context 'the type is exchange' do
+          context 'the resulting destination' do
+            let(:dest_name) { 'my_dest' }
             subject(:destination) { adapter_context.create_destination(dest_name, type: :exchange) }
 
             it { should be_a BunnyAdapter::ExchangeDestination }
@@ -227,21 +242,21 @@ module MessageDriver::Adapters
               expect(subject.dest_options).to_not have_key :type
             end
 
-            it "raises an error when pop_message is called" do
+            it 'raises an error when pop_message is called' do
               expect {
                 subject.pop_message(dest_name)
               }.to raise_error MessageDriver::Error, "You can't pop a message off an exchange"
             end
 
-            context "publishing a message" do
-              let(:body) { "Testing the ExchangeDestination" }
-              let(:headers) { {"foo" => "bar"} }
+            context 'publishing a message' do
+              let(:body) { 'Testing the ExchangeDestination' }
+              let(:headers) { {'foo' => 'bar'} }
               let(:properties) { {persistent: false} }
               before { connection.with_channel { |ch| ch.fanout(dest_name, auto_delete: true) } }
               let!(:queue) do
                 q = nil
                 connection.with_channel do |ch|
-                  q = ch.queue("", exclusive: true)
+                  q = ch.queue('', exclusive: true)
                   q.bind(dest_name)
                 end
                 q
@@ -250,7 +265,7 @@ module MessageDriver::Adapters
                 subject.publish(body, headers, properties)
               end
 
-              it "publishes to the specified exchange" do
+              it 'publishes to the specified exchange' do
                 connection.with_channel do |ch|
                   q = ch.queue(queue.name, passive: true)
                   msg = q.pop
@@ -260,19 +275,20 @@ module MessageDriver::Adapters
                   expect(msg[1][:delivery_mode]).to eq(1)
                 end
               end
+              include_examples 'supports publisher confirmations'
             end
           end
 
-          context "declaring an exchange on the broker" do
-            let(:dest_name) { "my.cool.exchange" }
+          context 'declaring an exchange on the broker' do
+            let(:dest_name) { 'my.cool.exchange' }
 
             it "creates the exchange if you include 'declare' in the options" do
               exchange = adapter_context.create_destination(dest_name, type: :exchange, declare: {type: :fanout, auto_delete: true})
-              queue = adapter_context.create_destination("", type: :queue, exclusive: true, bindings: [{source: dest_name}])
-              exchange.publish("test declaring exchange")
+              queue = adapter_context.create_destination('', type: :queue, exclusive: true, bindings: [{source: dest_name}])
+              exchange.publish('test declaring exchange')
               message = queue.pop_message
               expect(message).to_not be_nil
-              expect(message.body).to eq("test declaring exchange")
+              expect(message.body).to eq('test declaring exchange')
             end
 
             it "raises an error if you don't provide a type" do
@@ -283,51 +299,51 @@ module MessageDriver::Adapters
 
           end
 
-          context "and bindings are provided" do
-            let(:dest_name) { "binding_exchange_queue" }
-            let(:exchange) { adapter_context.create_destination("amq.direct", type: :exchange) }
+          context 'and bindings are provided' do
+            let(:dest_name) { 'binding_exchange_queue' }
+            let(:exchange) { adapter_context.create_destination('amq.direct', type: :exchange) }
 
             it "raises an exception if you don't provide a source" do
               expect {
-                adapter_context.create_destination("amq.fanout", type: :exchange, bindings: [{args: {routing_key: "test_exchange_bind"}}])
+                adapter_context.create_destination('amq.fanout', type: :exchange, bindings: [{args: {routing_key: 'test_exchange_bind'}}])
               }.to raise_error MessageDriver::Error, /must provide a source/
             end
 
-            it "routes message to the queue through the exchange" do
-              adapter_context.create_destination("amq.fanout", type: :exchange, bindings: [{source: "amq.direct", args: {routing_key: "test_exchange_bind"}}])
-              destination = adapter_context.create_destination(dest_name, type: :queue, exclusive: true, bindings: [{source: "amq.fanout"}])
-              exchange.publish("test exchange bindings", {}, {routing_key: "test_exchange_bind"})
+            it 'routes message to the queue through the exchange' do
+              adapter_context.create_destination('amq.fanout', type: :exchange, bindings: [{source: 'amq.direct', args: {routing_key: 'test_exchange_bind'}}])
+              destination = adapter_context.create_destination(dest_name, type: :queue, exclusive: true, bindings: [{source: 'amq.fanout'}])
+              exchange.publish('test exchange bindings', {}, routing_key: 'test_exchange_bind')
               message = destination.pop_message
               expect(message).to_not be_nil
-              expect(message.body).to eq("test exchange bindings")
+              expect(message.body).to eq('test exchange bindings')
             end
           end
 
-          context "we are not yet connected to the broker" do
+          context 'we are not yet connected to the broker' do
             it "doesn't cause a connection to the broker" do
               connection.stop
-              adapter_context.create_destination("amq.fanout", type: :exchange)
+              adapter_context.create_destination('amq.fanout', type: :exchange)
               expect(adapter.connection(false)).to_not be_open
             end
           end
         end
 
-        context "the type is invalid" do
-          it "raises in an error" do
+        context 'the type is invalid' do
+          it 'raises in an error' do
             expect {
-              adapter_context.create_destination("my_dest", type: :foo_bar)
+              adapter_context.create_destination('my_dest', type: :foo_bar)
             }.to raise_error MessageDriver::Error, "invalid destination type #{:foo_bar}"
           end
         end
       end
 
-      describe "#subscribe" do
-        context "the destination is an ExchangeDestination" do
-          let(:dest_name) { "my_dest" }
+      describe '#subscribe' do
+        context 'the destination is an ExchangeDestination' do
+          let(:dest_name) { 'my_dest' }
           let(:destination) { adapter_context.create_destination(dest_name, type: :exchange) }
-          let(:consumer) { lambda do |m|; end }
+          let(:consumer) { lambda do |_|; end }
 
-          it "raises an error" do
+          it 'raises an error' do
             expect {
               adapter_context.subscribe(destination, &consumer)
             }.to raise_error MessageDriver::Error, /QueueDestination/

data/spec/integration/in_memory/in_memory_adapter_spec.rb

@@ -4,39 +4,39 @@ require 'message_driver/adapters/in_memory_adapter'
 
 module MessageDriver::Adapters
   describe InMemoryAdapter, :in_memory, type: :integration do
-    let(:broker) { double("broker") }
+    let(:broker) { double('broker') }
     subject(:adapter) { described_class.new(broker) }
 
-    describe "#new_context" do
-      it "returns a InMemoryAdapter::InMemoryContext" do
+    describe '#new_context' do
+      it 'returns a InMemoryAdapter::InMemoryContext' do
         expect(subject.new_context).to be_a InMemoryAdapter::InMemoryContext
       end
     end
 
-    it_behaves_like "an adapter"
+    it_behaves_like 'an adapter'
 
     describe InMemoryAdapter::InMemoryContext do
       subject(:adapter_context) { adapter.new_context }
 
-      it_behaves_like "an adapter context"
-      it_behaves_like "transactions are not supported"
-      it_behaves_like "client acks are not supported"
-      it_behaves_like "subscriptions are supported", InMemoryAdapter::Subscription
+      it_behaves_like 'an adapter context'
+      it_behaves_like 'transactions are not supported'
+      it_behaves_like 'client acks are not supported'
+      it_behaves_like 'subscriptions are supported', InMemoryAdapter::Subscription
     end
 
-    describe "#create_destination" do
-      describe "the resulting destination" do
-        subject(:destination) { adapter.create_destination("my_test_dest") }
+    describe '#create_destination' do
+      describe 'the resulting destination' do
+        subject(:destination) { adapter.create_destination('my_test_dest') }
 
         it { should be_a InMemoryAdapter::Destination }
 
-        it_behaves_like "a destination"
-        include_examples "supports #message_count"
+        it_behaves_like 'a destination'
+        include_examples 'supports #message_count'
       end
 
-      context "when creating two destinations for the same queue" do
-        it "creates seperate destination instances" do
-          queue_name = "my_queue"
+      context 'when creating two destinations for the same queue' do
+        it 'creates seperate destination instances' do
+          queue_name = 'my_queue'
           dest1 = adapter.create_destination(queue_name)
           dest2 = adapter.create_destination(queue_name)
           expect(dest1).to_not be(dest2)
@@ -44,8 +44,8 @@ module MessageDriver::Adapters
       end
     end
 
-    describe "#reset_after_tests" do
-      it "empties all the destination queues" do
+    describe '#reset_after_tests' do
+      it 'empties all the destination queues' do
         destinations = (1..3).map(&adapter.method(:create_destination))
         destinations.each do |destination|
           destination.publish("There's always money in the banana stand!", {}, {})
@@ -58,9 +58,9 @@ module MessageDriver::Adapters
         end
       end
 
-      it "removes any existing subscriptions" do
+      it 'removes any existing subscriptions' do
         destinations = (1..3).map(&adapter.method(:create_destination))
-        consumer = lambda do |m| end
+        consumer = lambda do |_| end
         destinations.each do |destination|
           destination.subscribe(&consumer)
         end
@@ -74,43 +74,43 @@ module MessageDriver::Adapters
       end
     end
 
-    describe "accessing the same queue from two destinations" do
-      let(:queue_name) { "my_queue" }
+    describe 'accessing the same queue from two destinations' do
+      let(:queue_name) { 'my_queue' }
       let(:dest1) { adapter.create_destination(queue_name) }
       let(:dest2) { adapter.create_destination(queue_name) }
 
-      context "when I have a consumer on one destination" do
-        let(:consumer) { lambda do |m| end }
+      context 'when I have a consumer on one destination' do
+        let(:consumer) { lambda do |_| end }
         before do
           dest1.subscribe(&consumer)
         end
-        it "is the same consumer on the other destination" do
+        it 'is the same consumer on the other destination' do
           expect(dest2.subscription.consumer).to be(consumer)
         end
       end
 
-      context "when I publish a message to one destination" do
-        it "changes the message_count on the other" do
+      context 'when I publish a message to one destination' do
+        it 'changes the message_count on the other' do
           expect {
-            dest1.publish("my test message")
+            dest1.publish('my test message')
           }.to change{dest2.message_count}.from(0).to(1)
         end
 
-        it "can be popped off the other" do
-          dest1.publish("my test message")
+        it 'can be popped off the other' do
+          dest1.publish('my test message')
           msg = dest2.pop_message
           expect(msg).to_not be_nil
-          expect(msg.body).to eq("my test message")
+          expect(msg.body).to eq('my test message')
         end
       end
 
-      context "when I pop a message off one destination" do
-        let(:message_body) { "test popping a message" }
+      context 'when I pop a message off one destination' do
+        let(:message_body) { 'test popping a message' }
         before do
           dest2.publish(message_body)
         end
 
-        it "changes the message_count on the other" do
+        it 'changes the message_count on the other' do
           expect {
             dest1.pop_message
           }.to change{dest2.message_count}.from(1).to(0)
@@ -118,7 +118,7 @@ module MessageDriver::Adapters
       end
     end
 
-    describe "subscribing a consumer" do
+    describe 'subscribing a consumer' do
       let(:destination) { adapter.create_destination(:my_queue) }
 
       let(:subscription_type) { MessageDriver::Adapters::InMemoryAdapter::Subscription }