mcollective-client 2.0.0 → 2.2.0

data/spec/unit/plugins/mcollective/connector/stomp_spec.rb

@@ -102,6 +102,7 @@ module MCollective
                         "stomp.pool.max_reconnect_attempts" => "5",
                         "stomp.pool.randomize" => "true",
                         "stomp.pool.backup" => "true",
+                        "stomp.pool.connect_timeout" => 30,
                         "stomp.pool.timeout" => "1"}
 
 
@@ -120,6 +121,7 @@ module MCollective
                                        :use_exponential_back_off => false,
                                        :max_reconnect_attempts => 5,
                                        :initial_reconnect_delay => 0.02,
+                                       :connect_timeout => 30,
                                        :randomize => true,
                                        :reliable => true,
                                        :logger => "logger",

data/spec/unit/plugins/mcollective/data/agent_data_spec.rb

@@ -0,0 +1,43 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+
+require File.dirname(__FILE__) + "/../../../../../plugins/mcollective/data/agent_data.rb"
+
+module MCollective
+  module Data
+    describe Agent_data do
+      describe "#query_data" do
+        before do
+          @ddl = mock
+          @ddl.stubs(:meta).returns({:timeout => 1})
+          DDL.stubs(:new).returns(@ddl)
+          @plugin = Agent_data.new
+        end
+
+        it "should fail for unknown agents" do
+          expect { @plugin.query_data("rspec") }.to raise_error("No agent called rspec found")
+        end
+
+        it "should retrieve the correct agent and data" do
+          agent = mock
+          agent.stubs(:meta).returns({:license => "license",
+                                        :timeout => "timeout",
+                                        :description => "description",
+                                        :url => "url",
+                                        :version => "version",
+                                        :author => "author"})
+
+          PluginManager.stubs(:[]).with("rspec_agent").returns(agent)
+          PluginManager.expects(:include?).with("rspec_agent").returns(true)
+
+          @plugin.query_data("rspec")
+
+          [:license, :timeout, :description, :url, :version, :author].each do |item|
+            @plugin.result[item].should == item.to_s
+          end
+        end
+      end
+    end
+  end
+end

data/spec/unit/plugins/mcollective/data/fstat_data_spec.rb

@@ -0,0 +1,135 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+
+require File.dirname(__FILE__) + "/../../../../../plugins/mcollective/data/fstat_data.rb"
+
+module MCollective
+  module Data
+    describe Fstat_data do
+      describe "#query_data" do
+        before do
+          @ddl = mock
+          @ddl.stubs(:meta).returns({:timeout => 1})
+          DDL.stubs(:new).returns(@ddl)
+          @plugin = Fstat_data.new
+
+          @time = Time.now
+
+          @stat = mock
+          @stat.stubs(:size).returns(123)
+          @stat.stubs(:uid).returns(0)
+          @stat.stubs(:gid).returns(0)
+          @stat.stubs(:mtime).returns(@time)
+          @stat.stubs(:ctime).returns(@time)
+          @stat.stubs(:atime).returns(@time)
+          @stat.stubs(:mode).returns(33188)
+          @stat.stubs(:directory?).returns(false)
+          @stat.stubs(:file?).returns(false)
+          @stat.stubs(:symlink?).returns(false)
+          @stat.stubs(:socket?).returns(false)
+          @stat.stubs(:chardev?).returns(false)
+          @stat.stubs(:blockdev?).returns(false)
+        end
+
+        it "should detect missing files" do
+          File.expects(:exists?).with("/nonexisting").returns(false)
+          @plugin.query_data("/nonexisting")
+          @plugin.result.output.should == "not present"
+        end
+
+        it "should provide correct file stats" do
+          File.expects(:exists?).with("rspec").returns(true)
+          File.expects(:symlink?).with("rspec").returns(false)
+          File.expects(:stat).with("rspec").returns(@stat)
+          File.expects(:read).with("rspec").returns("rspec")
+
+          @stat.stubs(:file?).returns(true)
+
+          @plugin.query_data("rspec")
+          @plugin.result.output.should == "present"
+          @plugin.result.size.should == 123
+          @plugin.result.uid.should == 0
+          @plugin.result.gid.should == 0
+          @plugin.result.mtime.should == @time.strftime("%F %T")
+          @plugin.result.mtime_seconds.should == @time.to_i
+          @plugin.result.mtime_age.should <= 5
+          @plugin.result.ctime.should == @time.strftime("%F %T")
+          @plugin.result.ctime_seconds.should == @time.to_i
+          @plugin.result.ctime_age.should <= 5
+          @plugin.result.atime.should == @time.strftime("%F %T")
+          @plugin.result.atime_seconds.should == @time.to_i
+          @plugin.result.atime_age.should <= 5
+          @plugin.result.mode.should == "100644"
+          @plugin.result.md5.should == "2bc84dc69b73db9383b9c6711d2011b7"
+          @plugin.result.type.should == "file"
+        end
+
+        it "should provide correct link stats" do
+          File.expects(:exists?).with("rspec").returns(true)
+          File.expects(:symlink?).with("rspec").returns(true)
+          File.expects(:lstat).with("rspec").returns(@stat)
+
+          @stat.stubs(:symlink?).returns(true)
+
+          @plugin.query_data("rspec")
+          @plugin.result.output.should == "present"
+          @plugin.result.md5.should == 0
+          @plugin.result.type.should == "symlink"
+        end
+
+        it "should provide correct directory stats" do
+          File.expects(:exists?).with("rspec").returns(true)
+          File.expects(:symlink?).with("rspec").returns(false)
+          File.expects(:stat).with("rspec").returns(@stat)
+
+          @stat.stubs(:directory?).returns(true)
+
+          @plugin.query_data("rspec")
+          @plugin.result.output.should == "present"
+          @plugin.result.md5.should == 0
+          @plugin.result.type.should == "directory"
+        end
+
+        it "should provide correct socket stats" do
+          File.expects(:exists?).with("rspec").returns(true)
+          File.expects(:symlink?).with("rspec").returns(false)
+          File.expects(:stat).with("rspec").returns(@stat)
+
+          @stat.stubs(:socket?).returns(true)
+
+          @plugin.query_data("rspec")
+          @plugin.result.output.should == "present"
+          @plugin.result.md5.should == 0
+          @plugin.result.type.should == "socket"
+        end
+
+        it "should provide correct chardev stats" do
+          File.expects(:exists?).with("rspec").returns(true)
+          File.expects(:symlink?).with("rspec").returns(false)
+          File.expects(:stat).with("rspec").returns(@stat)
+
+          @stat.stubs(:chardev?).returns(true)
+
+          @plugin.query_data("rspec")
+          @plugin.result.output.should == "present"
+          @plugin.result.md5.should == 0
+          @plugin.result.type.should == "chardev"
+        end
+
+        it "should provide correct blockdev stats" do
+          File.expects(:exists?).with("rspec").returns(true)
+          File.expects(:symlink?).with("rspec").returns(false)
+          File.expects(:stat).with("rspec").returns(@stat)
+
+          @stat.stubs(:blockdev?).returns(true)
+
+          @plugin.query_data("rspec")
+          @plugin.result.output.should == "present"
+          @plugin.result.md5.should == 0
+          @plugin.result.type.should == "blockdev"
+        end
+      end
+    end
+  end
+end

data/spec/unit/plugins/mcollective/discovery/flatfile_spec.rb

@@ -0,0 +1,48 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+
+require File.dirname(__FILE__) + '/../../../../../plugins/mcollective/discovery/flatfile.rb'
+
+module MCollective
+  class Discovery
+    describe Flatfile do
+      describe "#discover" do
+        before do
+          @client = mock
+          @client.stubs(:options).returns({})
+          @client.stubs(:options).returns({:discovery_options => ["/nonexisting"]})
+
+
+          File.stubs(:readable?).with("/nonexisting").returns(true)
+          File.stubs(:readlines).with("/nonexisting").returns(["one", "two"])
+        end
+
+        it "should use a file specified in discovery_options" do
+          File.expects(:readable?).with("/nonexisting").returns(true)
+          File.expects(:readlines).with("/nonexisting").returns(["one", "two"])
+          Flatfile.discover(Util.empty_filter, 0, 0, @client).should == ["one", "two"]
+        end
+
+        it "should fail unless a file is specified" do
+          @client.stubs(:options).returns({:discovery_options => []})
+          expect { Flatfile.discover(Util.empty_filter, 0, 0, @client) }.to raise_error("The flatfile discovery method needs a path to a text file")
+        end
+
+        it "should fail for unreadable files" do
+          File.expects(:readable?).with("/nonexisting").returns(false)
+
+          expect { Flatfile.discover(Util.empty_filter, 0, 0, @client) }.to raise_error("Cannot read the file /nonexisting specified as discovery source")
+        end
+
+        it "should regex filters" do
+          Flatfile.discover(Util.empty_filter.merge("identity" => [/one/]), 0, 0, @client).should == ["one"]
+        end
+
+        it "should filter against non regex nodes" do
+          Flatfile.discover(Util.empty_filter.merge("identity" => ["one"]), 0, 0, @client).should == ["one"]
+        end
+      end
+    end
+  end
+end

data/spec/unit/plugins/mcollective/discovery/mc_spec.rb

@@ -0,0 +1,40 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+
+require File.dirname(__FILE__) + '/../../../../../plugins/mcollective/discovery/mc.rb'
+
+module MCollective
+  class Discovery
+    describe Mc do
+      describe "#discover" do
+        before do
+          @reply = mock
+          @reply.stubs(:payload).returns({:senderid => "rspec"})
+
+          @client = mock
+          @client.stubs(:sendreq)
+          @client.stubs(:unsubscribe)
+          @client.stubs(:receive).returns(@reply)
+
+          Log.stubs(:debug)
+        end
+
+        it "should send the ping request via the supplied client" do
+          @client.expects(:sendreq).with("ping", "discovery", Util.empty_filter).returns("123456")
+          Mc.discover(Util.empty_filter, 1, 1, @client)
+        end
+
+        it "should stop early if a limit is supplied" do
+          @client.stubs(:receive).returns(@reply).times(10)
+          Mc.discover(Util.empty_filter, 1, 10, @client).should == ("rspec," * 10).split(",")
+        end
+
+        it "should unsubscribe from the discovery reply source" do
+          @client.expects(:unsubscribe).with("discovery", :reply)
+          Mc.discover(Util.empty_filter, 1, 10, @client).should == ("rspec," * 10).split(",")
+        end
+      end
+    end
+  end
+end

data/spec/unit/plugins/mcollective/packagers/debpackage_packager_spec.rb

@@ -19,6 +19,7 @@ module MCollective
       before :each do
         PluginPackager.stubs(:build_tool?).with("debuild").returns(true)
         @plugin = mock()
+        @plugin.stubs(:mcname).returns("mcollective")
       end
 
       after :all do
@@ -30,7 +31,7 @@ module MCollective
           PluginPackager.expects(:build_tool?).with("debuild").returns(false)
           expect{
             DebpackagePackager.new("plugin")
-          }.to raise_error RuntimeError, "package 'debuild' is not installed"
+          }.to raise_error(RuntimeError, "package 'debuild' is not installed")
         end
 
         it "should set the correct libdir and verbose value" do
@@ -49,6 +50,7 @@ module MCollective
           @plugin.stubs(:iteration).returns("1")
           @packager.stubs(:prepare_tmpdirs)
           @packager.stubs(:create_package)
+          @packager.stubs(:move_packages)
           @packager.stubs(:cleanup_tmpdirs)
           Dir.stubs(:mktmpdir).with("mcollective_packager").returns("/tmp")
           Dir.stubs(:mkdir)
@@ -63,7 +65,7 @@ module MCollective
         end
 
         it "Should create the build dir" do
-          Dir.expects(:mkdir).with("/tmp/mcollective-test_plugin-test_1-1")
+          Dir.expects(:mkdir).with("/tmp/mcollective-test_plugin-test_1")
           @packager.create_packages
         end
 
@@ -79,7 +81,7 @@ module MCollective
           packager.stubs(:create_file).raises("test exception")
           expect{
             packager.create_package
-          }.to raise_error RuntimeError, "Could not build package - test exception"
+          }.to raise_error(RuntimeError, "Could not build package - test exception")
         end
 
         it "should correctly create a package" do
@@ -99,7 +101,6 @@ module MCollective
           packager.tmpdir = "/tmp"
           packager.current_package_fullname = "test"
           PluginPackager.expects(:safe_system).with("debuild -i -us -uc")
-          FileUtils.expects(:cp).with(File.join("/tmp", "test_all.deb"), ".")
           packager.expects(:puts).with("Created package test")
 
           packager.create_package
@@ -122,7 +123,6 @@ module MCollective
           packager.tmpdir = "/tmp"
           packager.current_package_fullname = "test"
           PluginPackager.expects(:safe_system).with("debuild -i -ktest")
-          FileUtils.expects(:cp).with(File.join("/tmp", "test_all.deb"), ".")
           packager.expects(:puts).with("Created package test")
 
           packager.create_package
@@ -139,7 +139,7 @@ module MCollective
           File.expects(:exists?).with("myscript").returns(false)
           expect{
             @packager.create_preandpost_install
-          }.to raise_error RuntimeError, "pre-install script 'myscript' not found"
+          }.to raise_error(RuntimeError, "pre-install script 'myscript' not found")
         end
 
         it "should raise an exception if postinstall is not null and postinstall script isn't present" do
@@ -148,7 +148,7 @@ module MCollective
           File.expects(:exists?).with("myscript").returns(false)
           expect{
             @packager.create_preandpost_install
-          }.to raise_error RuntimeError, "post-install script 'myscript' not found"
+          }.to raise_error(RuntimeError, "post-install script 'myscript' not found")
         end
 
         it "should copy the preinstall and postinstall scripts to the correct directory with the correct name" do
@@ -166,13 +166,14 @@ module MCollective
       describe "#create_install" do
         before :each do
           @packager = DebpackagePackager.new(@plugin)
+          @plugin.stubs(:path).returns("")
         end
 
         it "should raise an exception if the install file can't be created" do
           File.expects(:join).raises("test error")
           expect{
             @packager.create_install
-          }.to raise_error RuntimeError, "Could not create install file - test error"
+          }.to raise_error(RuntimeError, "Could not create install file - test error")
         end
 
         it "should copy the package install file to the correct location" do
@@ -183,7 +184,29 @@ module MCollective
           @packager.current_package_data = {:files => ["foo.rb"]}
           @packager.create_install
           install_file = File.read("#{tmpdir}/debian/test.install")
-          install_file.should == "/usr/share/mcollective/plugins/mcollective/foo.rb /usr/share/mcollective/plugins/mcollective/.\n"
+          install_file.should == "/usr/share/mcollective/plugins/mcollective/foo.rb /usr/share/mcollective/plugins/mcollective\n"
+        end
+      end
+
+      describe "#move_packages" do
+        before :each do
+          @plugin = mock()
+        end
+
+        it "should move the packages to the working directory" do
+          Dir.expects(:glob)
+          File.expects(:join)
+          FileUtils.expects(:cp)
+          @packager = DebpackagePackager.new(@plugin)
+          @packager.move_packages
+        end
+
+        it "should raise an error if the packages could not be moved" do
+          @packager = DebpackagePackager.new(@plugin)
+          File.expects(:join).raises("error")
+          expect{
+            @packager.move_packages
+          }.to raise_error(RuntimeError, "Could not copy packages to working directory: 'error'")
         end
       end
 
@@ -196,7 +219,7 @@ module MCollective
           PluginPackager.expects(:do_quietly?).raises("test error")
           expect{
             @packager.create_tar
-          }.to raise_error RuntimeError, "Could not create tarball - test error"
+          }.to raise_error(RuntimeError, "Could not create tarball - test error")
         end
 
         it "should create a tarball containing the package files" do
@@ -206,7 +229,7 @@ module MCollective
           @plugin.stubs(:metadata).returns(@plugin)
           @plugin.stubs(:[]).with(:version).returns("1")
           @plugin.stubs(:iteration).returns("1")
-          PluginPackager.expects(:safe_system).with("tar -Pcvzf /tmp/test_1.orig.tar.gz /build_dir")
+          PluginPackager.expects(:safe_system).with("tar -Pcvzf /tmp/test_1.orig.tar.gz test_1")
           @packager.create_tar
         end
       end
@@ -220,7 +243,7 @@ module MCollective
           File.expects(:dirname).raises("test error")
           expect{
             @packager.create_file("test")
-          }.to raise_error RuntimeError, "could not create test file - test error"
+          }.to raise_error(RuntimeError, "could not create test file - test error")
         end
 
         it "should place a build file in the debian directory" do
@@ -237,12 +260,15 @@ module MCollective
       end
 
       describe "#prepare_tmpdirs" do
-        before :all do
+        before :each do
           @tmpfile = Tempfile.new("mc-file").path
         end
 
-        after :all do
-          FileUtils.rm(@tmpfile)
+        after :each do
+          begin
+            FileUtils.rm(@tmpfile)
+          rescue Exception
+          end
         end
 
         it "should create the correct tmp dirs and copy package contents to correct dir" do