mcollective-client 2.0.0 → 2.2.0

data/spec/fixtures/util/1.in

@@ -0,0 +1,10 @@
+    This is a string This is a string This is a string This is a string This is a string This is a string This is a string
+    This is a string This is a string This is a string This is a string This is a string This is a string This is a string
+    This is a string This is a string This is a string This is a string This is a string This is a string This is a string
+
+        foo
+              bar
+
+    This is a string This is a string This is a string This is a string This is a string This is a string This is a string
+    This is a string This is a string This is a string This is a string This is a string This is a string This is a string
+    This is a string This is a string This is a string This is a string This is a string This is a string This is a string

data/spec/fixtures/util/1.out

@@ -0,0 +1,10 @@
+         This is a string This is a string This is a string This is a string This is a string This is a string This is a string
+         This is a string This is a string This is a string This is a string This is a string This is a string This is a string
+         This is a string This is a string This is a string This is a string This is a string This is a string This is a string
+     
+             foo
+                   bar
+     
+         This is a string This is a string This is a string This is a string This is a string This is a string This is a string
+         This is a string This is a string This is a string This is a string This is a string This is a string This is a string
+         This is a string This is a string This is a string This is a string This is a string This is a string This is a string

data/spec/fixtures/util/2.in

@@ -0,0 +1 @@
+foooooooooooooooooooooooooooooooooooooooooooooooooooo

data/spec/fixtures/util/2.out

@@ -0,0 +1 @@
+     foooooooooooooooooooooooooooooooooooooooooooooooooooo

data/spec/fixtures/util/3.in

@@ -0,0 +1 @@
+  Strings Strings Strings Strings Strings Strings

data/spec/fixtures/util/3.out

@@ -0,0 +1,2 @@
+  Strings Strings Strings
+  Strings Strings Strings

data/spec/fixtures/util/4.in

@@ -0,0 +1,5 @@
+this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text
+
+      foo(bar)
+
+this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text this is usage text

data/spec/fixtures/util/4.out

@@ -0,0 +1,9 @@
+   this is usage text this is usage text this is usage text this is usage text
+   this is usage text this is usage text this is usage text this is usage text
+   this is usage text this is usage text this is usage text this is usage text  
+   
+         foo(bar)
+   
+   this is usage text this is usage text this is usage text this is usage text
+   this is usage text this is usage text this is usage text this is usage text
+   this is usage text this is usage text this is usage text this is usage text

data/spec/spec.opts

@@ -1 +1 @@
---format s --colour --backtrace
+--colour --backtrace

data/spec/spec_helper.rb

@@ -1,6 +1,7 @@
 dir = File.expand_path(File.dirname(__FILE__))
 $LOAD_PATH.unshift("#{dir}/")
 $LOAD_PATH.unshift("#{dir}/../lib")
+$LOAD_PATH.unshift("#{dir}/../plugins")
 
 require 'rubygems'
 
@@ -21,6 +22,7 @@ RSpec.configure do |config|
   config.mock_with :mocha
 
   config.before :each do
+    MCollective::Config.instance.set_config_defaults("")
     MCollective::PluginManager.clear
   end
 end

data/spec/unit/agents_spec.rb

@@ -27,7 +27,7 @@ module MCollective
 
     describe "#initialize" do
       it "should fail if configuration has not been loaded" do
-        Config.any_instance.expects(:configured).returns(false)
+        Config.instance.expects(:configured).returns(false)
 
         expect {
           Agents.new
@@ -35,7 +35,7 @@ module MCollective
       end
 
       it "should load agents" do
-        Config.any_instance.expects(:configured).returns(true)
+        Config.instance.expects(:configured).returns(true)
         Agents.any_instance.expects(:loadagents).once
 
         Agents.new
@@ -44,8 +44,8 @@ module MCollective
 
     describe "#clear!" do
       it "should delete and unsubscribe all loaded agents" do
-        Config.any_instance.expects(:configured).returns(true).at_least_once
-        Config.any_instance.expects(:libdir).returns([@tmpdir])
+        Config.instance.expects(:configured).returns(true).at_least_once
+        Config.instance.expects(:libdir).returns([@tmpdir])
         PluginManager.expects(:delete).with("foo_agent").once
         Util.expects(:make_subscriptions).with("foo", :broadcast).returns("foo_target")
         Util.expects(:unsubscribe).with("foo_target")
@@ -56,8 +56,8 @@ module MCollective
 
     describe "#loadagents" do
       before do
-        Config.any_instance.stubs(:configured).returns(true)
-        Config.any_instance.stubs(:libdir).returns([@tmpdir])
+        Config.instance.stubs(:configured).returns(true)
+        Config.instance.stubs(:libdir).returns([@tmpdir])
         Agents.any_instance.stubs("clear!").returns(true)
       end
 
@@ -67,7 +67,7 @@ module MCollective
       end
 
       it "should attempt to load agents from all libdirs" do
-        Config.any_instance.expects(:libdir).returns(["/nonexisting", "/nonexisting"])
+        Config.instance.expects(:libdir).returns(["/nonexisting", "/nonexisting"])
         File.expects("directory?").with("/nonexisting/mcollective/agent").twice
 
         a = Agents.new
@@ -94,10 +94,11 @@ module MCollective
     describe "#loadagent" do
       before do
         FileUtils.touch(File.join([@agentsdir, "test.rb"]))
-        Config.any_instance.stubs(:configured).returns(true)
-        Config.any_instance.stubs(:libdir).returns([@tmpdir])
+        Config.instance.stubs(:configured).returns(true)
+        Config.instance.stubs(:libdir).returns([@tmpdir])
         Agents.any_instance.stubs("clear!").returns(true)
         PluginManager.stubs(:loadclass).returns(true)
+        PluginManager.stubs("[]").with("test_agent").returns(true)
         Util.stubs(:make_subscriptions).with("test", :broadcast).returns([{:agent => "test", :type => :broadcast, :collective => "test"}])
         Util.stubs(:subscribe).with([{:agent => "test", :type => :broadcast, :collective => "test"}]).returns(true)
         Agents.stubs(:findagentfile).returns(File.join([@agentsdir, "test.rb"]))
@@ -153,12 +154,26 @@ module MCollective
         Util.stubs(:make_subscriptions).with("foo", :broadcast).returns([{:agent => "foo", :type => :broadcast, :collective => "test"}])
         Util.expects("subscribe").with([{:type => :broadcast, :agent => 'foo', :collective => 'test'}]).returns(true)
         Agents.any_instance.expects(:findagentfile).with("foo").returns(File.join([@agentsdir, "foo.rb"]))
-
         FileUtils.touch(File.join([@agentsdir, "foo.rb"]))
+        Agents.any_instance.expects("activate_agent?").with("foo").returns(true)
+        PluginManager.stubs("[]").with("foo_agent").returns(true)
 
         @a.loadagent("foo")
       end
 
+      it "should check if an agent is loadable and remove it from the list if not" do
+        PluginManager.expects("<<").with({:type => "foo_agent", :class => "MCollective::Agent::Foo", :single_instance => false})
+        Agents.any_instance.expects(:findagentfile).with("foo").returns(File.join([@agentsdir, "foo.rb"]))
+        FileUtils.touch(File.join([@agentsdir, "foo.rb"]))
+        Agents.any_instance.expects("activate_agent?").with("foo").returns(true)
+        PluginManager.stubs("[]").with("foo_agent").raises("rspec")
+
+        Log.expects(:error).once.with("Loading agent foo failed: rspec")
+
+        @a.loadagent("foo").should == false
+        Agents.agentlist.include?("foo").should == false
+      end
+
       it "should add the agent to the agent list" do
         Agents.agentlist.should == ["test"]
       end
@@ -183,7 +198,7 @@ module MCollective
 
     describe "#class_for_agent" do
       it "should return the correct class" do
-        Config.any_instance.stubs(:configured).returns(true)
+        Config.instance.stubs(:configured).returns(true)
         Agents.any_instance.stubs(:loadagents).returns(true)
         Agents.new.class_for_agent("foo").should == "MCollective::Agent::Foo"
       end
@@ -191,7 +206,7 @@ module MCollective
 
     describe "#activate_agent?" do
       before do
-        Config.any_instance.stubs(:configured).returns(true)
+        Config.instance.stubs(:configured).returns(true)
         Agents.any_instance.stubs(:loadagents).returns(true)
         @a = Agents.new
 
@@ -225,14 +240,14 @@ module MCollective
 
     describe "#findagentfile" do
       before do
-        Config.any_instance.stubs(:configured).returns(true)
-        Config.any_instance.stubs(:libdir).returns([@tmpdir])
+        Config.instance.stubs(:configured).returns(true)
+        Config.instance.stubs(:libdir).returns([@tmpdir])
         Agents.any_instance.stubs(:loadagents).returns(true)
         @a = Agents.new
       end
 
       it "should support multiple libdirs" do
-        Config.any_instance.expects(:libdir).returns([@tmpdir, @tmpdir]).once
+        Config.instance.expects(:libdir).returns([@tmpdir, @tmpdir]).once
         File.expects("exist?").returns(false).twice
         @a.findagentfile("test")
       end
@@ -255,8 +270,8 @@ module MCollective
 
     describe "#include?" do
       it "should correctly report the plugin state" do
-        Config.any_instance.stubs(:configured).returns(true)
-        Config.any_instance.stubs(:libdir).returns([@tmpdir])
+        Config.instance.stubs(:configured).returns(true)
+        Config.instance.stubs(:libdir).returns([@tmpdir])
         Agents.any_instance.stubs(:loadagents).returns(true)
         PluginManager.expects("include?").with("test_agent").returns(true)
 
@@ -268,8 +283,8 @@ module MCollective
 
     describe "#agentlist" do
       it "should return the correct agent list" do
-        Config.any_instance.stubs(:configured).returns(true)
-        Config.any_instance.stubs(:libdir).returns([@tmpdir])
+        Config.instance.stubs(:configured).returns(true)
+        Config.instance.stubs(:libdir).returns([@tmpdir])
         Agents.any_instance.stubs(:loadagents).returns(true)
 
         @a = Agents.new("test" => true)

data/spec/unit/aggregate/base_spec.rb

@@ -0,0 +1,57 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+
+module MCollective
+  class Aggregate
+    describe Base do
+      describe "#initialize" do
+        it "should set the correct instance variables and call the startup hook" do
+          Base.any_instance.expects(:startup_hook).once
+          base = Base.new("value", [], "%s%s", "rspec")
+          base.name.should == "MCollective::Aggregate::Base"
+          base.output_name.should == "value"
+          base.aggregate_format.should == "%s%s"
+          base.action.should == "rspec"
+        end
+      end
+
+      describe "#startup_hook and #process_result" do
+        it "should raise an exception for an unimplemented startup_hook method " do
+          expect{
+            base = Base.new("value", [], "", "rspec")
+          }.to raise_error(RuntimeError, "'startup_hook' method of function class MCollective::Aggregate::Base has not yet been implemented")
+        end
+
+        it "should raise an exception for an unimplemented process_result method" do
+          Base.any_instance.stubs(:startup_hook)
+          base = Base.new("value", [], "", "rspec")
+          expect{
+            base.process_result
+          }.to raise_error(RuntimeError,"'process_result' method of function class MCollective::Aggregate::Base has not yet been implemented")
+        end
+      end
+
+      describe "summarize" do
+        it "should raise and exception if the result type has not been set" do
+          Base.any_instance.stubs(:startup_hook)
+          base = Base.new("value", [], "", "rspec")
+          expect{
+            base.summarize
+          }.to raise_error(RuntimeError, "Result type is not set while trying to summarize aggregate function results")
+        end
+
+        it "should return the correct result class if result type has been set" do
+          result_object = mock
+          result_object.stubs(:new)
+
+          Base.any_instance.stubs(:startup_hook)
+          base = Base.new("value", [], "", "rspec")
+          base.result[:type] = :result_type
+          base.expects(:result_class).with(:result_type).returns(result_object)
+          base.summarize
+        end
+      end
+    end
+  end
+end

data/spec/unit/aggregate/result/base_spec.rb

@@ -0,0 +1,28 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+
+module MCollective
+  class Aggregate
+    module Result
+      describe Base do
+        describe "#initialize" do
+          it "should raise an exception if neither the ddl or the aggregate function defines a format" do
+            expect{
+              base = Base.new(:structure, nil, :action)
+            }.to raise_error(RuntimeError, "No aggregate_format defined in ddl or aggregate function")
+          end
+        end
+
+        describe "#to_s" do
+          it "should raise an exception if the to_s method isn't implemented" do
+            base = Base.new(:structure, :aggregate_format, :action)
+            expect{
+              base.to_s
+            }.to raise_error(RuntimeError, "'to_s' method not implemented for result class 'MCollective::Aggregate::Result::Base'")
+          end
+        end
+      end
+    end
+  end
+end

data/spec/unit/aggregate/result/collection_result_spec.rb

@@ -0,0 +1,18 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+
+module MCollective
+  class Aggregate
+    module Result
+      describe CollectionResult do
+        describe "#to_s" do
+         it "should return the correctly formatted string" do
+           result = CollectionResult.new({:output => [:test], :value => {"foo" => 3, "bar" => 2}}, "%s:%s", :action).to_s
+           result.should == "    foo:3\n    bar:2"
+         end
+        end
+      end
+    end
+  end
+end

data/spec/unit/aggregate/result/numeric_result_spec.rb

@@ -0,0 +1,22 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+
+module MCollective
+  class Aggregate
+    module Result
+      describe NumericResult do
+        describe "#to_s" do
+          it "should return empty string when no results were computed" do
+            NumericResult.new({}, "test %d", :action).to_s.should == ""
+          end
+
+          it "should return the correctly formatted string" do
+            num = NumericResult.new({:value => 1}, "test %d", :action).to_s
+            num.should == "test 1"
+          end
+        end
+      end
+    end
+  end
+end

data/spec/unit/aggregate_spec.rb

@@ -0,0 +1,110 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+
+module MCollective
+  describe Aggregate do
+    let(:ddl) do
+      {
+        :aggregate => [{:function => :func, :args=>[:value], :format => "%s"}],
+        :action => "test_action",
+        :output => {:foo => nil, :bar => nil}
+      }
+    end
+
+    describe '#create_functions' do
+      before :each do
+        Aggregate.any_instance.stubs(:contains_output?)
+      end
+
+      it "should load all the functions with a format if defined" do
+        function = mock
+        function.expects(:new).with(:value, [], "%s", 'test_action')
+        Aggregate.any_instance.expects(:load_function).once.returns(function)
+        @aggregate = Aggregate.new(ddl)
+      end
+
+      it "should load all the functions without a format if it isn't defined" do
+        function = mock
+        function.expects(:new).with(:value, [], nil, 'test_action')
+        Aggregate.any_instance.expects(:load_function).once.returns(function)
+        ddl[:aggregate].first[:format] = nil
+        @aggregate = Aggregate.new(ddl)
+      end
+    end
+
+    describe '#contains_ouput?' do
+      before :all do
+        Aggregate.any_instance.stubs(:create_functions)
+        @aggregate = Aggregate.new(ddl)
+      end
+
+      it "should raise an exception if the ddl output does not include the function's input" do
+        expect{
+          @aggregate.contains_output?(:baz)
+        }.to raise_error("'test_action' action does not contain output 'baz'")
+      end
+
+      it "should not raise an exception if the ddl output includes the function's input" do
+        @aggregate.contains_output?(:foo)
+      end
+    end
+
+    describe '#call_functions' do
+      it "should call all of the functions" do
+        Aggregate.any_instance.stubs(:create_functions)
+        aggregate = Aggregate.new(ddl)
+
+        result = RPC::Result.new("rspec", "rspec", :sender => "rspec", :statuscode => 0, :statusmsg => "rspec", :data => {:test => :result})
+
+        function = mock
+        function.expects(:process_result).with(:result, result).once
+        function.expects(:output_name).returns(:test)
+
+        aggregate.functions = [function]
+
+        aggregate.call_functions(result)
+      end
+    end
+
+    describe '#summarize' do
+      it "should return the ordered function results" do
+        Aggregate.any_instance.stubs(:create_functions)
+        aggregate = Aggregate.new(ddl)
+
+        func1 = mock
+        func1.expects(:summarize).returns(func1)
+        func1.stubs(:result).returns(:output => 5)
+
+        func2 = mock
+        func2.expects(:summarize).returns(func2)
+        func2.stubs(:result).returns(:output => 2)
+
+        aggregate.functions = [func1, func2]
+
+        result = aggregate.summarize
+        result.should == [func2, func1]
+      end
+    end
+
+    describe '#load_function' do
+      before :all do
+        Aggregate.any_instance.stubs(:create_functions)
+        @aggregate = Aggregate.new(ddl)
+      end
+
+      it "should return a class object if it can be loaded" do
+        PluginManager.expects(:loadclass).with("MCollective::Aggregate::Test")
+        Aggregate.expects(:const_get).with("Test")
+        function = @aggregate.load_function("test")
+      end
+
+      it "should raise an exception if the class object cannot be loaded" do
+        PluginManager.expects(:loadclass).with("MCollective::Aggregate::Test")
+        expect {
+          function = @aggregate.load_function("test")
+        }.to raise_error("Aggregate function file 'test.rb' cannot be loaded")
+      end
+    end
+  end
+end