mcollective-client 2.0.0 → 2.2.0

data/spec/unit/pluginpackager/standard_definition_spec.rb

@@ -6,7 +6,7 @@ module MCollective
   module PluginPackager
     describe StandardDefinition do
       before :each do
-        PluginPackager.expects(:get_metadata).once.returns({:name => "foo"})
+        PluginPackager.expects(:get_metadata).once.returns({:name => "foo", :version => 1})
       end
 
       describe "#initialize" do
@@ -16,14 +16,15 @@ module MCollective
         end
 
         it "should set dependencies if present" do
-          plugin = StandardDefinition.new(".", "test plugin", nil, nil, nil, nil, ["foo"], {}, "testplugin")
-          plugin.dependencies.should == ["foo"]
+          plugin = StandardDefinition.new(".", "test plugin", nil, nil, nil, nil, [{:name => "foo", :version => nil}], {}, "testplugin")
+          plugin.dependencies.should == [{:name => "foo", :version => nil},
+                                         {:name => "mcollective-common", :version => nil}]
         end
 
-        it "should set mc server, client and common dependencies" do
-          plugin = StandardDefinition.new(".", "test plugin", nil, nil, nil, nil, [], {:server => "pe-mcollective"}, "testplugin")
-          plugin.mcserver.should == "pe-mcollective"
-          plugin.mccommon.should == "mcollective-common"
+        it "should set mc name and version dependencies" do
+          plugin = StandardDefinition.new(".", "test plugin", nil, nil, nil, nil, [], {:mcname => "pe-mcollective", :mcversion => "1"}, "testplugin")
+          plugin.mcname.should == "pe-mcollective"
+          plugin.mcversion.should == "1"
         end
       end
 
@@ -61,7 +62,8 @@ module MCollective
           Dir.expects(:glob).with("./testplugin/*").returns(["file.rb"])
           plugin = StandardDefinition.new(".", nil, nil, nil, nil, nil, [], {}, "testplugin")
           plugin.packagedata["testplugin"][:files].should == ["file.rb"]
-          plugin.packagedata["testplugin"][:dependencies].should == ["mcollective", "mcollective-foo-common"]
+          plugin.packagedata["testplugin"][:dependencies].should == [{:name => "mcollective-common", :version => nil},
+                                                                     {:name => "mcollective-foo-common", :version => 1}]
         end
       end
 

data/spec/unit/pluginpackager_spec.rb

@@ -0,0 +1,131 @@
+#!/usr/bin/enn rspec
+
+require 'spec_helper'
+
+module MCollective
+  describe PluginPackager do
+    describe "#load_packagers" do
+      it "should load all PluginPackager plugins" do
+        PluginManager.expects(:find_and_load).with("pluginpackager")
+        PluginPackager.load_packagers
+      end
+    end
+
+    describe "#[]" do
+      it "should return the correct class" do
+        PluginPackager.expects(:const_get).with("Foo").returns(:foo)
+        result = PluginPackager["Foo"]
+        result.should == :foo
+      end
+
+      it "should do something else" do
+        expect{
+          PluginPackager["Bar"]
+        }.to raise_error(NameError, 'uninitialized constant MCollective::PluginPackager::Bar')
+      end
+    end
+
+    describe "#get_metadata" do
+      it "should raise an exception if the ddl file can't be loaded" do
+        DDL.expects(:new).with("package", :foo, false)
+        File.stubs(:join)
+        Dir.stubs(:glob).returns('')
+        expect{
+          PluginPackager.get_metadata("/tmp", "foo")
+        }.to raise_error(RuntimeError)
+      end
+
+      it "should load the ddl file and return the metadata" do
+        ddl = mock
+        DDL.expects(:new).with("package", :foo, false).returns(ddl)
+        File.stubs(:join)
+        Dir.stubs(:glob).returns(["foo.ddl"])
+        File.expects(:read).with("foo.ddl").returns("foo_ddl")
+        ddl.expects(:instance_eval).with("foo_ddl")
+        ddl.expects(:meta).returns("metadata")
+        ddl.expects(:requirements).returns({:mcollective => 1})
+
+        meta, requirements = PluginPackager.get_metadata("/tmp", "foo")
+        meta.should == "metadata"
+        requirements.should == 1
+      end
+    end
+
+    describe "#check_dir_present" do
+      it "should return true if the directory is present and not empty" do
+        File.expects(:directory?).with("/tmp").returns(true)
+        File.expects(:join).with("/tmp", "*")
+        Dir.expects(:glob).returns([1])
+        result = PluginPackager.check_dir_present("/tmp")
+        result.should == true
+      end
+
+      it "should return false if the directory is not present" do
+        File.expects(:directory?).with("/tmp").returns(false)
+        result = PluginPackager.check_dir_present("/tmp")
+        result.should == false
+      end
+
+      it "should return false if the direcotry is present but empty" do
+        File.expects(:directory?).with("/tmp").returns(true)
+        File.expects(:join).with("/tmp", "*")
+        Dir.expects(:glob).returns([])
+        result = PluginPackager.check_dir_present("/tmp")
+        result.should == false
+      end
+    end
+
+    describe "#do_quietly?" do
+      it "should call the block parameter if verbose is true" do
+        result = PluginPackager.do_quietly?(true) {:success}
+        result.should == :success
+      end
+
+      it "should call the block parameter quietly if verbose is false" do
+        std_out = Tempfile.new("mc_pluginpackager_spec")
+        File.expects(:new).with("/dev/null", "w").returns(std_out)
+        PluginPackager.do_quietly?(false) {puts "success"}
+        std_out.rewind
+        std_out.read.should == "success\n"
+        std_out.close
+        std_out.unlink
+      end
+
+      it "should raise an exception and reset stdout if the block raises an execption" do
+        expect{
+          PluginPackager.do_quietly?(false) {raise Exception, "exception"}
+        }.to raise_error(Exception, "exception")
+      end
+    end
+
+    describe "#build_tool?" do
+      it "should return true if the given build tool is present on the system" do
+        File.expects(:join).returns("foo")
+        File.expects(:exists?).with("foo").returns(true)
+        result = PluginPackager.build_tool?("foo")
+        result.should == true
+      end
+
+      it "should return false if the given build tool is not present on the system" do
+        File.stubs(:join).returns("foo")
+        File.stubs(:exists?).with("foo").returns(false)
+        result = PluginPackager.build_tool?("foo")
+        result.should == false
+      end
+    end
+
+    describe "#safe_system" do
+      it "should not raise any exceptions if a command ran" do
+        PluginPackager.expects(:system).with("foo").returns(true)
+        lambda{PluginPackager.safe_system("foo")}.should_not raise_error
+      end
+
+      it "should raise a RuntimeError if command cannot be run" do
+        PluginPackager.expects(:system).with("foo").returns(false)
+        expect{
+          PluginPackager.safe_system("foo")
+        }.to raise_error(RuntimeError, "Failed: foo")
+      end
+    end
+  end
+end

data/spec/unit/plugins/mcollective/aggregate/average_spec.rb

@@ -0,0 +1,45 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+require File.dirname(__FILE__) + "/../../../../../plugins/mcollective/aggregate/average.rb"
+
+module MCollective
+  class Aggregate
+    describe Average do
+      describe "#startup_hook" do
+        it "should set the correct result hash" do
+          result = Average.new(:test, [], "%d", :test_action)
+          result.result.should == {:value => 0, :type => :numeric, :output => :test}
+          result.aggregate_format.should == "%d"
+        end
+
+        it "should set a defauly aggregate_format if one isn't defined" do
+          result = Average.new(:test, [], nil, :test_action)
+          result.aggregate_format.should == "Average of test: %f"
+        end
+      end
+
+      describe "#process_result" do
+        it "should add the reply value to the result hash" do
+          average = Average.new([:test], [], "%d", :test_action)
+          average.process_result(1, {:test => 1})
+          average.result[:value].should == 1
+        end
+      end
+
+      describe "#summarize" do
+        it "should calculate the average and return a result class" do
+          result_obj = mock
+          result_obj.stubs(:new).returns(:success)
+
+          average = Average.new([:test], [], "%d", :test_action)
+          average.process_result(10, {:test => 10})
+          average.process_result(20, {:test => 20})
+          average.stubs(:result_class).returns(result_obj)
+          average.summarize.should == :success
+          average.result[:value].should == 15
+        end
+      end
+    end
+  end
+end

data/spec/unit/plugins/mcollective/aggregate/sum_spec.rb

@@ -0,0 +1,31 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+require File.dirname(__FILE__) + "/../../../../../plugins/mcollective/aggregate/sum.rb"
+
+module MCollective
+  class Aggregate
+    describe Sum do
+      describe "#startup_hook" do
+        it "should set the correct result hash" do
+          result = Sum.new(:test, [], "%d", :test_action)
+          result.result.should == {:value => 0, :type => :numeric, :output => :test}
+          result.aggregate_format.should == "%d"
+        end
+
+        it "should set a defauly aggregate_format if one isn't defined" do
+          result = Sum.new(:test, [], nil, :test_action)
+          result.aggregate_format.should == "Sum of test: %f"
+        end
+      end
+
+      describe "#process_result" do
+        it "should add the reply value to the result hash" do
+          average = Sum.new([:test], [], "%d", :test_action)
+          average.process_result(1, {:test => 1})
+          average.result[:value].should == 1
+        end
+      end
+    end
+  end
+end

data/spec/unit/plugins/mcollective/aggregate/summary_spec.rb

@@ -0,0 +1,45 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+require File.dirname(__FILE__) + "/../../../../../plugins/mcollective/aggregate/summary.rb"
+
+module MCollective
+  class Aggregate
+    describe Summary do
+      describe "#startup_hook" do
+        it "should set the correct result hash" do
+          result = Summary.new(:test, [], "%d", :test_action)
+          result.result.should == {:value => {}, :type => :collection, :output => :test}
+          result.aggregate_format.should == "%d"
+        end
+
+        it "should set a defauly aggregate_format if one isn't defined" do
+          result = Summary.new(:test, [], nil, :test_action)
+          result.aggregate_format.should == :calculate
+        end
+      end
+
+      describe "#process_result" do
+        it "should add the value to the result hash" do
+          sum = Summary.new(:test, [], "%d", :test_action)
+          sum.process_result(:foo, {:test => :foo})
+          sum.result[:value].should == {:foo => 1}
+        end
+
+        it "should add the reply values to the result hash if value is an array" do
+          sum = Summary.new(:test, [], "%d", :test_action)
+          sum.process_result([:foo, :foo, :bar], {:test => [:foo, :foo, :bar]})
+          sum.result[:value].should == {:foo => 2, :bar => 1}
+        end
+      end
+
+      describe "#summarize" do
+        it "should calculate an attractive format" do
+          sum = Summary.new(:test, [], nil, :test_action)
+          sum.result[:value] = {"shrt" => 1, "long key" => 1}
+          sum.summarize.aggregate_format.should == "%8s = %s"
+        end
+      end
+    end
+  end
+end

data/spec/unit/plugins/mcollective/connector/activemq_spec.rb

@@ -438,7 +438,7 @@ module MCollective
           @c.make_target("test", :broadcast, "mcollective").should == {:name => "/topic/mcollective.test.agent", :headers => {}, :id => "/topic/mcollective.test.agent"}
           @c.make_target("test", :request, "mcollective").should == {:name => "/topic/mcollective.test.agent", :headers => {}, :id => "/topic/mcollective.test.agent"}
           @c.make_target("test", :direct_request, "mcollective").should == {:headers=>{}, :name=>"/queue/mcollective.nodes", :id => "/queue/mcollective.nodes"}
-          @c.make_target("test", :directed, "mcollective").should == {:name => "/queue/mcollective.nodes", :headers=>{"selector"=>"mc_identity = 'rspec'"}, :id => "directed_to_identity"}
+          @c.make_target("test", :directed, "mcollective").should == {:name => "/queue/mcollective.nodes", :headers=>{"selector"=>"mc_identity = 'rspec'"}, :id => "mcollective_directed_to_identity"}
         end
 
         it "should raise an error for unknown collectives" do

data/spec/unit/plugins/mcollective/connector/rabbitmq_spec.rb

@@ -0,0 +1,478 @@
+#!/usr/bin/env rspec
+
+require 'spec_helper'
+
+MCollective::PluginManager.clear
+
+require File.dirname(__FILE__) + '/../../../../../plugins/mcollective/connector/rabbitmq.rb'
+
+# create the stomp error class here as it does not always exist
+# all versions of the stomp gem and we do not want to tie tests
+# to the stomp gem
+module Stomp
+  module Error
+    class DuplicateSubscription < RuntimeError; end
+  end
+end
+
+module MCollective
+  module Connector
+    describe Rabbitmq do
+      before do
+        unless ::Stomp::Error.constants.map{|c| c.to_s}.include?("NoCurrentConnection")
+          class ::Stomp::Error::NoCurrentConnection < RuntimeError ; end
+        end
+
+        @config = mock
+        @config.stubs(:configured).returns(true)
+        @config.stubs(:identity).returns("rspec")
+        @config.stubs(:collectives).returns(["mcollective"])
+
+        logger = mock
+        logger.stubs(:log)
+        logger.stubs(:start)
+        Log.configure(logger)
+
+        Config.stubs(:instance).returns(@config)
+
+        @msg = mock
+        @msg.stubs(:base64_encode!)
+        @msg.stubs(:payload).returns("msg")
+        @msg.stubs(:agent).returns("agent")
+        @msg.stubs(:type).returns(:reply)
+        @msg.stubs(:collective).returns("mcollective")
+
+        @subscription = mock
+        @subscription.stubs("<<").returns(true)
+        @subscription.stubs("include?").returns(false)
+        @subscription.stubs("delete").returns(false)
+
+        @connection = mock
+        @connection.stubs(:subscribe).returns(true)
+        @connection.stubs(:unsubscribe).returns(true)
+
+        @c = Rabbitmq.new
+        @c.instance_variable_set("@subscriptions", @subscription)
+        @c.instance_variable_set("@connection", @connection)
+      end
+
+      describe "#initialize" do
+        it "should set the @config variable" do
+          c = Rabbitmq.new
+          c.instance_variable_get("@config").should == @config
+        end
+
+        it "should set @subscriptions to an empty list" do
+          c = Rabbitmq.new
+          c.instance_variable_get("@subscriptions").should == []
+        end
+      end
+
+      describe "#connect" do
+        it "should not try to reconnect if already connected" do
+          Log.expects(:debug).with("Already connection, not re-initializing connection").once
+          @c.connect
+        end
+
+        it "should support new style config" do
+          pluginconf = {"rabbitmq.pool.size" => "2",
+                        "rabbitmq.pool.1.host" => "host1",
+                        "rabbitmq.pool.1.port" => "6163",
+                        "rabbitmq.pool.1.user" => "user1",
+                        "rabbitmq.pool.1.password" => "password1",
+                        "rabbitmq.pool.1.ssl" => "false",
+                        "rabbitmq.pool.2.host" => "host2",
+                        "rabbitmq.pool.2.port" => "6164",
+                        "rabbitmq.pool.2.user" => "user2",
+                        "rabbitmq.pool.2.password" => "password2",
+                        "rabbitmq.pool.2.ssl" => "true",
+                        "rabbitmq.pool.2.ssl.fallback" => "true",
+                        "rabbitmq.initial_reconnect_delay" => "0.02",
+                        "rabbitmq.max_reconnect_delay" => "40",
+                        "rabbitmq.use_exponential_back_off" => "false",
+                        "rabbitmq.back_off_multiplier" => "3",
+                        "rabbitmq.max_reconnect_attempts" => "5",
+                        "rabbitmq.randomize" => "true",
+                        "rabbitmq.backup" => "true",
+                        "rabbitmq.timeout" => "1",
+                        "rabbitmq.vhost" => "mcollective",
+                        "rabbitmq.connect_timeout" => "5"}
+
+
+          ENV.delete("STOMP_USER")
+          ENV.delete("STOMP_PASSWORD")
+
+          @config.expects(:pluginconf).returns(pluginconf).at_least_once
+
+          Rabbitmq::EventLogger.expects(:new).returns("logger")
+
+          connector = mock
+          connector.expects(:new).with(:backup => true,
+                                       :back_off_multiplier => 3,
+                                       :max_reconnect_delay => 40.0,
+                                       :timeout => 1,
+                                       :connect_timeout => 5,
+                                       :use_exponential_back_off => false,
+                                       :max_reconnect_attempts => 5,
+                                       :initial_reconnect_delay => 0.02,
+                                       :randomize => true,
+                                       :reliable => true,
+                                       :logger => "logger",
+                                       :connect_headers => {'accept-version' => '1.0', 'host' => 'mcollective'},
+                                       :hosts => [{:passcode => 'password1',
+                                                   :host => 'host1',
+                                                   :port => 6163,
+                                                   :ssl => false,
+                                                   :login => 'user1'},
+                                                  {:passcode => 'password2',
+                                                   :host => 'host2',
+                                                   :port => 6164,
+                                                   :ssl => true,
+                                                   :login => 'user2'}
+          ])
+
+          @c.expects(:ssl_parameters).with(2, true).returns(true)
+
+          @c.instance_variable_set("@connection", nil)
+          @c.connect(connector)
+        end
+      end
+
+      describe "#ssl_paramaters" do
+        it "should ensure all settings are provided" do
+          pluginconf = {"rabbitmq.pool.1.host" => "host1",
+                        "rabbitmq.pool.1.port" => "6164",
+                        "rabbitmq.pool.1.user" => "user1",
+                        "rabbitmq.pool.1.password" => "password1",
+                        "rabbitmq.pool.1.ssl" => "true",
+                        "rabbitmq.pool.1.ssl.cert" => "rspec"}
+
+          @config.expects(:pluginconf).returns(pluginconf).at_least_once
+
+          expect { @c.ssl_parameters(1, false) }.to raise_error("cert, key and ca has to be supplied for verified SSL mode")
+        end
+
+        it "should verify the ssl files exist" do
+          pluginconf = {"rabbitmq.pool.1.host" => "host1",
+                        "rabbitmq.pool.1.port" => "6164",
+                        "rabbitmq.pool.1.user" => "user1",
+                        "rabbitmq.pool.1.password" => "password1",
+                        "rabbitmq.pool.1.ssl" => "true",
+                        "rabbitmq.pool.1.ssl.cert" => "rspec.cert",
+                        "rabbitmq.pool.1.ssl.key" => "rspec.key",
+                        "rabbitmq.pool.1.ssl.ca" => "rspec1.ca,rspec2.ca"}
+
+          @config.expects(:pluginconf).returns(pluginconf).at_least_once
+
+          File.expects(:exist?).with("rspec.cert").twice.returns(true)
+          File.expects(:exist?).with("rspec.key").twice.returns(true)
+          File.expects(:exist?).with("rspec1.ca").twice.returns(true)
+          File.expects(:exist?).with("rspec2.ca").twice.returns(false)
+
+          expect { @c.ssl_parameters(1, false) }.to raise_error("Cannot find CA file rspec2.ca")
+
+          @c.ssl_parameters(1, true).should == true
+        end
+
+        it "should support fallback mode when there are errors" do
+          pluginconf = {"rabbitmq.pool.1.host" => "host1",
+                        "rabbitmq.pool.1.port" => "6164",
+                        "rabbitmq.pool.1.user" => "user1",
+                        "rabbitmq.pool.1.password" => "password1",
+                        "rabbitmq.pool.1.ssl" => "true"}
+
+          @config.expects(:pluginconf).returns(pluginconf).at_least_once
+
+          @c.ssl_parameters(1, true).should == true
+        end
+
+        it "should fail if fallback isnt enabled" do
+          pluginconf = {"rabbitmq.pool.1.host" => "host1",
+                        "rabbitmq.pool.1.port" => "6164",
+                        "rabbitmq.pool.1.user" => "user1",
+                        "rabbitmq.pool.1.password" => "password1",
+                        "rabbitmq.pool.1.ssl" => "true"}
+
+          @config.expects(:pluginconf).returns(pluginconf).at_least_once
+
+          expect { @c.ssl_parameters(1, false) }.to raise_error
+        end
+      end
+
+      describe "#receive" do
+        it "should receive from the middleware" do
+          payload = mock
+          payload.stubs(:body).returns("msg")
+          payload.stubs(:headers).returns("headers")
+
+          @connection.expects(:receive).returns(payload)
+
+          Message.expects(:new).with("msg", payload, :base64 => true, :headers => "headers").returns("message")
+          @c.instance_variable_set("@base64", true)
+
+          received = @c.receive
+          received.should == "message"
+        end
+
+        it "should sleep and retry if recieving while disconnected" do
+          payload = mock
+          payload.stubs(:body).returns("msg")
+          payload.stubs(:headers).returns("headers")
+
+          Message.stubs(:new).returns("rspec")
+          @connection.expects(:receive).raises(::Stomp::Error::NoCurrentConnection).returns(payload).twice
+          @c.expects(:sleep).with(1)
+
+          @c.receive.should == "rspec"
+        end
+      end
+
+      describe "#publish" do
+        before do
+          @connection.stubs(:publish).with("test", "msg", {}).returns(true)
+        end
+
+        it "should base64 encode a message if configured to do so" do
+          @c.instance_variable_set("@base64", true)
+          @c.expects(:target_for).returns({:name => "test", :headers => {}})
+          @connection.expects(:publish).with("test", "msg", {})
+          @msg.expects(:base64_encode!)
+
+          @c.publish(@msg)
+        end
+
+        it "should not base64 encode if not configured to do so" do
+          @c.instance_variable_set("@base64", false)
+          @c.expects(:target_for).returns({:name => "test", :headers => {}})
+          @connection.expects(:publish).with("test", "msg", {})
+          @msg.expects(:base64_encode!).never
+
+          @c.publish(@msg)
+        end
+
+        it "should publish the correct message to the correct target with msgheaders" do
+          @connection.expects(:publish).with("test", "msg", {}).once
+          @c.expects(:target_for).returns({:name => "test", :headers => {}})
+
+          @c.publish(@msg)
+        end
+
+        it "should publish direct messages based on discovered_hosts" do
+          msg = mock
+          msg.stubs(:base64_encode!)
+          msg.stubs(:payload).returns("msg")
+          msg.stubs(:agent).returns("agent")
+          msg.stubs(:collective).returns("mcollective")
+          msg.stubs(:type).returns(:direct_request)
+          msg.expects(:discovered_hosts).returns(["one", "two"])
+
+          @connection.expects(:publish).with('/exchange/mcollective_directed/one', 'msg', {'reply-to' => '/temp-queue/mcollective_reply_agent'})
+          @connection.expects(:publish).with('/exchange/mcollective_directed/two', 'msg', {'reply-to' => '/temp-queue/mcollective_reply_agent'})
+
+          @c.publish(msg)
+        end
+      end
+
+      describe "#subscribe" do
+        it "should handle duplicate subscription errors" do
+          @connection.expects(:subscribe).raises(::Stomp::Error::DuplicateSubscription)
+          Log.expects(:error).with(regexp_matches(/already had a matching subscription, ignoring/))
+          @c.subscribe("test", :broadcast, "mcollective")
+        end
+
+        it "should use the make_target correctly" do
+          @c.expects("make_target").with("test", :broadcast, "mcollective").returns({:name => "test", :headers => {}})
+          @c.subscribe("test", :broadcast, "mcollective")
+        end
+
+        it "should check for existing subscriptions" do
+          @c.expects("make_target").with("test", :broadcast, "mcollective").returns({:name => "test", :headers => {}, :id => "rspec"})
+          @subscription.expects("include?").with("rspec").returns(false)
+          @connection.expects(:subscribe).never
+
+          @c.subscribe("test", :broadcast, "mcollective")
+        end
+
+        it "should subscribe to the middleware" do
+          @c.expects("make_target").with("test", :broadcast, "mcollective").returns({:name => "test", :headers => {}, :id => "rspec"})
+          @connection.expects(:subscribe).with("test", {}, "rspec")
+          @c.subscribe("test", :broadcast, "mcollective")
+        end
+
+        it "should add to the list of subscriptions" do
+          @c.expects("make_target").with("test", :broadcast, "mcollective").returns({:name => "test", :headers => {}, :id => "rspec"})
+          @subscription.expects("<<").with("rspec")
+          @c.subscribe("test", :broadcast, "mcollective")
+        end
+      end
+
+      describe "#unsubscribe" do
+        it "should use make_target correctly" do
+          @c.expects("make_target").with("test", :broadcast, "mcollective").returns({:name => "test", :headers => {}})
+          @c.unsubscribe("test", :broadcast, "mcollective")
+        end
+
+        it "should unsubscribe from the target" do
+          @c.expects("make_target").with("test", :broadcast, "mcollective").returns({:name => "test", :headers => {}, :id => "rspec"})
+          @connection.expects(:unsubscribe).with("test", {}, "rspec").once
+
+          @c.unsubscribe("test", :broadcast, "mcollective")
+        end
+
+        it "should delete the source from subscriptions" do
+          @c.expects("make_target").with("test", :broadcast, "mcollective").returns({:name => "test", :headers => {}, :id => "rspec"})
+          @subscription.expects(:delete).with("rspec").once
+
+          @c.unsubscribe("test", :broadcast, "mcollective")
+        end
+      end
+
+      describe "#target_for" do
+        it "should create reply targets based on reply-to headers in requests" do
+          message = mock
+          message.expects(:type).returns(:reply)
+
+          request = mock
+          request.expects(:headers).returns({"reply-to" => "foo"})
+
+          message.expects(:request).returns(request)
+
+          @c.target_for(message).should == {:name => "foo", :headers => {}, :id => ""}
+        end
+
+        it "should create new request targets" do
+          message = mock
+          message.expects(:type).returns(:request).times(3)
+          message.expects(:agent).returns("rspecagent")
+          message.expects(:collective).returns("mcollective")
+
+          @c.expects(:make_target).with("rspecagent", :request, "mcollective", nil)
+          @c.target_for(message)
+        end
+
+        it "should support direct requests" do
+          message = mock
+          message.expects(:type).returns(:direct_request).times(3)
+          message.expects(:agent).returns("rspecagent")
+          message.expects(:collective).returns("mcollective")
+
+          @c.expects(:make_target).with("rspecagent", :direct_request, "mcollective", nil)
+          @c.target_for(message)
+        end
+
+        it "should fail for unknown message types" do
+          message = mock
+          message.stubs(:type).returns(:fail)
+
+          expect {
+            @c.target_for(message)
+          }.to raise_error("Don't now how to create a target for message type fail")
+        end
+      end
+
+      describe "#disconnect" do
+        it "should disconnect from the stomp connection" do
+          @connection.expects(:disconnect)
+          @c.disconnect
+        end
+      end
+
+      describe "#make_target" do
+        it "should create correct targets" do
+          @c.make_target("test", :reply, "mcollective").should == {:name => "/temp-queue/mcollective_reply_test", :headers => {}, :id => "mcollective_test_replies"}
+          @c.make_target("test", :broadcast, "mcollective").should == {:name => "/exchange/mcollective_broadcast/test", :headers => {"reply-to"=>"/temp-queue/mcollective_reply_test"}, :id => "mcollective_broadcast_test"}
+          @c.make_target("test", :request, "mcollective").should == {:name => "/exchange/mcollective_broadcast/test", :headers => {"reply-to"=>"/temp-queue/mcollective_reply_test"}, :id => "mcollective_broadcast_test"}
+          @c.make_target("test", :direct_request, "mcollective", "rspec").should == {:headers=>{"reply-to"=>"/temp-queue/mcollective_reply_test"}, :name=>"/exchange/mcollective_directed/rspec", :id => nil}
+          @c.make_target("test", :directed, "mcollective").should == {:name => "/exchange/mcollective_directed/rspec", :headers=>{}, :id => "rspec_directed_to_identity"}
+        end
+
+        it "should raise an error for unknown collectives" do
+          expect {
+            @c.make_target("test", :broadcast, "foo")
+          }.to raise_error("Unknown collective 'foo' known collectives are 'mcollective'")
+        end
+
+        it "should raise an error for unknown types" do
+          expect {
+            @c.make_target("test", :test, "mcollective")
+          }.to raise_error("Unknown target type test")
+        end
+      end
+
+
+      describe "#get_env_or_option" do
+        it "should return the environment variable if set" do
+          ENV["test"] = "rspec_env_test"
+
+          @c.get_env_or_option("test", nil, nil).should == "rspec_env_test"
+
+          ENV.delete("test")
+        end
+
+        it "should return the config option if set" do
+          @config.expects(:pluginconf).returns({"test" => "rspec_test"}).twice
+          @c.get_env_or_option("test", "test", "test").should == "rspec_test"
+        end
+
+        it "should return default if nothing else matched" do
+          @config.expects(:pluginconf).returns({}).once
+          @c.get_env_or_option("test", "test", "test").should == "test"
+        end
+
+        it "should raise an error if no default is supplied" do
+          @config.expects(:pluginconf).returns({}).once
+
+          expect {
+            @c.get_env_or_option("test", "test")
+          }.to raise_error("No test environment or plugin.test configuration option given")
+        end
+      end
+
+      describe "#get_option" do
+        it "should return the config option if set" do
+          @config.expects(:pluginconf).returns({"test" => "rspec_test"}).twice
+          @c.get_option("test").should == "rspec_test"
+        end
+
+        it "should return default option was not found" do
+          @config.expects(:pluginconf).returns({}).once
+          @c.get_option("test", "test").should == "test"
+        end
+
+        it "should raise an error if no default is supplied" do
+          @config.expects(:pluginconf).returns({}).once
+
+          expect {
+            @c.get_option("test")
+          }.to raise_error("No plugin.test configuration option given")
+        end
+      end
+
+      describe "#get_bool_option" do
+        it "should return the default if option isnt set" do
+          @config.expects(:pluginconf).returns({}).once
+          @c.get_bool_option("test", "default").should == "default"
+        end
+
+        ["1", "yes", "true"].each do |boolean|
+          it "should map options to true correctly" do
+            @config.expects(:pluginconf).returns({"test" => boolean}).twice
+            @c.get_bool_option("test", "default").should == true
+          end
+        end
+
+        ["0", "no", "false"].each do |boolean|
+          it "should map options to false correctly" do
+            @config.expects(:pluginconf).returns({"test" => boolean}).twice
+            @c.get_bool_option("test", "default").should == false
+          end
+        end
+
+        it "should return default for non boolean options" do
+          @config.expects(:pluginconf).returns({"test" => "foo"}).twice
+          @c.get_bool_option("test", "default").should == "default"
+        end
+      end
+    end
+  end
+end