lhs 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23beb0804ec8b041eaa4e920e395a5d9b2bf394f
-  data.tar.gz: 3329ba17fc8d206210d143a8b8ad4aae09561316
+  metadata.gz: ef6ba468414f035212c331033b23e589a61052c6
+  data.tar.gz: 6b578fc834f3927e835a050fa62013fcd6d40886
 SHA512:
-  metadata.gz: 451e95f0aa50d9f41eedd21f7339f36904d146f36c3ca880effe675f5b9b7c6a6198592e4a4d6e2c284a10fadbe4b7aa8a96b3f1e60748fae1988bc4e805f788
-  data.tar.gz: df8f2a78480a2ead8098c786e04f620e6541420c78803adaf2ee2524c31274a2ddd756d6dd4b7309d08c76cacea9bda907c797a1b6a346e3c2ecdf59a04ae45b
+  metadata.gz: 1cf686058b99a28eec867a0f00be09cf92902376bc2932c661260776252bad1a0d60fb9e8e6f7ddd12888e6b7d89b20b485aa3b59d52157e50d96e30e97edeb0
+  data.tar.gz: 87d5662298e7bb7de53345fcb08b2271133f6dc0e7eec93e19ae66ae8003c8af02710852862c1eb4f8b050499f3efb8343bbb1e0f5fe4fc747e7e2361fe04f49

data/.rubocop.localch.yml

@@ -0,0 +1,190 @@
+# This is master rubocop configuration.
+# DO NOT EDIT THIS FILE - it WILL be overwriten on every config update
+AllCops:
+  TargetRubyVersion: 2.1
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+  Include:
+    - '**/Rakefile'
+    - '**/config.ru'
+    - '**/Capfile'
+  Exclude:
+    - 'db/**/*'
+    - 'script/**/*'
+    - 'vendor/bundle/**/*'
+    - 'bin/**/*'
+    - 'config/unicorn.rb'
+    - 'config/compass.rb'
+    - 'Rakefile'
+
+Rails:
+  Enabled: true
+
+require:
+  - rubocop-rspec
+
+Lint/HandleExceptions:
+  Exclude:
+    - spec/**/*
+
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false
+
+Metrics/ParameterLists:
+  Enabled: false
+
+Metrics/BlockNesting:
+  Enabled: false
+
+Performance/StringReplacement:
+  Enabled: false
+
+Performance/TimesMap:
+  Enabled: false
+
+Performance/RedundantBlockCall:
+  Enabled: false
+
+Performance/RedundantMatch:
+  Enabled: false
+
+Performance/RedundantMerge:
+  Enabled: false
+
+Performance/Casecmp:
+  Enabled: false
+
+Style/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+Style/StringLiterals:
+  Enabled: false
+
+Style/RegexpLiteral:
+  Exclude:
+    - spec/**/*
+
+Style/DotPosition:
+  EnforcedStyle: leading
+
+Style/AlignParameters:
+  Enabled: false
+
+Style/NumericLiterals:
+  Enabled: false
+
+Style/WordArray:
+  Enabled: false
+
+Style/EmptyLinesAroundClassBody:
+  Enabled: false
+
+Style/Next:
+  Enabled: false
+
+Style/PercentLiteralDelimiters:
+  Enabled: false
+
+Style/GlobalVars:
+  Enabled: false
+
+Style/CommentAnnotation:
+  Enabled: false
+
+Style/SymbolProc:
+  Enabled: false
+
+Style/DoubleNegation:
+  Enabled: false
+
+Style/FormatString:
+  Enabled: false
+
+Style/AsciiComments:
+  Enabled: false
+
+Style/BarePercentLiterals:
+  Enabled: false
+
+Style/SingleLineBlockParams:
+  Enabled: false
+
+Style/MultilineBlockChain:
+  Enabled: false
+
+Style/UnneededCapitalW:
+  Enabled: false
+
+Style/UnneededPercentQ:
+  Enabled: false
+
+Style/BlockDelimiters:
+  Exclude:
+    - spec/**/*
+
+Style/BracesAroundHashParameters:
+  EnforcedStyle: context_dependent
+
+Style/IfUnlessModifier:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/GuardClause:
+  Enabled: false
+
+Style/AccessorMethodName:
+  Exclude:
+    - spec/support/pages/**/*
+
+Style/NegatedIf:
+  Enabled: false
+
+Style/MutableConstant:
+  Enabled: false
+
+Style/ConditionalAssignment:
+  Enabled: false
+
+Style/IndentArray:
+  EnforcedStyle: consistent
+
+Style/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+RSpec/DescribeClass:
+  Exclude:
+    - spec/views/**/*
+    - spec/routing/**/*
+    - spec/requests/**/*
+    - spec/features/**/*
+
+RSpec/FilePath:
+  Enabled: false
+
+Rails/Output:
+  Exclude:
+    - 'config/application.rb'
+    - 'config/initializers/asset_manifest_warning.rb'

data/.rubocop.yml

@@ -0,0 +1,7 @@
+# This is project specific rubocop configuration file.
+# You can tweak project settings here
+inherit_from:
+  - ./.rubocop.localch.yml
+
+Lint/IneffectiveAccessModifier:
+  Enabled: false

data/cider-ci.yml

@@ -1,3 +1,4 @@
 jobs:
   _cider-ci_include:
-    - cider-ci/jobs/tests.yml
+    - cider-ci/jobs/rubocop.yml
+    - cider-ci/jobs/rspec.yml

data/cider-ci/jobs/rspec.yml

@@ -0,0 +1,48 @@
+rspec:
+  name: 'RSPec tests'
+
+  run-on:
+    - type: branch
+      include-match: ^.*$
+
+  context:
+    task-defaults:
+      ports:
+        CAPYBARA_PORT:
+          inet_address: "localhost"
+          min: 8000
+          max: 8999
+        PHANTOMJS_PORT:
+          inet_address: "localhost"
+          min: 44600
+          max: 44999
+
+      scripts:
+        rspec:
+          start-when:
+            - script: bundle
+            - script: ruby-version
+            - script: tmp-cache
+
+
+        _cider-ci_include:
+          - cider-ci/scripts/bundle.yml
+          - cider-ci/scripts/tmp-cache.yml
+          - cider-ci/scripts/ruby-version.yml
+          - cider-ci/scripts/rspec.yml
+
+
+      trial-attachments:
+        logs:
+          include-match: log\/.*\.log$
+          content-type: text/plain
+        image-screenshots:
+          include-match: tmp\/capybara\/.*\.png$
+          content-type: image/png
+        html-screenshots:
+          include-match: tmp\/capybara\/.*\.html$
+          content-type: text/html
+
+    _cider-ci_generate-tasks:
+      include-match: spec/.*_spec.rb
+      exclude-match: spec/support/shared/*

data/cider-ci/jobs/rubocop.yml

@@ -0,0 +1,55 @@
+rubocop:
+  name: 'Rubocop analysis'
+
+  run-on:
+    - type: branch
+      include-match: ^.*$
+
+  context:
+    task-defaults:
+      environment-variables:
+        GIT_REPOSITORY: local-ch/location-app
+        RESULT_PATH: 'tmp/checkstyle.json'
+
+      scripts:
+        rubocop:
+          start-when:
+            - script: bundle
+            - script: ruby-version
+            - script: tmp-cache
+
+        
+        github_comment:
+          start-when:
+            - script: rubocop
+              states: [failed]
+        
+
+        _cider-ci_include:
+          - cider-ci/scripts/bundle.yml
+          - cider-ci/scripts/tmp-cache.yml
+          - cider-ci/scripts/ruby-version.yml
+          - cider-ci/scripts/rubocop.yml
+          
+          - cider-ci/scripts/github_comment.yml
+          
+
+      max-auto-trials: 1
+
+      trial-attachments:
+        logs:
+          include-match: tmp\/checkstyle.json$
+          content-type: application/json
+
+      tree-attachments:
+        logs:
+          include-match: tmp\/checkstyle.json$
+          content-type: application/json
+
+    tasks:
+      rubocop:
+        scripts:
+          rubocop: {}
+          
+          github_comment: {}
+          

data/cider-ci/scripts/bundle.yml

@@ -0,0 +1,2 @@
+bundle:
+  body: sed 's/^source.*/source "http\:\/\/52.29.7.59:9292"/g' Gemfile > Gemfile.tmp ; mv Gemfile.tmp Gemfile && bundle install

data/cider-ci/scripts/github_comment.yml

@@ -0,0 +1,6 @@
+github_comment:
+  ignore-state: true
+  body: |
+    #!/usr/bin/env bash
+
+    bundle exec rake checkstyle

data/cider-ci/scripts/rspec.yml

@@ -0,0 +1,4 @@
+rspec:
+  body: |
+    #!/usr/bin/env bash
+    bundle exec rspec $CIDER_CI_TASK_FILE

data/cider-ci/scripts/rubocop.yml

@@ -0,0 +1,5 @@
+rubocop:
+  body: |
+    #!/usr/bin/env bash
+
+    bundle exec rubocop  --config .rubocop.yml --format json --out $RESULT_PATH --format progress

data/cider-ci/scripts/ruby-version.yml

@@ -0,0 +1,2 @@
+ruby-version:
+  body: ruby --version

data/cider-ci/scripts/tmp-cache.yml

@@ -0,0 +1,2 @@
+tmp-cache:
+  body: mkdir -p tmp/cache

data/lhs.gemspec

@@ -28,4 +28,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'webmock'
   s.add_development_dependency 'geminabox'
   s.add_development_dependency 'pry'
+  s.add_development_dependency 'ciderizer'
 end

data/lib/lhs/collection.rb

@@ -28,9 +28,7 @@ class LHS::Collection < LHS::Proxy
     Collection.new(raw, _data, _data._record_class)
   end
 
-  def _raw
-    _data._raw
-  end
+  delegate :_raw, to: :_data
 
   protected
 
@@ -49,8 +47,6 @@ class LHS::Collection < LHS::Proxy
     _collection.respond_to?(name, include_all)
   end
 
-  private
-
   # The internal collection class that includes enumerable
   # and insures to return LHS::Items in case of iterating items
   class Collection
@@ -65,7 +61,7 @@ class LHS::Collection < LHS::Proxy
       @record = record
     end
 
-    def each(&block)
+    def each(&_block)
       raw.each do |item|
         if item.is_a? Hash
           yield LHS::Data.new(item, @parent, @record)

data/lib/lhs/concerns/data/json.rb

@@ -5,7 +5,7 @@ class LHS::Data
   module Json
     extend ActiveSupport::Concern
 
-    def as_json(options = {})
+    def as_json(_options = {})
       _data._raw.as_json
     end
   end

data/lib/lhs/concerns/item/save.rb

@@ -8,21 +8,22 @@ class LHS::Item < LHS::Proxy
 
     def save
       save!
-      rescue LHC::Error => e
-        self.errors = LHS::Errors.new(e.response)
-        false
+    rescue LHC::Error => e
+      self.errors = LHS::Errors.new(e.response)
+      false
     end
 
     def save!
       record = _data._root._record_class
       data = _data._raw.dup
-      url = if href.present?
-       href
-      else
-        record.find_endpoint(data).compile(data)
-      end
-      data = record.request(method: :post, url: url, body: data.to_json, headers: {'Content-Type' => 'application/json'})
-      self._data.merge_raw!(data)
+      url =
+        if href.present?
+          href
+        else
+          record.find_endpoint(data).compile(data)
+        end
+      data = record.request(method: :post, url: url, body: data.to_json, headers: { 'Content-Type' => 'application/json' })
+      _data.merge_raw!(data)
       true
     end
   end

data/lib/lhs/concerns/item/update.rb

@@ -20,7 +20,7 @@ class LHS::Item < LHS::Proxy
         method: :post,
         url: href,
         body: _data.to_json,
-        headers: {'Content-Type' => 'application/json'}
+        headers: { 'Content-Type' => 'application/json' }
       )
       _data.merge_raw!(response_data)
       true

data/lib/lhs/concerns/item/validation.rb

@@ -16,7 +16,7 @@ class LHS::Item < LHS::Proxy
           method: :post,
           params: params,
           body: _data.to_json,
-          headers: {'Content-Type' => 'application/json'}
+          headers: { 'Content-Type' => 'application/json' }
         )
         true
       rescue LHC::Error => e
@@ -24,7 +24,7 @@ class LHS::Item < LHS::Proxy
         false
       end
     end
-    alias_method :validate, :valid?
+    alias validate valid?
 
     private