lhs 3.0.0 → 3.0.1

data/spec/item/getter_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Item do
-
   before(:each) do
     class Record < LHS::Record
       endpoint ':datastore/v2/:campaign_id/feedbacks'
@@ -10,11 +9,10 @@ describe LHS::Item do
   end
 
   let(:data) do
-    LHS::Data.new({addresses: [{business: {identities: [{name: 'Löwenzorn'}]}}]}, nil, Record)
+    LHS::Data.new({ addresses: [{ business: { identities: [{ name: 'Löwenzorn' }] } }] }, nil, Record)
   end
 
   context 'item getter' do
-
     it 'returns a collection if you access an array' do
       expect(data.addresses).to be_kind_of(LHS::Data)
       expect(data.addresses._proxy).to be_kind_of(LHS::Collection)

data/spec/item/internal_data_structure_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Item do
-
   before(:each) do
     class Feedback < LHS::Record
       endpoint ':datastore/v2/feedbacks'
@@ -10,7 +9,7 @@ describe LHS::Item do
   end
 
   let(:hash) do
-    {'addresses' => [{'businesses' => {'identities' => [{'name' => 'Löwenzorn'}]}}]}
+    { 'addresses' => [{ 'businesses' => { 'identities' => [{ 'name' => 'Löwenzorn' }] } }] }
   end
 
   let(:data) do
@@ -32,7 +31,7 @@ describe LHS::Item do
   it 'deep symbolizes internal data when building new objects' do
     feedback = Feedback.build('name' => 'BB8')
     expect(feedback._data._raw.keys).to include(:name)
-  end 
+  end
 
   it 'can handle ActionController::Parameters' do
     params = ActionController::Parameters.new('name' => 'Han')

data/spec/item/respond_to_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe LHS::Item do
   let(:item){
-    described_class.new({id: 1234})
+    described_class.new(id: 1234)
   }
 
   context '#respond_to?' do

data/spec/item/save_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Item do
-
   before(:each) do
     class Record < LHS::Record
       endpoint ':datastore/v2/:campaign_id/feedbacks'
@@ -22,7 +21,6 @@ describe LHS::Item do
   end
 
   context 'save' do
-
     it 'persists changes on the backend' do
       stub_request(:post, item.href).with(body: item._raw.merge(name: 'Steve').to_json)
       item.name = 'Steve'
@@ -31,27 +29,26 @@ describe LHS::Item do
 
     it 'returns false if persting goes wrong' do
       stub_request(:post, item.href)
-      .with(body: item._raw.to_json)
-      .to_return(status: 500)
+        .with(body: item._raw.to_json)
+        .to_return(status: 500)
       expect(item.save).to eq false
     end
 
     it 'merges reponse data with object' do
       stub_request(:post, item.href)
-      .with(body: item._raw.to_json)
-      .to_return(status: 200, body: item._raw.merge(name: 'Steve').to_json)
+        .with(body: item._raw.to_json)
+        .to_return(status: 200, body: item._raw.merge(name: 'Steve').to_json)
       item.save
       expect(item.name).to eq 'Steve'
     end
   end
 
   context 'save!' do
-
     it 'raises if something goes wrong' do
       stub_request(:post, item.href)
-      .with(body: item._raw.to_json)
-      .to_return(status: 500)
-      expect(->{ item.save! }).to raise_error LHC::ServerError
+        .with(body: item._raw.to_json)
+        .to_return(status: 500)
+      expect(-> { item.save! }).to raise_error LHC::ServerError
     end
   end
 end

data/spec/item/setter_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Item do
-
   before(:each) do
     class Record < LHS::Record
       endpoint ':datastore/v2/:campaign_id/feedbacks'
@@ -22,16 +21,15 @@ describe LHS::Item do
   end
 
   context 'item setter' do
-
     it 'sets the value for an existing attribute' do
-      expect(item.name = 'Steve').to eq 'Steve'
+      expect((item.name = 'Steve')).to eq 'Steve'
       expect(item.name).to eq 'Steve'
       expect(item._raw[:name]).to eq 'Steve'
     end
 
     it 'sets things to nil' do
       item.name = 'Steve'
-      expect(item.name = nil).to eq nil
+      expect((item.name = nil)).to eq nil
       expect(item.name).to eq nil
     end
   end

data/spec/item/update_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Item do
-
   before(:each) do
     class Record < LHS::Record
       endpoint ':datastore/v2/:campaign_id/feedbacks'
@@ -22,10 +21,9 @@ describe LHS::Item do
   end
 
   context 'update' do
-
     it 'persists changes on the backend' do
       stub_request(:post, item.href)
-      .with(body: item._raw.merge(name: 'Steve').to_json)
+        .with(body: item._raw.merge(name: 'Steve').to_json)
       result = item.update(name: 'Steve')
       expect(result).to eq true
     end
@@ -53,12 +51,11 @@ describe LHS::Item do
   end
 
   context 'update!' do
-
     it 'raises if something goes wrong' do
       stub_request(:post, item.href)
-      .with(body: item._raw.merge(name: 'Steve').to_json)
-      .to_return(status: 500)
-      expect(->{ item.update!(name: 'Steve') }).to raise_error LHC::ServerError
+        .with(body: item._raw.merge(name: 'Steve').to_json)
+        .to_return(status: 500)
+      expect(-> { item.update!(name: 'Steve') }).to raise_error LHC::ServerError
     end
   end
 end

data/spec/item/validation_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Item do
-
   let(:datastore) { 'http://local.ch' }
 
   before(:each) do
@@ -13,8 +12,8 @@ describe LHS::Item do
   end
 
   let(:mock_validation) do
-      successful_validation
-    end
+    successful_validation
+  end
 
   let(:successful_validation) do
     stub_request(:post, "#{datastore}/v2/users?persist=false").to_return(body: '{}')
@@ -23,10 +22,10 @@ describe LHS::Item do
   let(:failing_validation) do
     stub_request(:post, "#{datastore}/v2/users?persist=false")
       .to_return(status: 400,
-        body: {
-          field_errors: [{code: "UNSUPPORTED_PROPERTY_VALUE", "path" => [ "email" ]}] 
-        }.to_json
-      )
+                 body: {
+                   field_errors: [{ code: "UNSUPPORTED_PROPERTY_VALUE", "path" => ["email"] }]
+                 }.to_json
+                )
   end
 
   context 'valid data' do
@@ -48,7 +47,6 @@ describe LHS::Item do
   end
 
   context 'invalid data' do
-
     let(:user) do
       User.build(email: 'im not an email address')
     end
@@ -79,7 +77,7 @@ describe LHS::Item do
     end
 
     it 'fails when trying to use an endpoint for validations that does not support it' do
-      expect(->{
+      expect(lambda {
         Favorite.build.valid?
       }).to raise_error('Endpoint does not support validations!')
     end

data/spec/proxy/load_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Proxy do
-
   before(:each) do
     class Record < LHS::Record
       endpoint ':datastore/v2/feedbacks'
@@ -30,7 +29,6 @@ describe LHS::Proxy do
   end
 
   context 'load' do
-
     it 'is loading data remotely when not present yet' do
       expect(link.load!.id).to be
       expect(link.id).to be

data/spec/record/all_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Collection do
-
   let(:datastore) { 'http://local.ch/v2' }
 
   before(:each) do
@@ -13,41 +12,40 @@ describe LHS::Collection do
   end
 
   context 'all' do
-
     it 'fetches all records from the backend' do
       stub_request(:get, "#{datastore}/feedbacks?limit=100")
-      .to_return(status: 200, body: {items: (1..100).to_a, total: 300, limit: 100, offset: 0}.to_json)
+        .to_return(status: 200, body: { items: (1..100).to_a, total: 300, limit: 100, offset: 0 }.to_json)
       stub_request(:get, "#{datastore}/feedbacks?limit=100&offset=101")
-      .to_return(status: 200, body: {items: (101..200).to_a, total: 300, limit: 100, offset: 101}.to_json)
+        .to_return(status: 200, body: { items: (101..200).to_a, total: 300, limit: 100, offset: 101 }.to_json)
       stub_request(:get, "#{datastore}/feedbacks?limit=100&offset=201")
-      .to_return(status: 200, body: {items: (201..300).to_a, total: 300, limit: 100, offset: 201}.to_json)
+        .to_return(status: 200, body: { items: (201..300).to_a, total: 300, limit: 100, offset: 201 }.to_json)
       all = Record.all
       expect(all).to be_kind_of Record
-      expect(all._proxy).to be_kind_of LHS::Collection
+      expect(all._proxy).to be_kind_of described_class
       expect(all.count).to eq 300
       expect(all.last).to eq 300
     end
 
     it 'also fetches all when there is not meta information for limit' do
       stub_request(:get, "#{datastore}/feedbacks?limit=100")
-      .to_return(status: 200, body: {items: (1..100).to_a, total: 300, offset: 0}.to_json)
+        .to_return(status: 200, body: { items: (1..100).to_a, total: 300, offset: 0 }.to_json)
       stub_request(:get, "#{datastore}/feedbacks?limit=100&offset=101")
-      .to_return(status: 200, body: {items: (101..200).to_a, total: 300, offset: 101}.to_json)
+        .to_return(status: 200, body: { items: (101..200).to_a, total: 300, offset: 101 }.to_json)
       stub_request(:get, "#{datastore}/feedbacks?limit=100&offset=201")
-      .to_return(status: 200, body: {items: (201..300).to_a, total: 300, offset: 201}.to_json)
+        .to_return(status: 200, body: { items: (201..300).to_a, total: 300, offset: 201 }.to_json)
       all = Record.all
       expect(all).to be_kind_of Record
-      expect(all._proxy).to be_kind_of LHS::Collection
+      expect(all._proxy).to be_kind_of described_class
       expect(all.count).to eq 300
       expect(all.last).to eq 300
     end
 
     it 'also works when there is no item in the first response' do
       stub_request(:get, "#{datastore}/feedbacks?limit=100")
-        .to_return(status: 200, body: {items: [], total: 300, offset: 0}.to_json)
+        .to_return(status: 200, body: { items: [], total: 300, offset: 0 }.to_json)
       all = Record.all
       expect(all).to be_kind_of Record
-      expect(all._proxy).to be_kind_of LHS::Collection
+      expect(all._proxy).to be_kind_of described_class
       expect(all.count).to eq 0
     end
   end

data/spec/record/build_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   context 'build' do
-
     let(:datastore) { 'http://local.ch/v2' }
 
     before(:each) do

data/spec/record/create_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   context 'create' do
-
     let(:datastore) { 'http://local.ch/v2' }
 
     before(:each) do
@@ -33,16 +31,16 @@ describe LHS::Record do
 
     it 'uses proper endpoint when creating data' do
       stub_request(:post, "#{datastore}/content-ads/12345/feedbacks")
-      .with(body: object.to_json)
-      .to_return(status: 200, body: object.to_json)
+        .with(body: object.to_json)
+        .to_return(status: 200, body: object.to_json)
       Feedback.create(object.merge(campaign_id: '12345'))
     end
 
     it 'merges backend response object with object' do
       body = object.merge(additional_key: 1)
       stub_request(:post, "#{datastore}/content-ads/12345/feedbacks")
-      .with(body: object.to_json)
-      .to_return(status: 200, body: body.to_json)
+        .with(body: object.to_json)
+        .to_return(status: 200, body: body.to_json)
       data = Feedback.create(object.merge(campaign_id: '12345'))
       expect(data.additional_key).to eq 1
     end
@@ -55,9 +53,9 @@ describe LHS::Record do
             {
               "name" => "ratings",
               "details" => [{ "code" => "REQUIRED_PROPERTY_VALUE" }]
-              },{
+            }, {
               "name" => "recommended",
-              "details" => [{"code" => "REQUIRED_PROPERTY_VALUE"}]
+              "details" => [{ "code" => "REQUIRED_PROPERTY_VALUE" }]
             }
           ]
         }
@@ -72,8 +70,8 @@ describe LHS::Record do
 
       it 'raises an exception when creation failed using create!' do
         stub_request(:post, "#{datastore}/content-ads/12345/feedbacks")
-        .to_return(status: 400, body: creation_error.to_json)
-        expect(->{
+          .to_return(status: 400, body: creation_error.to_json)
+        expect(lambda {
           Feedback.create!(object.merge(campaign_id: '12345'))
         }).to raise_error
       end

data/spec/record/creation_failed_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   context 'creation failed' do
-
     let(:datastore) { 'http://local.ch/v2' }
 
     before(:each) do
@@ -24,9 +22,9 @@ describe LHS::Record do
           {
             "name" => "ratings",
             "details" => [{ "code" => "REQUIRED_PROPERTY_VALUE" }]
-          },{
+          }, {
             "name" => "recommended",
-            "details" => [{"code" => "REQUIRED_PROPERTY_VALUE"}]
+            "details" => [{ "code" => "REQUIRED_PROPERTY_VALUE" }]
           }
         ]
       }
@@ -42,13 +40,13 @@ describe LHS::Record do
       expect(record.errors.include?(:ratings)).to eq true
       expect(record.errors.include?(:recommended)).to eq true
       expect(record.errors[:ratings]).to eq ['REQUIRED_PROPERTY_VALUE']
-      expect(record.errors.messages).to eq({:ratings=>["REQUIRED_PROPERTY_VALUE"], :recommended=>["REQUIRED_PROPERTY_VALUE"]})
+      expect(record.errors.messages).to eq(ratings: ["REQUIRED_PROPERTY_VALUE"], recommended: ["REQUIRED_PROPERTY_VALUE"])
       expect(record.errors.message).to eq error_message
     end
 
     it 'doesnt fail when no fields are provided by the backend' do
       stub_request(:post, "#{datastore}/feedbacks")
-      .to_return(status: 400, body: {}.to_json)
+        .to_return(status: 400, body: {}.to_json)
       Record.create(name: 'Steve')
     end
   end

data/spec/record/definitions_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   context 'definitions' do
-
     let(:datastore) { 'http://local.ch/v2' }
 
     before(:each) do
@@ -21,7 +19,7 @@ describe LHS::Record do
         end
       end
       stub_request(:get, "#{datastore}/local-entries/1")
-        .to_return(status: 200, body: {addresses: [{business: {identities: [{name: 'Löwenzorn'}]}}]}.to_json)
+        .to_return(status: 200, body: { addresses: [{ business: { identities: [{ name: 'Löwenzorn' }] } }] }.to_json)
       entry = LocalEntry.find(1)
       expect(entry.name).to eq 'Löwenzorn'
     end

data/spec/record/endpoint_misconfiguration_spec.rb

@@ -1,12 +1,10 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   context 'misconfiguration of endpoints' do
-
     it 'fails trying to add clashing endpoints' do
       expect(
-        ->{
+        lambda {
           class Record < LHS::Record
             endpoint ':datastore/v2/feedbacks'
             endpoint ':datastore/v2/reviews'
@@ -14,7 +12,7 @@ describe LHS::Record do
         }
       ).to raise_error('Clashing endpoints.')
       expect(
-        ->{
+        lambda {
           class Record < LHS::Record
             endpoint ':datastore/v2/:campaign_id/feedbacks'
             endpoint ':datastore/v2/:campaign_id/reviews'

data/spec/record/endpoint_options_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   context 'set options for an endpoint' do
-
     before(:each) do
       class Record < LHS::Record
         endpoint 'backend/v2/feedbacks/:id', cache_expires_in: 1.day, retry: 2, cache: true