lhs 3.0.0 → 3.0.1

data/spec/record/endpoints_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   context 'endpoints' do
-
     let(:datastore) { 'http://local.ch/v2' }
 
     before(:each) do
@@ -16,7 +14,7 @@ describe LHS::Record do
     end
 
     it 'stores all the endpoints by url' do
-      expect(LHS::Record::Endpoints.all[':datastore/entries/:entry_id/content-ads/:campaign_id/feedbacks']).to be 
+      expect(LHS::Record::Endpoints.all[':datastore/entries/:entry_id/content-ads/:campaign_id/feedbacks']).to be
       expect(LHS::Record::Endpoints.all[':datastore/:campaign_id/feedbacks']).to be
       expect(LHS::Record::Endpoints.all[':datastore/feedbacks']).to be
     end
@@ -44,7 +42,6 @@ describe LHS::Record do
     end
 
     context 'compute url from endpoint' do
-
       before(:each) do
         class Feedback < LHS::Record
           endpoint ':datastore/feedbacks'
@@ -59,7 +56,6 @@ describe LHS::Record do
     end
 
     context 'unsorted endpoints' do
-
       before(:each) do
         class AnotherRecord < LHS::Record
           endpoint ':datastore/feedbacks'
@@ -72,7 +68,6 @@ describe LHS::Record do
         stub_request(:get, "#{datastore}/entries/123/content-ads/123/feedbacks").to_return(status: 200)
         AnotherRecord.where(campaign_id: 123, entry_id: 123)
       end
-
     end
   end
 end

data/spec/record/find_each_spec.rb

@@ -1,13 +1,12 @@
 require 'rails_helper'
 
 describe LHS::Collection do
-
   let(:total) { 443 }
 
   let(:limit) { 100 }
 
   def api_response(ids, offset)
-    records = ids.map{|i| {id: i}}
+    records = ids.map { |i| { id: i } }
     {
       items: records,
       total: total,
@@ -27,7 +26,6 @@ describe LHS::Collection do
   end
 
   context 'find_each' do
-
     it 'processes each record by fetching records in batches' do
       stub_request(:get, "#{datastore}/feedbacks?limit=100&offset=1").to_return(status: 200, body: api_response((1..100).to_a, 1))
       stub_request(:get, "#{datastore}/feedbacks?limit=100&offset=101").to_return(status: 200, body: api_response((101..200).to_a, 101))
@@ -42,6 +40,6 @@ describe LHS::Collection do
         expect(record._proxy).to be_kind_of LHS::Item
       end
       expect(count).to eq total
-    end    
+    end
   end
 end

data/spec/record/find_in_batches_spec.rb

@@ -1,13 +1,12 @@
 require 'rails_helper'
 
 describe LHS::Collection do
-
   let(:total) { 443 }
 
   let(:limit) { 100 }
 
   def api_response(ids, offset)
-    records = ids.map{|i| {id: i}}
+    records = ids.map { |i| { id: i } }
     {
       items: records,
       total: total,
@@ -27,7 +26,6 @@ describe LHS::Collection do
   end
 
   context 'find_batches' do
-
     it 'processes records in batches' do
       stub_request(:get, "#{datastore}/feedbacks?limit=100&offset=1").to_return(status: 200, body: api_response((1..100).to_a, 1))
       stub_request(:get, "#{datastore}/feedbacks?limit=100&offset=101").to_return(status: 200, body: api_response((101..200).to_a, 101))
@@ -38,7 +36,7 @@ describe LHS::Collection do
       Record.find_in_batches do |records|
         count += records.count
         expect(records).to be_kind_of Record
-        expect(records._proxy).to be_kind_of LHS::Collection
+        expect(records._proxy).to be_kind_of described_class
       end
       expect(count).to eq total
     end
@@ -53,7 +51,7 @@ describe LHS::Collection do
       Record.find_in_batches(batch_size: 230) do |records|
         count += records.count
         expect(records).to be_kind_of Record
-        expect(records._proxy).to be_kind_of LHS::Collection
+        expect(records._proxy).to be_kind_of described_class
       end
       expect(count).to eq total
     end
@@ -61,7 +59,7 @@ describe LHS::Collection do
     it 'forwards offset' do
       stub_request(:get, "#{datastore}/feedbacks?limit=100&offset=401").to_return(status: 200, body: api_response((401..total).to_a, 401))
       Record.find_in_batches(start: 401) do |records|
-        expect(records.count).to eq(total-400)
+        expect(records.count).to eq(total - 400)
       end
     end
   end

data/spec/record/find_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   let(:datastore) { 'http://local.ch/v2' }
 
   before(:each) do
@@ -15,24 +14,23 @@ describe LHS::Record do
   end
 
   context 'find' do
-
     it 'finds a single unique record' do
-      stub_request(:get, "#{datastore}/feedbacks/z12f-3asm3ngals").
-      to_return(status: 200, body: load_json(:feedback))
+      stub_request(:get, "#{datastore}/feedbacks/z12f-3asm3ngals")
+        .to_return(status: 200, body: load_json(:feedback))
       record = Record.find('z12f-3asm3ngals')
       expect(record).to be_kind_of Record
       expect(record.source_id).to be_kind_of String
     end
 
     it 'raises if nothing was found' do
-      stub_request(:get, "#{datastore}/feedbacks/not-existing").
-      to_return(status: 404)
+      stub_request(:get, "#{datastore}/feedbacks/not-existing")
+        .to_return(status: 404)
       expect { Record.find('not-existing') }.to raise_error LHC::NotFound
     end
 
     it 'finds unique item by providing parameters' do
       stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
-      .to_return(body: "{}")
+        .to_return(body: "{}")
       data = Record.find(campaign_id: '123', id: '123')
       expect(data._proxy).to be_kind_of LHS::Item
     end
@@ -41,15 +39,15 @@ describe LHS::Record do
       data = JSON.parse(load_json(:feedbacks))
       data['items'] = [data['items'].first]
       stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
-      .to_return(body: data.to_json)
+        .to_return(body: data.to_json)
       data = Record.find(campaign_id: '123', id: '123')
       expect(data._proxy).to be_kind_of LHS::Item
     end
 
     it 'fails when multiple items where found by parameters' do
       stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
-      .to_return(body: load_json(:feedbacks))
-      expect(->{
+        .to_return(body: load_json(:feedbacks))
+      expect(lambda {
         Record.find(campaign_id: '123', id: '123')
       }).to raise_error LHC::NotFound
     end
@@ -58,8 +56,8 @@ describe LHS::Record do
       data = JSON.parse(load_json(:feedbacks))
       data['items'] = []
       stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
-      .to_return(body: data.to_json)
-      expect(->{
+        .to_return(body: data.to_json)
+      expect(lambda {
         Record.find(campaign_id: '123', id: '123')
       }).to raise_error LHC::NotFound
     end
@@ -69,6 +67,5 @@ describe LHS::Record do
         .to_return(status: 404)
       expect { Record.find(campaign_id: '123', id: '123') }.to raise_error LHC::NotFound
     end
-
   end
 end

data/spec/record/first_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   let(:datastore) { 'http://local.ch/v2' }
 
   before(:each) do
@@ -13,7 +12,6 @@ describe LHS::Record do
   end
 
   context 'first' do
-
     it 'finds a single record' do
       stub_request(:get, "#{datastore}/feedbacks?limit=1")
         .to_return(status: 200, body: load_json(:feedback))
@@ -30,7 +28,6 @@ describe LHS::Record do
   end
 
   context 'first!' do
-
     it 'raises if nothing was found with parameters' do
       stub_request(:get, "#{datastore}/feedbacks?limit=1")
         .to_return(status: 404)

data/spec/record/includes_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   let(:datastore) { 'http://local.ch/v2' }
   before(:each) { LHC.config.placeholder('datastore', datastore) }
 
@@ -39,14 +38,14 @@ describe LHS::Record do
         endpoint ':datastore/favorites/:id'
       end
       stub_request(:get, "#{datastore}/local-entries/1")
-        .to_return(body: {company_name: 'local.ch'}.to_json)
+        .to_return(body: { company_name: 'local.ch' }.to_json)
       stub_request(:get, "#{datastore}/users/1")
-        .to_return(body: {name: 'Mario'}.to_json)
+        .to_return(body: { name: 'Mario' }.to_json)
       stub_request(:get, "#{datastore}/favorites/1")
         .to_return(body: {
-          local_entry: {href: "#{datastore}/local-entries/1"},
-          user: {href: "#{datastore}/users/1"}
-          }.to_json)
+          local_entry: { href: "#{datastore}/local-entries/1" },
+          user: { href: "#{datastore}/users/1" }
+        }.to_json)
     end
 
     it 'includes a resource' do
@@ -56,6 +55,7 @@ describe LHS::Record do
 
     it 'includes a list of resources' do
       favorite = Favorite.includes(:local_entry, :user).find(1)
+      expect(favorite.local_entry).to be_kind_of LocalEntry
       expect(favorite.local_entry.company_name).to eq 'local.ch'
       expect(favorite.user.name).to eq 'Mario'
     end
@@ -68,7 +68,6 @@ describe LHS::Record do
   end
 
   context 'multilevel includes' do
-
     before(:each) do
       class Feedback < LHS::Record
         endpoint ':datastore/feedbacks'
@@ -80,7 +79,6 @@ describe LHS::Record do
     end
 
     it 'includes linked resources while fetching multiple resources from one service' do
-
       stub_request(:get, "#{datastore}/feedbacks?has_reviews=true")
         .to_return(status: 200, body: {
           items: [
@@ -96,7 +94,6 @@ describe LHS::Record do
     end
 
     it 'includes linked resources while fetching a single resource from one service' do
-
       stub_request(:get, "#{datastore}/feedbacks/123")
         .to_return(status: 200, body: {
           'href' => "#{datastore}/feedbacks/-Sc4_pYNpqfsudzhtivfkA",
@@ -108,7 +105,6 @@ describe LHS::Record do
     end
 
     it 'includes linked resources with array while fetching a single resource from one service' do
-
       stub_request(:get, "#{datastore}/feedbacks/123")
         .to_return(status: 200, body: {
           'href' => "#{datastore}/feedbacks/-Sc4_pYNpqfsudzhtivfkA",
@@ -121,7 +117,6 @@ describe LHS::Record do
     end
 
     it 'includes list of linked resources while fetching a single resource from one service' do
-
       stub_request(:get, "#{datastore}/feedbacks/123")
         .to_return(status: 200, body: {
           'href' => "#{datastore}/feedbacks/-Sc4_pYNpqfsudzhtivfkA",
@@ -136,18 +131,17 @@ describe LHS::Record do
     end
 
     context 'include objects from known services' do
-
       let(:stub_feedback_request) do
         stub_request(:get, "#{datastore}/feedbacks")
           .to_return(status: 200, body: {
-              items: [
-                {
-                  'href' => "#{datastore}/feedbacks/-Sc4_pYNpqfsudzhtivfkA",
-                  'entry' => {
-                    'href' => "#{datastore}/local-entries/lakj35asdflkj1203va"
-                  }
+            items: [
+              {
+                'href' => "#{datastore}/feedbacks/-Sc4_pYNpqfsudzhtivfkA",
+                'entry' => {
+                  'href' => "#{datastore}/local-entries/lakj35asdflkj1203va"
                 }
-              ]
+              }
+            ]
           }.to_json)
       end
 
@@ -160,6 +154,7 @@ describe LHS::Record do
       end
 
       it 'uses interceptors for included links from known services' do
+        # rubocop:disable RSpec/InstanceVariable
         stub_feedback_request
         stub_entry_request
 
@@ -168,12 +163,12 @@ describe LHS::Record do
 
         expect(Feedback.includes(:entry).where.first.entry.name).to eq 'Casa Ferlin'
         expect(@called).to eq 2
+        # rubocop:enable RSpec/InstanceVariable
       end
     end
   end
 
   context 'links pointing to nowhere' do
-
     it 'sets nil for links that cannot be included' do
       class Feedback < LHS::Record
         endpoint ':datastore/feedbacks'

data/spec/record/mapping_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   context 'mapping' do
-
     let(:datastore) { 'http://local.ch/v2' }
 
     before(:each) do
@@ -21,7 +19,7 @@ describe LHS::Record do
         end
       end
       stub_request(:get, "#{datastore}/local-entries/1")
-        .to_return(status: 200, body: {addresses: [{business: {identities: [{name: 'Löwenzorn'}]}}]}.to_json)
+        .to_return(status: 200, body: { addresses: [{ business: { identities: [{ name: 'Löwenzorn' }] } }] }.to_json)
       entry = LocalEntry.find(1)
       expect(entry.name).to eq 'Löwenzorn'
     end
@@ -33,7 +31,7 @@ describe LHS::Record do
         end
       end
       stub_request(:get, "#{datastore}/local-entries/1?limit=1")
-        .to_return(status: 200, body: {items: [{addresses: [{business: {identities: [{name: 'Löwenzorn'}]}}]}]}.to_json)
+        .to_return(status: 200, body: { items: [{ addresses: [{ business: { identities: [{ name: 'Löwenzorn' }] } }] }] }.to_json)
       entry = LocalEntry.find_by(id: 1)
       expect(entry.name).to eq 'Löwenzorn'
     end
@@ -45,7 +43,7 @@ describe LHS::Record do
         end
       end
       stub_request(:get, "#{datastore}/local-entries/1")
-        .to_return(status: 200, body: {addresses: [{business: {identities: [{name: 'Löwenzorn'}]}}]}.to_json)
+        .to_return(status: 200, body: { addresses: [{ business: { identities: [{ name: 'Löwenzorn' }] } }] }.to_json)
       entry = LocalEntry.find(1)
       expect(entry.business).to be_kind_of LHS::Data
     end
@@ -60,14 +58,14 @@ describe LHS::Record do
 
       preceding_agb_url = "#{datastore}/agbs/547f0b461c266c4830ea6cea"
       # initial request
-      stub_request(:get, "#{datastore}/agbs/active?agb_type=CC_TOU&limit=1").
-      to_return(
-        status: 200,
-        body: {
-          'href' => "#{datastore}/agbs/547f02c61c266c4830ea6ce7",
-          'preceding_agb' => { 'href' => preceding_agb_url },
-          'binary_url_pdf_de' => 'de'
-        }.to_json)
+      stub_request(:get, "#{datastore}/agbs/active?agb_type=CC_TOU&limit=1")
+        .to_return(
+          status: 200,
+          body: {
+            'href' => "#{datastore}/agbs/547f02c61c266c4830ea6ce7",
+            'preceding_agb' => { 'href' => preceding_agb_url },
+            'binary_url_pdf_de' => 'de'
+          }.to_json)
 
       # includes request
       stub_request(:get, preceding_agb_url).to_return(
@@ -89,9 +87,9 @@ describe LHS::Record do
         endpoint ':datastore/favorites/:id'
       end
       stub_request(:get, "#{datastore}/local-entries/1")
-        .to_return(body: {company_name: 'local.ch'}.to_json)
+        .to_return(body: { company_name: 'local.ch' }.to_json)
       stub_request(:get, "#{datastore}/favorites/1")
-        .to_return(body: {local_entry: {href: "#{datastore}/local-entries/1"}}.to_json)
+        .to_return(body: { local_entry: { href: "#{datastore}/local-entries/1" } }.to_json)
 
       favorite = Favorite.includes(:local_entry).find(1)
       expect(favorite.local_entry).to be_kind_of LocalEntry

data/spec/record/model_name_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   context 'model_name' do
-
     before(:each) do
       class LocalEntry < LHS::Record
         endpoint ':datastore/local-entries'

data/spec/record/new_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   context 'new' do
-
     let(:datastore) { 'http://local.ch/v2' }
 
     before(:each) do
@@ -22,5 +20,9 @@ describe LHS::Record do
         .with(body: "{\"recommended\":true}")
       feedback.save
     end
+
+    it 'builds new items also with keys containing dashes' do
+      Feedback.new('some-key' => [])
+    end
   end
 end

data/spec/record/request_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Record do
-
   context 'url pattern' do
-
     let(:datastore) { 'http://local.ch/v2' }
 
     before(:each) do
@@ -16,7 +14,7 @@ describe LHS::Record do
 
     it 'is using params as query params explicitly when provided in params namespace' do
       stub_request(:get, "#{datastore}/content-ads/123/feedbacks?campaign_id=456").to_return(status: 200)
-      records = Record.where(campaign_id: 123, params: { campaign_id: '456' })
+      Record.where(campaign_id: 123, params: { campaign_id: '456' })
     end
   end
 end