lhs 3.0.0 → 3.0.1

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "3.0.0"
+  VERSION = "3.0.1"
 end

data/spec/collection/delegate_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Collection do
-
   let(:data) {
     ['ROLE_USER', 'ROLE_LOCALCH_ACCOUNT']
   }
@@ -11,7 +10,6 @@ describe LHS::Collection do
   }
 
   context 'delegates methods to raw' do
-
     %w(present? blank? empty?).each do |method|
       it "delegates #{method} to raw" do
         expect(collection.send(method.to_sym)).not_to be_nil

data/spec/collection/enumerable_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Collection do
-
   let(:data) {
     [1, 2, 3]
   }
@@ -11,16 +10,15 @@ describe LHS::Collection do
   }
 
   context 'enumerable' do
-
     it 'works with map' do
       expect(
-        collection.map{|x| x + 1}
+        collection.map { |x| x + 1 }
       ).to eq [2, 3, 4]
     end
 
     it 'works with select' do
       expect(
-        collection.select{|x| x == 2}
+        collection.select { |x| x == 2 }
       ).to eq [2]
     end
   end

data/spec/collection/meta_data_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Collection do
-
   let(:total) { 0 }
 
   let(:limit) { 50 }

data/spec/collection/respond_to_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Collection do
-
   let(:data) {
     ['ROLE_USER', 'ROLE_LOCALCH_ACCOUNT']
   }

data/spec/collection/without_object_items_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Collection do
-
   let(:datastore) { 'http://local.ch/v2' }
 
   before(:each) do

data/spec/data/collection_spec.rb

@@ -1,21 +1,19 @@
 require 'rails_helper'
 
 describe LHS::Data do
-
   let(:json) do
     load_json(:feedbacks)
   end
 
   let(:data) do
-    LHS::Data.new(json)
+    described_class.new(json)
   end
 
   context 'collections' do
-
     it 'forwards calls to the collection' do
       expect(data.count).to be_kind_of Fixnum
-      expect(data[0]).to be_kind_of LHS::Data
-      expect(data.sample).to be_kind_of LHS::Data
+      expect(data[0]).to be_kind_of described_class
+      expect(data.sample).to be_kind_of described_class
     end
 
     it 'provides a total method to get the number of total records' do
@@ -24,9 +22,8 @@ describe LHS::Data do
   end
 
   context 'collections from arrays' do
-
     let(:data) do
-      LHS::Data.new([1,2,3,4])
+      described_class.new([1, 2, 3, 4])
     end
 
     it 'uses collection as proxy for arrays' do

data/spec/data/item_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Data do
-
   before(:each) do
     class Record < LHS::Record
       endpoint ':datastore/v2/:campaign_id/feedbacks'
@@ -14,7 +13,7 @@ describe LHS::Data do
   end
 
   let(:data) do
-    LHS::Data.new(json, nil, Record)
+    described_class.new(json, nil, Record)
   end
 
   let(:item) do
@@ -22,7 +21,6 @@ describe LHS::Data do
   end
 
   context 'item' do
-
     it 'makes data accessible' do
       expect(item.href).to be_kind_of String
       expect(item.recommended).to be_kind_of TrueClass
@@ -33,8 +31,8 @@ describe LHS::Data do
       expect(item.something).to eq nil
     end
 
-    it 'returns datetime if string can be parsed as date_time' do
-      expect(item.created_date).to be_kind_of DateTime
+    it 'returns TimeWithZone if string can be parsed as date_time' do
+      expect(item.created_date).to be_kind_of ActiveSupport::TimeWithZone
     end
 
     it 'returns date if string can be parsed as date' do

data/spec/data/merge_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Data do
-
   before(:each) do
     class Record < LHS::Record
       endpoint ':datastore/v2/:campaign_id/feedbacks'
@@ -10,20 +9,19 @@ describe LHS::Data do
   end
 
   let(:data) do
-    LHS::Data.new({
-      href: 'http://www.local.ch/v2/stuff'
-    }, nil, Record)
+    described_class.new({
+                          href: 'http://www.local.ch/v2/stuff'
+                        }, nil, Record)
   end
 
   let(:loaded_data) do
-    LHS::Data.new({
-      href: 'http://www.local.ch/v2/stuff',
-      id: '123123123'
-    }, nil, Record)
+    described_class.new({
+                          href: 'http://www.local.ch/v2/stuff',
+                          id: '123123123'
+                        }, nil, Record)
   end
 
   context 'merging' do
-
     it 'merges data' do
       data.merge_raw!(loaded_data)
       expect(data.id).to eq loaded_data.id

data/spec/data/raw_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Data do
-
   before(:each) do
     class Record < LHS::Record
       endpoint ':datastore/v2/entries/:entry_id/content-ads/:campaign_id/feedbacks'
@@ -11,7 +10,7 @@ describe LHS::Data do
   end
 
   let(:data_from_raw) do
-    LHS::Data.new(
+    described_class.new(
       href: 'http://www.local.ch/v2/stuff',
       id: '123123123'
     )
@@ -19,12 +18,11 @@ describe LHS::Data do
 
   let(:data_from_item) do
     raw = { href: 'http://www.local.ch/v2/stuff' }
-    item = LHS::Item.new(LHS::Data.new(raw))
-    LHS::Data.new(item)
+    item = LHS::Item.new(described_class.new(raw))
+    described_class.new(item)
   end
 
   context 'raw' do
-
     it 'you can access raw data that is underlying' do
       expect(data_from_raw._raw).to be_kind_of Hash
     end

data/spec/data/respond_to_spec.rb

@@ -1,24 +1,22 @@
 require 'rails_helper'
 
 describe LHS::Data do
-
   before(:each) do
     class Record < LHS::Record
-      map :test_mapping?, ->(item){ true }
+      map :test_mapping?, ->(_item) { true }
     end
   end
 
   context '#respond_to?' do
-
     it 'it is true for mappings that are defined' do
-      data = described_class.new({'campaign' => {'id' => 123}}, nil, Record)
+      data = described_class.new({ 'campaign' => { 'id' => 123 } }, nil, Record)
 
       expect(data.respond_to?(:test_mapping?)).to be(true)
     end
 
     # proxy for this example is LHC::Collection which implements total
     it 'it is true for calls forwarded to proxy' do
-      data = described_class.new({'items' => [{'campaign' => {'id' => 123}}]}, nil, Record)
+      data = described_class.new({ 'items' => [{ 'campaign' => { 'id' => 123 } }] }, nil, Record)
 
       expect(data.respond_to?(:total)).to be(true)
     end

data/spec/data/root_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Data do
-
   before(:each) do
     class Record < LHS::Record
       endpoint ':datastore/v2/entries/:entry_id/content-ads/:campaign_id/feedbacks'
@@ -11,14 +10,13 @@ describe LHS::Data do
   end
 
   context 'root' do
-
     it 'is navigateable from nested data' do
-      root = LHS::Data.new({'items' => [{'campaign' => {'id' => 123}}]}, nil, Record)
+      root = described_class.new({ 'items' => [{ 'campaign' => { 'id' => 123 } }] }, nil, Record)
       child = root.first
       leafe = child.campaign
       expect(leafe._root).to eq root
-      expect(leafe._parent).to be_kind_of LHS::Data
-      expect(leafe._parent._parent).to be_kind_of LHS::Data
+      expect(leafe._parent).to be_kind_of described_class
+      expect(leafe._parent._parent).to be_kind_of described_class
       expect(leafe._parent._parent).to eq root
     end
   end

data/spec/data/select_spec.rb

@@ -1,20 +1,18 @@
 require 'rails_helper'
 
 describe LHS::Data do
-
   let(:raw) do
     { labels: { de: ['cat', 'dog'] } }
   end
 
   let(:data) do
-    LHS::Data.new(raw)
+    described_class.new(raw)
   end
 
   context 'select' do
-
     it 'works with select' do
       expect(
-        data.labels.de.select{|x| x}.join()
+        data.labels.de.select { |x| x }.join
       ).to eq 'catdog'
     end
   end

data/spec/data/to_json_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Data do
-
   before(:each) do
     class Record < LHS::Record
       endpoint ':datastore/v2/:campaign_id/feedbacks'
@@ -14,7 +13,7 @@ describe LHS::Data do
   end
 
   let(:collection) do
-    LHS::Data.new(json, nil, Record)
+    described_class.new(json, nil, Record)
   end
 
   let(:item) do
@@ -23,17 +22,16 @@ describe LHS::Data do
 
   it 'converts item to json' do
     expect(item.to_json)
-    .to eq JSON.parse(load_json(:feedbacks))['items'].first.to_json
+      .to eq JSON.parse(load_json(:feedbacks))['items'].first.to_json
   end
 
   it 'converts collection to json' do
     expect(collection.to_json)
-    .to eq JSON.parse(load_json(:feedbacks)).to_json
+      .to eq JSON.parse(load_json(:feedbacks)).to_json
   end
 
   it 'converts link to json' do
     expect(item.campaign.to_json)
-    .to eq item.campaign._raw.to_json
-  end  
-
+      .to eq item.campaign._raw.to_json
+  end
 end

data/spec/dummy/bin/rails

@@ -1,4 +1,4 @@
 #!/usr/bin/env ruby
-APP_PATH = File.expand_path('../../config/application',  __FILE__)
+APP_PATH = File.expand_path('../../config/application', __FILE__)
 require_relative '../config/boot'
 require 'rails/commands'

data/spec/dummy/config.ru

@@ -1,4 +1,4 @@
 # This file is used by Rack-based servers to start the application.
 
-require ::File.expand_path('../config/environment',  __FILE__)
+require ::File.expand_path('../config/environment', __FILE__)
 run Rails.application

data/spec/dummy/config/initializers/cookies_serializer.rb

@@ -1,3 +1,3 @@
 # Be sure to restart your server when you modify this file.
 
-Rails.application.config.action_dispatch.cookies_serializer = :json
+Rails.application.config.action_dispatch.cookies_serializer = :json

data/spec/endpoint/for_url_spec.rb

@@ -1,9 +1,7 @@
 require 'rails_helper'
 
 describe LHS::Endpoint do
-
   context 'for url' do
-
     before(:each) do
       class Record < LHS::Record
         endpoint ':datastore/entries/:entry_id/content-ads/:campaign_id/feedbacks'
@@ -14,13 +12,13 @@ describe LHS::Endpoint do
 
     it 'provides the endpoint for a given url' do
       expect(
-        LHS::Endpoint.for_url('http://local.ch/v2/entries/123/content-ads/456/feedbacks').url
+        described_class.for_url('http://local.ch/v2/entries/123/content-ads/456/feedbacks').url
       ).to eq ':datastore/entries/:entry_id/content-ads/:campaign_id/feedbacks'
       expect(
-        LHS::Endpoint.for_url('http://local.ch/123/feedbacks').url
+        described_class.for_url('http://local.ch/123/feedbacks').url
       ).to eq ':datastore/:campaign_id/feedbacks'
       expect(
-        LHS::Endpoint.for_url('http://local.ch/feedbacks').url
+        described_class.for_url('http://local.ch/feedbacks').url
       ).to eq ':datastore/feedbacks'
     end
   end

data/spec/item/delegate_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Item do
-
   before(:each) do
     class Record < LHS::Record
       endpoint ':datastore/v2/:campaign_id/feedbacks'
@@ -22,7 +21,6 @@ describe LHS::Item do
   end
 
   context 'delegates methods to raw' do
-
     %w(present? blank? empty?).each do |method|
       it "delegates #{method} to raw" do
         expect(item.send(method.to_sym)).not_to be_nil

data/spec/item/destroy_spec.rb

@@ -1,7 +1,6 @@
 require 'rails_helper'
 
 describe LHS::Item do
-
   before(:each) do
     LHC.config.placeholder('datastore', datastore)
     class Record < LHS::Record
@@ -27,10 +26,9 @@ describe LHS::Item do
   end
 
   context 'destroy' do
-
     it 'destroys the item on the backend' do
       stub_request(:delete, "#{datastore}/v2/feedbacks/0sdaetZ-OWVg4oBiBJ-7IQ")
-      .to_return(status: 200)
+        .to_return(status: 200)
       expect(item.destroy._raw).to eq item._raw
     end
 
@@ -51,11 +49,11 @@ describe LHS::Item do
       it 'destroys an item even though it includes additonal services and an empty response body' do
         stub_request(:delete, "#{datastore}/v2/feedbacks/1")
           .to_return(status: 204, body: '')
-        data = { href: "#{datastore}/v2/feedbacks/1", restaurant: {href: "#{datastore}/v2/restaurants/1"} }
+        data = { href: "#{datastore}/v2/feedbacks/1", restaurant: { href: "#{datastore}/v2/restaurants/1" } }
         stub_request(:get, "#{datastore}/v2/feedbacks?id=1")
           .to_return(status: 200, body: data.to_json)
         stub_request(:get, "#{datastore}/v2/restaurants/1")
-          .to_return(status: 200, body: {name: 'Casa Ferlin'}.to_json)
+          .to_return(status: 200, body: { name: 'Casa Ferlin' }.to_json)
         item = Record.includes(:restaurant).find(1)
         item.destroy
       end

data/spec/item/errors_spec.rb

@@ -1,44 +1,43 @@
 require 'rails_helper'
 
 describe LHS::Item do
-
   let(:datastore) { 'http://local.ch/v2' }
 
   let(:error_format_fields) do
-      {
-        "status" => 400,
-        "message" => "ratings must be set when review or name or review_title is set | The property value is required; it cannot be null, empty, or blank.",
-        "fields" => [
-          {
-            "name" => "ratings",
-            "details" => [{ "code" => "REQUIRED_PROPERTY_VALUE" }, { "code" => "UNSUPPORTED_PROPERTY_VALUE" }]
-          },{
-            "name" => "recommended",
-            "details" => [{"code" => "REQUIRED_PROPERTY_VALUE"}]
-          }
-        ]
-      }
-    end
+    {
+      "status" => 400,
+      "message" => "ratings must be set when review or name or review_title is set | The property value is required; it cannot be null, empty, or blank.",
+      "fields" => [
+        {
+          "name" => "ratings",
+          "details" => [{ "code" => "REQUIRED_PROPERTY_VALUE" }, { "code" => "UNSUPPORTED_PROPERTY_VALUE" }]
+        }, {
+          "name" => "recommended",
+          "details" => [{ "code" => "REQUIRED_PROPERTY_VALUE" }]
+        }
+      ]
+    }
+  end
 
   let(:error_format_field_errors) do
     {
       "status" => 400,
       "message" => "Some data in the request body failed validation. Inspect the field errors for details.",
-      "field_errors" => [ {
+      "field_errors" => [{
         "code" => "UNSUPPORTED_PROPERTY_VALUE",
-        "path" => [ "gender" ],
+        "path" => ["gender"],
         "message" => "The property value is unsupported. Supported values are: FEMALE, MALE"
       }, {
         "code" => "INCOMPLETE_PROPERTY_VALUE",
-        "path" => [ "gender" ],
+        "path" => ["gender"],
         "message" => "The property value is incomplete. It misses some data"
       }, {
         "code" => "INCOMPLETE_PROPERTY_VALUE",
-        "path" => [ "contract", "entry_id" ],
+        "path" => ["contract", "entry_id"],
         "message" => "The property value is incomplete. It misses some data"
-      }  ]
+      }]
     }
-  end 
+  end
 
   before(:each) do
     LHC.config.placeholder(:datastore, datastore)
@@ -49,7 +48,6 @@ describe LHS::Item do
   end
 
   context 'save failed' do
-
     it 'parses fields correctly when creation failed' do
       stub_request(:post, "#{datastore}/feedbacks")
         .to_return(status: 400, body: error_format_fields.to_json)
@@ -81,7 +79,6 @@ describe LHS::Item do
   end
 
   context 'raw error data' do
-
     it 'provides access to raw error data' do
       stub_request(:post, "#{datastore}/feedbacks")
         .to_return(status: 400, body: error_format_field_errors.to_json)